GNU bug report logs - #13250
24.3.50; Add a way to show pre-highlighted candidates in completions buffer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13250: closed (24.3.50; Add a way to show pre-highlighted
 candidates in completions buffer)
Date: Tue, 05 Mar 2013 08:05:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 05 Mar 2013 12:04:20 +0400
with message-id <5135A704.1010302 <at> yandex.ru>
and subject line Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer
has caused the debbugs.gnu.org bug report #13250,
regarding 24.3.50; Add a way to show pre-highlighted candidates in completions buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13250: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13250
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
	Add a way to show pre-highlighted candidates in completions buffer
Date: Fri, 21 Dec 2012 23:42:19 +0400

[Message part 3 (text/plain, inline)]

When I return the list of candidates from the "completion table"
function, I'd like to be able the specify the base (not user-defined)
highlighting, so that the actual candidate text looks more visible (as
opposed to the annotations) and easy to scan. In my case, the candidates
are method names and the annotations are argument lists, so using
font-lock-function-name-face is natural.

But if I propertize the list with 'font-lock-face properties, both the
"common" part and the "first difference" are still colored black,
because the completion code uses the hardcoded faces for them, one of
which inherits from `default', another from `bold'. Screenshot attached.

Can we change this so that those faces override the face attributes only
if they've been explicitly customized (as opposed to inherited from
`default')?

Is it possible to do that in a backwards-compatible way? With overlays,
maybe?

[completion-faces.png (image/png, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13250-done <at> debbugs.gnu.org
Subject: Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates
	in completions buffer
Date: Tue, 05 Mar 2013 12:04:20 +0400

On 04.03.2013 18:36, Stefan Monnier wrote:
>> Do you see any problems in the patch I sent for this bug in the
>> previous message?
>
> I'm not sure what impact it might have on speed, but I think the
> principle is fine, so go ahead,

Thanks, installed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.