From unknown Thu Jun 19 14:03:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13250 <13250@debbugs.gnu.org> To: bug#13250 <13250@debbugs.gnu.org> Subject: Status: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer Reply-To: bug#13250 <13250@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:03:18 +0000 retitle 13250 24.3.50; Add a way to show pre-highlighted candidates in comp= letions buffer reassign 13250 emacs submitter 13250 Dmitry Gutov severity 13250 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 21 14:43:11 2012 Received: (at submit) by debbugs.gnu.org; 21 Dec 2012 19:43:11 +0000 Received: from localhost ([127.0.0.1]:54605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tm8Uw-000548-HI for submit@debbugs.gnu.org; Fri, 21 Dec 2012 14:43:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33374) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tm8Ut-000541-Tf for submit@debbugs.gnu.org; Fri, 21 Dec 2012 14:43:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tm8UX-0000ME-Ck for submit@debbugs.gnu.org; Fri, 21 Dec 2012 14:42:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm8UX-0000Ly-9D for submit@debbugs.gnu.org; Fri, 21 Dec 2012 14:42:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm8UO-0004zx-95 for bug-gnu-emacs@gnu.org; Fri, 21 Dec 2012 14:42:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tm8UI-0000Ir-DH for bug-gnu-emacs@gnu.org; Fri, 21 Dec 2012 14:42:36 -0500 Received: from mail-la0-f51.google.com ([209.85.215.51]:54955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm8UI-0000Ih-0B for bug-gnu-emacs@gnu.org; Fri, 21 Dec 2012 14:42:30 -0500 Received: by mail-la0-f51.google.com with SMTP id e4so5743829lag.10 for ; Fri, 21 Dec 2012 11:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:subject:date:message-id:mime-version :content-type; bh=FFtICzqijirluatw7YiCPk/bkPpiK7mMdxRopeeF/gI=; b=f+g4Ik38XrFXLlo0v0ENsb7DcICZK2uDwwLzCQsYL7OEq1e8gzfRt1Ej/U/JpBK+5c 6PofuATzWSZxJ07bmrmRLKrORBF81jBC8sJ0BZTks6Svpn+7hc9Xbfym7yGxyuqcHrkw b1zxrn5RaCNhUX4OZkPkWOC2SFhCrS7BaduW88h5FLAUiU6u3rFEep1s61e/b+6dF/lo VXIu/I2d3jYWB3ZmclnaEtRl9G9y1zBV5t1VFp68i+LJYf9aI240UlYipuFYG9G4N0EC XqU6MToYCn5N7xLORgXi3VecrNRhqpdBzT+sEZbqBOcOkq/fpEUBu42Cy9qIuJbsqhGn z+kA== X-Received: by 10.112.101.232 with SMTP id fj8mr5389483lbb.83.1356118948479; Fri, 21 Dec 2012 11:42:28 -0800 (PST) Received: from vbx ([178.252.98.87]) by mx.google.com with ESMTPS id ne2sm4948694lab.10.2012.12.21.11.42.25 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 21 Dec 2012 11:42:26 -0800 (PST) From: Dmitry Gutov To: bug-gnu-emacs@gnu.org Subject: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer Date: Fri, 21 Dec 2012 23:42:19 +0400 Message-ID: <877gobgpk4.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) --=-=-= Content-Type: text/plain When I return the list of candidates from the "completion table" function, I'd like to be able the specify the base (not user-defined) highlighting, so that the actual candidate text looks more visible (as opposed to the annotations) and easy to scan. In my case, the candidates are method names and the annotations are argument lists, so using font-lock-function-name-face is natural. But if I propertize the list with 'font-lock-face properties, both the "common" part and the "first difference" are still colored black, because the completion code uses the hardcoded faces for them, one of which inherits from `default', another from `bold'. Screenshot attached. Can we change this so that those faces override the face attributes only if they've been explicitly customized (as opposed to inherited from `default')? Is it possible to do that in a backwards-compatible way? With overlays, maybe? --=-=-= Content-Type: image/png Content-Disposition: attachment; filename=completion-faces.png Content-Transfer-Encoding: base64 Content-Description: completion buffer iVBORw0KGgoAAAANSUhEUgAAAN4AAAClCAIAAAC84NTiAAAACXBIWXMAAAsTAAALEwEAmpwYAAAA B3RJTUUH3AwVExc5T/kt7wAAHQNJREFUeNrtnXdcFNcWx89sofcuKigogijP3rBALCCWaGy82FCj QuwixsQaW2xPRRM7xATsDWONJU9jQ8QnqLECgoqAtF1gC7s7c98fSN8ZdldR1PP98Pm4zu7cuXPm t/fMnfnNWerZowRAkLqHAAjBKCB1EEpaVKBi1LxhZmamdgWCUkbe06jJTnUVUhSFIUPeDzwMAYLS RJDalGbB2UEWFEVRFMXzPS5W9wl5wsJWBoatFyXKORsSH/e1ZGkB+XSpWT+aSZMpSIyc+oWrGZ+i 9Ozbj9kMAGb+MSJCiCjGx5ytSeP6TT3cm9Y3ruURWZHzXKSqg8EnRQ/2zPZzMxdQFM+8qd93Mc8V AAAq0fMcBUqzZv1oIs3iRxv79VorHXUwWc6oXl8Idc3WaON6TYMP3blzcHITvdo7+rKnB6d5d5gT J6t7sVc82TkjPHtAxIMihpHc2+R1dvyIHSlKAFncnA7e0w4myfAKh4ZIiwrUAgB/DK7XevWjYlJO ybSdlKjewidGVOE9knOkt3GFyXyFd2nxnV0hPi6mFADP6l8j1lzOVlVqgSmIX9XD3uPbU1kqUiN0 QeLOMc3tWk2OfljEEEJEMX2a9P92UFMDEDYdH7FrUktjMPCa87eIIYTOi90U5O1qZcA3sHL1Hrc5 No+u1vPy/ypfnZof4G4lBAChjWfAzIhbeXTJZxjJ4/1zAlrWM+YBZdL4i5n7nkgZohlMVrS3Td9T YkIIU/QwenIru+ZjdiYW0BqtzNL/Ph6Tjhz5cZCnlRBA2KDX4ku5nM3Rorv75g/r4GQqAOBbtw6K eCitabvqjhdHf9TGPz+mj+tXa1eOae+gB6Dv1GvB+YpHV41+qsaZa9Q8dtth1BAXjcc+66/OFZVv uHy4VqZsH9x7ZeHXe5/I6OKsSwu8JNnSCldSSUH8qn59I9y2XwwPsONzb4LOvbF+SCu/3XY/xcVu G+luXHIpS5F29dWQPzMSvofI0BPeMS8T5yl+C79VpEz6ZdCAbQZTjycXKgufHg3m/9x/0JYkJVvb RVfDJux33Xi3kCG0OGF3kLNUQgMAgOrlnpG9fnw9YGvcayUjTz4wLH3egB9uSjT85qfEZTl0cNIH AMrYfeS22LiVdrv9Wg1dfyOXrmFV1v4rn+6YuVsw+XianC6ID1NtCt78kOtMQZkVn6j/Zfi1zGKm OD3mq0ffBe1K4ToRYjterP1hiT8o0k4fygnYkSBWFSWusI0cOe1sHlfGqBpnrlGzj3X3Q7mVZM05 ahL13wlZ/GzXxlOuF6n9zNG0uBXeZnbD971QaDCKiE76GVoM3vNcoXZb+ccqvciMn+XqOjNOUvZB yc0ZLq6z4jNZRs3ixxt8G3Wb8/u1tKJKg5AsYZ5HyyX35WULVGlbOjYaf6WIENEJ/wp5Aoz9T1QO CCO+Ps/LOfBoZuVkoHi+Z7CFod9JMefOyrj6fyy/dBOv93hb9Tkhqjl4SvHze9fOHv55nJNZySjO ul31x0tWUzyrxD+tUpwVT1Z71R91qZB91KwWZ65R09GoIDVP+dbnXpn/iBp0dzNSdzL7cH3/Pusy jCSJt59rcgpm6r10Va+7oSPmxaSqmf2X3Q4oeaHIfCBy7OxSvl1D1y71xQ8z2QYYPbeZZ64sc3u4 Y3LPNq27DQ3dfiVTCQCgeJmQfG9JCwOqFIHztzdzXhfSAOb9z1Q8gkVn+ptXnA0lhg8b8ad/1NYv 7SskA/mzY98Nn32316ql3iY1xI2j/+X7qmcsZBScAzApTIwI9vVq22/q+sM3UqT6QlqmJNofrxrj WSX+lRFau1jIXxdydLRanLmkObht5p4jySyHkuJRmt1+F9q5m6dfS1I3YZFnJXtuvp14faNzZODs P3OYGq90WXSYfvDOuW/yFnbqPHnPIwnn5oX2HhYZsc/KtytPufHK3N1eyNfjKSWK0nUZurwV/QY9 Jq7cfSb2TuzB2c6nA3t8f1sOoOfo1aTtuqeVR/XCE33NOM88si8u6BOwp9Wv51Z2syiNMZE8ip7U qdOi/EkXEg5O72DBfQWDtf9aDg2y+IVDVuktunznyvHI9UvCJvk3FOp0vN6uP/K0W5kWHg567Pqp Fmeu8PitnGO0dnDIr7ezlYQW3YuaEgAAdOkOuJmmnLiaoaSLXj0Xc31rDf8VHGL7+8iQiPjXCsJI Uv/aHLb8r1wGAMC8x89bRjU2aTxu97ZOJ8YGH3pF17yPlGnL8ZFxV3/QD/fpMvcWxwzd0Ctkqn3U 2Nn7/hGpiCr/bvT0MVEOU0O8LBt1tv1nx957hQwjTT23YvTMq1IKABRPto8bvXBv3EsJA5TQ3KG+ tUBWUMwAGLScMrf+llFzom+9kjEAjDQ9/o9D117THBeP7m0b0WH0ra+OX1zV06ZswJTdmtvZZ5PB /GtxkeNamNR8w5et/4ZaSpMuzCpUKiRFSsIUJZ9bGzzvuoRz42zHS4f+SBO2bv4zVaqSPDu1eFKE UdDEloblX4Cq+qkWZ65zTUJo8f92BndvZAwAQvt2o8PLzzWJ4ln02ObGAGDkGrjnhZL9XJMQosq5 tnFspwaGACCw8Rqy7Gy6ospn6JyzE50se21PVhBNKX5x+WySvEI71V/QudfDg7q4WOnz9a1cvIPC r+fShBA6++J8X0cBgMDSY/BPZ05Pb+EXIyKkOP3S5m/9PW31AIBn6Nh+1IbrFWboB+cNbGmnDwB8 U+fOXy8/xX5uXHB+iHHlI1RyDipPOnv5RTHRBrX9Z73CwBqoZ/tDOtoLAQzs24xYfuRIiKdfDPe5 qdrjVWN/qrxIi/ExbT4tbJCHlZBv5tpzzrG0SjuvTj+V48zlPFJr70DnEaIR4uO+jTbOTP3vl+Y6 NoD30JE6CkoTqaOglRipo7BaiVGCCCZ0BEFpIihNBPlopVmjy11Dt7zO7auHEcetG9zMjKIogVnT EVHPVTUsR2pLD+zSFJ/sa0JVwqTvSZ2fl5DdmuHpr51Q3pdbvhLF//wnaJ1q7s1Cmigy/l43sL6A e3lto0Pc3l4iPMp9eYnPrvjufBeK+jDPybAf9hJbTcX7YJWdNdpBF2QWajnQvAe3vJqh+tn1TPdx X3mY8IBnXK+hOb+G5bWNDnF7awTW9YpPHktSABQ/PnJOYWDwYZ7w5unwrfJrPvno0aWDW1jrUZRe w95LLudxeYYkVybUpyjTXgdfXCx9YMm036mSryEpuv/rxI71DClKr0HPRZdKTB+5R/tUGK7LH25S ZZxe0M/DWo+iKD3bFv1mRcbn1+BVYgoSdkzq4qhPUYaN+iy6kE2rSRxl/y28+G9birL48mL+5SFW FEVRArfv/idnXw4ARPrkQFg/L0cTPsUzdek5a//TEmuf+Livpe+x9Id7ZnzhYiakKBO/A68ZbePM Ejdl8sb2Vt7b08r0WnTlm4auofEy8XG/JkPW/TS2Qz19ijJw7r3wQpkFha2fbGHjuQ50uHgsSVH8 +Mg1l6GeBpyXEYnov1NcrHpuT1ECAJP75wSneiOOZNI1HJeIb31dzXgUxbduFbj275w3H6+kB1Z7 B6t7QBTjK4CGA1acSSqk6YLEcB9L9yX3a7QtqGvHhw8Ne31/9FGBii5IDO9h2WzxPTn7WoX/Heng Ou3sSzlDaOnLWwc3bL6UTXNvkS/wCt4dly5VFj2K+rej3fCTuUxN9gg2t4Sa5coXUYMaeozZevWF hGaKs+K2DnNuNvNGUcmHjRv27dktaOu1dBnDyPNypDTRjerbpbNjBtk2W5BYEiom7/Twei1XPCwm ohgfgUGH2fvvZMpUFfeXo5/sW/z96OQ+y+PjlvSdeSq6JvsIYQpuzHW39N74RJZzZmyDBmNOvubc W0Xyli9sXEbtiM2Q08XZdw+tWHw4TaFGD7pIUxeXtdp2zLvuz2a42qm4FpsLXbMtlrus35U0udzv MT5C80F7XyrJW6OuP9Jbs13qj70oJoTQWQf7OnTZlqZk31+OfnJsMT12bt+xYwcuvpNRoVl2V78k YWkbm1aBfZ1dJ53nflKJ66mHynrQcYqhjcuaoxWBgZDStB02F7pm1Oyy1hYO9zsAGLcOCqitqZJh q2mhTmdXn8xg6Fcnf05sM3NwAwH7/nL3kw3jVqPa3XvUObC5YbXphzpXv1GLcVM87u0/Yxf6g48V t6Y4nnqorIf3NvsV6PNpufLtbn6qdaFrOL1Ji8u09KynBwDsLnftZmm6uN9LpjbS/Hw58xZxEzgH zu/xYP3ex0nHdqT6zuxjy1Ozv6Wuch37qd9y6e3Yee6aTUFVL/dPXZg9fllg1tLQIzUYwjmeevgw 1zUNG3vbP4w49EDCACPJSM3VulgAqwudA2nijq0XnsuY4lcXVoT8ahw0oYUhgIF6l7vWaO1+f6PL V3sG2FlZ2fT/7YVK57hRVj2/HyX95btFW/O/nOZtXtp/ta5yHfupBcqUyHGzksZGbfhh257Ae1PG 7EzmOrocTz1oKs2S65oWgy6JLr2ZIb7NdU0996nbZ/DXtDPhC02dvwiLeant43B6jQYEdcyLGt/G ik9RQptuq5WzDqzuZMS9Sh+f4m3+DnrGHsE3uu2MCfPUBwD95lO3TOGtaWvG128QsI0/dfsUN92u Tgmcxuw7E2p0aEJrSz5F6Tl4Tz/wRKyoaTSkBCbWVgCSC/vvSt8ibgYtQ2bXP32Q/npy6/IY6Du6 FWwLaGhk3mrGbZ9dx+d66uveT82vBD/aPPqH7CnRC9oZ88y7rtg/PW9+4Lq7Mq5dmnXq1DRq1+BG +jy+RftZl83bu5up0SGrKc7U1BTvUNTWxcrnW7v0uL3+/i5vY53bYDL3BbTePPDG3982EpReBXs7 V3ldQ4BCed/IUw78sEE5+mAbXXVJgJE8/H1G2H2/yH3On+4BRHvHex4wX+35evCvThtPLmxlqFsL hRdH2/NNO66lvvtjU2/LT7gULyb09w0hBIs746hZJwcD1CVKE0FpIghKE0FpIghKE0FQmghKE0FQ mghKE0FQmgiC0kRQmgiC0kRQmgiC0kRQmgiC0kQQlCaC0kQQlCaC0kSQz1GaVWq2s9RgLzhbWgCV 92HqN2vIu+/nW9a0/wSlKT7uyysv4+7sPWF7QmGt/MqVZjXbzfxjRG+qMNbpgOrYT46a7R+kpn1d HzXN39T8pCWPogelLghcfa+4FrrwQWq21zU4arZ/rvHR6JvIM2rQNegb99z/vSyRJpN/c/O4rk2s DQWG1k26jv/5Zj4D7LXW2Zaz1WxnqcHOgZa1yllriavdL/Fxv6YDpgx2M6T03CZERkz2MqEM/xV2 RSxir52uVT9Za91zxIeln+pr7GtbA58R39u/YHhHZzMhRQls2oyLfCQrT6Rqa9RzxL/4wapOJiad Vj3QYVBjLZhdoQCzUvT09PyOdl02JSsIIYqnm7rbNg/edz9fyShzE6O+aWbTffNTBVutdU1qsFcs 9sxWg12Hmupa1RJn2y9RjI/QYlBUSn7CoqZg8eVvyfmJS9xth5x/wVY7Xad+shXqVvMuaz/V19jX tgY+kT+OnLc0+sYLCc0UZ15Z1smm46ZkZWk31NSo59wvSeyU+gD1p8ZKta4VzinNkgooFCU0c+oQ uPJ8hrKkFvcsV9eZcZKyJiQ3Z7i4zooXs9Ra16QGexVpqq1JrkNNda1qibPtV2bpFvOPVXqR9k77 qbk0Ofuppsa+tjXwy75J4uf3rp09/PM4J7O+p8Sl3aheo76m+KsKMjIKVDqUsdfgXJNhFOK0m/u+ 7+UgAABQZD4QOXZ2KS84aujapb74YSaw1Fqv7Rrs2tYqZ6slzrZfZRV2y+vXU++jn6ztcPVTTY19 reNPChMjgn292vabuv7wjRSpvpCWlRfsrl6jvqb94ps6OJjya+tcs/JBsPewyIh9Vl52Vp5y45W5 u72Qvdb6u6nB/ibmPAoq/R62trXK2WqJc+yXRv0srZ2uYz81rnWvQz+1ir8sfuGQVXqLLt+5cjxy /ZKwSf4NuSNQU/zpoqysIvq9SNPQK2SqfdTY2fv+EamIKv9u9PQxUQ5TQ9xfqK+1/s5qsJcKy800 5cTVDCVd9Oq5mAbta5Wz1RJn2S8vjjKYamun69ZPzWvda9lPreNPF2YVKhWSIiVhipLPrQ2ed13C WdqOe7+kN2e4Ozh4zLwpq51pUFXo3OvhQV1crPT5+lYu3kHh13NpQorTL23+1t/TVg8AeIaO7Udt uJ5HE/bl7OeafdxGrFkyxMOMzzdz7TnnWFql38tSPIse29wYAIxcA/e8KDnrYSSPD84b2NJOHwD4 ps6dv15+6oWC4yxGlXNt49hODQwBQGDjNWTZ2XQF+36V9a3Ki7QYH9Pm08IGeVgJ30U/6bwry/wb GQAIjKzdh+5KVnD8ehB3P6usokn8K1H8bH9IR3shgIF9mxHLjxwJ8fRTOw2o8JtW7Pslv7+ivZFR +xX35Vqfa2LpV1355Gqn441KBEFpIh8zmNARHDURBKWJoDQRBKVZO5DinHQx/XH1WSV+mVNMUJqf tC4ldzf0axe443Hxx9Rr+eOtI9r233BXQj5vaXK4rz92mLwLs4dub7r9WGhz/Y+p3waeYTHbXLYN Db2Yz3zO0uRwX3/kyBJWz/irT8SaPjYfXebg2/qvjeh9YfrqBNlnKU1W97V6tzMtTTm9blLv5rZC iqIoS8/By/8qs1gwkBABvq7Ao4BvDYFr4Y2rnMCTA9DPC0z4wDOFnrPgKXuoVc+ggwVsSS1LxnB6 GLgvhGIA8T1YMByczYCiwKYNRD4q/YwYfC3hWDrsmQEuZkBR4HcASgeawhsb9hlNmdXJtMy7oLW7 W5V5YeWw1vVN+OVedKuh5wq1dZXrAmXWafYUw70bYws/YW2y2js43Nfq3M501qH+RgCmTTv39m1h BgBg6L83gyaEkOQtxMaF7Iglcppk3yUrFpM0BSGEvIgiDT3I1qtEQpPiLLJ1GGk2k7C602my3494 LiclJgo6g/S2JeHJhBDyOJIsjSYvJIQpJleWEZuOpNSVTXyMSd+eJGgrSZcRRk5yyrzWstuhbh7z E+W6u7sVTzd2svIKPZFcqFIVppwKa23XfeszpQ6uch2RJ/7g0WzO/2TkU0VXaVZ3OxN52t/XUqUM IUSWuMAVAIy+OldAiIzMdiVTrld3m5N5HmTJ/Qp+oDTSsRG5wv7khOg8cWhMbkkJIeTZFmLbi2TQ FV3Z5N41cvhn4mRGSl3ZxEdIBu0lyuptiU8H2Hbd+5rR3d0tPh1g0yUq800LTFZ0F5u+p8S6u8q1 hXm9p6ttv9PiT1aaup5nVXc7M/K81JPf+XnYG1GG/1qeDADSPCkDoIB/RNDdrVoLCkhIhiUtgKLe /Amc4WYOcLi+zb3hawp+iQVQwJ4t4Dsb7HkAAIWJEOwLbfvB+sOQIgUhDRVc2RAUAOp+zp6hCU/A q+hE1NLdbdwysNPz9atjHotVqoKnf6z5z5Om/s0M39bVr0VO5wl4hP6EJ0KCGj9Q6r7m/qlkJuvw v7uMOWM0ZOvx+0NbGZ73c/z6Wsk7QnA3h2tJMNy68hp64NUEeh2H0CYad9YQJk+G7uHw0hR2F8Hv 3YECABksHAJ6O+GOL/AAQAynV2qy39YuZqKkHCVYl3q4S9zdO+Pu+FryAEB8/PTKR5xzEev2/dtJ wxf77Rr+iti695z4++EQ15LG9Bv0mLiyx0QgxRk3tgcP6/H0j8R1bQ1KJ5ZFWTlgY29S9ZkEbZcr spNEZo2tBZ+sNGsaNTV1XzNF6S9lALmXd/0YMqhts1JdAoAhBIfA7yMhIh4UBCSpsDkM/soFMIAp c2HLKIi+BTIGgIH0eDh0Dbgvf7uOBI9YWLUS9MdCG+OSQwdZhaCQgJJAUTKsDYbrEk1U7ubXPOfP 2OzyUUdbd3fR9UWLk0btvZ5SoFQUvrob82NfRyHU6Cpnc31ruxyYnNg/s5v7uRl+ttLUc5+6fQZ/ TTsTvtDU+YuwmJcsyUnQOGjLMj8nYc7t87G5TUPCv29Z/p77LDg1DXYNBn0eWLSHy+bgbgYA4DQG zoTCoQlgyQdKD7ynwxMxcGcoviOEdoVfjkHwWHhzMdIEftoECd+AAQ+aDAfFMJjgpkk6tPSZ0Sst fPfjsu+aSdefNgUkfONqwDNuMjxSMWzFBDfOmgQm3st/bPif1qZv5uc8fQvnDiPDb8udBwR1zIsa 38aKT1FCm26rlbMOrO5U9pAZ38TR0cioXj2TKoHXdnnxo1/D03pN72FJfbYz9E8YZVpkX6eu6+7r OMeV31/avv3ysgcLVNKMK/PdrQaceR/zEum9Nd4N/HalKj/l41P3LjeLoa9J+dzozZ8JnHznd6QE TmN2b2m+68tx0am6zFOUrx+lpt2+cjermAAw0qwHfx06W9Cmv7tRbQdI8ey3sQMjPLb8FuT86Z5o AlqJVa/jr+Y16+Fuqn1iVL06szRk7rYz97OVwDdp0Kr3yNlL5we2MK3tbzspfHjpsXW3dnaCT/vQ oMsdqavTIBWDQUA+xhk6gqA0EaQuShPd5khdlCa6zRHtpfkeXO7oNkd0kWbtu9zRbY5oKc135XIX g18TWPcTdKgHFAXOveHC64qbQbc5wkJBQS273EXER0A6zCZ3MomqiET9m9gNJ+U1z9FtjrC53HWU puYudxHxsSAVap4Tr/qkvOY5us2RD+Zyr4zQGizkFa3s6DZH1FP7LvcqV1zSINMCymueo9sc0XGG /vYudwCQwtbNkCoFyTNYPAmMgqC85jm6zREdpfkuXO6gD24FENAQzFvBbR84PhfKr1+i2xzRcYb+ 9lSeBqHbHPl4XO7oNkd0mga9l7sqdv1+uWx/NU+nuYRJt7W/TQ6Z269hSLnb/M+jgY1qfc+ENh1C Dv7drZ0dH2VUK5c+CgoK1L6BLnekbk+DEASliSAoTQSl+dZUdL+jqxylWWd0Wcn9jq5ylGZFatvl LoMZnqC+/arud3SVozQrUtsudxoyWVy4atzv6Cr/rGC9UVn093jHKp81CTgpKjNxHn35IHq6b2NT AYBxn/1ZtCjGBwCg9BfDy14T8uoUCXAnQiAgJJ4BJOIWoQkhRWS8IwGo9Bdwsuw2VcHFUQ3bbkiq dgtQkbS+TcPRfxXgjbzP90alcbeI9CpW4sJT/Up//FuZvHPs5Asey6++VjDyF3sHsj/YUwRhE8B1 IxQyQIthdxBIS+pfGkNEOhAR+FhAjAgIAULgVL/SteRPT8eZ+H/RoNo9HWGDnv4mcaeT5Diq4DRI LYoC/Qn7dgZ3cTSgKH1La0P2dvSgnQckXIDbLwAMod0wmNpDg60qsh7mW3vWU+M50qvnaZ33MFOB xw6lqX5MreY2Z5fmzDOwzA12TIY2rWFoKFzJ1GS16u73N6CrHKVZQpnLvUb4egIAKC6UE0aaJ634 jj70mAi7z8CdWJjtDIE94HaFdKzPB3l1x1GZ+736eIqucpQmgOYudwADp/ZOAHBj7oghft0mxpUp 6QmMGw1740DCACUEh/ogkEG529wQvO0h4hBIGGAkkJpbtrya+710NEVXOUqzJB1r6HIH0Pecsn5y SyPIuHJd6r9+SZvSBhpBUEeIGg9WfKCE0G01zDoA5W5zPZi6HfhrwIQPps4QFgNv2q/ufi8BXeWf DXXYFKd6/uvAbpE9T58P9Sx91Ex2f23vvhfHXT05Ad27eK754ajqfkdXOY6adWTULBk6y2utfy41 zJGPQ5oIJnQEqWMndCX/mJmZlS1iG0cR5ANIE+WIYEJHEEzoCCZ0BMGEjmBCRxBM6AiCCR3BhI4g mNARTOgIggkdQWmiHBFM6AiCCR3BhI4gmNARTOg4giKY0BEEEzqCCR1BMKEjmNARBBM6gmBCRzCh IwgmdAQTOoJgQkcwoeMIimBCRxBM6AgmdATBhI5gQkeQD8P/ASPzkRcnJMV6AAAAAElFTkSuQmCC --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 24 00:04:18 2012 Received: (at 13250) by debbugs.gnu.org; 24 Dec 2012 05:04:18 +0000 Received: from localhost ([127.0.0.1]:57365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tn0D4-0005P1-Ha for submit@debbugs.gnu.org; Mon, 24 Dec 2012 00:04:18 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:32783) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tn0D3-0005Ov-C1 for 13250@debbugs.gnu.org; Mon, 24 Dec 2012 00:04:17 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCwsOHwcSFBgNJC6HbgW6CY0agyoDiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210625493" Received: from 69-196-176-227.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Dec 2012 00:03:48 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 4BA0DAE071; Mon, 24 Dec 2012 00:03:47 -0500 (EST) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer Message-ID: References: <877gobgpk4.fsf@yandex.ru> Date: Mon, 24 Dec 2012 00:03:47 -0500 In-Reply-To: <877gobgpk4.fsf@yandex.ru> (Dmitry Gutov's message of "Fri, 21 Dec 2012 23:42:19 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13250 Cc: 13250@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > When I return the list of candidates from the "completion table" > function, I'd like to be able the specify the base (not user-defined) > highlighting, so that the actual candidate text looks more visible (as > opposed to the annotations) and easy to scan. In my case, the candidates > are method names and the annotations are argument lists, so using > font-lock-function-name-face is natural. Adding such faces in the `all-completions' return value is not ideal, since all-completions can also be called without displaying the result in *Completions* (e.g. it's used to build the completion in partial-completion or in substring completion). That's why we have the annotate-function which adds annotations separately, only when we know we're going to display the result. Of course, in your case annotate-function doesn't cut it because it can only affect the annotation but not the actual completion. But I'm mentioning it, because the best long term solution should take it into account (i.e. extend annotate-function to let you do what you want to do here). > But if I propertize the list with 'font-lock-face properties, both the > "common" part and the "first difference" are still colored black, > because the completion code uses the hardcoded faces for them, one of > which inherits from `default', another from `bold'. Screenshot attached. The problem is that the first-difference and common part will simply replace the `font-lock-face' property. We could try and make them preserve a pre-existing font-lock-face instead. > Can we change this so that those faces override the face attributes only > if they've been explicitly customized (as opposed to inherited from > `default')? Not sure what you mean here. If you refer to the ":inherit default" of completions-common-part, I think it's just a mistake and that face should simply have a "nil" default (not that it would change much). > Is it possible to do that in a backwards-compatible way? > With overlays, maybe? Overlays can't be added to strings, so they're rather difficult to use here. If you really want it badly, you can probably get what you want by adding `display' properties which replace the completion text with a new text, identical except you can place any text-property you want on it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 24 02:12:10 2012 Received: (at 13250) by debbugs.gnu.org; 24 Dec 2012 07:12:10 +0000 Received: from localhost ([127.0.0.1]:57504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tn2Co-0008VN-8x for submit@debbugs.gnu.org; Mon, 24 Dec 2012 02:12:10 -0500 Received: from mail-la0-f46.google.com ([209.85.215.46]:46047) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tn2Cm-0008VG-MK for 13250@debbugs.gnu.org; Mon, 24 Dec 2012 02:12:09 -0500 Received: by mail-la0-f46.google.com with SMTP id p5so8166589lag.33 for <13250@debbugs.gnu.org>; Sun, 23 Dec 2012 23:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=uCLGgoxhlRI6S5jEd6C9FlB+XPr99HGrlx5pcJMo9Qk=; b=N9nSCBsgBHCEATICHhbFKXmjUIE64ny9u8jvJLnlF0E0LXSSBa8Rn/y6+Aw1eROtoN 5nbCLigd04cVbRBfH7D/pnCfY3YDvm/dlwxcV5MtMBjDIfShlXfalifYxmEzaLWFZTqb PUEoHGYr+dfRzMEmlOVyYq/T2A6MxC6iFvu2ltYkusZHyAAr0CPfEGk6dA+QFfbIesS6 CmFPyBWzedFgYh/ME2C+jD2obcUsTeCsmxs1UkL6cX7naMVNy7l/GbvoOTTRHc8jNAXJ 20W/M+4Et5BWO9wihOF9T05YfxQZLywC9oh5xOnO9A11r8jM9Hxh2EYu896qCwrKrMp4 8mFA== X-Received: by 10.152.114.65 with SMTP id je1mr19658159lab.33.1356333098463; Sun, 23 Dec 2012 23:11:38 -0800 (PST) Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPS id t3sm7098235lbl.17.2012.12.23.23.11.35 (version=SSLv3 cipher=OTHER); Sun, 23 Dec 2012 23:11:37 -0800 (PST) Message-ID: <50D8002C.5080401@yandex.ru> Date: Mon, 24 Dec 2012 11:11:40 +0400 From: Dmitry Gutov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer References: <877gobgpk4.fsf@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13250 Cc: 13250@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) On 24.12.2012 9:03, Stefan Monnier wrote: >> When I return the list of candidates from the "completion table" >> function, I'd like to be able the specify the base (not user-defined) >> highlighting, so that the actual candidate text looks more visible (as >> opposed to the annotations) and easy to scan. In my case, the candidates >> are method names and the annotations are argument lists, so using >> font-lock-function-name-face is natural. > > Adding such faces in the `all-completions' return value is not ideal, > since all-completions can also be called without displaying the result > in *Completions* (e.g. it's used to build the completion in > partial-completion or in substring completion). > > That's why we have the annotate-function which adds annotations > separately, only when we know we're going to display the result. > > Of course, in your case annotate-function doesn't cut it because it can > only affect the annotation but not the actual completion. But I'm > mentioning it, because the best long term solution should take it into > account (i.e. extend annotate-function to let you do what you want to > do here). It would have to be a different function and metadata property, no? I don't think we can change annotation-function to return the candidate plus annotation, for example. >> But if I propertize the list with 'font-lock-face properties, both the >> "common" part and the "first difference" are still colored black, >> because the completion code uses the hardcoded faces for them, one of >> which inherits from `default', another from `bold'. Screenshot attached. > > The problem is that the first-difference and common part will simply > replace the `font-lock-face' property. We could try and make them > preserve a pre-existing font-lock-face instead. So, AFAICT, the proper solution would be to walk the part of the string, look at every piece in it that has a different value of 'face, then where the value is a symbol, wrap it into a list, and then add the new face to the end of the lists. And repeat for the "first difference". Anything simpler? >> Can we change this so that those faces override the face attributes only >> if they've been explicitly customized (as opposed to inherited from >> `default')? > > Not sure what you mean here. If you refer to the ":inherit default" of > completions-common-part, I think it's just a mistake and that face > should simply have a "nil" default (not that it would change much). Yes, more or less. I was referring to the need to merge the customized highlightings onto the already propertized string. The algorithm above should work, though. >> Is it possible to do that in a backwards-compatible way? >> With overlays, maybe? > > Overlays can't be added to strings, so they're rather difficult to > use here. > > If you really want it badly, you can probably get what you want by > adding `display' properties which replace the completion text with a new > text, identical except you can place any text-property you want on it. That's clever, but this way the "first difference" will probably have to stay unemphasised. That's not ideal. I'm not in any particular hurry, maybe I'll implement the long term solution. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 29 00:30:34 2012 Received: (at 13250) by debbugs.gnu.org; 29 Dec 2012 05:30:34 +0000 Received: from localhost ([127.0.0.1]:35456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Top0D-0000wg-Pg for submit@debbugs.gnu.org; Sat, 29 Dec 2012 00:30:34 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:54052) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Top0B-0000wU-Cu for 13250@debbugs.gnu.org; Sat, 29 Dec 2012 00:30:31 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id qBT5TUPH001939; Sat, 29 Dec 2012 00:29:30 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id B738BAE0B8; Sat, 29 Dec 2012 00:29:30 -0500 (EST) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer Message-ID: References: <877gobgpk4.fsf@yandex.ru> <50D8002C.5080401@yandex.ru> Date: Sat, 29 Dec 2012 00:29:30 -0500 In-Reply-To: <50D8002C.5080401@yandex.ru> (Dmitry Gutov's message of "Mon, 24 Dec 2012 11:11:40 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4445=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4445> : streams <882694> : uri <1306212> X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 13250 Cc: 13250@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > It would have to be a different function and metadata property, no? Could be. > I don't think we can change annotation-function to return the candidate plus > annotation, for example. Currently it can only return a string (which is combined with the completion into a cons cell), but we could let it return the cons cell directly. That wouldn't necessarily help with "annotations before" (and it wouldn't make sure that the annotations don't actually change the completions). > So, AFAICT, the proper solution would be to walk the part of the string, > look at every piece in it that has a different value of 'face, then where > the value is a symbol, wrap it into a list, and then add the new face to the > end of the lists. And repeat for the "first difference". Yes. Lars wanted to add a function that does just that, but you can use font-lock-prepend-text-property in the mean time. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 11 22:46:16 2013 Received: (at 13250) by debbugs.gnu.org; 12 Jan 2013 03:46:16 +0000 Received: from localhost ([127.0.0.1]:56010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tts2x-0007RD-LY for submit@debbugs.gnu.org; Fri, 11 Jan 2013 22:46:16 -0500 Received: from mail-la0-f51.google.com ([209.85.215.51]:40263) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tts2u-0007Qq-46 for 13250@debbugs.gnu.org; Fri, 11 Jan 2013 22:46:13 -0500 Received: by mail-la0-f51.google.com with SMTP id fj20so2337030lab.24 for <13250@debbugs.gnu.org>; Fri, 11 Jan 2013 19:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=bskVYHXlxrVhLx2g8g6kvk7BEEUvTkAGXHZpg29q+0U=; b=zt9g8pYYhkCt6+lHKdjaIlMN3IhTQOBD0RmdRcZW99hg5Gc8RzRSJcABzNQ2T6E3/C nwBqUZ5/N/HN9X1PCIu73iJbps8yTCup6taK+saYnhOP1LZr0mqVgZREdmNYJwHVAF+h /VNyq6LQ38N6z31E4rRTd04ro5m42RUPMrzbEEkgN1Fgxc/In0HbtTk1F8ixjbGoCg+O 2gXbAWF1y4u8c4rY7L5JeDZudz/BUXGc8zH4O3+kJKda3TyPh8sCYFj+EAxDhH5hUAJh 8kYgFgFj7Y5nwK49JN/XSB0YCAfeZZiAjyPgj07Vssenl1IpK8xD+YuWa6t3Bhwc1wwH UMQw== X-Received: by 10.152.45.229 with SMTP id q5mr74532219lam.34.1357962355661; Fri, 11 Jan 2013 19:45:55 -0800 (PST) Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPS id iw6sm2692590lab.2.2013.01.11.19.45.53 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 11 Jan 2013 19:45:54 -0800 (PST) Message-ID: <50F0DC73.4@yandex.ru> Date: Sat, 12 Jan 2013 07:45:55 +0400 From: Dmitry Gutov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer References: <877gobgpk4.fsf@yandex.ru> <50D8002C.5080401@yandex.ru> In-Reply-To: Content-Type: multipart/mixed; boundary="------------070802030200070301050606" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13250 Cc: 13250@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------070802030200070301050606 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 29.12.2012 9:29, Stefan Monnier wrote: >> It would have to be a different function and metadata property, no? > > Could be. > >> I don't think we can change annotation-function to return the candidate plus >> annotation, for example. > > Currently it can only return a string (which is combined with the > completion into a cons cell), but we could let it return the cons cell > directly. That wouldn't necessarily help with "annotations before" (and > it wouldn't make sure that the annotations don't actually change > the completions). I decided not to do this for now, because it doesn't actually help in my case. Or maybe I just haven't encountered a bug that would be caused by the additional fontification (as long as I use 'face, not 'font-lock-face). And the part below works the same, whether the base highlighting was added in the completion strings directly, or through the annotation function. Speaking of "annotations before", I don't see how they can be used in the current interface. Showing the classes where the methods are defined would be good, but lining the candidates up vertically is important for visual scan-ability, and the "before strings" can be of different lengths. >> So, AFAICT, the proper solution would be to walk the part of the string, >> look at every piece in it that has a different value of 'face, then where >> the value is a symbol, wrap it into a list, and then add the new face to the >> end of the lists. And repeat for the "first difference". > > Yes. Lars wanted to add a function that does just that, but you can use > font-lock-prepend-text-property in the mean time. Thanks, that was rather easy. I'm attaching a patch that fixes this bug's problem for me (letting the fontifications through), so maybe we should leave improvements to annotation function for later. --------------070802030200070301050606 Content-Type: text/plain; charset=windows-1251; name="completions-hl.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="completions-hl.diff" === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2013-01-11 23:24:52 +0000 +++ lisp/ChangeLog 2013-01-12 03:37:51 +0000 @@ -1,3 +1,16 @@ +2013-01-12 Dmitry Gutov + + * minibuffer.el (completions-first-difference): State that the + face is "added" in the docstring. + (completions-common-part): Same. And not inheric from default. + (completion-hilit-commonality): Prepend 'completions-common-part + and 'completion-first-difference faces to the 'face property, + instead of replacing the value. + (completion--insert-strings): Same with 'completions-annotations face. + (completion-hilit-commonality): Use 'face instead of + 'font-lock-face, because it gets priority if the completion + strings already have 'face set. + 2013-01-11 Felix H. Dahlke * progmodes/js.el: Fix multiline declarations's indentation (bug#8576). === modified file 'lisp/minibuffer.el' --- lisp/minibuffer.el 2013-01-02 16:13:04 +0000 +++ lisp/minibuffer.el 2013-01-12 03:29:23 +0000 @@ -1458,9 +1458,11 @@ 'mouse-face 'highlight) (put-text-property (point) (progn (insert (car str)) (point)) 'mouse-face 'highlight) - (add-text-properties (point) (progn (insert (cadr str)) (point)) - '(mouse-face nil - face completions-annotations))) + (let ((beg (point)) + (end (progn (insert (cadr str)) (point)))) + (put-text-property beg end 'mouse-face nil) + (font-lock-prepend-text-property beg end 'face + 'completions-annotations))) (cond ((eq completions-format 'vertical) ;; Vertical format @@ -1487,12 +1489,11 @@ (defface completions-first-difference '((t (:inherit bold))) - "Face put on the first uncommon character in completions in *Completions* buffer." + "Face added on the first uncommon character in completions in *Completions* buffer." :group 'completion) -(defface completions-common-part - '((t (:inherit default))) - "Face put on the common prefix substring in completions in *Completions* buffer. +(defface completions-common-part '((t nil)) + "Face added on the common prefix substring in completions in *Completions* buffer. The idea of `completions-common-part' is that you can use it to make the common parts less visible than normal, so that the rest of the differing parts is, by contrast, slightly highlighted." @@ -1513,17 +1514,18 @@ (car (setq elem (cons (copy-sequence (car elem)) (cdr elem)))) (setq elem (copy-sequence elem))))) - (put-text-property 0 - ;; If completion-boundaries returns incorrect - ;; values, all-completions may return strings - ;; that don't contain the prefix. - (min com-str-len (length str)) - 'font-lock-face 'completions-common-part - str) + (font-lock-prepend-text-property + 0 + ;; If completion-boundaries returns incorrect + ;; values, all-completions may return strings + ;; that don't contain the prefix. + (min com-str-len (length str)) + 'face 'completions-common-part str) (if (> (length str) com-str-len) - (put-text-property com-str-len (1+ com-str-len) - 'font-lock-face 'completions-first-difference - str))) + (font-lock-prepend-text-property com-str-len (1+ com-str-len) + 'face + 'completions-first-difference + str))) elem) completions) base-size)))) --------------070802030200070301050606-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 04 02:39:29 2013 Received: (at 13250) by debbugs.gnu.org; 4 Mar 2013 07:39:29 +0000 Received: from localhost ([127.0.0.1]:58123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCPzc-0002Ns-QG for submit@debbugs.gnu.org; Mon, 04 Mar 2013 02:39:28 -0500 Received: from mail-lb0-f181.google.com ([209.85.217.181]:50972) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCPzZ-0002Nc-5h for 13250@debbugs.gnu.org; Mon, 04 Mar 2013 02:39:26 -0500 Received: by mail-lb0-f181.google.com with SMTP id gm6so3663384lbb.40 for <13250@debbugs.gnu.org>; Sun, 03 Mar 2013 23:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=uCvawlaISH25tYhQS5o+ckKhfH+4JHkagRc9qSQNwX8=; b=AEnhm4E3/wqFRnHO5/qQb2agrHua/jupBE1z806oITWUQL1XG3eAwzMYT+VK+aUNkv j0bvRMvI5zHbSUYgfVa37lEdtb8AjqDy0/p1YMW/shpNErshwKUnAGev9vpQ5grWecdm NFtsv9yndAePSI3dJ5Bm4VKLNh341CWi5iUSu/tt3qau40sOXYWgA2R/jowNQ7CYgQ/3 9NGGdYjXtMxGApi3nIdDy3WxyfSYflMgkGcs/wp244xBSwwl5idgn3fX7Fvy+aMdxG4c eeaDadNeMbQnlG1Ux/V2X+vK0I59ig3Tv1h7kbh2lvTKa0D4oT9eh14SP+tODA9NTU37 eQiQ== X-Received: by 10.152.105.17 with SMTP id gi17mr7057931lab.46.1362382745958; Sun, 03 Mar 2013 23:39:05 -0800 (PST) Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPS id m2sm6974334lbz.7.2013.03.03.23.39.04 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 03 Mar 2013 23:39:05 -0800 (PST) Message-ID: <51344F9D.5080401@yandex.ru> Date: Mon, 04 Mar 2013 11:39:09 +0400 From: Dmitry Gutov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer References: <877gobgpk4.fsf@yandex.ru> <50D8002C.5080401@yandex.ru> <50F0DC73.4@yandex.ru> In-Reply-To: <50F0DC73.4@yandex.ru> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13250 Cc: 13250@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan, Do you see any problems in the patch I sent for this bug in the previous message? --Dmitry From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 04 09:37:07 2013 Received: (at 13250) by debbugs.gnu.org; 4 Mar 2013 14:37:07 +0000 Received: from localhost ([127.0.0.1]:58429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCWVl-0006Xz-C9 for submit@debbugs.gnu.org; Mon, 04 Mar 2013 09:37:06 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:59674) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCWVf-0006XR-PI for 13250@debbugs.gnu.org; Mon, 04 Mar 2013 09:37:00 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLvL/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFFFxLvL/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="2972100" Received: from 69-196-187-203.dsl.teksavvy.com (HELO pastel.home) ([69.196.187.203]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Mar 2013 09:36:37 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6C6146BF75; Mon, 4 Mar 2013 09:36:38 -0500 (EST) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer Message-ID: References: <877gobgpk4.fsf@yandex.ru> <50D8002C.5080401@yandex.ru> <50F0DC73.4@yandex.ru> <51344F9D.5080401@yandex.ru> Date: Mon, 04 Mar 2013 09:36:38 -0500 In-Reply-To: <51344F9D.5080401@yandex.ru> (Dmitry Gutov's message of "Mon, 04 Mar 2013 11:39:09 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 13250 Cc: 13250@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Do you see any problems in the patch I sent for this bug in the > previous message? I'm not sure what impact it might have on speed, but I think the principle is fine, so go ahead, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 03:04:49 2013 Received: (at 13250-done) by debbugs.gnu.org; 5 Mar 2013 08:04:49 +0000 Received: from localhost ([127.0.0.1]:59682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCmrh-0007WM-2g for submit@debbugs.gnu.org; Tue, 05 Mar 2013 03:04:49 -0500 Received: from mail-la0-f41.google.com ([209.85.215.41]:44351) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCmre-0007W7-L6 for 13250-done@debbugs.gnu.org; Tue, 05 Mar 2013 03:04:47 -0500 Received: by mail-la0-f41.google.com with SMTP id fo12so5889607lab.28 for <13250-done@debbugs.gnu.org>; Tue, 05 Mar 2013 00:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=G9SlsonMzc4Too54VAa+/LhhI9RGhiCJTEhABXp0Gn4=; b=hylBLA+qKxxaDIvOR+SoHT3PmNIWCX3bep/k93+BWbsWsJCcE6f1klV7/7dHDVT9vK EzsX1RKVrr1xomIm2d+ajNkzmxuoYWPl02a3rn0iqx1wzx2vMzy4JboLUSL/ziYVzgOg BY+jwqCRIcxXmJxjJWSNq/+g8kd9sXyU0gy5s6awrb9G0wLDrOvDaQtDy461HdkQdHAc cioG6+ce+tPdiJjVumIrdfg6QVkuJqBypRgShKi+bbhVznfIS3ZzWv593W6H+DUvDxNT N5iYSUExB2N1hE4BYTIagD5fDYOU8T4IOXMlVXNg4bcdESNyNIlJI/7ZbH83cUbTwwjM Cdpg== X-Received: by 10.112.36.38 with SMTP id n6mr5612228lbj.126.1362470661289; Tue, 05 Mar 2013 00:04:21 -0800 (PST) Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPS id l1sm8215705lbn.8.2013.03.05.00.04.18 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 05 Mar 2013 00:04:19 -0800 (PST) Message-ID: <5135A704.1010302@yandex.ru> Date: Tue, 05 Mar 2013 12:04:20 +0400 From: Dmitry Gutov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#13250: 24.3.50; Add a way to show pre-highlighted candidates in completions buffer References: <877gobgpk4.fsf@yandex.ru> <50D8002C.5080401@yandex.ru> <50F0DC73.4@yandex.ru> <51344F9D.5080401@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13250-done Cc: 13250-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 04.03.2013 18:36, Stefan Monnier wrote: >> Do you see any problems in the patch I sent for this bug in the >> previous message? > > I'm not sure what impact it might have on speed, but I think the > principle is fine, so go ahead, Thanks, installed. From unknown Thu Jun 19 14:03:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Apr 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator