From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 20 02:16:07 2012 Received: (at submit) by debbugs.gnu.org; 20 Dec 2012 07:16:08 +0000 Received: from localhost ([127.0.0.1]:51661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlaMR-0005Bi-A2 for submit@debbugs.gnu.org; Thu, 20 Dec 2012 02:16:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48762) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlaMO-0005Ba-JG for submit@debbugs.gnu.org; Thu, 20 Dec 2012 02:16:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlaMF-0007dn-7H for submit@debbugs.gnu.org; Thu, 20 Dec 2012 02:15:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_DUL, RDNS_DYNAMIC autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:35106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlaME-0007dX-Qi for submit@debbugs.gnu.org; Thu, 20 Dec 2012 02:15:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlaMA-0001PU-L2 for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2012 02:15:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlaM7-0007cK-RA for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2012 02:15:50 -0500 Received: from v055125.ppp.asahi-net.or.jp ([124.155.55.125]:33004 helo=mail.musha.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlZ3S-0004ig-Ay for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2012 00:52:26 -0500 Received: from daemon.musha.org (daemon.local.idaemons.org [192.168.11.11]) by mail.musha.org (Postfix) with ESMTP id 3YRhvB4sy4z141C for ; Thu, 20 Dec 2012 14:52:22 +0900 (JST) Date: Thu, 20 Dec 2012 14:52:22 +0900 Message-ID: <86zk19w9rd.knu@iDaemons.org> From: "Akinori MUSHA" To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix make install (ignore error with chmod 1755) Organization: Associated I. Daemons MIME-Version: 1.0 (generated by EMIKO 1.14.1 - "Choanoflagellata") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: FreeBSD [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) On FreeBSD, "make install" stops with an error at the almost final command, which can be fixed by the attached patch. I found this problem on the emacs-24 branch but the situation is the same on the trunk. The chmod command line used to be guarded with a `-' prefix, but it was lost when the block was rewritten to a shell command block in the following commit: http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/108256 % make install (...) if test "no" = "no"; then /usr/bin/install -c src/emacs /home/knu/arch/freebsd9/mach/amd64/bin/`echo emacs-24.2.91 | sed 's,x,x,'` || exit 1 ; chmod 1755 /home/knu/arch/freebsd9/mach/amd64/bin/`echo emacs-24.2.91 | sed 's,x,x,'` ; if test "x" = x; then rm -f /home/knu/arch/freebsd9/mach/amd64/bin/`echo emacs | sed 's,x,x,'` ; cd /home/knu/arch/freebsd9/mach/amd64/bin && ln -s `echo emacs-24.2.91 | sed 's,x,x,'` `echo emacs | sed 's,x,x,'`; fi; else subdir=/site-lisp; if [ -f ${subdir}/subdirs.el ]; then true; else umask 022; /usr/local/bin/gmkdir -p ${subdir}; (echo "(if (fboundp 'normal-top-level-add-subdirs-to-load-path)"; echo " (normal-top-level-add-subdirs-to-load-path))") > ${subdir}/subdirs.el; fi || exit 1; rm -rf /share; fi chmod: /home/knu/arch/freebsd9/mach/amd64/bin/emacs-24.2.91: Inappropriate file type or format *** [install-arch-dep] Error code 1 Stop in /home/knu/src/github/emacs/.build.freebsd9-amd64. --- ChangeLog | 6 ++++++ Makefile.in | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 1d6a2af..4224806 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2012-12-20 Akinori MUSHA + + * Makefile.in (install-arch-dep): Ignore error in trying to set a + sticky bit on an emacs executable. Chmod 1755 on a regular file + fails on such platforms as FreeBSD. + 2012-12-16 Romain Francoise * configure.ac (acl): New option. diff --git a/Makefile.in b/Makefile.in index bc9b01c..1e3966f 100644 --- a/Makefile.in +++ b/Makefile.in @@ -445,7 +445,7 @@ install-arch-dep: src install-arch-indep install-doc INSTALL_STRIP=${INSTALL_STRIP} if test "${ns_self_contained}" = "no"; then \ ${INSTALL_PROGRAM} $(INSTALL_STRIP) src/emacs${EXEEXT} $(DESTDIR)${bindir}/$(EMACSFULL) || exit 1 ; \ - chmod 1755 $(DESTDIR)${bindir}/$(EMACSFULL) ; \ + chmod 1755 $(DESTDIR)${bindir}/$(EMACSFULL) || true ; \ if test "x${NO_BIN_LINK}" = x; then \ rm -f $(DESTDIR)${bindir}/$(EMACS) ; \ cd $(DESTDIR)${bindir} && $(LN_S) $(EMACSFULL) $(EMACS); \ -- 1.8.0.2 -- Akinori MUSHA / http://akinori.org/ From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 20 02:57:50 2012 Received: (at 13233-done) by debbugs.gnu.org; 20 Dec 2012 07:57:50 +0000 Received: from localhost ([127.0.0.1]:51695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tlb0n-0006AG-Ic for submit@debbugs.gnu.org; Thu, 20 Dec 2012 02:57:50 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56931) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tlb0k-0006A8-Nn for 13233-done@debbugs.gnu.org; Thu, 20 Dec 2012 02:57:47 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Tlb0b-0006kO-V0; Thu, 20 Dec 2012 02:57:38 -0500 From: Glenn Morris To: 13233-done@debbugs.gnu.org Subject: Re: bug#13233: [PATCH] Fix make install (ignore error with chmod 1755) References: <86zk19w9rd.knu@iDaemons.org> X-Spook: Juiliett Class Submarine Mahmoud Ahmadinejad ANZUS X-Ran: %zf4}v~#YNx,A;zn`[u_3YLPK;e`M<$Iu,taC;vujgWWEM~.za&x^9!wA=*}gwC\?0`m>t X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 20 Dec 2012 02:57:37 -0500 In-Reply-To: <86zk19w9rd.knu@iDaemons.org> (Akinori MUSHA's message of "Thu, 20 Dec 2012 14:52:22 +0900") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13233-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Version: 24.3 Thanks; applied. From unknown Mon Jun 23 06:00:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Jan 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator