From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 08:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13225@debbugs.gnu.org X-Debbugs-Original-To: Bug-Gnu-Emacs Received: via spool by submit@debbugs.gnu.org id=B.135590474814590 (code B ref -1); Wed, 19 Dec 2012 08:13:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2012 08:12:28 +0000 Received: from localhost ([127.0.0.1]:49896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlElP-0003nG-W0 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:12:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36308) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlElN-0003n9-W9 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:12:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlElL-0006Dy-Q4 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:12:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlElL-0006Dt-Nt for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:12:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlElK-0001qj-OO for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 03:12:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlElH-0006Cz-4o for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 03:12:22 -0500 Received: from mout.gmx.net ([212.227.15.18]:61822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlElG-0006Ct-SK for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 03:12:19 -0500 Received: from mailout-de.gmx.net ([10.1.76.24]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Mg20J-1TPySL4BPx-00NR9u for ; Wed, 19 Dec 2012 09:12:17 +0100 Received: (qmail invoked by alias); 19 Dec 2012 08:12:16 -0000 Received: from 62-47-39-246.adsl.highway.telekom.at (EHLO [62.47.39.246]) [62.47.39.246] by mail.gmx.net (mp024) with SMTP; 19 Dec 2012 09:12:16 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/JIYRKP7TJqY5ZFnSJKP4NHVkSOH0tcH4n3ZrSdQ PEZnMlKBsF+N/q Message-ID: <50D176DF.4080102@gmx.at> Date: Wed, 19 Dec 2012 09:12:15 +0100 From: martin rudalics MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) With emacs -Q do C-x 5 2. The mode lines of both windows appear in `mode-line' face, regardless of which window is selected. This contradicts the Elisp manual which says: The selected window's mode line is usually displayed in a different color using the face `mode-line'. Other windows' mode lines appear in the face `mode-line-inactive' instead. In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2012-12-19 on MACHNO Bzr revision: 111265 eliz@gnu.org-20121218190556-x9wmq083vwecgu0f Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt' martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 13225@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135593323629102 (code B ref 13225); Wed, 19 Dec 2012 16:08:02 +0000 Received: (at 13225) by debbugs.gnu.org; 19 Dec 2012 16:07:16 +0000 Received: from localhost ([127.0.0.1]:50997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlMAq-0007ZG-2p for submit@debbugs.gnu.org; Wed, 19 Dec 2012 11:07:15 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:47048) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlMAl-0007Z4-DY for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 11:07:10 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MFA00A00CPBU400@a-mtaout22.012.net.il> for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 18:07:02 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFA00AJGCRQTP10@a-mtaout22.012.net.il>; Wed, 19 Dec 2012 18:07:02 +0200 (IST) Date: Wed, 19 Dec 2012 18:07:18 +0200 From: Eli Zaretskii In-reply-to: <50D176DF.4080102@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <83zk1anhzd.fsf@gnu.org> References: <50D176DF.4080102@gmx.at> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Wed, 19 Dec 2012 09:12:15 +0100 > From: martin rudalics > > With emacs -Q do C-x 5 2. The mode lines of both windows appear in > `mode-line' face, regardless of which window is selected. > > This contradicts the Elisp manual which says: > > The selected window's mode line is usually displayed in a different > color using the face `mode-line'. Other windows' mode lines appear in > the face `mode-line-inactive' instead. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Wed, 19 Dec 2012 09:12:15 +0100 > From: martin rudalics > > With emacs -Q do C-x 5 2. The mode lines of both windows appear in > `mode-line' face, regardless of which window is selected. > > This contradicts the Elisp manual which says: > > The selected window's mode line is usually displayed in a different > color using the face `mode-line'. Other windows' mode lines appear in > the face `mode-line-inactive' instead. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4948] > Date: Wed, 19 Dec 2012 09:12:15 +0100 > From: martin rudalics > > With emacs -Q do C-x 5 2. The mode lines of both windows appear in > `mode-line' face, regardless of which window is selected. > > This contradicts the Elisp manual which says: > > The selected window's mode line is usually displayed in a different > color using the face `mode-line'. Other windows' mode lines appear in > the face `mode-line-inactive' instead. We are shooting ourselves in the foot. At some point during redisplay, it loops over all the frames and redisplays every window of every visible frame. Here's the beginning of that loop: FOR_EACH_FRAME (tail, frame) { struct frame *f = XFRAME (frame); /* We don't have to do anything for unselected terminal frames. */ if ((FRAME_TERMCAP_P (f) || FRAME_MSDOS_P (f)) && !EQ (FRAME_TTY (f)->top_frame, frame)) continue; if (FRAME_WINDOW_P (f) || FRAME_TERMCAP_P (f) || f == sf) { /* Select the frame, for the sake of frame-local variables. */ ensure_selected_frame (frame); /* Mark all the scroll bars to be removed; we'll redeem the ones we want when we redisplay their windows. */ if (FRAME_TERMINAL (f)->condemn_scroll_bars_hook) FRAME_TERMINAL (f)->condemn_scroll_bars_hook (f); if (FRAME_VISIBLE_P (f) && !FRAME_OBSCURED_P (f)) redisplay_windows (FRAME_ROOT_WINDOW (f)); Where we now call ensure_selected_frame, originally there was a call to select_frame_for_redisplay, which arranged for all the frame-local variables to appear in C variables. But now it does this in addition: selected_frame = frame; /* If redisplay causes scrolling, it sets point in the window, so we need to be careful with the selected-window's point handling. */ select_window_1 (XFRAME (frame)->selected_window, 0); This selects the frame, and _also_ makes that frame's selected window be the global selected_window. Therefore, when display_mode_lines comes to select a proper face for the mode line, it always finds the frame's selected window in selected_window, and thus always uses the face for selected windows. I can fix this with the kludge shown below, but do we care about yet another global variable, in addition to selected_window? If we don't want this, then the only other way I see is to drag this window all the way down to display_mode_lines through the calling sequences. (That's assuming that only the mode-line display wants to know about the _real_ selected_window.) === modified file 'src/xdisp.c' --- src/xdisp.c 2012-12-17 19:17:06 +0000 +++ src/xdisp.c 2012-12-19 16:02:53 +0000 @@ -13006,6 +13006,8 @@ do { if (polling_stopped_here) start_pol /* Perhaps in the future avoid recentering windows if it is not necessary; currently that causes some problems. */ +static struct window *sw_on_sf; + static void redisplay_internal (void) { @@ -13491,6 +13493,8 @@ redisplay_internal (void) if (FRAME_WINDOW_P (f) || FRAME_TERMCAP_P (f) || f == sf) { + sw_on_sf = sw; + /* Select the frame, for the sake of frame-local variables. */ ensure_selected_frame (frame); @@ -20371,7 +20375,7 @@ display_mode_lines (struct window *w) if (WINDOW_WANTS_MODELINE_P (w)) { - struct window *sel_w = XWINDOW (old_selected_window); + struct window *sel_w = sw_on_sf; /* Select mode line face based on the real selected window. */ display_mode_line (w, CURRENT_MODE_LINE_FACE_ID_3 (sel_w, sel_w, w), From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: martin rudalics , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135594186013209 (code B ref 13225); Wed, 19 Dec 2012 18:31:01 +0000 Received: (at 13225) by debbugs.gnu.org; 19 Dec 2012 18:31:00 +0000 Received: from localhost ([127.0.0.1]:51172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlOQ0-0003Qz-Hz for submit@debbugs.gnu.org; Wed, 19 Dec 2012 13:31:00 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:1545) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlOPz-0003Qt-JO for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 13:30:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBJy8jBQsLNBIUGA0kiBwFugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210363639" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Dec 2012 13:30:55 -0500 Received: by pastel.home (Postfix, from userid 20848) id 654114E0D7; Wed, 19 Dec 2012 13:30:54 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> Date: Wed, 19 Dec 2012 13:30:54 -0500 In-Reply-To: <83zk1anhzd.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Dec 2012 18:07:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) > selected_frame = frame; > /* If redisplay causes scrolling, it sets point in the window, so we need to > be careful with the selected-window's point handling. */ > select_window_1 (XFRAME (frame)->selected_window, 0); > This selects the frame, and _also_ makes that frame's selected window > be the global selected_window. Therefore, when display_mode_lines > comes to select a proper face for the mode line, it always finds the > frame's selected window in selected_window, and thus always uses the > face for selected windows. Ah, yes, that makes sense. Of course, when we drop frame-local variables this problem will disappear. Maybe we should live with the "selected_frame->selected_window != selected_window" problem until we get rid of frame-local vars. Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Stefan Monnier'" , "'Eli Zaretskii'" Cc: 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135594460117310 (code B ref 13225); Wed, 19 Dec 2012 19:17:01 +0000 Received: (at 13225) by debbugs.gnu.org; 19 Dec 2012 19:16:41 +0000 Received: from localhost ([127.0.0.1]:51197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlP8C-0004V8-AJ for submit@debbugs.gnu.org; Wed, 19 Dec 2012 14:16:40 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:49848) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlP8A-0004Ux-3d for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 14:16:38 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qBJJGWfR015009 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Dec 2012 19:16:33 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qBJJGVfa004979 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Dec 2012 19:16:32 GMT Received: from abhmt109.oracle.com (abhmt109.oracle.com [141.146.116.61]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qBJJGUCP014664; Wed, 19 Dec 2012 13:16:30 -0600 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 19 Dec 2012 11:16:30 -0800 From: "Drew Adams" References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> Date: Wed, 19 Dec 2012 11:16:29 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac3eFwOffMDJn4fCQ8Cr0pjCAUzlPgABfZ6g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.5 (-) > Of course, when we drop frame-local variables this problem > will disappear. > > Maybe we should live with the "selected_frame->selected_window != > selected_window" problem until we get rid of frame-local vars. And just why have you decided to drop frame-local vars? I don't use them - just wondering. Who have they hurt? Why were they created? Is that purpose no longer valid? Does no one use them for anything? From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Stefan Monnier'" , "'Eli Zaretskii'" Cc: 'Alp Aker' , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135594530218337 (code B ref 13225); Wed, 19 Dec 2012 19:29:02 +0000 Received: (at 13225) by debbugs.gnu.org; 19 Dec 2012 19:28:22 +0000 Received: from localhost ([127.0.0.1]:51203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlPJV-0004lh-Q4 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 14:28:22 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:41953) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlPJT-0004la-Jl for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 14:28:21 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qBJJSE8J008450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Dec 2012 19:28:15 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qBJJSDTc012802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Dec 2012 19:28:14 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qBJJSEsx000972; Wed, 19 Dec 2012 13:28:14 -0600 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 19 Dec 2012 11:28:13 -0800 From: "Drew Adams" References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> Date: Wed, 19 Dec 2012 11:28:12 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac3eFwOffMDJn4fCQ8Cr0pjCAUzlPgABfZ6gAABV5fA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.5 (-) > > Of course, when we drop frame-local variables this problem > > will disappear. > > > > Maybe we should live with the "selected_frame->selected_window != > > selected_window" problem until we get rid of frame-local vars. > > And just why have you decided to drop frame-local vars? > > I don't use them - just wondering. Who have they hurt? > Why were they created? Is that purpose no longer valid? > Does no one use them for anything? BTW, you might want to have a look at Alp Aker's library `frame-bufs.el' (ccing him): overview: http://www.emacswiki.org/emacs/FrameBufs code: http://www.emacswiki.org/emacs/download/frame-bufs.el >From the overview: Frame-bufs is intended as a convenience for those who like to organize their workflow in Emacs by using specific frames for different projects. It extends Emacs's buffer menu so that it understands a distinction between those buffers that are associated with a given frame and those that are not. The buffer menu can be toggled between a list of all buffers and a list of only those buffers associated with the selected frame. The criteria governing which buffers are associated with a frame can be customized through various options. In addition, buffers can be manually added to and removed from the list of buffers associated with a frame. The package interacts properly with other-buffer and respects changes in buffer ordering made by bury-buffer. From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 'Alp Aker' , 'Eli Zaretskii' , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135594762822011 (code B ref 13225); Wed, 19 Dec 2012 20:08:01 +0000 Received: (at 13225) by debbugs.gnu.org; 19 Dec 2012 20:07:08 +0000 Received: from localhost ([127.0.0.1]:51233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlPv1-0005iy-RM for submit@debbugs.gnu.org; Wed, 19 Dec 2012 15:07:07 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:11342) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlPuz-0005ir-N9 for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 15:07:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLDj/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kHIgABQu5fpBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210373383" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Dec 2012 15:07:01 -0500 Received: by pastel.home (Postfix, from userid 20848) id EF8164E0D7; Wed, 19 Dec 2012 15:07:00 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> Date: Wed, 19 Dec 2012 15:07:00 -0500 In-Reply-To: (Drew Adams's message of "Wed, 19 Dec 2012 11:28:12 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > code: http://www.emacswiki.org/emacs/download/frame-bufs.el No "frame-local" in sight, sorry. But thanks for playing, Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 20:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Stefan Monnier'" Cc: 'Alp Aker' , 'Eli Zaretskii' , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135595057326529 (code B ref 13225); Wed, 19 Dec 2012 20:57:01 +0000 Received: (at 13225) by debbugs.gnu.org; 19 Dec 2012 20:56:13 +0000 Received: from localhost ([127.0.0.1]:51275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlQgW-0006tp-Tq for submit@debbugs.gnu.org; Wed, 19 Dec 2012 15:56:13 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:34078) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlQgU-0006ti-Lw for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 15:56:11 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qBJKu4JB030584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Dec 2012 20:56:05 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qBJKu3v4028289 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Dec 2012 20:56:03 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qBJKu1SX016621; Wed, 19 Dec 2012 14:56:03 -0600 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 19 Dec 2012 12:56:01 -0800 From: "Drew Adams" References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> Date: Wed, 19 Dec 2012 12:56:00 -0800 Message-ID: <0DA30C04141E4A12A83D55A0B51E465B@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac3eJGp3HiUA1iJ9SSOpMKnoeds2oQABo7Lg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.3 (--) > > code: http://www.emacswiki.org/emacs/download/frame-bufs.el > > No "frame-local" in sight, sorry. > But thanks for playing, My bad. Sorry for the distraction. I guess I was confusing a frame's buffer list with frame-local variables. From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 21:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: rudalics@gmx.at, 13225@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135595299130184 (code B ref 13225); Wed, 19 Dec 2012 21:37:01 +0000 Received: (at 13225) by debbugs.gnu.org; 19 Dec 2012 21:36:31 +0000 Received: from localhost ([127.0.0.1]:51291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlRJX-0007qn-JX for submit@debbugs.gnu.org; Wed, 19 Dec 2012 16:36:31 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:57395) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlRJV-0007qf-Ju for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 16:36:30 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MFA00400RWEN200@a-mtaout23.012.net.il> for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 23:36:23 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFA0048JS0NN010@a-mtaout23.012.net.il>; Wed, 19 Dec 2012 23:36:23 +0200 (IST) Date: Wed, 19 Dec 2012 23:36:40 +0200 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83lictohav.fsf@gnu.org> References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.2 (/) > From: Stefan Monnier > Cc: martin rudalics , 13225@debbugs.gnu.org > Date: Wed, 19 Dec 2012 13:30:54 -0500 > > Of course, when we drop frame-local variables this problem > will disappear. You mean, there will be no longer a need to call ensure_selected_frame? > Maybe we should live with the "selected_frame->selected_window != > selected_window" problem until we get rid of frame-local vars. What does this mean in practice? revert your latest changes and delete the assertions that triggered those changes? From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 00:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 'Alp Aker' , 'Eli Zaretskii' , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135596474016289 (code B ref 13225); Thu, 20 Dec 2012 00:53:01 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 00:52:20 +0000 Received: from localhost ([127.0.0.1]:51411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlUN1-0004Eg-P2 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 19:52:19 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:51888) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlUN0-0004EZ-Fg for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 19:52:18 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLDj/2dsb2JhbABEtBGBCIIVAQEEAVYjEAs0EhQYDSQciAAFC7l+kEQDiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210390366" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Dec 2012 19:52:12 -0500 Received: by pastel.home (Postfix, from userid 20848) id 1F0DA4E0D7; Wed, 19 Dec 2012 19:52:12 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <0DA30C04141E4A12A83D55A0B51E465B@us.oracle.com> Date: Wed, 19 Dec 2012 19:52:11 -0500 In-Reply-To: <0DA30C04141E4A12A83D55A0B51E465B@us.oracle.com> (Drew Adams's message of "Wed, 19 Dec 2012 12:56:00 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> > code: http://www.emacswiki.org/emacs/download/frame-bufs.el >> No "frame-local" in sight, sorry. >> But thanks for playing, > My bad. Sorry for the distraction. I guess I was confusing a frame's buffer > list with frame-local variables. FWIW the only use I can still find of frame-local vars is in ECB. Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 02:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: rudalics@gmx.at, 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135596929723481 (code B ref 13225); Thu, 20 Dec 2012 02:09:02 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 02:08:17 +0000 Received: from localhost ([127.0.0.1]:51429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlVYW-00066g-Qw for submit@debbugs.gnu.org; Wed, 19 Dec 2012 21:08:17 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:45100) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlVYV-00066Z-1p for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 21:08:15 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBJy8jEAs0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210396822" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Dec 2012 21:08:08 -0500 Received: by pastel.home (Postfix, from userid 20848) id 377A94E0D7; Wed, 19 Dec 2012 21:08:08 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <83lictohav.fsf@gnu.org> Date: Wed, 19 Dec 2012 21:08:08 -0500 In-Reply-To: <83lictohav.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Dec 2012 23:36:40 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) >> Of course, when we drop frame-local variables this problem >> will disappear. > You mean, there will be no longer a need to call ensure_selected_frame? Yup. >> Maybe we should live with the "selected_frame->selected_window != >> selected_window" problem until we get rid of frame-local vars. > What does this mean in practice? revert your latest changes and delete > the assertions that triggered those changes? Yes. Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.13559975562161 (code B ref 13225); Thu, 20 Dec 2012 10:00:02 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 09:59:16 +0000 Received: from localhost ([127.0.0.1]:51820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlcuJ-0000Yn-CI for submit@debbugs.gnu.org; Thu, 20 Dec 2012 04:59:16 -0500 Received: from mout.gmx.net ([212.227.15.18]:53012) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlcuH-0000Yg-TZ for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 04:59:15 -0500 Received: from mailout-de.gmx.net ([10.1.76.1]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MGUSk-1Tq0cL2Rv6-00DDV0 for <13225@debbugs.gnu.org>; Thu, 20 Dec 2012 10:59:05 +0100 Received: (qmail invoked by alias); 20 Dec 2012 09:59:04 -0000 Received: from 62-47-36-61.adsl.highway.telekom.at (EHLO [62.47.36.61]) [62.47.36.61] by mail.gmx.net (mp001) with SMTP; 20 Dec 2012 10:59:04 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19tDXcOZ+ZtuRdiKRYwPkvoj6IE6E3i3Qws6QR/wh 8hM7k+DdobBea6 Message-ID: <50D2E164.8090300@gmx.at> Date: Thu, 20 Dec 2012 10:59:00 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> In-Reply-To: <83zk1anhzd.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > I can fix this with the kludge shown below, but do we care about yet > another global variable, in addition to selected_window? If we don't > want this, then the only other way I see is to drag this window all > the way down to display_mode_lines through the calling sequences. > (That's assuming that only the mode-line display wants to know about > the _real_ selected_window.) There might still be glitches with the region as Angelo mentioned in the previous thread. But I am surprised that currently the cursor is drawn correctly, that is, a hollow box is drawn on the non-selected frame's window. How is that managed without a kludge similar to the one you describe here? In any case, I think that some crashes Drew reported could be due to the inconsistency Stefan tries to resolve here. So it might be better to go on with the changes and look first whether these crashes disappear. You can always revert them later after we gained some experience. martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 10:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.13559976102302 (code B ref 13225); Thu, 20 Dec 2012 10:01:01 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 10:00:10 +0000 Received: from localhost ([127.0.0.1]:51823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tlcuz-0000Zg-4Q for submit@debbugs.gnu.org; Thu, 20 Dec 2012 05:00:10 -0500 Received: from mout.gmx.net ([212.227.15.19]:54866) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tlcux-0000ZZ-GH for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 04:59:56 -0500 Received: from mailout-de.gmx.net ([10.1.76.38]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0M06kM-1Sxw6x367Q-00uLk6 for <13225@debbugs.gnu.org>; Thu, 20 Dec 2012 10:59:47 +0100 Received: (qmail invoked by alias); 20 Dec 2012 09:59:42 -0000 Received: from 62-47-36-61.adsl.highway.telekom.at (EHLO [62.47.36.61]) [62.47.36.61] by mail.gmx.net (mp038) with SMTP; 20 Dec 2012 10:59:42 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18XmHdFRekXzJrLHjnfhiOxq8O6PQXJdFh4y4icW0 SkrEt+e9bITHyh Message-ID: <50D2E16B.70804@gmx.at> Date: Thu, 20 Dec 2012 10:59:07 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > Of course, when we drop frame-local variables this problem > will disappear. > > Maybe we should live with the "selected_frame->selected_window != > selected_window" problem until we get rid of frame-local vars. I completely fail to understand how frame-local variables are related to the problem at hand :-( martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135601219628483 (code B ref 13225); Thu, 20 Dec 2012 14:04:02 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 14:03:16 +0000 Received: from localhost ([127.0.0.1]:51968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlgiQ-0007PL-Nu for submit@debbugs.gnu.org; Thu, 20 Dec 2012 09:03:15 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:62206) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlgiN-0007PD-M7 for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 09:03:12 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBJy8jEAs0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210418548" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Dec 2012 09:03:02 -0500 Received: by pastel.home (Postfix, from userid 20848) id 20E794E15A; Thu, 20 Dec 2012 09:03:02 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> Date: Thu, 20 Dec 2012 09:03:01 -0500 In-Reply-To: <50D2E16B.70804@gmx.at> (martin rudalics's message of "Thu, 20 Dec 2012 10:59:07 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) >> Of course, when we drop frame-local variables this problem >> will disappear. >> Maybe we should live with the "selected_frame->selected_window != >> selected_window" problem until we get rid of frame-local vars. > I completely fail to understand how frame-local variables are related to > the problem at hand :-( Here's the connection: in order for the redisplay code to use the proper value of (frame-local) variables, it needs to `select-frame' on the frame being redisplayed. Since selected-frame and selected-window should be kept in sync, this means changing the selected-window as well, hence the bug where each frame's selected_window is drawn as if it were the global selected-window (the cursor seems to be unaffected, probably because drawing the cursor is handled specially, so I suspect this cursor code does not obey frame-local variables). Actually, now that I think about it, maybe the right fix is to remove this ensure_selected_frame. It would be one more step towards removing frame-local variables (just like we already disallowed variables that are both buffer-local and frame-local), but still without removing them altogether. After all, I don't think that the existing uses of frame-local vars affect the redisplay. I've just made this change. Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: rudalics@gmx.at, 13225@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.13560208839688 (code B ref 13225); Thu, 20 Dec 2012 16:29:01 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 16:28:03 +0000 Received: from localhost ([127.0.0.1]:52819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TliyY-0002WD-BL for submit@debbugs.gnu.org; Thu, 20 Dec 2012 11:28:02 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:64745) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TliyW-0002Vm-Bu for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 11:28:01 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MFC00L008321V00@a-mtaout20.012.net.il> for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 18:27:50 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFC00KC08EDW030@a-mtaout20.012.net.il>; Thu, 20 Dec 2012 18:27:50 +0200 (IST) Date: Thu, 20 Dec 2012 18:28:08 +0200 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83623wofhj.fsf@gnu.org> References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Stefan Monnier > Cc: Eli Zaretskii , 13225@debbugs.gnu.org > Date: Thu, 20 Dec 2012 09:03:01 -0500 > > the cursor seems to be unaffected, probably because drawing the > cursor is handled specially, so I suspect this cursor code does not > obey frame-local variables. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.166 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4712] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > From: Stefan Monnier > Cc: Eli Zaretskii , 13225@debbugs.gnu.org > Date: Thu, 20 Dec 2012 09:03:01 -0500 > > the cursor seems to be unaffected, probably because drawing the > cursor is handled specially, so I suspect this cursor code does not > obey frame-local variables. The cursor is unaffected, because we use a different test there, see get_window_cursor_type. > Actually, now that I think about it, maybe the right fix is to remove > this ensure_selected_frame. It would be one more step towards removing > frame-local variables (just like we already disallowed variables that > are both buffer-local and frame-local), but still without removing them > altogether. After all, I don't think that the existing uses of > frame-local vars affect the redisplay. > > I've just made this change. Thanks. From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 13225@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135602334313507 (code B ref 13225); Thu, 20 Dec 2012 17:10:02 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 17:09:03 +0000 Received: from localhost ([127.0.0.1]:52869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TljcE-0003Vo-Vh for submit@debbugs.gnu.org; Thu, 20 Dec 2012 12:09:03 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:56581) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TljcC-0003VN-Bo for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 12:09:01 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MFC00900A79TV00@a-mtaout21.012.net.il> for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 19:08:47 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFC009VMAANJNB0@a-mtaout21.012.net.il>; Thu, 20 Dec 2012 19:08:47 +0200 (IST) Date: Thu, 20 Dec 2012 19:09:06 +0200 From: Eli Zaretskii In-reply-to: <50D2E164.8090300@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <8338z0odl9.fsf@gnu.org> References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E164.8090300@gmx.at> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Thu, 20 Dec 2012 10:59:00 +0100 > From: martin rudalics > CC: 13225@debbugs.gnu.org > > > I can fix this with the kludge shown below, but do we care about yet > > another global variable, in addition to selected_window? If we don't > > want this, then the only other way I see is to drag this window all > > the way down to display_mode_lines through the calling sequences. > > (That's assuming that only the mode-line display wants to know about > > the _real_ selected_window.) > > There might still be glitches with the region as Angelo mentioned in the > previous thread. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.169 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Thu, 20 Dec 2012 10:59:00 +0100 > From: martin rudalics > CC: 13225@debbugs.gnu.org > > > I can fix this with the kludge shown below, but do we care about yet > > another global variable, in addition to selected_window? If we don't > > want this, then the only other way I see is to drag this window all > > the way down to display_mode_lines through the calling sequences. > > (That's assuming that only the mode-line display wants to know about > > the _real_ selected_window.) > > There might still be glitches with the region as Angelo mentioned in the > previous thread. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.169 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4822] > Date: Thu, 20 Dec 2012 10:59:00 +0100 > From: martin rudalics > CC: 13225@debbugs.gnu.org > > > I can fix this with the kludge shown below, but do we care about yet > > another global variable, in addition to selected_window? If we don't > > want this, then the only other way I see is to drag this window all > > the way down to display_mode_lines through the calling sequences. > > (That's assuming that only the mode-line display wants to know about > > the _real_ selected_window.) > > There might still be glitches with the region as Angelo mentioned in the > previous thread. Could someone please post a complete precise recipe, starting from "emacs -Q"? I don't think I understand what glitches are we talking about. > But I am surprised that currently the cursor is drawn correctly, > that is, a hollow box is drawn on the non-selected frame's window. > How is that managed without a kludge similar to the one you describe > here? I just explained that in another message here. From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Stefan Monnier , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135602431415062 (code B ref 13225); Thu, 20 Dec 2012 17:26:02 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 17:25:14 +0000 Received: from localhost ([127.0.0.1]:52889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tljrt-0003us-JT for submit@debbugs.gnu.org; Thu, 20 Dec 2012 12:25:13 -0500 Received: from mout.gmx.net ([212.227.17.21]:63611) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tljrp-0003ui-KN for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 12:25:11 -0500 Received: from mailout-de.gmx.net ([10.1.76.31]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MdY5y-1TSz3v21gy-00PLti for <13225@debbugs.gnu.org>; Thu, 20 Dec 2012 18:24:59 +0100 Received: (qmail invoked by alias); 20 Dec 2012 17:24:59 -0000 Received: from 62-47-36-61.adsl.highway.telekom.at (EHLO [62.47.36.61]) [62.47.36.61] by mail.gmx.net (mp031) with SMTP; 20 Dec 2012 18:24:59 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19uyuYTBv9ujvZ1ev7655txd8ptqWRhd2kpQ5qTKK nolPZbz5Ulwxw1 Message-ID: <50D349E6.3080200@gmx.at> Date: Thu, 20 Dec 2012 18:24:54 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <83623wofhj.fsf@gnu.org> In-Reply-To: <83623wofhj.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > The cursor is unaffected, because we use a different test there, see > get_window_cursor_type. Does this mean we could have used something like if (w = XWINDOW (f->selected_window) && f = FRAME_X_DISPLAY_INFO (f)->x_highlight_frame) for checking whether the mode line should indicate that w is the selected window? martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 17:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135602431915078 (code B ref 13225); Thu, 20 Dec 2012 17:26:03 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 17:25:19 +0000 Received: from localhost ([127.0.0.1]:52892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tljry-0003v8-V1 for submit@debbugs.gnu.org; Thu, 20 Dec 2012 12:25:19 -0500 Received: from mout.gmx.net ([212.227.15.18]:53827) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tljrw-0003v1-Rm for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 12:25:18 -0500 Received: from mailout-de.gmx.net ([10.1.76.38]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Mg20J-1TQW5H3wQv-00NRP6 for <13225@debbugs.gnu.org>; Thu, 20 Dec 2012 18:25:07 +0100 Received: (qmail invoked by alias); 20 Dec 2012 17:25:03 -0000 Received: from 62-47-36-61.adsl.highway.telekom.at (EHLO [62.47.36.61]) [62.47.36.61] by mail.gmx.net (mp038) with SMTP; 20 Dec 2012 18:25:03 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19l9HAF2vFlkGjDw4qhb9cChNYrBvobytVRSdajzS 0n969LeYezufrR Message-ID: <50D349EA.9060200@gmx.at> Date: Thu, 20 Dec 2012 18:24:58 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E164.8090300@gmx.at> <8338z0odl9.fsf@gnu.org> In-Reply-To: <8338z0odl9.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) >> There might still be glitches with the region as Angelo mentioned in the >> previous thread. > > Could someone please post a complete precise recipe, starting from > "emacs -Q"? I don't think I understand what glitches are we talking > about. I couldn't reproduce that either. But I suppose that the problem is no more reproducible anyway with Stefan's last change. martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 17:26:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135602432615100 (code B ref 13225); Thu, 20 Dec 2012 17:26:04 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 17:25:26 +0000 Received: from localhost ([127.0.0.1]:52895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tljs5-0003vU-Ma for submit@debbugs.gnu.org; Thu, 20 Dec 2012 12:25:26 -0500 Received: from mout.gmx.net ([212.227.15.19]:64094) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tljs0-0003vF-0h for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 12:25:22 -0500 Received: from mailout-de.gmx.net ([10.1.76.37]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MARmu-1TwDS21vQ2-00BYx2 for <13225@debbugs.gnu.org>; Thu, 20 Dec 2012 18:25:08 +0100 Received: (qmail invoked by alias); 20 Dec 2012 17:25:08 -0000 Received: from 62-47-36-61.adsl.highway.telekom.at (EHLO [62.47.36.61]) [62.47.36.61] by mail.gmx.net (mp037) with SMTP; 20 Dec 2012 18:25:08 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/aqnUTY6HaEltUu5JdnlNxlVpSftJoY8z1YVpCX0 h+0wyZPB69qRs2 Message-ID: <50D349EF.9020003@gmx.at> Date: Thu, 20 Dec 2012 18:25:03 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > Here's the connection: in order for the redisplay code to use the proper > value of (frame-local) variables, it needs to `select-frame' on the > frame being redisplayed. Ahh, sure. > Actually, now that I think about it, maybe the right fix is to remove > this ensure_selected_frame. It would be one more step towards removing > frame-local variables (just like we already disallowed variables that > are both buffer-local and frame-local), but still without removing them > altogether. After all, I don't think that the existing uses of > frame-local vars affect the redisplay. > > I've just made this change. So we can be sure that redisplay now nowhere changes the selected frame or the selected window? martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: monnier@iro.umontreal.ca, 13225@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135602502316204 (code B ref 13225); Thu, 20 Dec 2012 17:38:02 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 17:37:03 +0000 Received: from localhost ([127.0.0.1]:52911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tlk3K-0004DI-Mi for submit@debbugs.gnu.org; Thu, 20 Dec 2012 12:37:02 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:59410) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tlk3I-0004Co-7i for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 12:37:01 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MFC00900B8LXY00@a-mtaout21.012.net.il> for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 19:36:49 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFC009QEBLDUJ50@a-mtaout21.012.net.il>; Thu, 20 Dec 2012 19:36:49 +0200 (IST) Date: Thu, 20 Dec 2012 19:37:08 +0200 From: Eli Zaretskii In-reply-to: <50D349E6.3080200@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <83y5gsmxq3.fsf@gnu.org> References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <83623wofhj.fsf@gnu.org> <50D349E6.3080200@gmx.at> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Thu, 20 Dec 2012 18:24:54 +0100 > From: martin rudalics > CC: Stefan Monnier , 13225@debbugs.gnu.org > > > The cursor is unaffected, because we use a different test there, see > > get_window_cursor_type. > > Does this mean we could have used something like > > if (w = XWINDOW (f->selected_window) > && f = FRAME_X_DISPLAY_INFO (f)->x_highlight_frame) > > for checking whether the mode line should indicate that w is the > selected window? [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.169 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4597] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > Date: Thu, 20 Dec 2012 18:24:54 +0100 > From: martin rudalics > CC: Stefan Monnier , 13225@debbugs.gnu.org > > > The cursor is unaffected, because we use a different test there, see > > get_window_cursor_type. > > Does this mean we could have used something like > > if (w = XWINDOW (f->selected_window) > && f = FRAME_X_DISPLAY_INFO (f)->x_highlight_frame) > > for checking whether the mode line should indicate that w is the > selected window? Maybe, I'm not sure. There's this note in the comments to x_highlight_frame member: /* The frame which currently has the visual highlight, and should get keyboard input (other sorts of input have the frame encoded in the event). It points to the X focus frame's selected window's frame. It differs from x_focus_frame when we're using a global ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ minibuffer. */ ^^^^^^^^^^ How is (or should be) the mode line displayed when input goes to a "global minibuffer"? From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2012 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135602688519069 (code B ref 13225); Thu, 20 Dec 2012 18:09:01 +0000 Received: (at 13225) by debbugs.gnu.org; 20 Dec 2012 18:08:05 +0000 Received: from localhost ([127.0.0.1]:52930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlkXN-0004xW-Jn for submit@debbugs.gnu.org; Thu, 20 Dec 2012 13:08:05 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:43365) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlkXL-0004xN-Gv for 13225@debbugs.gnu.org; Thu, 20 Dec 2012 13:08:03 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBJy8jEAs0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210440059" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Dec 2012 13:07:53 -0500 Received: by pastel.home (Postfix, from userid 20848) id 57BF858EA5; Thu, 20 Dec 2012 13:07:53 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> Date: Thu, 20 Dec 2012 13:07:53 -0500 In-Reply-To: <50D349EF.9020003@gmx.at> (martin rudalics's message of "Thu, 20 Dec 2012 18:25:03 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) >> I've just made this change. > So we can be sure that redisplay now nowhere changes the selected frame > or the selected window? No: it is still changed while computing the mode-line, but that's been the case for a long time now (the recent change in this area is to not only change selected_frame and selected_window but also selected_frame->selected_window so that we preserve the invariant that selected_windows = selected_frame->selected_window). Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Dec 2012 09:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: monnier@iro.umontreal.ca, 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135608137723778 (code B ref 13225); Fri, 21 Dec 2012 09:17:01 +0000 Received: (at 13225) by debbugs.gnu.org; 21 Dec 2012 09:16:17 +0000 Received: from localhost ([127.0.0.1]:53488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlyiH-0006BS-9Y for submit@debbugs.gnu.org; Fri, 21 Dec 2012 04:16:17 -0500 Received: from mout.gmx.net ([212.227.17.20]:49529) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlyiE-0006BG-UT for 13225@debbugs.gnu.org; Fri, 21 Dec 2012 04:16:15 -0500 Received: from mailout-de.gmx.net ([10.1.76.71]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0Lmxbm-1T9d9R2H1g-00h6EV for <13225@debbugs.gnu.org>; Fri, 21 Dec 2012 10:16:01 +0100 Received: (qmail invoked by alias); 21 Dec 2012 09:16:00 -0000 Received: from 62-47-34-50.adsl.highway.telekom.at (EHLO [62.47.34.50]) [62.47.34.50] by mail.gmx.net (mp071) with SMTP; 21 Dec 2012 10:16:00 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+NNEx678KNiBiTpmlEkCCbooGpXY4kF1ij2XRYOI EqDHBmzsZoQOXf Message-ID: <50D428CA.5070806@gmx.at> Date: Fri, 21 Dec 2012 10:15:54 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <83623wofhj.fsf@gnu.org> <50D349E6.3080200@gmx.at> <83y5gsmxq3.fsf@gnu.org> In-Reply-To: <83y5gsmxq3.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > There's this note in the comments to > x_highlight_frame member: > > /* The frame which currently has the visual highlight, and should get > keyboard input (other sorts of input have the frame encoded in the > event). It points to the X focus frame's selected window's > frame. It differs from x_focus_frame when we're using a global > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > minibuffer. */ > ^^^^^^^^^^ > > How is (or should be) the mode line displayed when input goes to a > "global minibuffer"? My question was probably silly: We highlight the cursor as active when the associated frame is currently visually highlighted by the window manager. And we highlight the mode line when the associated window is the selected window, regardless of whether its frame is currently visually highlighted by the window manager. Is that interpretation correct? Then indeed we should not de-highlight a mode line when its frame is not highlighted because we would lose some useful feedback. martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Dec 2012 09:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135608138423796 (code B ref 13225); Fri, 21 Dec 2012 09:17:02 +0000 Received: (at 13225) by debbugs.gnu.org; 21 Dec 2012 09:16:24 +0000 Received: from localhost ([127.0.0.1]:53491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlyiN-0006Bk-Ss for submit@debbugs.gnu.org; Fri, 21 Dec 2012 04:16:24 -0500 Received: from mout.gmx.net ([212.227.17.20]:56976) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlyiL-0006Bc-LJ for 13225@debbugs.gnu.org; Fri, 21 Dec 2012 04:16:22 -0500 Received: from mailout-de.gmx.net ([10.1.76.28]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0LqGOk-1T8XDk2cGe-00ds0h for <13225@debbugs.gnu.org>; Fri, 21 Dec 2012 10:16:08 +0100 Received: (qmail invoked by alias); 21 Dec 2012 09:16:08 -0000 Received: from 62-47-34-50.adsl.highway.telekom.at (EHLO [62.47.34.50]) [62.47.34.50] by mail.gmx.net (mp028) with SMTP; 21 Dec 2012 10:16:08 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX197iHBdl6h7jO53mc5lfNKvXBB3+Krl3SBokbCrsS jeSvADvMb4U6SM Message-ID: <50D428D2.9090105@gmx.at> Date: Fri, 21 Dec 2012 10:16:02 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) >> So we can be sure that redisplay now nowhere changes the selected frame >> or the selected window? > > No: it is still changed while computing the mode-line, ... and this is good because otherwise Lisp code would have problems to get the window whose mode line shall be displayed, I presume ... > but that's been > the case for a long time now (the recent change in this area is to not > only change selected_frame and selected_window but also > selected_frame->selected_window so that we preserve the invariant that > selected_windows = selected_frame->selected_window). ... and while we compute the mode line we don't care whether selected_frame->selected_window equals selected_window. Wouldn't it be more correct to handle this as in run_window_configuration_change_hook? martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Dec 2012 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: monnier@iro.umontreal.ca, 13225@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135608256325551 (code B ref 13225); Fri, 21 Dec 2012 09:37:02 +0000 Received: (at 13225) by debbugs.gnu.org; 21 Dec 2012 09:36:03 +0000 Received: from localhost ([127.0.0.1]:53504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tlz1P-0006e4-5M for submit@debbugs.gnu.org; Fri, 21 Dec 2012 04:36:03 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:64313) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tlz1M-0006dU-4l for 13225@debbugs.gnu.org; Fri, 21 Dec 2012 04:36:01 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MFD00D00JZ0B800@a-mtaout22.012.net.il> for 13225@debbugs.gnu.org; Fri, 21 Dec 2012 11:35:33 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFD00DBSJZ82880@a-mtaout22.012.net.il>; Fri, 21 Dec 2012 11:35:32 +0200 (IST) Date: Fri, 21 Dec 2012 11:35:18 +0200 From: Eli Zaretskii In-reply-to: <50D428CA.5070806@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <83ehijn3xl.fsf@gnu.org> References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <83623wofhj.fsf@gnu.org> <50D349E6.3080200@gmx.at> <83y5gsmxq3.fsf@gnu.org> <50D428CA.5070806@gmx.at> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Fri, 21 Dec 2012 10:15:54 +0100 > From: martin rudalics > CC: monnier@iro.umontreal.ca, 13225@debbugs.gnu.org > > > There's this note in the comments to > > x_highlight_frame member: > > > > /* The frame which currently has the visual highlight, and should get > > keyboard input (other sorts of input have the frame encoded in the > > event). It points to the X focus frame's selected window's > > frame. It differs from x_focus_frame when we're using a global > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > minibuffer. */ > > ^^^^^^^^^^ > > > > How is (or should be) the mode line displayed when input goes to a > > "global minibuffer"? > > My question was probably silly: We highlight the cursor as active when > the associated frame is currently visually highlighted by the window > manager. And we highlight the mode line when the associated window is > the selected window, regardless of whether its frame is currently > visually highlighted by the window manager. Is that interpretation > correct? [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4998] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > Date: Fri, 21 Dec 2012 10:15:54 +0100 > From: martin rudalics > CC: monnier@iro.umontreal.ca, 13225@debbugs.gnu.org > > > There's this note in the comments to > > x_highlight_frame member: > > > > /* The frame which currently has the visual highlight, and should get > > keyboard input (other sorts of input have the frame encoded in the > > event). It points to the X focus frame's selected window's > > frame. It differs from x_focus_frame when we're using a global > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > minibuffer. */ > > ^^^^^^^^^^ > > > > How is (or should be) the mode line displayed when input goes to a > > "global minibuffer"? > > My question was probably silly: We highlight the cursor as active when > the associated frame is currently visually highlighted by the window > manager. And we highlight the mode line when the associated window is > the selected window, regardless of whether its frame is currently > visually highlighted by the window manager. Is that interpretation > correct? I think so. But I also think that the currently highlighted frame is mostly identical to the selected frame, except when minbuffer-only frames are in use. And recall that the problems with mismatches between the selected window and the selected frame, which started all this quest for having them in sync, and introduced assertions whose violations are being reported ever since, happen precisely in configurations where the minbuffer is a separate frame. > Then indeed we should not de-highlight a mode line when its frame is > not highlighted because we would lose some useful feedback. Maybe, but that could be a surprise to users, who are used to different behavior. From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Dec 2012 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: monnier@iro.umontreal.ca, 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135609991922385 (code B ref 13225); Fri, 21 Dec 2012 14:26:01 +0000 Received: (at 13225) by debbugs.gnu.org; 21 Dec 2012 14:25:19 +0000 Received: from localhost ([127.0.0.1]:53669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tm3X6-0005om-Qn for submit@debbugs.gnu.org; Fri, 21 Dec 2012 09:25:13 -0500 Received: from mout.gmx.net ([212.227.17.20]:49924) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tm3X1-0005oO-Ua for 13225@debbugs.gnu.org; Fri, 21 Dec 2012 09:25:02 -0500 Received: from mailout-de.gmx.net ([10.1.76.33]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MAiyD-1Txr5a2g2N-00Btif for <13225@debbugs.gnu.org>; Fri, 21 Dec 2012 15:24:45 +0100 Received: (qmail invoked by alias); 21 Dec 2012 14:24:45 -0000 Received: from 62-47-34-50.adsl.highway.telekom.at (EHLO [62.47.34.50]) [62.47.34.50] by mail.gmx.net (mp033) with SMTP; 21 Dec 2012 15:24:45 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19ON+4rsDhOkxdSMkQygOOVOcftSgfqVDUT7xaNiy mRZHkEkRNqBbSY Message-ID: <50D47127.9040201@gmx.at> Date: Fri, 21 Dec 2012 15:24:39 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <83623wofhj.fsf@gnu.org> <50D349E6.3080200@gmx.at> <83y5gsmxq3.fsf@gnu.org> <50D428CA.5070806@gmx.at> <83ehijn3xl.fsf@gnu.org> In-Reply-To: <83ehijn3xl.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) >> Then indeed we should not de-highlight a mode line when its frame is >> not highlighted because we would lose some useful feedback. > > Maybe, but that could be a surprise to users, who are used to > different behavior. Sorry, we probably miscommunicated. What I described should have reflected the status quo: When the minibuffer is active (regardless of whether it's standalone, global, or on the only visible frame), that fact is communicated by giving it the active cursor. At the same time, the mode line of the window that was selected before the minibuffer became active is still highlighted as active. Is that correct? martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Dec 2012 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: monnier@iro.umontreal.ca, 13225@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135610103623986 (code B ref 13225); Fri, 21 Dec 2012 14:44:02 +0000 Received: (at 13225) by debbugs.gnu.org; 21 Dec 2012 14:43:56 +0000 Received: from localhost ([127.0.0.1]:53692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tm3pL-0006Ep-WE for submit@debbugs.gnu.org; Fri, 21 Dec 2012 09:43:56 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:57533) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tm3pJ-0006Eg-44 for 13225@debbugs.gnu.org; Fri, 21 Dec 2012 09:43:54 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MFD00F00Y3IFW00@a-mtaout21.012.net.il> for 13225@debbugs.gnu.org; Fri, 21 Dec 2012 16:43:37 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFD00FCUY8MFG10@a-mtaout21.012.net.il>; Fri, 21 Dec 2012 16:43:34 +0200 (IST) Date: Fri, 21 Dec 2012 16:43:21 +0200 From: Eli Zaretskii In-reply-to: <50D47127.9040201@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <83pq23tqie.fsf@gnu.org> References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <83623wofhj.fsf@gnu.org> <50D349E6.3080200@gmx.at> <83y5gsmxq3.fsf@gnu.org> <50D428CA.5070806@gmx.at> <83ehijn3xl.fsf@gnu.org> <50D47127.9040201@gmx.at> X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Fri, 21 Dec 2012 15:24:39 +0100 > From: martin rudalics > CC: monnier@iro.umontreal.ca, 13225@debbugs.gnu.org > > When the minibuffer is active (regardless of whether it's > standalone, global, or on the only visible frame), that fact is > communicated by giving it the active cursor. At the same time, the > mode line of the window that was selected before the minibuffer > became active is still highlighted as active. Is that correct? Yes, of course. Nothing else would make sense to me. From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2012 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135619157716320 (code B ref 13225); Sat, 22 Dec 2012 15:53:01 +0000 Received: (at 13225) by debbugs.gnu.org; 22 Dec 2012 15:52:57 +0000 Received: from localhost ([127.0.0.1]:55679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmRNg-0004FA-Ky for submit@debbugs.gnu.org; Sat, 22 Dec 2012 10:52:57 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:6815) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmRNf-0004F3-47 for 13225@debbugs.gnu.org; Sat, 22 Dec 2012 10:52:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBJy8jBQsLNBIUGA0kiBwFugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210562105" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Dec 2012 10:52:34 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6C15658EA5; Sat, 22 Dec 2012 10:52:33 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> <50D428D2.9090105@gmx.at> Date: Sat, 22 Dec 2012 10:52:33 -0500 In-Reply-To: <50D428D2.9090105@gmx.at> (martin rudalics's message of "Fri, 21 Dec 2012 10:16:02 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > ... and while we compute the mode line we don't care whether > selected_frame-> selected_window equals selected_window. What makes you think so? > Wouldn't it be more correct to handle this as in > run_window_configuration_change_hook? I don't know how run_window_configuration_change_hook handles "this". Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2012 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135619235317544 (code B ref 13225); Sat, 22 Dec 2012 16:06:02 +0000 Received: (at 13225) by debbugs.gnu.org; 22 Dec 2012 16:05:53 +0000 Received: from localhost ([127.0.0.1]:55687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmRaC-0004Yu-NZ for submit@debbugs.gnu.org; Sat, 22 Dec 2012 11:05:53 -0500 Received: from mout.gmx.net ([212.227.15.19]:61193) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmRaA-0004Yn-T5 for 13225@debbugs.gnu.org; Sat, 22 Dec 2012 11:05:51 -0500 Received: from mailout-de.gmx.net ([10.1.76.16]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0McTJ0-1TUmAU1JOi-00Hhzo for <13225@debbugs.gnu.org>; Sat, 22 Dec 2012 17:05:30 +0100 Received: (qmail invoked by alias); 22 Dec 2012 16:05:30 -0000 Received: from 62-47-46-229.adsl.highway.telekom.at (EHLO [62.47.46.229]) [62.47.46.229] by mail.gmx.net (mp016) with SMTP; 22 Dec 2012 17:05:30 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+n3M4sMdancDRJCLMSqT9tmxkoqsHwbXYPOtGf4q fpXqVKJ+EqZS5b Message-ID: <50D5DA43.1070008@gmx.at> Date: Sat, 22 Dec 2012 17:05:23 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> <50D428D2.9090105@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) >> ... and while we compute the mode line we don't care whether >> selected_frame-> selected_window equals selected_window. > > What makes you think so? So we do? >> Wouldn't it be more correct to handle this as in >> run_window_configuration_change_hook? > > I don't know how run_window_configuration_change_hook handles "this". Hmmm... that's your code so I can only provide my interpretation of it: run_window_configuration_change_hook uses select_window_norecord (which preserves the selected_frame->selected_window = selected_window property we, according to your question above, do care about. display_mode_lines does only XSETWINDOW (selected_window, w) which does not preserve that property IIUC. martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2012 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135619541222252 (code B ref 13225); Sat, 22 Dec 2012 16:57:02 +0000 Received: (at 13225) by debbugs.gnu.org; 22 Dec 2012 16:56:52 +0000 Received: from localhost ([127.0.0.1]:55721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmSNY-0005mr-0n for submit@debbugs.gnu.org; Sat, 22 Dec 2012 11:56:52 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:37361) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmSNW-0005ml-T8 for 13225@debbugs.gnu.org; Sat, 22 Dec 2012 11:56:51 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBJy8jBQsLNBIUGA0kiBwFugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210564063" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Dec 2012 11:56:29 -0500 Received: by pastel.home (Postfix, from userid 20848) id 2569258EA5; Sat, 22 Dec 2012 11:56:28 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> <50D428D2.9090105@gmx.at> <50D5DA43.1070008@gmx.at> Date: Sat, 22 Dec 2012 11:56:28 -0500 In-Reply-To: <50D5DA43.1070008@gmx.at> (martin rudalics's message of "Sat, 22 Dec 2012 17:05:23 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >>> ... and while we compute the mode line we don't care whether >>> selected_frame-> selected_window equals selected_window. >> What makes you think so? > So we do? I believe we always do, especially when (potentially) running Elisp code, which can in turn run pretty much any code. >>> Wouldn't it be more correct to handle this as in >>> run_window_configuration_change_hook? >> I don't know how run_window_configuration_change_hook handles "this". > Hmmm... that's your code so I can only provide my interpretation of it: > run_window_configuration_change_hook uses select_window_norecord (which > preserves the selected_frame->selected_window = selected_window property > we, according to your question above, do care about. display_mode_lines > does only XSETWINDOW (selected_window, w) which does not preserve that > property IIUC. Oh, that's what you mean. Yes, maybe we could/should just use select_window(_norecord) (which is not just the way run_window_configuration_change_hook does it, but is more generally the normal way to do it). My recent change already brings display_mode_lines closer to what select_window does. Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2012 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135619815726648 (code B ref 13225); Sat, 22 Dec 2012 17:43:02 +0000 Received: (at 13225) by debbugs.gnu.org; 22 Dec 2012 17:42:37 +0000 Received: from localhost ([127.0.0.1]:55754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmT5o-0006vk-O7 for submit@debbugs.gnu.org; Sat, 22 Dec 2012 12:42:37 -0500 Received: from mout.gmx.net ([212.227.15.19]:60397) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmT5m-0006vc-D3 for 13225@debbugs.gnu.org; Sat, 22 Dec 2012 12:42:35 -0500 Received: from mailout-de.gmx.net ([10.1.76.1]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0Ldb0m-1TMRvT1pis-00igSI for <13225@debbugs.gnu.org>; Sat, 22 Dec 2012 18:42:13 +0100 Received: (qmail invoked by alias); 22 Dec 2012 17:42:12 -0000 Received: from 62-47-46-229.adsl.highway.telekom.at (EHLO [62.47.46.229]) [62.47.46.229] by mail.gmx.net (mp001) with SMTP; 22 Dec 2012 18:42:12 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19e2qMzY7RekhLcgkTHHZOuEA+7cEGp4qY48RnMwf Y1b2qjlQpRSTzR Message-ID: <50D5F0EC.9060303@gmx.at> Date: Sat, 22 Dec 2012 18:42:04 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> <50D428D2.9090105@gmx.at> <50D5DA43.1070008@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > I believe we always do, especially when (potentially) running Elisp > code, which can in turn run pretty much any code. Who am I to object? I thought the purpose of this was that a user can, in her mode line code, call `frame-selected-window' to check whether the currently selected window really is the selected window (at least in a one-frame environment). If we synchronize the frame's selected window too, there's no way to get that any more. Not that such a kludgy behavior seems reasonable ... > Oh, that's what you mean. Yes, maybe we could/should just use > select_window(_norecord) (which is not just the way > run_window_configuration_change_hook does it, If the function on the hook is local to the window's buffer, it does precisely that. Which is not entirely kosher because that function will have no idea about the really selected window but we always have the global hook for that. > but is more generally the > normal way to do it). My recent change already brings display_mode_lines > closer to what select_window does. IIUC display_mode_lines contains the only Lisp running code where the selected window does not necessarily equal the selected window of its frame. So it might be worth to fix this. martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Dec 2012 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135627009022605 (code B ref 13225); Sun, 23 Dec 2012 13:42:02 +0000 Received: (at 13225) by debbugs.gnu.org; 23 Dec 2012 13:41:30 +0000 Received: from localhost ([127.0.0.1]:56285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tmlo1-0005sX-SY for submit@debbugs.gnu.org; Sun, 23 Dec 2012 08:41:30 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:7336) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tmlnz-0005sO-5Q for 13225@debbugs.gnu.org; Sun, 23 Dec 2012 08:41:27 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210595104" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Dec 2012 08:41:01 -0500 Received: by pastel.home (Postfix, from userid 20848) id 2E4C558EA5; Sun, 23 Dec 2012 08:41:01 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> <50D428D2.9090105@gmx.at> <50D5DA43.1070008@gmx.at> <50D5F0EC.9060303@gmx.at> Date: Sun, 23 Dec 2012 08:41:00 -0500 In-Reply-To: <50D5F0EC.9060303@gmx.at> (martin rudalics's message of "Sat, 22 Dec 2012 18:42:04 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) >> I believe we always do, especially when (potentially) running Elisp >> code, which can in turn run pretty much any code. > Who am I to object? I thought the purpose of this was that a user can, > in her mode line code, call `frame-selected-window' to check whether the > currently selected window really is the selected window (at least in a > one-frame environment). If we want that, we'll need some other way to get that info, since as you point out it only worked for single-frame settings. > IIUC display_mode_lines contains the only Lisp running code where the ^^ ed > selected window does not necessarily equal the selected window of its > frame. Yes. > So it might be worth to fix this. That's why I did it. Stefan From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Dec 2012 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135627145524695 (code B ref 13225); Sun, 23 Dec 2012 14:05:01 +0000 Received: (at 13225) by debbugs.gnu.org; 23 Dec 2012 14:04:15 +0000 Received: from localhost ([127.0.0.1]:56310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tmm9z-0006QC-OK for submit@debbugs.gnu.org; Sun, 23 Dec 2012 09:04:13 -0500 Received: from mout.gmx.net ([212.227.15.19]:52375) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tmm9x-0006Q5-Kn for 13225@debbugs.gnu.org; Sun, 23 Dec 2012 09:04:10 -0500 Received: from mailout-de.gmx.net ([10.1.76.20]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0LZk7m-1TNdX13EdQ-00lX5C for <13225@debbugs.gnu.org>; Sun, 23 Dec 2012 15:03:43 +0100 Received: (qmail invoked by alias); 23 Dec 2012 14:03:43 -0000 Received: from 62-47-62-46.adsl.highway.telekom.at (EHLO [62.47.62.46]) [62.47.62.46] by mail.gmx.net (mp020) with SMTP; 23 Dec 2012 15:03:43 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18HbAw/ajMHsBWlvImLEMFPm5TmcOzhjAvMDciFFF x3akg8xSu33kAH Message-ID: <50D70F36.1020103@gmx.at> Date: Sun, 23 Dec 2012 15:03:34 +0100 From: martin rudalics MIME-Version: 1.0 References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> <50D428D2.9090105@gmx.at> <50D5DA43.1070008@gmx.at> <50D5F0EC.9060303@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) >> IIUC display_mode_lines contains the only Lisp running code where the > ^^ > ed > >> selected window does not necessarily equal the selected window of its >> frame. > > Yes. > >> So it might be worth to fix this. > > That's why I did it. Sorry. I was probably looking at the version in the release branch. Maybe you should move it there, though. martin From unknown Sun Jun 22 11:40:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Dec 2012 15:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Eli Zaretskii , 13225@debbugs.gnu.org Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.13562772621432 (code B ref 13225); Sun, 23 Dec 2012 15:42:01 +0000 Received: (at 13225) by debbugs.gnu.org; 23 Dec 2012 15:41:02 +0000 Received: from localhost ([127.0.0.1]:56926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tmnfh-0000N3-VQ for submit@debbugs.gnu.org; Sun, 23 Dec 2012 10:41:02 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:51820) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tmnff-0000Mf-DP for 13225@debbugs.gnu.org; Sun, 23 Dec 2012 10:40:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210598530" Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Dec 2012 10:40:33 -0500 Received: by pastel.home (Postfix, from userid 20848) id A7F1459067; Sun, 23 Dec 2012 10:40:32 -0500 (EST) From: Stefan Monnier Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> <50D428D2.9090105@gmx.at> <50D5DA43.1070008@gmx.at> <50D5F0EC.9060303@gmx.at> <50D70F36.1020103@gmx.at> Date: Sun, 23 Dec 2012 10:40:31 -0500 In-Reply-To: <50D70F36.1020103@gmx.at> (martin rudalics's message of "Sun, 23 Dec 2012 15:03:34 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) > Sorry. I was probably looking at the version in the release branch. > Maybe you should move it there, though. It's definitely not fixing a recent regression. These bugs have been with us for a very long time. Stefan From unknown Sun Jun 22 11:40:20 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: martin rudalics Subject: bug#13225: closed (Re: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face) Message-ID: References: <50D176DF.4080102@gmx.at> X-Gnu-PR-Message: they-closed 13225 X-Gnu-PR-Package: emacs Reply-To: 13225@debbugs.gnu.org Date: Fri, 04 Jan 2013 08:29:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1357288143-21160-1" This is a multi-part message in MIME format... ------------=_1357288143-21160-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13225: 24.3.50; Non-selected window has not mode-line-inactive face which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13225@debbugs.gnu.org. --=20 13225: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13225 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1357288143-21160-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13225-done) by debbugs.gnu.org; 4 Jan 2013 08:28:35 +0000 Received: from localhost ([127.0.0.1]:42596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tr2dn-0005UZ-2V for submit@debbugs.gnu.org; Fri, 04 Jan 2013 03:28:35 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:47897) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tr2dk-0005UM-EV for 13225-done@debbugs.gnu.org; Fri, 04 Jan 2013 03:28:33 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Tr2dd-0006KO-En; Fri, 04 Jan 2013 03:28:25 -0500 From: Glenn Morris To: 13225-done@debbugs.gnu.org Subject: Re: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face References: <50D176DF.4080102@gmx.at> X-Spook: brigand Dick Cheney UMTS Montenegro BCCI Belknap defense X-Ran: 5XJ{8cRS"md3|v#{K$ffs;/QlIqMnMY)}y-b,HmI:-Nz~/q]DU9R8^t`y (martin rudalics's message of "Wed, 19 Dec 2012 09:12:15 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13225-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) martin rudalics wrote: > With emacs -Q do C-x 5 2. The mode lines of both windows appear in > `mode-line' face, regardless of which window is selected. AFAICS, this is fixed. The remainder of the discussion seems too free-form to make a useful bug report, but please open a new one(s) summarising the issues if you disagree (or reopen this one). ------------=_1357288143-21160-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Dec 2012 08:12:28 +0000 Received: from localhost ([127.0.0.1]:49896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlElP-0003nG-W0 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:12:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36308) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlElN-0003n9-W9 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:12:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlElL-0006Dy-Q4 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:12:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlElL-0006Dt-Nt for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:12:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlElK-0001qj-OO for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 03:12:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlElH-0006Cz-4o for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 03:12:22 -0500 Received: from mout.gmx.net ([212.227.15.18]:61822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlElG-0006Ct-SK for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 03:12:19 -0500 Received: from mailout-de.gmx.net ([10.1.76.24]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Mg20J-1TPySL4BPx-00NR9u for ; Wed, 19 Dec 2012 09:12:17 +0100 Received: (qmail invoked by alias); 19 Dec 2012 08:12:16 -0000 Received: from 62-47-39-246.adsl.highway.telekom.at (EHLO [62.47.39.246]) [62.47.39.246] by mail.gmx.net (mp024) with SMTP; 19 Dec 2012 09:12:16 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/JIYRKP7TJqY5ZFnSJKP4NHVkSOH0tcH4n3ZrSdQ PEZnMlKBsF+N/q Message-ID: <50D176DF.4080102@gmx.at> Date: Wed, 19 Dec 2012 09:12:15 +0100 From: martin rudalics MIME-Version: 1.0 To: Bug-Gnu-Emacs Subject: 24.3.50; Non-selected window has not mode-line-inactive face Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) With emacs -Q do C-x 5 2. The mode lines of both windows appear in `mode-line' face, regardless of which window is selected. This contradicts the Elisp manual which says: The selected window's mode line is usually displayed in a different color using the face `mode-line'. Other windows' mode lines appear in the face `mode-line-inactive' instead. In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2012-12-19 on MACHNO Bzr revision: 111265 eliz@gnu.org-20121218190556-x9wmq083vwecgu0f Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt' martin ------------=_1357288143-21160-1--