From unknown Fri Aug 15 20:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13224: 24.3.50; [PATCH] Variable `icomplete-prospects-height' is no longer honored Resent-From: Wesley Dawson Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 08:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 13224@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135590430713938 (code B ref -1); Wed, 19 Dec 2012 08:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2012 08:05:07 +0000 Received: from localhost ([127.0.0.1]:49891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlEeI-0003ck-FA for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:05:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43752) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlCQJ-0000HS-46 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 00:42:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlCQG-0005vH-70 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 00:42:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlCQG-0005vD-3l for submit@debbugs.gnu.org; Wed, 19 Dec 2012 00:42:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlCQD-0000AY-D5 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 00:42:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlCQA-0005ut-Ve for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 00:42:25 -0500 Received: from karen.lavabit.com ([72.249.41.33]:35188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlCQA-0005up-Pg for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 00:42:22 -0500 Received: from e.earth.lavabit.com (e.earth.lavabit.com [192.168.111.14]) by karen.lavabit.com (Postfix) with ESMTP id A348A11BBAA for ; Tue, 18 Dec 2012 23:42:21 -0600 (CST) Received: from sirith (c-24-130-13-84.hsd1.ca.comcast.net [24.130.13.84]) by lavabit.com with ESMTP id X3L5CB95MHXU for ; Tue, 18 Dec 2012 23:42:21 -0600 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=UGyMbq74YzmUK7SS2YpPJTnTiNzNhU2942S1vknuMBjKZ4m/rBZrIyes4EFN5K8WJ8fpdfr5DiRbkKwNgqRpcsQrxzJdD7f/xfkvnsDKj8JDTm+BXdjbuCY5O8ZSQUSRtSw7aNLP+eozzAdqzmtJtvLqp1Pn+24jZob780GXcj4=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; From: Wesley Dawson Date: Tue, 18 Dec 2012 21:41:13 -0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Mailman-Approved-At: Wed, 19 Dec 2012 03:05:04 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain M-x icomplete-mode M-x set-variable icomplete-prospects-height 1 M-x a (the candidates list takes up two lines in the minibuffer) Here's a patch to make icomplete honor `icomplete-prospects-height' again, which it hasn't since the introduction of `icomplete-separator' (revno: 111031). About formatting: the source appears to mix tabs and spaces for indentation quite freely; I didn't attempt to fix this and went with what emacs -Q did for formatting. * lisp/icomplete.el (icomplete-completions): Fix to honor `icomplete-prospects-height' again. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=patch.diff Content-Transfer-Encoding: quoted-printable Content-Description: Fix to honor `icomplete-prospects-height' again. =3D=3D=3D modified file 'lisp/icomplete.el' --- lisp/icomplete.el 2012-12-17 19:43:55 +0000 +++ lisp/icomplete.el 2012-12-19 04:25:35 +0000 @@ -343,8 +343,10 @@ (t (concat "=E2=80=A6" (substring most compare)))) close-bracket))) ;;"-prospects" - more than one candidate - (prospects-len (+ (length determ) 6 ;; take {,...} into account - (string-width (buffer-string)))) + (prospects-len (+ (length determ) + (string-width icomplete-separator) + 3 ;; take {=E2=80=A6} into account + (string-width (buffer-string)))) (prospects-max ;; Max total length to use, including the minibuffer content. (* (+ icomplete-prospects-height @@ -375,7 +377,9 @@ (cond ((string-equal comp "") (setq most-is-exact t)) ((member comp prospects)) (t (setq prospects-len - (+ (string-width comp) 1 prospects-len)) + (+ (string-width comp) + (string-width icomplete-separator) + prospects-len)) (if (< prospects-len prospects-max) (push comp prospects) (setq limit t)))))) --=-=-=-- From unknown Fri Aug 15 20:53:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Wesley Dawson Subject: bug#13224: closed (Re: bug#13224: 24.3.50; [PATCH] Variable `icomplete-prospects-height' is no longer honored) Message-ID: References: X-Gnu-PR-Message: they-closed 13224 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 13224@debbugs.gnu.org Date: Fri, 04 Jan 2013 08:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1357287722-20475-1" This is a multi-part message in MIME format... ------------=_1357287722-20475-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13224: 24.3.50; [PATCH] Variable `icomplete-prospects-height' is no longer= honored which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13224@debbugs.gnu.org. --=20 13224: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13224 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1357287722-20475-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13224-done) by debbugs.gnu.org; 4 Jan 2013 08:21:35 +0000 Received: from localhost ([127.0.0.1]:42588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tr2X0-0005JY-Rk for submit@debbugs.gnu.org; Fri, 04 Jan 2013 03:21:35 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:47703) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tr2Wz-0005JR-0N for 13224-done@debbugs.gnu.org; Fri, 04 Jan 2013 03:21:33 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Tr2Ws-0006cG-OR; Fri, 04 Jan 2013 03:21:26 -0500 From: Glenn Morris To: 13224-done@debbugs.gnu.org Subject: Re: bug#13224: 24.3.50; [PATCH] Variable `icomplete-prospects-height' is no longer honored References: X-Spook: PET Axis of Evil unclassified rs9512c Kh-11 wire transfer X-Ran: h/!G3%q8lH{tSqZ['6exRB3B,J.rDocC6p7tg/pz;&d*](F,%Xg%eKcTkHRZLR/O[OVtfs X-Hue: black X-Attribution: GM Date: Fri, 04 Jan 2013 03:21:26 -0500 In-Reply-To: (Wesley Dawson's message of "Tue, 18 Dec 2012 21:41:13 -0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13224-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Thanks; applied. ------------=_1357287722-20475-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Dec 2012 08:05:07 +0000 Received: from localhost ([127.0.0.1]:49891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlEeI-0003ck-FA for submit@debbugs.gnu.org; Wed, 19 Dec 2012 03:05:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43752) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlCQJ-0000HS-46 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 00:42:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlCQG-0005vH-70 for submit@debbugs.gnu.org; Wed, 19 Dec 2012 00:42:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlCQG-0005vD-3l for submit@debbugs.gnu.org; Wed, 19 Dec 2012 00:42:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlCQD-0000AY-D5 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 00:42:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlCQA-0005ut-Ve for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 00:42:25 -0500 Received: from karen.lavabit.com ([72.249.41.33]:35188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlCQA-0005up-Pg for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 00:42:22 -0500 Received: from e.earth.lavabit.com (e.earth.lavabit.com [192.168.111.14]) by karen.lavabit.com (Postfix) with ESMTP id A348A11BBAA for ; Tue, 18 Dec 2012 23:42:21 -0600 (CST) Received: from sirith (c-24-130-13-84.hsd1.ca.comcast.net [24.130.13.84]) by lavabit.com with ESMTP id X3L5CB95MHXU for ; Tue, 18 Dec 2012 23:42:21 -0600 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=UGyMbq74YzmUK7SS2YpPJTnTiNzNhU2942S1vknuMBjKZ4m/rBZrIyes4EFN5K8WJ8fpdfr5DiRbkKwNgqRpcsQrxzJdD7f/xfkvnsDKj8JDTm+BXdjbuCY5O8ZSQUSRtSw7aNLP+eozzAdqzmtJtvLqp1Pn+24jZob780GXcj4=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; From: Wesley Dawson To: bug-gnu-emacs@gnu.org Subject: 24.3.50; [PATCH] Variable `icomplete-prospects-height' is no longer honored Date: Tue, 18 Dec 2012 21:41:13 -0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 19 Dec 2012 03:05:04 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain M-x icomplete-mode M-x set-variable icomplete-prospects-height 1 M-x a (the candidates list takes up two lines in the minibuffer) Here's a patch to make icomplete honor `icomplete-prospects-height' again, which it hasn't since the introduction of `icomplete-separator' (revno: 111031). About formatting: the source appears to mix tabs and spaces for indentation quite freely; I didn't attempt to fix this and went with what emacs -Q did for formatting. * lisp/icomplete.el (icomplete-completions): Fix to honor `icomplete-prospects-height' again. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=patch.diff Content-Transfer-Encoding: quoted-printable Content-Description: Fix to honor `icomplete-prospects-height' again. =3D=3D=3D modified file 'lisp/icomplete.el' --- lisp/icomplete.el 2012-12-17 19:43:55 +0000 +++ lisp/icomplete.el 2012-12-19 04:25:35 +0000 @@ -343,8 +343,10 @@ (t (concat "=E2=80=A6" (substring most compare)))) close-bracket))) ;;"-prospects" - more than one candidate - (prospects-len (+ (length determ) 6 ;; take {,...} into account - (string-width (buffer-string)))) + (prospects-len (+ (length determ) + (string-width icomplete-separator) + 3 ;; take {=E2=80=A6} into account + (string-width (buffer-string)))) (prospects-max ;; Max total length to use, including the minibuffer content. (* (+ icomplete-prospects-height @@ -375,7 +377,9 @@ (cond ((string-equal comp "") (setq most-is-exact t)) ((member comp prospects)) (t (setq prospects-len - (+ (string-width comp) 1 prospects-len)) + (+ (string-width comp) + (string-width icomplete-separator) + prospects-len)) (if (< prospects-len prospects-max) (push comp prospects) (setq limit t)))))) --=-=-=-- ------------=_1357287722-20475-1--