From unknown Thu Aug 14 21:45:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13223 <13223@debbugs.gnu.org> To: bug#13223 <13223@debbugs.gnu.org> Subject: Status: 24.2; comint history rendered useless by messages Reply-To: bug#13223 <13223@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:45:50 +0000 retitle 13223 24.2; comint history rendered useless by messages reassign 13223 emacs submitter 13223 "Tim Daly Jr." severity 13223 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 19 01:39:32 2012 Received: (at submit) by debbugs.gnu.org; 19 Dec 2012 06:39:32 +0000 Received: from localhost ([127.0.0.1]:49875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlDJT-0001gX-Tw for submit@debbugs.gnu.org; Wed, 19 Dec 2012 01:39:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50689) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlDJQ-0001gP-QV for submit@debbugs.gnu.org; Wed, 19 Dec 2012 01:39:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlDJN-00046l-2S for submit@debbugs.gnu.org; Wed, 19 Dec 2012 01:39:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:55840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlDJM-00046f-VP for submit@debbugs.gnu.org; Wed, 19 Dec 2012 01:39:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlDJJ-0001dQ-AJ for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 01:39:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlDJG-0003xC-7x for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 01:39:21 -0500 Received: from tenkan.org ([216.114.78.229]:49429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlDJG-0003x5-1o for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 01:39:18 -0500 Received: from vpn-pool-10-72-119-125.corp.yahoo.com (nat-dip6.cfw-a-gci.corp.yahoo.com [209.131.62.115]) by tenkan.org (Postfix) with ESMTPSA id 533FEA5582F9 for ; Wed, 19 Dec 2012 06:39:17 +0000 (UTC) From: "Tim Daly Jr." Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: 24.2; comint history rendered useless by messages Date: Tue, 18 Dec 2012 22:39:16 -0800 Message-Id: <58A8252B-C006-4216-97FD-3D2933D35282@tenkan.org> To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Apple Message framework v1283) X-Mailer: Apple Mail (2.1283) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (barebone) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) I always have to comment out the line (1194 in my copy) in comint.el that does this: (message "History item: %d" (1+ pos)) because it makes M-r in shell mode too slow to use. You hit M-r and type something and it just spams the heck out of you and goes nowhere. In GNU Emacs 24.2.1 (x86_64-apple-darwin, NS apple-appkit-1038.36) of 2012-08-27 on bob.porkrind.org Windowing system distributor `Apple', version 10.3.1138 Configured using: `configure '--host=x86_64-apple-darwin' '--build=i686-apple-darwin' '--with-ns' 'build_alias=i686-apple-darwin' 'host_alias=x86_64-apple-darwin' 'CC=gcc -mmacosx-version-min=10.5'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: T h e SPC i n d e t e n d e d SPC e f f e c t SPC i s SPC j u s t SPC t o SPC k i l l SPC t h e SPC f o r e g r o u n d SPC p r o c e s s SPC o n SPC t h e SPC r e o m o o t e SPC h o s t . C-n C-p C-f C-SPC C-M-f C-M-f M-f M-f M-f C-f C-f C-w C-p M-b M-b C-y SPC M-q C-n C-n C-e C-n M-< C-e M-b M-b M-b M-b M-b C-SPC C-e C-b C-w y a h o o - M-b M-b C-SPC C-e C-b C-w t i m @ t e n k a n . o r g C-n C-a C-n C-n C-v C-v M-> M-< C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-c C-c y e s m a i l SPC c l i e n t C-SPC M-< C-x C-n C-n C-n C-g C-x 1 C-n C-n C-n C-n C-g C-SPC C-n C-p C-n C-n C-p C-p C-n C-w C-n C-n C-n C-n C-n C-SPC C-p C-w C-p C-p C-p C-p C-p C-SPC M-> M-w M-< C-n M-f C-f C-f C-SPC C-e M-w C-n C-a M-f M-b C-SPC C-e M-w C-x k y e s C-x b c c o m i C-p C-p C-a M-f M-b C-b C-b C-f C-SPC C-e M-w M-x r e p o r C-g M-x r e p r o t - b u o r t - b u g Recent messages: Quit [2 times] Mark set [3 times] Saved text from " If you ssh someplace in shell mode and " Mark set [2 times] Auto-saving...done Mark set Making completion list... Mark set Making completion list... Quit Load-path shadows: None found. Features: (novice cus-edit cus-start cus-load wid-edit shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils mule-util rect nxml-uchnm rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok conf-mode newcomment derived cl byte-opt bytecomp byte-compile cconv macroexp vc-dispatcher vc-svn jka-compr tabify man assoc make-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs vc-git help-mode view pcmpl-unix dired-aux misearch multi-isearch sh-script executable dired shell pcomplete warnings iswitchb compile comint regexp-opt ansi-color advice help-fns advice-preload xcscope ring easymenu slime-autoloads edmacro kmacro time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process ns multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 28 18:28:00 2013 Received: (at 13223) by debbugs.gnu.org; 28 Apr 2013 22:28:00 +0000 Received: from localhost ([127.0.0.1]:49004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWa4e-0007Lr-Bo for submit@debbugs.gnu.org; Sun, 28 Apr 2013 18:28:00 -0400 Received: from tenkan.org ([216.114.78.229]:43909) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWa4c-0007Lj-MN for 13223@debbugs.gnu.org; Sun, 28 Apr 2013 18:27:59 -0400 Received: from [10.0.0.253] (c-24-5-122-5.hsd1.ca.comcast.net [24.5.122.5]) by tenkan.org (Postfix) with ESMTPSA id E1B17257A0A0 for <13223@debbugs.gnu.org>; Sun, 28 Apr 2013 22:27:42 +0000 (UTC) From: "Tim Daly Jr." Content-Type: multipart/mixed; boundary=Apple-Mail-4-186320145 Subject: patch to fix this bug Date: Sun, 28 Apr 2013 15:27:40 -0700 Message-Id: <96A9F7F8-2C61-422F-A18E-9C95511F260F@tenkan.org> To: 13223@debbugs.gnu.org Mime-Version: 1.0 (Apple Message framework v1085) X-Mailer: Apple Mail (2.1085) X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: 13223 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) --Apple-Mail-4-186320145 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii This patch keeps emacs from printing the history messages when = performing a history search in a comint buffer. (For example, M-x shell = RET M-r o). Changelog: 2013-04-28 Tim Daly Jr. * comint.el (comint-history-isearch-in-progress): new variable that lets us detect that an isearch is running over command history (comint-previous-matching-input): don't print "History item: N" messages when called as part of an isearch over history, because it's too slow and spammy. (comint-history-isearch-setup, comint-history-isearch-end): = toggle comint-history-isearch-in-progress to indicate search start and stop Patch: --Apple-Mail-4-186320145 Content-Disposition: attachment; filename=skip-isearch-history-msgs.patch Content-Type: application/octet-stream; name="skip-isearch-history-msgs.patch" Content-Transfer-Encoding: 7bit === modified file 'ChangeLog' *** ChangeLog 2013-04-27 19:30:33 +0000 --- ChangeLog 2013-04-28 22:22:55 +0000 *************** *** 1,3 **** --- 1,15 ---- + 2013-04-28 Tim Daly Jr. + + * comint.el (comint-history-isearch-in-progress): new variable + that lets us detect that an isearch is running over command + history + (comint-previous-matching-input): don't print "History item: N" + messages when called as part of an isearch over history, because + it's too slow and spammy. + (comint-history-isearch-setup, comint-history-isearch-end): toggle + comint-history-isearch-in-progress to indicate search start and + stop + 2013-04-27 Paul Eggert Merge from gnulib, incorporating: === modified file 'lisp/comint.el' *** lisp/comint.el 2013-04-21 03:13:04 +0000 --- lisp/comint.el 2013-04-28 22:01:31 +0000 *************** Moves relative to START, or `comint-inpu *** 1175,1180 **** --- 1175,1183 ---- (process-mark (get-buffer-process (current-buffer)))) (point-max))) + (defvar comint-history-isearch-in-progress nil + "Indicates that a comint history search is currently running.") + (defun comint-previous-matching-input (regexp n) "Search backwards through input history for match for REGEXP. \(Previous history elements are earlier commands.) *************** If N is negative, find the next or Nth n *** 1191,1197 **** (setq comint-stored-incomplete-input (funcall comint-get-old-input))) (setq comint-input-ring-index pos) ! (message "History item: %d" (1+ pos)) (comint-delete-input) (insert (ring-ref comint-input-ring pos))))) --- 1194,1201 ---- (setq comint-stored-incomplete-input (funcall comint-get-old-input))) (setq comint-input-ring-index pos) ! (unless comint-history-isearch-in-progress ! (message "History item: %d" (1+ pos))) (comint-delete-input) (insert (ring-ref comint-input-ring pos))))) *************** Intended to be added to `isearch-mode-ho *** 1433,1439 **** 'comint-history-isearch-wrap) (set (make-local-variable 'isearch-push-state-function) 'comint-history-isearch-push-state) ! (add-hook 'isearch-mode-end-hook 'comint-history-isearch-end nil t))) (defun comint-history-isearch-end () "Clean up the comint after terminating Isearch in comint." --- 1437,1444 ---- 'comint-history-isearch-wrap) (set (make-local-variable 'isearch-push-state-function) 'comint-history-isearch-push-state) ! (add-hook 'isearch-mode-end-hook 'comint-history-isearch-end nil t) ! (setq comint-history-isearch-in-progress t))) (defun comint-history-isearch-end () "Clean up the comint after terminating Isearch in comint." *************** Intended to be added to `isearch-mode-ho *** 1444,1450 **** (setq isearch-message-function nil) (setq isearch-wrap-function nil) (setq isearch-push-state-function nil) ! (remove-hook 'isearch-mode-end-hook 'comint-history-isearch-end t)) (defun comint-goto-input (pos) "Put input history item of the absolute history position POS." --- 1449,1456 ---- (setq isearch-message-function nil) (setq isearch-wrap-function nil) (setq isearch-push-state-function nil) ! (remove-hook 'isearch-mode-end-hook 'comint-history-isearch-end t) ! (setq comint-history-isearch-in-progress nil)) (defun comint-goto-input (pos) "Put input history item of the absolute history position POS." --Apple-Mail-4-186320145-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 28 19:13:36 2013 Received: (at 13223) by debbugs.gnu.org; 28 Apr 2013 23:13:36 +0000 Received: from localhost ([127.0.0.1]:49050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWaml-000102-Ui for submit@debbugs.gnu.org; Sun, 28 Apr 2013 19:13:36 -0400 Received: from tenkan.org ([216.114.78.229]:57660) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWamj-0000zs-CJ for 13223@debbugs.gnu.org; Sun, 28 Apr 2013 19:13:34 -0400 Received: from [10.0.0.253] (c-24-5-122-5.hsd1.ca.comcast.net [24.5.122.5]) by tenkan.org (Postfix) with ESMTPSA id E3E6C257A0A0 for <13223@debbugs.gnu.org>; Sun, 28 Apr 2013 23:13:16 +0000 (UTC) From: "Tim Daly Jr." Content-Type: multipart/mixed; boundary=Apple-Mail-3-189056066 Subject: resending the patch as text/plain... Date: Sun, 28 Apr 2013 16:13:16 -0700 Message-Id: <2ED44AF9-A0E7-4E5F-BEF1-0AAA8DCED708@tenkan.org> To: 13223@debbugs.gnu.org Mime-Version: 1.0 (Apple Message framework v1085) X-Mailer: Apple Mail (2.1085) X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 13223 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) --Apple-Mail-3-189056066 Content-Disposition: attachment; filename=skip-isearch-history-msgs.patch.txt Content-Type: text/plain; x-unix-mode=0644; name="skip-isearch-history-msgs.patch.txt" Content-Transfer-Encoding: 7bit === modified file 'ChangeLog' *** ChangeLog 2013-04-27 19:30:33 +0000 --- ChangeLog 2013-04-28 22:22:55 +0000 *************** *** 1,3 **** --- 1,15 ---- + 2013-04-28 Tim Daly Jr. + + * comint.el (comint-history-isearch-in-progress): new variable + that lets us detect that an isearch is running over command + history + (comint-previous-matching-input): don't print "History item: N" + messages when called as part of an isearch over history, because + it's too slow and spammy. + (comint-history-isearch-setup, comint-history-isearch-end): toggle + comint-history-isearch-in-progress to indicate search start and + stop + 2013-04-27 Paul Eggert Merge from gnulib, incorporating: === modified file 'lisp/comint.el' *** lisp/comint.el 2013-04-21 03:13:04 +0000 --- lisp/comint.el 2013-04-28 22:01:31 +0000 *************** Moves relative to START, or `comint-inpu *** 1175,1180 **** --- 1175,1183 ---- (process-mark (get-buffer-process (current-buffer)))) (point-max))) + (defvar comint-history-isearch-in-progress nil + "Indicates that a comint history search is currently running.") + (defun comint-previous-matching-input (regexp n) "Search backwards through input history for match for REGEXP. \(Previous history elements are earlier commands.) *************** If N is negative, find the next or Nth n *** 1191,1197 **** (setq comint-stored-incomplete-input (funcall comint-get-old-input))) (setq comint-input-ring-index pos) ! (message "History item: %d" (1+ pos)) (comint-delete-input) (insert (ring-ref comint-input-ring pos))))) --- 1194,1201 ---- (setq comint-stored-incomplete-input (funcall comint-get-old-input))) (setq comint-input-ring-index pos) ! (unless comint-history-isearch-in-progress ! (message "History item: %d" (1+ pos))) (comint-delete-input) (insert (ring-ref comint-input-ring pos))))) *************** Intended to be added to `isearch-mode-ho *** 1433,1439 **** 'comint-history-isearch-wrap) (set (make-local-variable 'isearch-push-state-function) 'comint-history-isearch-push-state) ! (add-hook 'isearch-mode-end-hook 'comint-history-isearch-end nil t))) (defun comint-history-isearch-end () "Clean up the comint after terminating Isearch in comint." --- 1437,1444 ---- 'comint-history-isearch-wrap) (set (make-local-variable 'isearch-push-state-function) 'comint-history-isearch-push-state) ! (add-hook 'isearch-mode-end-hook 'comint-history-isearch-end nil t) ! (setq comint-history-isearch-in-progress t))) (defun comint-history-isearch-end () "Clean up the comint after terminating Isearch in comint." *************** Intended to be added to `isearch-mode-ho *** 1444,1450 **** (setq isearch-message-function nil) (setq isearch-wrap-function nil) (setq isearch-push-state-function nil) ! (remove-hook 'isearch-mode-end-hook 'comint-history-isearch-end t)) (defun comint-goto-input (pos) "Put input history item of the absolute history position POS." --- 1449,1456 ---- (setq isearch-message-function nil) (setq isearch-wrap-function nil) (setq isearch-push-state-function nil) ! (remove-hook 'isearch-mode-end-hook 'comint-history-isearch-end t) ! (setq comint-history-isearch-in-progress nil)) (defun comint-goto-input (pos) "Put input history item of the absolute history position POS." --Apple-Mail-3-189056066-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 29 02:51:15 2013 Received: (at 13223) by debbugs.gnu.org; 29 Apr 2013 06:51:15 +0000 Received: from localhost ([127.0.0.1]:49405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWhva-0008Rw-3H for submit@debbugs.gnu.org; Mon, 29 Apr 2013 02:51:15 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:46272 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWhvS-0008RC-GN for 13223@debbugs.gnu.org; Mon, 29 Apr 2013 02:51:08 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id D94E2258B9E91C; Sun, 28 Apr 2013 23:50:44 -0700 (PDT) From: Juri Linkov To: "Tim Daly Jr." Subject: Re: bug#13223: patch to fix this bug Organization: JURTA References: <58A8252B-C006-4216-97FD-3D2933D35282@tenkan.org> <96A9F7F8-2C61-422F-A18E-9C95511F260F@tenkan.org> Date: Mon, 29 Apr 2013 09:45:34 +0300 In-Reply-To: <96A9F7F8-2C61-422F-A18E-9C95511F260F@tenkan.org> (Tim Daly, Jr.'s message of "Sun, 28 Apr 2013 15:27:40 -0700") Message-ID: <87ppxexhjh.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 13223 Cc: 13223@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > * comint.el (comint-history-isearch-in-progress): new variable > that lets us detect that an isearch is running over command > history I wonder why you didn't use the existing variable `isearch-mode' to detect that an isearch is running? There should be no problem using `isearch-mode' as you can see in the patch below. Additionally it will display only the current history item where isearch actually matches, i.e. to display just one "History item" message per one M-r isearch match. This is necessary to inform the user about the current history index as the commands `M-p' (comint-previous-input) and `M-n' (comint-next-input) already do: === modified file 'lisp/comint.el' --- lisp/comint.el 2013-04-27 23:07:46 +0000 +++ lisp/comint.el 2013-04-29 06:44:43 +0000 @@ -1191,7 +1191,8 @@ (defun comint-previous-matching-input (r (setq comint-stored-incomplete-input (funcall comint-get-old-input))) (setq comint-input-ring-index pos) - (message "History item: %d" (1+ pos)) + (unless isearch-mode + (message "History item: %d" (1+ pos))) (comint-delete-input) (insert (ring-ref comint-input-ring pos))))) @@ -1540,8 +1541,11 @@ (defun comint-history-isearch-message (& (overlay-put comint-history-isearch-message-overlay 'evaporate t)) (overlay-put comint-history-isearch-message-overlay 'display (isearch-message-prefix c-q-hack ellipsis)) - ;; And clear any previous isearch message. - (message ""))) + (if (and comint-input-ring-index (not ellipsis)) + ;; Display the current history index. + (message "History item: %d" (1+ comint-input-ring-index)) + ;; Or clear a previous isearch message. + (message "")))) (defun comint-history-isearch-wrap () "Wrap the input history search when search fails. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 30 21:36:39 2013 Received: (at 13223) by debbugs.gnu.org; 1 May 2013 01:36:39 +0000 Received: from localhost ([127.0.0.1]:53009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UXLyE-0008Ud-NB for submit@debbugs.gnu.org; Tue, 30 Apr 2013 21:36:39 -0400 Received: from tenkan.org ([216.114.78.229]:48213) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UXLy8-0008Tw-KF for 13223@debbugs.gnu.org; Tue, 30 Apr 2013 21:36:33 -0400 Received: from [10.0.0.253] (c-24-5-122-5.hsd1.ca.comcast.net [24.5.122.5]) by tenkan.org (Postfix) with ESMTPSA id 790AF257A077; Wed, 1 May 2013 01:36:00 +0000 (UTC) Subject: Re: bug#13223: patch to fix this bug Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: "Tim Daly Jr." In-Reply-To: <87ppxexhjh.fsf@mail.jurta.org> Date: Tue, 30 Apr 2013 18:35:59 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <5F5F4251-B57C-4908-BBBB-6848AA6EF362@tenkan.org> References: <58A8252B-C006-4216-97FD-3D2933D35282@tenkan.org> <96A9F7F8-2C61-422F-A18E-9C95511F260F@tenkan.org> <87ppxexhjh.fsf@mail.jurta.org> To: Juri Linkov X-Mailer: Apple Mail (2.1085) X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 13223 Cc: 13223@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.4 (----) On Apr 28, 2013, at 11:45 PM, Juri Linkov wrote: >> * comint.el (comint-history-isearch-in-progress): new variable >> that lets us detect that an isearch is running over command >> history >=20 > I wonder why you didn't use the existing variable `isearch-mode' > to detect that an isearch is running? There should be no problem > using `isearch-mode' as you can see in the patch below. >=20 > Additionally it will display only the current history item where > isearch actually matches, i.e. to display just one "History item" > message per one M-r isearch match. This is necessary to inform the = user > about the current history index as the commands `M-p' = (comint-previous-input) > and `M-n' (comint-next-input) already do: quite right, your patch looks much better. :) -tim From debbugs-submit-bounces@debbugs.gnu.org Wed May 01 04:07:03 2013 Received: (at control) by debbugs.gnu.org; 1 May 2013 08:07:03 +0000 Received: from localhost ([127.0.0.1]:53257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UXS47-0003e7-2Y for submit@debbugs.gnu.org; Wed, 01 May 2013 04:07:03 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:51745 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UXS44-0003dg-Ej for control@debbugs.gnu.org; Wed, 01 May 2013 04:07:01 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 74102258B92943 for ; Wed, 1 May 2013 01:06:31 -0700 (PDT) From: Juri Linkov To: control@debbugs.gnu.org Subject: Re: bug#13223: patch to fix this bug Organization: JURTA References: <58A8252B-C006-4216-97FD-3D2933D35282@tenkan.org> <96A9F7F8-2C61-422F-A18E-9C95511F260F@tenkan.org> <87ppxexhjh.fsf@mail.jurta.org> <5F5F4251-B57C-4908-BBBB-6848AA6EF362@tenkan.org> Date: Wed, 01 May 2013 11:05:45 +0300 In-Reply-To: <5F5F4251-B57C-4908-BBBB-6848AA6EF362@tenkan.org> (Tim Daly, Jr.'s message of "Tue, 30 Apr 2013 18:35:59 -0700") Message-ID: <87d2tbrup2.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) fixed 13223 24.3.50 close 13223 stop From unknown Thu Aug 14 21:45:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 29 May 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator