GNU bug report logs - #1320
sh-mode indentation of "case $foo in (bar)"

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Karl Chen <quarl <at> cs.berkeley.edu>
Subject: bug#1320 closed by Chong Yidong <cyd <at> stupidchicken.com> (Re:
 sh-mode indentation of "case $foo in (bar)")
Date: Sat, 24 Oct 2009 21:25:06 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#1320: sh-mode indentation of "case $foo in (bar)"

It has been closed by Chong Yidong <cyd <at> stupidchicken.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <cyd <at> stupidchicken.com> by
replying to this email.


-- 
1320: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1320
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Karl Chen <quarl <at> cs.berkeley.edu>
Cc: 1320-done <at> debbugs.gnu.org
Subject: Re: sh-mode indentation of "case $foo in (bar)"
Date: Sat, 24 Oct 2009 17:16:39 -0400

> #
> case x in
> y)
> y2
> ;;
> (z)
> z2
> ;;
> esac
>
> Running (sh-get-indent-info) on the y2 line includes
> sh-indent-for-case-alt in the result (as expected); running
> (sh-get-indent-info) on the z2 line doesn't yield
> sh-indent-for-case-alt.

Sorry for the late response.  I've checked in a fix for this problem
into Emacs CVS.

[Message part 3 (message/rfc822, inline)]

From: Karl Chen <quarl <at> cs.berkeley.edu>
To: quiet <at> debbugs.gnu.org
Subject: sh-mode indentation of "case $foo in (bar)"
Date: Fri, 31 Oct 2008 03:29:13 -0700

[ resent from
http://lists.gnu.org/archive/html/emacs-devel/2008-10/msg00906.html ]

emacs -Q /tmp/case.sh
#
case x in
y)
y2
;;
(z)
z2
;;
esac

M-: (indent-region (point-min) (point-max))


Result:
#
case x in
    y)
        y2
	;;
    (z)
    z2
    ;;
esac


Expected:
#
case x in
    y)
        y2
	;;
    (z)
        z2
        ;;
esac



Running (sh-get-indent-info) on the y2 line includes
sh-indent-for-case-alt in the result (as expected); running
(sh-get-indent-info) on the z2 line doesn't yield
sh-indent-for-case-alt.

The "(altpattern)" syntax with leading opening parenthesis is
supported by various shells (bash, ksh, zsh).


Also, a second indentation bug: if the first line in the buffer is
the case statement, sh-mode gets even more confused and
double-indents the y2 line.  This is rare though since usually the
first line is "#!"; I only noticed it while constructing this bug
report.

Tested on emacs 22.2 and emacs 2008-10-31.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.