GNU bug report logs - #13197
24.3.50; org-odt.el code that kills modified buffers

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Bastien <bzg <at> altern.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13197: closed (24.3.50; org-odt.el code that kills modified
 buffers)
Date: Thu, 20 Dec 2012 15:08:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 20 Dec 2012 16:07:16 +0100
with message-id <87wqwcn4nv.fsf <at> bzg.ath.cx>
and subject line Re: bug#13197: 24.3.50; org-odt.el code that kills modified buffers
has caused the debbugs.gnu.org bug report #13197,
regarding 24.3.50; org-odt.el code that kills modified buffers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13197: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13197
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; org-odt.el code that kills modified buffers
Date: Sat, 15 Dec 2012 14:35:45 -0800

This is a question, but it might also be a bug report regarding the code
cited.
 
IIUC, `set-buffer-modified-p' (and also `restore-buffer-modified-p',
which is a lousy name BTW) always acts on the current buffer.  There is
no way to tell it which buffer to act on, other than, say, using
`with-current-buffer'.
 
I use `find-file-noselect' over a large set of files, and at a later
point I kill many such visited-file buffers.  But even just
`find-file-no-select' can cause visiting to modify some buffers.  So
when I go to kill them I need to prevent the user being queried about
killing a modified buffer.
 
I was grepping some source files to see how other code handles this kind
of thing, and I came across this in org-odt.el (in
`org-odt-cleanup-xml-buffers'):
 
(mapc (lambda (file)
        (let ((buf (find-file-noselect
                     (expand-file-name file org-odt-zip-dir) t)))
          (when (buffer-name buf)
            (set-buffer-modified-p nil)
            (kill-buffer buf))))
      xml-files)
 
I don't see how that can work properly, since `find-file-noselect' does
not make the visited-file buffer current, and `set-buffer-modified-p'
acts only on the current buffer.
 
Am I missing something here, or is that a bug?
 
In any case, I would like to learn more about this.  Currently I am
doing this (since this code is for Emacs 23+, which has
`restore-buffer-modified-p'):
 
(with-current-buffer buf
  (restore-buffer-modified-p nil)
  (kill-buffer buf))
 
Is there a way to accomplish that without making BUF current?
 
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2012-12-13 on ODIEONE
Bzr revision: 111211 eggert <at> cs.ucla.edu-20121213021749-eyqqen0ewhn2hogq
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include -Wall -Wextra -Wno-sign-compare
 -Wno-type-limits -Wno-missing-field-initializers -Wno-pointer-sign
 -Wdeclaration-after-statement --ldflags -LC:/Devel/emacs/build/lib'
 

[Message part 3 (message/rfc822, inline)]

From: Bastien <bzg <at> altern.org>
To: Jambunathan K <kjambunathan <at> gmail.com>
Cc: 13197-done <at> debbugs.gnu.org
Subject: Re: bug#13197: 24.3.50; org-odt.el code that kills modified buffers
Date: Thu, 20 Dec 2012 16:07:16 +0100

Hi Drew and Jambunathan,

Bastien <bzg <at> altern.org> writes:

> thanks for taking care of this in Org's repo.

I've taken care of it in Org's maint branch, it will be
part of the next merge with the emacs-24 branch.

Thanks,

-- 
 Bastien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.