From unknown Fri Jun 20 19:47:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13191: 24.3.50; insert-directory: Always replace "total" with "total used in directory" Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Dec 2012 11:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13191@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13555713654717 (code B ref -1); Sat, 15 Dec 2012 11:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Dec 2012 11:36:05 +0000 Received: from localhost ([127.0.0.1]:43388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjq2H-0001E1-0P for submit@debbugs.gnu.org; Sat, 15 Dec 2012 06:36:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56230) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjq2E-0001Dt-7A for submit@debbugs.gnu.org; Sat, 15 Dec 2012 06:36:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tjq1A-0000dG-9X for submit@debbugs.gnu.org; Sat, 15 Dec 2012 06:34:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:43711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjq1A-0000dC-6P for submit@debbugs.gnu.org; Sat, 15 Dec 2012 06:34:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjq14-0008Fb-L3 for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 06:34:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tjq0u-0000Vv-LZ for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 06:34:50 -0500 Received: from ristopher.com ([146.185.21.93]:36837 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjq0u-0000U2-E4 for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 06:34:40 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id CD04420168; Sat, 15 Dec 2012 11:34:37 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1355571277; bh=JnxfdwWAGhCfMvxNPqMAn2jhOzAXNnciTxyhEsSoH8o=; h=From:To:Subject:Message-ID:MIME-Version:Content-Type:Date; b=nedlhTQLkr+bQDhxHljTV86fS9YdGwyTB/LBsPnCkbd5/p54tZRZe7k2JI252Hr9e AvdFIGfyf3ylJjXrL4kyzke9qAT0NelECsQ6Ta0qWuVhxX5xdcMx9P/hZ3Q4liECCA /8xR20gKHlBQEpmWEwRtHM2V5CicagaPoOfCE0Z4= From: Christopher Schmidt Message-ID: <878v8z7dm4@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Sat, 15 Dec 2012 11:34:37 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) --=-=-= Content-Type: text/plain severity: wishlist In insert-directory there are these forms: (goto-char beg) ;; First find the line to put it on. (when (re-search-forward "^ *\\(total\\)" nil t) (let ((available (get-free-disk-space "."))) (when available ;; Replace "total" with "used", to avoid confusion. (replace-match "total used in directory" nil nil nil 1) (end-of-line) (insert " available " available)))))) I think "total" should always be replaced by "total used in directory" even if Emacs is not able to get the free disk space. This increases consistency and avoids confusion by other packages which rely on consistent output, such as dired-details, Here is a patch. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=files-insert-directory.diff --- lisp/ChangeLog +++ lisp/ChangeLog @@ -1,3 +1,8 @@ +2012-12-15 Christopher Schmidt + + * files.el (insert-directory): Always replace "total" with "total + used in directory" to avoid confusion. (Bug#) + 2012-12-14 Glenn Morris * emacs-lisp/macroexp.el (macroexp--warn-and-return): --- lisp/files.el +++ lisp/files.el @@ -6299,10 +6299,11 @@ (goto-char beg) ;; First find the line to put it on. (when (re-search-forward "^ *\\(total\\)" nil t) + ;; Replace "total" with "total used in directory" to + ;; avoid confusion. + (replace-match "total used in directory" nil nil nil 1) (let ((available (get-free-disk-space "."))) (when available - ;; Replace "total" with "used", to avoid confusion. - (replace-match "total used in directory" nil nil nil 1) (end-of-line) (insert " available " available)))))))))) --=-=-= Content-Type: text/plain If this patch is applied, tramp (tramp-sh-handle-insert-directory) should be modified to do the same. Christopher --=-=-=-- From unknown Fri Jun 20 19:47:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13191: 24.3.50; insert-directory: Always replace "total" with "total used indirectory" Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Dec 2012 15:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Christopher Schmidt'" , <13191@debbugs.gnu.org> Received: via spool by 13191-submit@debbugs.gnu.org id=B13191.135558706732425 (code B ref 13191); Sat, 15 Dec 2012 15:58:01 +0000 Received: (at 13191) by debbugs.gnu.org; 15 Dec 2012 15:57:47 +0000 Received: from localhost ([127.0.0.1]:44245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tju7V-0008Qu-R5 for submit@debbugs.gnu.org; Sat, 15 Dec 2012 10:57:46 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:37503) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tju7T-0008Ql-Qo for 13191@debbugs.gnu.org; Sat, 15 Dec 2012 10:57:44 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qBFFuckJ031994 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 15 Dec 2012 15:56:39 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qBFFubDt003594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 15 Dec 2012 15:56:38 GMT Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qBFFubER029510; Sat, 15 Dec 2012 09:56:37 -0600 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 15 Dec 2012 07:56:37 -0800 From: "Drew Adams" References: <878v8z7dm4@ch.ristopher.com> Date: Sat, 15 Dec 2012 07:56:30 -0800 Message-ID: <1B27E07CE742494A9C0FB268E9B4F570@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <878v8z7dm4@ch.ristopher.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac3auGECqvJf23yHQ9KUzWvFowKZSAAJD9DQ X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.5 (-) > I think "total" should always be replaced by "total used in directory" > even if Emacs is not able to get the free disk space. This increases > consistency and avoids confusion by other packages which rely on > consistent output, such as dired-details, FWIW, in Dired+ I use this: files 1559/1559 space used 63122 available 24468736 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 12:44:16 2019 Received: (at control) by debbugs.gnu.org; 30 Sep 2019 16:44:16 +0000 Received: from localhost ([127.0.0.1]:60373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEymW-0001qz-Gs for submit@debbugs.gnu.org; Mon, 30 Sep 2019 12:44:16 -0400 Received: from mail-pg1-f182.google.com ([209.85.215.182]:41147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEymT-0001qh-T7 for control@debbugs.gnu.org; Mon, 30 Sep 2019 12:44:14 -0400 Received: by mail-pg1-f182.google.com with SMTP id s1so7687372pgv.8 for ; Mon, 30 Sep 2019 09:44:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=T+00PUWDu6FM0mwqsawYXnhgEJN/Jow3maswaWRFGu8=; b=G3sRuoMZi21SN9scoG9fdydM7dasoMB6WLGDbbscfCC3AJi/o7Tz2aNtomfgZqWGzC vTtM5uMfbFRi9wcn7devb+uCkl47/Gr43kfRkOnSZbC719BXabjdik+0VngNof9gejw7 MYgPuWQc9r7QGJS5jdMgE6zfcrl8DdFVQ40O0q8J9h6xUyFxaH/xBIGgjc79CoqHASze N5vjUI5wwljUl+yDJwCaVe0aAgGup39kc1m2zRCViKxnHJfJMo51ow+AS/4X6rQPyu4M xISoV6Bfo1OIeuLZQBybRswD7SbFHbqQYLPpKUhX/T8oY939nmYCO/6rQFRrd/EdgLVe Qi2Q== X-Gm-Message-State: APjAAAVC3LPdF1uMX/AMDZfJ+zeOo/W74QYgQ9Kze/XJZGOvE6S1BMeD VwdiKHov2aKMD0PJ9xe846xWawkBxXU777LNw5gH0wyXxNk= X-Google-Smtp-Source: APXvYqzg6OnauHYozC1/38tYLUf1WJRyBtRglHmAFgswwdweXE0Z6p+1BQwfdMAamoDjRAsWz5nY0mnFK4dso0Jf6UY= X-Received: by 2002:aa7:8009:: with SMTP id j9mr22095054pfi.107.1569861847804; Mon, 30 Sep 2019 09:44:07 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Mon, 30 Sep 2019 18:43:56 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 13191 + patch quit Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.182 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.215.182 listed in wl.mailspike.net] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 13191 + patch quit Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.182 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.215.182 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 2.0 BLANK_SUBJECT Subject is present but empty 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager tags 13191 + patch quit From unknown Fri Jun 20 19:47:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13191: 24.3.50; insert-directory: Always replace "total" with "total used in directory" Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2019 14:48:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 13191@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15745204416711 (code B ref -1); Sat, 23 Nov 2019 14:48:05 +0000 Received: (at submit) by debbugs.gnu.org; 23 Nov 2019 14:47:21 +0000 Received: from localhost ([127.0.0.1]:56055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYWgy-0001k0-Bz for submit@debbugs.gnu.org; Sat, 23 Nov 2019 09:47:20 -0500 Received: from lists.gnu.org ([209.51.188.17]:36112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYWga-0001jK-D0 for submit@debbugs.gnu.org; Sat, 23 Nov 2019 09:47:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49257) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYWgR-0003Nz-1o for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 09:46:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYWgP-0001tM-Ux for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 09:46:46 -0500 Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:53452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iYWgP-0001sr-OX for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 09:46:45 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iYWgL-0006Jx-C0 for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 15:46:43 +0100 From: Lars Ingebrigtsen References: <878v8z7dm4@ch.ristopher.com> Date: Sat, 23 Nov 2019 15:46:40 +0100 In-Reply-To: <878v8z7dm4@ch.ristopher.com> (Christopher Schmidt's message of "Sat, 15 Dec 2012 11:34:37 +0000 (GMT)") Message-ID: <87k17qlkfj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f9:2b:f0f::2 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Christopher Schmidt writes: > I think "total" should always be replaced by "total used in directory" > even if Emacs is not able to get the free disk space. This increases > consistency and avoids confusion by other packages which rely on > consistent output, such as dired-details, Makes sense to me. I've now installed this in Emacs 27. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 09:48:17 2019 Received: (at control) by debbugs.gnu.org; 23 Nov 2019 14:48:17 +0000 Received: from localhost ([127.0.0.1]:56059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYWhq-0001lP-4v for submit@debbugs.gnu.org; Sat, 23 Nov 2019 09:48:16 -0500 Received: from quimby.gnus.org ([95.216.78.240]:37354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYWgx-0001jr-1m for control@debbugs.gnu.org; Sat, 23 Nov 2019 09:47:20 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iYWgo-0006KI-Om for control@debbugs.gnu.org; Sat, 23 Nov 2019 15:47:12 +0100 Date: Sat, 23 Nov 2019 15:47:10 +0100 Message-Id: <87imnalkep.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13191 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 13191 fixed close 13191 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 13191 fixed close 13191 27.1 quit