From unknown Fri Aug 15 16:21:59 2025 X-Loop: don@donarmstrong.com Subject: bug#1319: Change in where-is-internal causing describe-key problems Reply-To: "Geoff Gole" , 1319@debbugs.gnu.org Resent-From: "Geoff Gole" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 09 Nov 2008 03:30:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1319 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122620080414864 (code B ref -1); Sun, 09 Nov 2008 03:30:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 9 Nov 2008 03:20:04 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA93K0Ee014757 for ; Sat, 8 Nov 2008 19:20:02 -0800 Received: from mx10.gnu.org ([199.232.76.166]:40182) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kz0nI-0005hg-Ez for emacs-pretest-bug@gnu.org; Sat, 08 Nov 2008 22:16:56 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kz0qF-0008Je-FB for emacs-pretest-bug@gnu.org; Sat, 08 Nov 2008 22:19:59 -0500 Received: from fg-out-1718.google.com ([72.14.220.159]:46958) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kz0qF-0008JO-3z for emacs-pretest-bug@gnu.org; Sat, 08 Nov 2008 22:19:59 -0500 Received: by fg-out-1718.google.com with SMTP id l26so1853149fgb.30 for ; Sat, 08 Nov 2008 19:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=hoKxLOHbAaudar9l4dPDpN6b+jVeAgSOwwvYyZW8uTY=; b=QnPVDqGqtJnx0phCl+5Azefleo3ofSbD8XnUhXtB6RF90gM5Xm0vAe79HuL2an0N29 0FB0Mat6MM3INHQv0JgzZtq1hwi6MnwrkRCqUwvAxDrlwgsnHQIb4yTLHyoLPURb0I9g w7zHfF2JWZeDA9P6pi2Yeysi0BOItlXOMRDvk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=a9/3SKPcE4YrVfkrh7jEQBusiMCY+WAMjAciEwlqWjkbx1s8HpsTlwOiRtKQCTRgI6 1pteuncHYkEezU5KLt/Rvmx1Y1Xin8sLZ3rNTrH7Dd5OuGiolGn7vCAI1Ck5d3owgGRN mRcveXgpa5l6H5wusicoV53P27N6iI9YOXMF8= Received: by 10.187.208.15 with SMTP id k15mr1134752faq.89.1226200797802; Sat, 08 Nov 2008 19:19:57 -0800 (PST) Received: by 10.187.193.8 with HTTP; Sat, 8 Nov 2008 19:19:57 -0800 (PST) Message-ID: Date: Sat, 8 Nov 2008 19:19:57 -0800 From: "Geoff Gole" To: emacs-pretest-bug@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) The behaviour of where-is-internal has changed in CVS emacs. Enter view mode, M-: (where-is-internal 'self-insert-command nil nil nil) : 22.2 => ([491520] [458752] [442368] [425984] [409600]...) CVS => ([(128 . 4194303)]) This change breaks describe-function-1, used internally in describe-key, causing a bound key to be printed as a non-ascii character in some conditions. To reproduce the problem: emacs -Q C-h k k Switch to the *Help* buffer C-h k k where-is-internal seems to be buggy, but perhaps describe-function-1 should also be doing more checking. I'm not sure if it should handle input of the form ([(128 . 4194303)]) or not. From unknown Fri Aug 15 16:21:59 2025 X-Loop: don@donarmstrong.com Subject: bug#1319: Change in where-is-internal causing describe-key problems Reply-To: martin rudalics , 1319@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 11 Nov 2008 10:00:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1319 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1319-submit@emacsbugs.donarmstrong.com id=B1319.122639710329538 (code B ref 1319); Tue, 11 Nov 2008 10:00:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1319) by emacsbugs.donarmstrong.com; 11 Nov 2008 09:51:43 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mAB9pd9I029532 for <1319@emacsbugs.donarmstrong.com>; Tue, 11 Nov 2008 01:51:41 -0800 Received: (qmail invoked by alias); 11 Nov 2008 09:51:33 -0000 Received: from 62-47-44-147.adsl.highway.telekom.at (EHLO [62.47.44.147]) [62.47.44.147] by mail.gmx.net (mp025) with SMTP; 11 Nov 2008 10:51:33 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19jvvQniOFjQkl/WiG+g5wybl6I0zGi8VJAiC9TF7 noiJ8cHe0SQ1AP Message-ID: <4919554E.9020600@gmx.at> Date: Tue, 11 Nov 2008 10:50:06 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: 1319@debbugs.gnu.org CC: Geoff Gole References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.71 > but perhaps describe-function-1 > should also be doing more checking. It chokes at the very last conjunct of (if (and (eq function 'self-insert-command) (eq (key-binding "a") 'self-insert-command) (eq (key-binding "b") 'self-insert-command) (eq (key-binding "c") 'self-insert-command)) because in `help-mode' "c" is bound to `View-leave'. IIUC, the heuristic above should make "many" in the text (princ "It is bound to many ordinary text characters.\n") sound reasonable but apparently fails miserably when one of a, b, or c is bound to something else. martin From unknown Fri Aug 15 16:21:59 2025 X-Loop: don@donarmstrong.com Subject: bug#1319: Change in where-is-internal causing describe-key problems Reply-To: martin rudalics , 1319@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 11 Nov 2008 12:50:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1319 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1319-submit@emacsbugs.donarmstrong.com id=B1319.12264073377373 (code B ref 1319); Tue, 11 Nov 2008 12:50:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1319) by emacsbugs.donarmstrong.com; 11 Nov 2008 12:42:17 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mABCgDBV007367 for <1319@emacsbugs.donarmstrong.com>; Tue, 11 Nov 2008 04:42:15 -0800 Received: (qmail invoked by alias); 11 Nov 2008 12:42:06 -0000 Received: from 62-47-37-52.adsl.highway.telekom.at (EHLO [62.47.37.52]) [62.47.37.52] by mail.gmx.net (mp032) with SMTP; 11 Nov 2008 13:42:06 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19wdEsllQBwZBAABc5GoES1bq5RMeNG67/F2pvrb8 UDEOYnsWSFXctx Message-ID: <49197D47.4080406@gmx.at> Date: Tue, 11 Nov 2008 13:40:39 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Geoff Gole CC: 1319@debbugs.gnu.org References: <4919554E.9020600@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.73 > I saw that, but I thought it was more likely to be a cheap early > out than a test that was ever meant to be bulletproof. Maybe you were right in thinking so, I don't know. > This code later in the describe-function-1 should handle the case > where that test fails but there are many keys bound to > self-insert-command: > > (when keys > (princ (if remapped ", which is bound to " "It is bound to ")) > ;; If lots of ordinary text characters run this command, > ;; don't mention them one by one. > (if (< (length non-modified-keys) 10) > (princ (mapconcat 'key-description keys ", ")) > (dolist (key non-modified-keys) > (setq keys (delq key keys))) > (if keys > (progn > (princ (mapconcat 'key-description keys ", ")) > (princ ", and many ordinary text characters")) > (princ "many ordinary text characters")))) > > And indeed in 22.2, it does. But the aforementioned change in > where-is-internal breaks it. What precisely was the change in `where-is-internal' that broke it? martin From unknown Fri Aug 15 16:21:59 2025 X-Loop: don@donarmstrong.com Subject: bug#1319: Change in where-is-internal causing describe-key problems Reply-To: "Geoff Gole" , 1319@debbugs.gnu.org Resent-From: "Geoff Gole" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 11 Nov 2008 14:20:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1319 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1319-submit@emacsbugs.donarmstrong.com id=B1319.122641273630317 (code B ref 1319); Tue, 11 Nov 2008 14:20:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1319) by emacsbugs.donarmstrong.com; 11 Nov 2008 14:12:16 +0000 Received: from ik-out-1112.google.com (ik-out-1112.google.com [66.249.90.183]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mABECCoj030311 for <1319@emacsbugs.donarmstrong.com>; Tue, 11 Nov 2008 06:12:14 -0800 Received: by ik-out-1112.google.com with SMTP id c28so2583384ika.1 for <1319@emacsbugs.donarmstrong.com>; Tue, 11 Nov 2008 06:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=03UYFqAPXiCRlSxCovKnlPqOAu3Sg9J/oS+gOtZ5NUI=; b=QT68iCoj8c5aDVUKsTr7bOneD2FBG94gNx2lxsWPAztAmy7MeUqJFcL9/JfxcEGmPd 0AxY64fDTkg2g4/6TMq3S3ihBBCmICWBjhbFZMVQnlqr6V3PiuvNwkPmsEpZzFLQlItg GNwiaXmIYEI/aNEckvvNaUbLB/cIBQjep5YX0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=DxzL3pLL7Y0/WeNJB7E3QV0Ha8EINp2WNlZtF/mCcByWwx2Rfhz62uLm+YzZFeR+fy qbRWUn08QUkTC+CGhDmAwJQRDf1zoxgvVZ6VvR8vYB4v8YGJ9NbX7WjVINbP8SLbIClq CqdJpepLOWSfDktVOhXcvuvaHBpHSgkWhJqvQ= Received: by 10.187.211.13 with SMTP id n13mr2535910faq.39.1226412731788; Tue, 11 Nov 2008 06:12:11 -0800 (PST) Received: by 10.187.193.8 with HTTP; Tue, 11 Nov 2008 06:12:11 -0800 (PST) Message-ID: Date: Tue, 11 Nov 2008 06:12:11 -0800 From: "Geoff Gole" To: "martin rudalics" , 1319@debbugs.gnu.org In-Reply-To: <49197D47.4080406@gmx.at> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4919554E.9020600@gmx.at> <49197D47.4080406@gmx.at> The change in return value described in the original report: > The behaviour of where-is-internal has changed in CVS emacs. Enter > view mode, M-: (where-is-internal 'self-insert-command nil nil nil) : > > 22.2 => ([491520] [458752] [442368] [425984] [409600]...) > CVS => ([(128 . 4194303)]) Unfortunately I don't have the 22.2 source at the moment to compare what differences in the code might cause that. If it would be helpful, I'll try to figure out how to pull them from cvs. From unknown Fri Aug 15 16:21:59 2025 X-Loop: don@donarmstrong.com Subject: bug#1319: Change in where-is-internal causing describe-key problems Reply-To: martin rudalics , 1319@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 11 Nov 2008 19:15:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1319 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1319-submit@emacsbugs.donarmstrong.com id=B1319.12264304527617 (code B ref 1319); Tue, 11 Nov 2008 19:15:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1319) by emacsbugs.donarmstrong.com; 11 Nov 2008 19:07:32 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mABJ7RZn007611 for <1319@emacsbugs.donarmstrong.com>; Tue, 11 Nov 2008 11:07:29 -0800 Received: (qmail invoked by alias); 11 Nov 2008 19:07:21 -0000 Received: from 62-47-37-34.adsl.highway.telekom.at (EHLO [62.47.37.34]) [62.47.37.34] by mail.gmx.net (mp010) with SMTP; 11 Nov 2008 20:07:21 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+dJQtwnOudPb7s4tpN+B5rm6X4CZk11lx6frCTXk y/qwso+8ubcOgJ Message-ID: <4919D78E.9080905@gmx.at> Date: Tue, 11 Nov 2008 20:05:50 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Geoff Gole CC: 1319@debbugs.gnu.org References: <4919554E.9020600@gmx.at> <49197D47.4080406@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.71 >> The behaviour of where-is-internal has changed in CVS emacs. Enter >> view mode, M-: (where-is-internal 'self-insert-command nil nil nil) : >> >> 22.2 => ([491520] [458752] [442368] [425984] [409600]...) >> CVS => ([(128 . 4194303)]) > > Unfortunately I don't have the 22.2 source at the moment to > compare what differences in the code might cause that. If it > would be helpful, I'll try to figure out how to pull them from > cvs. From your previous mail I concluded that you knew the change that caused this. I have no idea what the cons above stands for (some optimization, I presume) so I'm totally lost here. martin From unknown Fri Aug 15 16:21:59 2025 X-Loop: don@donarmstrong.com Subject: bug#1319: Change in where-is-internal causing describe-key problems Reply-To: Stefan Monnier , 1319@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 12 Nov 2008 03:10:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1319 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1319-submit@emacsbugs.donarmstrong.com id=B1319.122645894427904 (code B ref 1319); Wed, 12 Nov 2008 03:10:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.1 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1319) by emacsbugs.donarmstrong.com; 12 Nov 2008 03:02:24 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAC32K3W027898 for <1319@emacsbugs.donarmstrong.com>; Tue, 11 Nov 2008 19:02:22 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhAFAG/WGUlFxLQU/2dsb2JhbACBdstUg1eBEQ X-IronPort-AV: E=Sophos;i="4.33,587,1220241600"; d="scan'208";a="29749867" Received: from 69-196-180-20.dsl.teksavvy.com (HELO ceviche.home) ([69.196.180.20]) by ironport2-out.teksavvy.com with ESMTP; 11 Nov 2008 22:02:03 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 899B2B409D; Tue, 11 Nov 2008 22:01:51 -0500 (EST) From: Stefan Monnier To: Geoff Gole Cc: 1319@debbugs.gnu.org, "martin rudalics" Message-ID: References: <4919554E.9020600@gmx.at> <49197D47.4080406@gmx.at> Date: Tue, 11 Nov 2008 22:01:51 -0500 In-Reply-To: (Geoff Gole's message of "Tue, 11 Nov 2008 06:12:11 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> 22.2 => ([491520] [458752] [442368] [425984] [409600]...) >> CVS => ([(128 . 4194303)]) The 22.2 answer lists generic chars (these are chars that stand for a whole charset). In Emacs-23, generic chars have been dropped in favor of using char-ranges, represented a a cons cell (START . END). Stefan From unknown Fri Aug 15 16:21:59 2025 X-Loop: don@donarmstrong.com Subject: bug#1319: Change in where-is-internal causing describe-key problems Reply-To: martin rudalics , 1319@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 12 Nov 2008 18:40:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1319 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1319-submit@emacsbugs.donarmstrong.com id=B1319.12265148491953 (code B ref 1319); Wed, 12 Nov 2008 18:40:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1319) by emacsbugs.donarmstrong.com; 12 Nov 2008 18:34:09 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mACIY4Ac001947 for <1319@emacsbugs.donarmstrong.com>; Wed, 12 Nov 2008 10:34:06 -0800 Received: (qmail invoked by alias); 12 Nov 2008 18:33:58 -0000 Received: from 62-47-49-82.adsl.highway.telekom.at (EHLO [62.47.49.82]) [62.47.49.82] by mail.gmx.net (mp008) with SMTP; 12 Nov 2008 19:33:58 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18bdtxM7Q4bqrAp5uPubzvVgs3d4Iicr1ZyWhP60p 65BpPSVaaIercn Message-ID: <491B213A.3080001@gmx.at> Date: Wed, 12 Nov 2008 19:32:26 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Stefan Monnier CC: Geoff Gole , 1319@debbugs.gnu.org References: <4919554E.9020600@gmx.at> <49197D47.4080406@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6 >>> 22.2 => ([491520] [458752] [442368] [425984] [409600]...) >>> CVS => ([(128 . 4194303)]) > > The 22.2 answer lists generic chars (these are chars that stand for > a whole charset). In Emacs-23, generic chars have been dropped in favor > of using char-ranges, represented a a cons cell (START . END). This would deserve a NEWS entry. Anyway, we can either replace (if (and (eq function 'self-insert-command) (eq (key-binding "a") 'self-insert-command) (eq (key-binding "b") 'self-insert-command) (eq (key-binding "c") 'self-insert-command)) (princ "It is bound to many ordinary text characters.\n") ... by something like (if (and (eq function 'self-insert-command) (catch 'plenty (let ((count 0)) (dolist (item (where-is-internal 'self-insert-command)) (when (vectorp item) (let ((range (elt item 0))) (when (consp range) (setq count (+ count (- (cdr range) (car range)))) (when (> count 100) (throw 'plenty count))))))))) (princ "It is bound to many ordinary text characters.\n") ... or drop that "It is bound to many ordinary text characters" stuff. martin, who'd drop it unless someone finds a better solution. From unknown Fri Aug 15 16:21:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: "Geoff Gole" Subject: bug#1319 closed by Chong Yidong (Re: bug#1319: Change in where-is-internal causing describe-key problems) Message-ID: References: <87y6zljyos.fsf@cyd.mit.edu> X-Emacs-PR-Message: they-closed 1319 X-Emacs-PR-Package: emacs Reply-To: 1319@debbugs.gnu.org Content-Type: multipart/mixed; boundary="----------=_1226730603-23524-1" This is a multi-part message in MIME format... ------------=_1226730603-23524-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #1319: Change in where-is-internal causing describe-key problems It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 1319: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1319 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1226730603-23524-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From cyd@stupidchicken.com Fri Nov 14 22:22:15 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1319-done) by emacsbugs.donarmstrong.com; 15 Nov 2008 06:22:15 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAF6MDGG022295 for <1319-done@emacsbugs.donarmstrong.com>; Fri, 14 Nov 2008 22:22:14 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id A01A757E195; Sat, 15 Nov 2008 01:22:27 -0500 (EST) From: Chong Yidong To: martin rudalics Cc: 1319-done@debbugs.gnu.org Subject: Re: bug#1319: Change in where-is-internal causing describe-key problems Date: Sat, 15 Nov 2008 01:22:27 -0500 Message-ID: <87y6zljyos.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I checked in a slightly simpler fix to describe-function-1. It's probably not necessary to lose too much hair over this part of the code. ------------=_1226730603-23524-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From geoffgole@gmail.com Sat Nov 8 19:20:04 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 9 Nov 2008 03:20:04 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA93K0Ee014757 for ; Sat, 8 Nov 2008 19:20:02 -0800 Received: from mx10.gnu.org ([199.232.76.166]:40182) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kz0nI-0005hg-Ez for emacs-pretest-bug@gnu.org; Sat, 08 Nov 2008 22:16:56 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kz0qF-0008Je-FB for emacs-pretest-bug@gnu.org; Sat, 08 Nov 2008 22:19:59 -0500 Received: from fg-out-1718.google.com ([72.14.220.159]:46958) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kz0qF-0008JO-3z for emacs-pretest-bug@gnu.org; Sat, 08 Nov 2008 22:19:59 -0500 Received: by fg-out-1718.google.com with SMTP id l26so1853149fgb.30 for ; Sat, 08 Nov 2008 19:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=hoKxLOHbAaudar9l4dPDpN6b+jVeAgSOwwvYyZW8uTY=; b=QnPVDqGqtJnx0phCl+5Azefleo3ofSbD8XnUhXtB6RF90gM5Xm0vAe79HuL2an0N29 0FB0Mat6MM3INHQv0JgzZtq1hwi6MnwrkRCqUwvAxDrlwgsnHQIb4yTLHyoLPURb0I9g w7zHfF2JWZeDA9P6pi2Yeysi0BOItlXOMRDvk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=a9/3SKPcE4YrVfkrh7jEQBusiMCY+WAMjAciEwlqWjkbx1s8HpsTlwOiRtKQCTRgI6 1pteuncHYkEezU5KLt/Rvmx1Y1Xin8sLZ3rNTrH7Dd5OuGiolGn7vCAI1Ck5d3owgGRN mRcveXgpa5l6H5wusicoV53P27N6iI9YOXMF8= Received: by 10.187.208.15 with SMTP id k15mr1134752faq.89.1226200797802; Sat, 08 Nov 2008 19:19:57 -0800 (PST) Received: by 10.187.193.8 with HTTP; Sat, 8 Nov 2008 19:19:57 -0800 (PST) Message-ID: Date: Sat, 8 Nov 2008 19:19:57 -0800 From: "Geoff Gole" To: emacs-pretest-bug@gnu.org Subject: Change in where-is-internal causing describe-key problems MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) The behaviour of where-is-internal has changed in CVS emacs. Enter view mode, M-: (where-is-internal 'self-insert-command nil nil nil) : 22.2 => ([491520] [458752] [442368] [425984] [409600]...) CVS => ([(128 . 4194303)]) This change breaks describe-function-1, used internally in describe-key, causing a bound key to be printed as a non-ascii character in some conditions. To reproduce the problem: emacs -Q C-h k k Switch to the *Help* buffer C-h k k where-is-internal seems to be buggy, but perhaps describe-function-1 should also be doing more checking. I'm not sure if it should handle input of the form ([(128 . 4194303)]) or not. ------------=_1226730603-23524-1--