From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 14 22:43:44 2012 Received: (at submit) by debbugs.gnu.org; 15 Dec 2012 03:43:44 +0000 Received: from localhost ([127.0.0.1]:43168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjif9-0006SC-IJ for submit@debbugs.gnu.org; Fri, 14 Dec 2012 22:43:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36985) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjif5-0006S2-A1 for submit@debbugs.gnu.org; Fri, 14 Dec 2012 22:43:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tjie2-0000hb-9Y for submit@debbugs.gnu.org; Fri, 14 Dec 2012 22:42:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:51361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjie2-0000hX-6U for submit@debbugs.gnu.org; Fri, 14 Dec 2012 22:42:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjidz-0004xo-4y for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 22:42:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tjidw-0000h7-2y for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 22:42:31 -0500 Received: from gateway05.websitewelcome.com ([67.18.144.2]:51070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjidv-0000h3-Sv for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 22:42:28 -0500 Received: by gateway05.websitewelcome.com (Postfix, from userid 5007) id 29B51CEDF3BC5; Fri, 14 Dec 2012 21:42:26 -0600 (CST) Received: from leaf.websitewelcome.com (leaf.websitewelcome.com [174.121.85.66]) by gateway05.websitewelcome.com (Postfix) with ESMTP id 1E7A9CEDF3B87 for ; Fri, 14 Dec 2012 21:42:26 -0600 (CST) Received: from [68.162.239.121] (port=57606 helo=[192.168.2.100]) by leaf.websitewelcome.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.80) (envelope-from ) id 1Tjidt-0005hn-J5 for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 21:42:25 -0600 From: Devon Sean McCullough Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: 24.2; lisp/url/url-http.el Date: Fri, 14 Dec 2012 22:41:54 -0500 Message-Id: <210B2BEE-0E3C-4A67-93E3-5C441F926EBE@jovi.net> To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Apple Message framework v1085) X-Mailer: Apple Mail (2.1085) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: yes X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.2.100]) [68.162.239.121]:57606 X-Source-Auth: devon@jovi.net X-Email-Count: 1 X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) * url-http documentation string omits essential info. * url-https source cannot be found by Help nor etags. * url-https definition cannot be found by text search as it omits the defined and defining function names. Here's a fix: --- url-http.el.~1~ 2012-08-23 01:33:42.000000000 -0400 +++ url-http.el 2012-12-14 21:28:51.000000000 -0500 @@ -1177,10 +1177,12 @@ "Retrieve URL via HTTP asynchronously. URL must be a parsed URL. See `url-generic-parse-url' for details. When retrieval is completed, the function CALLBACK is executed with -CBARGS as the arguments. +CBARGS as the arguments and the retrieval buffer as current. =20 Optional arg RETRY-BUFFER, if non-nil, specifies the buffer of a -previous `url-http' call, which is being re-attempted." +previous `url-http' call, which is being re-attempted. + +Return the retrieval buffer." (check-type url vector "Need a pre-parsed URL.") (declare (special url-current-object url-http-end-of-headers @@ -1213,45 +1215,27 @@ (mm-disable-multibyte) (setq url-current-object url mode-line-format "%b [%s]") - - (dolist (var '(url-http-end-of-headers - url-http-content-type - url-http-content-length - url-http-transfer-encoding - url-http-after-change-function - url-http-response-version - url-http-response-status - url-http-chunked-length - url-http-chunked-counter - url-http-chunked-start - url-callback-function - url-callback-arguments - url-show-status - url-http-process - url-http-method - url-http-extra-headers - url-http-data - url-http-target-url - url-http-no-retry - url-http-connection-opened - url-http-proxy)) - (set (make-local-variable var) nil)) - - (setq url-http-method (or url-request-method "GET") - url-http-extra-headers url-request-extra-headers - url-http-data url-request-data - url-http-process connection - url-http-chunked-length nil - url-http-chunked-start nil - url-http-chunked-counter 0 - url-callback-function callback - url-callback-arguments cbargs - url-http-after-change-function = 'url-http-wait-for-headers-change-function - url-http-target-url url-current-object - url-http-no-retry retry-buffer - url-http-connection-opened nil - url-http-proxy url-using-proxy) - + (set (make-local-variable 'url-http-method) (or = url-request-method "GET")) + (set (make-local-variable 'url-http-extra-headers) = url-request-extra-headers) + (set (make-local-variable 'url-http-data) url-request-data) + (set (make-local-variable 'url-http-process) connection) + (set (make-local-variable 'url-http-chunked-length) nil) + (set (make-local-variable 'url-http-chunked-start) nil) + (set (make-local-variable 'url-http-chunked-counter) 0) + (set (make-local-variable 'url-callback-function) callback) + (set (make-local-variable 'url-callback-arguments) cbargs) + (set (make-local-variable 'url-http-after-change-function) = 'url-http-wait-for-headers-change-function) + (set (make-local-variable 'url-http-target-url) = url-current-object) + (set (make-local-variable 'url-http-no-retry) retry-buffer) + (set (make-local-variable 'url-http-connection-opened) nil) + (set (make-local-variable 'url-http-proxy) url-using-proxy) + (set (make-local-variable 'url-http-content-length) ()) + (set (make-local-variable 'url-http-content-type) ()) + (set (make-local-variable 'url-http-end-of-headers) ()) + (set (make-local-variable 'url-http-response-status) ()) + (set (make-local-variable 'url-http-response-version) ()) + (set (make-local-variable 'url-http-transfer-encoding) ()) + (set (make-local-variable 'url-show-status) ()) (set-process-buffer connection buffer) (set-process-filter connection 'url-http-generic-filter) (let ((status (process-status connection))) @@ -1465,21 +1449,25 @@ ;;;###autoload (defalias 'url-https-expand-file-name 'url-default-expander) =20 -(defmacro url-https-create-secure-wrapper (method args) - `(defun ,(intern (format (if method "url-https-%s" "url-https") = method)) ,args - ,(format "HTTPS wrapper around `%s' call." (or method "url-http")) +(defmacro define-url-https-secure-wrapper (name insecure-name) + (let* ((arglist (progn (require 'help-fns) + (help-function-arglist insecure-name = 'preserve-names))) + (arguments (remove '&rest + (remove '&optional + arglist)))) + `(defun ,name ,arglist + ,(format "Https wrapper around `%s' call." insecure-name) (let ((url-gateway-method 'tls)) - (,(intern (format (if method "url-http-%s" "url-http") method)) - ,@(remove '&rest (remove '&optional args)))))) + (,insecure-name .,arguments))))) =20 ;;;###autoload (autoload 'url-https "url-http") -(url-https-create-secure-wrapper nil (url callback cbargs)) +(define-url-https-secure-wrapper url-https url-http) ;;;###autoload (autoload 'url-https-file-exists-p "url-http") -(url-https-create-secure-wrapper file-exists-p (url)) +(define-url-https-secure-wrapper url-https-file-exists-p = url-http-file-exists-p) ;;;###autoload (autoload 'url-https-file-readable-p "url-http") -(url-https-create-secure-wrapper file-readable-p (url)) +(define-url-https-secure-wrapper url-https-file-readable-p = url-http-file-readable-p) ;;;###autoload (autoload 'url-https-file-attributes "url-http") -(url-https-create-secure-wrapper file-attributes (url &optional = id-format)) +(define-url-https-secure-wrapper url-https-file-attributes = url-http-file-attributes) =20 (provide 'url-http) =20= From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 16:21:08 2015 Received: (at 13187) by debbugs.gnu.org; 25 Dec 2015 21:21:08 +0000 Received: from localhost ([127.0.0.1]:35564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCZnP-0000PD-Qd for submit@debbugs.gnu.org; Fri, 25 Dec 2015 16:21:07 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:33851) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCZnO-0000P6-Lw for 13187@debbugs.gnu.org; Fri, 25 Dec 2015 16:21:07 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCZn3-0004dv-6s; Fri, 25 Dec 2015 22:20:45 +0100 From: Lars Ingebrigtsen To: Devon Sean McCullough Subject: Re: bug#13187: 24.2; lisp/url/url-http.el References: <210B2BEE-0E3C-4A67-93E3-5C441F926EBE@jovi.net> Date: Fri, 25 Dec 2015 22:20:44 +0100 In-Reply-To: <210B2BEE-0E3C-4A67-93E3-5C441F926EBE@jovi.net> (Devon Sean McCullough's message of "Fri, 14 Dec 2012 22:41:54 -0500") Message-ID: <871taa1az7.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aCZn3-0004dv-6s X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451683245.38068@aGG7zsA+bifgUYqYHVCEdw X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13187 Cc: 13187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Devon Sean McCullough writes: > * url-http documentation string omits essential info. I've applied your patch to the doc string (with some changes) to the Emacs trunk. > * url-https source cannot be found by Help nor etags. > * url-https definition cannot be found by text search > as it omits the defined and defining function names. > Here's a fix: That's true, but I'm not sure that's really worth fixing... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 16:21:14 2015 Received: (at control) by debbugs.gnu.org; 25 Dec 2015 21:21:14 +0000 Received: from localhost ([127.0.0.1]:35567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCZnW-0000Pa-1Z for submit@debbugs.gnu.org; Fri, 25 Dec 2015 16:21:14 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:33858) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCZnU-0000PQ-Nd for control@debbugs.gnu.org; Fri, 25 Dec 2015 16:21:13 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCZn9-0004e6-ND for control@debbugs.gnu.org; Fri, 25 Dec 2015 22:20:51 +0100 Date: Fri, 25 Dec 2015 22:20:51 +0100 Message-Id: <87ziwyz0lo.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13187 X-MailScanner-ID: 1aCZn9-0004e6-ND X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451683252.10554@83uxHDhk2QDB0jKcM0Zh1A X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 13187 fixed close 13187 25.2 From unknown Tue Jun 24 13:57:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 23 Jan 2016 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator