From unknown Sun Jun 15 08:29:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13169 <13169@debbugs.gnu.org> To: bug#13169 <13169@debbugs.gnu.org> Subject: Status: [PATCH] kill-region fails to deactivate mark after cutting empty region Reply-To: bug#13169 <13169@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:29:30 +0000 retitle 13169 [PATCH] kill-region fails to deactivate mark after cutting em= pty region reassign 13169 emacs submitter 13169 Kelly Dean severity 13169 normal tag 13169 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 13 03:20:23 2012 Received: (at submit) by debbugs.gnu.org; 13 Dec 2012 08:20:23 +0000 Received: from localhost ([127.0.0.1]:39933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tj41n-0004vi-54 for submit@debbugs.gnu.org; Thu, 13 Dec 2012 03:20:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37537) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tj41k-0004vV-6R for submit@debbugs.gnu.org; Thu, 13 Dec 2012 03:20:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj40q-0002XY-VQ for submit@debbugs.gnu.org; Thu, 13 Dec 2012 03:19:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_XBL, RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj40q-0002XS-RX for submit@debbugs.gnu.org; Thu, 13 Dec 2012 03:19:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj40o-0001fV-53 for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:19:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj40k-0002N7-Dv for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:19:21 -0500 Received: from nm23-vm0.bullet.mail.bf1.yahoo.com ([98.139.212.191]:40490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj40k-0002Jh-8P for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:19:18 -0500 Received: from [98.139.212.148] by nm23.bullet.mail.bf1.yahoo.com with NNFMP; 13 Dec 2012 08:19:16 -0000 Received: from [98.139.212.229] by tm5.bullet.mail.bf1.yahoo.com with NNFMP; 13 Dec 2012 08:19:16 -0000 Received: from [127.0.0.1] by omp1038.mail.bf1.yahoo.com with NNFMP; 13 Dec 2012 08:19:16 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 680007.64961.bm@omp1038.mail.bf1.yahoo.com Received: (qmail 25810 invoked by uid 60001); 13 Dec 2012 08:19:16 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1355386756; bh=dIhspwV2FGXyEv+m0ND8FFGep+d7ozu8+x6qPwsct14=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:MIME-Version:Content-Type; b=RMhnMfS9vZ1ky4/r3aTNF0SsoGr6Awiq6d8juTs/G7HroxeDK8qVgvx2TXby2pFDPq27I/kIJ4TyXaqUSnVHhyGZJ/mOzst1Ps7e9kUPqavTOCo4az0BtJhok1QVGJrpYtSPe/LZXCFx3ohceK0H4umn4J56rtg4DOJT6IzEU6k= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:MIME-Version:Content-Type; b=PTKUiSwo5KI6pixbb2E7sJHtcLDoBHNF+7usga3PHS9uaWP1Yahm0fmZLuS5YYyyjEBN/1LWv5VwgoZhGIixyhbJJYCD0Mr8lXO693CrbbGUrCUo+/SqxdFd70mObiFlKTe5uIHtFq9aFIS1VXbOXZx7PZKjg5TP2sbKXqTrIpk=; X-YMail-OSG: 4R1kxdAVM1nPoFPNoitCRVKZzS05vkiOIM7Htv6jqDF3NEg MZ_su5E3yE1Ih396XZ81Bw3Z9OH9T2A2SjiuQYblz9RH3vKMGdVkRhmUzxCj LA_lQz0FTr0mc0NpXHsz9hOCamKp5riQraDFibQrIhj1pg2pxQAbOdj8Gd24 GkFqqtRqdr4jpWXLdbq_zI.ONH9Ic.ddAV5pkX1cOejJmzV_hPzS4YR.b1sd tIBSW9BxJuZIDnPFIdumRl4_a9fgexUNPIV22TE7tOlhlkMLsext6RbsR5Pl N5L9vp7zmmW4VVyFWZrM2iMF_KCqxlco3O0M6bqZNS0QNWKB7W1tIImlIt2V W8IIH3837kyAmfQyntRWu0S2C5iD3A.MmOBTDGqtWb5AlvRWffbaq5tVhCdR djAG_eXq_sKosd1tIoE.42MBYRJiPkRpUHeez6vOtovygRRJD.GeMag-- Received: from [96.44.189.100] by web141106.mail.bf1.yahoo.com via HTTP; Thu, 13 Dec 2012 00:19:16 PST X-Rocket-MIMEInfo: 001.001, T24gMjQuMiwgZW1hY3MgLVEKQy1TUEMgTS13IEMtcApraWxsLXJpbmctc2F2ZSBjb3BpZWQgYW4gZW1wdHkgcmVnaW9uLCBhbmQgZGVhY3RpdmF0ZWQgdGhlIG1hcmsuIFRoaXMgaXMgY29ycmVjdC4gQnV0IG5vdyBkbwpDLVNQQyBDLXcgQy1wCmtpbGwtcmVnaW9uIGN1dCBhbiBlbXB0eSByZWdpb24sIHdoaWNoIGlzIGNvcnJlY3QsIGJ1dCB0aGUgbWFyayBpcyBzdGlsbCBhY3RpdmUsIHdoaWNoIGlzIGluY29ycmVjdC4gV2hlbiB0aGUgYnVmZmVyIGFuZCB0ZXh0IGFyZW4ndCByZWFkLW9ubHksIGtpbGwtcmUBMAEBAQE- X-Mailer: YahooMailClassic/15.1.1 YahooMailWebService/0.8.128.478 Message-ID: <1355386756.25768.YahooMailClassic@web141106.mail.bf1.yahoo.com> Date: Thu, 13 Dec 2012 00:19:16 -0800 (PST) From: Kelly Dean Subject: [PATCH] kill-region fails to deactivate mark after cutting empty region To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1234169369-984943936-1355386756=:25768" X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) --1234169369-984943936-1355386756=:25768 Content-Type: text/plain; charset=us-ascii On 24.2, emacs -Q C-SPC M-w C-p kill-ring-save copied an empty region, and deactivated the mark. This is correct. But now do C-SPC C-w C-p kill-region cut an empty region, which is correct, but the mark is still active, which is incorrect. When the buffer and text aren't read-only, kill-region relies on the command loop to deactivate the mark after the buffer is modified, but when cutting an empty region, the buffer isn't modified, so the mark is never deactivated. The attached killregionbug.patch fixes it. --1234169369-984943936-1355386756=:25768 Content-Type: text/x-diff; name="killregionbug.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="killregionbug.patch" LS0tIGVtYWNzLTI0LjIvbGlzcC9zaW1wbGUuZWwJMjAxMi0wOC0yMiAyMjoz Mzo0Mi4wMDAwMDAwMDAgLTA3MDAKKysrIGVtYWNzLTI0LjIvbGlzcC9zaW1w bGUuZWwubmV3MgkyMDEyLTEyLTEyIDIyOjUyOjQ2LjI1ODQ2MjMwNiAtMDgw MApAQCAtMzIzMyw2ICszMjMzLDcgQEAKIAkgICAgKGtpbGwtbmV3IHN0cmlu ZyBuaWwgeWFuay1oYW5kbGVyKSkpCiAJKHdoZW4gKG9yIHN0cmluZyAoZXEg bGFzdC1jb21tYW5kICdraWxsLXJlZ2lvbikpCiAJICAoc2V0cSB0aGlzLWNv bW1hbmQgJ2tpbGwtcmVnaW9uKSkKKwkoc2V0cSBkZWFjdGl2YXRlLW1hcmsg dCkKIAluaWwpCiAgICAgKChidWZmZXItcmVhZC1vbmx5IHRleHQtcmVhZC1v bmx5KQogICAgICA7OyBUaGUgY29kZSBhYm92ZSBmYWlsZWQgYmVjYXVzZSB0 aGUgYnVmZmVyLCBvciBzb21lIG9mIHRoZSBjaGFyYWN0ZXJzCg== --1234169369-984943936-1355386756=:25768-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 20 22:50:16 2012 Received: (at 13169-done) by debbugs.gnu.org; 21 Dec 2012 03:50:16 +0000 Received: from localhost ([127.0.0.1]:53275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tltcl-0004JH-Fp for submit@debbugs.gnu.org; Thu, 20 Dec 2012 22:50:16 -0500 Received: from mail-pb0-f54.google.com ([209.85.160.54]:38403) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tltci-0004J9-Ra for 13169-done@debbugs.gnu.org; Thu, 20 Dec 2012 22:50:14 -0500 Received: by mail-pb0-f54.google.com with SMTP id wz12so2413241pbc.13 for <13169-done@debbugs.gnu.org>; Thu, 20 Dec 2012 19:50:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=DAjT5OuYK2EvZrl3HVBNwVUaznJc6qF0yMYqZjxWZ6Q=; b=XhUVegmNAgLOI+eC8UbO1oUJRpx6t4IIP4vszJu9kxn0AAZKA0vjgn46cuvOX/9IA4 DQOnP0SGUuW0uYWkf90YRzImGjYX0JV4WNiMJ95252TzGZI7zyMJrW/PrArfDQDbYvtv v/nN3mUisV69t2hOCoA5Zo1/nGiR5D8TFVxf42aKp99mXt+3J1x7TaDznQvl1UQoMiep SWHpR92Zbvdcojcms56SDD6aXvarfqk+L01mjKlNlRXKIMima7kBSN1FbuAYn4niSds/ mGl4ihyj2qo7yQHhuHbJc/Kbb3GYgbnRumwntWUwQa4Xz4biJB/qpjF+8Zsv6DrRPIwH Nh1g== X-Received: by 10.68.251.136 with SMTP id zk8mr35582607pbc.82.1356061800842; Thu, 20 Dec 2012 19:50:00 -0800 (PST) Received: from ulysses ([155.69.18.203]) by mx.google.com with ESMTPS id o6sm6542342paw.37.2012.12.20.19.49.57 (version=SSLv3 cipher=OTHER); Thu, 20 Dec 2012 19:49:59 -0800 (PST) From: Chong Yidong To: Kelly Dean Subject: Re: bug#13169: [PATCH] kill-region fails to deactivate mark after cutting empty region References: <1355386756.25768.YahooMailClassic@web141106.mail.bf1.yahoo.com> Date: Fri, 21 Dec 2012 11:49:54 +0800 In-Reply-To: <1355386756.25768.YahooMailClassic@web141106.mail.bf1.yahoo.com> (Kelly Dean's message of "Thu, 13 Dec 2012 00:19:16 -0800 (PST)") Message-ID: <874njgcbdp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13169-done Cc: 13169-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Kelly Dean writes: > C-SPC C-w C-p > kill-region cut an empty region, which is correct, but the mark is > still active, which is incorrect. When the buffer and text aren't > read-only, kill-region relies on the command loop to deactivate the > mark after the buffer is modified, but when cutting an empty region, > the buffer isn't modified, so the mark is never deactivated. > The attached killregionbug.patch fixes it. Committed to trunk, thanks. From unknown Sun Jun 15 08:29:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Jan 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator