From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode References: In-Reply-To: Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jan 2013 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Elias Pipping Cc: 13164@debbugs.gnu.org Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.135776330911241 (code B ref 13164); Wed, 09 Jan 2013 20:29:02 +0000 Received: (at 13164) by debbugs.gnu.org; 9 Jan 2013 20:28:29 +0000 Received: from localhost ([127.0.0.1]:59108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt2GC-0002vG-Vc for submit@debbugs.gnu.org; Wed, 09 Jan 2013 15:28:29 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:58014) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt2GC-0002v4-HM for 13164@debbugs.gnu.org; Wed, 09 Jan 2013 15:28:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtkGAG6Zu0+4rw8T/2dsb2JhbABEgXuyFoEIghUBAQRXIwUWNCYYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="212162632" Received: from 184-175-15-19.dsl.teksavvy.com (HELO pastel.home) ([184.175.15.19]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 09 Jan 2013 15:28:11 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5BF5F592A7; Wed, 9 Jan 2013 15:28:11 -0500 (EST) From: Stefan Monnier Message-ID: Date: Wed, 09 Jan 2013 15:28:11 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I sent a patch to this list last year that made it possible to use > mupdf's "mudraw" instead of ghostscript's "gs" to convert pdf documents > into png files within doc-view-mode. Thanks, I've just installed your mupdf patch with a few cosmetic changes, thank you. The djvu patch is still pending, [...] Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [206.248.154.182 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] 1.5 FAKE_REPLY_C FAKE_REPLY_C X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I sent a patch to this list last year that made it possible to use > mupdf's "mudraw" instead of ghostscript's "gs" to convert pdf documents > into png files within doc-view-mode. Thanks, I've just installed your mupdf patch with a few cosmetic changes, thank you. The djvu patch is still pending, [...] Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [206.248.154.182 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4981] 1.5 FAKE_REPLY_C FAKE_REPLY_C > I sent a patch to this list last year that made it possible to use > mupdf's "mudraw" instead of ghostscript's "gs" to convert pdf documents > into png files within doc-view-mode. Thanks, I've just installed your mupdf patch with a few cosmetic changes, thank you. The djvu patch is still pending, Stefan From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Elias Pipping Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jan 2013 00:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 13164@debbugs.gnu.org Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.135777698132501 (code B ref 13164); Thu, 10 Jan 2013 00:17:01 +0000 Received: (at 13164) by debbugs.gnu.org; 10 Jan 2013 00:16:21 +0000 Received: from localhost ([127.0.0.1]:59187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt5of-0008S7-W9 for submit@debbugs.gnu.org; Wed, 09 Jan 2013 19:16:20 -0500 Received: from karen.lavabit.com ([72.249.41.33]:34675) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt5oL-0008RH-7H for 13164@debbugs.gnu.org; Wed, 09 Jan 2013 19:16:00 -0500 Received: from c.earth.lavabit.com (c.earth.lavabit.com [192.168.111.12]) by karen.lavabit.com (Postfix) with ESMTP id 0D11611BC6C; Wed, 9 Jan 2013 18:15:44 -0600 (CST) Received: from bogus (e178038187.adsl.alicedsl.de [85.178.38.187]) by lavabit.com with ESMTP id W704MIR22VQC; Wed, 09 Jan 2013 18:15:44 -0600 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=wkM9GP5Mf5Skiq8xZAt7yd4rKSZyADBKETFhHWQWoTnF6xdyw277birRacKQhBpWJB6IM0RIS2q3qVUrT5kCy4D24nSLn/gZbC6Fhnj9nSs3YpHD0jaQHGsnmvdeJZbaINHD0vCn8H8j5Ug2YpRoxURTuxkO+ELBySCmzRm3w28=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type; From: Elias Pipping References: Date: Thu, 10 Jan 2013 01:15:28 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 09 Jan 2013 15:28:11 -0500") Message-ID: <8738y999lr.fsf@lavabit.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> I sent a patch to this list last year that made it possible to use >> mupdf's "mudraw" instead of ghostscript's "gs" to convert pdf documents >> into png files within doc-view-mode. > > Thanks, I've just installed your mupdf patch with a few cosmetic > changes, thank you. > The djvu patch is still pending, I see you've pushed the djvu patch as well. Thank you; also for the modifications you've made. I've attached three more tiny patches. Best regards, Elias Pipping --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Enable-doc-view-for-djvu-files.patch >From 887b136fa79c81422c3fddc858e446f26ac71ab7 Mon Sep 17 00:00:00 2001 From: Elias Pipping Date: Thu, 10 Jan 2013 00:56:50 +0100 Subject: [PATCH 1/3] Enable doc-view for djvu files --- lisp/files.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/files.el b/lisp/files.el index ca5a415..9fea670 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -2357,7 +2357,7 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode) ("\\.\\(diffs?\\|patch\\|rej\\)\\'" . diff-mode) ("\\.\\(dif\\|pat\\)\\'" . diff-mode) ; for MSDOG ("\\.[eE]?[pP][sS]\\'" . ps-mode) - ("\\.\\(?:PDF\\|DVI\\|OD[FGPST]\\|DOCX?\\|XLSX?\\|PPTX?\\|pdf\\|dvi\\|od[fgpst]\\|docx?\\|xlsx?\\|pptx?\\)\\'" . doc-view-mode-maybe) + ("\\.\\(?:PDF\\|DVI\\|DJVU\\|OD[FGPST]\\|DOCX?\\|XLSX?\\|PPTX?\\|pdf\\|djvu\\|dvi\\|od[fgpst]\\|docx?\\|xlsx?\\|pptx?\\)\\'" . doc-view-mode-maybe) ("configure\\.\\(ac\\|in\\)\\'" . autoconf-mode) ("\\.s\\(v\\|iv\\|ieve\\)\\'" . sieve-mode) ("BROWSE\\'" . ebrowse-tree-mode) -- 1.8.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-single-page-converter-need-not-be-passed.patch >From a8a298ab5b6a2c12e7cca16af81ba76fd54d1c9a Mon Sep 17 00:00:00 2001 From: Elias Pipping Date: Thu, 10 Jan 2013 00:59:16 +0100 Subject: [PATCH 2/3] single-page-converter need not be passed --- lisp/doc-view.el | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 0658a11..5f2d70d 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -970,7 +970,7 @@ Call CALLBACK with no arguments when done." (declare-function clear-image-cache "image.c" (&optional filter)) -(defun doc-view-document->png (pdf png pages single-page-converter) +(defun doc-view-document->png (pdf png pages) ;; FIXME: Fix docstring. "Convert a PDF file to PNG asynchronously. Start by converting PAGES, and then the rest." @@ -981,7 +981,7 @@ Start by converting PAGES, and then the rest." ;; a single page anyway, and of the remaining 1%, few cases will have ;; consecutive pages, it's not worth the trouble. (let ((rest (cdr pages))) - (funcall single-page-converter + (funcall doc-view-single-page-converter-function pdf (format png (car pages)) (car pages) (lambda () (if rest @@ -1095,12 +1095,10 @@ Those files are saved in the directory given by the function (`pdf (let ((pages (doc-view-active-pages))) ;; Convert PDF to PNG images starting with the active pages. - (doc-view-document->png doc-view-buffer-file-name png-file pages - 'doc-view-pdf->png-1))) + (doc-view-document->png doc-view-buffer-file-name png-file pages))) (`djvu (let ((pages (doc-view-active-pages))) - (doc-view-document->png doc-view-buffer-file-name png-file pages - 'doc-view-djvu->png-1))) + (doc-view-document->png doc-view-buffer-file-name png-file pages))) (_ ;; Convert to PNG images. (doc-view-pdf/ps->png doc-view-buffer-file-name png-file))))) -- 1.8.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-Detect-properly-if-PDFs-can-be-handled.patch >From 31244c43ecf24945db95c823c020eccb68d3ef1d Mon Sep 17 00:00:00 2001 From: Elias Pipping Date: Thu, 10 Jan 2013 01:12:45 +0100 Subject: [PATCH 3/3] Detect properly if PDFs can be handled --- lisp/doc-view.el | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 5f2d70d..8065b3e 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -708,11 +708,18 @@ OpenDocument format)." (executable-find doc-view-dvipdf-program)) (and doc-view-dvipdfm-program (executable-find doc-view-dvipdfm-program))))) - ((or (eq type 'postscript) (eq type 'ps) (eq type 'eps) - (eq type 'pdf)) - ;; FIXME: allow mupdf here + ((or (eq type 'postscript) (eq type 'ps) (eq type 'eps)) (and doc-view-ghostscript-program (executable-find doc-view-ghostscript-program))) + ((eq type 'pdf) + (pcase doc-view-pdf->png-converter-function + (`doc-view-pdf->png-converter-ghostscript + (and doc-view-ghostscript-program + (executable-find doc-view-ghostscript-program))) + (`doc-view-pdf->png-converter-mupdf + (and doc-view-pdfdraw-program + (executable-find doc-view-pdfdraw-program))) + (_ t))) ;; Assume the user knows what he/she is doing ((eq type 'odf) (and doc-view-unoconv-program (executable-find doc-view-unoconv-program) -- 1.8.1 --=-=-=-- From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jan 2013 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Elias Pipping Cc: 13164@debbugs.gnu.org Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.135783303913750 (code B ref 13164); Thu, 10 Jan 2013 15:51:02 +0000 Received: (at 13164) by debbugs.gnu.org; 10 Jan 2013 15:50:39 +0000 Received: from localhost ([127.0.0.1]:54329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TtKOs-0003Zj-PL for submit@debbugs.gnu.org; Thu, 10 Jan 2013 10:50:39 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:17100) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TtKOr-0003ZV-38 for 13164@debbugs.gnu.org; Thu, 10 Jan 2013 10:50:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtkGAG6Zu0+4rw8T/2dsb2JhbABEgXuyFoEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="212227750" Received: from 184-175-15-19.dsl.teksavvy.com (HELO pastel.home) ([184.175.15.19]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Jan 2013 10:50:29 -0500 Received: by pastel.home (Postfix, from userid 20848) id D197959230; Thu, 10 Jan 2013 10:50:28 -0500 (EST) From: Stefan Monnier Message-ID: References: <8738y999lr.fsf@lavabit.com> Date: Thu, 10 Jan 2013 10:50:28 -0500 In-Reply-To: <8738y999lr.fsf@lavabit.com> (Elias Pipping's message of "Thu, 10 Jan 2013 01:15:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > I've attached three more tiny patches. Thanks, installed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 10 10:51:44 2013 Received: (at control) by debbugs.gnu.org; 10 Jan 2013 15:51:44 +0000 Received: from localhost ([127.0.0.1]:54334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TtKPw-0003bQ-50 for submit@debbugs.gnu.org; Thu, 10 Jan 2013 10:51:44 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14712) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TtKPv-0003bF-4l for control@debbugs.gnu.org; Thu, 10 Jan 2013 10:51:43 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtkGAG6Zu0+4rw8T/2dsb2JhbABEgXuyFoEIghEFAQUZPTMLNBIUGA2GAAeCKBa6CY0mgx4DiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="212227833" Received: from 184-175-15-19.dsl.teksavvy.com (HELO pastel.home) ([184.175.15.19]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Jan 2013 10:51:36 -0500 Received: by pastel.home (Postfix, from userid 20848) id D4A9D59230; Thu, 10 Jan 2013 10:51:35 -0500 (EST) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: [PATCH] View DjVu documents through doc-view-mode Message-ID: References: <8738y999lr.fsf@lavabit.com> Date: Thu, 10 Jan 2013 10:51:35 -0500 In-Reply-To: <8738y999lr.fsf@lavabit.com> (Elias Pipping's message of "Thu, 10 Jan 2013 01:15:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) close 13164 thanks From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Tassilo Horn Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jan 2013 15:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 13164@debbugs.gnu.org, Elias Pipping Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.135791658323739 (code B ref 13164); Fri, 11 Jan 2013 15:04:01 +0000 Received: (at 13164) by debbugs.gnu.org; 11 Jan 2013 15:03:03 +0000 Received: from localhost ([127.0.0.1]:55640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ttg8M-0006Aq-PJ for submit@debbugs.gnu.org; Fri, 11 Jan 2013 10:03:02 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:36925) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ttg8K-0006AP-2r for 13164@debbugs.gnu.org; Fri, 11 Jan 2013 10:03:01 -0500 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 5E9EA3D600E; Fri, 11 Jan 2013 16:02:52 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 59jr9I5Qf8uw; Fri, 11 Jan 2013 16:02:51 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from thinkpad.tsdh.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id B39503D6007; Fri, 11 Jan 2013 16:02:51 +0100 (CET) From: Tassilo Horn References: <8738y999lr.fsf@lavabit.com> Date: Fri, 11 Jan 2013 16:02:48 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 10 Jan 2013 10:50:28 -0500") Message-ID: <87wqvj3gpz.fsf@thinkpad.tsdh.de> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.6 (-) Stefan Monnier writes: Hi Elias & Stefan, >> I've attached three more tiny patches. > > Thanks, installed, I really like the new mupdf support. It's much faster than ghostscript. There seems to be some minor issue, though: the last-page counter in the mode-line doesn't seem to be updated properly during conversion. I've just tested with some 700 pages PDF. Initially, it displayed "1/4" but didn't increase anymore. To make it update again, I needed to do something, e.g., switch to another page or just scroll a bit. Bye, Tassilo From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Elias Pipping Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Jan 2013 23:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Tassilo Horn Cc: 13164@debbugs.gnu.org, Stefan Monnier Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.13588099108107 (code B ref 13164); Mon, 21 Jan 2013 23:12:02 +0000 Received: (at 13164) by debbugs.gnu.org; 21 Jan 2013 23:11:50 +0000 Received: from localhost ([127.0.0.1]:43652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxQWq-00026e-W3 for submit@debbugs.gnu.org; Mon, 21 Jan 2013 18:11:50 -0500 Received: from karen.lavabit.com ([72.249.41.33]:46778) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxQWn-00026T-24 for 13164@debbugs.gnu.org; Mon, 21 Jan 2013 18:11:47 -0500 Received: from d.earth.lavabit.com (d.earth.lavabit.com [192.168.111.13]) by karen.lavabit.com (Postfix) with ESMTP id 44E0911BC29; Mon, 21 Jan 2013 17:10:36 -0600 (CST) Received: from bogus (e178024159.adsl.alicedsl.de [85.178.24.159]) by lavabit.com with ESMTP id ZIJ9PXMQ8P9B; Mon, 21 Jan 2013 17:10:36 -0600 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=rPe1Emtc2/rHSJQNdXI39T3321HS0z4QWY2IO/LH5aHm5MJ/OrRTOYACGix4wzxYElCwtxEOYE7ewC6mkoxlOdudVGPiKJ5xSFkqY3Qns7HyRHij3SbAhlmQYkmklmFMjRch0fhLBZn6DCQqUvyX+MstkTw57fllgg4S7Pzs0pE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type; From: Elias Pipping References: <8738y999lr.fsf@lavabit.com> <87wqvj3gpz.fsf@thinkpad.tsdh.de> Date: Tue, 22 Jan 2013 00:10:32 +0100 In-Reply-To: <87wqvj3gpz.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Fri, 11 Jan 2013 16:02:48 +0100") Message-ID: <87fw1u2kuv.fsf@lavabit.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) --=-=-= Content-Type: text/plain Tassilo Horn writes: > Stefan Monnier writes: > > Hi Elias & Stefan, > >>> I've attached three more tiny patches. >> >> Thanks, installed, > > I really like the new mupdf support. It's much faster than ghostscript. > > There seems to be some minor issue, though: the last-page counter in the > mode-line doesn't seem to be updated properly during conversion. I've > just tested with some 700 pages PDF. Initially, it displayed "1/4" but > didn't increase anymore. To make it update again, I needed to do > something, e.g., switch to another page or just scroll a bit. Indeed, I can reproduce your problem with a recent version of emacs, namely commit c5a8149837c5ed53655d4383dea3b8f29374b266 Author: Glenn Morris Date: Sat Jan 19 18:40:49 2013 -0800 * lisp-mode.el (emacs-lisp-mode-map): Add native profiler menu entries. I do not have it with emacs 24.2.92 and my original two patches (I'm attaching them in case you want to verify that; please note that you need to have (setq doc-view-pdf->png-converter-invocation 'doc-view-pdf->png-converter-invocation-mupdf) in your init.el with that version for mupdf to be used). So it must've snuck in sometime after. Best regards, Elias Pipping --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-doc-view-pdf-png-1-customizable.patch >From f6684796d3a9cb0016b50251d9b36a4c618855c1 Mon Sep 17 00:00:00 2001 From: Elias Pipping Date: Sun, 26 Jun 2011 20:02:29 +0200 Subject: [PATCH 1/2] Make doc-view-pdf->png-1 customizable This allows mupdf's mudraw to be used as a pdf->png converter Not only is it faster than ghostscript, it also does anti-aliasing --- lisp/doc-view.el | 73 ++++++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index f8975a5..8e1b309 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -158,6 +158,26 @@ :type 'file :group 'doc-view) +(defcustom doc-view-pdfdraw-program "mudraw" + "Program to convert PDF files to PNG." + :type 'file + :group 'doc-view) + +(defcustom doc-view-pdf->png-converter-invocation + 'doc-view-pdf->png-converter-invocation-ghostscript + "Called to convert a PDF file into a PNG file" + :type '(radio (function-item doc-view-pdf->png-converter-invocation-ghostscript :doc "Use ghostscript") + (function-item doc-view-pdf->png-converter-invocation-mupdf :doc "Use mupdf") + function) + :group 'doc-view) + +(defcustom doc-view-ps->png-converter-invocation + 'doc-view-ps->png-converter-invocation-ghostscript + "Called to convert a PS file into a PNG file" + :type '(radio (function-item doc-view-ps->png-converter-invocation-ghostscript :doc "Use ghostscript") + function) + :group 'doc-view) + (defcustom doc-view-ghostscript-options '("-dSAFER" ;; Avoid security problems when rendering files from untrusted ;; sources. @@ -653,6 +673,7 @@ OpenDocument format)." (executable-find doc-view-dvipdfm-program))))) ((or (eq type 'postscript) (eq type 'ps) (eq type 'eps) (eq type 'pdf)) + ;; FIXME: allow mupdf here (and doc-view-ghostscript-program (executable-find doc-view-ghostscript-program))) ((eq type 'odf) @@ -817,6 +838,25 @@ Should be invoked when the cached images aren't up-to-date." (list "-o" pdf dvi) callback))) +(defun doc-view-pdf->png-converter-invocation-ghostscript (resolution pdf png &optional page) + `((command . ,doc-view-ghostscript-program) + (arguments . (,@doc-view-ghostscript-options + ,(format "-r%d" resolution) + ,@(if page `(,(format "-dFirstPage=%d" page))) + ,@(if page `(,(format "-dLastPage=%d" page))) + ,(concat "-sOutputFile=" png) + ,pdf)))) + +(defalias 'doc-view-ps->png-converter-invocation-ghostscript + 'doc-view-pdf->png-converter-invocation-ghostscript) + +(defun doc-view-pdf->png-converter-invocation-mupdf (resolution pdf png &optional page) + `((command . ,doc-view-pdfdraw-program) + (arguments . (,(concat "-o" png) + ,(format "-r%d" resolution) + ,pdf + ,@(if page `(,(format "%d" page))))))) + (defun doc-view-odf->pdf (odf callback) "Convert ODF to PDF asynchronously and call CALLBACK when finished. The converted PDF is put into the current cache directory, and it @@ -827,12 +867,14 @@ is named like ODF with the extension turned to pdf." (defun doc-view-pdf/ps->png (pdf-ps png) "Convert PDF-PS to PNG asynchronously." - (doc-view-start-process - "pdf/ps->png" doc-view-ghostscript-program - (append doc-view-ghostscript-options - (list (format "-r%d" (round doc-view-resolution)) - (concat "-sOutputFile=" png) - pdf-ps)) + (let ((invocation (case doc-view-doc-type + (pdf (funcall doc-view-pdf->png-converter-invocation + (round doc-view-resolution) pdf-ps png)) + (t (funcall doc-view-ps->png-converter-invocation + (round doc-view-resolution) pdf-ps png))))) + (doc-view-start-process + "pdf/ps->png" (cdr (assoc 'command invocation)) + (cdr (assoc 'arguments invocation)) (let ((resolution doc-view-resolution)) (lambda () ;; Only create the resolution file when it's all done, so it also @@ -844,7 +886,7 @@ is named like ODF with the extension turned to pdf." (when doc-view-current-timer (cancel-timer doc-view-current-timer) (setq doc-view-current-timer nil)) - (doc-view-display (current-buffer) 'force)))) + (doc-view-display (current-buffer) 'force))))) ;; Update the displayed pages as soon as they're done generating. (when doc-view-conversion-refresh-interval (setq doc-view-current-timer @@ -855,17 +897,12 @@ is named like ODF with the extension turned to pdf." (defun doc-view-pdf->png-1 (pdf png page callback) "Convert a PAGE of a PDF file to PNG asynchronously. Call CALLBACK with no arguments when done." - (doc-view-start-process - "pdf->png-1" doc-view-ghostscript-program - (append doc-view-ghostscript-options - (list (format "-r%d" (round doc-view-resolution)) - ;; Sadly, `gs' only supports the page-range - ;; for PDF files. - (format "-dFirstPage=%d" page) - (format "-dLastPage=%d" page) - (concat "-sOutputFile=" png) - pdf)) - callback)) + (let ((invocation (funcall doc-view-pdf->png-converter-invocation + (round doc-view-resolution) pdf png page))) + (doc-view-start-process + "pdf/ps->png" (cdr (assoc 'command invocation)) + (cdr (assoc 'arguments invocation)) + callback))) (declare-function clear-image-cache "image.c" (&optional filter)) -- 1.8.0.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-Add-DjVu-support.patch >From c02ac7ce9db90f1772658beae4dd0c51debf0bdd Mon Sep 17 00:00:00 2001 From: Elias Pipping Date: Sat, 1 Sep 2012 18:15:11 +0200 Subject: [PATCH 2/2] Add DjVu support --- lisp/doc-view.el | 135 ++++++++++++++++++++++++++++++++++++++++++------------- lisp/files.el | 2 +- 2 files changed, 106 insertions(+), 31 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 8e1b309..ea2023e 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -138,6 +138,7 @@ ;;; Code: (eval-when-compile (require 'cl-lib)) +(require 'cl) (require 'dired) (require 'image-mode) (require 'jka-compr) @@ -145,7 +146,7 @@ ;;;; Customization Options (defgroup doc-view nil - "In-buffer viewer for PDF, PostScript and DVI files." + "In-buffer viewer for PDF, PostScript, DVI, and DJVU files." :link '(function-link doc-view) :version "22.2" :group 'applications @@ -171,6 +172,18 @@ function) :group 'doc-view) +(defcustom doc-view-ddjvu-program "ddjvu" + "Program to convert DjVu files to PNG." + :type 'file + :group 'doc-view) + +(defcustom doc-view-djvu->png-converter-invocation + 'doc-view-djvu->png-converter-invocation-ddjvu + "Called to convert a DJVU file into a PNG file" + :type '(radio (function-item doc-view-djvu->png-converter-invocation-ddjvu :doc "Use ddjvu") + function) + :group 'doc-view) + (defcustom doc-view-ps->png-converter-invocation 'doc-view-ps->png-converter-invocation-ghostscript "Called to convert a PS file into a PNG file" @@ -332,6 +345,17 @@ the (uncompressed, extracted) file residing in "The type of document in the current buffer. Can be `dvi', `pdf', or `ps'.") +(defvar doc-view-single-page-converter nil + "Called to convert a single page of the document to a PNG file.") + +(defvar doc-view-image-type nil + "The type of image in the current buffer. +Can be `png' or `tiff'.") + +(defvar doc-view-image-file-extension nil + "The file extension of the image type in the current buffer. +Can be `png' or `tif'.") + ;;;; DocView Keymaps (defvar doc-view-mode-map @@ -470,24 +494,25 @@ Can be `dvi', `pdf', or `ps'.") ;; We used to find the file name from doc-view-current-files but ;; that's not right if the pages are not generated sequentially ;; or if the page isn't in doc-view-current-files yet. - (let ((file (expand-file-name (format "page-%d.png" page) + (let ((file (expand-file-name (format "page-%d.%s" page doc-view-image-file-extension) (doc-view-current-cache-dir)))) (doc-view-insert-image file :pointer 'arrow) (set-window-hscroll (selected-window) hscroll) (when (and (not (file-exists-p file)) doc-view-current-converter-processes) ;; The PNG file hasn't been generated yet. - (doc-view-pdf->png-1 doc-view-buffer-file-name file page - (let ((win (selected-window))) - (lambda () - (and (eq (current-buffer) (window-buffer win)) - ;; If we changed page in the mean - ;; time, don't mess things up. - (eq (doc-view-current-page win) page) - ;; Make sure we don't infloop. - (file-readable-p file) - (with-selected-window win - (doc-view-goto-page page)))))))) + (funcall doc-view-single-page-converter + doc-view-buffer-file-name file page + (let ((win (selected-window))) + (lambda () + (and (eq (current-buffer) (window-buffer win)) + ;; If we changed page in the mean + ;; time, don't mess things up. + (eq (doc-view-current-page win) page) + ;; Make sure we don't infloop. + (file-readable-p file) + (with-selected-window win + (doc-view-goto-page page)))))))) (overlay-put (doc-view-current-overlay) 'help-echo (doc-view-current-info)))) @@ -663,7 +688,7 @@ Document types are symbols like `dvi', `ps', `pdf', or `odf' (any OpenDocument format)." (and (display-graphic-p) (or (image-type-available-p 'imagemagick) - (image-type-available-p 'png)) + (image-type-available-p 'png)) ; FIXME: do not check for PNG with djvu (cond ((eq type 'dvi) (and (doc-view-mode-p 'pdf) @@ -680,6 +705,8 @@ OpenDocument format)." (and doc-view-unoconv-program (executable-find doc-view-unoconv-program) (doc-view-mode-p 'pdf))) + ((eq type 'djvu) + (executable-find doc-view-ddjvu-program)) ; FIXME: check for TIFF with djvu (t ;; unknown image type nil)))) @@ -850,6 +877,16 @@ Should be invoked when the cached images aren't up-to-date." (defalias 'doc-view-ps->png-converter-invocation-ghostscript 'doc-view-pdf->png-converter-invocation-ghostscript) +(defun doc-view-djvu->png-converter-invocation-ddjvu (resolution djvu png &optional page) + `((command . ,doc-view-ddjvu-program) + (arguments . ("-format=tiff" + ,(format "-scale=%d" resolution) ; ddjvu only accepts the range 1-999 + ;; -eachpage was only added after djvulibre-3.5.25.3! + ,@(unless page '("-eachpage")) + ,@(if page `(,(format "-page=%d" page))) + ,djvu + ,png)))) + (defun doc-view-pdf->png-converter-invocation-mupdf (resolution pdf png &optional page) `((command . ,doc-view-pdfdraw-program) (arguments . (,(concat "-o" png) @@ -867,10 +904,12 @@ is named like ODF with the extension turned to pdf." (defun doc-view-pdf/ps->png (pdf-ps png) "Convert PDF-PS to PNG asynchronously." - (let ((invocation (case doc-view-doc-type - (pdf (funcall doc-view-pdf->png-converter-invocation + (let ((invocation (pcase doc-view-doc-type + (`pdf (funcall doc-view-pdf->png-converter-invocation (round doc-view-resolution) pdf-ps png)) - (t (funcall doc-view-ps->png-converter-invocation + (`djvu (funcall doc-view-djvu->png-converter-invocation + (round doc-view-resolution) pdf-ps png)) + (_ (funcall doc-view-ps->png-converter-invocation (round doc-view-resolution) pdf-ps png))))) (doc-view-start-process "pdf/ps->png" (cdr (assoc 'command invocation)) @@ -904,9 +943,19 @@ Call CALLBACK with no arguments when done." (cdr (assoc 'arguments invocation)) callback))) +(defun doc-view-djvu->png-1 (djvu png page callback) + "Convert a PAGE of a DJVU file to PNG asynchronously. +Call CALLBACK with no arguments when done." + (let ((invocation (funcall doc-view-djvu->png-converter-invocation + (round doc-view-resolution) djvu png page))) + (doc-view-start-process + "djvu->png" (cdr (assoc 'command invocation)) + (cdr (assoc 'arguments invocation)) + callback))) + (declare-function clear-image-cache "image.c" (&optional filter)) -(defun doc-view-pdf->png (pdf png pages) +(defun doc-view-document->png (pdf png pages) "Convert a PDF file to PNG asynchronously. Start by converting PAGES, and then the rest." (if (null pages) @@ -916,11 +965,11 @@ Start by converting PAGES, and then the rest." ;; a single page anyway, and of the remaining 1%, few cases will have ;; consecutive pages, it's not worth the trouble. (let ((rest (cdr pages))) - (doc-view-pdf->png-1 - pdf (format png (car pages)) (car pages) + (funcall doc-view-single-page-converter + pdf (format png (car pages)) (car pages) (lambda () (if rest - (doc-view-pdf->png pdf png rest) + (doc-view-document->png pdf png rest) ;; Yippie, the important pages are done, update the display. (clear-image-cache) ;; For the windows that have a message (like "Welcome to @@ -928,8 +977,8 @@ Start by converting PAGES, and then the rest." ;; not sufficient. (dolist (win (get-buffer-window-list (current-buffer) nil 'visible)) (with-selected-window win - (when (stringp (get-char-property (point-min) 'display)) - (doc-view-goto-page (doc-view-current-page))))) + (when (stringp (get-char-property (point-min) 'display)) + (doc-view-goto-page (doc-view-current-page))))) ;; Convert the rest of the pages. (doc-view-pdf/ps->png pdf png))))))) @@ -999,7 +1048,7 @@ Those files are saved in the directory given by the function ;; preserves the horizontal/vertical scroll settings (which are otherwise ;; resets during the redisplay). (setq doc-view-pending-cache-flush t) - (let ((png-file (expand-file-name "page-%d.png" + (let ((png-file (expand-file-name (concat "page-%d." doc-view-image-file-extension) (doc-view-current-cache-dir)))) (make-directory (doc-view-current-cache-dir) t) (pcase doc-view-doc-type @@ -1028,7 +1077,10 @@ Those files are saved in the directory given by the function (`pdf (let ((pages (doc-view-active-pages))) ;; Convert PDF to PNG images starting with the active pages. - (doc-view-pdf->png doc-view-buffer-file-name png-file pages))) + (doc-view-document->png doc-view-buffer-file-name png-file pages))) + (`djvu + (let ((pages (doc-view-active-pages))) + (doc-view-document->png doc-view-buffer-file-name png-file pages))) (_ ;; Convert to PNG images. (doc-view-pdf/ps->png doc-view-buffer-file-name png-file))))) @@ -1171,7 +1223,7 @@ ARGS is a list of image descriptors." (let ((ol (doc-view-current-overlay)) (image (if (and file (file-readable-p file)) (if (not (fboundp 'imagemagick-types)) - (apply 'create-image file 'png nil args) + (apply 'create-image file doc-view-image-type nil args) (unless (member :width args) (setq args (append args (list :width doc-view-image-width)))) (apply 'create-image file 'imagemagick nil args)))) @@ -1221,12 +1273,12 @@ have the page we want to view." (let ((prev-pages doc-view-current-files)) (setq doc-view-current-files (sort (directory-files (doc-view-current-cache-dir) t - "page-[0-9]+\\.png" t) + (concat "page-[0-9]+\\." doc-view-image-file-extension) t) 'doc-view-sort)) (dolist (win (or (get-buffer-window-list buffer nil t) (list t))) (let* ((page (doc-view-current-page win)) - (pagefile (expand-file-name (format "page-%d.png" page) + (pagefile (expand-file-name (format "page-%d.%s" page doc-view-image-file-extension) (doc-view-current-cache-dir)))) (when (or force (and (not (member pagefile prev-pages)) @@ -1421,7 +1473,7 @@ If BACKWARD is non-nil, jump to the previous match." (file-readable-p (expand-file-name "resolution.el" (doc-view-current-cache-dir))) (> (length (directory-files (doc-view-current-cache-dir) - nil "\\.png\\'")) + nil (concat "\\." doc-view-image-file-extension "\\'"))) 0))) (defun doc-view-initiate-display () @@ -1494,6 +1546,8 @@ If BACKWARD is non-nil, jump to the previous match." ("pdf" pdf) ("epdf" pdf) ;; PostScript ("ps" ps) ("eps" ps) + ;; DjVu + ("djvu" djvu) ;; OpenDocument formats ("odt" odf) ("ods" odf) ("odp" odf) ("odg" odf) ("odc" odf) ("odi" odf) ("odm" odf) ("ott" odf) @@ -1508,7 +1562,8 @@ If BACKWARD is non-nil, jump to the previous match." (cond ((looking-at "%!") '(ps)) ((looking-at "%PDF") '(pdf)) - ((looking-at "\367\002") '(dvi)))))) + ((looking-at "\367\002") '(dvi)) + ((looking-at "AT&TFORM") '(djvu)))))) (set (make-local-variable 'doc-view-doc-type) (car (or (doc-view-intersection name-types content-types) (when (and name-types content-types) @@ -1517,6 +1572,24 @@ If BACKWARD is non-nil, jump to the previous match." name-types content-types (error "Cannot determine the document type")))))) +(defun doc-view-set-up-single-converter () + "Find the right single-page converter for the current document type" + (set (make-local-variable 'doc-view-single-page-converter) + (pcase doc-view-doc-type + (`djvu 'doc-view-djvu->png-1) + (_ 'doc-view-pdf->png-1)))) + +(defun doc-view-prepare-for-images () + "Figure out the appropriate image type for the current document type" + (multiple-value-bind (type extension) + (pcase doc-view-doc-type + (`djvu (values 'tiff "tif")) + (_ (values 'png "png"))) + (set (make-local-variable 'doc-view-image-type) + type) + (set (make-local-variable 'doc-view-image-file-extension) + extension))) + ;;;###autoload (defun doc-view-mode () "Major mode in DocView buffers. @@ -1549,6 +1622,8 @@ toggle between displaying the document or editing it as text. ;; Figure out the document type. (unless doc-view-doc-type (doc-view-set-doc-type)) + (doc-view-set-up-single-converter) + (doc-view-prepare-for-images) (doc-view-make-safe-dir doc-view-cache-directory) ;; Handle compressed files, remote files, files inside archives diff --git a/lisp/files.el b/lisp/files.el index 62ad96c..c52ef28 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -2355,7 +2355,7 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode) ("\\.\\(diffs?\\|patch\\|rej\\)\\'" . diff-mode) ("\\.\\(dif\\|pat\\)\\'" . diff-mode) ; for MSDOG ("\\.[eE]?[pP][sS]\\'" . ps-mode) - ("\\.\\(?:PDF\\|DVI\\|OD[FGPST]\\|DOCX?\\|XLSX?\\|PPTX?\\|pdf\\|dvi\\|od[fgpst]\\|docx?\\|xlsx?\\|pptx?\\)\\'" . doc-view-mode-maybe) + ("\\.\\(?:PDF\\|DVI\\|OD[FGPST]\\|DOCX?\\|XLSX?\\|PPTX?\\|pdf\\|dvi\\|djvu\\|od[fgpst]\\|docx?\\|xlsx?\\|pptx?\\)\\'" . doc-view-mode-maybe) ("configure\\.\\(ac\\|in\\)\\'" . autoconf-mode) ("\\.s\\(v\\|iv\\|ieve\\)\\'" . sieve-mode) ("BROWSE\\'" . ebrowse-tree-mode) -- 1.8.0.2 --=-=-=-- From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jan 2013 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Elias Pipping Cc: 13164@debbugs.gnu.org, Tassilo Horn Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.13588669996394 (code B ref 13164); Tue, 22 Jan 2013 15:04:02 +0000 Received: (at 13164) by debbugs.gnu.org; 22 Jan 2013 15:03:19 +0000 Received: from localhost ([127.0.0.1]:44811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxfNf-0001f5-8A for submit@debbugs.gnu.org; Tue, 22 Jan 2013 10:03:19 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45998) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxfNc-0001ex-N3 for 13164@debbugs.gnu.org; Tue, 22 Jan 2013 10:03:17 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r0MF1w7g021322; Tue, 22 Jan 2013 10:01:59 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E2A8CAE3F6; Tue, 22 Jan 2013 10:02:03 -0500 (EST) From: Stefan Monnier Message-ID: References: <8738y999lr.fsf@lavabit.com> <87wqvj3gpz.fsf@thinkpad.tsdh.de> <87fw1u2kuv.fsf@lavabit.com> Date: Tue, 22 Jan 2013 10:02:03 -0500 In-Reply-To: <87fw1u2kuv.fsf@lavabit.com> (Elias Pipping's message of "Tue, 22 Jan 2013 00:10:32 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4469=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4469> : streams <892874> : uri <1324984> X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) >> There seems to be some minor issue, though: the last-page counter in the >> mode-line doesn't seem to be updated properly during conversion. I've [...] > Indeed, I can reproduce your problem with a recent version of Emacs Could someone bisect to find the commit that introduced this problem? Stefan From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Tassilo Horn Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jan 2013 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 13164@debbugs.gnu.org, Elias Pipping Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.13588683628359 (code B ref 13164); Tue, 22 Jan 2013 15:27:02 +0000 Received: (at 13164) by debbugs.gnu.org; 22 Jan 2013 15:26:02 +0000 Received: from localhost ([127.0.0.1]:44830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Txfjd-0002AW-JM for submit@debbugs.gnu.org; Tue, 22 Jan 2013 10:26:02 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:44690) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Txfja-0002AO-KC for 13164@debbugs.gnu.org; Tue, 22 Jan 2013 10:26:00 -0500 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 4F4961A8477; Tue, 22 Jan 2013 16:24:47 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JRousYaaEKpH; Tue, 22 Jan 2013 16:24:47 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from thinkpad.tsdh.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id ED8021A847E; Tue, 22 Jan 2013 16:24:46 +0100 (CET) From: Tassilo Horn References: <8738y999lr.fsf@lavabit.com> <87wqvj3gpz.fsf@thinkpad.tsdh.de> <87fw1u2kuv.fsf@lavabit.com> Date: Tue, 22 Jan 2013 16:24:45 +0100 In-Reply-To: (Stefan Monnier's message of "Tue, 22 Jan 2013 10:02:03 -0500") Message-ID: <87d2wxqlz6.fsf@thinkpad.tsdh.de> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) Stefan Monnier writes: >>> There seems to be some minor issue, though: the last-page counter in >>> the mode-line doesn't seem to be updated properly during conversion. >>> I've > [...] >> Indeed, I can reproduce your problem with a recent version of Emacs > > Could someone bisect to find the commit that introduced this problem? Yes, I can do that. I'll report back when I'm done. Bye, Tassilo From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Tassilo Horn Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jan 2013 09:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 13164@debbugs.gnu.org, Elias Pipping Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.135893471217387 (code B ref 13164); Wed, 23 Jan 2013 09:52:02 +0000 Received: (at 13164) by debbugs.gnu.org; 23 Jan 2013 09:51:52 +0000 Received: from localhost ([127.0.0.1]:45664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Txwzo-0004WM-5C for submit@debbugs.gnu.org; Wed, 23 Jan 2013 04:51:52 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:32834) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Txwzj-0004Vz-NS for 13164@debbugs.gnu.org; Wed, 23 Jan 2013 04:51:49 -0500 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 75BB83D6063; Wed, 23 Jan 2013 10:49:24 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ObGNZsBYRACs; Wed, 23 Jan 2013 10:49:23 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from thinkpad.tsdh.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 3A4D23D6741; Wed, 23 Jan 2013 10:42:35 +0100 (CET) From: Tassilo Horn References: <8738y999lr.fsf@lavabit.com> <87wqvj3gpz.fsf@thinkpad.tsdh.de> <87fw1u2kuv.fsf@lavabit.com> <87d2wxqlz6.fsf@thinkpad.tsdh.de> Date: Wed, 23 Jan 2013 10:42:33 +0100 In-Reply-To: <87d2wxqlz6.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Tue, 22 Jan 2013 16:24:45 +0100") Message-ID: <87r4lc1bhy.fsf@thinkpad.tsdh.de> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) Tassilo Horn writes: Hi! >>>> There seems to be some minor issue, though: the last-page counter >>>> in the mode-line doesn't seem to be updated properly during >>>> conversion. I've >> [...] >>> Indeed, I can reproduce your problem with a recent version of Emacs >> >> Could someone bisect to find the commit that introduced this problem? > > Yes, I can do that. I'll report back when I'm done. Ok, I'm done. --8<---------------cut here---------------start------------->8--- 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d is the first bad commit commit 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d Author: Dmitry Antipov Date: Tue Dec 11 13:51:12 2012 +0400 * buffer.c (Fset_buffer_multibyte): Do not force redisplay if changed buffer is not shown in a window. * insdel.c (prepare_to_modify_buffer): Likewise. * window.c (replace_buffer_in_windows_safely): Do nothing if buffer is not shown in a window. (Fforce_window_update): Likewise if string or buffer argument is passed. :040000 040000 c3cd9f89a3926ca04ecfee03ae667056986ba352 385c925b8bcfcc59262a140e4ce8701b20eb7265 M src --8<---------------cut here---------------end--------------->8--- In bzr, that's revno 111189. BTW: I first tried the bzr bisect plugin, but I got frequent conflicts in cl-loaddefs.el when it switched to another revision. I used "bzr resolve --take-other lisp/emacs-lisp/cl-loaddefs.el", and in the end the bisection aborted somehow. I also had lots of problems with files that were added/removed between revisions. Are there any instructions on doing bisection on emacs bzr? Maybe I've just operated bzr bisect wrongly... Anyway, git bisect on the git mirror worked flawlessly. Bye, Tassilo From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jan 2013 13:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Antipov Cc: 13164@debbugs.gnu.org, Elias Pipping , Tassilo Horn Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.13589472001796 (code B ref 13164); Wed, 23 Jan 2013 13:20:01 +0000 Received: (at 13164) by debbugs.gnu.org; 23 Jan 2013 13:20:00 +0000 Received: from localhost ([127.0.0.1]:45887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty0FD-0000Ss-Cu for submit@debbugs.gnu.org; Wed, 23 Jan 2013 08:20:00 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47032) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty0FA-0000Sc-6R for 13164@debbugs.gnu.org; Wed, 23 Jan 2013 08:19:57 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r0NDIcAR005865; Wed, 23 Jan 2013 08:18:39 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 4658DAE194; Wed, 23 Jan 2013 08:18:37 -0500 (EST) From: Stefan Monnier Message-ID: References: <8738y999lr.fsf@lavabit.com> <87wqvj3gpz.fsf@thinkpad.tsdh.de> <87fw1u2kuv.fsf@lavabit.com> <87d2wxqlz6.fsf@thinkpad.tsdh.de> <87r4lc1bhy.fsf@thinkpad.tsdh.de> Date: Wed, 23 Jan 2013 08:18:37 -0500 In-Reply-To: <87r4lc1bhy.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Wed, 23 Jan 2013 10:42:33 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: * X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 1 X-NAI-Spam-Rules: 2 Rules triggered AFF_LOTTO_1=1, RV4470=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4470> : streams <893456> : uri <1325815> X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) >>> Could someone bisect to find the commit that introduced this problem? >> Yes, I can do that. I'll report back when I'm done. > Ok, I'm done. Thank you very much. > --8<---------------cut here---------------start------------->8--- > 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d is the first bad commit > commit 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d > Author: Dmitry Antipov > Date: Tue Dec 11 13:51:12 2012 +0400 > * buffer.c (Fset_buffer_multibyte): Do not force redisplay > if changed buffer is not shown in a window. > * insdel.c (prepare_to_modify_buffer): Likewise. > * window.c (replace_buffer_in_windows_safely): Do nothing > if buffer is not shown in a window. > (Fforce_window_update): Likewise if string or buffer argument > is passed. Dmitry, could you take a look at this? It looks like the new code's more aggressive avoidance of redisplay ends up leaving some mode-lines out-of-date after running timers. I don't see any immediate connection between the above commit message and doc-view's timer behavior, so maybe the problem is a problem in your commit. OTOH maybe doc-view was simply lucky that the redisplay was not optimized enough and we should really use something like the patch below, > Are there any instructions on doing bisection on emacs bzr? My impression that "bzr bisect" is in the same boat as "bzr switch" and "bzr rebase": kinda works sometimes, but not nearly robust enough. Stefan === modified file 'lisp/doc-view.el' --- lisp/doc-view.el 2013-01-10 15:50:04 +0000 +++ lisp/doc-view.el 2013-01-23 13:14:23 +0000 @@ -1265,6 +1265,8 @@ "[0-9]+") t) 'doc-view-sort)) + (unless (eq (length prev-pages) (length doc-view-current-files)) + (force-mode-line-update)) (dolist (win (or (get-buffer-window-list buffer nil t) (list t))) (let* ((page (doc-view-current-page win)) From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Dmitry Antipov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jan 2013 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 13164@debbugs.gnu.org, Elias Pipping , Tassilo Horn Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.135895294223117 (code B ref 13164); Wed, 23 Jan 2013 14:56:02 +0000 Received: (at 13164) by debbugs.gnu.org; 23 Jan 2013 14:55:42 +0000 Received: from localhost ([127.0.0.1]:46057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty1jl-00060e-Rh for submit@debbugs.gnu.org; Wed, 23 Jan 2013 09:55:41 -0500 Received: from forward1.mail.yandex.net ([77.88.46.6]:46068) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty1jd-0005zn-8Y for 13164@debbugs.gnu.org; Wed, 23 Jan 2013 09:55:35 -0500 Received: from smtp2.mail.yandex.net (smtp2.mail.yandex.net [77.88.46.102]) by forward1.mail.yandex.net (Yandex) with ESMTP id 416651245779; Wed, 23 Jan 2013 18:54:12 +0400 (MSK) Received: from smtp2.mail.yandex.net (localhost [127.0.0.1]) by smtp2.mail.yandex.net (Yandex) with ESMTP id E27B1E203E5; Wed, 23 Jan 2013 18:54:11 +0400 (MSK) Received: from unknown (unknown [37.139.80.10]) by smtp2.mail.yandex.net (nwsmtp/Yandex) with ESMTP id sBdaxTkL-sBdmb3pw; Wed, 23 Jan 2013 18:54:11 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1358952851; bh=bcXW34mNMGWXlNWTTpZPsOviSrV55/j+TcWqgX60tNg=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=l1Bt+0FS1Qr85B3aIFQv7fPQKG16SJiFfCgT36uV6N6W2tk1FX0tTtdJW/zj25PpA Texi8+soJiZlcwqFJNXUkRYHIQPTVgfMsUs/HsV/YuhnEJei38UXX/F/VCV9CQdGlW fTPj1mgvROK5Cw4TXSwfg3yHpYtMaRQnB0RQG7+Y= Message-ID: <50FFF993.2090206@yandex.ru> Date: Wed, 23 Jan 2013 18:54:11 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 References: <8738y999lr.fsf@lavabit.com> <87wqvj3gpz.fsf@thinkpad.tsdh.de> <87fw1u2kuv.fsf@lavabit.com> <87d2wxqlz6.fsf@thinkpad.tsdh.de> <87r4lc1bhy.fsf@thinkpad.tsdh.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) On 01/23/2013 05:18 PM, Stefan Monnier wrote: > Dmitry, could you take a look at this? It looks like the new code's > more aggressive avoidance of redisplay ends up leaving some mode-lines > out-of-date after running timers. Should be fixed by bzr commit 111589. Dmitry From unknown Sun Jun 22 00:21:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Resent-From: Tassilo Horn Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Jan 2013 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Antipov Cc: 13164-done@debbugs.gnu.org, Stefan Monnier , Elias Pipping Received: via spool by 13164-done@debbugs.gnu.org id=D13164.13590132377033 (code D ref 13164); Thu, 24 Jan 2013 07:41:02 +0000 Received: (at 13164-done) by debbugs.gnu.org; 24 Jan 2013 07:40:37 +0000 Received: from localhost ([127.0.0.1]:47276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyHQK-0001pN-5d for submit@debbugs.gnu.org; Thu, 24 Jan 2013 02:40:37 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:38371) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyHQF-0001pD-Ve for 13164-done@debbugs.gnu.org; Thu, 24 Jan 2013 02:40:34 -0500 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 6E7791A8979; Thu, 24 Jan 2013 08:40:17 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VXbIUBGvkk78; Thu, 24 Jan 2013 08:40:16 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from thinkpad.tsdh.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 4E9801A89A3; Thu, 24 Jan 2013 08:39:56 +0100 (CET) From: Tassilo Horn References: <8738y999lr.fsf@lavabit.com> <87wqvj3gpz.fsf@thinkpad.tsdh.de> <87fw1u2kuv.fsf@lavabit.com> <87d2wxqlz6.fsf@thinkpad.tsdh.de> <87r4lc1bhy.fsf@thinkpad.tsdh.de> <50FFF993.2090206@yandex.ru> Date: Thu, 24 Jan 2013 08:39:55 +0100 In-Reply-To: <50FFF993.2090206@yandex.ru> (Dmitry Antipov's message of "Wed, 23 Jan 2013 18:54:11 +0400") Message-ID: <87d2wvni5w.fsf@thinkpad.tsdh.de> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) Dmitry Antipov writes: >> Dmitry, could you take a look at this? It looks like the new code's >> more aggressive avoidance of redisplay ends up leaving some >> mode-lines out-of-date after running timers. > > Should be fixed by bzr commit 111589. Confirmed, it works again. Thanks Dmitry! I'm closing the bug since the original issue (the DjVu patches) have already been applied. Bye, Tassilo