From unknown Mon Jun 23 20:15:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13152 <13152@debbugs.gnu.org> To: bug#13152 <13152@debbugs.gnu.org> Subject: Status: 24.2.90; [REGRESSION] dired-get-marked-files changed Reply-To: bug#13152 <13152@debbugs.gnu.org> Date: Tue, 24 Jun 2025 03:15:38 +0000 retitle 13152 24.2.90; [REGRESSION] dired-get-marked-files changed reassign 13152 emacs submitter 13152 Leo severity 13152 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 11 21:24:38 2012 Received: (at submit) by debbugs.gnu.org; 12 Dec 2012 02:24:38 +0000 Received: from localhost ([127.0.0.1]:37856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tibzx-0007ko-DH for submit@debbugs.gnu.org; Tue, 11 Dec 2012 21:24:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:32786) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tibzv-0007kh-9t for submit@debbugs.gnu.org; Tue, 11 Dec 2012 21:24:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TibzA-0006MN-R4 for submit@debbugs.gnu.org; Tue, 11 Dec 2012 21:23:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:37780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TibzA-0006MI-Nt for submit@debbugs.gnu.org; Tue, 11 Dec 2012 21:23:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tibz5-0000o8-SW for bug-gnu-emacs@gnu.org; Tue, 11 Dec 2012 21:23:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tibz1-0006KW-U3 for bug-gnu-emacs@gnu.org; Tue, 11 Dec 2012 21:23:43 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:60333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tibz1-0006KQ-ON for bug-gnu-emacs@gnu.org; Tue, 11 Dec 2012 21:23:39 -0500 Received: by mail-pb0-f41.google.com with SMTP id xa7so108427pbc.0 for ; Tue, 11 Dec 2012 18:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=pQECmSq8+HnD5WK6UhYXTeXPhzSrKCWc9KxT1wzy6Aw=; b=li6IW8QhHiBX3Y7rHdPdWfWiVFvzwLD0Tsdn+F1KOAfORh8TPaLXzt+6aabrlqMvsy 3b1V3Eq3c/WKCmKxUUV8Gmn+zFBo/0X0cWYsWvw7ONeet1hTdMkPHo1eUPjw5AlibqD8 QPWg+S6Hx7v01FUGba7nAuSMbBNNGo9oF4DGL+ZSsbJqN0cyUoS5mDY5gIfk/jsdqGSY qjexwAJcVJDR1YTgSeAdJix38l6wc2rlZH+yA4cRWumqoeaZDkAHtajSElj5kutSEJJg l/TNs5hQUKmIZnVmhqMs/N2apchD20oRYiKjJ6VGEUBm+vRblqODuLBP+S1SVhZVlkEy Fvmw== Received: by 10.66.76.41 with SMTP id h9mr1254736paw.1.1355279018622; Tue, 11 Dec 2012 18:23:38 -0800 (PST) Received: from localhost ([119.255.41.67]) by mx.google.com with ESMTPS id c2sm9278773pay.34.2012.12.11.18.23.35 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Dec 2012 18:23:37 -0800 (PST) From: Leo To: bug-gnu-emacs@gnu.org Subject: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Wed, 12 Dec 2012 10:23:26 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) 1. Eval (progn (require 'dired-x) (setq dired-guess-shell-alist-user '(("." (let ((files (dired-get-marked-files t current-prefix-arg))) (message "%S" (current-buffer)) (dired-guess-default files)))))) 2. In a dired buffer, run `!' (dired-do-shell-command) twice first without marking any file then with some files marked You should get an error when files are marked. You'll notice in the second run, the current-buffer has changed to ' *Marked Files*'. Note in previous versions of Emacs, dired-get-marked-files throws an error when run in a non-dired buffer, but in 24.2.90 it returns '(nil). Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 11 21:47:56 2012 Received: (at 13152) by debbugs.gnu.org; 12 Dec 2012 02:47:56 +0000 Received: from localhost ([127.0.0.1]:37871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TicMW-0008KV-Lm for submit@debbugs.gnu.org; Tue, 11 Dec 2012 21:47:56 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:45416) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TicMU-0008KO-Mv for 13152@debbugs.gnu.org; Tue, 11 Dec 2012 21:47:55 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TicLl-0005BG-Ho; Tue, 11 Dec 2012 21:47:09 -0500 From: Glenn Morris To: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: X-Spook: Uzi SHA high security Mossad KGB Cohiba Kh-11 FSF X-Ran: THeH>P-#%.>%j);z`,m:7xkp?v\4/VRto/0K (Leo's message of "Wed, 12 Dec 2012 10:23:26 +0800") Message-ID: <7hd2ygng0i.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Leo wrote: > 1. Eval > (progn > (require 'dired-x) > (setq dired-guess-shell-alist-user > '(("." (let ((files (dired-get-marked-files t current-prefix-arg))) > (message "%S" (current-buffer)) > (dired-guess-default files)))))) > > 2. In a dired buffer, run `!' (dired-do-shell-command) Simply doing that, I get Variable binding depth exceeds max-specpdl-size (or its equivalent) all the way back to 22.1. Is this a recipe from emacs -Q, and if so which versions of Emacs is it supposed to work in? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 11 21:48:18 2012 Received: (at control) by debbugs.gnu.org; 12 Dec 2012 02:48:18 +0000 Received: from localhost ([127.0.0.1]:37875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TicMr-0008Lj-So for submit@debbugs.gnu.org; Tue, 11 Dec 2012 21:48:18 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:45424) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TicMp-0008Lc-Qc for control@debbugs.gnu.org; Tue, 11 Dec 2012 21:48:16 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TicM7-0005D3-Ez for control@debbugs.gnu.org; Tue, 11 Dec 2012 21:47:31 -0500 Date: Tue, 11 Dec 2012 21:47:31 -0500 Message-Id: Subject: control message for bug 13152 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) tag 13152 moreinfo unreproducible From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 12 00:31:27 2012 Received: (at submit) by debbugs.gnu.org; 12 Dec 2012 05:31:28 +0000 Received: from localhost ([127.0.0.1]:37994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tieul-0005nF-EM for submit@debbugs.gnu.org; Wed, 12 Dec 2012 00:31:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59468) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tieui-0005n7-SX for submit@debbugs.gnu.org; Wed, 12 Dec 2012 00:31:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tietu-0002aj-Gs for submit@debbugs.gnu.org; Wed, 12 Dec 2012 00:30:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tietu-0002af-Dx for submit@debbugs.gnu.org; Wed, 12 Dec 2012 00:30:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tieto-00016u-Pr for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 00:30:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tietj-0002Yz-7K for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 00:30:28 -0500 Received: from plane.gmane.org ([80.91.229.3]:45891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tietj-0002Yr-0Y for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 00:30:23 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Tietq-0004No-Cw for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 06:30:30 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Dec 2012 06:30:30 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Dec 2012 06:30:30 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Wed, 12 Dec 2012 13:30:05 +0800 Lines: 23 Message-ID: References: <7hd2ygng0i.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (OS X 10.8.2) Cancel-Lock: sha1:aG5k0CMgrDWbqqSRlLkNV12n2lI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2012-12-12 10:47 +0800, Glenn Morris wrote: > Is this a recipe from emacs -Q, and if so which versions of Emacs is it > supposed to work in? Sorry. My fault. Eval this instead: (progn (require 'dired-x) (setq dired-guess-shell-alist-user '(("." (let ((files (dired-get-marked-files t current-prefix-arg))) (message "%S" (current-buffer)) (let (dired-guess-shell-alist-user) (dired-guess-default files))))))) Eval (dired-get-marked-files t current-prefix-arg) in dired and non-dired buffers will do too. My recipe is to single out the problem of buffer changing by dired-get-marked-files, which makes forms in dired-guess-shell-alist-user hard to predict. Leo From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 12 03:14:18 2012 Received: (at 13152) by debbugs.gnu.org; 12 Dec 2012 08:14:18 +0000 Received: from localhost ([127.0.0.1]:38110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TihSL-0001Yh-ID for submit@debbugs.gnu.org; Wed, 12 Dec 2012 03:14:18 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:51816) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TihSJ-0001Ya-D0 for 13152@debbugs.gnu.org; Wed, 12 Dec 2012 03:14:16 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TihRY-0006rJ-Bv; Wed, 12 Dec 2012 03:13:28 -0500 From: Glenn Morris To: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <7hd2ygng0i.fsf@fencepost.gnu.org> X-Spook: Blowfish munitions New World Order Steve Case threat X-Ran: ?f%'+<=mH'gcobzBX51,cF&$cb)s;Q"P{7"Ijg%>u4Hv_x<:/Fsu^PILo=gz])>2s\GI1i X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 12 Dec 2012 03:13:28 -0500 In-Reply-To: (Leo's message of "Wed, 12 Dec 2012 13:30:05 +0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Leo wrote: > (progn > (require 'dired-x) > (setq dired-guess-shell-alist-user > '(("." (let ((files (dired-get-marked-files t current-prefix-arg))) > (message "%S" (current-buffer)) > (let (dired-guess-shell-alist-user) > (dired-guess-default files))))))) When more than one file is marked, this says "no file on this line" in 24.2, and "Wrong type argument: stringp, nil" in 24.2.90. It's not obvious to me that this matters. > Eval (dired-get-marked-files t current-prefix-arg) in dired and > non-dired buffers will do too. Why does is matter what a dired command does in non-dired buffers? > My recipe is to single out the problem of buffer changing by > dired-get-marked-files, I'm totally lost. Maybe someone else gets it. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 12 04:35:27 2012 Received: (at 13152) by debbugs.gnu.org; 12 Dec 2012 09:35:28 +0000 Received: from localhost ([127.0.0.1]:38156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tiiit-0003Um-NA for submit@debbugs.gnu.org; Wed, 12 Dec 2012 04:35:27 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:35219 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tiiio-0003UR-T2 for 13152@debbugs.gnu.org; Wed, 12 Dec 2012 04:35:23 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 1CE55451C164; Wed, 12 Dec 2012 01:34:35 -0800 (PST) From: Juri Linkov To: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Organization: JURTA References: Date: Wed, 12 Dec 2012 11:29:20 +0200 In-Reply-To: (Leo's message of "Wed, 12 Dec 2012 10:23:26 +0800") Message-ID: <87fw3bpqir.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > You'll notice in the second run, the current-buffer has changed to > ' *Marked Files*'. Despite the recent changes in `dired-mark-pop-up' that added `with-temp-buffer-window' the same behavior is observable in older versions too. For more than 1 file the call to `(apply function args)' is performed in the buffer " *Marked Files*" (in the QUIT-FUNCTION arg of `with-temp-buffer-window'). > Note in previous versions of Emacs, dired-get-marked-files throws an > error when run in a non-dired buffer, but in 24.2.90 it returns '(nil). This is a result of the following change: http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/110668 I see no problems with this. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 12 06:33:41 2012 Received: (at submit) by debbugs.gnu.org; 12 Dec 2012 11:33:41 +0000 Received: from localhost ([127.0.0.1]:38241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TikZJ-0006SN-1U for submit@debbugs.gnu.org; Wed, 12 Dec 2012 06:33:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48676) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TikZG-0006SE-VF for submit@debbugs.gnu.org; Wed, 12 Dec 2012 06:33:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TikYN-0001Ih-8k for submit@debbugs.gnu.org; Wed, 12 Dec 2012 06:32:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:59994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TikYN-0001Id-6G for submit@debbugs.gnu.org; Wed, 12 Dec 2012 06:32:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TikYH-00058I-HI for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 06:32:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TikY7-0001H9-Nh for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 06:32:37 -0500 Received: from plane.gmane.org ([80.91.229.3]:50327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TikY7-0001H5-Hn for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 06:32:27 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TikYF-00045e-S8 for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 12:32:35 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Dec 2012 12:32:35 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Dec 2012 12:32:35 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Wed, 12 Dec 2012 19:32:13 +0800 Lines: 12 Message-ID: References: <87fw3bpqir.fsf@mail.jurta.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (OS X 10.8.2) Cancel-Lock: sha1:NRrutDuTZFv547jJvXisIfV5zKs= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) On 2012-12-12 17:29 +0800, Juri Linkov wrote: [snipped 3 lines] > I see no problems with this. On 2012-12-12 16:13 +0800, Glenn Morris wrote: [snipped 22 lines] > I'm totally lost. Maybe someone else gets it. See dired-guess-shell-alist-user, COMMAND can be an expression which is eval'd in different contexts (buffers) and that is a problem. Leo From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 12 18:13:48 2012 Received: (at 13152) by debbugs.gnu.org; 12 Dec 2012 23:13:48 +0000 Received: from localhost ([127.0.0.1]:39677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TivUp-0005GF-4q for submit@debbugs.gnu.org; Wed, 12 Dec 2012 18:13:48 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:51806 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TivUn-0005G4-30 for 13152@debbugs.gnu.org; Wed, 12 Dec 2012 18:13:45 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id EDC52451E1B6; Wed, 12 Dec 2012 15:12:54 -0800 (PST) From: Juri Linkov To: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Organization: JURTA References: <87fw3bpqir.fsf@mail.jurta.org> Date: Thu, 13 Dec 2012 01:11:39 +0200 In-Reply-To: (Leo's message of "Wed, 12 Dec 2012 19:32:13 +0800") Message-ID: <8738zasw5w.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) >> I see no problems with this. > > See dired-guess-shell-alist-user, COMMAND can be an expression which is > eval'd in different contexts (buffers) and that is a problem. Actually I meant there is no bug because the documentation of dired-guess-shell-alist-user says nothing about the current buffer. But indeed you have a problem when trying to do undocumented things. Without changing the source code you can reuse the existing variable `files' dynamically bound in `dired-guess-shell-command' like: (progn (require 'dired-x) (setq dired-guess-shell-alist-user '(("." (progn (message "%S" files) (let (dired-guess-shell-alist-user) (dired-guess-default files))))))) This is bad practice but acceptable for ~/.emacs. Regarding changing the current buffer in `dired-mark-pop-up' where an expression is evaluated, I have doubts because it might broke code that relies on the fact that the selected window and the current buffer should be " *Marked Files*" as it was in all older versions. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 12 20:21:38 2012 Received: (at submit) by debbugs.gnu.org; 13 Dec 2012 01:21:38 +0000 Received: from localhost ([127.0.0.1]:39720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TixUY-0000gg-9Q for submit@debbugs.gnu.org; Wed, 12 Dec 2012 20:21:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58651) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TixUV-0000gY-8z for submit@debbugs.gnu.org; Wed, 12 Dec 2012 20:21:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TixTg-0001iq-Kr for submit@debbugs.gnu.org; Wed, 12 Dec 2012 20:20:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TixTg-0001im-E1 for submit@debbugs.gnu.org; Wed, 12 Dec 2012 20:20:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TixTf-00009Q-Ha for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 20:20:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TixTe-0001ia-J9 for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 20:20:43 -0500 Received: from plane.gmane.org ([80.91.229.3]:48719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TixTe-0001iS-5X for bug-gnu-emacs@gnu.org; Wed, 12 Dec 2012 20:20:42 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TixTp-0002AF-Is for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 02:20:53 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 13 Dec 2012 02:20:53 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 13 Dec 2012 02:20:53 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Thu, 13 Dec 2012 09:20:31 +0800 Lines: 25 Message-ID: References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (OS X 10.8.2) Cancel-Lock: sha1:zMSDxghuzk1iqe+7g9cp87kIZds= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) On 2012-12-13 07:11 +0800, Juri Linkov wrote: > (progn > (require 'dired-x) > (setq dired-guess-shell-alist-user > '(("." (progn > (message "%S" files) > (let (dired-guess-shell-alist-user) > (dired-guess-default files))))))) > > This is bad practice but acceptable for ~/.emacs. I fixed my setup before sending the bug report, pretty much as you did here. > Regarding changing the current buffer in `dired-mark-pop-up' > where an expression is evaluated, I have doubts because > it might broke code that relies on the fact that the > selected window and the current buffer should be " *Marked Files*" > as it was in all older versions. Note in previous versions dired-mark-pop-up throws an error in that buffer so I am pretty sure no code will expect COMMAND to be eval'd in " *Marked Files*". Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 13 20:05:49 2012 Received: (at 13152) by debbugs.gnu.org; 14 Dec 2012 01:05:49 +0000 Received: from localhost ([127.0.0.1]:41524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjJim-0004WW-Re for submit@debbugs.gnu.org; Thu, 13 Dec 2012 20:05:49 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:54055 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjJij-0004W8-8v for 13152@debbugs.gnu.org; Thu, 13 Dec 2012 20:05:47 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 41B33451E1EF; Thu, 13 Dec 2012 17:04:49 -0800 (PST) From: Juri Linkov To: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Organization: JURTA References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> Date: Fri, 14 Dec 2012 02:46:43 +0200 In-Reply-To: (Leo's message of "Thu, 13 Dec 2012 09:20:31 +0800") Message-ID: <87obhxbgdw.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) >> Regarding changing the current buffer in `dired-mark-pop-up' >> where an expression is evaluated, I have doubts because >> it might broke code that relies on the fact that the >> selected window and the current buffer should be " *Marked Files*" >> as it was in all older versions. > > Note in previous versions dired-mark-pop-up throws an error in that > buffer so I am pretty sure no code will expect COMMAND to be eval'd in > " *Marked Files*". The doubt raises the fact that evaluating the expression after selecting " *Marked Files*" was intentionally coded this way in `dired-mark-pop-up': (with-selected-window window (unwind-protect (apply function args) (when (window-live-p window) (quit-restore-window window 'kill)))) I guess the reason was to allow quit-restore-window to kill the " *Marked Files*" buffer after the minibuffer (that reads a command) is displayed and exited in `(apply function args)'. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 13 22:06:52 2012 Received: (at submit) by debbugs.gnu.org; 14 Dec 2012 03:06:52 +0000 Received: from localhost ([127.0.0.1]:41601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjLbw-00008V-LT for submit@debbugs.gnu.org; Thu, 13 Dec 2012 22:06:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40072) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjLbv-00008O-1o for submit@debbugs.gnu.org; Thu, 13 Dec 2012 22:06:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjLb0-00042L-6b for submit@debbugs.gnu.org; Thu, 13 Dec 2012 22:05:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjLb0-00042H-44 for submit@debbugs.gnu.org; Thu, 13 Dec 2012 22:05:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjLaz-0000GJ-2m for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 22:05:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjLay-00041z-29 for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 22:05:53 -0500 Received: from plane.gmane.org ([80.91.229.3]:34425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjLax-00041n-Rd for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 22:05:51 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TjLb6-00029W-Na for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 04:06:00 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 14 Dec 2012 04:06:00 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 14 Dec 2012 04:06:00 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Fri, 14 Dec 2012 11:05:24 +0800 Lines: 26 Message-ID: References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (OS X 10.8.2) Cancel-Lock: sha1:WU0PwrBpLdh++7QWGX3Fj9W/IvI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2012-12-14 08:46 +0800, Juri Linkov wrote: > The doubt raises the fact that evaluating the expression after > selecting " *Marked Files*" was intentionally coded this way > in `dired-mark-pop-up': > > (with-selected-window window > (unwind-protect > (apply function args) > (when (window-live-p window) > (quit-restore-window window 'kill)))) > > I guess the reason was to allow quit-restore-window to kill the > " *Marked Files*" buffer after the minibuffer (that reads a command) > is displayed and exited in `(apply function args)'. Could be but I only know superficially about the new `window' thingie. My concern is mainly from the user's point of view. This is a trap that is there to trick every user as soon as they start using lisp expression for COMMAND. And if we let dired-mark-pop-up run in the HIDDEN ' *marked files*' buffer without throwing an error, users might grow to rely on it. Harder to get it right later. I think the old behaviour is probably not the best but better, and eval COMMAND should be in the dired buffer. This is what users expect. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 14 05:27:12 2012 Received: (at 13152) by debbugs.gnu.org; 14 Dec 2012 10:27:12 +0000 Received: from localhost ([127.0.0.1]:41932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSU4-0004mK-GA for submit@debbugs.gnu.org; Fri, 14 Dec 2012 05:27:12 -0500 Received: from mout.gmx.net ([212.227.15.18]:55820) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSU1-0004mB-QV for 13152@debbugs.gnu.org; Fri, 14 Dec 2012 05:27:10 -0500 Received: from mailout-de.gmx.net ([10.1.76.27]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0LnVZY-1TCq9C08lS-00heCx for <13152@debbugs.gnu.org>; Fri, 14 Dec 2012 11:26:12 +0100 Received: (qmail invoked by alias); 14 Dec 2012 10:26:11 -0000 Received: from 62-47-53-23.adsl.highway.telekom.at (EHLO [62.47.53.23]) [62.47.53.23] by mail.gmx.net (mp027) with SMTP; 14 Dec 2012 11:26:11 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/YFgdevnvYvosPIQwLj1STEFXrKlIal+/mw6+Qsx ay95FigxdyXerl Message-ID: <50CAFEBC.6000208@gmx.at> Date: Fri, 14 Dec 2012 11:26:04 +0100 From: martin rudalics MIME-Version: 1.0 To: Juri Linkov Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> In-Reply-To: <87obhxbgdw.fsf@mail.jurta.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: Leo , 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > The doubt raises the fact that evaluating the expression after > selecting " *Marked Files*" was intentionally coded this way > in `dired-mark-pop-up': > > (with-selected-window window > (unwind-protect > (apply function args) > (when (window-live-p window) > (quit-restore-window window 'kill)))) > > I guess the reason was to allow quit-restore-window to kill the > " *Marked Files*" buffer after the minibuffer (that reads a command) > is displayed and exited in `(apply function args)'. I suppose we can safely do #'(lambda (window _value) (unwind-protect (apply function args) (with-selected-window window (when (window-live-p window) (quit-restore-window window 'kill))))) instead if people think it's better. But FUNCTION "should not manipulate files, just read input \(an argument or confirmation)." so I don't see why this matters. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 14 05:27:24 2012 Received: (at 13152) by debbugs.gnu.org; 14 Dec 2012 10:27:24 +0000 Received: from localhost ([127.0.0.1]:41935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSUF-0004mg-RG for submit@debbugs.gnu.org; Fri, 14 Dec 2012 05:27:24 -0500 Received: from mout.gmx.net ([212.227.17.20]:54237) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSUD-0004mY-Ge for 13152@debbugs.gnu.org; Fri, 14 Dec 2012 05:27:22 -0500 Received: from mailout-de.gmx.net ([10.1.76.37]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MDjZQ-1TuwPA3CsI-00H57n for <13152@debbugs.gnu.org>; Fri, 14 Dec 2012 11:26:22 +0100 Received: (qmail invoked by alias); 14 Dec 2012 10:26:22 -0000 Received: from 62-47-53-23.adsl.highway.telekom.at (EHLO [62.47.53.23]) [62.47.53.23] by mail.gmx.net (mp037) with SMTP; 14 Dec 2012 11:26:22 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18/CFsWhZc/RM3mRzZWzuZwVMnop88KNxyYsA+XQ1 kXvdvUVkq6gND/ Message-ID: <50CAFEC7.6050102@gmx.at> Date: Fri, 14 Dec 2012 11:26:15 +0100 From: martin rudalics MIME-Version: 1.0 To: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > My concern is mainly from the user's point of view. This is a trap that > is there to trick every user as soon as they start using lisp expression > for COMMAND. And if we let dired-mark-pop-up run in the HIDDEN ' *marked > files*' buffer without throwing an error, users might grow to rely on > it. Harder to get it right later. I don't understand. `dired-mark-pop-up' displays that buffer, so why do you mean it's hidden? It is considered "ephemeral and generally uninteresting to the user" so Emacs won't switch to it automatically. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 14 05:44:52 2012 Received: (at submit) by debbugs.gnu.org; 14 Dec 2012 10:44:52 +0000 Received: from localhost ([127.0.0.1]:41979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSl9-0005Gm-Qh for submit@debbugs.gnu.org; Fri, 14 Dec 2012 05:44:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55116) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSl7-0005Ge-8F for submit@debbugs.gnu.org; Fri, 14 Dec 2012 05:44:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjSkB-0002lh-3D for submit@debbugs.gnu.org; Fri, 14 Dec 2012 05:43:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjSkA-0002ld-WA for submit@debbugs.gnu.org; Fri, 14 Dec 2012 05:43:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjSkA-0007wX-3J for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 05:43:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjSk9-0002lJ-93 for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 05:43:50 -0500 Received: from plane.gmane.org ([80.91.229.3]:58764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjSk9-0002lE-2Y for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 05:43:49 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TjSkK-0004ZP-3M for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2012 11:44:00 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 14 Dec 2012 11:44:00 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 14 Dec 2012 11:44:00 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Fri, 14 Dec 2012 18:43:38 +0800 Lines: 8 Message-ID: References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEC7.6050102@gmx.at> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (OS X 10.8.2) Cancel-Lock: sha1:fmP9V4WzYRtFl+S5bGqhb1IMDso= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2012-12-14 18:26 +0800, martin rudalics wrote: > I don't understand. `dired-mark-pop-up' displays that buffer, so why do > you mean it's hidden? It is considered "ephemeral and generally > uninteresting to the user" so Emacs won't switch to it automatically. I mean its buffer name is prefixed with ?\s. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 14 05:59:37 2012 Received: (at 13152) by debbugs.gnu.org; 14 Dec 2012 10:59:37 +0000 Received: from localhost ([127.0.0.1]:41987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSzR-0005b3-39 for submit@debbugs.gnu.org; Fri, 14 Dec 2012 05:59:37 -0500 Received: from mout.gmx.net ([212.227.17.20]:56374) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjSzO-0005aw-VZ for 13152@debbugs.gnu.org; Fri, 14 Dec 2012 05:59:35 -0500 Received: from mailout-de.gmx.net ([10.1.76.28]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0ME0kj-1TunNT0OzP-00HN72 for <13152@debbugs.gnu.org>; Fri, 14 Dec 2012 11:58:36 +0100 Received: (qmail invoked by alias); 14 Dec 2012 10:58:35 -0000 Received: from 62-47-53-23.adsl.highway.telekom.at (EHLO [62.47.53.23]) [62.47.53.23] by mail.gmx.net (mp028) with SMTP; 14 Dec 2012 11:58:35 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+pKTJ8NnqpeYT9kF5zL7/S0YNISqC1Yb+DyniBuU NjOQlO2A0zgonQ Message-ID: <50CB0656.9020702@gmx.at> Date: Fri, 14 Dec 2012 11:58:30 +0100 From: martin rudalics MIME-Version: 1.0 To: Leo Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEC7.6050102@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) >> I don't understand. `dired-mark-pop-up' displays that buffer, so why do >> you mean it's hidden? It is considered "ephemeral and generally >> uninteresting to the user" so Emacs won't switch to it automatically. > > I mean its buffer name is prefixed with ?\s. Yes. And the Elisp manual says Buffers that are ephemeral and generally uninteresting to the user have names starting with a space, so that the `list-buffers' and `buffer-menu' commands don't mention them (but if such a buffer visits a file, it *is* mentioned). A name starting with space also initially disables recording undo information; see *Note Undo::. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 15 06:10:39 2012 Received: (at 13152) by debbugs.gnu.org; 15 Dec 2012 11:10:39 +0000 Received: from localhost ([127.0.0.1]:43369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjpde-0000bB-DG for submit@debbugs.gnu.org; Sat, 15 Dec 2012 06:10:39 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:50437 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjpdb-0000ay-N7 for 13152@debbugs.gnu.org; Sat, 15 Dec 2012 06:10:36 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7C9F7451CD5D; Sat, 15 Dec 2012 03:09:31 -0800 (PST) From: Juri Linkov To: martin rudalics Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Organization: JURTA References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> Date: Sat, 15 Dec 2012 12:59:00 +0200 In-Reply-To: <50CAFEBC.6000208@gmx.at> (martin rudalics's message of "Fri, 14 Dec 2012 11:26:04 +0100") Message-ID: <87a9tf1szv.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: Leo , 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > But FUNCTION "should not manipulate files, just read input > \(an argument or confirmation)." so I don't see why this matters. I agree it shouldn't matter in which buffer FUNCTION is called. The problem is caused by the flawed design of dired-x where `dired-guess-default' doesn't propagate the value of `files' to the evaluated expressions in `dired-guess-shell-alist-default'. Also note how `dired-guess-shell-alist-default' is forced to use the dynamically bound variable `file'. The proper fix would be to redesign `dired-guess-shell-alist-default' to funcall lambdas with one arg `files' instead of using `eval'. So instead of (setq dired-guess-shell-alist-user '(("." (let ((files (dired-get-marked-files t current-prefix-arg))) (let (dired-guess-shell-alist-user) (dired-guess-default files)))))) Leo would be able to use (setq dired-guess-shell-alist-user '(("." (lambda (files) (let (dired-guess-shell-alist-user) (dired-guess-default files)))))) This could help to move useful features from dired-x.el to dired-aux.el. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 03 22:47:04 2013 Received: (at 13152) by debbugs.gnu.org; 4 Jan 2013 03:47:04 +0000 Received: from localhost ([127.0.0.1]:42408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqyFL-00060Q-Dy for submit@debbugs.gnu.org; Thu, 03 Jan 2013 22:47:04 -0500 Received: from mail-da0-f53.google.com ([209.85.210.53]:47022) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqyFH-000600-QS for 13152@debbugs.gnu.org; Thu, 03 Jan 2013 22:47:01 -0500 Received: by mail-da0-f53.google.com with SMTP id x6so7265696dac.12 for <13152@debbugs.gnu.org>; Thu, 03 Jan 2013 19:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=nj92i/zvBwk9PMVNyZQzmgqYl6S1FZrag7JJgBGr1fM=; b=MRXAReWAiuGeVEnQ0t5JV55F7uA1t801xcrX7V4Lvn1zpSvZcLQHYvkWfj9Dzfbx3G s7GGuP3XGVXZnvVDa/WlYRXezCWBDUdk/uMozPRb2cOJdUFbV7mtRvvFhsGfU+WPdg/U brhgPdSZFawwTf5m4HXYV5ZeGyXQCE+Zdx2nJgMYMoTPL4Z6J8pUr3aiWaNiPURYM80O cNgKAJiQ5lwGHIomT5EfyGR+xAzI8ZnEkgrFdnInHlU1fNnj4N/txwaufGuKRmd7ly6l ycOYHSq5bj27NT5Zyur/rLbeHUPOqzibgePu/4B9foMMtPEpCQOh1JI0+gv9CLNogOcw FU6A== X-Received: by 10.66.86.101 with SMTP id o5mr151196612paz.15.1357271214560; Thu, 03 Jan 2013 19:46:54 -0800 (PST) Received: from Shidais-iMac.local ([119.255.41.67]) by mx.google.com with ESMTPS id mz10sm31423484pbc.37.2013.01.03.19.46.50 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Jan 2013 19:46:53 -0800 (PST) From: Leo Liu To: martin rudalics Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= Date: Fri, 04 Jan 2013 11:46:41 +0800 In-Reply-To: <50CAFEBC.6000208@gmx.at> (martin rudalics's message of "Fri, 14 Dec 2012 11:26:04 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13152 Cc: Juri Linkov , 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2012-12-14 18:26 +0800, martin rudalics wrote: > I suppose we can safely do > > #'(lambda (window _value) > (unwind-protect > (apply function args) > (with-selected-window window > (when (window-live-p window) > (quit-restore-window window 'kill))))) > > instead if people think it's better. But FUNCTION "should not > manipulate files, just read input \(an argument or confirmation)." so I > don't see why this matters. > > martin Hello Martin, Could you restore the behaviour to previous releases i.e. throw an error? The return value '(nil) doesn't make any sense and a corner case to trap future users. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 03 22:51:04 2013 Received: (at 13152) by debbugs.gnu.org; 4 Jan 2013 03:51:05 +0000 Received: from localhost ([127.0.0.1]:42434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqyJ7-00066a-51 for submit@debbugs.gnu.org; Thu, 03 Jan 2013 22:51:00 -0500 Received: from mail-da0-f43.google.com ([209.85.210.43]:49972) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqyJ3-00066Q-KY for 13152@debbugs.gnu.org; Thu, 03 Jan 2013 22:50:54 -0500 Received: by mail-da0-f43.google.com with SMTP id u36so7306210dak.16 for <13152@debbugs.gnu.org>; Thu, 03 Jan 2013 19:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=305KW/dZbzwuqXjctppWreQzjK23y8zKauzDR70cXzc=; b=vHxNRMFEPu9EqJ9ngtxkHmRwJa9uUDLCGHI4N/19+5JEe8b5QVFSESq7ftkc+veNqH YvXWCYdWN6ryvz/V4ceSib4hDBJRq+12Hw741VoKin2EhcKBkI9fchZWW8afQghfIZwv sS1Cbylw/BUZ7DzPPifA/ty++EoWH63nOvxUG9J0dkIaTYC18Tx2JCyB6HxO0jmVhoRN q5FQ+az9zYwvN5TwMykwy9gvaTAB1FV78kuxyxqUyfeZQ72rqo9dstyBShOcdjLSt7RU gd5/AlXWkUAzCc6t+oDj2sEc4xWF3YR1RfK2Af6x+xsnaQ0dFGXMqtysgIX8NEMYzvU+ f3yw== X-Received: by 10.68.230.200 with SMTP id ta8mr157019432pbc.13.1357271448523; Thu, 03 Jan 2013 19:50:48 -0800 (PST) Received: from Shidais-iMac.local ([119.255.41.67]) by mx.google.com with ESMTPS id na4sm31433729pbc.18.2013.01.03.19.50.44 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Jan 2013 19:50:48 -0800 (PST) From: Leo Liu To: Juri Linkov Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <87a9tf1szv.fsf@mail.jurta.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Fri, 04 Jan 2013 11:49:59 +0800 In-Reply-To: <87a9tf1szv.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 15 Dec 2012 12:59:00 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 13152 Cc: martin rudalics , 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2012-12-15 18:59 +0800, Juri Linkov wrote: > I agree it shouldn't matter in which buffer FUNCTION is called. > The problem is caused by the flawed design of dired-x where > `dired-guess-default' doesn't propagate the value of `files' > to the evaluated expressions in `dired-guess-shell-alist-default'. Ideally, yes. But not common in elisp where stateful is the norm. We just have to use the least surprise principle. > Also note how `dired-guess-shell-alist-default' is forced to use the > dynamically bound variable `file'. > > The proper fix would be to redesign `dired-guess-shell-alist-default' > to funcall lambdas with one arg `files' instead of using `eval'. > > So instead of > > (setq dired-guess-shell-alist-user > '(("." (let ((files (dired-get-marked-files t current-prefix-arg))) > (let (dired-guess-shell-alist-user) > (dired-guess-default files)))))) > > Leo would be able to use > > (setq dired-guess-shell-alist-user > '(("." (lambda (files) > (let (dired-guess-shell-alist-user) > (dired-guess-default files)))))) > > This could help to move useful features from dired-x.el to dired-aux.el. This seems like a good design. Cheers. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 04 02:08:37 2013 Received: (at 13152) by debbugs.gnu.org; 4 Jan 2013 07:08:37 +0000 Received: from localhost ([127.0.0.1]:42544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tr1OO-0002bM-9H for submit@debbugs.gnu.org; Fri, 04 Jan 2013 02:08:36 -0500 Received: from mout.gmx.net ([212.227.15.19]:57146) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tr1OF-0002b7-UQ for 13152@debbugs.gnu.org; Fri, 04 Jan 2013 02:08:29 -0500 Received: from mailout-de.gmx.net ([10.1.76.12]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0Mhg69-1TdSS62qEl-00MwqN for <13152@debbugs.gnu.org>; Fri, 04 Jan 2013 08:08:21 +0100 Received: (qmail invoked by alias); 04 Jan 2013 07:08:21 -0000 Received: from 62-47-57-118.adsl.highway.telekom.at (EHLO [62.47.57.118]) [62.47.57.118] by mail.gmx.net (mp012) with SMTP; 04 Jan 2013 08:08:21 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+5AqFTyMC5EqYihn0r3r6RPUKvBIyrqWyxR9DtVv OhTGIxO5cLbjf9 Message-ID: <50E67FE0.6030500@gmx.at> Date: Fri, 04 Jan 2013 08:08:16 +0100 From: martin rudalics MIME-Version: 1.0 To: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: Juri Linkov , 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Could you restore the behaviour to previous releases i.e. throw an > error? > > The return value '(nil) doesn't make any sense and a corner case to trap > future users. I don't understand what you mean with previous behavior. IIUC I need the unwindform to make sure the window gets killed when a user aborts her dialog with dired, for example, via C-g. What am I missing? martin From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 06 21:38:57 2013 Received: (at submit) by debbugs.gnu.org; 7 Jan 2013 02:38:57 +0000 Received: from localhost ([127.0.0.1]:33401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ts2c5-0001Ul-0X for submit@debbugs.gnu.org; Sun, 06 Jan 2013 21:38:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41825) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ts2c0-0001UQ-S5 for submit@debbugs.gnu.org; Sun, 06 Jan 2013 21:38:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ts2bt-0004Cf-6N for submit@debbugs.gnu.org; Sun, 06 Jan 2013 21:38:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ts2bt-0004Cb-3H for submit@debbugs.gnu.org; Sun, 06 Jan 2013 21:38:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ts2br-00077M-Bd for bug-gnu-emacs@gnu.org; Sun, 06 Jan 2013 21:38:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ts2bq-0004CN-G3 for bug-gnu-emacs@gnu.org; Sun, 06 Jan 2013 21:38:43 -0500 Received: from plane.gmane.org ([80.91.229.3]:43651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ts2bq-0004CJ-9d for bug-gnu-emacs@gnu.org; Sun, 06 Jan 2013 21:38:42 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Ts2c4-0007a3-Hz for bug-gnu-emacs@gnu.org; Mon, 07 Jan 2013 03:38:56 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 07 Jan 2013 03:38:56 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 07 Jan 2013 03:38:56 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Mon, 07 Jan 2013 10:38:32 +0800 Lines: 12 Message-ID: References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) Cancel-Lock: sha1:UHPM8Vk7sF4WMc4sUwnvokA27Po= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2013-01-04 15:08 +0800, martin rudalics wrote: > I don't understand what you mean with previous behavior. IIUC I need > the unwindform to make sure the window gets killed when a user aborts > her dialog with dired, for example, via C-g. What am I missing? Eval (dired-get-marked-files t current-prefix-arg) in non dired buffers threw an error in the released emacsen, which is a more reasonable thing to do. In the pretest it returns (nil). Leo From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 07 02:44:01 2013 Received: (at 13152) by debbugs.gnu.org; 7 Jan 2013 07:44:02 +0000 Received: from localhost ([127.0.0.1]:33572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ts7NI-0000V7-S8 for submit@debbugs.gnu.org; Mon, 07 Jan 2013 02:44:01 -0500 Received: from mout.gmx.net ([212.227.15.19]:55540) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ts7NG-0000Ut-Sh for 13152@debbugs.gnu.org; Mon, 07 Jan 2013 02:43:59 -0500 Received: from mailout-de.gmx.net ([10.1.76.29]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MTuiV-1TRtPL1nyT-00Qo9J for <13152@debbugs.gnu.org>; Mon, 07 Jan 2013 08:43:50 +0100 Received: (qmail invoked by alias); 07 Jan 2013 07:43:50 -0000 Received: from 62-47-39-143.adsl.highway.telekom.at (EHLO [62.47.39.143]) [62.47.39.143] by mail.gmx.net (mp029) with SMTP; 07 Jan 2013 08:43:50 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19B6agJjfxB9bT8hsvdTHFNHg/AngZktuL5cTrRfc j7c6ocLJhNQIAn Message-ID: <50EA7CAD.50200@gmx.at> Date: Mon, 07 Jan 2013 08:43:41 +0100 From: martin rudalics MIME-Version: 1.0 To: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) > Eval (dired-get-marked-files t current-prefix-arg) in non dired buffers > threw an error in the released emacsen, which is a more reasonable thing > to do. > > In the pretest it returns (nil). But this is unrelated to the change in `dired-mark-pop-up' I suppose. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 08 06:02:44 2013 Received: (at 13152) by debbugs.gnu.org; 8 Jan 2013 11:02:44 +0000 Received: from localhost ([127.0.0.1]:56194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TsWx9-0005cH-1x for submit@debbugs.gnu.org; Tue, 08 Jan 2013 06:02:43 -0500 Received: from mail-da0-f50.google.com ([209.85.210.50]:38739) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TsWx7-0005c4-F3 for 13152@debbugs.gnu.org; Tue, 08 Jan 2013 06:02:42 -0500 Received: by mail-da0-f50.google.com with SMTP id h15so143911dan.9 for <13152@debbugs.gnu.org>; Tue, 08 Jan 2013 03:02:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=Bcvxp0r3AAmmvqJl4IHM722Yd8uNqV/bO/85Jln7+FA=; b=GQPAe0tf8EPdPG0SRuDPSmMAmlKpx4YbyoZfPquYfZF2bqMTOtSFBXnienITHKWT9a 4zZ4U4zrqauUXqfqE5Jooz+MX+hamqiqcoZ9Zj+FH+btVvU4OlIWBkmrTUk3a/f9FNqi I8Y56VW6YgnsOlaeJ4nTC49BWn6odrrK0CPxCS4hDBm2eycO8uH5FTx229SPQYV6TLEn e/ut2NNw0R0gqycsBMYDKkyzBC9X7dq7tmScHhuoYpm1sYAOqRuS9othfv+rrAKkKU9D t0voK6x7hpyQqgzEfu7i7uIpYA5/z109tzFYH2Y02cLTvrl0mdBoM4aeW5Ui7PILk5lk XEdg== X-Received: by 10.68.247.39 with SMTP id yb7mr200202737pbc.15.1357642952094; Tue, 08 Jan 2013 03:02:32 -0800 (PST) Received: from Shidais-iMac.local ([119.255.41.67]) by mx.google.com with ESMTPS id ix9sm39460311pbc.7.2013.01.08.03.02.28 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Jan 2013 03:02:30 -0800 (PST) From: Leo Liu To: 13152@debbugs.gnu.org Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Tue, 08 Jan 2013 19:02:18 +0800 In-Reply-To: (Leo Liu's message of "Mon, 07 Jan 2013 10:38:32 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 13152 Cc: Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2013-01-07 10:38 +0800, Leo Liu wrote: > Eval (dired-get-marked-files t current-prefix-arg) in non dired buffers > threw an error in the released emacsen, which is a more reasonable thing > to do. > > In the pretest it returns (nil). The incompatibility is introduced by this change: Author: Juri Linkov Date: Wed Sep 19 23:09:55 2012 +0300 * lisp/dired-aux.el (dired-diff): Add (require 'diff) because `diff-latest-backup-file' is not autoloaded. (dired-do-chxxx, dired-do-chmod): Set `no-error-if-not-filep' arg of `dired-get-filename' to t to not report error when there is no default file on the current line. Juri, could you take a look? thanks. Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 08 17:27:16 2013 Received: (at 13152) by debbugs.gnu.org; 8 Jan 2013 22:27:17 +0000 Received: from localhost ([127.0.0.1]:57434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tshdb-0001wF-6A for submit@debbugs.gnu.org; Tue, 08 Jan 2013 17:27:16 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:42100 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TshdZ-0001w7-1U for 13152@debbugs.gnu.org; Tue, 08 Jan 2013 17:27:13 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TshdR-0008D4-Sv; Tue, 08 Jan 2013 17:27:05 -0500 From: Glenn Morris To: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> X-Spook: Lexis-Nexis Albanian espionage FBI ARPA BROMURE Soviet X-Ran: q-kuWXyEd&/GS\==o}+L$c1-$@=t?C$j*O]v"^d(}x.,@*/7]Nb{!tGMD`6~ X-Hue: white X-Attribution: GM Date: Tue, 08 Jan 2013 17:27:05 -0500 In-Reply-To: (Leo Liu's message of "Tue, 08 Jan 2013 19:02:18 +0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 13152 Cc: Juri Linkov , 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Leo Liu wrote: > On 2013-01-07 10:38 +0800, Leo Liu wrote: >> Eval (dired-get-marked-files t current-prefix-arg) in non dired buffers >> threw an error in the released emacsen, which is a more reasonable thing >> to do. >> >> In the pretest it returns (nil). > > The incompatibility is introduced by this change: > > Author: Juri Linkov > Date: Wed Sep 19 23:09:55 2012 +0300 > > * lisp/dired-aux.el (dired-diff): Add (require 'diff) because > `diff-latest-backup-file' is not autoloaded. > (dired-do-chxxx, dired-do-chmod): Set `no-error-if-not-filep' arg > of `dired-get-filename' to t to not report error when there is > no default file on the current line. How can a commit that did not touch dired-get-marked-files, or any code called by it, possibly have changed the behaviour of dired-get-marked-files? Presumably you mean this change http://lists.gnu.org/archive/html/emacs-diffs/2012-10/msg00382.html http://debbugs.gnu.org/12725 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 08 17:35:53 2013 Received: (at 13152) by debbugs.gnu.org; 8 Jan 2013 22:35:53 +0000 Received: from localhost ([127.0.0.1]:57444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tshlx-00029R-2n for submit@debbugs.gnu.org; Tue, 08 Jan 2013 17:35:53 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:42216 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tshlv-00029L-Ft for 13152@debbugs.gnu.org; Tue, 08 Jan 2013 17:35:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Tshlo-0007HA-80; Tue, 08 Jan 2013 17:35:44 -0500 From: Glenn Morris To: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> X-Spook: PET Venezuela ICE FIPS140 secure clones Panama national X-Ran: sq"~4HP7MW]mJ@ X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 08 Jan 2013 17:35:44 -0500 In-Reply-To: (Glenn Morris's message of "Tue, 08 Jan 2013 17:27:05 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Maybe you can just make dired-get-marked-files throw an explicit error "Not in Dired mode" unless (derived-mode-p 'dired-mode), though I still don't see what the big deal is here. You would need to check ever caller to make sure this did not break anything. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 08 20:16:25 2013 Received: (at submit) by debbugs.gnu.org; 9 Jan 2013 01:16:25 +0000 Received: from localhost ([127.0.0.1]:57509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TskHI-0005vu-9G for submit@debbugs.gnu.org; Tue, 08 Jan 2013 20:16:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34486) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TskHF-0005vh-Ol for submit@debbugs.gnu.org; Tue, 08 Jan 2013 20:16:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TskH2-00057f-Py for submit@debbugs.gnu.org; Tue, 08 Jan 2013 20:16:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TskH2-00057Z-Ma for submit@debbugs.gnu.org; Tue, 08 Jan 2013 20:16:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TskH1-0004xM-GI for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2013 20:16:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TskGz-00056u-6W for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2013 20:16:07 -0500 Received: from plane.gmane.org ([80.91.229.3]:42633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TskGy-00056p-WE for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2013 20:16:05 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TskHB-0006oj-2u for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 02:16:17 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jan 2013 02:16:17 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jan 2013 02:16:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Wed, 09 Jan 2013 09:15:49 +0800 Lines: 12 Message-ID: References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) Cancel-Lock: sha1:MLgC+aNvaPHxzl7hi6P7S3GxqrU= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2013-01-09 06:35 +0800, Glenn Morris wrote: > Maybe you can just make dired-get-marked-files throw an explicit error > "Not in Dired mode" unless (derived-mode-p 'dired-mode), though I still > don't see what the big deal is here. You would need to check ever caller > to make sure this did not break anything. dired-get-marked-files can now return (nil) which is non-nil and yet not a list of files. It is an incorrect return value. OK, I'll have a look tonight. Thanks. Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 08 20:20:07 2013 Received: (at submit) by debbugs.gnu.org; 9 Jan 2013 01:20:07 +0000 Received: from localhost ([127.0.0.1]:57513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TskKs-00061Z-Sg for submit@debbugs.gnu.org; Tue, 08 Jan 2013 20:20:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35568) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TskKq-00060v-NA for submit@debbugs.gnu.org; Tue, 08 Jan 2013 20:20:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TskKe-0006Cp-1M for submit@debbugs.gnu.org; Tue, 08 Jan 2013 20:19:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TskKd-0006Cl-Uf for submit@debbugs.gnu.org; Tue, 08 Jan 2013 20:19:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TskKc-0006DN-SF for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2013 20:19:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TskKb-0006CZ-Pt for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2013 20:19:50 -0500 Received: from plane.gmane.org ([80.91.229.3]:59860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TskKb-0006CT-JL for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2013 20:19:49 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TskKq-0002sC-6A for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 02:20:04 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jan 2013 02:20:04 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jan 2013 02:20:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Wed, 09 Jan 2013 09:19:18 +0800 Lines: 9 Message-ID: References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) Cancel-Lock: sha1:lc0jo5zldGrsRDMthqcErb309zc= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2013-01-09 06:27 +0800, Glenn Morris wrote: > Presumably you mean this change > > http://lists.gnu.org/archive/html/emacs-diffs/2012-10/msg00382.html That is it. Sorry. The two commits were what I found but I mixed up. Anyway I'll take a look tonight. Leo From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 09 06:08:31 2013 Received: (at 13152) by debbugs.gnu.org; 9 Jan 2013 11:08:31 +0000 Received: from localhost ([127.0.0.1]:57972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TstWI-0004Bk-JK for submit@debbugs.gnu.org; Wed, 09 Jan 2013 06:08:31 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:60486) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TstWG-0004BX-0W for 13152@debbugs.gnu.org; Wed, 09 Jan 2013 06:08:29 -0500 Received: by mail-pa0-f42.google.com with SMTP id rl6so972509pac.1 for <13152@debbugs.gnu.org>; Wed, 09 Jan 2013 03:08:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=yYynUOOkeJKf+UCvYeG3tega5XHdX84HbAexlMkwsUU=; b=JPsJXLxvzmCJt0GUvrUps0OXr4fyk+bmpeoj9OgOeVSjM5uyMzw/+8KD4SoD99ew7W E7jj1T3HMAopm8z9U1u3ahyCtRgsrvzhsPj8v9xO1AnQPG3V7MQvvfLxoQxpVsEfg/cm 5qJ8OBnlInOScfkYSns1OvioXoMHy7+T3CRV/ZCQ33ejzhJw6xKcOLWGxtxBNXu3YqMS 2Arblqb59g738q1gUZ809jm14cEDwS1s1xVZtaNRZAnk3UVQI/2B2WC3MF/DZpk6ORdG OxFHwBSq0MEpwOlCIYNF9kcXv/4qyMTmneEq9r0/7s/aR8iet8qwlYtfgYOU/oL4Mhyv B4LA== X-Received: by 10.68.211.42 with SMTP id mz10mr210132374pbc.100.1357729692935; Wed, 09 Jan 2013 03:08:12 -0800 (PST) Received: from Shidais-iMac.local ([119.255.41.67]) by mx.google.com with ESMTPS id nf9sm41460675pbc.17.2013.01.09.03.08.09 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Jan 2013 03:08:11 -0800 (PST) From: Leo Liu To: Glenn Morris Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= Date: Wed, 09 Jan 2013 19:07:57 +0800 In-Reply-To: (Glenn Morris's message of "Tue, 08 Jan 2013 17:35:44 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 13152 Cc: 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2013-01-09 06:35 +0800, Glenn Morris wrote: > Maybe you can just make dired-get-marked-files throw an explicit error > "Not in Dired mode" unless (derived-mode-p 'dired-mode), though I still > don't see what the big deal is here. You would need to check ever caller > to make sure this did not break anything. After looking at this function more closely, I am reluctant to put in a (derived-mode-p 'dired-mode) check since all the related functions work more generally (using regexps) and do not depend on mode checking. So I propose the following patch instead which avoids returning values such as (nil) or (t nil). What do you think? - Leo diff --git a/lisp/dired.el b/lisp/dired.el index b62b4d1a..2f7d5b37 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -620,12 +620,14 @@ (defun dired-get-marked-files (&optional localp arg filter distinguish-one-marke If DISTINGUISH-ONE-MARKED is non-nil, then if we find just one marked file, return (t FILENAME) instead of (FILENAME). Don't use that together with FILTER." - (let* ((all-of-them - (save-excursion - (dired-map-over-marks - (dired-get-filename localp 'no-error-if-not-filep) - arg nil distinguish-one-marked))) - result) + (let ((all-of-them + (save-excursion + (delq nil (dired-map-over-marks + (dired-get-filename localp 'no-error-if-not-filep) + arg nil distinguish-one-marked)))) + result) + (when (equal all-of-them '(t)) + (setq all-of-them nil)) (if (not filter) (if (and distinguish-one-marked (eq (car all-of-them) t)) all-of-them From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 09 19:51:17 2013 Received: (at 13152) by debbugs.gnu.org; 10 Jan 2013 00:51:17 +0000 Received: from localhost ([127.0.0.1]:59239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt6MV-0001lL-V0 for submit@debbugs.gnu.org; Wed, 09 Jan 2013 19:51:16 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:34048 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt6MT-0001lA-FT for 13152@debbugs.gnu.org; Wed, 09 Jan 2013 19:51:14 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 595EE229BC3516; Wed, 9 Jan 2013 16:50:59 -0800 (PST) From: Juri Linkov To: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Organization: JURTA References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> Date: Thu, 10 Jan 2013 02:50:10 +0200 In-Reply-To: (Leo Liu's message of "Wed, 09 Jan 2013 19:07:57 +0800") Message-ID: <876235vp33.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13152 Cc: Glenn Morris , 13152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > So I propose the following patch instead which avoids returning values > such as (nil) or (t nil). What do you think? Could you provide a test case that demonstrates the problem that you are trying to fix? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 09 20:05:42 2013 Received: (at submit) by debbugs.gnu.org; 10 Jan 2013 01:05:42 +0000 Received: from localhost ([127.0.0.1]:59256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt6aS-0002Az-G0 for submit@debbugs.gnu.org; Wed, 09 Jan 2013 20:05:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57594) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt6aI-0002AZ-9a for submit@debbugs.gnu.org; Wed, 09 Jan 2013 20:05:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tt6Zz-0005Dn-A6 for submit@debbugs.gnu.org; Wed, 09 Jan 2013 20:05:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_NUMERIC_HELO, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=no version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt6Zz-0005Dh-7Q for submit@debbugs.gnu.org; Wed, 09 Jan 2013 20:05:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt6Zx-0003G3-DT for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 20:05:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tt6Zw-0005CG-Gk for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 20:05:09 -0500 Received: from plane.gmane.org ([80.91.229.3]:49201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt6Zw-0005BZ-AS for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 20:05:08 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Tt6aA-0003eR-Fd for bug-gnu-emacs@gnu.org; Thu, 10 Jan 2013 02:05:22 +0100 Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 10 Jan 2013 02:05:22 +0100 Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 10 Jan 2013 02:05:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Liu Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Thu, 10 Jan 2013 09:04:58 +0800 Lines: 7 Message-ID: References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> <876235vp33.fsf@mail.jurta.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (OS X 10.8.2) Cancel-Lock: sha1:/jFOSip1OxpE/TYRmOItBK5FtAo= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2013-01-10 08:50 +0800, Juri Linkov wrote: > Could you provide a test case that demonstrates the problem > that you are trying to fix? Like (dired-get-marked-files nil nil nil t)? Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 18 13:41:11 2013 Received: (at 13152-done) by debbugs.gnu.org; 18 Jan 2013 18:41:11 +0000 Received: from localhost ([127.0.0.1]:39040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TwGsH-0002t6-Sp for submit@debbugs.gnu.org; Fri, 18 Jan 2013 13:41:10 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:60366) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TwGsF-0002sz-SO for 13152-done@debbugs.gnu.org; Fri, 18 Jan 2013 13:41:08 -0500 Received: by mail-pa0-f49.google.com with SMTP id bi1so2258836pad.22 for <13152-done@debbugs.gnu.org>; Fri, 18 Jan 2013 10:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=M/HLpdFXpRyXu3Tz0dIQ6vBab27NKHGHjnnuk7XNC+E=; b=TfLThsp4orUDILPEJWxzqe/3mOIlScCYukzpbsMwsrP7GsqfLGW0d1rRGMofNPOyfW c1INUZnQeNRDyOtKUyKl7JQp1hMcvpTxB5NdR3f/goAxAYTxdVKR8GBzJNMobihfKyUS +8VyFaqQ1Y+u+2B58qdEEO0XEoPD/5gYS4jozdnbi+XmxTwG/RyOeNm32bQdsD6ChgrE RR0dCk20PtOieU3dXjzaBXWhJuoozEe9FhVnN5t7fdnuOb+AftTvVoUV8SJ0oV6Vq6bY K7I5KvBupNWKCeffIuNwlKQ8e0EvpF6TNb3oXPONsaDYSF2U03Rn0S/pKJtfvubjwcKZ wZ+Q== X-Received: by 10.68.135.40 with SMTP id pp8mr26820744pbb.63.1358534419043; Fri, 18 Jan 2013 10:40:19 -0800 (PST) Received: from localhost ([182.48.109.8]) by mx.google.com with ESMTPS id pj1sm3504393pbb.71.2013.01.18.10.40.14 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 18 Jan 2013 10:40:17 -0800 (PST) From: Leo Liu To: 13152-done@debbugs.gnu.org Subject: Re: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> <50E67FE0.6030500@gmx.at> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Sat, 19 Jan 2013 02:40:11 +0800 In-Reply-To: (Leo Liu's message of "Wed, 09 Jan 2013 19:07:57 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (OS X 10.8.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13152-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Fixed in 24.3. From unknown Mon Jun 23 20:15:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 16 Feb 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator