GNU bug report logs - #13146
[PATCH] help-for-help interferes with buffer order, and displays help in too many windows

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13146 in the body.
You can then email your comments to 13146 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] help-for-help interferes with buffer order,
	and displays help in too many windows
Date: Tue, 11 Dec 2012 10:57:39 -0800 (PST)

[Message part 1 (text/plain, inline)]

In 24.2, do emacs -Q, then
M-x split-window RET C-x b foo RET C-x b bar RET C-h C-h C-g C-x b
It defaults to *Help*, but it should default to foo; transiently displaying help-for-help shouldn't modify the buffer order.

Now do C-g C-h f mark RET C-x o C-h C-h
It shows the help-for-help page in both windows, but it should show it in only one.

The attached helphelpbug.patch fixes both problems. I'm not bothering to submit separate reports for the two since it's a one-line patch.

[helphelpbug.patch (text/x-diff, attachment)]

Message #8 received at 13146 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Kelly Dean <kellydeanch <at> yahoo.com>
Cc: 13146 <at> debbugs.gnu.org
Subject: Re: bug#13146: [PATCH] help-for-help interferes with buffer order,
	and displays help in too many windows
Date: Wed, 12 Dec 2012 10:42:21 +0100

> M-x split-window RET C-x b foo RET C-x b bar RET C-h C-h C-g C-x b
> It defaults to *Help*, but it should default to foo; transiently displaying help-for-help shouldn't modify the buffer order.

You're right.  It shouldn't.

> Now do C-g C-h f mark RET C-x o C-h C-h
> It shows the help-for-help page in both windows, but it should show it in only one.

This look quite silly, indeed.

-		     (switch-to-buffer-other-window "*Help*")
+		     (if (not (equal (buffer-name) "*Help*")) (switch-to-buffer-other-window "*Help*" t))

Using t as NORECORD argument is correct IMO.  Checking whether *Help* is
current is not quite correct (the current buffer is not necessarily
displayed in the selected window) but good enough for interactive use.
I think a simple `pop-to-buffer' would suffice here.

But I'm not sure whether `help-for-help' should use *Help* in the first
place.  A user might want to consult `help-for-help' and continue/resume
watching the current help information.  Does anyone see a downside to
renaming the buffer used by `help-for-help' to *help-for-help* (with a
leading space)?

martin

Message #11 received at 13146 <at> debbugs.gnu.org (full text, mbox):

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 13146 <at> debbugs.gnu.org
Subject: Re: bug#13146: [PATCH] help-for-help interferes with buffer order,
	and displays help in too many windows
Date: Thu, 13 Dec 2012 00:12:13 -0800 (PST)

> Does anyone see
> a downside to
> renaming the buffer used by `help-for-help' to
> *help-for-help* (with a
> leading space)?
That sounds like a good solution.

Message #14 received at 13146 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Kelly Dean <kellydeanch <at> yahoo.com>
Cc: 13146 <at> debbugs.gnu.org
Subject: Re: bug#13146: [PATCH] help-for-help interferes with buffer order,
	and displays help in too many windows
Date: Fri, 14 Dec 2012 11:24:12 +0100

>> Does anyone see
>> a downside to
>> renaming the buffer used by `help-for-help' to
>> *help-for-help* (with a
>> leading space)?
> That sounds like a good solution.

Can you provide a patch for this (using `pop-to-buffer' instead of
`switch-to-buffer-other-window') and test it a bit?

martin

Message #17 received at 13146 <at> debbugs.gnu.org (full text, mbox):

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 13146 <at> debbugs.gnu.org
Subject: Re: bug#13146: [PATCH] help-for-help interferes with buffer order,
	and displays help in too many windows
Date: Sun, 16 Dec 2012 03:58:02 -0800 (PST)

[Message part 1 (text/plain, inline)]

> Can you provide a patch for this (using `pop-to-buffer'
> instead of
> `switch-to-buffer-other-window') and test it a bit?
Attached. Works fine for me.

[helphelpbug.patch2 (application/octet-stream, attachment)]

Message #22 received at 13146-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 13146-done <at> debbugs.gnu.org
Cc: Kelly Dean <kellydeanch <at> yahoo.com>
Subject: Re: bug#13146: [PATCH] help-for-help interferes with buffer order,
	and displays help in too many windows
Date: Mon, 17 Dec 2012 14:38:44 +0100

> Attached. Works fine for me.

Installed on trunk as revision 111254.  Bug closed.

Thanks, martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.