GNU bug report logs - #13127
[PATCH] cut: use only one data strucutre

Previous Next

Full log

Message #58 received at 13127 <at> debbugs.gnu.org (full text, mbox):

From: Cojocaru Alexandru <xojoc <at> gmx.com>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 13127 <at> debbugs.gnu.org
Subject: Re: bug#13127: [PATCH] cut: use only one data strucutre
Date: Mon, 6 May 2013 20:54:01 +0200

[Message part 1 (text/plain, inline)]

On Mon, 29 Apr 2013 00:59:20 +0100
Pádraig Brady <P <at> draigBrady.com> wrote:

> So I reinstated the bit vector which was a little tricky
> to do while maintaining performance, but it works very well.
I think it works because we are avoiding a memory access
inside `next_item' this way.

With this patch I try to keep the CPU benefits for `--output-d'
and when large ranges are specified, even without the bitarray.

Because of the sentinel now the max line len supported will be
`(size_t)-1 - 1' and no more `(size_t)-1'. Is this an issue?

PS: This patch also fix a little bug inside `set_fields'.

Best regards,
Cojocaru Alexandru

[cut.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.