GNU bug report logs - #13119
cp --no-preserve=mode exits 1 since coreutils 8.20

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13119: closed (cp --no-preserve=mode exits 1 since coreutils
 8.20)
Date: Sun, 09 Dec 2012 16:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 09 Dec 2012 17:32:08 +0100
with message-id <50C4BD08.4040804 <at> bernhard-voelker.de>
and subject line Re: bug#13119: cp --no-preserve=mode exits 1 since coreutils 8.20
has caused the debbugs.gnu.org bug report #13119,
regarding cp --no-preserve=mode exits 1 since coreutils 8.20
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13119: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13119
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Florian Pritz <bluewind <at> xinu.at>
To: bug-coreutils <at> gnu.org
Subject: cp --no-preserve=mode exits 1 since coreutils 8.20
Date: Fri, 07 Dec 2012 21:43:47 +0100

[Message part 3 (text/plain, inline)]

Hi,

I've used the following code in an update script. I don't want cp to
change permission since the target directory has default ACLs in place
that will set the correct permissions, but I want to keep timestamps so
once upon a time I added "--preserve=timestamp
--nopreserve=mode,ownership". I've tested without mode now and it seems
permission are fine.

mkdir a
touch a/a
cp -rfT --preserve=timestamps --no-preserve=mode,ownership a b

If I remove mode from the arguments to --no-preserve it exits 0, but if
you have it it exits 1 and doesn't print anything. It worked in
coreutils 8.19 (exit code 0) even though it might not actually do
anything. If it's intended behaviour you should at least print some kind
of error message.

The cause of this change is commit
24ebca61a3a0f10d6cd2800b188b3c034d1c4755 but it doesn't say anything
about changing the exit code.

-- 
Florian Pritz

[signature.asc (application/pgp-signature, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 13119-done <at> debbugs.gnu.org, Florian Pritz <bluewind <at> xinu.at>
Subject: Re: bug#13119: cp --no-preserve=mode exits 1 since coreutils 8.20
Date: Sun, 09 Dec 2012 17:32:08 +0100

On 12/09/2012 01:48 PM, Pádraig Brady wrote:
> The patch looks perfect.

Thanks for the review. Pushed:
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=62543570

Marking the bug as "done".

Have a nice day,
Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.