From unknown Sun Aug 17 10:17:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13099: possible test bug in "tests/df/total-verify.sh" Resent-From: Assaf Gordon Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 06 Dec 2012 03:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13099 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 13099@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135476430224431 (code B ref -1); Thu, 06 Dec 2012 03:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Dec 2012 03:25:02 +0000 Received: from localhost ([127.0.0.1]:55578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgS57-0006Lw-Fi for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:25:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50239) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgS52-0006Lg-Vc for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:24:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgS4m-0007R1-9H for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:24:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgS4m-0007Qw-5M for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:24:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgS4j-0000OS-Ft for bug-coreutils@gnu.org; Wed, 05 Dec 2012 22:24:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgS4g-0007B9-7T for bug-coreutils@gnu.org; Wed, 05 Dec 2012 22:24:37 -0500 Received: from mail-vb0-f52.google.com ([209.85.212.52]:63524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgS4f-00078b-Ta for bug-coreutils@gnu.org; Wed, 05 Dec 2012 22:24:34 -0500 Received: by mail-vb0-f52.google.com with SMTP id ez10so2732486vbb.39 for ; Wed, 05 Dec 2012 19:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=f4Ca4kG1V9OKUtDsSqQ2hQfmIF35reYC7njYKVO7LQQ=; b=aC13bg5dBfCizGIfhMxDtZ+8YJytYzbQbY6Wae6S7trQ4Oe/c2VIDu/l30c8Bq5/oK 36aMXwkBXMKZnhldXPeO/ZY1Il3jAywKL2F7fLwoHqPXCRSktVhY9SY1rBhfcO1NWKyJ GuWZFNrgh+zMlvCEgKPVf2HyikSK1/rQrWtzQEIi1JjjS68SHvq00oN45uXxs3555bWf M8udrtJuwlYfkLNtOoi9BJkT4c1v98Jqft/BK2o/jGaAnHUhHsf4izYxOm/AapSPjNLl U2Mo2YM84fORQ3wWZq7VOr/4sH/eG65/bFi9tXVOaxPww0T9Ju4GQT4S22GmPDnlpdTf rfFg== Received: by 10.52.18.147 with SMTP id w19mr51959vdd.94.1354764273275; Wed, 05 Dec 2012 19:24:33 -0800 (PST) Received: from [192.168.1.102] ([143.48.64.234]) by mx.google.com with ESMTPS id cv19sm2752629vdb.5.2012.12.05.19.24.32 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Dec 2012 19:24:32 -0800 (PST) Message-ID: <50C0121A.3030406@gmail.com> Date: Wed, 05 Dec 2012 22:33:46 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120922 Icedove/10.0.7 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Hello, (properly reporting a bug I mentioned in another email). The test "df/total-verify.sh" fails on my system, due to a wrong(?) regex to verify the output of "df --total -i -P". To make a long story short, my "df" produces the following line: === $ df --total -i -P Filesystem Inodes IUsed IFree IUse% Mounted on < snip > //bluearctitan3/foobar 0 0 0 - /media/foobar === The filesystem is mounted with fuse/sshfs (not sure if that makes a difference). The test error is: === check-df: invalid input line : //bluearctitan3/foobar 0 0 0 - /media/foobar === The 'bug' is that "check-df" script (in 'total-verify.sh') assumes that there are two (2) spaces following the dash, whereas on my system there's only one space. A possible fix (not sure about the side-effects, though); ==== diff --git a/tests/df/total-verify.sh b/tests/df/total-verify.sh index 18d215f..c36a7a7 100755 --- a/tests/df/total-verify.sh +++ b/tests/df/total-verify.sh @@ -32,7 +32,7 @@ while (<>) # /dev/sdc1 0 0 0 - /c # tmpfs 1536000 12965 1523035 1% /tmp # total 5285932 787409 4498523 15% - - /^(.*?) +(-?\d+|-) +(-?\d+|-) +(-?\d+|-) +(?:- |[0-9]+%) (.*)$/ + /^(.*?) +(-?\d+|-) +(-?\d+|-) +(-?\d+|-) +(?:-|[0-9]+%) +(.*)$/ or die "$0: invalid input line\n: $_"; if ($1 eq 'total' && $5 eq '-') { ==== Regards, -gordon From unknown Sun Aug 17 10:17:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13099: possible test bug in "tests/df/total-verify.sh" Resent-From: Assaf Gordon Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 06 Dec 2012 03:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13099 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 13099@debbugs.gnu.org Received: via spool by 13099-submit@debbugs.gnu.org id=B13099.135476463025129 (code B ref 13099); Thu, 06 Dec 2012 03:31:01 +0000 Received: (at 13099) by debbugs.gnu.org; 6 Dec 2012 03:30:30 +0000 Received: from localhost ([127.0.0.1]:55585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgSAP-0006XF-8J for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:30:30 -0500 Received: from mail-vb0-f43.google.com ([209.85.212.43]:55472) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgSAO-0006X9-1B for 13099@debbugs.gnu.org; Wed, 05 Dec 2012 22:30:28 -0500 Received: by mail-vb0-f43.google.com with SMTP id fs19so6810499vbb.30 for <13099@debbugs.gnu.org>; Wed, 05 Dec 2012 19:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=h7n7WLsFBjX7KMS/3wDd4SR9KZ/4vcJsc///AkT1QGI=; b=iGO9Mm+p4yG74pzE1oHIzbMHBcO2MGIbGXAJ3hZ+V6Whul2r88dZ6XpPepvtCnco3W LsUzMoaYhxXhlMHnAlwNXRX4ZLZJzqoZiYFAJLSj4R8uO918xONqWXuOlgWHusePqsbO WI5tEXcLYJOYDZwwEVF6M/2xIptXrs76n9Y3lBjgFcDBAXPPOYeLW7c85cIjJ3OKHM6h P6GR6dd02QW6lSCmeYIajbQ8R/RaIEoZiUXow+5VT/idWBIQrBXG4SMPlBeyI2j7xRlL v0lCVV4exLGpz8tiKAKCx2naaPQr3RMjoSHdcRGgdkiN0BwVbo+/oQ5Afj/oGg6S2ceP TYVg== Received: by 10.220.153.212 with SMTP id l20mr118511vcw.1.1354764615574; Wed, 05 Dec 2012 19:30:15 -0800 (PST) Received: from [192.168.1.102] ([143.48.64.234]) by mx.google.com with ESMTPS id g5sm2456666vez.6.2012.12.05.19.30.14 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Dec 2012 19:30:14 -0800 (PST) Message-ID: <50C01370.6010300@gmail.com> Date: Wed, 05 Dec 2012 22:39:28 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120922 Icedove/10.0.7 MIME-Version: 1.0 References: <50C0121A.3030406@gmail.com> In-Reply-To: <50C0121A.3030406@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) Correction: On 12/05/12 22:33, Assaf Gordon wrote: > === > $ df --total -i -P > Filesystem Inodes IUsed IFree IUse% Mounted on > < snip > > //bluearctitan3/foobar 0 0 0 - /media/foobar > === > > The filesystem is mounted with fuse/sshfs (not sure if that makes a difference). The filesystem is mounted with CIFS, not sshfs. From unknown Sun Aug 17 10:17:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13099: possible test bug in "tests/df/total-verify.sh" Resent-From: Bernhard Voelker Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 06 Dec 2012 09:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13099 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon Cc: 13099@debbugs.gnu.org Received: via spool by 13099-submit@debbugs.gnu.org id=B13099.1354785749992 (code B ref 13099); Thu, 06 Dec 2012 09:23:01 +0000 Received: (at 13099) by debbugs.gnu.org; 6 Dec 2012 09:22:29 +0000 Received: from localhost ([127.0.0.1]:55842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgXf2-0000Fx-Jw for submit@debbugs.gnu.org; Thu, 06 Dec 2012 04:22:28 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:62599) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgXez-0000Fm-FR for 13099@debbugs.gnu.org; Thu, 06 Dec 2012 04:22:26 -0500 Received: from [192.168.1.11] (p4FC3E64E.dip.t-dialin.net [79.195.230.78]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0M6VWV-1SxGCe0nTH-00yJnU; Thu, 06 Dec 2012 10:22:11 +0100 Message-ID: <50C063C1.30808@bernhard-voelker.de> Date: Thu, 06 Dec 2012 10:22:09 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 References: <50C0121A.3030406@gmail.com> <50C01370.6010300@gmail.com> In-Reply-To: <50C01370.6010300@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:EoUmVwQzeFuHl6jDL58u7oMDwfxr7fvmusjMJ1PVYVc C70vbI6BVoPJbf8MWKi2vypqn+yhCvg8+fe91sVf8321FgM5pF YpHV4i5WwuaG7PX3NDABjfQg4G3V4RteAnnmpD9VKTw8dd9Dsn eeQGLYQWsm4AmT+fuEu97rvOCS0FvsTOQtp9YHQ1dn1e11pPAH kD+DHBzdI7bYoOv7EFpvnp1XmsonSPy2Yl1g5/Bj+KHmQOsgfY 5KbdHk88hoK3TU+4VFV/BjMj+VByKIJJpFm3qtrJrbx1myxUGs zTyEoYild4XtONAzG7mhNAhiIB90ExLENKYjbyX+yxmLgNlaQH 2mIGpjy3KNcbPZmRJ8oWrfi06I6ysBlkrDtvbFEOp X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) On 12/06/2012 04:39 AM, Assaf Gordon wrote: > Correction: > > On 12/05/12 22:33, Assaf Gordon wrote: >> === >> $ df --total -i -P >> Filesystem Inodes IUsed IFree IUse% Mounted on >> < snip > >> //bluearctitan3/foobar 0 0 0 - /media/foobar >> === >> >> The filesystem is mounted with fuse/sshfs (not sure if that makes a difference). > > The filesystem is mounted with CIFS, not sshfs. Thanks for reporting. Actually the culprit is not CIFS but the underlying (remote) file system, i.e. CIFS exposes the inode statistics of e.g. an ext4 file system properly, while it can not do the same for vfat. The bug was introduced with my implementation of "df --output" where the "total" line now also has a "-" in the target ("Mounted on") field. Well, it seems that none of us had a vfat file system mounted while running the tests yet. I wrapped your fix in the following patch. As there's no official coreutils release yet with that bug, I didn't add a NEWS entry. Have a nice day, Berny >From d597168b25d58dbd29cf04222608eef262a7d08a Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Thu, 6 Dec 2012 10:11:42 +0100 Subject: [PATCH] tests: fix regex to match "-" in ipcent field in df/total-verify.sh The regular expression failed to match for file systems that do not provide inode statistics, e.g. VFAT or CIFS (depending on the underlying peer file system). * tests/df/total-verify.sh: Fix the regular expression to match a dash in the ipcent field again. Reported by Assaf Gordon in http://bugs.gnu.org/13099. Bug introduced in commit v8.20-18-gdae8d22. --- tests/df/total-verify.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/df/total-verify.sh b/tests/df/total-verify.sh index 18d215f..5f375bb 100755 --- a/tests/df/total-verify.sh +++ b/tests/df/total-verify.sh @@ -32,7 +32,7 @@ while (<>) # /dev/sdc1 0 0 0 - /c # tmpfs 1536000 12965 1523035 1% /tmp # total 5285932 787409 4498523 15% - - /^(.*?) +(-?\d+|-) +(-?\d+|-) +(-?\d+|-) +(?:- |[0-9]+%) (.*)$/ + /^(.*?) +(-?\d+|-) +(-?\d+|-) +(-?\d+|-) +(?:-|[0-9]+%) (.*)$/ or die "$0: invalid input line\n: $_"; if ($1 eq 'total' && $5 eq '-') { -- 1.7.7 From unknown Sun Aug 17 10:17:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Assaf Gordon Subject: bug#13099: closed (Re: bug#13099: possible test bug in "tests/df/total-verify.sh") Message-ID: References: <50C06B76.30209@draigBrady.com> <50C0121A.3030406@gmail.com> X-Gnu-PR-Message: they-closed 13099 X-Gnu-PR-Package: coreutils Reply-To: 13099@debbugs.gnu.org Date: Thu, 06 Dec 2012 10:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1354788782-5811-1" This is a multi-part message in MIME format... ------------=_1354788782-5811-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13099: possible test bug in "tests/df/total-verify.sh" which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13099@debbugs.gnu.org. --=20 13099: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13099 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1354788782-5811-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13099-done) by debbugs.gnu.org; 6 Dec 2012 10:12:36 +0000 Received: from localhost ([127.0.0.1]:55880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgYRX-0001V7-TI for submit@debbugs.gnu.org; Thu, 06 Dec 2012 05:12:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1322) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgYRV-0001Us-20 for 13099-done@debbugs.gnu.org; Thu, 06 Dec 2012 05:12:34 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB6ACF8k028017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Dec 2012 05:12:17 -0500 Received: from [10.36.116.69] (ovpn-116-69.ams2.redhat.com [10.36.116.69]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB69t3ED014818 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 6 Dec 2012 04:55:04 -0500 Message-ID: <50C06B76.30209@draigBrady.com> Date: Thu, 06 Dec 2012 09:55:02 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Bernhard Voelker Subject: Re: bug#13099: possible test bug in "tests/df/total-verify.sh" References: <50C0121A.3030406@gmail.com> <50C01370.6010300@gmail.com> <50C063C1.30808@bernhard-voelker.de> In-Reply-To: <50C063C1.30808@bernhard-voelker.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id qB6ACF8k028017 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13099-done Cc: Assaf Gordon , 13099-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) On 12/06/2012 09:22 AM, Bernhard Voelker wrote: > On 12/06/2012 04:39 AM, Assaf Gordon wrote: >> Correction: >> >> On 12/05/12 22:33, Assaf Gordon wrote: >>> =3D=3D=3D >>> $ df --total -i -P >>> Filesystem Inodes IUsed IFree IUse% Mount= ed on >>> < snip > >>> //bluearctitan3/foobar 0 0 0 - /medi= a/foobar >>> =3D=3D=3D >>> >>> The filesystem is mounted with fuse/sshfs (not sure if that makes a d= ifference). >> >> The filesystem is mounted with CIFS, not sshfs. > > Thanks for reporting. > > Actually the culprit is not CIFS but the underlying (remote) file syste= m, > i.e. CIFS exposes the inode statistics of e.g. an ext4 file system > properly, while it can not do the same for vfat. > > The bug was introduced with my implementation of "df --output" where > the "total" line now also has a "-" in the target ("Mounted on") field. > Well, it seems that none of us had a vfat file system mounted while > running the tests yet. > > I wrapped your fix in the following patch. > > As there's no official coreutils release yet with that bug, I didn't > add a NEWS entry. > > Have a nice day, > Berny > >>>From d597168b25d58dbd29cf04222608eef262a7d08a Mon Sep 17 00:00:00 2001 > From: Bernhard Voelker > Date: Thu, 6 Dec 2012 10:11:42 +0100 > Subject: [PATCH] tests: fix regex to match "-" in ipcent field in > df/total-verify.sh > > The regular expression failed to match for file systems that > do not provide inode statistics, e.g. VFAT or CIFS (depending > on the underlying peer file system). > > * tests/df/total-verify.sh: Fix the regular expression to match > a dash in the ipcent field again. > > Reported by Assaf Gordon in http://bugs.gnu.org/13099. > Bug introduced in commit v8.20-18-gdae8d22. > --- > tests/df/total-verify.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/df/total-verify.sh b/tests/df/total-verify.sh > index 18d215f..5f375bb 100755 > --- a/tests/df/total-verify.sh > +++ b/tests/df/total-verify.sh > @@ -32,7 +32,7 @@ while (<>) > # /dev/sdc1 0 0 0 - /c > # tmpfs 1536000 12965 1523035 1% /tmp > # total 5285932 787409 4498523 15% - > - /^(.*?) +(-?\d+|-) +(-?\d+|-) +(-?\d+|-) +(?:- |[0-9]+%) (.*)$/ > + /^(.*?) +(-?\d+|-) +(-?\d+|-) +(-?\d+|-) +(?:-|[0-9]+%) (.*)$/ > or die "$0: invalid input line\n: $_"; > if ($1 eq 'total' && $5 eq '-') > { > That still passes here with a "standard" file system at least. Please push. I'm marking this issue as "done" now. thanks, P=E1draig. ------------=_1354788782-5811-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Dec 2012 03:25:02 +0000 Received: from localhost ([127.0.0.1]:55578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgS57-0006Lw-Fi for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:25:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50239) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgS52-0006Lg-Vc for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:24:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgS4m-0007R1-9H for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:24:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgS4m-0007Qw-5M for submit@debbugs.gnu.org; Wed, 05 Dec 2012 22:24:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgS4j-0000OS-Ft for bug-coreutils@gnu.org; Wed, 05 Dec 2012 22:24:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgS4g-0007B9-7T for bug-coreutils@gnu.org; Wed, 05 Dec 2012 22:24:37 -0500 Received: from mail-vb0-f52.google.com ([209.85.212.52]:63524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgS4f-00078b-Ta for bug-coreutils@gnu.org; Wed, 05 Dec 2012 22:24:34 -0500 Received: by mail-vb0-f52.google.com with SMTP id ez10so2732486vbb.39 for ; Wed, 05 Dec 2012 19:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=f4Ca4kG1V9OKUtDsSqQ2hQfmIF35reYC7njYKVO7LQQ=; b=aC13bg5dBfCizGIfhMxDtZ+8YJytYzbQbY6Wae6S7trQ4Oe/c2VIDu/l30c8Bq5/oK 36aMXwkBXMKZnhldXPeO/ZY1Il3jAywKL2F7fLwoHqPXCRSktVhY9SY1rBhfcO1NWKyJ GuWZFNrgh+zMlvCEgKPVf2HyikSK1/rQrWtzQEIi1JjjS68SHvq00oN45uXxs3555bWf M8udrtJuwlYfkLNtOoi9BJkT4c1v98Jqft/BK2o/jGaAnHUhHsf4izYxOm/AapSPjNLl U2Mo2YM84fORQ3wWZq7VOr/4sH/eG65/bFi9tXVOaxPww0T9Ju4GQT4S22GmPDnlpdTf rfFg== Received: by 10.52.18.147 with SMTP id w19mr51959vdd.94.1354764273275; Wed, 05 Dec 2012 19:24:33 -0800 (PST) Received: from [192.168.1.102] ([143.48.64.234]) by mx.google.com with ESMTPS id cv19sm2752629vdb.5.2012.12.05.19.24.32 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Dec 2012 19:24:32 -0800 (PST) Message-ID: <50C0121A.3030406@gmail.com> Date: Wed, 05 Dec 2012 22:33:46 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120922 Icedove/10.0.7 MIME-Version: 1.0 To: bug-coreutils@gnu.org Subject: possible test bug in "tests/df/total-verify.sh" Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Hello, (properly reporting a bug I mentioned in another email). The test "df/total-verify.sh" fails on my system, due to a wrong(?) regex to verify the output of "df --total -i -P". To make a long story short, my "df" produces the following line: === $ df --total -i -P Filesystem Inodes IUsed IFree IUse% Mounted on < snip > //bluearctitan3/foobar 0 0 0 - /media/foobar === The filesystem is mounted with fuse/sshfs (not sure if that makes a difference). The test error is: === check-df: invalid input line : //bluearctitan3/foobar 0 0 0 - /media/foobar === The 'bug' is that "check-df" script (in 'total-verify.sh') assumes that there are two (2) spaces following the dash, whereas on my system there's only one space. A possible fix (not sure about the side-effects, though); ==== diff --git a/tests/df/total-verify.sh b/tests/df/total-verify.sh index 18d215f..c36a7a7 100755 --- a/tests/df/total-verify.sh +++ b/tests/df/total-verify.sh @@ -32,7 +32,7 @@ while (<>) # /dev/sdc1 0 0 0 - /c # tmpfs 1536000 12965 1523035 1% /tmp # total 5285932 787409 4498523 15% - - /^(.*?) +(-?\d+|-) +(-?\d+|-) +(-?\d+|-) +(?:- |[0-9]+%) (.*)$/ + /^(.*?) +(-?\d+|-) +(-?\d+|-) +(-?\d+|-) +(?:-|[0-9]+%) +(.*)$/ or die "$0: invalid input line\n: $_"; if ($1 eq 'total' && $5 eq '-') { ==== Regards, -gordon ------------=_1354788782-5811-1-- From unknown Sun Aug 17 10:17:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13099: possible test bug in "tests/df/total-verify.sh" Resent-From: Bernhard Voelker Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 06 Dec 2012 10:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13099 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: Assaf Gordon , 13099@debbugs.gnu.org Received: via spool by 13099-submit@debbugs.gnu.org id=B13099.13547894816914 (code B ref 13099); Thu, 06 Dec 2012 10:25:01 +0000 Received: (at 13099) by debbugs.gnu.org; 6 Dec 2012 10:24:41 +0000 Received: from localhost ([127.0.0.1]:55888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgYdF-0001nT-GB for submit@debbugs.gnu.org; Thu, 06 Dec 2012 05:24:41 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:50621) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgYdD-0001nJ-GP for 13099@debbugs.gnu.org; Thu, 06 Dec 2012 05:24:40 -0500 Received: from [192.168.1.11] (p4FC3E64E.dip.t-dialin.net [79.195.230.78]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0M31Ih-1Srl3n4Buh-00smd3; Thu, 06 Dec 2012 11:24:25 +0100 Message-ID: <50C07258.70402@bernhard-voelker.de> Date: Thu, 06 Dec 2012 11:24:24 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 References: <50C0121A.3030406@gmail.com> <50C01370.6010300@gmail.com> <50C063C1.30808@bernhard-voelker.de> <50C06B76.30209@draigBrady.com> In-Reply-To: <50C06B76.30209@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:hFNhj4y1FU9jkG1WoHc1cm/jB2h/18qFXR0o37HZrUu ASik0Wbh9oqnbTJvSJwbeRWkbmsnfnKawT3SNu0EfuMG63770+ i2GzEGvsRR8eHxJzxJJcEdCBSCuj2iXt852E9NN6oVH6XCUDos JaQOYrli8G4fdgMn/OnDK//3kJGtf39F7KX6npqESHRZoatxNk AxCP7m9ymdWWtXG13x5UuQlQ3iCEx3xUbiH0mFufbXVnoffbhx /j7u/xBYMaYuh8/R823c6H4kWf6dafLZN/rva4PEWzfw2G0+zd s5YRXyIPCmignpUL/DC2YgH1uBZ2Pw9ltqcaick/C31CCgf/eP t9GYdrGHAXwIekNRNVhAo0VBAzFy+QEz76JmXQVhk X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) On 12/06/2012 10:55 AM, Pádraig Brady wrote: > That still passes here with a "standard" file system at least. > Please push. I could reproduce the failure with a loop-mounted vfat image. Thanks for the review, pushed: http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=43a6ccf0 Have a nice day, Berny