GNU bug report logs - #13078
[PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces

Previous Next

Package: emacs;

Reported by: Josh <josh <at> foxtail.org>

Date: Tue, 4 Dec 2012 04:39:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

Message #17 received at 13078 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Josh <josh <at> foxtail.org>, 13078 <at> debbugs.gnu.org
Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to
	pkg-tool contains spaces
Date: Wed, 05 Dec 2012 00:01:30 -0500

>>>> -     if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then
>>>> +     if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then
>> I'd expect $PKG_CONFIG_MIN_VERSION to need quoting as well.
> It's a variable that we define ourselves rather than something we get
> from the environment, and we know it doesn't contain spaces.

I tend to just put "..." everywhere except in those rare cases where
I know I want the expansion to be split at spaces.

This way I don't need to worry about whether or not this is fully under
my control and whether I'm really sure it won't ever have a space in it.

Served me well so far,


        Stefan
This bug report was last modified 11 years and 293 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.