From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 03 23:38:01 2012 Received: (at submit) by debbugs.gnu.org; 4 Dec 2012 04:38:01 +0000 Received: from localhost ([127.0.0.1]:52321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfkGf-0004pp-9s for submit@debbugs.gnu.org; Mon, 03 Dec 2012 23:38:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59530) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfkGd-0004pi-Ad for submit@debbugs.gnu.org; Mon, 03 Dec 2012 23:38:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfkEG-0001ET-7q for submit@debbugs.gnu.org; Mon, 03 Dec 2012 23:35:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:45672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkEG-0001EP-4t for submit@debbugs.gnu.org; Mon, 03 Dec 2012 23:35:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkEA-0003dE-9K for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:35:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfkE8-0001Dk-7O for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:35:26 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:54446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkE8-0001De-2Y for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:35:24 -0500 Received: by mail-ob0-f169.google.com with SMTP id lz20so3831751obb.0 for ; Mon, 03 Dec 2012 20:35:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type:x-gm-message-state; bh=YOwnjksXwgKKU6qmXTWFQt226W4eowKrNSJAxu3P+tE=; b=gNxAj8Ug9RJHqq27s/HcV4KZ0MzzZcp/UU+06bo6xP+hbFw5E/P9++V2YIguXwKCfk wpSzRFF2b+VZSC1J9/IVVas8wvisT5jRW3mfV7g1/JWoj+3J8HbE56k+UHbBtbaC6A44 3sJFR63p+2rtRE9RXgOTzLmY5I96jvx/iJYWsbJ1aI0s2HXTGwbq0EckThQ1BJMQ3vZ4 K2azERkO13UE4IQ13u2vBPZWA413r23EO/xlRHTS8icKJ4dAJLalRi4pfwq86c0M5hv5 2bZbndz6hD7EGUfiKCLXCNjj8Wb3nidBIPPBahlTsAVQ4YhGNqUvUTVU3UqICrMOQG1m EIDA== Received: by 10.60.31.49 with SMTP id x17mr10578012oeh.33.1354595722733; Mon, 03 Dec 2012 20:35:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.51.229 with HTTP; Mon, 3 Dec 2012 20:35:02 -0800 (PST) From: Josh Date: Mon, 3 Dec 2012 20:35:02 -0800 X-Google-Sender-Auth: b8O0Q2pgsNz0XpYZMDhtbMqFd18 Message-ID: Subject: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQkpuE1fiDLKBv2nzwn+pKRwZ8UyfKhUivBboaTB9VpdXVOptv+8ny8Ow9BhsVa5hBwP2dL+ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Hi, I tried building trunk under Cygwin for the first time a few days ago (with the `--with-w32' switch, though I don't think that's relevant) but the build failed because ./configure was finding a version of pkg-config whose path contained whitespace. This exposed some quoting problems in configure.ac, fixed in the patch below. Here's a snippet of the session with some representative errors: checking for cma_open in -lpthreads... no ./configure: line 10967: /cygdrive/c/Program: No such file or directory *** Your version of pkg-config is too old. You need version 0.9.0 or newer. *** See http://www.freedesktop.org/software/pkgconfig checking for lgetfilecon in -lselinux... no ./configure: line 11304: /cygdrive/c/Program: No such file or directory *** Your version of pkg-config is too old. You need version 0.9.0 or newer. *** See http://www.freedesktop.org/software/pkgconfig checking for gnutls_certificate_set_verify_function... no [...] checking for gpm.h... no ./configure: line 13122: /cygdrive/c/Program: No such file or directory *** Your version of pkg-config is too old. You need version 0.9.0 or newer. *** See http://www.freedesktop.org/software/pkgconfig checking whether netdb declares h_errno... yes In addition to the quoting problem, it appears that failure to open a file is interpreted as having a version which is too old, which is perhaps not ideal. Here's the patch I applied locally that allowed me to build successfully: diff --git a/configure.ac b/configure.ac index 085ca83..85c21e1 100644 --- a/configure.ac +++ b/configure.ac @@ -1189,10 +1189,10 @@ AC_DEFUN([PKG_CHECK_MODULES], [ *** The pkg-config script could not be found. Make sure it is in your path, or give the full path to pkg-config with the PKG_CONFIG environment variable or --with-pkg-config-prog. Or see http://www.freedesktop.org/software/pkgconfig to get pkg-config.])], [$4]) else PKG_CONFIG_MIN_VERSION=0.9.0 - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then AC_MSG_CHECKING(for $2) - if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD && + if "$PKG_CONFIG" --exists "$2" 2>&AS_MESSAGE_LOG_FD && $1_CFLAGS=`$PKG_CONFIG --cflags "$2" 2>&AS_MESSAGE_LOG_FD` && $1_LIBS=`$PKG_CONFIG --libs "$2" 2>&AS_MESSAGE_LOG_FD`; then edit_cflags=" @@ -2027,7 +2027,7 @@ if test x"$pkg_check_gtk" = xyes; then AC_DEFINE(USE_GTK, 1, [Define to 1 if using GTK.]) GTK_OBJ="gtkutil.o $GTK_OBJ" USE_X_TOOLKIT=none - if $PKG_CONFIG --atleast-version=2.10 gtk+-2.0; then + if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then : else AC_MSG_WARN([[Your version of Gtk+ will have problems with From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 20:59:43 2012 Received: (at 13078) by debbugs.gnu.org; 5 Dec 2012 01:59:43 +0000 Received: from localhost ([127.0.0.1]:53896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg4H1-0003VG-6w for submit@debbugs.gnu.org; Tue, 04 Dec 2012 20:59:43 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54114) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg4Gy-0003V9-St for 13078@debbugs.gnu.org; Tue, 04 Dec 2012 20:59:41 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Tg4Gt-0004Rf-3L; Tue, 04 Dec 2012 20:59:35 -0500 From: Glenn Morris To: Josh Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces References: X-Spook: clandestine cracking espionage ANC Hamas Vickie Weaver X-Ran: YM8&^HxY6+UYm=x`bO\5=R[l(s&&.l|[[Y`TL52xxv (josh@foxtail.org's message of "Mon, 3 Dec 2012 20:35:02 -0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13078 Cc: 13078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Josh wrote: > but the build failed because ./configure was finding a version of > pkg-config whose path contained whitespace. This exposed some quoting > problems in configure.ac, fixed in the patch below. Thanks, see comments below. (I wouldn't be surprised to learn that there are similar problems for other variables.) > --- a/configure.ac > +++ b/configure.ac [...] > - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then > + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then > AC_MSG_CHECKING(for $2) > > - if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD && > + if "$PKG_CONFIG" --exists "$2" 2>&AS_MESSAGE_LOG_FD && > $1_CFLAGS=`$PKG_CONFIG --cflags "$2" 2>&AS_MESSAGE_LOG_FD` && ^^^^^^^^^^^ > $1_LIBS=`$PKG_CONFIG --libs "$2" 2>&AS_MESSAGE_LOG_FD`; then ^^^^^^^^^^^ Surely these (and the --print-errors call) need quoting too? > edit_cflags=" > @@ -2027,7 +2027,7 @@ if test x"$pkg_check_gtk" = xyes; then > AC_DEFINE(USE_GTK, 1, [Define to 1 if using GTK.]) > GTK_OBJ="gtkutil.o $GTK_OBJ" > USE_X_TOOLKIT=none > - if $PKG_CONFIG --atleast-version=2.10 gtk+-2.0; then > + if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 23:16:27 2012 Received: (at 13078) by debbugs.gnu.org; 5 Dec 2012 04:16:28 +0000 Received: from localhost ([127.0.0.1]:53963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg6PL-0007WJ-1r for submit@debbugs.gnu.org; Tue, 04 Dec 2012 23:16:27 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:18074) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg6PJ-0007WD-Nx for 13078@debbugs.gnu.org; Tue, 04 Dec 2012 23:16:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09soXOY/2dsb2JhbABEtBGBCIIWAQVWIxALDiYSFBgNJIghugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="209103917" Received: from 108-161-115-152.dsl.teksavvy.com (HELO pastel.home) ([108.161.115.152]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Dec 2012 23:16:20 -0500 Received: by pastel.home (Postfix, from userid 20848) id BA98A58C73; Tue, 4 Dec 2012 23:16:19 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces Message-ID: References: Date: Tue, 04 Dec 2012 23:16:19 -0500 In-Reply-To: (Glenn Morris's message of "Tue, 04 Dec 2012 20:59:34 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 13078 Cc: Josh , 13078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then >> + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then I'd expect $PKG_CONFIG_MIN_VERSION to need quoting as well. In my experience, $FOO variable references in sh scripts need to be wrapped inside "..." by default to avoid such problem. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 23:40:52 2012 Received: (at 13078) by debbugs.gnu.org; 5 Dec 2012 04:40:52 +0000 Received: from localhost ([127.0.0.1]:53974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg6mx-00083w-JC for submit@debbugs.gnu.org; Tue, 04 Dec 2012 23:40:52 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56549) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg6mu-00083n-Mg for 13078@debbugs.gnu.org; Tue, 04 Dec 2012 23:40:50 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Tg6mo-0000Nv-8Q; Tue, 04 Dec 2012 23:40:42 -0500 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces References: X-Spook: Armani keyhole Kosovo NASA Exon Shell BLU-97 A/B FSF X-Ran: oTmW=FHuCbkxiZ~sym,jkD$TCsqgNG<>d~Q:zRwF>K)lW&O*O&r?}nv3PEq1F=Z,O+Q2:F X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 04 Dec 2012 23:40:42 -0500 In-Reply-To: (Stefan Monnier's message of "Tue, 04 Dec 2012 23:16:19 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13078 Cc: Josh , 13078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Stefan Monnier wrote: >>> - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then >>> + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then > > I'd expect $PKG_CONFIG_MIN_VERSION to need quoting as well. It's a variable that we define ourselves rather than something we get from the environment, and we know it doesn't contain spaces. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 05 00:01:38 2012 Received: (at 13078) by debbugs.gnu.org; 5 Dec 2012 05:01:38 +0000 Received: from localhost ([127.0.0.1]:53982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg774-00004s-0J for submit@debbugs.gnu.org; Wed, 05 Dec 2012 00:01:38 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:59094) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg772-0008WS-PO for 13078@debbugs.gnu.org; Wed, 05 Dec 2012 00:01:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09soXOY/2dsb2JhbABEtBGBCIIWAQVWIxALDiYSFBgNJIghugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="209105135" Received: from 108-161-115-152.dsl.teksavvy.com (HELO pastel.home) ([108.161.115.152]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Dec 2012 00:01:30 -0500 Received: by pastel.home (Postfix, from userid 20848) id 7AF8158C73; Wed, 5 Dec 2012 00:01:30 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces Message-ID: References: Date: Wed, 05 Dec 2012 00:01:30 -0500 In-Reply-To: (Glenn Morris's message of "Tue, 04 Dec 2012 23:40:42 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13078 Cc: Josh , 13078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) >>>> - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then >>>> + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then >> I'd expect $PKG_CONFIG_MIN_VERSION to need quoting as well. > It's a variable that we define ourselves rather than something we get > from the environment, and we know it doesn't contain spaces. I tend to just put "..." everywhere except in those rare cases where I know I want the expansion to be split at spaces. This way I don't need to worry about whether or not this is fully under my control and whether I'm really sure it won't ever have a space in it. Served me well so far, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 05 00:14:16 2012 Received: (at 13078) by debbugs.gnu.org; 5 Dec 2012 05:14:16 +0000 Received: from localhost ([127.0.0.1]:54027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg7JH-0000NA-B9 for submit@debbugs.gnu.org; Wed, 05 Dec 2012 00:14:15 -0500 Received: from mail-oa0-f44.google.com ([209.85.219.44]:43580) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg7JF-0000N1-7R for 13078@debbugs.gnu.org; Wed, 05 Dec 2012 00:14:14 -0500 Received: by mail-oa0-f44.google.com with SMTP id n5so4620662oag.3 for <13078@debbugs.gnu.org>; Tue, 04 Dec 2012 21:14:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=aH6FSXWk5JQMA1RmojA0lbZSi+69sdlqO6Bf8vQlO/g=; b=Go6yHC5QewbXjh0fDgoqIGVqkg1W+19TMuMzmtSOMeg3ze5HmmCSmBqYXU7eeXMHIL Vlv9fKoor/iv+VwS5sLU5nPf1kETctoNHK4VGgIUWvubLMGY5fhEeuqbJhMeUHwOOWEu rjUKJhcSVMFKqz0Q+M7r/xIFBPVbUBzb9ATz01FibHSooduQxPX9t/+/mwmaJhqkr4Jy HpnZCJLzExLdjCNRj3XNSTLhHeC6cHJCJyBMLbh28UQVT6iQzXK+tiukYbq3XAMChdFS 5ybNjIz+xl3ymVRUpbse1LYivgyjWrbBg6EVzv+845B3j13iAzrro12zCm3rJZ0zbP04 ZcfQ== Received: by 10.60.0.138 with SMTP id 10mr13329740oee.142.1354684447226; Tue, 04 Dec 2012 21:14:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.51.229 with HTTP; Tue, 4 Dec 2012 21:13:47 -0800 (PST) In-Reply-To: References: From: Josh Date: Tue, 4 Dec 2012 21:13:47 -0800 X-Google-Sender-Auth: 98-c06HTpze3GJBXWeowCZqbTnU Message-ID: Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces To: Glenn Morris Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmwDzdkX5cMh124F7FHZX2t9dYA5bB0x4k6t7u1Qr5YWuSieeobKUxl8fkmMS2hurzSZvwn X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13078 Cc: 13078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) On Tue, Dec 4, 2012 at 5:59 PM, Glenn Morris wrote: > Josh wrote: > >> but the build failed because ./configure was finding a version of >> pkg-config whose path contained whitespace. This exposed some quoting >> problems in configure.ac, fixed in the patch below. > > Thanks, see comments below. (I wouldn't be surprised to learn that there > are similar problems for other variables.) Nor would I. My patch addresses only the failure I encountered; it might be worthwhile for someone more conversant with the build process than I to investigate. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 21:28:40 2012 Received: (at 13078-done) by debbugs.gnu.org; 9 Dec 2012 02:28:40 +0000 Received: from localhost ([127.0.0.1]:33419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThWdE-0001KZ-10 for submit@debbugs.gnu.org; Sat, 08 Dec 2012 21:28:40 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:35540) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThWdB-0001KR-No for 13078-done@debbugs.gnu.org; Sat, 08 Dec 2012 21:28:39 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id ADEC139E8106 for <13078-done@debbugs.gnu.org>; Sat, 8 Dec 2012 18:28:09 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89jUb7NRZC4T for <13078-done@debbugs.gnu.org>; Sat, 8 Dec 2012 18:28:08 -0800 (PST) Received: from [192.168.1.3] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7A58F39E8008 for <13078-done@debbugs.gnu.org>; Sat, 8 Dec 2012 18:28:08 -0800 (PST) Message-ID: <50C3F73F.9060809@cs.ucla.edu> Date: Sat, 08 Dec 2012 18:28:15 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: 13078-done@debbugs.gnu.org Subject: Re: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 13078-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.5 (-) I looked into problems in this area in configure.ac and fixed all the ones mentioned so far in this bug report, along with some others, in trunk bzr 111162. No doubt there are similar problems in other parts of Emacs, but at least this bug report we can mark 'done' so I've done that. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 23:14:56 2012 Received: (at 13078) by debbugs.gnu.org; 9 Dec 2012 04:14:56 +0000 Received: from localhost ([127.0.0.1]:33477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThYI4-0003k0-9T for submit@debbugs.gnu.org; Sat, 08 Dec 2012 23:14:56 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:53540) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThYI0-0003jm-PX for 13078@debbugs.gnu.org; Sat, 08 Dec 2012 23:14:54 -0500 Received: by mail-ob0-f172.google.com with SMTP id za17so1485543obc.3 for <13078@debbugs.gnu.org>; Sat, 08 Dec 2012 20:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=tFPfS0gpgChpyfCrpo15UYgofVvMVXkTqziwq+vTvao=; b=HKPi27myneEoYqfojeshl7CO7VjjiYNe2+evCslO3BPXnj2c9bUyzN3RmuYCRo/0Di CeUDL22fLEWo/QgJsmlg3XBxqYwYhKTUzYsHtMDU9UqjxFXBPBA7F4iJauPoetnTAF8D ptQeCV/1Ulhd0OwbPcThRWg09Lht0OsVLZBQ/uLfoqAqkvUdEVUK/JZ3yQaSut9MmeBd cTWQt6EKYcUR2WpeTQ7jHTBzutDGDG1pCGWVfSi+qDHKYpSyAMi2TOghnhMK215OeDyX 9rBoF/hkFxNAmSteFvRhkrojE15MlO3vJ4FxPHJZZXV6VzHmZi8yFaAfW2N417ah3bx/ ykog== Received: by 10.60.31.49 with SMTP id x17mr5716124oeh.33.1355026464391; Sat, 08 Dec 2012 20:14:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.51.229 with HTTP; Sat, 8 Dec 2012 20:14:03 -0800 (PST) In-Reply-To: <50C3F73F.9060809@cs.ucla.edu> References: <50C3F73F.9060809@cs.ucla.edu> From: Josh Date: Sat, 8 Dec 2012 20:14:03 -0800 X-Google-Sender-Auth: DKZbRgzZiUGyKCG8LzxuISCBJSU Message-ID: Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces To: 13078@debbugs.gnu.org, eggert@cs.ucla.edu, josh@foxtail.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQkjySxvo6YcaX4HByuRmgpF2INPYjVwJT0YVNupk7DOnKvLm4u3a4C47DBRwlhW+ZYtK1Hq X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13078 Cc: 13078-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) Great, thanks for looking into it Paul. Josh On Sat, Dec 8, 2012 at 6:28 PM, Paul Eggert wrote: > I looked into problems in this area in configure.ac and > fixed all the ones mentioned so far in this bug report, > along with some others, in trunk bzr 111162. No doubt > there are similar problems in other parts of Emacs, > but at least this bug report we can mark 'done' so I've done that. > > > From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 09 02:58:39 2012 Received: (at 13078) by debbugs.gnu.org; 9 Dec 2012 07:58:39 +0000 Received: from localhost ([127.0.0.1]:33536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThbmZ-0001MT-0q for submit@debbugs.gnu.org; Sun, 09 Dec 2012 02:58:39 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:49221) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThbmV-0001ML-Kz for 13078@debbugs.gnu.org; Sun, 09 Dec 2012 02:58:37 -0500 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3YK0CK2gLPz3hhjV; Sun, 9 Dec 2012 08:58:04 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3YK0CJ34KBzbbcx; Sun, 9 Dec 2012 08:58:04 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id HMPmM53kzKrg; Sun, 9 Dec 2012 08:58:03 +0100 (CET) X-Auth-Info: vDfP2vJ95GtbiDIssS6BSxlOZMDiiyxmxjctQf3z9zY= Received: from linux.local (ppp-88-217-121-108.dynamic.mnet-online.de [88.217.121.108]) by mail.mnet-online.de (Postfix) with ESMTPA; Sun, 9 Dec 2012 08:58:03 +0100 (CET) Received: by linux.local (Postfix, from userid 501) id 2A53314E11A; Sun, 9 Dec 2012 08:58:00 +0100 (CET) From: Andreas Schwab To: 13078@debbugs.gnu.org Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces References: <50C3F73F.9060809@cs.ucla.edu> X-Yow: On the other hand, life can be an endless parade of TRANSSEXUAL QUILTING BEES aboard a cruise ship to DISNEYWORLD if only we let it!! Date: Sun, 09 Dec 2012 08:57:59 +0100 In-Reply-To: <50C3F73F.9060809@cs.ucla.edu> (Paul Eggert's message of "Sat, 08 Dec 2012 18:28:15 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 13078 Cc: josh@foxtail.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Paul Eggert writes: > I looked into problems in this area in configure.ac and > fixed all the ones mentioned so far in this bug report, > along with some others, in trunk bzr 111162. This is wrong. It must be possible to pass options in MAKEINFO and PKG_CONFIG. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 09 04:05:42 2012 Received: (at 13078) by debbugs.gnu.org; 9 Dec 2012 09:05:42 +0000 Received: from localhost ([127.0.0.1]:33578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThcpR-0002u3-Us for submit@debbugs.gnu.org; Sun, 09 Dec 2012 04:05:42 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:45467) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThcpQ-0002tw-Rt for 13078@debbugs.gnu.org; Sun, 09 Dec 2012 04:05:41 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id BCE2039E810A; Sun, 9 Dec 2012 01:05:11 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DCrIlCe1V3OV; Sun, 9 Dec 2012 01:05:11 -0800 (PST) Received: from [192.168.1.3] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 49CDD39E8100; Sun, 9 Dec 2012 01:05:11 -0800 (PST) Message-ID: <50C45450.4080908@cs.ucla.edu> Date: Sun, 09 Dec 2012 01:05:20 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Andreas Schwab Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces References: <50C3F73F.9060809@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 13078 Cc: josh@foxtail.org, 13078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.5 (-) On 12/08/2012 11:57 PM, Andreas Schwab wrote: > This is wrong. It must be possible to pass options in MAKEINFO and > PKG_CONFIG. MAKEINFO perhaps (and I see that you already changed that back), but PKG_CONFIG was already documented as being a file name, not a command with arguments, so it seems more appropriate to quote it. If we want to make it possible to pass options to PKG_CONFIG, we could add another 'configure' option to do that. Is it documented anywhere that Emacs cannot be built if the working directory has spaces or other special characters in its fully qualified file name? If not, perhaps it should be. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 09 06:53:47 2012 Received: (at 13078) by debbugs.gnu.org; 9 Dec 2012 11:53:47 +0000 Received: from localhost ([127.0.0.1]:33665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThfS7-0006qA-Hl for submit@debbugs.gnu.org; Sun, 09 Dec 2012 06:53:47 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:50311) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThfS3-0006q0-Jo for 13078@debbugs.gnu.org; Sun, 09 Dec 2012 06:53:45 -0500 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3YK5Qc6CSjz4KK6k; Sun, 9 Dec 2012 12:53:12 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3YK5Qc4Rf1zbbjS; Sun, 9 Dec 2012 12:53:12 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id LcxAdlHMyc03; Sun, 9 Dec 2012 12:53:11 +0100 (CET) X-Auth-Info: MjoMLAMRc5bR+vPuSv4icgJ6MG5rbG9IKDATz2KTcPM= Received: from igel.home (ppp-88-217-121-108.dynamic.mnet-online.de [88.217.121.108]) by mail.mnet-online.de (Postfix) with ESMTPA; Sun, 9 Dec 2012 12:53:10 +0100 (CET) Received: by igel.home (Postfix, from userid 501) id 5BB92CA2C5; Sun, 9 Dec 2012 12:53:10 +0100 (CET) From: Andreas Schwab To: Paul Eggert Subject: Re: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces References: <50C3F73F.9060809@cs.ucla.edu> <50C45450.4080908@cs.ucla.edu> X-Yow: I don't think you fellows would do so much RAPING and PILLAGING if you played more PINBALL and watched CABLE TELEVISION!! Date: Sun, 09 Dec 2012 12:53:10 +0100 In-Reply-To: <50C45450.4080908@cs.ucla.edu> (Paul Eggert's message of "Sun, 09 Dec 2012 01:05:20 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 13078 Cc: josh@foxtail.org, 13078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Paul Eggert writes: > Is it documented anywhere that Emacs cannot be built if > the working directory has spaces or other special characters > in its fully qualified file name? configure rejects them. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Mon Aug 18 14:25:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 06 Jan 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 21 21:14:02 2013 Received: (at control) by debbugs.gnu.org; 22 Oct 2013 01:14:02 +0000 Received: from localhost ([127.0.0.1]:33778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VYQXq-0006wv-0t for submit@debbugs.gnu.org; Mon, 21 Oct 2013 21:14:02 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:58351 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VYQXm-0006wO-Tp for control@debbugs.gnu.org; Mon, 21 Oct 2013 21:13:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VYQXm-0006NR-3m for control@debbugs.gnu.org; Mon, 21 Oct 2013 21:13:58 -0400 Date: Mon, 21 Oct 2013 21:13:58 -0400 Message-Id: Subject: control message for bug 15675 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) unarchive 13078 unmerge 15675 From unknown Mon Aug 18 14:25:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Nov 2013 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator