From unknown Fri Aug 15 22:18:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures Resent-From: Stephen Berman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Dec 2012 00:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13072@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135457944523626 (code B ref -1); Tue, 04 Dec 2012 00:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Dec 2012 00:04:05 +0000 Received: from localhost ([127.0.0.1]:52134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TffzY-000691-8T for submit@debbugs.gnu.org; Mon, 03 Dec 2012 19:04:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39993) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TffzS-00068Y-HB for submit@debbugs.gnu.org; Mon, 03 Dec 2012 19:04:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tffx3-00036u-M0 for submit@debbugs.gnu.org; Mon, 03 Dec 2012 19:01:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:44102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tffx3-00036q-IT for submit@debbugs.gnu.org; Mon, 03 Dec 2012 19:01:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tffwz-0005o6-UR for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 19:01:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tffwx-000362-0e for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 19:01:25 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:46137) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Tffww-00035w-NT for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 19:01:22 -0500 Received: (qmail invoked by alias); 04 Dec 2012 00:01:20 -0000 Received: from i59F55AB4.versanet.de (EHLO rosalinde.fritz.box) [89.245.90.180] by mail.gmx.net (mp039) with SMTP; 04 Dec 2012 01:01:20 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1/n8RNSb0Hnpe2It6YaP/uDxv9bA2z9/JvOm8L+iY pYebKuD1bPfYAs From: Stephen Berman Date: Tue, 04 Dec 2012 01:01:15 +0100 Message-ID: <87k3sybs8k.fsf@rosalinde.fritz.box> MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) In GNU Emacs 24.3.50.6 (x86_64-suse-linux-gnu, GTK+ Version 3.4.4) of 2012-12-03 on rosalinde Bzr revision: 111073 dmantipov@yandex.ru-20121203080602-hwv4fug7bvt2red7 Windowing system distributor `The X.Org Foundation', version 11.0.11203000 System Description: openSUSE 12.2 (x86_64) Configured using: `configure '--without-toolkit-scroll-bars' 'CFLAGS=-g3 -O0'' Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=local locale-coding-system: utf-8-unix default enable-multibyte-characters: t The doc string of calendar-date-display-form says: For example, a typical American form would be '(month "/" day "/" (substring year -2)) whereas '((format "%9s, %9s %2s, %4s" dayname monthname day year)) would give the usual American style in fixed-length fields. But if you set calendar-date-display-form to either of these values (either via setq in your user-init-file or via the Custom interface), then in the Fancy Diary display the date header line is not fontified. To reproduce: 0. Let the file ~/diary consist of entries dated today, like these: +------------------ | Dec 3, 2012 test1 | 12/3/2012 test2 | 12/3/12 test3 +------------------ 1. emacs -Q 2. M-x calendar 3. In the *Calendar* buffer type `d' to get the Fancy Diary display, and note the fontified date header: +------------------ | Monday, December 3, 2012 | ======================== | test2 | test3 | test1 +------------------ 4. Kill the *Fancy Diary Entries* buffer. 5. Type `M-x customize-option RET calendar-date-display-form RET', change the value from the default `((if dayname (concat dayname ", ")) monthname " " day ", " year)' to `(month "/" day "/" (substring year -2))', then repeat steps 2 and 3. => The date header in the Fancy Diary display is not fontified. Now repeat steps 4 and 5, this time changing the value to `((format "%9s, %9s %2s, %4s" dayname monthname day year))', then repeat steps 2 and 3 again. => Again, the date header in the Fancy Diary display is not fontified. If you restore the default value and repeat steps 2 and 3, now the date header is fontified again. (Note, too, the all the entries in the ~/diary have correctly fontified headers, regardless of the value of calendar-date-display-form.) I think these two cases (using `substring' and using `format' in the value of calendar-date-display-form) fail to fontify for different reasons: - In the substring case, the problem is that in diary-fancy-date-pattern, the form `(substring year -2)' is evaluated with `year' let-bound to "3", which raises an args-out-of-range error, short-circuiting fontification. - In contrast, the `format' form returns a string with the variables replaced by their let-bound values, which evaluates to itself and is passed to replace-regexp-in-string, so diary-fancy-date-pattern returns a valid regexp for the Fancy Diary header, so fontification should occur AFAICT, yet it doesn't. However, this appears to depend on the pattern and values of the width specifiers in the format string, in a way I don't understand. From testing lots of combinations, I found the following generalization appears to hold: if the second `%s' sequence (corresponding to `monthname') has a width specifier not greater than 8 (note that `monthname' evaluates to "December", a string of 9 characters; I haven't tested other month names yet) and the fourth `%s' sequence (corresponding to `year') has a width specifier not greater than 1, then in the Fancy Diary display, the date header is correctly fontified, regardless of the values (or presence) of the first and third width specifiers (corresponding to `dayname' and `day'); otherwise, fontification fails. (I haven't yet tested different numbers of `%s' sequences.) I have no idea what's going on with the `format' cases; but if an explanation can be found for the behavior I described, which is independent of how diary-fancy-date-pattern builds the regexp -- in other words, if we assume that the regexp resulting from `format' in general is valid for fontification, then the following patch, which fixes the fontification failure in the `substring' case (and generalizes it to all non-atomic sexps aside from `format' sexps) is one possible half of the solution. === modified file 'lisp/calendar/diary-lib.el' *** lisp/calendar/diary-lib.el 2012-11-27 15:40:49 +0000 --- lisp/calendar/diary-lib.el 2012-12-03 23:48:18 +0000 *************** *** 2461,2469 **** ;; string form"; eg the iso version calls string-to-number on some. ;; Therefore we cannot eg just let day = "[0-9]+". (Bug#8583). ;; Assumes no integers in c-day/month-name-array. ! (replace-regexp-in-string "[0-9]+" "[0-9]+" ! (mapconcat 'eval calendar-date-display-form "") ! nil t)) ;; Optional ": holiday name" after the date. "\\(: .*\\)?")) --- 2461,2478 ---- ;; string form"; eg the iso version calls string-to-number on some. ;; Therefore we cannot eg just let day = "[0-9]+". (Bug#8583). ;; Assumes no integers in c-day/month-name-array. ! (replace-regexp-in-string ! "[0-9]+" "[0-9]+" ! (mapconcat (lambda (x) (if (or (atom x) (eq (car x) 'format)) ! (eval x) ! (catch 'end ! (while (consp x) ! (let ((y (pop x))) ! (when (or (eq y 'year) (eq y 'month) ! (eq y 'day)) ! (throw 'end (eval y)))))))) ! calendar-date-display-form "") ! nil t)) ;; Optional ": holiday name" after the date. "\\(: .*\\)?")) From unknown Fri Aug 15 22:18:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: 13072@debbugs.gnu.org Received: via spool by 13072-submit@debbugs.gnu.org id=B13072.159801332530171 (code B ref 13072); Fri, 21 Aug 2020 12:36:02 +0000 Received: (at 13072) by debbugs.gnu.org; 21 Aug 2020 12:35:25 +0000 Received: from localhost ([127.0.0.1]:45309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96GT-0007qY-9X for submit@debbugs.gnu.org; Fri, 21 Aug 2020 08:35:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96GQ-0007qD-K7 for 13072@debbugs.gnu.org; Fri, 21 Aug 2020 08:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=03jNeKRSRuKifN+UeFRUkpgdNGppr0ugTY9mVaHLJPc=; b=pzaZO9FPz0O1qneVXcZzHiKLZY 3bMK6BBrDJi9QW+x52dGCZOUAFtY0FRl1bcytRCUfuDc2lRqsgQez6kUB/No+DE9y8J354dSiy42s yxDmnFL+t8M6ETtTXcTUVNUmjKduWYEqyX+MJDrCmBhUEivb+MGgzkHLNZNZlsSVOWTE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k96GD-0003eC-Tj; Fri, 21 Aug 2020 14:35:16 +0200 From: Lars Ingebrigtsen References: <87k3sybs8k.fsf@rosalinde.fritz.box> X-Now-Playing: The Raincoats's _The Raincoats_: "Fairytale in the Supermarket" Date: Fri, 21 Aug 2020 14:35:08 +0200 In-Reply-To: <87k3sybs8k.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Tue, 04 Dec 2012 01:01:15 +0100") Message-ID: <87v9hc5g8z.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > The doc string of calendar-date-display-form says: > > For example, a typical American form would be > '(month "/" day "/" (substring year -2)) > whereas > '((format "%9s, %9s %2s, %4s" dayname mont [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > The doc string of calendar-date-display-form says: > > For example, a typical American form would be > '(month "/" day "/" (substring year -2)) > whereas > '((format "%9s, %9s %2s, %4s" dayname monthname day year)) > would give the usual American style in fixed-length fields. > > But if you set calendar-date-display-form to either of these values > (either via setq in your user-init-file or via the Custom interface), > then in the Fancy Diary display the date header line is not fontified. I've respun your patch for Emacs 28... However, I'm not really sure why Fancy Diary Mode is doing any of this -- it seems kinda misguided, and as you say, your patch only fixes half of the problem. Instead of inserting the heading, and then trying to make a regexp to match the heading and letting font-lock fontize, why doesn't it just put the correct face on the heading when it inserts it? Because trying to make that regexp is bound to have strange edge cases. Historical reasons? diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el index da98e44926..8ea831554b 100644 --- a/lisp/calendar/diary-lib.el +++ b/lisp/calendar/diary-lib.el @@ -2406,9 +2406,18 @@ diary-fancy-date-pattern ;; string form"; eg the iso version calls string-to-number on some. ;; Therefore we cannot eg just let day = "[0-9]+". (Bug#8583). ;; Assumes no integers in c-day/month-name-array. - (replace-regexp-in-string "[0-9]+" "[0-9]+" - (mapconcat #'eval calendar-date-display-form "") - nil t)) + (replace-regexp-in-string + "[0-9]+" "[0-9]+" + (mapconcat (lambda (x) + (if (or (atom x) (eq (car x) 'format)) + (eval x) + (catch 'end + (while (consp x) + (let ((y (pop x))) + (when (or (eq y 'year) (eq y 'month) (eq y 'day)) + (throw 'end (eval y)))))))) + calendar-date-display-form "") + nil t)) ;; Optional ": holiday name" after the date. "\\(: .*\\)?")) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 21 08:35:32 2020 Received: (at control) by debbugs.gnu.org; 21 Aug 2020 12:35:32 +0000 Received: from localhost ([127.0.0.1]:45312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96Ga-0007qs-IP for submit@debbugs.gnu.org; Fri, 21 Aug 2020 08:35:32 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96GY-0007qa-Po for control@debbugs.gnu.org; Fri, 21 Aug 2020 08:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QPuSor/eNr/1RBoANkhphRUEL5bO5w/t9MRP1nloE5o=; b=EoSKhyRmfHBHZszjd+zcJSgRBm 2e7aR3ac8zf0TOVcQNxK3bG0xHIC6VYOct/XgOF6EuyQR2T+ip92+avA7B4jsH+Oh/B/M1Po1NgFv OHgy8Ga2nOMhF9s4HFACBrKAYiMndDw88iBH/ZNNFtvrx4/hfn3OltLqu7KMzYeDc2Wg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k96GR-0003eL-1C for control@debbugs.gnu.org; Fri, 21 Aug 2020 14:35:25 +0200 Date: Fri, 21 Aug 2020 14:35:21 +0200 Message-Id: <87tuww5g8m.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13072 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 13072 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 13072 + patch quit From unknown Fri Aug 15 22:18:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 13072@debbugs.gnu.org Received: via spool by 13072-submit@debbugs.gnu.org id=B13072.15980212237230 (code B ref 13072); Fri, 21 Aug 2020 14:48:01 +0000 Received: (at 13072) by debbugs.gnu.org; 21 Aug 2020 14:47:03 +0000 Received: from localhost ([127.0.0.1]:47995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k98Jr-0001sG-5d for submit@debbugs.gnu.org; Fri, 21 Aug 2020 10:47:03 -0400 Received: from mout.gmx.net ([212.227.17.20]:54023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k98Jn-0001kl-S1 for 13072@debbugs.gnu.org; Fri, 21 Aug 2020 10:47:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598021213; bh=JalsOmw0XNZ6wQBFGiY3bVQdrJPsG/f3zU4Z5ZtdDM8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=A/BpnVRQWFvfTrrhXvbXoi5afu4CtEYY5nfQig2ygAn0eE2ESACO97Hb/mqU4cJlc v/JzirHkiLDabW5/AX/gtJf3HHlu2xPyi7ci2ndzaqW8k818s4aB50zQEcIWb+6ooJ cKgRsE59TrjLrYhDpSonqhYtB/8qA/Su78X3Zd0E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([178.1.122.94]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQ5vc-1kMFJd1rZA-00M7ZS; Fri, 21 Aug 2020 16:46:53 +0200 From: Stephen Berman References: <87k3sybs8k.fsf@rosalinde.fritz.box> <87v9hc5g8z.fsf@gnus.org> Date: Fri, 21 Aug 2020 16:46:52 +0200 In-Reply-To: <87v9hc5g8z.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Aug 2020 14:35:08 +0200") Message-ID: <87r1s0m4yr.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:bdP1Cj0Rlu6/mh3VmU2dsujrst3XmoMXIujppMr2cxyFHKbGnCd YYZxlm4j4nKpeWKuu52jCBBdkfkl5jMUjqOm/0M/p6vfXOVPPuc9KowDdSkAHycBH8pLnx6 NBfJN9A79xIWT72CHiJW6VQGJ74p2y22fmjSVVSleUNUyEWgTK+KIyOeQSQi77ID7sWBW6a n4rIVWIMDGhPEmTxj5K2A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:y3ICzstBo2c=:bFbFPlxy5FMhnxklOmo+x5 700NEVaOSuGKDzcoOdJjed6qO7rm+eeL07XKAXij+ENvOmYUK0Fjei1ONwI7u5GNMSAJ0gHM1 jGK2SPwDz5pHItpurxwm45yfoM6F9THdHTXKdMGoi326+vXN5sLmZx+v8fJaM5BFbJzL1II6J FZh65+AQ8n6JCsR2Qb1T/5PGMfkcBUhAeVv3OqqH3IBsAOSnY7BVVKZ06nKDW6SPgFktqQxc4 xV+6/lA0gvoTmc1c1htftoNRdp9HRUry2z9tg/YR3zq38/xoXpn+hYumLbfYgOW1gunqOB2KD PwwgPtNKv9M0C3sFz81bxEaRhLeWTuNykyh3C1gMGbWTmVIFHjF2DUfZaIrb1EchNS9oGckcE zVk65GaiKc+EdLhs65ey1eM394lZjNgGtMjXAHwQBYkrWXbspLg4P+Bph2QgwDmDhjlH3Yma0 p6cSw5DoDYiELbvb+9gJbacY21t9loEZofFqIK0oOtaqPzx511oFPXJAEeJGxq5jXoN2rIYiD QH7X5Z8bjb6qf4MSXT/OVY9HuLxdNXw4TDWSkEJqAfdFwIxQOA28dLC13cuXcQS2lfmG4aJP0 oh6ShsmfCevVqE72adypHTGOg1Wtoe8eLpTMArgdxOqH2FqkpEZQLevYbEXmeehYYDZMFJDLW 4UbkIQ/4R/S3FOfM7LSQKJxinMmFhmH3Tb80BZGx4oTSYGO8JOFG6OZIavwX6D6L/WQ9LWdlh dTGKfZjTyg+VEjFmBIgXxke7Vyfe1kZzEzF+wvOHgOCXF+Ucr5QQ026O4WCGEaK/fK0z0bq0m MUfXTPmWT9+/1054PV2CjbF0Z528OkXWTN55wWVkXgkMDTkwdjw6DWqEJCJxK0tNGnWxheFAr 1By2qdMvQmUMOx2gyi3RrQaiHsbWBu7acBqv1vY2exltOHFTglaWkpRkhGlcPl2w2esylauo/ JRIYb2F9MNS5TRnYTbGQpRHjAgdNBTACh3vyCrnk+Ne719EcjaqnduJBCOyeleMBNkzaDX739 IZbb84oAkRHnEIKIGhulIO2n6MIvmQrzegtmZPuLmCctx0aX4/1QAPG22Fu1lP3gPpIbeTma/ 8U4RY+r5geyG8uRAE2Kcm2Hu8h1zBSLSYDlI6YyoQy6BN2T/9zVNLAHNQf3x1FAuT5PL1QCkg /s+LSpEuKpMG5egQnk3uN1D43U7kKZnWC7eBCd43lpKJYXUdvNtzpsDFD7M/XVFtlXmkjekTM fkuQbMuKMu1dwnux9EYKdy77zwKl/6EGxFzSTrg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 21 Aug 2020 14:35:08 +0200 Lars Ingebrigtsen wrote: > Stephen Berman writes: > >> The doc string of calendar-date-display-form says: >> >> For example, a typical American form would be >> '(month "/" day "/" (substring year -2)) >> whereas >> '((format "%9s, %9s %2s, %4s" dayname monthname day year)) >> would give the usual American style in fixed-length fields. >> >> But if you set calendar-date-display-form to either of these values >> (either via setq in your user-init-file or via the Custom interface), >> then in the Fancy Diary display the date header line is not fontified. > > I've respun your patch for Emacs 28... > > However, I'm not really sure why Fancy Diary Mode is doing any of > this -- it seems kinda misguided, and as you say, your patch only fixes > half of the problem. > > Instead of inserting the heading, and then trying to make a regexp to > match the heading and letting font-lock fontize, why doesn't it just put > the correct face on the heading when it inserts it? Because trying to > make that regexp is bound to have strange edge cases. > > Historical reasons? I don't know, but a first rough implementation of your suggestion seems promising: with the patch below, when using either of the above values of calendar-date-display-form, the date strings are fontified. A complete fix should go through the code carefully, checking for possible corner cases. Glenn Morris probably knows best if such an approach is worth pursuing. Steve Berman diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el index da98e44926..2d024c04d9 100644 --- a/lisp/calendar/diary-lib.el +++ b/lisp/calendar/diary-lib.el @@ -1092,7 +1092,8 @@ diary-fancy-display (if (calendar-date-equal date (car h)) (setq date-holiday-list (append date-holiday-list (cdr h))))) - (insert (if (bobp) "" ?\n) (calendar-date-string date)) + (insert (if (bobp) "" ?\n) + (propertize (calendar-date-string date) 'face 'diary)) (if date-holiday-list (insert ": ")) (setq cc (current-column)) (insert (mapconcat (lambda (x) @@ -2460,11 +2461,6 @@ diary-fancy-overriding-map (define-derived-mode diary-fancy-display-mode special-mode "Diary" "Major mode used while displaying diary entries using Fancy Display." - (set (make-local-variable 'font-lock-defaults) - '(diary-fancy-font-lock-keywords - t nil nil nil - (font-lock-fontify-region-function - . diary-fancy-font-lock-fontify-region-function))) (set (make-local-variable 'minor-mode-overriding-map-alist) (list (cons t diary-fancy-overriding-map))) (view-mode 1)) From unknown Fri Aug 15 22:18:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Aug 2020 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman Cc: 13072@debbugs.gnu.org Received: via spool by 13072-submit@debbugs.gnu.org id=B13072.15981028115996 (code B ref 13072); Sat, 22 Aug 2020 13:27:02 +0000 Received: (at 13072) by debbugs.gnu.org; 22 Aug 2020 13:26:51 +0000 Received: from localhost ([127.0.0.1]:49102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9TXm-0001Yd-K6 for submit@debbugs.gnu.org; Sat, 22 Aug 2020 09:26:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9TXl-0001YR-E4 for 13072@debbugs.gnu.org; Sat, 22 Aug 2020 09:26:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PFCBjhy3cPAUsJ+Mry83wA0poxrBfgc5HpqXi7jiayE=; b=BjFDixb67cXvazsw1g/VbrAcqE oxw6GYxCdx0v2XphBVrNh+qwEz1qgNzTXZDPSUdOgpDBoxlBfOUvXaZBvvXXMKa4J0FyLPy3OHeba iS6l/UL+OenpREc8hGUIfPZIPlKxQXahZXXe/fGdr7Vn3T+ZbxanAw53sOd/C5qnJQBc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9TXc-0007qZ-0F; Sat, 22 Aug 2020 15:26:43 +0200 From: Lars Ingebrigtsen References: <87k3sybs8k.fsf@rosalinde.fritz.box> <87v9hc5g8z.fsf@gnus.org> <87r1s0m4yr.fsf@gmx.net> X-Now-Playing: The Contortions's _Buy_: "Design to Kill" Date: Sat, 22 Aug 2020 15:26:38 +0200 In-Reply-To: <87r1s0m4yr.fsf@gmx.net> (Stephen Berman's message of "Fri, 21 Aug 2020 16:46:52 +0200") Message-ID: <877dtqolpt.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > I don't know, but a first rough implementation of your suggestion seems > promising: with the patch below, when using either of the above values > of calendar-date-display-form, the date strings are [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > I don't know, but a first rough implementation of your suggestion seems > promising: with the patch below, when using either of the above values > of calendar-date-display-form, the date strings are fontified. A > complete fix should go through the code carefully, checking for possible > corner cases. Glenn Morris probably knows best if such an approach is > worth pursuing. [...] > - (insert (if (bobp) "" ?\n) (calendar-date-string date)) > + (insert (if (bobp) "" ?\n) > + (propertize (calendar-date-string date) 'face 'diary)) Makes sense to me. And we could then probably remove diary-fancy-date-pattern. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 22:18:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Aug 2020 18:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 13072@debbugs.gnu.org Received: via spool by 13072-submit@debbugs.gnu.org id=B13072.159837853212877 (code B ref 13072); Tue, 25 Aug 2020 18:03:01 +0000 Received: (at 13072) by debbugs.gnu.org; 25 Aug 2020 18:02:12 +0000 Received: from localhost ([127.0.0.1]:35970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAdGu-0003Ld-Eh for submit@debbugs.gnu.org; Tue, 25 Aug 2020 14:02:12 -0400 Received: from mout.gmx.net ([212.227.15.19]:40163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAdGt-0003LN-Hk for 13072@debbugs.gnu.org; Tue, 25 Aug 2020 14:02:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598378525; bh=0XGBxyXuw2ZoWI0W0KWY/vReF3guU4Aus51KATtTUck=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=hesHt5MqCn5xQdnx5z9zeZ0i0B0o4PA2RchY53FMAjfMz0N9tUdx+a4wlBhNYzVhM EmJYrwG91zHBsVhExnhlPCOrgxqoomU2rNKrZFW+bo7VmSoUzTjzTe9nbuUGhOEd5X tQi0VE9ncxhlCKzCvUPQTz/S46CK9ytI4cSc0Ivk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([188.109.196.40]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mo6v3-1kzfPS1v7j-00pZIQ; Tue, 25 Aug 2020 20:02:05 +0200 From: Stephen Berman References: <87k3sybs8k.fsf@rosalinde.fritz.box> <87v9hc5g8z.fsf@gnus.org> <87r1s0m4yr.fsf@gmx.net> <877dtqolpt.fsf@gnus.org> Date: Tue, 25 Aug 2020 20:02:04 +0200 In-Reply-To: <877dtqolpt.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 22 Aug 2020 15:26:38 +0200") Message-ID: <87a6yili3n.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:1OwZ6PbK1BPtTBGxEP6MTxLtkaygaAShmYmnWI0p16cCZf+ffxh as0Ma+kq5brgDJubTAhCK24oxNbncpFP4zkVhUp2O5VB0BbIXnThW+AZ6sQVukUYlIR9eTf /djufeZ0f9EGT9j6LMxnZfzMGU8eSBckIRim1l2ZPKhPt/72V3xsPD0M2C1BItMFTiyVB60 G0mwECAbbLubkX+JX/W3Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TaI1GFMe1GE=:AnahHxgxsZaQzv+qj3uMxH Eu2waCR4QHtnh765Bl4OApEzl+2IFJnJ+Z04flKm5NqDesaPuVtCHK2bfp5j3N/BTXUwIa+qD PEdh3YdBWOEJIHqAalOvbIdn4uvxey29OhbcDFPACrYBC9zfNnbXK7sZREBhvr895VUaiOjwe YOIor1ydCJl2MacGc2chldYPAvxT/gKQZzwbOzWCeSP91CKbkL0MKWjrafbfd1RrogZYwzbEU aGg1cEbX2Th7rhOja43U1hDqG31htuM5QBoN4plpjPD4FM2biKZ2H03h/bSB35Hx1uipjAa8B 7Yz9t9ek4Rxuy9Xv2f00gW6SfGFEkoNFMMqVgkjXMIiMcbxU2r8aDgcXlqWifJdnQA1q7TkCZ lovlpI6eRks58m4ISLIF2C+GSui+6upYoX6Ee3vixILEoA03foAIujCeb0Ffug+aw2hKzTYM7 BsUIgvfiXRjr/8eHRoHRDs+1FPCnQMcvi/FoyU9BKzSS1SkNDGxpfB0vkvnTmsJptoLeoUKzN KtTwQuOi72AHIZuteqLN1LXno0F9iwVwNETY+MAnVxbiipKjbInDCE1gvrE/EWhH70dFY9bbE mo/2xFV3PM5dLbWQrYHrFiXRa2BcIJCpTSghhEocfjFP4fXdGjwZoaXzaUD+skytnkVeGlwVW WEIXwv987ORBA/ABj71xhJzGmpotdAcrgOwwwnAuJ7Jvkd6bnqlDbBRG3t+HbAZ/mshd/d+LY eEFKeHEiJkOuekeKSWeqE6b3okc9qxMlUbMRpaEJj6a3BZ9oV3MJSYCRyvpAW9+QWNCbcst1H oR7Brl1ck0sV9yoC5hxORtKc3SyEodKCHHopV0leq41yoevoFJhTc5gO3qMZa+Qbu8BomVe/1 3h4RGJYqgqDz2OeNt9alnAUDmLl4xqHaFEpweO5/2GbHT/xccOiIB+QMHiThADORKNbPl/su1 ZzGquloETtsJ1e53Lqocu/oXd/jANRoqka/MC4xAMYi/Mqv0/lLmHNh9aVxeT/CYjdY/gvdAW cxQnUfoCIXY8FeXS62WVsreca/JoiMhl6he1MdMTC9jGcXYzYLteNryhagAWZfD8WSeWtWYRM GQae5iEPJMj9QAYFJulSc6HPYydxAyH12ylhzYriXnkIUb/iEzCNVipIUQ58jrTBWOIHuRIQ4 qOID1FhHxxVng0VQKwqxwOSdi2YCuuK3Vi99xlsVa7z+0D3Z2I1wZweDJ7/LCMc3nV5yCvTRx n/dZId9qouwYaIAVQOMBlqKsLucpT3RVrFLLovA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, 22 Aug 2020 15:26:38 +0200 Lars Ingebrigtsen wrote: > Stephen Berman writes: > >> I don't know, but a first rough implementation of your suggestion seems >> promising: with the patch below, when using either of the above values >> of calendar-date-display-form, the date strings are fontified. A >> complete fix should go through the code carefully, checking for possible >> corner cases. Glenn Morris probably knows best if such an approach is >> worth pursuing. > > [...] > >> - (insert (if (bobp) "" ?\n) (calendar-date-string date)) >> + (insert (if (bobp) "" ?\n) >> + (propertize (calendar-date-string date) 'face 'diary)) > > Makes sense to me. And we could then probably remove > diary-fancy-date-pattern. That sounds like a good simplification of the code, but I think Glenn should chime in before any such change is made. Steve Berman From unknown Fri Aug 15 22:18:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Aug 2020 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman Cc: 13072@debbugs.gnu.org, Glenn Morris Received: via spool by 13072-submit@debbugs.gnu.org id=B13072.15983821542425 (code B ref 13072); Tue, 25 Aug 2020 19:03:01 +0000 Received: (at 13072) by debbugs.gnu.org; 25 Aug 2020 19:02:34 +0000 Received: from localhost ([127.0.0.1]:36128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAeD5-0000RR-6E for submit@debbugs.gnu.org; Tue, 25 Aug 2020 15:02:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAeD3-0000Ls-0w for 13072@debbugs.gnu.org; Tue, 25 Aug 2020 15:02:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4VjYqiJO8+94MvT2D8pTaapFMwg7qLx5X8BzsBA9KRs=; b=D77C1G21iD0bKM7g7AbyRY9Klc PABogv8tJpQN2bc+CwhagUi6ZKCiQnzgBsry0PqsBEXKiKqXxXH4MFchE0hsiUY0yMnyByoyc/xsq /YnC4gj4aSAGsjDPfCsLTXSRGX7j4QxflKSvXZB5qD+ywb6uDZRPiMgT56FkwtX0bWHY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAeCt-0000q6-HY; Tue, 25 Aug 2020 21:02:10 +0200 From: Lars Ingebrigtsen References: <87k3sybs8k.fsf@rosalinde.fritz.box> <87v9hc5g8z.fsf@gnus.org> <87r1s0m4yr.fsf@gmx.net> <877dtqolpt.fsf@gnus.org> <87a6yili3n.fsf@gmx.net> X-Now-Playing: King Crimson's _On (and off) The Road (8): Are You Recording, Gary?_: "Three of a Perfect Pair Redux" Date: Tue, 25 Aug 2020 21:02:06 +0200 In-Reply-To: <87a6yili3n.fsf@gmx.net> (Stephen Berman's message of "Tue, 25 Aug 2020 20:02:04 +0200") Message-ID: <871rju5z2p.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > That sounds like a good simplification of the code, but I think Glenn > should chime in before any such change is made. Sure (but Glenn removed himself as the maintainer last year, in case you didn't know). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > That sounds like a good simplification of the code, but I think Glenn > should chime in before any such change is made. Sure (but Glenn removed himself as the maintainer last year, in case you didn't know). diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el index 1be2a05eee..369a93ca17 100644 --- a/lisp/calendar/diary-lib.el +++ b/lisp/calendar/diary-lib.el @@ -4,7 +4,7 @@ ;; Foundation, Inc. ;; Author: Edward M. Reingold -;; Maintainer: Glenn Morris +;; Maintainer: emacs-devel@gnu.org ;; Keywords: calendar ;; This file is part of GNU Emacs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 22:18:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Oct 2020 02:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman Cc: 13072@debbugs.gnu.org Received: via spool by 13072-submit@debbugs.gnu.org id=B13072.160255513120337 (code B ref 13072); Tue, 13 Oct 2020 02:13:02 +0000 Received: (at 13072) by debbugs.gnu.org; 13 Oct 2020 02:12:11 +0000 Received: from localhost ([127.0.0.1]:44602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS9nP-0005Hx-Ak for submit@debbugs.gnu.org; Mon, 12 Oct 2020 22:12:11 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS9nN-0005Hi-0c for 13072@debbugs.gnu.org; Mon, 12 Oct 2020 22:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z/HBVHxuTGKj0JfgQDm711ETRaGzt5MPSToQDKSuEM8=; b=QTBx7FBU5ADzbJdQUIHeoFaPnl 2wji8+F2klkhnx48/xw4+36/+eVcq4WoxendxjgKBCS8aSVk+yKMAoSYIvcm8zdfNoNYL2r4jf5S1 EbDFyaWPZiZt8zz50pPAnvE3Op4QUbICPW890g0cG5pXdyEiHGk7Gt1Dts8SEu9KewTo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kS9nE-0000oT-A9; Tue, 13 Oct 2020 04:12:02 +0200 From: Lars Ingebrigtsen References: <87k3sybs8k.fsf@rosalinde.fritz.box> <87v9hc5g8z.fsf@gnus.org> <87r1s0m4yr.fsf@gmx.net> <877dtqolpt.fsf@gnus.org> <87a6yili3n.fsf@gmx.net> X-Now-Playing: Matmos's _A Chance To Cut Is A Chance To Cure_: "California Rhinoplasty" Date: Tue, 13 Oct 2020 04:11:58 +0200 In-Reply-To: <87a6yili3n.fsf@gmx.net> (Stephen Berman's message of "Tue, 25 Aug 2020 20:02:04 +0200") Message-ID: <87d01m98nl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: >> Makes sense to me. And we could then probably remove >> diary-fancy-date-pattern. > > That sounds like a good simplification of the code, but I think Glenn > should chime in before any such change [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: >> Makes sense to me. And we could then probably remove >> diary-fancy-date-pattern. > > That sounds like a good simplification of the code, but I think Glenn > should chime in before any such change is made. I've now applied a somewhat reworked version of your patch to the trunk. I'm keeping the fancy font lock stuff, but just eliding the date header match. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 12 22:12:15 2020 Received: (at control) by debbugs.gnu.org; 13 Oct 2020 02:12:16 +0000 Received: from localhost ([127.0.0.1]:44605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS9nT-0005ID-H7 for submit@debbugs.gnu.org; Mon, 12 Oct 2020 22:12:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS9nR-0005Hp-WA for control@debbugs.gnu.org; Mon, 12 Oct 2020 22:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RrzJzJy5Q7hYMx7WFQ84NuKVKuginHlWEOotsu1M+pk=; b=RRLxTSJLyvGUEX/YxUdRe4vjqK ufgD41LMDpJtCCe7Vit6/ukPDa6UHeNN35Yw90TTy7p15bM2LecCkShGV59cW7+/Xv1PJ8+5AvV8v 8+oRHPdm87ANrjDQT96vfJqk+PPpYiMmAvIj8oqzlx8AjQq0K2iXqZ5RXul4/fgsg/G8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kS9nK-0000od-BV for control@debbugs.gnu.org; Tue, 13 Oct 2020 04:12:08 +0200 Date: Tue, 13 Oct 2020 04:12:05 +0200 Message-Id: <87blh698ne.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13072 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 13072 fixed close 13072 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 13072 fixed close 13072 28.1 quit