GNU bug report logs - #13064
24.4.50; Recent changes to ert.el broke "make check" on trunk

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chong Yidong <cyd <at> gnu.org>
Subject: bug#13064: closed (Re: bug#13064: 24.4.50; Recent changes to
 ert.el broke "make check" on trunk)
Date: Mon, 13 Jan 2014 10:59:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#13064: 24.4.50; Recent changes to ert.el broke "make check" on trunk

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 13064 <at> debbugs.gnu.org.

-- 
13064: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13064
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 13064-done <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#13064: 24.4.50;
 Recent changes to ert.el broke "make check" on trunk
Date: Mon, 13 Jan 2014 11:58:06 +0100

Chong Yidong <cyd <at> gnu.org> writes:

> Test ert-test-record-backtrace condition:
>     (ert-test-failed
>      ((should
>        (equal first-line "  signal(ert-test-failed (\"foo\"))"))
>       :form
>       (equal "  (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" "  signal(ert-test-failed (\"foo\"))")
>       :value nil :explanation
>       (arrays-of-different-length 61 33 "  (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" "  signal(ert-test-failed (\"foo\"))" first-mismatch-at 2)))

I've changed the string to be checked for. It is still the same for more
than a year, so I regard it as stable.

Best regards, Michael.

[Message part 3 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; Recent changes to ert.el broke "make check" on trunk
Date: Mon, 03 Dec 2012 13:36:28 +0800

`make check' fails on latest trunk due to this commit:

  revno: 110983
  committer: Stefan Monnier <monnier <at> iro.umontreal.ca>
  branch nick: trunk
  timestamp: Thu 2012-11-22 22:26:09 -0500
  message:
  * emacs-lisp/ert.el, emacs-lisp/ert-x.el: Use cl-lib and lexical-binding.

The error condition is:

1 unexpected results:
   FAILED  ert-test-record-backtrace

Test ert-test-record-backtrace condition:
    (ert-test-failed
     ((should
       (equal first-line "  signal(ert-test-failed (\"foo\"))"))
      :form
      (equal "  (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" "  signal(ert-test-failed (\"foo\"))")
      :value nil :explanation
      (arrays-of-different-length 61 33 "  (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" "  signal(ert-test-failed (\"foo\"))" first-mismatch-at 2)))


In GNU Emacs 24.3.50.7 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
 of 2012-12-02 on ulysses
Bzr revision: 111062 cyd <at> gnu.org-20121202062232-h7g8nwdfwszelw70
Windowing system distributor `The X.Org Foundation', version 11.0.11103000
System Description:	Ubuntu 12.04.1 LTS

Configured using:
 `configure '--with-x-toolkit=gtk3' 'CFLAGS=-g''

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.