From unknown Tue Aug 19 23:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13064: 24.4.50; Recent changes to ert.el broke "make check" on trunk Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Dec 2012 05:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13064 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13064@debbugs.gnu.org Cc: Stefan Monnier X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Received: via spool by submit@debbugs.gnu.org id=B.13545131425241 (code B ref -1); Mon, 03 Dec 2012 05:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Dec 2012 05:39:02 +0000 Received: from localhost ([127.0.0.1]:50697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfOk9-0001MU-VA for submit@debbugs.gnu.org; Mon, 03 Dec 2012 00:39:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38109) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfOk7-0001M4-GG for submit@debbugs.gnu.org; Mon, 03 Dec 2012 00:39:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfOhp-0001hB-Vv for submit@debbugs.gnu.org; Mon, 03 Dec 2012 00:36:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:45218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfOhp-0001h3-Sw for submit@debbugs.gnu.org; Mon, 03 Dec 2012 00:36:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfOho-0002CQ-U6 for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 00:36:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfOhn-0001gO-II for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 00:36:36 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:47623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfOhn-0001g7-C2 for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 00:36:35 -0500 Received: by mail-pb0-f41.google.com with SMTP id xa7so1658216pbc.0 for ; Sun, 02 Dec 2012 21:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; bh=+ShAzQ9jaQ2M9CwakpQcZJY0YZZ8ngFH5s8bqMBwPYI=; b=0TD3MzBi6G8FgzHAI+bCSnCAJzenkriHNw1XbnwuNkLTmh4tgXCvYF5NcjXLiDWBDP y1FoxiCtxKkTiIEvK1pTI8ih+cJ9WTkCyVZcx3smpNzrHKEAa97+Z/RmO9mpvQ6T7vA7 xqohCiCIqmR4fbOr4qTWS7yeGkfG7sBGQvgvrRD4b81BSQNJ1/WuVgLwaeWQT1FakQZo 9+cZu6Jvy/i2rYkVY8U+/qtRb7MFaC+rOchkxLXAeCrcI8C093fcIA4hljuS3E0VLVGr kFP9mQ86rCI86RyU73XNateqpl6QDa4rZ0xR5LujozP/H2VlvAouOStN8u1VCkrrNIk4 zCqw== Received: by 10.68.191.104 with SMTP id gx8mr26093957pbc.138.1354512994568; Sun, 02 Dec 2012 21:36:34 -0800 (PST) Received: from ulysses ([155.69.16.129]) by mx.google.com with ESMTPS id gu5sm7449432pbc.10.2012.12.02.21.36.31 (version=SSLv3 cipher=OTHER); Sun, 02 Dec 2012 21:36:33 -0800 (PST) From: Chong Yidong Date: Mon, 03 Dec 2012 13:36:28 +0800 Message-ID: <87hao3g0ir.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) `make check' fails on latest trunk due to this commit: revno: 110983 committer: Stefan Monnier branch nick: trunk timestamp: Thu 2012-11-22 22:26:09 -0500 message: * emacs-lisp/ert.el, emacs-lisp/ert-x.el: Use cl-lib and lexical-binding. The error condition is: 1 unexpected results: FAILED ert-test-record-backtrace Test ert-test-record-backtrace condition: (ert-test-failed ((should (equal first-line " signal(ert-test-failed (\"foo\"))")) :form (equal " (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" " signal(ert-test-failed (\"foo\"))") :value nil :explanation (arrays-of-different-length 61 33 " (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" " signal(ert-test-failed (\"foo\"))" first-mismatch-at 2))) In GNU Emacs 24.3.50.7 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2012-12-02 on ulysses Bzr revision: 111062 cyd@gnu.org-20121202062232-h7g8nwdfwszelw70 Windowing system distributor `The X.Org Foundation', version 11.0.11103000 System Description: Ubuntu 12.04.1 LTS Configured using: `configure '--with-x-toolkit=gtk3' 'CFLAGS=-g'' From unknown Tue Aug 19 23:13:08 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Chong Yidong Subject: bug#13064: closed (Re: bug#13064: 24.4.50; Recent changes to ert.el broke "make check" on trunk) Message-ID: References: <87r48cno75.fsf@gmx.de> <87hao3g0ir.fsf@gnu.org> X-Gnu-PR-Message: they-closed 13064 X-Gnu-PR-Package: emacs Reply-To: 13064@debbugs.gnu.org Date: Mon, 13 Jan 2014 10:59:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1389610743-21384-1" This is a multi-part message in MIME format... ------------=_1389610743-21384-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13064: 24.4.50; Recent changes to ert.el broke "make check" on trunk which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13064@debbugs.gnu.org. --=20 13064: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13064 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1389610743-21384-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13064-done) by debbugs.gnu.org; 13 Jan 2014 10:58:13 +0000 Received: from localhost ([127.0.0.1]:48438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2fDg-0005Xm-LD for submit@debbugs.gnu.org; Mon, 13 Jan 2014 05:58:13 -0500 Received: from mout.gmx.net ([212.227.15.15]:51907) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2fDf-0005Xb-0t for 13064-done@debbugs.gnu.org; Mon, 13 Jan 2014 05:58:11 -0500 Received: from detlef.gmx.de ([93.209.80.46]) by mail.gmx.com (mrgmx102) with ESMTPS (Nemesis) id 0LsOsW-1VMhcf1XYm-0122Yk for <13064-done@debbugs.gnu.org>; Mon, 13 Jan 2014 11:58:09 +0100 From: Michael Albinus To: Chong Yidong Subject: Re: bug#13064: 24.4.50; Recent changes to ert.el broke "make check" on trunk References: <87hao3g0ir.fsf@gnu.org> Date: Mon, 13 Jan 2014 11:58:06 +0100 In-Reply-To: <87hao3g0ir.fsf@gnu.org> (Chong Yidong's message of "Mon, 03 Dec 2012 13:36:28 +0800") Message-ID: <87r48cno75.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:Zk5Pt//dCRT0Oj6uWP/YhdQL3hieZJEkV6/xjfxtYJZ+QtHmegR ZpSh/vz7Hd7mMb6FNmNqYu164m5gWKzHjDdhwvJaexJ9tPAuoOYu5o5nqyKk5WYBHcWrsI8 1/CpUC/QOl1sXFrXysr7KF4CEOgYQGO6+oxP72sK+rhuTiME4YSSVTWOa0d5B/nErIoIElG K8anZD71AgMv+kxXbC62Q== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13064-done Cc: 13064-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Chong Yidong writes: > Test ert-test-record-backtrace condition: > (ert-test-failed > ((should > (equal first-line " signal(ert-test-failed (\"foo\"))")) > :form > (equal " (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" " signal(ert-test-failed (\"foo\"))") > :value nil :explanation > (arrays-of-different-length 61 33 " (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" " signal(ert-test-failed (\"foo\"))" first-mismatch-at 2))) I've changed the string to be checked for. It is still the same for more than a year, so I regard it as stable. Best regards, Michael. ------------=_1389610743-21384-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Dec 2012 05:39:02 +0000 Received: from localhost ([127.0.0.1]:50697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfOk9-0001MU-VA for submit@debbugs.gnu.org; Mon, 03 Dec 2012 00:39:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38109) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfOk7-0001M4-GG for submit@debbugs.gnu.org; Mon, 03 Dec 2012 00:39:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfOhp-0001hB-Vv for submit@debbugs.gnu.org; Mon, 03 Dec 2012 00:36:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:45218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfOhp-0001h3-Sw for submit@debbugs.gnu.org; Mon, 03 Dec 2012 00:36:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfOho-0002CQ-U6 for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 00:36:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfOhn-0001gO-II for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 00:36:36 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:47623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfOhn-0001g7-C2 for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 00:36:35 -0500 Received: by mail-pb0-f41.google.com with SMTP id xa7so1658216pbc.0 for ; Sun, 02 Dec 2012 21:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; bh=+ShAzQ9jaQ2M9CwakpQcZJY0YZZ8ngFH5s8bqMBwPYI=; b=0TD3MzBi6G8FgzHAI+bCSnCAJzenkriHNw1XbnwuNkLTmh4tgXCvYF5NcjXLiDWBDP y1FoxiCtxKkTiIEvK1pTI8ih+cJ9WTkCyVZcx3smpNzrHKEAa97+Z/RmO9mpvQ6T7vA7 xqohCiCIqmR4fbOr4qTWS7yeGkfG7sBGQvgvrRD4b81BSQNJ1/WuVgLwaeWQT1FakQZo 9+cZu6Jvy/i2rYkVY8U+/qtRb7MFaC+rOchkxLXAeCrcI8C093fcIA4hljuS3E0VLVGr kFP9mQ86rCI86RyU73XNateqpl6QDa4rZ0xR5LujozP/H2VlvAouOStN8u1VCkrrNIk4 zCqw== Received: by 10.68.191.104 with SMTP id gx8mr26093957pbc.138.1354512994568; Sun, 02 Dec 2012 21:36:34 -0800 (PST) Received: from ulysses ([155.69.16.129]) by mx.google.com with ESMTPS id gu5sm7449432pbc.10.2012.12.02.21.36.31 (version=SSLv3 cipher=OTHER); Sun, 02 Dec 2012 21:36:33 -0800 (PST) From: Chong Yidong To: bug-gnu-emacs@gnu.org Subject: 24.4.50; Recent changes to ert.el broke "make check" on trunk X-Debbugs-CC: Stefan Monnier Date: Mon, 03 Dec 2012 13:36:28 +0800 Message-ID: <87hao3g0ir.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) `make check' fails on latest trunk due to this commit: revno: 110983 committer: Stefan Monnier branch nick: trunk timestamp: Thu 2012-11-22 22:26:09 -0500 message: * emacs-lisp/ert.el, emacs-lisp/ert-x.el: Use cl-lib and lexical-binding. The error condition is: 1 unexpected results: FAILED ert-test-record-backtrace Test ert-test-record-backtrace condition: (ert-test-failed ((should (equal first-line " signal(ert-test-failed (\"foo\"))")) :form (equal " (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" " signal(ert-test-failed (\"foo\"))") :value nil :explanation (arrays-of-different-length 61 33 " (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()" " signal(ert-test-failed (\"foo\"))" first-mismatch-at 2))) In GNU Emacs 24.3.50.7 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2012-12-02 on ulysses Bzr revision: 111062 cyd@gnu.org-20121202062232-h7g8nwdfwszelw70 Windowing system distributor `The X.Org Foundation', version 11.0.11103000 System Description: Ubuntu 12.04.1 LTS Configured using: `configure '--with-x-toolkit=gtk3' 'CFLAGS=-g'' ------------=_1389610743-21384-1--