GNU bug report logs - #13027
Activating mark does not run mark activation hook

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13027: closed (Activating mark does not run mark activation hook)
Date: Thu, 29 Nov 2012 20:13:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 29 Nov 2012 15:10:05 -0500
with message-id <jwvobigxjaz.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#13027: Activating mark does not run mark activation hook
has caused the debbugs.gnu.org bug report #13027,
regarding Activating mark does not run mark activation hook
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13027: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13027
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Activating mark does not run mark activation hook
Date: Thu, 29 Nov 2012 02:08:19 -0800 (PST)

In 24.2, from emacs -Q
(add-hook 'deactivate-mark-hook (lambda () (message "Deactivate mark hook called.")))
(add-hook 'activate-mark-hook (lambda () (message "Activate mark hook called.")))
C-SPC C-SPC C-SPC C-SPC
In *Messages* you get:

Mark set
Activate mark hook called.
Deactivate mark hook called.
Mark deactivated
Mark activated
Deactivate mark hook called.
Mark deactivated

Notice that the second "Activate mark hook called" is missing.

simple.el has:
(defun activate-mark ()
  "Activate the mark."
  (when (mark t)
    (setq mark-active t)
    (unless transient-mark-mode
      (setq transient-mark-mode 'lambda))))

The bug is fixed by changing that to:
(defun activate-mark ()
  "Activate the mark."
  (when (mark t)
    (setq mark-active t)
    (run-hooks 'activate-mark-hook)
    (unless transient-mark-mode
      (setq transient-mark-mode 'lambda))))

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kelly Dean <kellydeanch <at> yahoo.com>
Cc: 13027-done <at> debbugs.gnu.org
Subject: Re: bug#13027: Activating mark does not run mark activation hook
Date: Thu, 29 Nov 2012 15:10:05 -0500

> The bug is fixed by changing that to:
> (defun activate-mark ()
>   "Activate the mark."
>   (when (mark t)
>     (setq mark-active t)
>     (run-hooks 'activate-mark-hook)
>     (unless transient-mark-mode
>       (setq transient-mark-mode 'lambda))))

Thank you, installed,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.