GNU bug report logs - #13017
24.2.90; minibuf-eldef-setup-minibuffer should append minibuf-eldef-update-minibuffer to post-command-hook

Previous Next

Package: emacs;

Reported by: Christopher Schmidt <christopher <at> ch.ristopher.com>

Date: Wed, 28 Nov 2012 00:13:02 UTC

Severity: minor

Tags: moreinfo, patch

Found in version 24.2.90

Done: Christopher Schmidt <ch <at> ristopher.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Christopher Schmidt <christopher <at> ch.ristopher.com>
Cc: 13017 <at> debbugs.gnu.org
Subject: bug#13017: 24.2.90; minibuf-eldef-setup-minibuffer should append minibuf-eldef-update-minibuffer to post-command-hook
Date: Wed, 05 Feb 2014 16:55:44 -0800

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> In minibuf-eldef-setup-minibuffer there is this form
>
>>     (add-hook 'post-command-hook #'minibuf-eldef-update-minibuffer nil t)
>
>> I think this is not correct.  The APPEND parameter of add-hook should be
>> t so all changes made to the minibuffer content by previous functions in
>> post-command-hook are taken into account by
>> minibuf-eldef-update-minibuffer.
>
> That sounds reasonable, but I'd be happier to know of a concrete example
> where this was needed.

Christopher, do you have an example that demonstrates why this is needed?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/
This bug report was last modified 11 years and 95 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.