From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 27 19:12:56 2012 Received: (at submit) by debbugs.gnu.org; 28 Nov 2012 00:12:56 +0000 Received: from localhost ([127.0.0.1]:42346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdVGp-000692-9t for submit@debbugs.gnu.org; Tue, 27 Nov 2012 19:12:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36789) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdVGm-00068v-Qc for submit@debbugs.gnu.org; Tue, 27 Nov 2012 19:12:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdVEy-0002Mv-JV for submit@debbugs.gnu.org; Tue, 27 Nov 2012 19:11:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdVEy-0002Mq-Ga for submit@debbugs.gnu.org; Tue, 27 Nov 2012 19:11:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdVEx-0005EO-IR for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 19:11:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdVEw-0002M7-Br for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 19:10:59 -0500 Received: from ristopher.com ([146.185.21.93]:60815 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdVEv-0002Kw-T1 for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 19:10:58 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 331C0214A7; Wed, 28 Nov 2012 00:10:54 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1354061454; bh=6dYGGqLTRctQ3VP/Dd1CV3FIevbXKNSoL3xafNycXKE=; h=From:To:Subject:Message-ID:MIME-Version:Content-Type:Date; b=Ne3f+TAIYAeN0Dq52ERc0MT5TsFyYZoxY2d0tJAjXDfWosc/jwsly0QlctzQw3vZn ffgLSrHICpTd1rNTrY7g440vAxw+nJorose22A6dTGCfaiQNLHBHusHdafVFoe7XcE Wz6fW3TS8B4uxffdbHjqzOq4S2Vxh1E1+18dvV7Y= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: 24.2.90; minibuf-eldef-setup-minibuffer should append minibuf-eldef-update-minibuffer to post-command-hook Message-ID: <87obii60zj@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Wed, 28 Nov 2012 00:10:54 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain In minibuf-eldef-setup-minibuffer there is this form (add-hook 'post-command-hook #'minibuf-eldef-update-minibuffer nil t) I think this is not correct. The APPEND parameter of add-hook should be t so all changes made to the minibuffer content by previous functions in post-command-hook are taken into account by minibuf-eldef-update-minibuffer. Here is a patch for the trunk. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=minibuf-eldef.diff === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2012-11-27 16:40:04 +0000 +++ lisp/ChangeLog 2012-11-28 00:07:24 +0000 @@ -1,3 +1,8 @@ +2012-11-28 Christopher Schmidt + + * minibuf-eldef.el (minibuf-eldef-setup-minibuffer): Append + minibuf-eldef-update-minibuffer to post-command-hook. (Bug#) + 2012-11-27 Glenn Morris * emacs-lisp/derived.el (derived-mode-make-docstring): === modified file 'lisp/minibuf-eldef.el' --- lisp/minibuf-eldef.el 2012-11-07 20:43:38 +0000 +++ lisp/minibuf-eldef.el 2012-11-28 00:05:45 +0000 @@ -140,7 +140,7 @@ (minibuffer-contents-no-properties)) (setq minibuf-eldef-initial-buffer-length (point-max)) (add-to-list 'minibuf-eldef-frobbed-minibufs (current-buffer)) - (add-hook 'post-command-hook #'minibuf-eldef-update-minibuffer nil t)))) + (add-hook 'post-command-hook #'minibuf-eldef-update-minibuffer t t)))) ;; post-command-hook to swap prompts when necessary (defun minibuf-eldef-update-minibuffer () --=-=-= Content-Type: text/plain Christopher --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 27 20:44:35 2012 Received: (at submit) by debbugs.gnu.org; 28 Nov 2012 01:44:35 +0000 Received: from localhost ([127.0.0.1]:42357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdWhW-0008IM-K1 for submit@debbugs.gnu.org; Tue, 27 Nov 2012 20:44:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53812) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdWhT-0008IE-Se for submit@debbugs.gnu.org; Tue, 27 Nov 2012 20:44:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdWff-0000HP-BI for submit@debbugs.gnu.org; Tue, 27 Nov 2012 20:42:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:37449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdWff-0000HL-7j for submit@debbugs.gnu.org; Tue, 27 Nov 2012 20:42:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdWfe-0007Dq-Ei for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 20:42:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdWfd-0000GJ-Ku for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 20:42:38 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:40652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdWfd-0000GF-Gv for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 20:42:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxKh9/2dsb2JhbABEsEiDSYEIghUBAQQBVigLCy0HBwsUGA2IQAW6CY0aDIMeA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="208634293" Received: from 69-196-168-125.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.125]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Nov 2012 20:42:36 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6644452110; Tue, 27 Nov 2012 20:42:35 -0500 (EST) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: Re: bug#13017: 24.2.90; minibuf-eldef-setup-minibuffer should append minibuf-eldef-update-minibuffer to post-command-hook Message-ID: References: <87obii60zj@ch.ristopher.com> Date: Tue, 27 Nov 2012 20:42:35 -0500 In-Reply-To: <87obii60zj@ch.ristopher.com> (Christopher Schmidt's message of "Wed, 28 Nov 2012 00:10:54 +0000 (GMT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > In minibuf-eldef-setup-minibuffer there is this form > (add-hook 'post-command-hook #'minibuf-eldef-update-minibuffer nil t) > I think this is not correct. The APPEND parameter of add-hook should be > t so all changes made to the minibuffer content by previous functions in > post-command-hook are taken into account by > minibuf-eldef-update-minibuffer. That sounds reasonable, but I'd be happier to know of a concrete example where this was needed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 19:55:46 2014 Received: (at control) by debbugs.gnu.org; 6 Feb 2014 00:55:46 +0000 Received: from localhost ([127.0.0.1]:51618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDFq-00079p-5S for submit@debbugs.gnu.org; Wed, 05 Feb 2014 19:55:46 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:55378) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDFm-00079f-0T for control@debbugs.gnu.org; Wed, 05 Feb 2014 19:55:43 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WBDFY-0007zv-7G for control@debbugs.gnu.org; Thu, 06 Feb 2014 01:55:28 +0100 Date: Wed, 05 Feb 2014 16:54:25 -0800 Message-Id: <87txcdxdq6.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13017 X-MailScanner-ID: 1WBDFY-0007zv-7G X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392252928.854@WdUPy6RXeaRCVcq26oRFLQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 13017 patch From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 19:57:10 2014 Received: (at 13017) by debbugs.gnu.org; 6 Feb 2014 00:57:10 +0000 Received: from localhost ([127.0.0.1]:51624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDHB-0007Cn-Or for submit@debbugs.gnu.org; Wed, 05 Feb 2014 19:57:10 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:55396) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDH9-0007Cd-R2 for 13017@debbugs.gnu.org; Wed, 05 Feb 2014 19:57:08 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WBDGp-00080y-00; Thu, 06 Feb 2014 01:56:47 +0100 From: Lars Ingebrigtsen To: Christopher Schmidt Subject: Re: bug#13017: 24.2.90; minibuf-eldef-setup-minibuffer should append minibuf-eldef-update-minibuffer to post-command-hook References: <87obii60zj@ch.ristopher.com> Date: Wed, 05 Feb 2014 16:55:44 -0800 In-Reply-To: (Stefan Monnier's message of "Tue, 27 Nov 2012 20:42:35 -0500") Message-ID: <87ppn1xdnz.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WBDGp-00080y-00 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392253007.44352@KstUh4Zvsy2oeDYBSEsASQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13017 Cc: 13017@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >> In minibuf-eldef-setup-minibuffer there is this form > >> (add-hook 'post-command-hook #'minibuf-eldef-update-minibuffer nil t) > >> I think this is not correct. The APPEND parameter of add-hook should be >> t so all changes made to the minibuffer content by previous functions in >> post-command-hook are taken into account by >> minibuf-eldef-update-minibuffer. > > That sounds reasonable, but I'd be happier to know of a concrete example > where this was needed. Christopher, do you have an example that demonstrates why this is needed? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 17 17:25:48 2014 Received: (at 13017-done) by debbugs.gnu.org; 17 Apr 2014 21:25:48 +0000 Received: from localhost ([127.0.0.1]:51173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WatoV-0002HR-8L for submit@debbugs.gnu.org; Thu, 17 Apr 2014 17:25:47 -0400 Received: from ristopher.com ([81.4.108.209]:56915) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WaTFY-0000ND-V4 for 13017-done@debbugs.gnu.org; Wed, 16 Apr 2014 13:03:58 -0400 Received: by ristopher.com (Postfix, from userid 0) id 1BAC0228D6; Wed, 16 Apr 2014 13:03:50 -0400 (EDT) From: Christopher Schmidt To: 13017-done@debbugs.gnu.org Subject: Re: bug#13017: 24.2.90; minibuf-eldef-setup-minibuffer should append minibuf-eldef-update-minibuffer to post-command-hook In-Reply-To: <87ppn1xdnz.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Wed, 05 Feb 2014 16:55:44 -0800") Message-ID: <874n1t8avr@ristopher.com> References: <87obii60zj@ch.ristopher.com> <87ppn1xdnz.fsf@building.gnus.org> MIME-Version: 1.0 Content-Type: text/plain Date: Wed, 16 Apr 2014 13:03:49 -0400 (EDT) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13017-done X-Mailman-Approved-At: Thu, 17 Apr 2014 17:25:37 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Tags: notabug Lars Ingebrigtsen writes: > Christopher, do you have an example that demonstrates why this is > needed? IIRC, I played around with another prompt-simplifying form in post-command-hook. I do not have the source code any more. It is easy to come up with an artificial sample which demonstrates this issue. Yet, even if minibuf-eldef-update-minibuffer is appended to post-command-hook, does this change actually improve the situation? I do not think so. It is not hard to come up with another sample which requires the initial behaviour. This issue is probably not a bug and does not matter to me any more. Closing... From unknown Sat Aug 16 18:47:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 16 May 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator