GNU bug report logs - #13002
directory variables in VALAFLAGS are expanded after cd

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Daiki Ueno <ueno <at> unixuser.org>
Subject: bug#13002: closed (Re: bug#13002: Updated, fixed patch)
Date: Sun, 08 Nov 2020 02:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#13002: directory variables in VALAFLAGS are expanded after cd

which was filed against the automake package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 13002 <at> debbugs.gnu.org.

-- 
13002: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13002
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Karl Berry <karl <at> freefriends.org>
To: rrt <at> sc3d.org
Cc: 13002 <at> debbugs.gnu.org
Subject: Re: bug#13002: Updated, fixed patch
Date: Sat, 7 Nov 2020 19:45:20 -0700

    I have taken Daniel Espinosa's patch and improved it so that it
    fixes all the test failures.

Reuben, thank you very much for dealing with everything, and thanks to
Daniel for the original work.

make check && make distcheck are working for me now.
I have pushed the changes (with fingers crossed)
and am closing this bug. -k

[Message part 3 (message/rfc822, inline)]

From: Daiki Ueno <ueno <at> unixuser.org>
To: bug-automake <at> gnu.org
Subject: directory variables in VALAFLAGS are expanded after cd
Date: Mon, 26 Nov 2012 20:03:38 +0900

Hi,

I see quite a few Vala projects setting VALAFLAGS as follows:

libfolks_eds_la_VALAFLAGS = \
        --vapidir=. \
        --vapidir=$(top_srcdir)/folks \
        ...

This is referred by the generated rule in Makefile.in as:

$(AM_V_VALAC)$(am__cd) $(srcdir) && $(VALAC) $(libfolks_eds_la_VALAFLAGS) $(VALAFLAGS) -C $(libfolks_eds_la_SOURCES)

Here, if $(srcdir) != $(builddir) and $(top_srcdir) is a relative path
from $(builddir), the --vapidir option will point to a wrong location.

Though this could be worked around by using $(abs_top_srcdir) instead of
$(top_srcdir), it looks to me a bit unintuitive.  It would be nice that
automake handles this case nicely.

Regards,
-- 
Daiki Ueno

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.