GNU bug report logs - #13000
24.2.90; underwave doesn't look as good as other IDEs

Previous Next

Full log

View this message in rfc822 format

From: Leo <sdl.web <at> gmail.com>
To: 13000 <at> debbugs.gnu.org
Cc: Chong Yidong <cyd <at> stupidchicken.com>, aurelien.aptel <at> gmail.com
Subject: bug#13000: 24.2.90; underwave doesn't look as good as other IDEs
Date: Thu, 27 Dec 2012 16:33:19 +0800

The following patch by YAMAMOTO Mitsuharu brings the code to be in line
with the comment. I tested it with an X11 build and the wave looked
better.


=== modified file 'src/xterm.c'
*** src/xterm.c 2012-12-12 15:33:30 +0000
--- src/xterm.c 2012-12-27 01:20:52 +0000
***************
*** 2633,2646 ****
  static void
  x_draw_underwave (struct glyph_string *s)
  {
!   int wave_height = 2, wave_length = 3;
    int dx, dy, x0, y0, width, x1, y1, x2, y2, odd, xmax;
    XRectangle wave_clip, string_clip, final_clip;

    dx = wave_length;
    dy = wave_height - 1;
    x0 = s->x;
!   y0 = s->ybase + 1;
    width = s->width;
    xmax = x0 + width;

--- 2633,2646 ----
  static void
  x_draw_underwave (struct glyph_string *s)
  {
!   int wave_height = 3, wave_length = 2;
    int dx, dy, x0, y0, width, x1, y1, x2, y2, odd, xmax;
    XRectangle wave_clip, string_clip, final_clip;

    dx = wave_length;
    dy = wave_height - 1;
    x0 = s->x;
!   y0 = s->ybase - wave_height + 3;
    width = s->width;
    xmax = x0 + width;

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.