From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 25 09:51:45 2012 Received: (at submit) by debbugs.gnu.org; 25 Nov 2012 14:51:45 +0000 Received: from localhost ([127.0.0.1]:37676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TcdYd-0000bT-Ud for submit@debbugs.gnu.org; Sun, 25 Nov 2012 09:51:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39733) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TcdYZ-0000bJ-9J for submit@debbugs.gnu.org; Sun, 25 Nov 2012 09:51:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TcdWy-0006OV-LG for submit@debbugs.gnu.org; Sun, 25 Nov 2012 09:50:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:59434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TcdWy-0006OR-Hv for submit@debbugs.gnu.org; Sun, 25 Nov 2012 09:50:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TcdWx-0006O9-Pv for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2012 09:50:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TcdWx-0006OA-0X for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2012 09:49:59 -0500 Received: from smtp207.alice.it ([82.57.200.103]:52039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TcdWw-0006O3-Pz for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2012 09:49:58 -0500 Received: from [192.168.1.101] (79.9.171.118) by smtp207.alice.it (8.6.058.01) id 5091339C03A32F58 for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2012 15:49:54 +0100 Message-ID: <50B2300C.3090100@alice.it> Date: Sun, 25 Nov 2012 15:49:48 +0100 From: Angelo Graziosi User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: bug-emacs Subject: Wrong icon for Cygw32-Emacs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) I notice that the Cygw32 port does not show the standard Emacs icon on the upper-left corner (and elsewhere, I think). Would it be possible to have that? The Windows port has... Ciao, Angelo. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 02:14:15 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 07:14:15 +0000 Received: from localhost ([127.0.0.1]:34787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThxZ9-00026p-7U for submit@debbugs.gnu.org; Mon, 10 Dec 2012 02:14:15 -0500 Received: from dancol.org ([96.126.100.184]:40111) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThxZ7-00026i-OU for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 02:14:14 -0500 Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1ThxYX-00080s-BY; Sun, 09 Dec 2012 23:13:37 -0800 Message-ID: <50C58B9F.8050105@dancol.org> Date: Sun, 09 Dec 2012 23:13:35 -0800 From: Daniel Colascione User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Angelo Graziosi Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> In-Reply-To: <50B2300C.3090100@alice.it> X-Enigmail-Version: 1.4.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig37136015B5A593DE5C2DA238" X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig37136015B5A593DE5C2DA238 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/25/12 6:49 AM, Angelo Graziosi wrote: > I notice that the Cygw32 port does not show the standard Emacs icon on > the upper-left corner (and elsewhere, I think). >=20 > Would it be possible to have that? The Windows port has... I've pushed a change to the emacs-24 branch that should resolve the problem. We weren't compiling Windows resources into the cygw32 Emacs binary. --------------enig37136015B5A593DE5C2DA238 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlDFi58ACgkQ17c2LVA10Vv02QCdFu3hfKnjuOf67/sTAYa7oVMT 0QQAoKh1nCWQNReAnhbPmptV4xNLbrqD =fi30 -----END PGP SIGNATURE----- --------------enig37136015B5A593DE5C2DA238-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 08:41:10 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 13:41:10 +0000 Received: from localhost ([127.0.0.1]:35046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti3bZ-00035d-UD for submit@debbugs.gnu.org; Mon, 10 Dec 2012 08:41:10 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:51772) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti3bV-00035S-ET for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 08:41:07 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MET00300HYHNC00@a-mtaout21.012.net.il> for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 15:40:27 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MET00372HZF8L70@a-mtaout21.012.net.il>; Mon, 10 Dec 2012 15:40:27 +0200 (IST) Date: Mon, 10 Dec 2012 15:40:18 +0200 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <50C58B9F.8050105@dancol.org> X-012-Sender: halo1@inter.net.il To: Daniel Colascione Message-id: <83lid6auv1.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Sun, 09 Dec 2012 23:13:35 -0800 > From: Daniel Colascione > Cc: 12993@debbugs.gnu.org > > On 11/25/12 6:49 AM, Angelo Graziosi wrote: > > I notice that the Cygw32 port does not show the standard Emacs icon on > > the upper-left corner (and elsewhere, I think). > > > > Would it be possible to have that? The Windows port has... > > I've pushed a change to the emacs-24 branch that should resolve the > problem. We weren't compiling Windows resources into the cygw32 Emacs > binary. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.169 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4981] X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > Date: Sun, 09 Dec 2012 23:13:35 -0800 > From: Daniel Colascione > Cc: 12993@debbugs.gnu.org > > On 11/25/12 6:49 AM, Angelo Graziosi wrote: > > I notice that the Cygw32 port does not show the standard Emacs icon on > > the upper-left corner (and elsewhere, I think). > > > > Would it be possible to have that? The Windows port has... > > I've pushed a change to the emacs-24 branch that should resolve the > problem. We weren't compiling Windows resources into the cygw32 Emacs > binary. Why are such changes committed to the release branch? This is a minor feature, certainly not a bugfix, while the changes are definitely non-trivial. Please don't do that without discussion. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 09:08:52 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 14:08:52 +0000 Received: from localhost ([127.0.0.1]:35058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti42N-0003gc-SK for submit@debbugs.gnu.org; Mon, 10 Dec 2012 09:08:52 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:56381) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti42L-0003gT-P4 for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 09:08:51 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MET00700J5REN00@a-mtaout20.012.net.il> for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 16:08:12 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MET007N3J9O7X20@a-mtaout20.012.net.il>; Mon, 10 Dec 2012 16:08:12 +0200 (IST) Date: Mon, 10 Dec 2012 16:08:03 +0200 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <83lid6auv1.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: dancol@dancol.org Message-id: <83k3sqatks.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Mon, 10 Dec 2012 15:40:18 +0200 > From: Eli Zaretskii > Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it > > > I've pushed a change to the emacs-24 branch that should resolve the > > problem. We weren't compiling Windows resources into the cygw32 Emacs > > binary. > > Why are such changes committed to the release branch? This is a minor > feature, certainly not a bugfix, while the changes are definitely > non-trivial. Please don't do that without discussion. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.166 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4947] X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > Date: Mon, 10 Dec 2012 15:40:18 +0200 > From: Eli Zaretskii > Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it > > > I've pushed a change to the emacs-24 branch that should resolve the > > problem. We weren't compiling Windows resources into the cygw32 Emacs > > binary. > > Why are such changes committed to the release branch? This is a minor > feature, certainly not a bugfix, while the changes are definitely > non-trivial. Please don't do that without discussion. The more I look at the changes, the less I like them. E.g., how do we know that the various Windows utilities that access the resources will DTRT with forward slashes? Any references on the subject? And what is this hunk about: === modified file 'src/unexw32.c' --- a/src/unexw32.c 2012-10-17 19:02:44 +0000 +++ b/src/unexw32.c 2012-12-10 07:11:21 +0000 @@ -85,13 +85,6 @@ PIMAGE_SECTION_HEADER heap_section; -#ifdef HAVE_NTGUI -extern HINSTANCE hinst; -HINSTANCE hprevinst = NULL; -LPSTR lpCmdLine = ""; -int nCmdShow = 0; -#endif /* HAVE_NTGUI */ - /* Startup code for running on NT. When we are running as the dumped version, we need to bootstrap our heap and .bss section into our address space before we can actually hand off control to the startup @@ -121,15 +114,6 @@ /* Prevent Emacs from being locked up (eg. in batch mode) when accessing devices that aren't mounted (eg. removable media drives). */ SetErrorMode (SEM_FAILCRITICALERRORS); - - /* Invoke the NT CRT startup routine now that our housecleaning - is finished. */ -#ifdef HAVE_NTGUI - /* determine WinMain args like crt0.c does */ - hinst = GetModuleHandle (NULL); - lpCmdLine = GetCommandLine (); - nCmdShow = SW_SHOWDEFAULT; -#endif mainCRTStartup (); } What do you know about lpCmdLine and nCmdShow, and "what crt0.c does" with them, to be sure they can be removed? And this hunk breaks the MS-DOS build: -temacs$(EXEEXT): $(START_FILES) stamp-oldxmenu $(obj) $(otherobj) $(lib)/libgnu.a +temacs$(EXEEXT): $(START_FILES) stamp-oldxmenu $(obj) $(otherobj) \ + $(lib)/libgnu.a $(W32_RES) $(CC) $(LD_FIRSTFLAG) $(ALL_CFLAGS) $(TEMACS_LDFLAGS) $(TEMACS_LDFLAGS2) \ - -o temacs $(START_FILES) $(obj) $(otherobj) $(lib)/libgnu.a $(LIBES) + -o temacs $(START_FILES) $(obj) $(otherobj) $(lib)/libgnu.a $(LIBES) \ + $(W32_RES_LINK) test "$(CANNOT_DUMP)" = "yes" || \ test "X$(PAXCTL)" = X || $(PAXCTL) -r temacs$(EXEEXT) (because W32_RES will be expanded to @W32_RES@ and W32_RES_LINK to @W32_RES_LINK@, and GCC will barf). Any reasons why not revert this changeset and apply it to the trunk instead? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 11:04:05 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 16:04:06 +0000 Received: from localhost ([127.0.0.1]:35747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti5pt-0007H6-HF for submit@debbugs.gnu.org; Mon, 10 Dec 2012 11:04:05 -0500 Received: from dancol.org ([96.126.100.184]:41469) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti5pr-0007Gu-Es for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 11:04:04 -0500 Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1Ti5pE-0000qz-LN; Mon, 10 Dec 2012 08:03:24 -0800 Message-ID: <50C607C8.3050003@dancol.org> Date: Mon, 10 Dec 2012 08:03:20 -0800 From: Daniel Colascione User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> In-Reply-To: <83lid6auv1.fsf@gnu.org> X-Enigmail-Version: 1.4.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5BCC729DAB544DCAEF0DA2A7" X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5BCC729DAB544DCAEF0DA2A7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/10/12 5:40 AM, Eli Zaretskii wrote:>> Date: Sun, 09 Dec 2012 23:13:35 -0800 >> From: Daniel Colascione >> Cc: 12993@debbugs.gnu.org >> >> On 11/25/12 6:49 AM, Angelo Graziosi wrote: >>> I notice that the Cygw32 port does not show the standard Emacs icon o= n >>> the upper-left corner (and elsewhere, I think). >>> >>> Would it be possible to have that? The Windows port has... >> >> I've pushed a change to the emacs-24 branch that should resolve the >> problem. We weren't compiling Windows resources into the cygw32 Emacs >> binary. > > Why are such changes committed to the release branch? This is a minor > feature, certainly not a bugfix, while the changes are definitely > non-trivial. Please don't do that without discussion. > It's a minor bugfix, not a feature. I was under the impression that the release branch was _for_ minor bugfixes. Enough people have complained about the icon missing from the cygw32 build that I thought it would be worthwhile to fix it before release. --------------enig5BCC729DAB544DCAEF0DA2A7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlDGB8kACgkQ17c2LVA10VujrwCeIuaW8/UYdT6FrdG5fmLvgtUE 7FIAn3pze8LZ6CeTefMFa27qoL/a5ZjZ =g8qi -----END PGP SIGNATURE----- --------------enig5BCC729DAB544DCAEF0DA2A7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 11:25:14 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 16:25:14 +0000 Received: from localhost ([127.0.0.1]:35757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti6AL-0007k3-Lj for submit@debbugs.gnu.org; Mon, 10 Dec 2012 11:25:14 -0500 Received: from dancol.org ([96.126.100.184]:41509) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti6AI-0007ju-M8 for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 11:25:12 -0500 Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1Ti69h-0000sp-NM; Mon, 10 Dec 2012 08:24:33 -0800 Message-ID: <50C60CBE.1070905@dancol.org> Date: Mon, 10 Dec 2012 08:24:30 -0800 From: Daniel Colascione User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <83k3sqatks.fsf@gnu.org> In-Reply-To: <83k3sqatks.fsf@gnu.org> X-Enigmail-Version: 1.4.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2C5694B2093E59AE5CB60845" X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2C5694B2093E59AE5CB60845 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/10/12 6:08 AM, Eli Zaretskii wrote: >> Date: Mon, 10 Dec 2012 15:40:18 +0200 >> From: Eli Zaretskii >> Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it >> >>> I've pushed a change to the emacs-24 branch that should resolve the >>> problem. We weren't compiling Windows resources into the cygw32 Emacs= >>> binary. >> >> Why are such changes committed to the release branch? This is a minor= >> feature, certainly not a bugfix It looks more like a bugfix to me. Setting the window icon is something we should have always done, and that we didn't do so is problem the cygw32 build had versus the nt build, with which it should have feature parity. It's wrong and generated user complaints. That sounds like a bug to me. I'd also mentioned on the mailing list before that I intended to fix this problem before release. > The more I look at the changes, the less I like them. E.g., how do we > know that the various Windows utilities that access the resources will > DTRT with forward slashes? Any references on the subject? The resources stored in the binary don't contain paths. (I checked with a hex editor to make sure.) > And what is this hunk about: >=20 > =3D=3D=3D modified file 'src/unexw32.c' > --- a/src/unexw32.c 2012-10-17 19:02:44 +0000 > +++ b/src/unexw32.c 2012-12-10 07:11:21 +0000 > @@ -85,13 +85,6 @@ >=20 > PIMAGE_SECTION_HEADER heap_section; >=20 > -#ifdef HAVE_NTGUI > -extern HINSTANCE hinst; > -HINSTANCE hprevinst =3D NULL; > -LPSTR lpCmdLine =3D ""; > -int nCmdShow =3D 0; > -#endif /* HAVE_NTGUI */ > - > /* Startup code for running on NT. When we are running as the dum= ped > version, we need to bootstrap our heap and .bss section into our > address space before we can actually hand off control to the startup > @@ -121,15 +114,6 @@ > /* Prevent Emacs from being locked up (eg. in batch mode) when > accessing devices that aren't mounted (eg. removable media drives). = */ > SetErrorMode (SEM_FAILCRITICALERRORS); > - > - /* Invoke the NT CRT startup routine now that our housecleaning > - is finished. */ > -#ifdef HAVE_NTGUI > - /* determine WinMain args like crt0.c does */ > - hinst =3D GetModuleHandle (NULL); > - lpCmdLine =3D GetCommandLine (); > - nCmdShow =3D SW_SHOWDEFAULT; > -#endif > mainCRTStartup (); > } >=20 > What do you know about lpCmdLine and nCmdShow, and "what crt0.c does" > with them, to be sure they can be removed? I removed dead code. Those variables are never used; the C runtime (to which we dynamically link anyway) handles this initialization internally. (We appear to have a separate bug with respect to nCmdShow: create a shortcut to runemacs.exe and set it to start minimized or start maximized. Emacs starts with a normal window.) The setting of hinst specifically now happens in cache_system_info, so we don't need to do it in _start, which doesn't run for Cygwin builds. I tested the change, and it didn't cause any functional regressions related to command-line parsing. > And this hunk breaks the MS-DOS build: *sigh* The MS-DOS build breaks when the wind blows the wrong way. Does the build work inside DOSBox? I'll have to start testing the build in that environment before pushing. > Any reasons why not revert this changeset and apply it to the trunk > instead? The missing icon annoys users. Do we really want to ship that way? --------------enig2C5694B2093E59AE5CB60845 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlDGDL4ACgkQ17c2LVA10VtWJACfVybIj9yfH9fTy++xxlGU7YlT GcoAoJSrB+FlT5xtcv4Tz3LeNubOiGOH =RqY8 -----END PGP SIGNATURE----- --------------enig2C5694B2093E59AE5CB60845-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 11:36:08 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 16:36:08 +0000 Received: from localhost ([127.0.0.1]:35761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti6Kt-0007ze-S3 for submit@debbugs.gnu.org; Mon, 10 Dec 2012 11:36:08 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:61392) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti6Kr-0007zV-OJ for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 11:36:07 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MET00D00PVC2C00@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 18:34:29 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MET00CB7Q1H6KH0@a-mtaout22.012.net.il>; Mon, 10 Dec 2012 18:34:29 +0200 (IST) Date: Mon, 10 Dec 2012 18:34:21 +0200 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <50C607C8.3050003@dancol.org> X-012-Sender: halo1@inter.net.il To: Daniel Colascione Message-id: <8338zdc1de.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <50C607C8.3050003@dancol.org> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Mon, 10 Dec 2012 08:03:20 -0800 > From: Daniel Colascione > CC: angelo.graziosi@alice.it, 12993@debbugs.gnu.org > > > Why are such changes committed to the release branch? This is a minor > > feature, certainly not a bugfix, while the changes are definitely > > non-trivial. Please don't do that without discussion. > > > > It's a minor bugfix, not a feature. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4997] X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Mon, 10 Dec 2012 08:03:20 -0800 > From: Daniel Colascione > CC: angelo.graziosi@alice.it, 12993@debbugs.gnu.org > > > Why are such changes committed to the release branch? This is a minor > > feature, certainly not a bugfix, while the changes are definitely > > non-trivial. Please don't do that without discussion. > > > > It's a minor bugfix, not a feature. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4036] > Date: Mon, 10 Dec 2012 08:03:20 -0800 > From: Daniel Colascione > CC: angelo.graziosi@alice.it, 12993@debbugs.gnu.org > > > Why are such changes committed to the release branch? This is a minor > > feature, certainly not a bugfix, while the changes are definitely > > non-trivial. Please don't do that without discussion. > > > > It's a minor bugfix, not a feature. I guess we disagree about the definitions of these. Me, I don't see how not seeing a smalll icon in a build that was never supported by Emacs until now can be a bug. > I was under the impression that the release branch was _for_ minor > bugfixes. Enough people have complained about the icon missing from > the cygw32 build that I thought it would be worthwhile to fix it > before release. If it were a simple fix, perhaps. But it isn't, and it touches 2 other builds, that don't have this problem, in non-trivial ways. If you insist on having this in 24.3, then please at least make it Cygwin-only. For the source changes, this is easy -- use #ifdef. For emacs.rc, I hope you can do the same. If not, I'd go as far as providing a separate cygw32.rc file. The MSDOS problems are on me -- you will owe me ;-) OK? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 12:31:41 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 17:31:41 +0000 Received: from localhost ([127.0.0.1]:35843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti7Cf-0000qv-HI for submit@debbugs.gnu.org; Mon, 10 Dec 2012 12:31:41 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:50129) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti7Cd-0000qo-N7 for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 12:31:40 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id qBAHV4dX013828; Mon, 10 Dec 2012 12:31:04 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 09631B415D; Mon, 10 Dec 2012 12:30:59 -0500 (EST) From: Stefan Monnier To: Daniel Colascione Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs Message-ID: References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <50C607C8.3050003@dancol.org> Date: Mon, 10 Dec 2012 12:30:59 -0500 In-Reply-To: <50C607C8.3050003@dancol.org> (Daniel Colascione's message of "Mon, 10 Dec 2012 08:03:20 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4428=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4428> : streams <873207> : uri <1290285> X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, Eli Zaretskii , angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.2 (--) > It's a minor bugfix, not a feature. I was under the impression that > the release branch was _for_ minor bugfixes. Enough people have > complained about the icon missing from the cygw32 build that I thought > it would be worthwhile to fix it before release. The branch is in "regression only" state, i.e. only regressions w.r.t Emacs>=23 should make it there (except for trivially safe bug-fixes, and exceptions granted on a case-by-case basis). Please move your patch from the branch to the trunk, since it doesn't fix such a regression, is not super important (yes, it's definitely nicer to have an icon, but people can live without one until 24.4), and its safety is not obvious. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 12:59:00 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 17:59:00 +0000 Received: from localhost ([127.0.0.1]:35852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti7d5-0001Tp-PN for submit@debbugs.gnu.org; Mon, 10 Dec 2012 12:59:00 -0500 Received: from dancol.org ([96.126.100.184]:41740) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti7d3-0001Tg-7f for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 12:58:58 -0500 Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1Ti7cQ-000119-W1; Mon, 10 Dec 2012 09:58:19 -0800 Message-ID: <50C622B7.9070103@dancol.org> Date: Mon, 10 Dec 2012 09:58:15 -0800 From: Daniel Colascione User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <50C607C8.3050003@dancol.org> In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig314948BBC71A1E9E4AB67F82" X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, Eli Zaretskii , angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig314948BBC71A1E9E4AB67F82 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/10/12 9:30 AM, Stefan Monnier wrote: >> It's a minor bugfix, not a feature. I was under the impression that >> the release branch was _for_ minor bugfixes. Enough people have >> complained about the icon missing from the cygw32 build that I thought= >> it would be worthwhile to fix it before release. >=20 > The branch is in "regression only" state, i.e. only regressions w.r.t > Emacs>=3D23 should make it there (except for trivially safe bug-fixes, = and > exceptions granted on a case-by-case basis). >=20 > Please move your patch from the branch to the trunk, since it doesn't > fix such a regression, is not super important (yes, it's definitely > nicer to have an icon, but people can live without one until 24.4), and= > its safety is not obvious. Done. --------------enig314948BBC71A1E9E4AB67F82 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlDGIrkACgkQ17c2LVA10VsXcQCgjdSAUyfrvYWWpGPslssMlGXD vZgAoOc90k4B2ruNMC/nxYdObA+D2mzj =xLRi -----END PGP SIGNATURE----- --------------enig314948BBC71A1E9E4AB67F82-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 14:58:24 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 19:58:24 +0000 Received: from localhost ([127.0.0.1]:35895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti9Ue-0004E0-Dm for submit@debbugs.gnu.org; Mon, 10 Dec 2012 14:58:24 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:45740) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti9Ua-0004Dp-W0 for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 14:58:22 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MET00E00YRIWD00@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 21:57:32 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MET00E07ZFUM5A0@a-mtaout22.012.net.il>; Mon, 10 Dec 2012 21:57:31 +0200 (IST) Date: Mon, 10 Dec 2012 21:57:23 +0200 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <50C60CBE.1070905@dancol.org> X-012-Sender: halo1@inter.net.il To: Daniel Colascione Message-id: <831uexbrz0.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <83k3sqatks.fsf@gnu.org> <50C60CBE.1070905@dancol.org> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.2 (/) > Date: Mon, 10 Dec 2012 08:24:30 -0800 > From: Daniel Colascione > CC: 12993@debbugs.gnu.org, angelo.graziosi@alice.it > > > SetErrorMode (SEM_FAILCRITICALERRORS); > > - > > - /* Invoke the NT CRT startup routine now that our housecleaning > > - is finished. */ > > -#ifdef HAVE_NTGUI > > - /* determine WinMain args like crt0.c does */ > > - hinst = GetModuleHandle (NULL); > > - lpCmdLine = GetCommandLine (); > > - nCmdShow = SW_SHOWDEFAULT; > > -#endif > > mainCRTStartup (); > > } > > > > What do you know about lpCmdLine and nCmdShow, and "what crt0.c does" > > with them, to be sure they can be removed? > > I removed dead code. Those variables are never used; the C runtime (to > which we dynamically link anyway) handles this initialization > internally. I'm not sure. To me, it looks like we are _replacing_ the _start function from the C runtime, and therefore whoever wrote this code wanted to do things like the C runtime does. I see similar code in crt0.c from the Windows Platform SDK. If you know why this is dead code, please tell the details. > (We appear to have a separate bug with respect to > nCmdShow: create a shortcut to runemacs.exe and set it to start > minimized or start maximized. Emacs starts with a normal window.) The equivalent code in crt0.c indeed looks at dwFlags member of STARTUPINFO. So I guess this is evidence that this code does matter, right? > > And this hunk breaks the MS-DOS build: > > *sigh* The MS-DOS build breaks when the wind blows the wrong way. That's an exaggeration. There's no evidence for that. > Does the build work inside DOSBox? I'll have to start testing the > build in that environment before pushing. There's no need. The DOS build can remain broken on the trunk for prolonged periods, because no one tracks that. I usually test the build at strategic moments, and fix whatever needs fixing. For this pretest, I already did that on the branch, and I'd like to keep it functional if possible. In general, any introduction of a new variable in src/Makefile.in that gets replaced by the configure script should be edited by msdos/sed1v2.inp, usually to an empty value. But if the configury stuff doesn't change during a pretest, no changes are needed in msdos/* files. Anyway, when in doubt, just ask me, I can test if needed. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 15:07:56 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 20:07:56 +0000 Received: from localhost ([127.0.0.1]:35902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti9ds-0004SQ-I8 for submit@debbugs.gnu.org; Mon, 10 Dec 2012 15:07:56 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:47875) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti9dr-0004SK-A8 for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 15:07:55 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MET00F00ZQ04C00@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 22:06:37 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MET00ETVZV0UF70@a-mtaout22.012.net.il>; Mon, 10 Dec 2012 22:06:37 +0200 (IST) Date: Mon, 10 Dec 2012 22:06:29 +0200 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <50C622B7.9070103@dancol.org> X-012-Sender: halo1@inter.net.il To: Daniel Colascione Message-id: <83zk1lacze.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <50C607C8.3050003@dancol.org> <50C622B7.9070103@dancol.org> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, monnier@IRO.UMontreal.CA, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.2 (/) > Date: Mon, 10 Dec 2012 09:58:15 -0800 > From: Daniel Colascione > CC: Eli Zaretskii , 12993@debbugs.gnu.org, > angelo.graziosi@alice.it > > > Please move your patch from the branch to the trunk, since it doesn't > > fix such a regression, is not super important (yes, it's definitely > > nicer to have an icon, but people can live without one until 24.4), and > > its safety is not obvious. > > Done. Thank you. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 16:06:31 2012 Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 21:06:31 +0000 Received: from localhost ([127.0.0.1]:35934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TiAYZ-0005o1-2E for submit@debbugs.gnu.org; Mon, 10 Dec 2012 16:06:31 -0500 Received: from dancol.org ([96.126.100.184]:42234) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TiAYW-0005nt-AG for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 16:06:29 -0500 Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[0.0.0.0]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1TiAXt-0001LX-N3; Mon, 10 Dec 2012 13:05:49 -0800 Message-ID: <50C64EA4.1070303@dancol.org> Date: Mon, 10 Dec 2012 13:05:40 -0800 From: Daniel Colascione User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <83k3sqatks.fsf@gnu.org> <50C60CBE.1070905@dancol.org> <831uexbrz0.fsf@gnu.org> In-Reply-To: <831uexbrz0.fsf@gnu.org> X-Enigmail-Version: 1.4.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig297DACCECA62E4AED09D8CEB" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig297DACCECA62E4AED09D8CEB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12/10/2012 11:57 AM, Eli Zaretskii wrote: >> Date: Mon, 10 Dec 2012 08:24:30 -0800 >> From: Daniel Colascione >> CC: 12993@debbugs.gnu.org, angelo.graziosi@alice.it >> >>> SetErrorMode (SEM_FAILCRITICALERRORS); >>> - >>> - /* Invoke the NT CRT startup routine now that our housecleanin= g >>> - is finished. */ >>> -#ifdef HAVE_NTGUI >>> - /* determine WinMain args like crt0.c does */ >>> - hinst =3D GetModuleHandle (NULL); >>> - lpCmdLine =3D GetCommandLine (); >>> - nCmdShow =3D SW_SHOWDEFAULT; >>> -#endif >>> mainCRTStartup (); >>> } >>> >>> What do you know about lpCmdLine and nCmdShow, and "what crt0.c does"= >>> with them, to be sure they can be removed? >> >> I removed dead code. Those variables are never used; the C runtime (to= >> which we dynamically link anyway) handles this initialization >> internally. >=20 > I'm not sure. To me, it looks like we are _replacing_ the _start > function from the C runtime, and therefore whoever wrote this code > wanted to do things like the C runtime does. I see similar code in > crt0.c from the Windows Platform SDK. If you know why this is dead > code, please tell the details. I don't see that code in my copy of VS10's crt0.c. The code is useless because it doesn't affect program execution. The symb= ols lpCmdLine and nCmdShow are defined only because we define them. (If you d= eclare them extern without defining them, compilation fails.) Therefore, Emacs i= s the only user of these variables. The variables aren't used elsewhere in Emac= s code either. --------------enig297DACCECA62E4AED09D8CEB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Cygwin) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iEYEARECAAYFAlDGTqgACgkQ17c2LVA10VtzvQCgtpfFXpjf9BOj8wJZYwJVJQsN 3IQAn3XEimZjewV38KtbzY0NsVrAWRak =wQaQ -----END PGP SIGNATURE----- --------------enig297DACCECA62E4AED09D8CEB-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 20 22:44:30 2012 Received: (at control) by debbugs.gnu.org; 21 Dec 2012 03:44:30 +0000 Received: from localhost ([127.0.0.1]:53267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TltXB-0003HO-MO for submit@debbugs.gnu.org; Thu, 20 Dec 2012 22:44:30 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:47911) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TltX6-0003HE-UU for control@debbugs.gnu.org; Thu, 20 Dec 2012 22:44:29 -0500 Received: by mail-pa0-f47.google.com with SMTP id fa10so2519828pad.34 for ; Thu, 20 Dec 2012 19:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:subject:date:message-id:mime-version :content-type; bh=ZcaB7XH5Z8IxfO3gNPzY+tJO05L7xwK9q6H7cPXE3FI=; b=RLnaIyRDUjU7D/c1T1j5vuf/mbpSA/HNoYDwqYREgXDx0eabPfz8SR/dgRYgmTA7VD qje7ObVXqK92JiJmhFFh14324NW7Gbq79De+PZjpwDJiRMGdhQfP78I/qWm89kglPKK3 5k48MnwlHB0G8CZFuf7E5nEYmlroB68497qZI9TAgewDsxzCPcV5149bQccpmtI2B0q/ GOvoCbq8JSmm37Efc8/vQa/wmS28eFkY1yFS7eIqTrGHd0qIVkyjqvaqn7OPOMuIR1Jm AudulTak9lyO3MKRxTEnk7yPB6kXwzWZO4A4yHwLjeAL8uFtmji1qwcf81yh8qTibg3l lAvA== X-Received: by 10.68.234.36 with SMTP id ub4mr36156806pbc.68.1356061453093; Thu, 20 Dec 2012 19:44:13 -0800 (PST) Received: from ulysses ([155.69.18.203]) by mx.google.com with ESMTPS id qn3sm3993192pbb.56.2012.12.20.19.44.10 (version=SSLv3 cipher=OTHER); Thu, 20 Dec 2012 19:44:11 -0800 (PST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 12993 Date: Fri, 21 Dec 2012 11:44:07 +0800 Message-ID: <87zk18hxx4.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) close 12993 thanks From unknown Mon Jun 23 04:13:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Jan 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 14:12:01 2013 Received: (at control) by debbugs.gnu.org; 7 Apr 2013 18:12:01 +0000 Received: from localhost ([127.0.0.1]:38702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOu4O-0002S3-VQ for submit@debbugs.gnu.org; Sun, 07 Apr 2013 14:12:01 -0400 Received: from limestone5.mail.cornell.edu ([128.253.83.165]:50470) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOu4N-0002Rw-17 for control@debbugs.gnu.org; Sun, 07 Apr 2013 14:12:00 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu ([10.16.197.8]) by limestone5.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r37I8SBa016413; Sun, 7 Apr 2013 14:08:29 -0400 (EDT) Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r37I8TuI003362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 7 Apr 2013 14:08:29 -0400 Message-ID: <5161B60E.5090902@cornell.edu> Date: Sun, 07 Apr 2013 14:08:14 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: control@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) unarchive 12993 reopen 12993 From unknown Mon Jun 23 04:13:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Sun, 07 Apr 2013 18:12:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 14:15:43 2013 Received: (at 12993) by debbugs.gnu.org; 7 Apr 2013 18:15:43 +0000 Received: from localhost ([127.0.0.1]:38710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOu7z-0003Qp-KZ for submit@debbugs.gnu.org; Sun, 07 Apr 2013 14:15:43 -0400 Received: from limestone8.mail.cornell.edu ([128.253.83.168]:43223) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOu7x-0003Qi-Fm for 12993@debbugs.gnu.org; Sun, 07 Apr 2013 14:15:42 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limestone8.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r37IC4AY022712; Sun, 7 Apr 2013 14:12:05 -0400 (EDT) Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r37IC3kg004020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 7 Apr 2013 14:12:04 -0400 Message-ID: <5161B6E4.90508@cornell.edu> Date: Sun, 07 Apr 2013 14:11:48 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Daniel Colascione Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> In-Reply-To: <50C58B9F.8050105@dancol.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, Angelo Graziosi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On 12/10/2012 2:13 AM, Daniel Colascione wrote: > On 11/25/12 6:49 AM, Angelo Graziosi wrote: >> I notice that the Cygw32 port does not show the standard Emacs icon on >> the upper-left corner (and elsewhere, I think). >> >> Would it be possible to have that? The Windows port has... > > I've pushed a change to the emacs-24 branch that should resolve the > problem. We weren't compiling Windows resources into the cygw32 Emacs > binary. Daniel, At some point could you update this fix so that it works on 64-bit Cygwin also? I don't know if you've set up a 64-bit Cygwin environment yet. If not, there's obviously no rush about this. Thanks. Ken From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 14:51:48 2013 Received: (at 12993) by debbugs.gnu.org; 7 Apr 2013 18:51:48 +0000 Received: from localhost ([127.0.0.1]:38753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOugu-0004IP-FA for submit@debbugs.gnu.org; Sun, 07 Apr 2013 14:51:48 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:65507) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOugs-0004IG-AK for 12993@debbugs.gnu.org; Sun, 07 Apr 2013 14:51:47 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MKW00L00EQG0200@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Sun, 07 Apr 2013 21:48:11 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKW00KNLEWBH9C0@a-mtaout22.012.net.il>; Sun, 07 Apr 2013 21:48:11 +0300 (IDT) Date: Sun, 07 Apr 2013 21:48:19 +0300 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <5161B6E4.90508@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <834nfich3g.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org, angelo.graziosi@alice.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Sun, 07 Apr 2013 14:11:48 -0400 > From: Ken Brown > Cc: 12993@debbugs.gnu.org, Angelo Graziosi > > At some point could you update this fix so that it works on 64-bit > Cygwin also? What are the problems that prevent this from working with 64-bit Cygwin? I presume there's a 64-bit windres.exe, and nt/emacs.rc is already set up to cater to 64-bit builds. What am I missing? From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 18:48:01 2013 Received: (at 12993) by debbugs.gnu.org; 7 Apr 2013 22:48:01 +0000 Received: from localhost ([127.0.0.1]:38957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOyNU-0001OI-Rs for submit@debbugs.gnu.org; Sun, 07 Apr 2013 18:48:01 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:61438) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOyNQ-0001O7-6P for 12993@debbugs.gnu.org; Sun, 07 Apr 2013 18:47:57 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu ([10.16.197.8]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r37MiAEH028942; Sun, 7 Apr 2013 18:44:10 -0400 (EDT) Received: from [192.168.1.9] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r37MiJBe003090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 7 Apr 2013 18:44:19 -0400 Message-ID: <5161F6D4.20402@cornell.edu> Date: Sun, 07 Apr 2013 18:44:36 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> In-Reply-To: <834nfich3g.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On 4/7/2013 2:48 PM, Eli Zaretskii wrote: >> Date: Sun, 07 Apr 2013 14:11:48 -0400 >> From: Ken Brown >> Cc: 12993@debbugs.gnu.org, Angelo Graziosi >> >> At some point could you update this fix so that it works on 64-bit >> Cygwin also? > > What are the problems that prevent this from working with 64-bit > Cygwin? I presume there's a 64-bit windres.exe, and nt/emacs.rc is > already set up to cater to 64-bit builds. What am I missing? The problem is that the build fails. There's no error message explaining the failure, just "Makefile:785: recipe for target `bootstrap-emacs.exe' failed". But the build succeeds if I remove the attempt to compile Windows resources: --- configure.ac 2013-03-18 05:26:56 +0000 +++ configure.ac 2013-03-23 15:09:15 +0000 @@ -1524,10 +1525,12 @@ W32_OBJ="$W32_OBJ w32xfns.o w32select.o w32uniscribe.o" W32_LIBS="$W32_LIBS -lkernel32 -luser32 -lgdi32 -lole32 -lcomdlg32" W32_LIBS="$W32_LIBS -lusp10 -lcomctl32 -lwinspool" - W32_RES="emacs.res" + dnl W32_RES="emacs.res" + W32_RES="" # Tell the linker that emacs.res is an object (which we compile from # the rc file), not a linker script. - W32_RES_LINK="-Wl,-bpe-i386 -Wl,emacs.res" + dnl W32_RES_LINK="-Wl,-bpe-i386 -Wl,emacs.res" + W32_RES_LINK="" fi AC_SUBST(W32_OBJ) AC_SUBST(W32_LIBS) I know nothing about Windows resources, so I have no idea what's causing the build failure. Ken From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 22:42:49 2013 Received: (at 12993) by debbugs.gnu.org; 8 Apr 2013 02:42:49 +0000 Received: from localhost ([127.0.0.1]:39163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UP22j-0006zS-En for submit@debbugs.gnu.org; Sun, 07 Apr 2013 22:42:49 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:58074) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UP22g-0006zJ-D2 for 12993@debbugs.gnu.org; Sun, 07 Apr 2013 22:42:47 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MKX002000OO3900@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 05:39:14 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKX001AC0PEQY80@a-mtaout22.012.net.il>; Mon, 08 Apr 2013 05:39:14 +0300 (IDT) Date: Mon, 08 Apr 2013 05:39:23 +0300 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <5161F6D4.20402@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83zjx9bvac.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Sun, 07 Apr 2013 18:44:36 -0400 > From: Ken Brown > CC: dancol@dancol.org, 12993@debbugs.gnu.org > > On 4/7/2013 2:48 PM, Eli Zaretskii wrote: > >> Date: Sun, 07 Apr 2013 14:11:48 -0400 > >> From: Ken Brown > >> Cc: 12993@debbugs.gnu.org, Angelo Graziosi > >> > >> At some point could you update this fix so that it works on 64-bit > >> Cygwin also? > > > > What are the problems that prevent this from working with 64-bit > > Cygwin? I presume there's a 64-bit windres.exe, and nt/emacs.rc is > > already set up to cater to 64-bit builds. What am I missing? > > The problem is that the build fails. There's no error message > explaining the failure, just "Makefile:785: recipe for target > `bootstrap-emacs.exe' failed". But the build succeeds if I remove the > attempt to compile Windows resources: What is on line 785 of Makefile? > I know nothing about Windows resources They are just a fancy kind of object file produced from a fancy kind of source (emacs.rc in this case). From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 09:06:58 2013 Received: (at 12993) by debbugs.gnu.org; 8 Apr 2013 13:06:58 +0000 Received: from localhost ([127.0.0.1]:39615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPBmi-0006k0-Gm for submit@debbugs.gnu.org; Mon, 08 Apr 2013 09:06:57 -0400 Received: from limestone5.mail.cornell.edu ([128.253.83.165]:61480) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPBme-0006jr-D2 for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 09:06:54 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu ([10.16.197.9]) by limestone5.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r38D3Cod014341; Mon, 8 Apr 2013 09:03:13 -0400 (EDT) Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r38D3BXJ002202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Apr 2013 09:03:12 -0400 Message-ID: <5162BFFF.3090407@cornell.edu> Date: Mon, 08 Apr 2013 09:02:55 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> In-Reply-To: <83zjx9bvac.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On 4/7/2013 10:39 PM, Eli Zaretskii wrote: >> Date: Sun, 07 Apr 2013 18:44:36 -0400 >> From: Ken Brown >> CC: dancol@dancol.org, 12993@debbugs.gnu.org >> >> On 4/7/2013 2:48 PM, Eli Zaretskii wrote: >>>> Date: Sun, 07 Apr 2013 14:11:48 -0400 >>>> From: Ken Brown >>>> Cc: 12993@debbugs.gnu.org, Angelo Graziosi >>>> >>>> At some point could you update this fix so that it works on 64-bit >>>> Cygwin also? >>> >>> What are the problems that prevent this from working with 64-bit >>> Cygwin? I presume there's a 64-bit windres.exe, and nt/emacs.rc is >>> already set up to cater to 64-bit builds. What am I missing? >> >> The problem is that the build fails. There's no error message >> explaining the failure, just "Makefile:785: recipe for target >> `bootstrap-emacs.exe' failed". But the build succeeds if I remove the >> attempt to compile Windows resources: > > What is on line 785 of Makefile? > >> I know nothing about Windows resources > > They are just a fancy kind of object file produced from a fancy kind > of source (emacs.rc in this case). I tried again on a different computer, after updating to the current emacs trunk, and this time I got a meaningful error message: /usr/lib/gcc/x86_64-pc-cygwin/4.8.0/../../../../x86_64-pc-cygwin/bin/ld: i386 architecture of input file `emacs.res' is incompatible with i386:x86-64 output This made me think that the problem was the "pe-i386" in the following line of configure.ac: W32_RES_LINK="-Wl,-bpe-i386 -Wl,emacs.res" I made several guesses as to what should be there (including "pe-x86-64", which seemed the most likely), but I kept getting the same error message. Is it possible that the problem is in nt/emacs.rc after all? Ken From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 10:56:55 2013 Received: (at 12993) by debbugs.gnu.org; 8 Apr 2013 14:56:55 +0000 Received: from localhost ([127.0.0.1]:40144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPDV9-00010M-5A for submit@debbugs.gnu.org; Mon, 08 Apr 2013 10:56:55 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:61713) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPDV3-000109-84 for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 10:56:52 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MKX00700YLU8Z00@a-mtaout21.012.net.il> for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 17:53:14 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKX007UOYOO3550@a-mtaout21.012.net.il>; Mon, 08 Apr 2013 17:53:13 +0300 (IDT) Date: Mon, 08 Apr 2013 17:53:22 +0300 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <5162BFFF.3090407@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83vc7xaxb1.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Mon, 08 Apr 2013 09:02:55 -0400 > From: Ken Brown > CC: dancol@dancol.org, 12993@debbugs.gnu.org > > I tried again on a different computer, after updating to the current > emacs trunk, and this time I got a meaningful error message: > > /usr/lib/gcc/x86_64-pc-cygwin/4.8.0/../../../../x86_64-pc-cygwin/bin/ld: > i386 architecture of input file `emacs.res' is incompatible with > i386:x86-64 output > > This made me think that the problem was the "pe-i386" in the following > line of configure.ac: > > W32_RES_LINK="-Wl,-bpe-i386 -Wl,emacs.res" > > I made several guesses as to what should be there (including > "pe-x86-64", which seemed the most likely), but I kept getting the same > error message. What does "objdump -fh emacs.res" say? > Is it possible that the problem is in nt/emacs.rc after all? Unlikely, since it works with the 64-bit Microsoft compiler. Does Cygwin64 define WIN64? If not, it might be getting the wrong version of the manifest. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 11:29:45 2013 Received: (at 12993) by debbugs.gnu.org; 8 Apr 2013 15:29:45 +0000 Received: from localhost ([127.0.0.1]:40173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPE0u-0001kv-Dw for submit@debbugs.gnu.org; Mon, 08 Apr 2013 11:29:45 -0400 Received: from limestone4.mail.cornell.edu ([128.253.83.164]:35968) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPE0r-0001kn-E2 for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 11:29:43 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu ([10.16.197.8]) by limestone4.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r38FQ0Uj008279; Mon, 8 Apr 2013 11:26:01 -0400 (EDT) Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r38FPxU9006869 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Apr 2013 11:26:00 -0400 Message-ID: <5162E177.10601@cornell.edu> Date: Mon, 08 Apr 2013 11:25:43 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> <83vc7xaxb1.fsf@gnu.org> In-Reply-To: <83vc7xaxb1.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On 4/8/2013 10:53 AM, Eli Zaretskii wrote: >> Date: Mon, 08 Apr 2013 09:02:55 -0400 >> From: Ken Brown >> CC: dancol@dancol.org, 12993@debbugs.gnu.org >> >> I tried again on a different computer, after updating to the current >> emacs trunk, and this time I got a meaningful error message: >> >> /usr/lib/gcc/x86_64-pc-cygwin/4.8.0/../../../../x86_64-pc-cygwin/bin/ld: >> i386 architecture of input file `emacs.res' is incompatible with >> i386:x86-64 output >> >> This made me think that the problem was the "pe-i386" in the following >> line of configure.ac: >> >> W32_RES_LINK="-Wl,-bpe-i386 -Wl,emacs.res" >> >> I made several guesses as to what should be there (including >> "pe-x86-64", which seemed the most likely), but I kept getting the same >> error message. > > What does "objdump -fh emacs.res" say? $ objdump -fh src/emacs.res src/emacs.res: file format pe-i386 architecture: i386, flags 0x00000039: HAS_RELOC, HAS_DEBUG, HAS_SYMS, HAS_LOCALS start address 0x00000000 Sections: Idx Name Size VMA LMA File off Algn 0 .rsrc 0000d5f0 00000000 00000000 0000003c 2**2 CONTENTS, ALLOC, LOAD, RELOC, DATA > > Is it possible that the problem is in nt/emacs.rc after all? > > Unlikely, since it works with the 64-bit Microsoft compiler. Does > Cygwin64 define WIN64? If not, it might be getting the wrong version > of the manifest. No, it doesn't define WIN64. It does define __x86_64__ if that helps. Ken From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 12:28:43 2013 Received: (at 12993) by debbugs.gnu.org; 8 Apr 2013 16:28:43 +0000 Received: from localhost ([127.0.0.1]:40255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPEvy-00043q-6d for submit@debbugs.gnu.org; Mon, 08 Apr 2013 12:28:42 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:37645) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPEvt-00043g-Tz for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 12:28:40 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MKY00A002AGMP00@a-mtaout23.012.net.il> for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 19:24:43 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKY00AC72X3O000@a-mtaout23.012.net.il>; Mon, 08 Apr 2013 19:24:39 +0300 (IDT) Date: Mon, 08 Apr 2013 19:24:49 +0300 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <5162E177.10601@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83ip3xat2m.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> <83vc7xaxb1.fsf@gnu.org> <5162E177.10601@cornell.edu> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Mon, 08 Apr 2013 11:25:43 -0400 > From: Ken Brown > CC: dancol@dancol.org, 12993@debbugs.gnu.org > > $ objdump -fh src/emacs.res > > src/emacs.res: file format pe-i386 > architecture: i386, flags 0x00000039: > HAS_RELOC, HAS_DEBUG, HAS_SYMS, HAS_LOCALS > start address 0x00000000 > > Sections: > Idx Name Size VMA LMA File off > Algn > 0 .rsrc 0000d5f0 00000000 00000000 0000003c 2**2 > CONTENTS, ALLOC, LOAD, RELOC, DATA That doesn't look right, the format shouldn't be pe-i386. What do you get for any .o file compiled by the 64-bit Cygwin GCC? > > > Is it possible that the problem is in nt/emacs.rc after all? > > > > Unlikely, since it works with the 64-bit Microsoft compiler. Does > > Cygwin64 define WIN64? If not, it might be getting the wrong version > > of the manifest. > > No, it doesn't define WIN64. It does define __x86_64__ if that helps. Then please try editing emacs.rc to change #ifdef WIN64 1 24 "emacs-x64.manifest" #else 1 24 "emacs-x86.manifest" #endif into #ifdef __x86_64__ 1 24 "emacs-x64.manifest" #else 1 24 "emacs-x86.manifest" #endif and see if that helps. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 13:02:07 2013 Received: (at 12993) by debbugs.gnu.org; 8 Apr 2013 17:02:07 +0000 Received: from localhost ([127.0.0.1]:40280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPFSI-0004sU-Ez for submit@debbugs.gnu.org; Mon, 08 Apr 2013 13:02:07 -0400 Received: from limestone5.mail.cornell.edu ([128.253.83.165]:47954) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPFSE-0004sL-VL for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 13:02:04 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu ([10.16.197.9]) by limestone5.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r38GwMil004661; Mon, 8 Apr 2013 12:58:22 -0400 (EDT) Received: from [192.168.1.9] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r38GwLdc030953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Apr 2013 12:58:22 -0400 Message-ID: <5162F740.9020409@cornell.edu> Date: Mon, 08 Apr 2013 12:58:40 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> <83vc7xaxb1.fsf@gnu.org> <5162E177.10601@cornell.edu> <83ip3xat2m.fsf@gnu.org> In-Reply-To: <83ip3xat2m.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On 4/8/2013 12:24 PM, Eli Zaretskii wrote: >> Date: Mon, 08 Apr 2013 11:25:43 -0400 >> From: Ken Brown >> CC: dancol@dancol.org, 12993@debbugs.gnu.org >> >> $ objdump -fh src/emacs.res >> >> src/emacs.res: file format pe-i386 >> architecture: i386, flags 0x00000039: >> HAS_RELOC, HAS_DEBUG, HAS_SYMS, HAS_LOCALS >> start address 0x00000000 >> >> Sections: >> Idx Name Size VMA LMA File off >> Algn >> 0 .rsrc 0000d5f0 00000000 00000000 0000003c 2**2 >> CONTENTS, ALLOC, LOAD, RELOC, DATA > > That doesn't look right, the format shouldn't be pe-i386. What do you > get for any .o file compiled by the 64-bit Cygwin GCC? $ objdump -fh src/emacs.o src/emacs.o: file format pe-x86-64 architecture: i386:x86-64, flags 0x00000039: HAS_RELOC, HAS_DEBUG, HAS_SYMS, HAS_LOCALS start address 0x0000000000000000 Sections: Idx Name Size VMA LMA File off Algn 0 .text 000031c0 0000000000000000 0000000000000000 0000049c 2**4 CONTENTS, ALLOC, LOAD, RELOC, READONLY, CODE 1 .data 00000120 0000000000000000 0000000000000000 0000365c 2**4 CONTENTS, ALLOC, LOAD, RELOC, DATA 2 .bss 00000150 0000000000000000 0000000000000000 00000000 2**4 ALLOC [...] >>>> Is it possible that the problem is in nt/emacs.rc after all? >>> >>> Unlikely, since it works with the 64-bit Microsoft compiler. Does >>> Cygwin64 define WIN64? If not, it might be getting the wrong version >>> of the manifest. >> >> No, it doesn't define WIN64. It does define __x86_64__ if that helps. > > Then please try editing emacs.rc to change > > #ifdef WIN64 > 1 24 "emacs-x64.manifest" > #else > 1 24 "emacs-x86.manifest" > #endif > > into > > #ifdef __x86_64__ > 1 24 "emacs-x64.manifest" > #else > 1 24 "emacs-x86.manifest" > #endif > > and see if that helps. Yes, the build now completes and the correct icon is there. Moreover, objdump now gives the expected file format: $ objdump -fr src/emacs.res src/emacs.res: file format pe-x86-64 architecture: i386:x86-64, flags 0x00000039: HAS_RELOC, HAS_DEBUG, HAS_SYMS, HAS_LOCALS start address 0x0000000000000000 RELOCATION RECORDS FOR [.rsrc]: OFFSET TYPE VALUE 000000000000022c rva32 .rsrc 000000000000023c rva32 .rsrc 000000000000024c rva32 .rsrc 000000000000025c rva32 .rsrc 000000000000026c rva32 .rsrc 000000000000027c rva32 .rsrc 000000000000028c rva32 .rsrc 000000000000029c rva32 .rsrc 00000000000002ac rva32 .rsrc 00000000000002bc rva32 .rsrc 00000000000002cc rva32 .rsrc 00000000000002dc rva32 .rsrc Thank you! So I assume the correct fix is the following: === modified file 'nt/emacs.rc' --- nt/emacs.rc 2013-03-05 03:59:35 +0000 +++ nt/emacs.rc 2013-04-08 16:55:12 +0000 @@ -1,6 +1,6 @@ Emacs ICON icons/emacs.ico 32649 CURSOR icons/hand.cur -#ifdef WIN64 +#if defined (WIN64) || defined (__x86_64__) 1 24 "emacs-x64.manifest" #else 1 24 "emacs-x86.manifest" Right? Ken From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 13:24:58 2013 Received: (at 12993) by debbugs.gnu.org; 8 Apr 2013 17:24:58 +0000 Received: from localhost ([127.0.0.1]:40300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPFoN-0005Nw-8B for submit@debbugs.gnu.org; Mon, 08 Apr 2013 13:24:58 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:52774) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPFoI-0005Nl-Rn for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 13:24:54 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MKY00D005HNJR00@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 20:20:47 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKY00CYS5IMW8E0@a-mtaout22.012.net.il>; Mon, 08 Apr 2013 20:20:47 +0300 (IDT) Date: Mon, 08 Apr 2013 20:20:56 +0300 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <5162F740.9020409@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83fvz1aqh3.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> <83vc7xaxb1.fsf@gnu.org> <5162E177.10601@cornell.edu> <83ip3xat2m.fsf@gnu.org> <5162F740.9020409@cornell.edu> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Mon, 08 Apr 2013 12:58:40 -0400 > From: Ken Brown > CC: dancol@dancol.org, 12993@debbugs.gnu.org > > Thank you! So I assume the correct fix is the following: > > === modified file 'nt/emacs.rc' > --- nt/emacs.rc 2013-03-05 03:59:35 +0000 > +++ nt/emacs.rc 2013-04-08 16:55:12 +0000 > @@ -1,6 +1,6 @@ > Emacs ICON icons/emacs.ico > 32649 CURSOR icons/hand.cur > -#ifdef WIN64 > +#if defined (WIN64) || defined (__x86_64__) > 1 24 "emacs-x64.manifest" > #else > 1 24 "emacs-x86.manifest" > > Right? Yes. But what about that linker directive in configure.ac -- is that still required? (I never understood why Cygwin needs that in the first place.) From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 16:30:40 2013 Received: (at 12993) by debbugs.gnu.org; 8 Apr 2013 20:30:40 +0000 Received: from localhost ([127.0.0.1]:40539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPIi7-0001hk-S2 for submit@debbugs.gnu.org; Mon, 08 Apr 2013 16:30:40 -0400 Received: from limestone8.mail.cornell.edu ([128.253.83.168]:57649) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPIi5-0001hc-E6 for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 16:30:38 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limestone8.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r38KQtYW003221; Mon, 8 Apr 2013 16:26:56 -0400 (EDT) Received: from [128.84.234.248] (dhcp248.math.cornell.edu [128.84.234.248]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r38KQtHM032107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Apr 2013 16:26:55 -0400 Message-ID: <516327FF.1050801@cornell.edu> Date: Mon, 08 Apr 2013 16:26:39 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> <83vc7xaxb1.fsf@gnu.org> <5162E177.10601@cornell.edu> <83ip3xat2m.fsf@gnu.org> <5162F740.9020409@cornell.edu> <83fvz1aqh3.fsf@gnu.org> In-Reply-To: <83fvz1aqh3.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On 4/8/2013 1:20 PM, Eli Zaretskii wrote: >> Date: Mon, 08 Apr 2013 12:58:40 -0400 >> From: Ken Brown >> CC: dancol@dancol.org, 12993@debbugs.gnu.org >> >> Thank you! So I assume the correct fix is the following: >> >> === modified file 'nt/emacs.rc' >> --- nt/emacs.rc 2013-03-05 03:59:35 +0000 >> +++ nt/emacs.rc 2013-04-08 16:55:12 +0000 >> @@ -1,6 +1,6 @@ >> Emacs ICON icons/emacs.ico >> 32649 CURSOR icons/hand.cur >> -#ifdef WIN64 >> +#if defined (WIN64) || defined (__x86_64__) >> 1 24 "emacs-x64.manifest" >> #else >> 1 24 "emacs-x86.manifest" >> >> Right? > > Yes. But what about that linker directive in configure.ac -- is that > still required? (I never understood why Cygwin needs that in the > first place.) The "-Wl,-bpe-i386" part is not necessary. I just checked this on both Cygwin32 and Cygwin64. I think it should be removed, since it's confusing to have an unnecessary directive (especially on Cygwin64, where the format is actually pe-x86-64). But if both directives are removed, the icon doesn't show up. I guess the comment right before that line in configure.ac explains why. Ken From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 22:44:32 2013 Received: (at 12993) by debbugs.gnu.org; 9 Apr 2013 02:44:32 +0000 Received: from localhost ([127.0.0.1]:40922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPOXv-00030j-So for submit@debbugs.gnu.org; Mon, 08 Apr 2013 22:44:32 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:37931) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPOXs-00030Z-7j for 12993@debbugs.gnu.org; Mon, 08 Apr 2013 22:44:29 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MKY00I00VDOIB00@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Tue, 09 Apr 2013 05:40:51 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKY00IKUVG20NB0@a-mtaout22.012.net.il>; Tue, 09 Apr 2013 05:40:51 +0300 (IDT) Date: Tue, 09 Apr 2013 05:41:02 +0300 From: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs In-reply-to: <516327FF.1050801@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83bo9obf41.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> <83vc7xaxb1.fsf@gnu.org> <5162E177.10601@cornell.edu> <83ip3xat2m.fsf@gnu.org> <5162F740.9020409@cornell.edu> <83fvz1aqh3.fsf@gnu.org> <516327FF.1050801@cornell.edu> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 12993 Cc: 12993@debbugs.gnu.org, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Mon, 08 Apr 2013 16:26:39 -0400 > From: Ken Brown > CC: dancol@dancol.org, 12993@debbugs.gnu.org > > The "-Wl,-bpe-i386" part is not necessary. I just checked this on both > Cygwin32 and Cygwin64. I think it should be removed, since it's > confusing to have an unnecessary directive (especially on Cygwin64, > where the format is actually pe-x86-64). But if both directives are > removed, the icon doesn't show up. I guess the comment right before > that line in configure.ac explains why. Then you will have to provide a different directive for the 64-bit build, because the file type is no longer pe-i386. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 22:47:54 2013 Received: (at 12993-done) by debbugs.gnu.org; 9 Apr 2013 02:47:54 +0000 Received: from localhost ([127.0.0.1]:40929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPObB-00035k-EN for submit@debbugs.gnu.org; Mon, 08 Apr 2013 22:47:54 -0400 Received: from limestone4.mail.cornell.edu ([128.253.83.164]:56224) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPOb8-00035a-Mq for 12993-done@debbugs.gnu.org; Mon, 08 Apr 2013 22:47:52 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu ([10.16.197.8]) by limestone4.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r392iDEg027919; Mon, 8 Apr 2013 22:44:14 -0400 (EDT) Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r392iDgf028837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Apr 2013 22:44:13 -0400 Message-ID: <5163806B.3060404@cornell.edu> Date: Mon, 08 Apr 2013 22:43:55 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12993: Wrong icon for Cygw32-Emacs References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> <83vc7xaxb1.fsf@gnu.org> <5162E177.10601@cornell.edu> <83ip3xat2m.fsf@gnu.org> <5162F740.9020409@cornell.edu> <83fvz1aqh3.fsf@gnu.org> <516327FF.1050801@cornell.edu> In-Reply-To: <516327FF.1050801@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 12993-done Cc: 12993-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On 4/8/2013 4:26 PM, Ken Brown wrote: > On 4/8/2013 1:20 PM, Eli Zaretskii wrote: >>> Date: Mon, 08 Apr 2013 12:58:40 -0400 >>> From: Ken Brown >>> CC: dancol@dancol.org, 12993@debbugs.gnu.org >>> >>> Thank you! So I assume the correct fix is the following: >>> >>> === modified file 'nt/emacs.rc' >>> --- nt/emacs.rc 2013-03-05 03:59:35 +0000 >>> +++ nt/emacs.rc 2013-04-08 16:55:12 +0000 >>> @@ -1,6 +1,6 @@ >>> Emacs ICON icons/emacs.ico >>> 32649 CURSOR icons/hand.cur >>> -#ifdef WIN64 >>> +#if defined (WIN64) || defined (__x86_64__) >>> 1 24 "emacs-x64.manifest" >>> #else >>> 1 24 "emacs-x86.manifest" >>> >>> Right? >> >> Yes. But what about that linker directive in configure.ac -- is that >> still required? (I never understood why Cygwin needs that in the >> first place.) > > The "-Wl,-bpe-i386" part is not necessary. I just checked this on both > Cygwin32 and Cygwin64. I think it should be removed, since it's > confusing to have an unnecessary directive (especially on Cygwin64, > where the format is actually pe-x86-64). But if both directives are > removed, the icon doesn't show up. I guess the comment right before > that line in configure.ac explains why. I've removed "-Wl,-bpe-i386" and made the change to nt/emacs.rc as bzr revision 112251. I'm closing the bug report. Thanks again for your help, Eli. Ken From unknown Mon Jun 23 04:13:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 May 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator