GNU bug report logs - #12972
24.3.50; Move `org-open-file' and associated code out of Org mode

Previous Next

Full log

Message #56 received at 12972 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Maxim Nikulin <manikulin <at> gmail.com>
Cc: 12972 <at> debbugs.gnu.org
Subject: Re: bug#12972: [PATCH] Avoid regression in mailcap-view-file similar
 to Bug#44824
Date: Mon, 05 Jul 2021 18:23:54 +0300

> From: Maxim Nikulin <manikulin <at> gmail.com>
> Date: Mon, 5 Jul 2021 20:12:34 +0700
> 
> It is about proper way to a launch viewer in 
> `mailcap-view-file'. Original `start-process-shell-command' with 'pty 
> connection type prematurely kills children of kde-open5 or gio open. 
> With 'pipe connection type it or `make-process' might make emacs CPU 
> hungry if a child decides to close stdout and stderr:
> 
> >> #!/bin/sh
> >> exec 1>&-
> >> exec 2>&-
> >> sleep 30

Is the above something a file viewer is likely to do?

And if it does, how would you suggest to countermand that?

> and finally `process-file-shell-command' does not allow to report 
> failure.

The original code uses start-process-shell-command, and I don't think
I understand why you wanted to call process-file-shell-command
instead.  Can you explain?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.