From unknown Mon Jun 23 04:11:51 2025 X-Loop: don@donarmstrong.com Subject: bug#1297: font-lock-keywords-case-fold-search doc and usage Reply-To: Dan Nicolaescu , 1297@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 02 Nov 2008 16:05:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1297 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122564142216334 (code B ref -1); Sun, 02 Nov 2008 16:05:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.9 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 2 Nov 2008 15:57:02 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA2FuwgG016328 for ; Sun, 2 Nov 2008 07:57:00 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KwfJx-0001Ze-7u for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 10:56:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KwfJt-0001ZS-E4 for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 10:56:55 -0500 Received: from [199.232.76.173] (port=58469 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwfJt-0001ZP-8c for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 10:56:53 -0500 Received: from sallyv2.ics.uci.edu ([128.195.1.120]:47169) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KwfJs-0001df-7D for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 10:56:53 -0500 Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mA2FuYdD007020 for ; Sun, 2 Nov 2008 07:56:34 -0800 (PST) Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mA2FuXo1028390; Sun, 2 Nov 2008 07:56:33 -0800 (PST) Date: Sun, 2 Nov 2008 07:56:33 -0800 (PST) Message-Id: <200811021556.mA2FuXo1028390@mothra.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Lines: 13 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mA2FuYdD007020 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) font-lock-keywords-case-fold-search docstring should make it more clear that font-lock-defaults erases it. There is one victim in the tree. `lisp-mode' does: (make-local-variable 'font-lock-keywords-case-fold-search) (setq font-lock-keywords-case-fold-search t) but the value of font-lock-keywords-case-fold-search in a lisp-mode buffer is nil, that's because font-lock-defaults does a kill-local-variable on it... From unknown Mon Jun 23 04:11:51 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Dan Nicolaescu Subject: bug#1297 closed by Chong Yidong (Re: font-lock-keywords-case-fold-search doc and usage) Message-ID: References: <87od0xh600.fsf@cyd.mit.edu> <200811021556.mA2FuXo1028390@mothra.ics.uci.edu> X-Emacs-PR-Message: they-closed 1297 X-Emacs-PR-Package: emacs Reply-To: 1297@debbugs.gnu.org Content-Type: multipart/mixed; boundary="----------=_1225681506-22131-1" This is a multi-part message in MIME format... ------------=_1225681506-22131-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #1297: font-lock-keywords-case-fold-search doc and usage It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 1297: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1297 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1225681506-22131-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From cyd@stupidchicken.com Sun Nov 2 18:56:30 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1297-done) by emacsbugs.donarmstrong.com; 3 Nov 2008 02:56:30 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA32uNmF020516 for <1297-done@emacsbugs.donarmstrong.com>; Sun, 2 Nov 2008 18:56:24 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 7C6EA57E1BA; Sun, 2 Nov 2008 21:56:31 -0500 (EST) From: Chong Yidong To: Dan Nicolaescu Cc: 1297-done@debbugs.gnu.org Subject: Re: font-lock-keywords-case-fold-search doc and usage Date: Sun, 02 Nov 2008 21:56:31 -0500 Message-ID: <87od0xh600.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > font-lock-keywords-case-fold-search docstring should make it more clear > that font-lock-defaults erases it. Okay, I changed it to make it hopefully clearer. > There is one victim in the tree. `lisp-mode' does: > > (make-local-variable 'font-lock-keywords-case-fold-search) > (setq font-lock-keywords-case-fold-search t) > > but the value of font-lock-keywords-case-fold-search in a lisp-mode > buffer is nil, that's because font-lock-defaults does a > kill-local-variable on it... Great catch. No one has complained about this, so clearly it's OK for font-lock-keywords-case-fold-search to be nil. I removed the bogus 8-year-old setting of font-lock-keywords-case-fold-search. ------------=_1225681506-22131-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From dann@mothra.ics.uci.edu Sun Nov 2 07:57:02 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.9 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 2 Nov 2008 15:57:02 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA2FuwgG016328 for ; Sun, 2 Nov 2008 07:57:00 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KwfJx-0001Ze-7u for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 10:56:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KwfJt-0001ZS-E4 for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 10:56:55 -0500 Received: from [199.232.76.173] (port=58469 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwfJt-0001ZP-8c for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 10:56:53 -0500 Received: from sallyv2.ics.uci.edu ([128.195.1.120]:47169) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KwfJs-0001df-7D for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 10:56:53 -0500 Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mA2FuYdD007020 for ; Sun, 2 Nov 2008 07:56:34 -0800 (PST) Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mA2FuXo1028390; Sun, 2 Nov 2008 07:56:33 -0800 (PST) Date: Sun, 2 Nov 2008 07:56:33 -0800 (PST) Message-Id: <200811021556.mA2FuXo1028390@mothra.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: font-lock-keywords-case-fold-search doc and usage Lines: 13 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mA2FuYdD007020 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) font-lock-keywords-case-fold-search docstring should make it more clear that font-lock-defaults erases it. There is one victim in the tree. `lisp-mode' does: (make-local-variable 'font-lock-keywords-case-fold-search) (setq font-lock-keywords-case-fold-search t) but the value of font-lock-keywords-case-fold-search in a lisp-mode buffer is nil, that's because font-lock-defaults does a kill-local-variable on it... ------------=_1225681506-22131-1-- From unknown Mon Jun 23 04:11:51 2025 X-Loop: don@donarmstrong.com Subject: bug#1297: font-lock-keywords-case-fold-search doc and usage Reply-To: Dan Nicolaescu , 1297@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 03 Nov 2008 04:50:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1297 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1297-submit@emacsbugs.donarmstrong.com id=B1297.122568745514479 (code B ref 1297); Mon, 03 Nov 2008 04:50:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.4 required=4.0 tests=AWL,BAYES_00,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1297) by emacsbugs.donarmstrong.com; 3 Nov 2008 04:44:15 +0000 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA34iC8K014473 for <1297@emacsbugs.donarmstrong.com>; Sun, 2 Nov 2008 20:44:13 -0800 Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mA34i2xk011669; Sun, 2 Nov 2008 20:44:02 -0800 (PST) Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mA34i1oB000823; Sun, 2 Nov 2008 20:44:01 -0800 (PST) Date: Sun, 2 Nov 2008 20:44:01 -0800 (PST) Message-Id: <200811030444.mA34i1oB000823@mothra.ics.uci.edu> From: Dan Nicolaescu To: Chong Yidong Cc: 1297@debbugs.gnu.org References: <87od0xh600.fsf@cyd.mit.edu> In-Reply-To: <87od0xh600.fsf@cyd.mit.edu> (Chong Yidong's message of "Sun, 02 Nov 2008 21:56:31 -0500") Lines: 32 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mA34i2xk011669 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu Chong Yidong writes: > > font-lock-keywords-case-fold-search docstring should make it more clear > > that font-lock-defaults erases it. > > Okay, I changed it to make it hopefully clearer. Thanks. > > There is one victim in the tree. `lisp-mode' does: > > > > (make-local-variable 'font-lock-keywords-case-fold-search) > > (setq font-lock-keywords-case-fold-search t) > > > > but the value of font-lock-keywords-case-fold-search in a lisp-mode > > buffer is nil, that's because font-lock-defaults does a > > kill-local-variable on it... > > Great catch. No one has complained about this, so clearly it's OK for > font-lock-keywords-case-fold-search to be nil. I removed the bogus > 8-year-old setting of font-lock-keywords-case-fold-search. But that's not quite right, not sure about the standard, but there are lisps that are case insensitive: (DEFUN foo (arg) blah) ought to be fontified the same was as: (defun foo (arg) blah) From unknown Mon Jun 23 04:11:51 2025 X-Loop: don@donarmstrong.com Subject: bug#1297: font-lock-keywords-case-fold-search doc and usage Reply-To: Chong Yidong , 1297@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 03 Nov 2008 15:25:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1297 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1297-submit@emacsbugs.donarmstrong.com id=B1297.122572558011295 (code B ref 1297); Mon, 03 Nov 2008 15:25:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1297) by emacsbugs.donarmstrong.com; 3 Nov 2008 15:19:40 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA3FJb3B011289 for <1297@emacsbugs.donarmstrong.com>; Mon, 3 Nov 2008 07:19:38 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id E56B157E1B7; Mon, 3 Nov 2008 10:19:45 -0500 (EST) From: Chong Yidong To: Dan Nicolaescu Cc: 1297@debbugs.gnu.org References: <87od0xh600.fsf@cyd.mit.edu> <200811030444.mA34i1oB000823@mothra.ics.uci.edu> Date: Mon, 03 Nov 2008 10:19:45 -0500 In-Reply-To: <200811030444.mA34i1oB000823@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 2 Nov 2008 20:44:01 -0800 (PST)") Message-ID: <8763n4ltv2.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Dan Nicolaescu writes: > > Great catch. No one has complained about this, so clearly it's OK for > > font-lock-keywords-case-fold-search to be nil. I removed the bogus > > 8-year-old setting of font-lock-keywords-case-fold-search. > > But that's not quite right, not sure about the standard, but there are > lisps that are case insensitive: > > (DEFUN foo (arg) > blah) > > ought to be fontified the same was as: > > (defun foo (arg) > blah) We can put this in the wishlist. I don't see any reason to rock this particular boat right now. From unknown Mon Jun 23 04:11:51 2025 X-Loop: don@donarmstrong.com Subject: bug#1297: font-lock-keywords-case-fold-search doc and usage Reply-To: Dan Nicolaescu , 1297@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 04 Nov 2008 07:30:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1297 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1297-submit@emacsbugs.donarmstrong.com id=B1297.122578339626108 (code B ref 1297); Tue, 04 Nov 2008 07:30:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.4 required=4.0 tests=AWL,BAYES_00,FOURLA, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1297) by emacsbugs.donarmstrong.com; 4 Nov 2008 07:23:16 +0000 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA47NDT6026102 for <1297@emacsbugs.donarmstrong.com>; Mon, 3 Nov 2008 23:23:14 -0800 Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mA47MsfW005536; Mon, 3 Nov 2008 23:22:55 -0800 (PST) Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mA47Ms3q020156; Mon, 3 Nov 2008 23:22:54 -0800 (PST) Date: Mon, 3 Nov 2008 23:22:54 -0800 (PST) Message-Id: <200811040722.mA47Ms3q020156@mothra.ics.uci.edu> From: Dan Nicolaescu To: Chong Yidong Cc: 1297@debbugs.gnu.org References: <87od0xh600.fsf@cyd.mit.edu> <200811030444.mA34i1oB000823@mothra.ics.uci.edu> <8763n4ltv2.fsf@cyd.mit.edu> In-Reply-To: <8763n4ltv2.fsf@cyd.mit.edu> (Chong Yidong's message of "Mon, 03 Nov 2008 10:19:45 -0500") Lines: 57 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mA47MsfW005536 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu Chong Yidong writes: > Dan Nicolaescu writes: > > > > Great catch. No one has complained about this, so clearly it's OK for > > > font-lock-keywords-case-fold-search to be nil. I removed the bogus > > > 8-year-old setting of font-lock-keywords-case-fold-search. > > > > But that's not quite right, not sure about the standard, but there are > > lisps that are case insensitive: > > > > (DEFUN foo (arg) > > blah) > > > > ought to be fontified the same was as: > > > > (defun foo (arg) > > blah) > > We can put this in the wishlist. I don't see any reason to rock this > particular boat right now. It's easier to fix than to write a wishlist item --- lisp-mode.el.~1.230.~ 2008-11-02 21:49:24.000000000 -0800 +++ lisp-mode.el 2008-11-03 23:13:38.000000000 -0800 @@ -195,7 +195,8 @@ ;; The LISP-SYNTAX argument is used by code in inf-lisp.el and is ;; (uselessly) passed from pp.el, chistory.el, gnus-kill.el and score-mode.el -(defun lisp-mode-variables (&optional lisp-syntax) +;; KEYWORDS-CASE-SENSITIVE means that for font-lock keywords will not be case sensitive. +(defun lisp-mode-variables (&optional lisp-syntax keywords-case-insensitive) (when lisp-syntax (set-syntax-table lisp-mode-syntax-table)) (setq local-abbrev-table lisp-mode-abbrev-table) @@ -241,9 +242,9 @@ (setq multibyte-syntax-as-symbol t) (set (make-local-variable 'syntax-begin-function) 'beginning-of-defun) (setq font-lock-defaults - '((lisp-font-lock-keywords + `((lisp-font-lock-keywords lisp-font-lock-keywords-1 lisp-font-lock-keywords-2) - nil nil (("+-*/.<>=!?$%_&~^:@" . "w")) nil + nil ,keywords-case-insensitive (("+-*/.<>=!?$%_&~^:@" . "w")) nil (font-lock-mark-block-function . mark-defun) (font-lock-syntactic-face-function . lisp-font-lock-syntactic-face-function)))) @@ -464,7 +465,7 @@ if that value is non-nil." (use-local-map lisp-mode-map) (setq major-mode 'lisp-mode) (setq mode-name "Lisp") - (lisp-mode-variables) + (lisp-mode-variables nil t) (make-local-variable 'comment-start-skip) (setq comment-start-skip "\\(\\(^\\|[^\\\\\n]\\)\\(\\\\\\\\\\)*\\)\\(;+\\|#|\\) *")