GNU bug report logs - #12963
Fwd: Small modification to sh-script, to cover unsupported case label

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12963 in the body.
You can then email your comments to 12963 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Pfeiffer <occitan <at> t-online.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Ivan Kelly <ivan <at> ivankelly.net>
Subject: Fwd: Small modification to sh-script, to cover unsupported case label
Date: Thu, 22 Nov 2012 23:31:37 +0100

[Message part 1 (text/plain, inline)]

-------- Original Message --------
Subject: 	Small modification to sh-script, to cover unsupported case label
Date: 	Thu, 22 Nov 2012 15:53:25 +0000
From: 	Ivan Kelly <ivan <at> ivankelly.net>
To: 	Daniel Pfeiffer <occitan <at> esperanto.org>



Hi,

I ran into an issue with the sh-mode today with case labels.
case $X in
    foo)
        do_something
        ;;
    arg=*)
        do_something_else_based_on_arg
        ;;
    *)
        default
        ;;
esac

Indention will mess up on the second label, due to the =
This can be fixed by adding a = to the skip-chars-backwards in
sh-font-lock-parens;

i.e.
(defun sh-font-lock-paren (start)
  (save-excursion
    (goto-char start)
    ;; Skip through all patterns
    (while
      (progn
        (forward-comment (- (point-max)))
        ;; Skip through one pattern
        (while
          (or (/= 0 (skip-syntax-backward "w_"))
          (/= 0 (skip-chars-backward "?[]*@/\\="))
            (and (sh-is-quoted-p (1- (point)))
...

Also, I'm finding indent-tabs-mode is being reset by sh-mode. Do you
know what could be causing this?

Regards
Ivan

[Message part 2 (text/html, inline)]

Message #8 received at 12963 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: occitan <at> esperanto.org
Cc: Ivan Kelly <ivan <at> ivankelly.net>, 12963 <at> debbugs.gnu.org
Subject: Re: bug#12963: Fwd: Small modification to sh-script,
	to cover unsupported case label
Date: Thu, 22 Nov 2012 21:16:48 -0500

> Indention will mess up on the second label, due to the =
> This can be fixed by adding a = to the skip-chars-backwards in
> sh-font-lock-parens;

This already works correctly in Emacs-24, so I suggest you upgrade.

> Also, I'm finding indent-tabs-mode is being reset by sh-mode.  Do you
> know what could be causing this?

AFAICT sh-script.el does not touch indent-tabs-mode (neither the most
recent version, nor the version in Emacs-23).  But I'm not exactly sure
what you mean by "being reset".


        Stefan

Message #11 received at 12963 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Ivan Kelly <ivan+gambit <at> bleurgh.com>
Cc: occitan <at> esperanto.org, 12963 <at> debbugs.gnu.org
Subject: Re: bug#12963: Fwd: Small modification to sh-script,
	to cover unsupported case label
Date: Fri, 23 Nov 2012 10:53:18 -0500

> By being reset, I mean I have a hook 
> (add-hook 'sh-mode-hook '(lambda () (setq indent-tabs-mode nil)))
> I open a sh file, and when I look at the value of indent-tabs-mode,
> it's t.

I just tried

   % emacs23 -Q --eval "(add-hook 'sh-mode-hook (lambda () (setq indent-tabs-mode nil)))" test/indent/shell.sh

and C-h v indent-tabs-mode tells me it's nil in this buffer.
I suggest you add a (message "here I am") inside the above lambda (and
I also suggest you don't quote your lambdas with "'") to make sure it's
actually run.
   
> It may be something else that's borking it, but it works fine in other
> modes (java, c++). Is there a way to instrument a variable so that I
> can see when it gets changed?

No, but a binary search in your .emacs should quickly find the culprit.


        Stefan

Message #14 received at 12963 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Kelly <ivan+gambit <at> bleurgh.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: occitan <at> esperanto.org, 12963 <at> debbugs.gnu.org
Subject: Re: bug#12963: Fwd: Small modification to sh-script, to cover
	unsupported case label
Date: Fri, 23 Nov 2012 09:04:53 +0000

On Thu, Nov 22, 2012 at 09:16:48PM -0500, Stefan Monnier wrote:
> > Indention will mess up on the second label, due to the =
> > This can be fixed by adding a = to the skip-chars-backwards in
> > sh-font-lock-parens;
> 
> This already works correctly in Emacs-24, so I suggest you upgrade.
Ah ok, I'm using Emacs-23 here, and was pulling trunk from bzr but it
was taking a long time, so I just decided to email the fix.

> 
> > Also, I'm finding indent-tabs-mode is being reset by sh-mode.  Do you
> > know what could be causing this?
> 
> AFAICT sh-script.el does not touch indent-tabs-mode (neither the most
> recent version, nor the version in Emacs-23).  But I'm not exactly sure
> what you mean by "being reset".
By being reset, I mean I have a hook 
(add-hook 'sh-mode-hook '(lambda () (setq indent-tabs-mode nil)))

I open a sh file, and when I look at the value of indent-tabs-mode,
it's t.

It may be something else that's borking it, but it works fine in other
modes (java, c++). Is there a way to instrument a variable so that I
can see when it gets changed?

-Ivan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.