GNU bug report logs - #12915
24.2.50; Visiting a file via drag-and-drop should add it to the history of visited files

Previous Next

Package: emacs;

Reported by: Dani Moncayo <dmoncayo <at> gmail.com>

Date: Sat, 17 Nov 2012 13:09:01 UTC

Severity: wishlist

Merged with 3909

Found in version 24.2.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Juri Linkov'" <juri <at> jurta.org>
Cc: 12915 <at> debbugs.gnu.org, 'Chong Yidong' <cyd <at> gnu.org>, 'Dani Moncayo' <dmoncayo <at> gmail.com>
Subject: bug#12915: 24.2.50; Visiting a file via drag-and-drop should add it to the history ofvisited files
Date: Tue, 15 Jan 2013 07:07:59 -0800
> > `file-name-history' was designed to be augmented by 
> > `read-file-name', whenever a file name is input.  That includes
> > commands that do not display/visit the file.
> > This way of interactively choosing files should not be 
> > ignored, just because someone finds an easy way to hook history
> > augmentation into file-buffer display.
> 
> A new variable (e.g. `file-name-history-variable') could be introduced
> to hold the name of the history variable.  The default would be the
> currently existing `file-name-history'.  And the other possible value
> would be a new history variable (e.g. `file-name-extended-history')
> that will collect all visited/displayed file names like:
> 
> (defvar file-name-history nil
>   "History list of file names entered in the minibuffer.")
> 
> (defvar file-name-extended-history nil
>   "History list of files visited/displayed in the current session.")
> 
> (defcustom file-name-history-variable 'file-name-history
>   "History list to use in the minibuffer that reads a file name.
> The value of this variable should be a symbol; that symbol
> is used as a variable to hold a history list for the file names."
>   :group 'files
>   :type 'symbol)
> 
> Then the users would be able to customize it to 
> `file-name-extended-history':
> 
> (custom-set-variables
>  '(file-name-history-variable file-name-extended-history))

Having separate variables does not deal with the heart of the problem being
discussed.

`read-file-name' already adds correctly to the history.  The problem is that
some commands that let users choose files without entering a name - i.e., which
do _not_ use `read-file-name', should also (optionally) augment the history.

A mouse-click or menu command that just wraps a command that if called
interactively would use `read-file-name' should itself (optionally) augment the
history.





This bug report was last modified 3 years and 304 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.