Subject: bug#12913: closed (Re: bug#12913: [patch] an overlooked string in 'uptime')

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 12 Jan 2013 13:38:10 +0000

Your bug report

#12913: [patch] an overlooked string in 'uptime'

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
12913: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12913
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#12913: [patch] an overlooked string in 'uptime'
From: Pádraig Brady <[email-masked]>
To: Benno Schulenberg <[email-masked]>
Cc: [email-masked]
Date: Sat, 12 Jan 2013 13:37:13 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

On 11/17/2012 10:56 AM, Benno Schulenberg wrote:
>  From 855f5c860acb350125476765cf064f6ccc4d2aaa Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg<[email-masked]>
> Date: Sat, 17 Nov 2012 11:49:21 +0100
> Subject: [PATCH] uptime: gettextize an overlooked string, and normalize another
>
> * src/uptime.c: Add calls to gettext() and select_plural().
> ---
>   src/uptime.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/uptime.c b/src/uptime.c
> index f8c7cfa..1bef1cb 100644
> --- a/src/uptime.c
> +++ b/src/uptime.c
> @@ -146,9 +146,9 @@ print_uptime (size_t n, const STRUCT_UTMP *this)
>                             select_plural (updays)),
>                   updays, uphours, upmins);
>         else
> -        printf ("up  %2d:%02d,  ", uphours, upmins);
> +        printf (_("up  %2d:%02d,  "), uphours, upmins);
>       }
> -  printf (ngettext ("%lu user", "%lu users", entries),
> +  printf (ngettext ("%lu user", "%lu users", select_plural (entries)),
>             (unsigned long int) entries);
>
>     loads = getloadavg (avg, 3);
> -- 1.7.0.4

pushed

thanks,
Pádraig.

Subject: [patch] an overlooked string in 'uptime'
From: Benno Schulenberg <[email-masked]>
To: Coreutils <[email-masked]>
Date: Sat, 17 Nov 2012 11:56:57 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Well, tiny patch says everything.

Benno

-- 
http://www.fastmail.fm - One of many happy users:
  http://www.fastmail.fm/help/overview_quotes.html

From 855f5c860acb350125476765cf064f6ccc4d2aaa Mon Sep 17 00:00:00 2001
From: Benno Schulenberg <[email-masked]>
Date: Sat, 17 Nov 2012 11:49:21 +0100
Subject: [PATCH] uptime: gettextize an overlooked string, and normalize another

* src/uptime.c: Add calls to gettext() and select_plural().
---
 src/uptime.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/uptime.c b/src/uptime.c
index f8c7cfa..1bef1cb 100644
--- a/src/uptime.c
+++ b/src/uptime.c
@@ -146,9 +146,9 @@ print_uptime (size_t n, const STRUCT_UTMP *this)
                           select_plural (updays)),
                 updays, uphours, upmins);
       else
-        printf ("up  %2d:%02d,  ", uphours, upmins);
+        printf (_("up  %2d:%02d,  "), uphours, upmins);
     }
-  printf (ngettext ("%lu user", "%lu users", entries),
+  printf (ngettext ("%lu user", "%lu users", select_plural (entries)),
           (unsigned long int) entries);
 
   loads = getloadavg (avg, 3);
-- 
1.7.0.4