GNU bug report logs - #12899
Build failure from latest master

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12899 in the body.
You can then email your comments to 12899 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: Build failure from latest master
Date: Thu, 15 Nov 2012 19:24:53 +0100

In a freshly-cloned repository on Debian with GNU make 3.82 and
gcc 4.7.2.:

  $ ./bootstrap && ./configure
  ... [all is ok]
  $ make all
    ...
    CC       src/echo.o
    CCLD     src/echo
    CC       src/env.o
    CCLD     src/env
    CC       src/expand.o
    CCLD     src/expand
    CC       src/expr.o
    CCLD     src/expr
    CC       src/factor.o
  src/factor.c:650:20: fatal error: primes.h: No such file or directory
  compilation terminated.
  make[2]: *** [src/factor.o] Error 1

Am I the only one encountering such failures?  If yes, I'll provide
more information about my environment in order to help debugging this.

Regards,
  Stefano

Message #8 received at 12899 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: 12899 <at> debbugs.gnu.org
Subject: Re: bug#12899: Build failure from latest master
Date: Thu, 15 Nov 2012 19:36:47 +0100

On 11/15/2012 07:24 PM, Stefano Lattarini wrote:
> In a freshly-cloned repository on Debian with GNU make 3.82 and
> gcc 4.7.2.:
> 
>   $ ./bootstrap && ./configure
>   ... [all is ok]
>   $ make all
>     ...
>     CC       src/echo.o
>     CCLD     src/echo
>     CC       src/env.o
>     CCLD     src/env
>     CC       src/expand.o
>     CCLD     src/expand
>     CC       src/expr.o
>     CCLD     src/expr
>     CC       src/factor.o
>   src/factor.c:650:20: fatal error: primes.h: No such file or directory
>   compilation terminated.
>   make[2]: *** [src/factor.o] Error 1
>
The patch below seems to solve the issue.  Just let me run a complete
bootstrap to ensure this is the case ...

---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ----

From 0d1064cf32327fc0f2c422306d35eceb6334336d Mon Sep 17 00:00:00 2001
Message-Id: <0d1064cf32327fc0f2c422306d35eceb6334336d.1353004592.git.stefano.lattarini <at> gmail.com>
From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Date: Thu, 15 Nov 2012 19:36:21 +0100
Subject: [PATCH] build: fix build failures from pristine checkout

Fixed coreutils bug#12899.

* src/local.mk (BUILT_SOURCES): Add '$(top_srcdir)/src/primes.h'.
---
 src/local.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/local.mk b/src/local.mk
index 02a9bf5..337d005 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -386,6 +386,7 @@ src/dircolors.h: src/dcgen src/dircolors.hin
 # insist that maintainers must build on hosts that support the widest
 # known ints (currently 128-bit).
 MAINTAINERCLEANFILES += $(top_srcdir)/src/primes.h
+BUILT_SOURCES += $(top_srcdir)/src/primes.h
 $(top_srcdir)/src/primes.h:
 	$(MAKE) src/make-prime-list
 	$(AM_V_GEN)rm -f $@ $@-t
-- 
1.8.0.150.gb0b00a3

Message #11 received at 12899 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 12899 <at> debbugs.gnu.org
Subject: Re: bug#12899: Build failure from latest master
Date: Thu, 15 Nov 2012 13:03:13 -0800

Thanks, wouldn't the following be a bit cleaner,
since MAINTAINERCLEANFILES contains BUILT_SOURCES?

diff --git a/src/local.mk b/src/local.mk
index 02a9bf5..ead3b8b 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -385,7 +385,7 @@ src/dircolors.h: src/dcgen src/dircolors.hin
 # built only if absent.  It is not cleaned because we don't want to
 # insist that maintainers must build on hosts that support the widest
 # known ints (currently 128-bit).
-MAINTAINERCLEANFILES += $(top_srcdir)/src/primes.h
+BUILT_SOURCES += $(top_srcdir)/src/primes.h
 $(top_srcdir)/src/primes.h:
 	$(MAKE) src/make-prime-list
 	$(AM_V_GEN)rm -f $@ $@-t

Message #14 received at 12899 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: 12899 <at> debbugs.gnu.org
Subject: Re: bug#12899: Build failure from latest master
Date: Thu, 15 Nov 2012 22:05:22 +0100

On 11/15/2012 07:36 PM, Stefano Lattarini wrote:
>
> The patch below seems to solve the issue.  Just let me run a complete
> bootstrap to ensure this is the case ...
> 
Yep, it works.  But I don't have pushing rights, so someone will have
to apply it for me.

Regards,
  Stefano

Message #17 received at 12899 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 12899 <at> debbugs.gnu.org
Subject: Re: bug#12899: Build failure from latest master
Date: Thu, 15 Nov 2012 22:08:30 +0100

Hi Paul, thanks for the quick feedback.

On 11/15/2012 10:03 PM, Paul Eggert wrote:
> Thanks, wouldn't the following be a bit cleaner,
> since MAINTAINERCLEANFILES contains BUILT_SOURCES?
>
Possibly yes, but since this behaviour is not documented in the Automake
manual, I'd marginally (60-40) prefer not rely on it.  Not a big deal
in any case, so feel free to mend my patch if you like, with my ACK.

Thanks,
  Stefano

Message #20 received at 12899 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, 12899 <at> debbugs.gnu.org
Subject: Re: bug#12899: Build failure from latest master
Date: Fri, 16 Nov 2012 02:44:48 +0100

Stefano Lattarini wrote:

> Hi Paul, thanks for the quick feedback.
>
> On 11/15/2012 10:03 PM, Paul Eggert wrote:
>> Thanks, wouldn't the following be a bit cleaner,
>> since MAINTAINERCLEANFILES contains BUILT_SOURCES?
>>
> Possibly yes, but since this behaviour is not documented in the Automake
> manual, I'd marginally (60-40) prefer not rely on it.  Not a big deal
> in any case, so feel free to mend my patch if you like, with my ACK.

I too prefer to use BUILT_SOURCES, and using it here is
consistent with the numerous other uses in that file.

Which behavior is not documented?
The MAINTAINERCLEANFILES-containing-BUILT_SOURCES is done
via this in src/local.mk:

  MAINTAINERCLEANFILES += $(BUILT_SOURCES)

Message #23 received at 12899 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, 12899 <at> debbugs.gnu.org
Subject: Re: bug#12899: Build failure from latest master
Date: Fri, 16 Nov 2012 10:01:07 +0100

On 11/16/2012 02:44 AM, Jim Meyering wrote:
> Stefano Lattarini wrote:
> 
>> Hi Paul, thanks for the quick feedback.
>>
>> On 11/15/2012 10:03 PM, Paul Eggert wrote:
>>> Thanks, wouldn't the following be a bit cleaner,
>>> since MAINTAINERCLEANFILES contains BUILT_SOURCES?
>>>
>> Possibly yes, but since this behaviour is not documented in the Automake
>> manual, I'd marginally (60-40) prefer not rely on it.  Not a big deal
>> in any case, so feel free to mend my patch if you like, with my ACK.
> 
> I too prefer to use BUILT_SOURCES, and using it here is
> consistent with the numerous other uses in that file.
> 
> Which behavior is not documented?
>
The fact that $(BUILT_SOURCES) is automatically cleaned by the
Automake-generated 'maintainer-clean rule'.

> The MAINTAINERCLEANFILES-containing-BUILT_SOURCES is done
> via this in src/local.mk:
>
>   MAINTAINERCLEANFILES += $(BUILT_SOURCES)
>
Ah, I didn't noticed that.  That I agree with Paul.  Could you (Paul
or Jim) tweak my patch accordingly, before pushing it?  Or should I
send a re-roll?

Thanks,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.