GNU bug report logs - #12890
read-face-attribute, face-valid-attribute-values do not handle all :underline etc forms

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12890 in the body.
You can then email your comments to 12890 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: read-face-attribute,
	face-valid-attribute-values do not handle all :underline etc forms
Date: Thu, 15 Nov 2012 02:39:16 -0500

Package: emacs
Version: 24.2.50

You can't use read-face-attribute to set list values for :box, :stipple,
or :underline:

emacs -Q --eval "(read-face-attribute 'underline :underline)"
Start to enter: (:color "red")
and get stopped with "no match" when you type the space.
If you force it with C-q space, it takes your input and returns it, but
silently does not actually set the :underline attribute to it.

This is because face-valid-attribute-values does not return such values.

This affects eg M-x set-face-underline.

Message #6 received at 12890 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 12890 <at> debbugs.gnu.org
Subject: Re: bug#12890: read-face-attribute, face-valid-attribute-values do
 not handle all :underline etc forms
Date: Tue, 10 May 2022 14:19:28 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> You can't use read-face-attribute to set list values for :box, :stipple,
> or :underline:
>
> emacs -Q --eval "(read-face-attribute 'underline :underline)"
> Start to enter: (:color "red")
> and get stopped with "no match" when you type the space.
> If you force it with C-q space, it takes your input and returns it, but
> silently does not actually set the :underline attribute to it.
>
> This is because face-valid-attribute-values does not return such values.
>
> This affects eg M-x set-face-underline.

I tried reproducing this in Emacs 29.  It does indeed still need `C-q'
to enter the space, but after doing that, it seems to actually do the
rest correctly.

I did:

M-x set-face-underline RET
default RET
(:colorC-q "red") RET

and the default face got a red underline.

The `C-q' should be fixed, but do you also see the same behaviour for
the rest?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 12890 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 12890 <at> debbugs.gnu.org
Subject: Re: bug#12890: read-face-attribute, face-valid-attribute-values do
 not handle all :underline etc forms
Date: Thu, 09 Jun 2022 16:08:40 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I tried reproducing this in Emacs 29.  It does indeed still need `C-q'
> to enter the space, but after doing that, it seems to actually do the
> rest correctly.
>
> I did:
>
> M-x set-face-underline RET
> default RET
> (:colorC-q "red") RET
>
> and the default face got a red underline.
>
> The `C-q' should be fixed, but do you also see the same behaviour for
> the rest?

Actually, I have no idea how to fix the `C-q' here.  We do want
completion because we want to complete over colour names, and (by
default) `SPC' does completion.

It might be nice to have the `SPC' in minibuffer-local-completion-map to
be more DWIM -- don't try to complete if it's "obvious" that the user
doesn't want completion.  Myself, I've disabled completion on `SPC'
because it's really annoying, but perhaps there is something we could do
here?  I.e., if there are no completions, then just insert a `SPC' and
make that the new default binding for `SPC' here?  

Because I think that would make usability here a lot better.  (It could
say "No completions; inserting space".)

Opinions?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 12890 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 12890 <at> debbugs.gnu.org
Subject: Re: bug#12890: read-face-attribute, face-valid-attribute-values do
 not handle all :underline etc forms
Date: Mon, 11 Jul 2022 15:12:37 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> It might be nice to have the `SPC' in minibuffer-local-completion-map to
> be more DWIM -- don't try to complete if it's "obvious" that the user
> doesn't want completion.  Myself, I've disabled completion on `SPC'
> because it's really annoying, but perhaps there is something we could do
> here?  I.e., if there are no completions, then just insert a `SPC' and
> make that the new default binding for `SPC' here?  
>
> Because I think that would make usability here a lot better.  (It could
> say "No completions; inserting space".)
>
> Opinions?

Thinking about this a bit more, I think it's likely that there are
people that are relying on SPC being bound to
`minibuffer-complete-word', and it would be too annoying to change this
behaviour (even when there are no completions to be had).

It could be added as an option, but I don't think it would be a very
popular option -- people that don't like the SPC behaviour already have

(define-key minibuffer-local-completion-map " " 'self-insert-command)

and the rest wouldn't want to use this, anyway.  So I'm closing this bug
report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.