GNU bug report logs - #12881
Assume at least POSIX.1-1988 for fcntl.h

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12881: closed (Assume at least POSIX.1-1988 for fcntl.h)
Date: Sat, 17 Nov 2012 22:19:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 17 Nov 2012 14:17:14 -0800
with message-id <50A80CEA.4030207 <at> cs.ucla.edu>
and subject line Re: Assume at least POSIX.1-1988 for fcntl.h
has caused the debbugs.gnu.org bug report #12881,
regarding Assume at least POSIX.1-1988 for fcntl.h
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12881: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12881
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-gnu-emacs <at> gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Assume at least POSIX.1-1988 for fcntl.h
Date: Tue, 13 Nov 2012 23:37:58 -0800

[Message part 3 (text/plain, inline)]

Tags: patch

On POSIXish hosts it's long been safe to assume at least
POSIX.1-1988, as the pre-POSIX platforms died out long ago.
Attached is a patch to simplify Emacs to assume this
for <fcntl.h>.  I haven't tested this on Windows but have
tried to make the Windows port work by renaming its O_NDELAY
flag to O_NONBLOCK, as POSIX standardized the spelling of this
flag to be O_NONBLOCK.  I'll CC: this patch to Eli to give
him a heads-up.  This patch is relative to trunk bzr 110892.

[fcntl.txt (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 12881-done <at> debbugs.gnu.org
Subject: Re: Assume at least POSIX.1-1988 for fcntl.h
Date: Sat, 17 Nov 2012 14:17:14 -0800

On 11/16/2012 01:49 AM, Eli Zaretskii wrote:
> I wonder how it compiled for you;
> presumably some other header on your platform includes fcntl.h
> internally

It's systty.h, which includes fcntl.h everywhere.
But it doesn't hurt to include it again, so I did that.
I took the other suggestions you made as well, except
that I moved the replacement definitions of O_RDWR and
O_NOCTTY into nt/inc/unistd.h rather than to some other
spot in term.c.  It's cleaner to define system macros
in our implementation of the system rather than in the
application.  In the longer run we may want to move those
macros to a new file that replaces fcntl.h, but that's
for another day.

I installed this as trunk bzr 110931 and am marking it as
done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.