From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 11 09:38:08 2012 Received: (at submit) by debbugs.gnu.org; 11 Nov 2012 14:38:08 +0000 Received: from localhost ([127.0.0.1]:33002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TXYfn-0001S3-Dl for submit@debbugs.gnu.org; Sun, 11 Nov 2012 09:38:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35328) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TXYfk-0001Rv-Nl for submit@debbugs.gnu.org; Sun, 11 Nov 2012 09:38:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXYfO-00089C-L0 for submit@debbugs.gnu.org; Sun, 11 Nov 2012 09:37:45 -0500 Received: from lists.gnu.org ([208.118.235.17]:47488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXYfO-00088z-Hi for submit@debbugs.gnu.org; Sun, 11 Nov 2012 09:37:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXYfL-0008G2-D0 for bug-gnu-emacs@gnu.org; Sun, 11 Nov 2012 09:37:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXYfI-000883-AT for bug-gnu-emacs@gnu.org; Sun, 11 Nov 2012 09:37:39 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:63370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXYfI-00087r-3L for bug-gnu-emacs@gnu.org; Sun, 11 Nov 2012 09:37:36 -0500 Received: by mail-ee0-f41.google.com with SMTP id c4so3516625eek.0 for ; Sun, 11 Nov 2012 06:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:user-agent:date:message-id:mime-version :content-type; bh=GjmghlgSyUg8LvBhNrMwNslN63R6ovo3xRhsNkFt1dk=; b=kWVlS0Elru7JEBkDt+0GyS6m7QKyI6qyL/Z6al9vkEJGtkkK/9uVi1aiM1ID4DgWeD 9WxUCFXv7HSLI7t18VFTkO5wF6YjDbf5mqPV2Mkd8jqFnn9rOdRrS08ShQ+NsRLbrYG0 7gZj5wbnlu+vKcmsXj0qJ9EhgDqXtUgPoV58eraETLFA1vpz9DmEjUfy8TmOJehTSzKi wwoCmZIsZgpchXTLCw7RD/nDZwKMTishqs6UCDiegVSMehwHhv64lNkMcsJl34VDf1of 2ifQmfNoTAqEB3+dBy0YwGCdJKJu9oEXFkv+2V42oUsrpCDDNVC6SUbTx/2Ch1cPRVcA vQFw== Received: by 10.14.223.199 with SMTP id v47mr53975147eep.45.1352644203314; Sun, 11 Nov 2012 06:30:03 -0800 (PST) Received: from lem (178-83-201-90.dynamic.hispeed.ch. [178.83.201.90]) by mx.google.com with ESMTPS id o47sm10099613eem.11.2012.11.11.06.30.01 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 11 Nov 2012 06:30:02 -0800 (PST) From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org Subject: wrong default value when completing in woman-file-name User-agent: mu4e 0.9.9.5-dev3; emacs 24.2.1 Date: Sun, 11 Nov 2012 15:30:00 +0100 Message-ID: <87d2zkfc0n.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) I don't use TAB to `minibuffer-complete' (I use and use C-i as a key combination that does not have anything to do with the Tab key). In `woman-file-name' TAB is unread, which in my case causes the previously selected file to become the initial input for `completing-read'. That file is the last man page I looked at, usually that is not the command I want to look at now. This means that I often get some bogus initial value in the minibuffer which I first have to delete, then I complete to get the common prefix, and only then I can actually select one of the files that correspond to the topic I want to look up. Could you please change this so that the key sequence actually used to invoke `minibuffer-complete' is unread instead of TAB (or just call `minibuffer-complete' explicitly?). Thanks, Jonas From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 11 10:55:14 2012 Received: (at 12861) by debbugs.gnu.org; 11 Nov 2012 15:55:14 +0000 Received: from localhost ([127.0.0.1]:33319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TXZsQ-0003Fn-DE for submit@debbugs.gnu.org; Sun, 11 Nov 2012 10:55:14 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:23450) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TXZsP-0003Fh-7R for 12861@debbugs.gnu.org; Sun, 11 Nov 2012 10:55:13 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09sr+ZY/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="206927770" Received: from 108-175-230-88.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([108.175.230.88]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Nov 2012 10:54:53 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 44556AE224; Sun, 11 Nov 2012 10:54:53 -0500 (EST) From: Stefan Monnier To: Jonas Bernoulli Subject: Re: bug#12861: wrong default value when completing in woman-file-name Message-ID: References: <87d2zkfc0n.fsf@bernoul.li> Date: Sun, 11 Nov 2012 10:54:53 -0500 In-Reply-To: <87d2zkfc0n.fsf@bernoul.li> (Jonas Bernoulli's message of "Sun, 11 Nov 2012 15:30:00 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12861 Cc: 12861@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > Could you please change this so that the key sequence actually used to > invoke `minibuffer-complete' is unread instead of TAB (or just call > `minibuffer-complete' explicitly?). Unreading events is nasty business. Sometimes it's hard to avoid, but I don't think it's justified here, indeed. The patch below should fix your problem, but could you confirm it provides the intended completion behavior? Stefan === modified file 'lisp/woman.el' --- lisp/woman.el 2012-10-29 10:30:11 +0000 +++ lisp/woman.el 2012-11-11 15:54:23 +0000 @@ -1303,12 +1303,11 @@ ((null (cdr files)) (car (car files))) ; only 1 file for topic. (t ;; Multiple files for topic, so must select 1. - ;; Unread the command event (TAB = ?\t = 9) that runs the command - ;; `minibuffer-complete' in order to automatically complete the - ;; minibuffer contents as far as possible. - (setq unread-command-events '(9)) ; and delete any type-ahead! + ;; Run the command `minibuffer-complete' in order to automatically + ;; complete the minibuffer contents as far as possible. + (minibuffer-with-setup-hook #'minibuffer-complete (completing-read "Manual file: " files nil 1 - (try-completion "" files) 'woman-file-history)))))) + (try-completion "" files) 'woman-file-history))))))) (defun woman-select (predicate list) "Select unique elements for which PREDICATE is true in LIST. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 12 17:15:52 2012 Received: (at 12861) by debbugs.gnu.org; 12 Nov 2012 22:15:52 +0000 Received: from localhost ([127.0.0.1]:36398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TY2IK-0006is-F6 for submit@debbugs.gnu.org; Mon, 12 Nov 2012 17:15:52 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]:53930) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TY2II-0006il-Jg for 12861@debbugs.gnu.org; Mon, 12 Nov 2012 17:15:51 -0500 Received: by mail-ee0-f44.google.com with SMTP id b47so931910eek.3 for <12861@debbugs.gnu.org>; Mon, 12 Nov 2012 14:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:user-agent:in-reply-to:date :message-id:mime-version:content-type; bh=VDDBnKXspmNNSWw2eS5YT0L4kwu3CsgqcNJmyPke/Wk=; b=fo6v7ZuTGfEaVcSdaJQoztCoz0C6pAg/ItG1fCvLL+nfUk2X1jGXbMYc5QVWPhuzHD U1DRYe53I/u1+x4UqvjkmUCzPymQxFIM7oC0or19/GLxw1WmMGpXO2aHkA2kCPAn2LHC iN8g/8R0zRIeHAwy80nGCc1F+MYVQCE3VYob5lYdbBoIaGLtJxdYi7Ppstai9ZITlA4p ml508f0dv4JNMiar5ezB5ZkfxeBBLPZSspLh+enDx1EZNkD0oPzfGZufcSbR9U/4nGfZ liXfnJYl2Dwzc9tjGzSq+My/uOh5uhqwEekaBbcSa/rU8bM7G+EGXj2kAHO2mpYBrAK0 cADg== Received: by 10.14.193.134 with SMTP id k6mr26302771een.15.1352758523559; Mon, 12 Nov 2012 14:15:23 -0800 (PST) Received: from lem (178-83-201-90.dynamic.hispeed.ch. [178.83.201.90]) by mx.google.com with ESMTPS id z43sm18527129een.16.2012.11.12.14.15.21 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 12 Nov 2012 14:15:22 -0800 (PST) From: Jonas Bernoulli To: "Stefan Monnier" Subject: Re: bug#12861: wrong default value when completing in woman-file-name References: <87d2zkfc0n.fsf@bernoul.li>, User-agent: mu4e 0.9.9.5-dev3; emacs 24.2.1 In-reply-to: Date: Mon, 12 Nov 2012 23:15:20 +0100 Message-ID: <877gpq79jb.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12861 Cc: 12861@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) Stefan Monnier writes: >> Could you please change this so that the key sequence actually used to >> invoke `minibuffer-complete' is unread instead of TAB (or just call >> `minibuffer-complete' explicitly?). > > The patch below should fix your problem, but could you confirm it > provides the intended completion behavior? With emacs -Q it works but with my configuration it doesn't. I think that again me using instead of TAB to complete causes this. I will let you know once I have verified this. The problem I see is that iff the selected topic is also the prefix of other available topics (e.g. git-prune[-packed]) then pressing when completing the *file-name* does not cause the *Completions* buffer to appear. When I do something before pressing (e.g. delete a character or C-h c to verify it is indeed bound to `minibuffer-complete') and *then* press then the completions are shown, just not when completing immediately. -- Jonas From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 13 12:02:27 2012 Received: (at 12861) by debbugs.gnu.org; 13 Nov 2012 17:02:27 +0000 Received: from localhost ([127.0.0.1]:39009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYJsZ-0002LB-8A for submit@debbugs.gnu.org; Tue, 13 Nov 2012 12:02:27 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:50299) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYJsX-0002L1-0w for 12861@debbugs.gnu.org; Tue, 13 Nov 2012 12:02:26 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id qADH1orM016748; Tue, 13 Nov 2012 12:01:50 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 5240BB4278; Tue, 13 Nov 2012 12:01:50 -0500 (EST) From: Stefan Monnier To: Jonas Bernoulli Subject: Re: bug#12861: wrong default value when completing in woman-file-name Message-ID: References: <87d2zkfc0n.fsf@bernoul.li> <877gpq79jb.fsf@bernoul.li> Date: Tue, 13 Nov 2012 12:01:50 -0500 In-Reply-To: <877gpq79jb.fsf@bernoul.li> (Jonas Bernoulli's message of "Mon, 12 Nov 2012 23:15:20 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4401=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4401> : streams <857622> : uri <1267121> X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 12861 Cc: 12861@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > With emacs -Q it works but with my configuration it doesn't. I think > that again me using instead of TAB to complete causes this. > I will let you know once I have verified this. Thanks. I've installed the patch because it's an improvement in any case. > The problem I see is that iff the selected topic is also the prefix of > other available topics (e.g. git-prune[-packed]) then pressing > when completing the *file-name* does not cause the *Completions* buffer > to appear. When I do something before pressing (e.g. delete a > character or C-h c to verify it is indeed bound to > `minibuffer-complete') and *then* press then the completions are > shown, just not when completing immediately. Hmm... it rings a very distant bell, but without a test-case I don't think I'll be able to attack this problem. Can you provide a stripped down version of your config along with a few steps to reproduce the problem? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 13 17:02:16 2012 Received: (at 12861) by debbugs.gnu.org; 13 Nov 2012 22:02:16 +0000 Received: from localhost ([127.0.0.1]:39602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYOYi-0004R0-4D for submit@debbugs.gnu.org; Tue, 13 Nov 2012 17:02:16 -0500 Received: from mail-ea0-f172.google.com ([209.85.215.172]:48710) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYOYf-0004Qs-1P for 12861@debbugs.gnu.org; Tue, 13 Nov 2012 17:02:14 -0500 Received: by mail-ea0-f172.google.com with SMTP id k13so3306160eaa.3 for <12861@debbugs.gnu.org>; Tue, 13 Nov 2012 14:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:user-agent:in-reply-to:date :message-id:mime-version:content-type; bh=6oaFY5c4xEIBVfiviq1MD/JUwrGB7ZHvXpW+2iEI+Sk=; b=B3o6HaQpURqtSsQLcxoOcKwkKmFaF6yEN9r3Sqa9nJW2Vily5gZh/nsL1HN2Q6lyeC mru3Gu82aoJSsJkYdZM5zxvguxvNfnvDpp0Q/PHWB5sHDruJG5gD3m0wAbIrBfbIw0CU zsHR47I0UWIEksDXP2zou7orL7KKamg32RZn4mCHL57on9pqtYVlE9nJk5aVrNEzeo7h 6oa3P6v5AlgvR9g5X/mTybiUXrXjfeLp7gZQOdyfxZAKTUsSswQtDd3gzwEcwA4FNm3H VpeCY3jo2K0JzPqaZZJQVR2NXsm/AwUT1IrBq8hlYETC1PTIbxfrPz3+QlEDsbNEYkCJ kwcg== Received: by 10.14.178.195 with SMTP id f43mr79621005eem.44.1352844100513; Tue, 13 Nov 2012 14:01:40 -0800 (PST) Received: from lem (178-83-201-90.dynamic.hispeed.ch. [178.83.201.90]) by mx.google.com with ESMTPS id i1sm25309630eeo.8.2012.11.13.14.01.39 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 13 Nov 2012 14:01:39 -0800 (PST) From: Jonas Bernoulli To: "Stefan Monnier" Subject: Re: bug#12861: wrong default value when completing in woman-file-name References: <87d2zkfc0n.fsf@bernoul.li>, , <877gpq79jb.fsf@bernoul.li>, User-agent: mu4e 0.9.9.5-dev3; emacs 24.3.50.1 In-reply-to: Date: Tue, 13 Nov 2012 23:01:38 +0100 Message-ID: <87vcd9w4al.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12861 Cc: 12861@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) Stefan Monnier writes: > I've installed the patch because it's an improvement in any case. The patch you installed is different from what you posted here. Which is good; with the installed patch completion works even when using to invoke minibuffer-complete. Thanks a lot, Jonas From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 07 23:14:03 2012 Received: (at control) by debbugs.gnu.org; 8 Dec 2012 04:14:03 +0000 Received: from localhost ([127.0.0.1]:59746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThBne-0000yb-TT for submit@debbugs.gnu.org; Fri, 07 Dec 2012 23:14:03 -0500 Received: from mail-da0-f44.google.com ([209.85.210.44]:52639) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThBnd-0000y6-8O for control@debbugs.gnu.org; Fri, 07 Dec 2012 23:14:01 -0500 Received: by mail-da0-f44.google.com with SMTP id z20so453761dae.3 for ; Fri, 07 Dec 2012 20:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=zZPyFCy/7X8WXGzA5bGsiZ0EdqtLIam39X7JELxFVNQ=; b=ghu+1GKcKfxb/xuRv8AFSDecJKiLPwaU7VhHqP9Frq/RSY0OmDDN6pSHMqiyBemuOR 2n0S9hLcGhWCazKEe740HsGlb3PFg0uz35Bd7rO++4NaRI7PzjPhqgDCT+igTTRY/nNn sXD4e+7FTdrMJt4n84lgHdFpWduHcy+vSYXqkH1tS76FqTx2rXa0hQfIQxG1MRoUEokj o2b570Xlz3a/5MuWJUk6J14gUXwyqgkBPjQz5iES+NwDN93ACo9JAZ/yVXZmzNSu3cOz pAQuhtzgVi2wvfMEANCV0dMhYA6f4nDiwlR4k/Bv/g+xjLsmYCXvuSW9h/bKp+cbgz1Q VTAg== Received: by 10.68.243.10 with SMTP id wu10mr21283672pbc.85.1354940018677; Fri, 07 Dec 2012 20:13:38 -0800 (PST) Received: from ulysses (cm107.delta179.maxonline.com.sg. [59.189.179.107]) by mx.google.com with ESMTPS id gu5sm7779066pbc.10.2012.12.07.20.13.35 (version=SSLv3 cipher=OTHER); Fri, 07 Dec 2012 20:13:37 -0800 (PST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 12861 Date: Sat, 08 Dec 2012 12:13:33 +0800 Message-ID: <87d2ylnpua.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) close 12861 thanks From unknown Sat Sep 13 12:32:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Jan 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator