From unknown Sat Sep 13 03:53:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12857: rcirc.el: make default PART and QUIT reasons customizable Resent-From: Daniel Ralston Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Nov 2012 23:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12857@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13525883819485 (code B ref -1); Sat, 10 Nov 2012 23:00:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Nov 2012 22:59:41 +0000 Received: from localhost ([127.0.0.1]:60216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TXK1d-0002Sw-0p for submit@debbugs.gnu.org; Sat, 10 Nov 2012 17:59:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54871) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TXIqg-0000np-Nt for submit@debbugs.gnu.org; Sat, 10 Nov 2012 16:44:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXIqO-0002Ue-Ly for submit@debbugs.gnu.org; Sat, 10 Nov 2012 16:44:03 -0500 Received: from lists.gnu.org ([208.118.235.17]:48276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXIqO-0002Ua-IF for submit@debbugs.gnu.org; Sat, 10 Nov 2012 16:44:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXIqL-0000u4-FH for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2012 16:44:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXIqI-0002Ta-DP for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2012 16:43:57 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:52427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXIqI-0002TW-6T for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2012 16:43:54 -0500 Received: by mail-pb0-f41.google.com with SMTP id rq2so3742689pbb.0 for ; Sat, 10 Nov 2012 13:43:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=6JadKpFfWlwGLwyHn0PIoTnr1tl+0EaMZxczxGVMSuI=; b=bFFLF1eygboogzyqM5RqN6AgopuUeaFH6JblielbiXj2iPjrVZ5i+fQXUmUZsS19wK ls1EzorbuL4SgGP+r2qt1AcDujqE5ndgyx/K7fIbEToAq/Rc1KN5uKeq2Ych//zcCllD TXhuy56DE+cuZ+DAdVtLabhkaepPT/0jqeRFrkYzvBkcnisAerdA4EUAmuPMdZaF270d JWbcL4zB0HDWj7RbICs8U3i/5zIqVwBlp9y19e54aDkxzrf0/TcnISiALeLEwI8FG/kv FNkVobm++bP1ReyXkDQCyzxom56a0ck6YMMNXYDrmg+kFpk1o1vaVV3r+ZiyPsZEAYOP 2TCA== MIME-Version: 1.0 Received: by 10.66.77.74 with SMTP id q10mr42840708paw.81.1352583832923; Sat, 10 Nov 2012 13:43:52 -0800 (PST) Received: by 10.66.219.5 with HTTP; Sat, 10 Nov 2012 13:43:52 -0800 (PST) Date: Sat, 10 Nov 2012 13:43:52 -0800 Message-ID: From: Daniel Ralston Content-Type: multipart/mixed; boundary=f46d042fdddee3ef3b04ce2af649 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Mailman-Approved-At: Sat, 10 Nov 2012 17:59:40 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) --f46d042fdddee3ef3b04ce2af649 Content-Type: text/plain; charset=ISO-8859-1 If no other reason is given for parting or quitting with rcirc-cmd-part or rcirc-cmd-quit, rcirc will use the value of rcirc-id-string: "rcirc on GNU Emacs ". Kinda stuffy. This patch adds two customizable variables to rcirc: rcirc-default-part-reason and rcirc-default-quit-reason. The above commands will use these variables as the default part/quit reason if they are set. If they are left nil, rcirc will fallback to its current behaviour, and use the value of rcirc-id-string. Changelog entry: 2012-11-10 Daniel Ralston * rcirc.el: Make the default PART and QUIT reasons used by rcirc-cmd-part and rcirc-cmd-quit customizable. (rcirc-default-part-reason,rcirc-default-quit-reason): New customizable vars. --f46d042fdddee3ef3b04ce2af649 Content-Type: application/octet-stream; name="rcirc-default-reasons.patch" Content-Disposition: attachment; filename="rcirc-default-reasons.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h9d97flk0 PT09IG1vZGlmaWVkIGZpbGUgJ2xpc3AvbmV0L3JjaXJjLmVsJwoqKiogbGlzcC9uZXQvcmNpcmMu ZWwJMjAxMi0xMC0yMyAxNTowNjowNyArMDAwMAotLS0gbGlzcC9uZXQvcmNpcmMuZWwJMjAxMi0x MS0xMCAyMDo0NzoyMSArMDAwMAoqKioqKioqKioqKioqKiogZm9yIGNvbm5lY3Rpb25zIHVzaW5n IFNTTC9UTFMuIgoqKiogMTM4LDE0MyAqKioqCi0tLSAxMzgsMTU1IC0tLS0KICAgIDp0eXBlICdz dHJpbmcKICAgIDpncm91cCAncmNpcmMpCiAgCisgKGRlZmN1c3RvbSByY2lyYy1kZWZhdWx0LXBh cnQtcmVhc29uIG5pbAorICAgIlRoZSBkZWZhdWx0IHJlYXNvbiB0byBzZW5kIHdoZW4gcGFydGlu ZyBmcm9tIGEgY2hhbm5lbC4gSWYKKyBuaWwsIHVzZSB0aGUgdmFsdWUgb2YgcmNpcmMtaWQtc3Ry aW5nIGluc3RlYWQuIgorICAgOnR5cGUgJ3N0cmluZworICAgOmdyb3VwICdyY2lyYykKKyAKKyAo ZGVmY3VzdG9tIHJjaXJjLWRlZmF1bHQtcXVpdC1yZWFzb24gbmlsCisgICAiVGhlIGRlZmF1bHQg cmVhc29uIHRvIHNlbmQgd2hlbiBxdWl0dGluZyBhIHNlcnZlci4gSWYgbmlsLCB1c2UKKyB0aGUg dmFsdWUgb2YgcmNpcmMtaWQtc3RyaW5nIGluc3RlYWQuIgorICAgOnR5cGUgJ3N0cmluZworICAg Omdyb3VwICdyY2lyYykKKyAKICAoZGVmY3VzdG9tIHJjaXJjLWZpbGwtZmxhZyB0CiAgICAiTm9u LW5pbCBtZWFucyBsaW5lLXdyYXAgbWVzc2FnZXMgcHJpbnRlZCBpbiBjaGFubmVsIGJ1ZmZlcnMu IgogICAgOnR5cGUgJ2Jvb2xlYW4KKioqKioqKioqKioqKioqIENIQU5ORUxTIGlzIGEgY29tbWEt IG9yIHNwYWNlLXNlcGFyYXRlZAoqKiogMjE5OSwyMjA1ICoqKioKICAgICJQYXJ0IENIQU5ORUwu IgogICAgKGludGVyYWN0aXZlICJzUGFydCBjaGFubmVsOiAiKQogICAgKGxldCAoKGNoYW5uZWwg KGlmICg+IChsZW5ndGggY2hhbm5lbCkgMCkgY2hhbm5lbCB0YXJnZXQpKSkKISAgICAgKHJjaXJj LXNlbmQtc3RyaW5nIHByb2Nlc3MgKGNvbmNhdCAiUEFSVCAiIGNoYW5uZWwgIiA6IiByY2lyYy1p ZC1zdHJpbmcpKSkpCiAgCiAgKGRlZnVuLXJjaXJjLWNvbW1hbmQgcXVpdCAocmVhc29uKQogICAg IlNlbmQgYSBxdWl0IG1lc3NhZ2UgdG8gc2VydmVyIHdpdGggUkVBU09OLiIKLS0tIDIyMTEsMjIx OSAtLS0tCiAgICAiUGFydCBDSEFOTkVMLiIKICAgIChpbnRlcmFjdGl2ZSAic1BhcnQgY2hhbm5l bDogIikKICAgIChsZXQgKChjaGFubmVsIChpZiAoPiAobGVuZ3RoIGNoYW5uZWwpIDApIGNoYW5u ZWwgdGFyZ2V0KSkpCiEgICAgIChyY2lyYy1zZW5kLXN0cmluZyBwcm9jZXNzIChjb25jYXQgIlBB UlQgIiBjaGFubmVsICIgOiIKISAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAob3IgcmNpcmMtZGVmYXVsdC1wYXJ0LXJlYXNvbgohICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICByY2lyYy1pZC1zdHJpbmcpKSkpKQogIAogIChkZWZ1bi1yY2ly Yy1jb21tYW5kIHF1aXQgKHJlYXNvbikKICAgICJTZW5kIGEgcXVpdCBtZXNzYWdlIHRvIHNlcnZl ciB3aXRoIFJFQVNPTi4iCioqKioqKioqKioqKioqKiBDSEFOTkVMUyBpcyBhIGNvbW1hLSBvciBz cGFjZS1zZXBhcmF0ZWQKKioqIDIyMDcsMjIxMyAqKioqCiAgICAocmNpcmMtc2VuZC1zdHJpbmcg cHJvY2VzcyAoY29uY2F0ICJRVUlUIDoiCiAgCQkJCSAgICAgKGlmIChub3QgKHplcm9wIChsZW5n dGggcmVhc29uKSkpCiAgCQkJCQkgcmVhc29uCiEgCQkJCSAgICAgICByY2lyYy1pZC1zdHJpbmcp KSkpCiAgCiAgKGRlZnVuLXJjaXJjLWNvbW1hbmQgbmljayAobmljaykKICAgICJDaGFuZ2Ugbmlj ayB0byBOSUNLLiIKLS0tIDIyMjEsMjIyOCAtLS0tCiAgICAocmNpcmMtc2VuZC1zdHJpbmcgcHJv Y2VzcyAoY29uY2F0ICJRVUlUIDoiCiAgCQkJCSAgICAgKGlmIChub3QgKHplcm9wIChsZW5ndGgg cmVhc29uKSkpCiAgCQkJCQkgcmVhc29uCiEgCQkJCSAgICAgICAob3IgcmNpcmMtZGVmYXVsdC1x dWl0LXJlYXNvbgohICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy Y2lyYy1pZC1zdHJpbmcpKSkpKQogIAogIChkZWZ1bi1yY2lyYy1jb21tYW5kIG5pY2sgKG5pY2sp CiAgICAiQ2hhbmdlIG5pY2sgdG8gTklDSy4iCgo= --f46d042fdddee3ef3b04ce2af649-- From unknown Sat Sep 13 03:53:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12857: rcirc.el: make default PART and QUIT reasons customizable References: In-Reply-To: Resent-From: Deniz Dogan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Nov 2012 17:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 12857@debbugs.gnu.org Received: via spool by 12857-submit@debbugs.gnu.org id=B12857.135369164324954 (code B ref 12857); Fri, 23 Nov 2012 17:28:01 +0000 Received: (at 12857) by debbugs.gnu.org; 23 Nov 2012 17:27:23 +0000 Received: from localhost ([127.0.0.1]:35185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tbx2B-0006UQ-DD for submit@debbugs.gnu.org; Fri, 23 Nov 2012 12:27:23 -0500 Received: from mxf1.bahnhof.se ([213.80.101.25]:62970) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tbx28-0006UI-9t for 12857@debbugs.gnu.org; Fri, 23 Nov 2012 12:27:21 -0500 Received: from localhost (mxf1.local [127.0.0.1]) by mxf1-reinject (Postfix) with ESMTP id AA4D31E320D for <12857@debbugs.gnu.org>; Fri, 23 Nov 2012 18:25:52 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MXF1) X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-99 required=5 tests=[none] Received: from mxf1.bahnhof.se ([127.0.0.1]) by localhost (mxf1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NOP8g1T87Blh for <12857@debbugs.gnu.org>; Fri, 23 Nov 2012 18:25:50 +0100 (CET) Received: from [192.168.1.2] (h-169-224.a336.priv.bahnhof.se [176.10.169.224]) by mxf1.bahnhof.se (Postfix) with ESMTP id 03E781E318C for <12857@debbugs.gnu.org>; Fri, 23 Nov 2012 18:25:49 +0100 (CET) Message-ID: <50AFB18A.8020806@dogan.se> Date: Fri, 23 Nov 2012 18:25:30 +0100 From: Deniz Dogan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) Hi, Daniel This is a good patch! In my opinion it would be nicer if we use a composite customization type for rcirc-default-part-reason and rcirc-default-quit-reason, letting the user choose between the default (rcirc-id-string) and a custom message. What do you think about this idea? Would you be willing to write a new patch implementing this instead? Cheers, Deniz From unknown Sat Sep 13 03:53:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable Resent-From: Daniel Ralston Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Dec 2012 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 12857@debbugs.gnu.org Cc: deniz@dogan.se Received: via spool by 12857-submit@debbugs.gnu.org id=B12857.13554111726907 (code B ref 12857); Thu, 13 Dec 2012 15:07:01 +0000 Received: (at 12857) by debbugs.gnu.org; 13 Dec 2012 15:06:12 +0000 Received: from localhost ([127.0.0.1]:41076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjAMW-0001nJ-6N for submit@debbugs.gnu.org; Thu, 13 Dec 2012 10:06:12 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36264) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjAMS-0001n9-Q9 for 12857@debbugs.gnu.org; Thu, 13 Dec 2012 10:06:10 -0500 Received: by mail-pa0-f44.google.com with SMTP id hz11so1600827pad.3 for <12857@debbugs.gnu.org>; Thu, 13 Dec 2012 07:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ljPunHLDj6sVfUQxBnKIS/3SEZLZ8OQojIvMgoYa6pk=; b=ctdZX3/iY6hAVvjd1IFT+Vg4RKsLUahVtKOonnujQEMWY9iMzk9gVNwfVPLg/dAICo TgNqZZ7LMeudP/LQ9GZQmSVRytvK32p391F+yRr/uyetgrUAc+hmsprWcUExJGz+Z30V BYA0VWDSA5M9UrAM9VpZxoPjr7d3L//c3tXfIWbdMaTKzYLWA0lFfE+ubZUj6aAMW9U+ SvHPtrxZOq77EvQD0HFrOhos3seTwoehGPBgA/3p/pSHvTyFPk49OpRPgJNjzodDUOkr 0qeuCiMu1xpvb7baxELAk3NNLa3GHtX4HjjMU0M3VqUC3cYaiEaEbcP+qfQ3yEl7EMTT /A2g== MIME-Version: 1.0 Received: by 10.68.189.65 with SMTP id gg1mr6318347pbc.57.1355411108819; Thu, 13 Dec 2012 07:05:08 -0800 (PST) Received: by 10.68.5.199 with HTTP; Thu, 13 Dec 2012 07:05:08 -0800 (PST) In-Reply-To: <50BE7E86.9020601@dogan.se> References: <50AFB18A.8020806@dogan.se> <50BE7E86.9020601@dogan.se> Date: Thu, 13 Dec 2012 07:05:08 -0800 Message-ID: From: Daniel Ralston Content-Type: multipart/mixed; boundary=e89a8ff1cae0aa72ad04d0bd3d73 X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) --e89a8ff1cae0aa72ad04d0bd3d73 Content-Type: multipart/alternative; boundary=e89a8ff1cae0aa72aa04d0bd3d71 --e89a8ff1cae0aa72aa04d0bd3d71 Content-Type: text/plain; charset=ISO-8859-1 Hi Deniz, Sorry for my glacially tardy response. That's a much cleaner way of doing it. I hadn't really looked into composite types before, so thanks for the suggestion! I have attached the new patch file to this message. Let me know what you think, and if you'd like me to tweak it any further. I'll try to respond more promptly next time. Daniel Changelog entry: 2012-11-10 Daniel Ralston * rcirc.el: Make the default PART and QUIT reasons used by rcirc-cmd-part and rcirc-cmd-quit customizable. (rcirc-default-part-reason,rcirc-default-quit-reason): New customizable vars. Subject: Re: rcirc.el: make default PART and QUIT reasons customizable > Date: Fri, 23 Nov 2012 18:25:30 +0100 > From: Deniz Dogan > To: 12857@debbugs.gnu.org > > Hi, Daniel > > This is a good patch! In my opinion it would be nicer if we use a > composite customization type for rcirc-default-part-reason and > rcirc-default-quit-reason, letting the user choose between the default > (rcirc-id-string) and a custom message. > > What do you think about this idea? Would you be willing to write a new > patch implementing this instead? > > Cheers, > Deniz > > > > --e89a8ff1cae0aa72aa04d0bd3d71 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Deniz,

Sorry for my glacially tardy response.
That's a muc= h cleaner way of doing it. I hadn't really looked into composite types = before, so thanks for the suggestion! I have attached the new patch file to= this message. Let me know what you think, and if you'd like me to twea= k it any further. I'll try to respond more promptly next time.

=A0=A0=A0 Daniel

Changelog entry:

2012-11-10 =A0Daniel Ra= lston =A0<Wubbulous@gmail.com= >

=A0 =A0 * rcirc.el: Make the default PART and QUIT reasons used= by
=A0 =A0 rcirc-cmd-part and rcirc-cmd-quit customizable.
=A0 =A0 (rcirc-default-part-reason,rcirc-default-quit-reason): New
=A0 = =A0 customizable vars.


Subject: Re: rcirc.el: make default PART and QUIT reasons customizable
Date: Fri, 23 Nov 2012 18:25:30 +0100
From: Deniz Dogan <d= eniz@dogan.se>
To: 12857@debbug= s.gnu.org

Hi, Daniel

This is a good patch! In my opinion it would be nicer if we use a
composite customization type for rcirc-default-part-reason and
rcirc-default-quit-reason, letting the user choose between the default
(rcirc-id-string) and a custom message.

What do you think about this idea? =A0Would you be willing to write a new patch implementing this instead?

Cheers,
Deniz




--e89a8ff1cae0aa72aa04d0bd3d71-- --e89a8ff1cae0aa72ad04d0bd3d73 Content-Type: application/octet-stream; name="rcirc-default-part-quit-reasons.patch" Content-Disposition: attachment; filename="rcirc-default-part-quit-reasons.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hao07fdm0 PT09IG1vZGlmaWVkIGZpbGUgJ2xpc3AvbmV0L3JjaXJjLmVsJwoqKiogbGlzcC9uZXQvcmNpcmMu ZWwJMjAxMi0xMC0yMyAxNTowNjowNyArMDAwMAotLS0gbGlzcC9uZXQvcmNpcmMuZWwJMjAxMi0x Mi0xMyAxNDo0MjoyNCArMDAwMAoqKioqKioqKioqKioqKioKKioqIDQ3LDUyICoqKioKLS0tIDQ3 LDU0IC0tLS0KICAocmVxdWlyZSAndGltZS1kYXRlKQogIChldmFsLXdoZW4tY29tcGlsZSAocmVx dWlyZSAnY2wpKQogIAorIChkZWZjb25zdCByY2lyYy1pZC1zdHJpbmcgKGNvbmNhdCAicmNpcmMg b24gR05VIEVtYWNzICIgZW1hY3MtdmVyc2lvbikpCisgCiAgKGRlZmdyb3VwIHJjaXJjIG5pbAog ICAgIlNpbXBsZSBJUkMgY2xpZW50LiIKICAgIDp2ZXJzaW9uICIyMi4xIgoqKioqKioqKioqKioq KiogZm9yIGNvbm5lY3Rpb25zIHVzaW5nIFNTTC9UTFMuIgoqKiogMTM4LDE0MyAqKioqCi0tLSAx NDAsMTU5IC0tLS0KICAgIDp0eXBlICdzdHJpbmcKICAgIDpncm91cCAncmNpcmMpCiAgCisgKGRl ZmN1c3RvbSByY2lyYy1kZWZhdWx0LXBhcnQtcmVhc29uIHJjaXJjLWlkLXN0cmluZworICAgIlRo ZSBkZWZhdWx0IHJlYXNvbiB0byBzZW5kIHdoZW4gcGFydGluZyBmcm9tIGEgY2hhbm5lbCwgd2hl bgorIG5vIHJlYXNvbiBpcyBleHBsaWNpdGx5IGdpdmVuLiIKKyAgIDp0eXBlIGAoY2hvaWNlIChj b25zdCA6dGFnICJWYWx1ZSBvZiBgcmNpcmMtaWQtc3RyaW5nJyIgLHJjaXJjLWlkLXN0cmluZykK KyAgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiQ3VzdG9tIHN0cmluZyIpKQorICAgOmdy b3VwICdyY2lyYykKKyAKKyAoZGVmY3VzdG9tIHJjaXJjLWRlZmF1bHQtcXVpdC1yZWFzb24gcmNp cmMtaWQtc3RyaW5nCisgICAiVGhlIGRlZmF1bHQgcmVhc29uIHRvIHNlbmQgd2hlbiBxdWl0dGlu ZyBhIHNlcnZlciwgd2hlbiBubworIHJlYXNvbiBpcyBleHBsaWNpdGx5IGdpdmVuLiIKKyAgIDp0 eXBlIGAoY2hvaWNlIChjb25zdCA6dGFnICJWYWx1ZSBvZiBgcmNpcmMtaWQtc3RyaW5nJyIgLHJj aXJjLWlkLXN0cmluZykKKyAgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiQ3VzdG9tIHN0 cmluZyIpKQorICAgOmdyb3VwICdyY2lyYykKKyAKICAoZGVmY3VzdG9tIHJjaXJjLWZpbGwtZmxh ZyB0CiAgICAiTm9uLW5pbCBtZWFucyBsaW5lLXdyYXAgbWVzc2FnZXMgcHJpbnRlZCBpbiBjaGFu bmVsIGJ1ZmZlcnMuIgogICAgOnR5cGUgJ2Jvb2xlYW4KKioqKioqKioqKioqKioqIHdpbGwgYmUg a2lsbGVkLiIKKioqIDQxMiw0MTkgKioqKgogIChkZWZ2YXIgcmNpcmMtdGltZW91dC1zZWNvbmRz IDYwMAogICAgIktpbGwgY29ubmVjdGlvbiBhZnRlciB0aGlzIG1hbnkgc2Vjb25kcyBpZiB0aGVy ZSBpcyBubyBhY3Rpdml0eS4iKQogIAotIChkZWZjb25zdCByY2lyYy1pZC1zdHJpbmcgKGNvbmNh dCAicmNpcmMgb24gR05VIEVtYWNzICIgZW1hY3MtdmVyc2lvbikpCi0gDAogIChkZWZ2YXIgcmNp cmMtc3RhcnR1cC1jaGFubmVscyBuaWwpCiAgCiAgKGRlZnZhciByY2lyYy1zZXJ2ZXItbmFtZS1o aXN0b3J5IG5pbAotLS0gNDI4LDQzMyAtLS0tCioqKioqKioqKioqKioqKiBDSEFOTkVMUyBpcyBh IGNvbW1hLSBvciBzcGFjZS1zZXBhcmF0ZWQKKioqIDIxOTksMjIwNSAqKioqCiAgICAiUGFydCBD SEFOTkVMLiIKICAgIChpbnRlcmFjdGl2ZSAic1BhcnQgY2hhbm5lbDogIikKICAgIChsZXQgKChj aGFubmVsIChpZiAoPiAobGVuZ3RoIGNoYW5uZWwpIDApIGNoYW5uZWwgdGFyZ2V0KSkpCiEgICAg IChyY2lyYy1zZW5kLXN0cmluZyBwcm9jZXNzIChjb25jYXQgIlBBUlQgIiBjaGFubmVsICIgOiIg cmNpcmMtaWQtc3RyaW5nKSkpKQogIAogIChkZWZ1bi1yY2lyYy1jb21tYW5kIHF1aXQgKHJlYXNv bikKICAgICJTZW5kIGEgcXVpdCBtZXNzYWdlIHRvIHNlcnZlciB3aXRoIFJFQVNPTi4iCi0tLSAy MjEzLDIyMjAgLS0tLQogICAgIlBhcnQgQ0hBTk5FTC4iCiAgICAoaW50ZXJhY3RpdmUgInNQYXJ0 IGNoYW5uZWw6ICIpCiAgICAobGV0ICgoY2hhbm5lbCAoaWYgKD4gKGxlbmd0aCBjaGFubmVsKSAw KSBjaGFubmVsIHRhcmdldCkpKQohICAgICAocmNpcmMtc2VuZC1zdHJpbmcgcHJvY2VzcyAoY29u Y2F0ICJQQVJUICIgY2hhbm5lbCAiIDoiCiEgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcmNpcmMtZGVmYXVsdC1wYXJ0LXJlYXNvbikpKSkKICAKICAoZGVmdW4tcmNpcmMt Y29tbWFuZCBxdWl0IChyZWFzb24pCiAgICAiU2VuZCBhIHF1aXQgbWVzc2FnZSB0byBzZXJ2ZXIg d2l0aCBSRUFTT04uIgoqKioqKioqKioqKioqKiogQ0hBTk5FTFMgaXMgYSBjb21tYS0gb3Igc3Bh Y2Utc2VwYXJhdGVkCioqKiAyMjA3LDIyMTMgKioqKgogICAgKHJjaXJjLXNlbmQtc3RyaW5nIHBy b2Nlc3MgKGNvbmNhdCAiUVVJVCA6IgogIAkJCQkgICAgIChpZiAobm90ICh6ZXJvcCAobGVuZ3Ro IHJlYXNvbikpKQogIAkJCQkJIHJlYXNvbgohIAkJCQkgICAgICAgcmNpcmMtaWQtc3RyaW5nKSkp KQogIAogIChkZWZ1bi1yY2lyYy1jb21tYW5kIG5pY2sgKG5pY2spCiAgICAiQ2hhbmdlIG5pY2sg dG8gTklDSy4iCi0tLSAyMjIyLDIyMjggLS0tLQogICAgKHJjaXJjLXNlbmQtc3RyaW5nIHByb2Nl c3MgKGNvbmNhdCAiUVVJVCA6IgogIAkJCQkgICAgIChpZiAobm90ICh6ZXJvcCAobGVuZ3RoIHJl YXNvbikpKQogIAkJCQkJIHJlYXNvbgohIAkJCQkgICAgICAgcmNpcmMtZGVmYXVsdC1xdWl0LXJl YXNvbikpKSkKICAKICAoZGVmdW4tcmNpcmMtY29tbWFuZCBuaWNrIChuaWNrKQogICAgIkNoYW5n ZSBuaWNrIHRvIE5JQ0suIgoK --e89a8ff1cae0aa72ad04d0bd3d73-- From unknown Sat Sep 13 03:53:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 06:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Ralston Cc: 12857@debbugs.gnu.org, deniz@dogan.se Received: via spool by 12857-submit@debbugs.gnu.org id=B12857.145629381031116 (code B ref 12857); Wed, 24 Feb 2016 06:04:02 +0000 Received: (at 12857) by debbugs.gnu.org; 24 Feb 2016 06:03:30 +0000 Received: from localhost ([127.0.0.1]:42291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYSXq-00085o-74 for submit@debbugs.gnu.org; Wed, 24 Feb 2016 01:03:30 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:56932) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYSXo-00085g-7t for 12857@debbugs.gnu.org; Wed, 24 Feb 2016 01:03:28 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYSXP-0002Zo-D0; Wed, 24 Feb 2016 07:03:04 +0100 From: Lars Ingebrigtsen References: <50AFB18A.8020806@dogan.se> <50BE7E86.9020601@dogan.se> Date: Wed, 24 Feb 2016 17:02:59 +1100 In-Reply-To: (Daniel Ralston's message of "Thu, 13 Dec 2012 07:05:08 -0800") Message-ID: <87fuwiejcc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYSXP-0002Zo-D0 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456898585.42678@senBuBNtYmWhYR1ims1xRw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Daniel Ralston writes: > Sorry for my glacially tardy response. > That's a much cleaner way of doing it. I hadn't really looked into composite types before, so thanks for the suggestion! I have attached > the new patch file to this message. Let me know what you think, and if you'd like me to tweak it any further. I'll try to respond more > promptly next time. > > Daniel > > Changelog entry: > > 2012-11-10 Daniel Ralston > > * rcirc.el: Make the default PART and QUIT reasons used by > rcirc-cmd-part and rcirc-cmd-quit customizable. > (rcirc-default-part-reason,rcirc-default-quit-reason): New > customizable vars. > > Subject: Re: rcirc.el: make default PART and QUIT reasons customizable > Date: Fri, 23 Nov 2012 18:25:30 +0100 > From: Deniz Dogan > To: 12857@debbug=, 12857@debbugs.gnu.org s.gnu.org That was three years ago. :-) Deniz, did you have a look at the respun patch, and does it look OK? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Sep 13 03:53:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jun 2019 00:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Ralston Cc: 12857@debbugs.gnu.org, deniz@dogan.se Received: via spool by 12857-submit@debbugs.gnu.org id=B12857.155943432124210 (code B ref 12857); Sun, 02 Jun 2019 00:12:02 +0000 Received: (at 12857) by debbugs.gnu.org; 2 Jun 2019 00:12:01 +0000 Received: from localhost ([127.0.0.1]:39035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXE6T-0006IQ-7V for submit@debbugs.gnu.org; Sat, 01 Jun 2019 20:12:01 -0400 Received: from mail-io1-f51.google.com ([209.85.166.51]:41556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXE6Q-0006I2-Vh; Sat, 01 Jun 2019 20:11:59 -0400 Received: by mail-io1-f51.google.com with SMTP id w25so11331591ioc.8; Sat, 01 Jun 2019 17:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rwu3bs5mtW/okOZHWNbP614XozxSAA0w1p0y+dbiwqA=; b=JSFk4jJ2nI/ZeFA+XnN0HG7M4S8UNlgncEEv7Nr5jNw6YB8DOQsltlm2Ek/UjndWBU Nq6o3L8Y0fDBUB2Vd5s2j43n+6ah8GraiamIncpvzMzWC3vOM8gVyQy+TmNZVo+Z2DzU xGiIyqVMF2MPxcYymVxpjG+Ez9g4KCiVqrXByZmJRKVZ/cZarqQDFh/ZPdkYd1BohSEq 38VkaWnxQi+syan/LG/ChoqN8JRpv+BJVA78wtgo54IyIHbT+lQWkebSQ26hUkFRv38B w4K0rJpNwWaaP79Lg6bVdKySkVW42b8APwqoQlQD1XuUt9n9LLA7wc41mqayBROok13x pHFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rwu3bs5mtW/okOZHWNbP614XozxSAA0w1p0y+dbiwqA=; b=qKvHo/rjIA3hnq6kfgtwJQyEcZ7VDEdXIBRVdOp0XVP7yw+Md8QfY88BRMF66jr4Yo uW53jN3i3Ya/0p/36DUIfviIwB1uZu2zU26/PnfA7J1UbbLr2Etjt1/Pl6c1dSYuzcQn p7no3n+AhWRL/NWk93OnR9C4N8+8CuJqPJJmU9QH/H8OBu0JLX3S3coad5cwFT2mkrSq ZAF5RKlV960ye5Wy9Oub1fLY5lQODhDLkR+9RogEn3MXN2bt28/zL4+fLOPWQSs2PkTt 9WSy+C69g/mX35/riBhXrtr+Eqjyok3axG6EIXGrBVoVxvNz+KweJOUwTmCXZCymkU0G 7vmg== X-Gm-Message-State: APjAAAVv60xcytHOIuYE0p/0yi+vv1bOZF3h4lsem0tktYHvEgCv5ZDX guG/tza19n1EKMwweTpTQbGRnAAM X-Google-Smtp-Source: APXvYqyk0b7NnzcnvfPcBAZU0sepi6UnomcRq1EEQf1PZKb1YUVi5oeB10jXAmxOFNWn93cR2EvZwQ== X-Received: by 2002:a6b:e711:: with SMTP id b17mr11319558ioh.3.1559434313140; Sat, 01 Jun 2019 17:11:53 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id 62sm4644186itx.8.2019.06.01.17.11.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Jun 2019 17:11:52 -0700 (PDT) From: Noam Postavsky References: <50AFB18A.8020806@dogan.se> <50BE7E86.9020601@dogan.se> Date: Sat, 01 Jun 2019 20:11:52 -0400 In-Reply-To: (Daniel Ralston's message of "Thu, 13 Dec 2012 07:05:08 -0800") Message-ID: <874l586e2f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 12857 fixed close 12857 27.1 quit Daniel Ralston writes: > That's a much cleaner way of doing it. I hadn't really looked into > composite types before, so thanks for the suggestion! >> This is a good patch! In my opinion it would be nicer if we use a >> composite customization type for rcirc-default-part-reason and >> rcirc-default-quit-reason, letting the user choose between the default >> (rcirc-id-string) and a custom message. I removed the part that puts the default into the customization type, since the customization machinery already handles default values just fine. Pushed to master, with followup NEWS entry. aa9d57eed1 2019-06-01T20:01:43-04:00 "; Add NEWS entry for previous change" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=aa9d57eed17ee6a8006c9cdd4f8636100482cd71 d3f14ffae4 2019-06-01T20:01:43-04:00 "Make rcirc PART and QUIT reasons customizable (Bug#12857)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d3f14ffae4078688a57acdff30fdd91747386f17