GNU bug report logs - #12836
automake-1.12 make check: FAIL:2

Previous Next

Package: automake;

Reported by: Tru Huynh <tru <at> pasteur.fr>

Date: Thu, 8 Nov 2012 16:57:02 UTC

Severity: minor

Tags: notabug

Done: Stefano Lattarini <stefano.lattarini <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12836 in the body.
You can then email your comments to 12836 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Thu, 08 Nov 2012 16:57:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tru Huynh <tru <at> pasteur.fr>:
New bug report received and forwarded. Copy sent to bug-automake <at> gnu.org. (Thu, 08 Nov 2012 16:57:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tru Huynh <tru <at> pasteur.fr>
To: bug-automake <at> gnu.org
Subject: automake-1.12 make check: FAIL:2
Date: Thu, 8 Nov 2012 15:10:29 +0100
[Message part 1 (text/plain, inline)]
Hello,

automake 1.12 fails 2 tests (autoconf version 2.69 used).
[tru <at> liberte automake-1.11.6]$ rpm -q kernel gcc
kernel-2.6.18-308.16.1.el5.x86_64
gcc-4.1.2-52.el5_8.1.x86_64
[tru <at> liberte automake-1.12]$  gcc -v
Using built-in specs.
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-libgcj-multifile --enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk --disable-dssi --disable-plugin --with-java-home=/usr/lib/jvm/java-1.4.2-gcj-1.4.2.0/jre --with-cpu=generic --host=x86_64-redhat-linux
Thread model: posix
gcc version 4.1.2 20080704 (Red Hat 4.1.2-52)
[tru <at> liberte automake-1.12]$ type autoconf
autoconf is /c5/shared/autoconf/2.69/bin/autoconf
[tru <at> liberte automake-1.12]$ autoconf -V
autoconf (GNU Autoconf) 2.69
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+/Autoconf: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>, <http://gnu.org/licenses/exceptions.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.
...

tar xzvf ~/sources/automake-1.12.tar.gz 
cd automake-1.12/
./configure --prefix=/c5/shared/automake/1.12
make && make install && make check

============================================================================
Testsuite summary for GNU Automake 1.12
============================================================================
# TOTAL: 2721
# PASS:  2474
# SKIP:  203
# XFAIL: 42
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to bug-automake <at> gnu.org
============================================================================

Best regards,

Tru
-- 
Dr Tru Huynh          | http://www.pasteur.fr/recherche/unites/Binfs/
mailto:tru <at> pasteur.fr | tel/fax +33 1 45 68 87 37/19
Institut Pasteur, 25-28 rue du Docteur Roux, 75724 Paris CEDEX 15 France  
[test-suite.log (text/plain, attachment)]
[config.status (text/plain, attachment)]
[config.log (text/plain, attachment)]

Information forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Thu, 08 Nov 2012 19:28:01 GMT) Full text and rfc822 format available.

Message #8 received at 12836 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Tru Huynh <tru <at> pasteur.fr>
Cc: 12836 <at> debbugs.gnu.org
Subject: Re: bug#12836: automake-1.12 make check: FAIL:2
Date: Thu, 08 Nov 2012 20:27:28 +0100
tags 12836 + moreinfo
severity 12836 minor
thanks

On 11/08/2012 03:10 PM, Tru Huynh wrote:
> Hello,
> 
Hi Tru, thanks for the report.

> automake 1.12 fails 2 tests (autoconf version 2.69 used).
> [tru <at> liberte automake-1.11.6]$ rpm -q kernel gcc
> kernel-2.6.18-308.16.1.el5.x86_64
> gcc-4.1.2-52.el5_8.1.x86_64
> [tru <at> liberte automake-1.12]$  gcc -v
> Using built-in specs.
> Target: x86_64-redhat-linux
> Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-libgcj-multifile --enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk --disable-dssi --disable-plugin --with-java-home=/usr/lib/jvm/java-1.4.2-gcj-1.4.2.0/jre --with-cpu=generic --host=x86_64-redhat-linux
> Thread model: posix
> gcc version 4.1.2 20080704 (Red Hat 4.1.2-52)
> [tru <at> liberte automake-1.12]$ type autoconf
> autoconf is /c5/shared/autoconf/2.69/bin/autoconf
> [tru <at> liberte automake-1.12]$ autoconf -V
> autoconf (GNU Autoconf) 2.69
> Copyright (C) 2012 Free Software Foundation, Inc.
> License GPLv3+/Autoconf: GNU GPL version 3 or later
> <http://gnu.org/licenses/gpl.html>, <http://gnu.org/licenses/exceptions.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> 
> Written by David J. MacKenzie and Akim Demaille.
> ...
> 
> tar xzvf ~/sources/automake-1.12.tar.gz 
> cd automake-1.12/
> ./configure --prefix=/c5/shared/automake/1.12
> make && make install && make check
> 
> ============================================================================
> Testsuite summary for GNU Automake 1.12
> ============================================================================
> # TOTAL: 2721
> # PASS:  2474
> # SKIP:  203
> # XFAIL: 42
> # FAIL:  2
> # XPASS: 0
> # ERROR: 0
> ============================================================================
> See ./test-suite.log
> Please report to bug-automake <at> gnu.org
> ============================================================================
> 
> Best regards,
> 
I've done several fixes to the Automake testsuite since 1.12 was released;
could you please try with the last released version (1.12.4) and see if
these issues persist?

Thanks,
  Stefano




Added tag(s) moreinfo. Request was from Stefano Lattarini <stefano.lattarini <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 08 Nov 2012 19:28:02 GMT) Full text and rfc822 format available.

Severity set to 'minor' from 'normal' Request was from Stefano Lattarini <stefano.lattarini <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 08 Nov 2012 19:28:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Thu, 08 Nov 2012 21:21:02 GMT) Full text and rfc822 format available.

Message #15 received at 12836 <at> debbugs.gnu.org (full text, mbox):

From: Tru Huynh <tru <at> pasteur.fr>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 12836 <at> debbugs.gnu.org
Subject: Re: bug#12836: automake-1.12 make check: FAIL:2
Date: Thu, 8 Nov 2012 22:17:38 +0100
[Message part 1 (text/plain, inline)]
On Thu, Nov 08, 2012 at 08:27:28PM +0100, Stefano Lattarini wrote:
> I've done several fixes to the Automake testsuite since 1.12 was released;
> could you please try with the last released version (1.12.4) and see if
> these issues persist?

sure:

tar xzvf ~/sources/automake-1.12.4.tar.gz 
cd automake-1.12.4/
./configure --prefix=/c5/shared/automake/1.12.4
make && make install && make check
....
============================================================================
Testsuite summary for GNU Automake 1.12.4
============================================================================
# TOTAL: 2633
# PASS:  2380
# SKIP:  211
# XFAIL: 40
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to bug-automake <at> gnu.org
============================================================================

In 1.12 the errors were:
FAIL: t/distcheck-override-infodir
FAIL: t/help2

One of the errors changed for 1.12.4:
FAIL: t/help2
FAIL: t/lex-header

I am attaching the full test-suite.log config.status config.log

Cheers,

Tru
-- 
Dr Tru Huynh          | http://www.pasteur.fr/recherche/unites/Binfs/
mailto:tru <at> pasteur.fr | tel/fax +33 1 45 68 87 37/19
Institut Pasteur, 25-28 rue du Docteur Roux, 75724 Paris CEDEX 15 France  
[config.log (text/plain, attachment)]
[config.status (text/plain, attachment)]
[test-suite.log (text/plain, attachment)]

Information forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Thu, 15 Nov 2012 16:26:02 GMT) Full text and rfc822 format available.

Message #18 received at 12836 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Tru Huynh <tru <at> pasteur.fr>
Cc: 12836 <at> debbugs.gnu.org
Subject: Re: bug#12836: automake-1.12 make check: FAIL:2
Date: Thu, 15 Nov 2012 17:24:56 +0100
Hi Tru, sorry for the further delay.

On 11/08/2012 10:17 PM, Tru Huynh wrote:
> On Thu, Nov 08, 2012 at 08:27:28PM +0100, Stefano Lattarini wrote:
>> I've done several fixes to the Automake testsuite since 1.12 was released;
>> could you please try with the last released version (1.12.4) and see if
>> these issues persist?
> 
> sure:
> 
> tar xzvf ~/sources/automake-1.12.4.tar.gz 
> cd automake-1.12.4/
> ./configure --prefix=/c5/shared/automake/1.12.4
> make && make install && make check
> ....
> ============================================================================
> Testsuite summary for GNU Automake 1.12.4
> ============================================================================
> # TOTAL: 2633
> # PASS:  2380
> # SKIP:  211
> # XFAIL: 40
> # FAIL:  2
> # XPASS: 0
> # ERROR: 0
> ============================================================================
> See ./test-suite.log
> Please report to bug-automake <at> gnu.org
> ============================================================================
> 

> FAIL: t/lex-header
> ==================
>
> lex-header: running flex --version
> flex version 2.5.4
>
Yikes!  According to what I see in <http://flex.sourceforge.net/>, this
flex version is fifteen years old!  The failure here is due to the fact
that we are assuming a flex feature (support for the "--header-file"
option) that is not present in such an old version.  So we can consider
this a spurious error; and the fact that all the other test cases on lex
support have passed shows that Automake-generated rules can actually
work very well even with such an old flex version.

(and BTW, I'd reeally suggest you to update your flex installation ;-)

> FAIL: t/help2
> ==============
>
> + aclocal-1.12
> + cat stderr
> NONE:0: /usr/bin/m4: ERROR: end of file in string
> autom4te: /usr/bin/m4 failed with exit status: 1
> aclocal-1.12: error: autom4te failed with exit status: 1
> + /bin/grep -F acinclude.m4 stderr
> + am_exit_trap 1
> + exit_status=1
>
This too sounds like a spurious error, in that the error message we
expected from this particular aclocal invocation is there, but it's
not as "precise" as we'd like it to be.  Not a big deal, and not
really aclocal's fault, since the error message comes from GNU m4.
May I ask you which m4 version re you using?  That is unfortunately
not registered in config.log ...

-*-*-

In conclusion: these two failures are just negligible testsuite
weaknesses, that we can safely ignore.  And the automake you have
built should be perfectly safe for production use.

I will close this bug report soonish (I'm still keeping it open
because I'd like to know the m4 version you're using).

Thanks,
  Stefano








Information forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Thu, 15 Nov 2012 16:35:01 GMT) Full text and rfc822 format available.

Message #21 received at 12836 <at> debbugs.gnu.org (full text, mbox):

From: Tru Huynh <tru <at> pasteur.fr>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 12836 <at> debbugs.gnu.org
Subject: Re: bug#12836: automake-1.12 make check: FAIL:2
Date: Thu, 15 Nov 2012 17:33:34 +0100
On Thu, Nov 15, 2012 at 05:24:56PM +0100, Stefano Lattarini wrote:
> Hi Tru, sorry for the further delay.
> 
no problem :)
> 
> > FAIL: t/lex-header
> > ==================
> >
> > lex-header: running flex --version
> > flex version 2.5.4
> >
> Yikes!  According to what I see in <http://flex.sourceforge.net/>, this
> flex version is fifteen years old!  The failure here is due to the fact
> that we are assuming a flex feature (support for the "--header-file"
> option) that is not present in such an old version.  So we can consider
> this a spurious error; and the fact that all the other test cases on lex
> support have passed shows that Automake-generated rules can actually
> work very well even with such an old flex version.
> 
> (and BTW, I'd reeally suggest you to update your flex installation ;-)
That's the default flex version on CentOS-5/Red Hat Enterprise Linux 5.
[tru <at> sillage ~]$ rpm -q flex
flex-2.5.4a-41.fc6.x86_64

I will install another flex version next time :).

> 
> > FAIL: t/help2
> > ==============
> >
> > + aclocal-1.12
> > + cat stderr
> > NONE:0: /usr/bin/m4: ERROR: end of file in string
> > autom4te: /usr/bin/m4 failed with exit status: 1
> > aclocal-1.12: error: autom4te failed with exit status: 1
> > + /bin/grep -F acinclude.m4 stderr
> > + am_exit_trap 1
> > + exit_status=1
> >
> This too sounds like a spurious error, in that the error message we
> expected from this particular aclocal invocation is there, but it's
> not as "precise" as we'd like it to be.  Not a big deal, and not
> really aclocal's fault, since the error message comes from GNU m4.
> May I ask you which m4 version re you using?  That is unfortunately
> not registered in config.log ...
> 
/usr/bin/m4 is the CentOS-5 default version.
[tru <at> sillage ~]$ rpm -qf /usr/bin/m4
m4-1.4.5-3.el5.1.x86_64

Another oldy too :D

Thanks for you help,

Tru
-- 
Dr Tru Huynh          | http://www.pasteur.fr/recherche/unites/Binfs/
mailto:tru <at> pasteur.fr | tel/fax +33 1 45 68 87 37/19
Institut Pasteur, 25-28 rue du Docteur Roux, 75724 Paris CEDEX 15 France  




Information forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Thu, 15 Nov 2012 16:38:02 GMT) Full text and rfc822 format available.

Message #24 received at 12836 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Tru Huynh <tru <at> pasteur.fr>
Cc: GNU bug tracker automated control server <control <at> debbugs.gnu.org>,
	12836 <at> debbugs.gnu.org
Subject: Re: bug#12836: automake-1.12 make check: FAIL:2
Date: Thu, 15 Nov 2012 17:36:28 +0100
tags  12836 - moreinfo
tags  12836 + notabug
close 12836

On 11/15/2012 05:33 PM, Tru Huynh wrote:
> On Thu, Nov 15, 2012 at 05:24:56PM +0100, Stefano Lattarini wrote:
>> Hi Tru, sorry for the further delay.
>>
> no problem :)
>>
>>> FAIL: t/lex-header
>>> ==================
>>>
>>> lex-header: running flex --version
>>> flex version 2.5.4
>>>
>> Yikes!  According to what I see in <http://flex.sourceforge.net/>, this
>> flex version is fifteen years old!  The failure here is due to the fact
>> that we are assuming a flex feature (support for the "--header-file"
>> option) that is not present in such an old version.  So we can consider
>> this a spurious error; and the fact that all the other test cases on lex
>> support have passed shows that Automake-generated rules can actually
>> work very well even with such an old flex version.
>>
>> (and BTW, I'd reeally suggest you to update your flex installation ;-)
> That's the default flex version on CentOS-5/Red Hat Enterprise Linux 5.
> [tru <at> sillage ~]$ rpm -q flex
> flex-2.5.4a-41.fc6.x86_64
> 
> I will install another flex version next time :).
> 
>>
>>> FAIL: t/help2
>>> ==============
>>>
>>> + aclocal-1.12
>>> + cat stderr
>>> NONE:0: /usr/bin/m4: ERROR: end of file in string
>>> autom4te: /usr/bin/m4 failed with exit status: 1
>>> aclocal-1.12: error: autom4te failed with exit status: 1
>>> + /bin/grep -F acinclude.m4 stderr
>>> + am_exit_trap 1
>>> + exit_status=1
>>>
>> This too sounds like a spurious error, in that the error message we
>> expected from this particular aclocal invocation is there, but it's
>> not as "precise" as we'd like it to be.  Not a big deal, and not
>> really aclocal's fault, since the error message comes from GNU m4.
>> May I ask you which m4 version re you using?  That is unfortunately
>> not registered in config.log ...
>>
> /usr/bin/m4 is the CentOS-5 default version.
> [tru <at> sillage ~]$ rpm -qf /usr/bin/m4
> m4-1.4.5-3.el5.1.x86_64
> 
> Another oldy too :D
>
Yep :-)

> Thanks for you help,
> 
Thanks for the details.  I can now proceed to close this bug report.

Best regards,
  Stefano





Removed tag(s) moreinfo. Request was from Stefano Lattarini <stefano.lattarini <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 15 Nov 2012 16:38:02 GMT) Full text and rfc822 format available.

Added tag(s) notabug. Request was from Stefano Lattarini <stefano.lattarini <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 15 Nov 2012 16:38:03 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 12836 <at> debbugs.gnu.org and Tru Huynh <tru <at> pasteur.fr> Request was from Stefano Lattarini <stefano.lattarini <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 15 Nov 2012 16:38:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Thu, 22 Nov 2012 09:42:02 GMT) Full text and rfc822 format available.

Message #33 received at 12836 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Dagobert Michelsen <dam <at> opencsw.org>
Cc: 11524 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>,
	12836 <at> debbugs.gnu.org
Subject: Re: bug#11524: ping on automake bug#11524
Date: Thu, 22 Nov 2012 10:39:44 +0100
[+cc bug#12836, automake-patches]

On 11/21/2012 10:17 PM, Dagobert Michelsen wrote:
> Hi Stefano,
>
Hi Dagobert, thanks for the quick reply.

> Am 21.11.2012 um 11:11 schrieb Stefano Lattarini <stefano.lattarini <at> gmail.com>:
>> Reference:
>> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11524>
>>
>> Any news on this bug?  Can it still be reproduced with Automake 1.12.5?
>> Can it be reproduced with the development version of Automake from the
>> 'master' branch?  Since the evidence so far seems to point to spurious
>> errors, I will close this report in a few days if I haven't heard back
>> by then.
> 
> 
> I still get quite some failures:
>   http://buildfarm.opencsw.org/~dam/automake-1.12.5-test-suite.log
>
Let's try to go through them one by one (in different replies).

> FAIL: t/lex-header
> lex-header: running flex --version
> flex version 2.5.4
>
OK, this version of flex is ~ 15 years old, and ...

> /bin/bash ./ylwrap `test -f 'lexer.l' || echo './'`lexer.l \
>    lex.yy.c foo-lexer.c -- flex --header-file=mylex.h
> flex: unknown flag '-'.  For usage, try
>	flex --help
> *** Error code 1
> make: Fatal error: Command failed for target `foo-lexer.c'
>
... doesn't support the '--header-file' option.  This issue has been
reported once already (in automake bug#12836, which I am CC:ing).
The patch should take care of the issue.  Can you confirm it works?

---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ----

From 656f866264c7afe0f821eb0962aad8ff2f65c531 Mon Sep 17 00:00:00 2001
Message-Id: <656f866264c7afe0f821eb0962aad8ff2f65c531.1353576830.git.stefano.lattarini <at> gmail.com>
From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Date: Thu, 22 Nov 2012 10:29:37 +0100
Subject: [PATCH] tests: fix a spurious failure with older flex versions

See automake bug#11524 and bug#12836.

* t/lex-header.sh: Here, we use flex option '--header-file',
but that option is not supported by some older flex versions.
Simply skip this test if such an old flex version is detected.

Signed-off-by: Stefano Lattarini <stefano.lattarini <at> gmail.com>
---
 t/lex-header.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/t/lex-header.sh b/t/lex-header.sh
index f8d7333..ad2976e 100755
--- a/t/lex-header.sh
+++ b/t/lex-header.sh
@@ -20,6 +20,12 @@
 required='cc flex'
 . ./defs || exit 1

+# Here, we need to use the use flex option '--header-file', but some
+# older flex versions don't support is (see automake bug#11524 and
+# bug#12836).  Skip this test if such an old flex version is detected.
+$LEX --help | grep '.*--header-file' \
+  || skip_ "flex doesn't support the --header-file' option"
+
 cat >> configure.ac << 'END'
 AC_PROG_CC
 AC_PROG_LEX
-- 
1.8.0.209.gf3828dc




Information forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Sat, 24 Nov 2012 12:08:02 GMT) Full text and rfc822 format available.

Message #36 received at 12836 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Dagobert Michelsen <dam <at> opencsw.org>
Cc: 11524 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>,
	12836 <at> debbugs.gnu.org
Subject: Re: bug#12836: bug#11524: ping on automake bug#11524
Date: Sat, 24 Nov 2012 13:06:00 +0100
On 11/22/2012 10:39 AM, Stefano Lattarini wrote:
>
> 
>> FAIL: t/lex-header
>> lex-header: running flex --version
>> flex version 2.5.4
>>
> OK, this version of flex is ~ 15 years old, and ...
> 
>> /bin/bash ./ylwrap `test -f 'lexer.l' || echo './'`lexer.l \
>>    lex.yy.c foo-lexer.c -- flex --header-file=mylex.h
>> flex: unknown flag '-'.  For usage, try
>> 	flex --help
>> *** Error code 1
>> make: Fatal error: Command failed for target `foo-lexer.c'
>>
> ... doesn't support the '--header-file' option.  This issue has been
> reported once already (in automake bug#12836, which I am CC:ing).
> The patch should take care of the issue.
> 
>  -*-*-*-
>
> Subject: [PATCH] tests: fix a spurious failure with older flex versions
> 
> See automake bug#11524 and bug#12836.
> 
> * t/lex-header.sh: Here, we use flex option '--header-file',
> but that option is not supported by some older flex versions.
> Simply skip this test if such an old flex version is detected.
> 
I've now pushed this patch (to maint).

Regards,
  Stefano




Information forwarded to bug-automake <at> gnu.org:
bug#12836; Package automake. (Mon, 26 Nov 2012 08:24:02 GMT) Full text and rfc822 format available.

Message #39 received at 12836 <at> debbugs.gnu.org (full text, mbox):

From: Dagobert Michelsen <dam <at> opencsw.org>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 11524 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>,
	12836 <at> debbugs.gnu.org
Subject: Re: bug#11524: ping on automake bug#11524
Date: Mon, 26 Nov 2012 09:21:21 +0100
Hi Stefano,

Am 22.11.2012 um 10:39 schrieb Stefano Lattarini <stefano.lattarini <at> gmail.com>:

> [+cc bug#12836, automake-patches]
> 
> On 11/21/2012 10:17 PM, Dagobert Michelsen wrote:
>> Hi Stefano,
>> 
> Hi Dagobert, thanks for the quick reply.
> 
>> Am 21.11.2012 um 11:11 schrieb Stefano Lattarini <stefano.lattarini <at> gmail.com>:
>>> Reference:
>>> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11524>
>>> 
>>> Any news on this bug?  Can it still be reproduced with Automake 1.12.5?
>>> Can it be reproduced with the development version of Automake from the
>>> 'master' branch?  Since the evidence so far seems to point to spurious
>>> errors, I will close this report in a few days if I haven't heard back
>>> by then.
>> 
>> 
>> I still get quite some failures:
>>  http://buildfarm.opencsw.org/~dam/automake-1.12.5-test-suite.log
>> 
> Let's try to go through them one by one (in different replies).
> 
>> FAIL: t/lex-header
>> lex-header: running flex --version
>> flex version 2.5.4
>> 
> OK, this version of flex is ~ 15 years old, and ...
> 
>> /bin/bash ./ylwrap `test -f 'lexer.l' || echo './'`lexer.l \
>>   lex.yy.c foo-lexer.c -- flex --header-file=mylex.h
>> flex: unknown flag '-'.  For usage, try
>> 	flex --help
>> *** Error code 1
>> make: Fatal error: Command failed for target `foo-lexer.c'
>> 
> ... doesn't support the '--header-file' option.  This issue has been
> reported once already (in automake bug#12836, which I am CC:ing).
> The patch should take care of the issue.  Can you confirm it works?

Looks good, no more "unknown flag" in test-suite.log


Best regards

  -- Dago

> ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ----
> 
> From 656f866264c7afe0f821eb0962aad8ff2f65c531 Mon Sep 17 00:00:00 2001
> Message-Id: <656f866264c7afe0f821eb0962aad8ff2f65c531.1353576830.git.stefano.lattarini <at> gmail.com>
> From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
> Date: Thu, 22 Nov 2012 10:29:37 +0100
> Subject: [PATCH] tests: fix a spurious failure with older flex versions
> 
> See automake bug#11524 and bug#12836.
> 
> * t/lex-header.sh: Here, we use flex option '--header-file',
> but that option is not supported by some older flex versions.
> Simply skip this test if such an old flex version is detected.
> 
> Signed-off-by: Stefano Lattarini <stefano.lattarini <at> gmail.com>
> ---
> t/lex-header.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/t/lex-header.sh b/t/lex-header.sh
> index f8d7333..ad2976e 100755
> --- a/t/lex-header.sh
> +++ b/t/lex-header.sh
> @@ -20,6 +20,12 @@
> required='cc flex'
> . ./defs || exit 1
> 
> +# Here, we need to use the use flex option '--header-file', but some
> +# older flex versions don't support is (see automake bug#11524 and
> +# bug#12836).  Skip this test if such an old flex version is detected.
> +$LEX --help | grep '.*--header-file' \
> +  || skip_ "flex doesn't support the --header-file' option"
> +
> cat >> configure.ac << 'END'
> AC_PROG_CC
> AC_PROG_LEX
> -- 
> 1.8.0.209.gf3828dc

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 24 Dec 2012 12:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 12 years and 264 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.