From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Nov 2012 15:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12823@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135230133513848 (code B ref -1); Wed, 07 Nov 2012 15:16:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Nov 2012 15:15:35 +0000 Received: from localhost ([127.0.0.1]:54600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TW7Lr-0003bJ-2U for submit@debbugs.gnu.org; Wed, 07 Nov 2012 10:15:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55260) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TW7Lk-0003b7-J0 for submit@debbugs.gnu.org; Wed, 07 Nov 2012 10:15:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TW7Li-00011m-GZ for submit@debbugs.gnu.org; Wed, 07 Nov 2012 10:15:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TW7Li-00011h-DT for submit@debbugs.gnu.org; Wed, 07 Nov 2012 10:15:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TW7Ld-0000py-Mh for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2012 10:15:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TW7LT-0000zp-PQ for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2012 10:15:21 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:45906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TW7LT-0000zX-L9 for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2012 10:15:11 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvIGAG6Zu0/O+LEi/2dsb2JhbABEojIBjhWDSYEIgnIaRRMhARwNiEWYUqE3jSaDHgOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="206663867" Received: from 206-248-177-34.dsl.teksavvy.com (HELO pastel.home) ([206.248.177.34]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Nov 2012 10:15:10 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6BDA45977E; Wed, 7 Nov 2012 10:15:10 -0500 (EST) From: Stefan Monnier Date: Wed, 07 Nov 2012 10:15:10 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) Package: Emacs Version: 24.3.50 After letting xft use bitmap fonts on my system, Emacs started to crash, which was tracked to an invalid font name that was used without checking. So I added if (NILP (spec)) signal_error ("Invalid font name", ascii_font); to x_set_font in revno 110704, but this only prevents the crash, replacing it with an error. Basically the error is that ascii_font is not a valid XLFD font name because one of its fields has a "-" in its name, and since fields are separated by "-", this leads to a misparse. Now, this invalid name was built by Emacs, probably in font_unparse_xlfd. The appended patch fixes my problem. So now the question is: should we reorder all the entries in the width_table, slant_table, and weight_table so that the first entry of every line is a non-dashed name? Or could this have undesirable effects? Stefan === modified file 'src/font.c' --- src/font.c 2012-11-06 03:17:56 +0000 +++ src/font.c 2012-11-07 15:04:24 +0000 @@ -102,7 +102,7 @@ { 50, { "ultra-condensed", "ultracondensed" }}, { 63, { "extra-condensed", "extracondensed" }}, { 75, { "condensed", "compressed", "narrow" }}, - { 87, { "semi-condensed", "semicondensed", "demicondensed" }}, + { 87, { "semicondensed", "semi-condensed", "demicondensed" }}, { 100, { "normal", "medium", "regular", "unspecified" }}, { 113, { "semi-expanded", "semiexpanded", "demiexpanded" }}, { 125, { "expanded" }}, From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Nov 2012 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135230715722349 (code B ref 12823); Wed, 07 Nov 2012 16:53:01 +0000 Received: (at 12823) by debbugs.gnu.org; 7 Nov 2012 16:52:37 +0000 Received: from localhost ([127.0.0.1]:54662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TW8rl-0005oQ-6v for submit@debbugs.gnu.org; Wed, 07 Nov 2012 11:52:37 -0500 Received: from mailout.melmac.se ([62.20.26.67]:42391) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TW8ri-0005oI-Tq for 12823@debbugs.gnu.org; Wed, 07 Nov 2012 11:52:36 -0500 Received: from mail01.melmac.se (mail01.melmac.se [62.20.26.80]) by mailout.melmac.se (Postfix) with ESMTP id 52DCB964F for <12823@debbugs.gnu.org>; Wed, 7 Nov 2012 17:52:36 +0100 (CET) Received: (qmail 8419 invoked by uid 89); 7 Nov 2012 16:52:36 -0000 Received: from h-46-59-42-18.na.cust.bahnhof.se (HELO coolsville.localdomain) (boel.djarv@bdtv.se@46.59.42.18) by mail01.melmac.se with ESMTPA; 7 Nov 2012 16:52:36 -0000 Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id DD82A7FA05E; Wed, 7 Nov 2012 17:52:35 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) From: Jan =?UTF-8?Q?Dj=C3=A4rv?= In-Reply-To: Date: Wed, 7 Nov 2012 17:52:41 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <2D6B98DD-F6EA-439D-A43F-0648171A3663@swipnet.se> References: X-Mailer: Apple Mail (2.1499) X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello. From the XLFD-specification 1.5 (http://www.xfree86.org/current/xlfd.pdf): "Field values are constructed as strings of ISO 8859-1 graphic characters, excluding the following: [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello. From the XLFD-specification 1.5 (http://www.xfree86.org/current/xlfd.pdf): "Field values are constructed as strings of ISO 8859-1 graphic characters, excluding the following: [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] Hello. =46rom the XLFD-specification 1.5 = (http://www.xfree86.org/current/xlfd.pdf): "Field values are constructed as strings of ISO 8859-1 graphic = characters, excluding the following: =E2=80=A2 =E2=80=98=E2=80=98=E2=88=92=E2=80=99=E2=80=99 = (HYPHEN), the XLFD font name delimiter character =E2=80=A2 =E2=80=98=E2=80=98?=E2=80=99=E2=80=99 (QUESTION MARK) = and =E2=80=98=E2=80=98*=E2=80=99=E2=80=99 (ASTERISK), the X protocol = font name wildcard characters =E2=80=A2 =E2=80=98=E2=80=98,=E2=80=99=E2=80=99 (COMMA), used by = Xlib to separate XLFD font names in a font set. =E2=80=A2 =E2=80=98=E2=80=98"=E2=80=99=E2=80=99 (QUOTATION = MARK), used by some commercial products to quote a font name. Alphabetic case distinctions are allowed but are for human readability = concerns only. Conforming X servers will perform matching on font name = query or open requests independent of case. The entire font name string = must have no more than 255 characters." So the use of semi-condensed (for example) is invalid, so we should = simply remove all entries with "-" in them. Jan D. 7 nov 2012 kl. 16:15 skrev Stefan Monnier : > Package: Emacs > Version: 24.3.50 >=20 > After letting xft use bitmap fonts on my system, Emacs started to = crash, > which was tracked to an invalid font name that was used > without checking. > So I added >=20 > if (NILP (spec)) > signal_error ("Invalid font name", ascii_font); >=20 > to x_set_font in revno 110704, but this only prevents the crash, > replacing it with an error. Basically the error is that ascii_font is > not a valid XLFD font name because one of its fields has a "-" in its > name, and since fields are separated by "-", this leads to a misparse. >=20 > Now, this invalid name was built by Emacs, probably in > font_unparse_xlfd. The appended patch fixes my problem. >=20 > So now the question is: should we reorder all the entries in the > width_table, slant_table, and weight_table so that the first entry of > every line is a non-dashed name? Or could this have undesirable = effects? >=20 >=20 > Stefan >=20 >=20 > =3D=3D=3D modified file 'src/font.c' > --- src/font.c 2012-11-06 03:17:56 +0000 > +++ src/font.c 2012-11-07 15:04:24 +0000 > @@ -102,7 +102,7 @@ > { 50, { "ultra-condensed", "ultracondensed" }}, > { 63, { "extra-condensed", "extracondensed" }}, > { 75, { "condensed", "compressed", "narrow" }}, > - { 87, { "semi-condensed", "semicondensed", "demicondensed" }}, > + { 87, { "semicondensed", "semi-condensed", "demicondensed" }}, > { 100, { "normal", "medium", "regular", "unspecified" }}, > { 113, { "semi-expanded", "semiexpanded", "demiexpanded" }}, > { 125, { "expanded" }}, >=20 >=20 >=20 From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name References: Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Nov 2012 14:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.13524701904913 (code B ref 12823); Fri, 09 Nov 2012 14:10:01 +0000 Received: (at 12823) by debbugs.gnu.org; 9 Nov 2012 14:09:50 +0000 Received: from localhost ([127.0.0.1]:57326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TWpHJ-0001HC-Rk for submit@debbugs.gnu.org; Fri, 09 Nov 2012 09:09:50 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56147) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TWpHH-0001H5-Va for 12823@debbugs.gnu.org; Fri, 09 Nov 2012 09:09:48 -0500 Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:62371 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TWpH9-00075H-FW; Fri, 09 Nov 2012 09:09:40 -0500 From: Kenichi Handa In-Reply-To: (message from Stefan Monnier on Wed, 07 Nov 2012 10:15:10 -0500) Date: Fri, 09 Nov 2012 23:07:44 +0900 Message-ID: <87ip9euaxb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) In article , Stefan Monnier writes: > Now, this invalid name was built by Emacs, probably in > font_unparse_xlfd. The appended patch fixes my problem. > So now the question is: should we reorder all the entries in the > width_table, slant_table, and weight_table so that the first entry of > every line is a non-dashed name? Or could this have undesirable effects? Yes. The first elements in those table should match the face attribute values for :weight, :width, and :slant (see set-face-attribute). I should have wrote that in the comment. Could you please try this patch instead? --- Kenichi Handa handa@gnu.org === modified file 'src/font.c' --- src/font.c 2012-11-03 05:11:34 +0000 +++ src/font.c 2012-11-09 14:05:15 +0000 @@ -1234,8 +1234,19 @@ f[j] = "*"; else { + int c, k, l; + val = SYMBOL_NAME (val); - f[j] = SSDATA (val); + len = SBYTES (val); + f[j] = alloca (len + 1); + /* Copy the name while excluding '-', '?', ',', and '"'. */ + for (k = l = 0; k < len; k++) + { + c = SREF (val, k); + if (c != '-' && c != '?' && c != ',' && c != '"') + f[l++] = c; + } + f[l] = '\0'; } } From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name References: Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Nov 2012 11:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kenichi Handa Cc: monnier@iro.umontreal.ca, 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135280785310851 (code B ref 12823); Tue, 13 Nov 2012 11:58:01 +0000 Received: (at 12823) by debbugs.gnu.org; 13 Nov 2012 11:57:33 +0000 Received: from localhost ([127.0.0.1]:37776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYF7R-0002ou-85 for submit@debbugs.gnu.org; Tue, 13 Nov 2012 06:57:33 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54818) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYF7M-0002ol-FH for 12823@debbugs.gnu.org; Tue, 13 Nov 2012 06:57:28 -0500 Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:65380 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TYF6s-0002KM-79; Tue, 13 Nov 2012 06:56:54 -0500 From: Kenichi Handa In-Reply-To: <87ip9euaxb.fsf@gnu.org> (message from Kenichi Handa on Fri, 09 Nov 2012 23:07:44 +0900) Date: Tue, 13 Nov 2012 20:55:10 +0900 Message-ID: <878va5u38h.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.4 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) In article <87ip9euaxb.fsf@gnu.org>, Kenichi Handa writes: > Yes. The first elements in those table should match the > face attribute values for :weight, :width, and :slant (see > set-face-attribute). I should have wrote that in the > comment. > Could you please try this patch instead? Oops, sorry, I've sent the wrong version. Here's the correct patch. === modified file 'src/font.c' --- src/font.c 2012-11-03 05:11:34 +0000 +++ src/font.c 2012-11-13 11:50:50 +0000 @@ -1185,7 +1185,7 @@ font_unparse_xlfd (Lisp_Object font, int pixel_size, char *name, int nbytes) { char *p; - const char *f[XLFD_REGISTRY_INDEX + 1]; + char *f[XLFD_REGISTRY_INDEX + 1]; Lisp_Object val; int i, j, len; @@ -1234,8 +1234,21 @@ f[j] = "*"; else { + int c, k, l; + ptrdiff_t alloc; + val = SYMBOL_NAME (val); - f[j] = SSDATA (val); + alloc = SBYTES (val) + 1; + if (nbytes <= alloc) + return -1; + f[j] = alloca (alloc); + /* Copy the name while excluding '-', '?', ',', and '"'. */ + for (k = l = 0; k < alloc; k++) + { + c = SREF (val, k); + if (c != '-' && c != '?' && c != ',' && c != '"') + f[j][l++] = c; + } } } --- Kenichi Handa handa@gnu.org From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name Resent-From: Andreas Schwab Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Nov 2012 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kenichi Handa Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135283473625211 (code B ref 12823); Tue, 13 Nov 2012 19:26:01 +0000 Received: (at 12823) by debbugs.gnu.org; 13 Nov 2012 19:25:36 +0000 Received: from localhost ([127.0.0.1]:39236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYM76-0006Ya-L5 for submit@debbugs.gnu.org; Tue, 13 Nov 2012 14:25:36 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:58640) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYM74-0006YS-E2 for 12823@debbugs.gnu.org; Tue, 13 Nov 2012 14:25:35 -0500 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3Y1Jgx5qj0z4KK5r; Tue, 13 Nov 2012 20:25:01 +0100 (CET) X-Auth-Info: 08orknst9iWIhUgWEFDHjEyvir1lVFaZ8yFNlq6fBjw= Received: from igel.home (ppp-88-217-112-134.dynamic.mnet-online.de [88.217.112.134]) by mail.mnet-online.de (Postfix) with ESMTPA id 3Y1Jgx5L2mzbbjb; Tue, 13 Nov 2012 20:25:01 +0100 (CET) Received: by igel.home (Postfix, from userid 501) id 6D2E6CA2A4; Tue, 13 Nov 2012 20:25:01 +0100 (CET) From: Andreas Schwab References: <878va5u38h.fsf@gnu.org> X-Yow: It's today's SPECIAL! Date: Tue, 13 Nov 2012 20:25:01 +0100 In-Reply-To: <878va5u38h.fsf@gnu.org> (Kenichi Handa's message of "Tue, 13 Nov 2012 20:55:10 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Kenichi Handa writes: > === modified file 'src/font.c' > --- src/font.c 2012-11-03 05:11:34 +0000 > +++ src/font.c 2012-11-13 11:50:50 +0000 > @@ -1185,7 +1185,7 @@ > font_unparse_xlfd (Lisp_Object font, int pixel_size, char *name, int nbytes) > { > char *p; > - const char *f[XLFD_REGISTRY_INDEX + 1]; > + char *f[XLFD_REGISTRY_INDEX + 1]; This will provoke warnings that are turned into errors with --enable-gcc-warnings. There is no need for that, just use a temporary variable (there is already one above that is perfectly suitable). Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name References: Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Nov 2012 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135298641822489 (code B ref 12823); Thu, 15 Nov 2012 13:34:01 +0000 Received: (at 12823) by debbugs.gnu.org; 15 Nov 2012 13:33:38 +0000 Received: from localhost ([127.0.0.1]:44513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYzZY-0005qe-TH for submit@debbugs.gnu.org; Thu, 15 Nov 2012 08:33:38 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54656) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYzZV-0005qW-04 for 12823@debbugs.gnu.org; Thu, 15 Nov 2012 08:33:34 -0500 Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:51094 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TYzYm-0003C1-Sd; Thu, 15 Nov 2012 08:32:51 -0500 From: Kenichi Handa In-Reply-To: (message from Andreas Schwab on Tue, 13 Nov 2012 20:25:01 +0100) Date: Thu, 15 Nov 2012 22:30:52 +0900 Message-ID: <87wqxnro1f.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) In article , Andreas Schwab writes: > Kenichi Handa writes: > > === modified file 'src/font.c' > > --- src/font.c 2012-11-03 05:11:34 +0000 > > +++ src/font.c 2012-11-13 11:50:50 +0000 > > @@ -1185,7 +1185,7 @@ > > font_unparse_xlfd (Lisp_Object font, int pixel_size, char *name, int nbytes) > > { > > char *p; > > - const char *f[XLFD_REGISTRY_INDEX + 1]; > > + char *f[XLFD_REGISTRY_INDEX + 1]; > This will provoke warnings that are turned into errors with > --enable-gcc-warnings. There is no need for that, just use a temporary > variable (there is already one above that is perfectly suitable). Thank you for the suggesiton. Do you mean something like this additional patch? === modified file 'src/font.c' --- src/font.c 2012-11-13 14:24:26 +0000 +++ src/font.c 2012-11-15 13:04:45 +0000 @@ -1185,7 +1185,7 @@ font_unparse_xlfd (Lisp_Object font, int pixel_size, char *name, int nbytes) { char *p; - char *f[XLFD_REGISTRY_INDEX + 1]; + const char *f[XLFD_REGISTRY_INDEX + 1]; Lisp_Object val; int i, j, len; @@ -1241,13 +1241,13 @@ alloc = SBYTES (val) + 1; if (nbytes <= alloc) return -1; - f[j] = alloca (alloc); + f[j] = p = alloca (alloc); /* Copy the name while excluding '-', '?', ',', and '"'. */ for (k = l = 0; k < alloc; k++) { c = SREF (val, k); if (c != '-' && c != '?' && c != ',' && c != '"') - f[j][l++] = c; + p[l++] = c; } } } --- Kenichi Handa handa@gnu.org From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name References: Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Nov 2012 14:32:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kenichi Handa Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135402667111581 (code B ref 12823); Tue, 27 Nov 2012 14:32:06 +0000 Received: (at 12823) by debbugs.gnu.org; 27 Nov 2012 14:31:11 +0000 Received: from localhost ([127.0.0.1]:41361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdMBf-00030U-Nz for submit@debbugs.gnu.org; Tue, 27 Nov 2012 09:31:07 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:34446) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdMAy-0002zd-1Q for 12823@debbugs.gnu.org; Tue, 27 Nov 2012 09:30:26 -0500 Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:64027 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TdM9B-0000Cr-H2; Tue, 27 Nov 2012 09:28:26 -0500 From: Kenichi Handa In-Reply-To: <87wqxnro1f.fsf@gnu.org> (message from Kenichi Handa on Thu, 15 Nov 2012 22:30:52 +0900) Date: Tue, 27 Nov 2012 23:26:27 +0900 Message-ID: <87sj7vxgto.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) For fixing this bug, I've just installed this change to trunk (rev. 111019). But, as the bug had caused crashing, it may be better to apply the change to emacs-24. --- Kenichi Handa handa@gnu.org === modified file 'src/ChangeLog' --- src/ChangeLog 2012-11-27 05:38:42 +0000 +++ src/ChangeLog 2012-11-27 13:40:38 +0000 @@ -1,3 +1,13 @@ +2012-11-18 Kenichi Handa + + * font.c (font_unparse_xlfd): Fix previous change. Keep "const" + for the variable "f". + +2012-11-13 Kenichi Handa + + * font.c (font_unparse_xlfd): Exclude special characters from the + generating XLFD name. + 2012-11-27 Paul Eggert Assume POSIX 1003.1-1988 or later for grp.h, pwd.h. === modified file 'src/font.c' --- src/font.c 2012-11-06 13:26:20 +0000 +++ src/font.c 2012-11-27 13:40:38 +0000 @@ -1234,8 +1234,21 @@ f[j] = "*"; else { + int c, k, l; + ptrdiff_t alloc; + val = SYMBOL_NAME (val); - f[j] = SSDATA (val); + alloc = SBYTES (val) + 1; + if (nbytes <= alloc) + return -1; + f[j] = p = alloca (alloc); + /* Copy the name while excluding '-', '?', ',', and '"'. */ + for (k = l = 0; k < alloc; k++) + { + c = SREF (val, k); + if (c != '-' && c != '?' && c != ',' && c != '"') + p[l++] = c; + } } } From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Nov 2012 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kenichi Handa Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135402915315670 (code B ref 12823); Tue, 27 Nov 2012 15:13:02 +0000 Received: (at 12823) by debbugs.gnu.org; 27 Nov 2012 15:12:33 +0000 Received: from localhost ([127.0.0.1]:41831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdMpp-00044e-Gd for submit@debbugs.gnu.org; Tue, 27 Nov 2012 10:12:33 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:56733) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdMpn-00044S-9s for 12823@debbugs.gnu.org; Tue, 27 Nov 2012 10:12:27 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Au0FAG6Zu09FxKh9/2dsb2JhbABEr1qEN4EIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="208585353" Received: from 69-196-168-125.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.125]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Nov 2012 10:10:36 -0500 Received: by pastel.home (Postfix, from userid 20848) id 9327F52110; Tue, 27 Nov 2012 10:10:36 -0500 (EST) From: Stefan Monnier Message-ID: References: <87sj7vxgto.fsf@gnu.org> Date: Tue, 27 Nov 2012 10:10:36 -0500 In-Reply-To: <87sj7vxgto.fsf@gnu.org> (Kenichi Handa's message of "Tue, 27 Nov 2012 23:26:27 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > For fixing this bug, I've just installed this change to > trunk (rev. 111019). Thanks, that looks good. > But, as the bug had caused crashing, > it may be better to apply the change to emacs-24. I didn't see any crashes, only assertion violations. FWIW Debian's emacs23 and emacs24 binaries don't crash here, so I suspect that the bug is luckily "solved" by accident somewhere. I'm still wondering about those names that include -, such as "semi-condensed" that we have in font.c: - IIUC, they can never be useful for XFLD font names. Are they useful for other font name formats supported by Emacs? Examples? - If they are useful sometimes, is it important to have the dashed name first in the list? Stefan From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name References: Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Nov 2012 09:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135409462416836 (code B ref 12823); Wed, 28 Nov 2012 09:24:02 +0000 Received: (at 12823) by debbugs.gnu.org; 28 Nov 2012 09:23:44 +0000 Received: from localhost ([127.0.0.1]:42600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tddrr-0004NV-JR for submit@debbugs.gnu.org; Wed, 28 Nov 2012 04:23:43 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56465) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tddrp-0004NO-Ky for 12823@debbugs.gnu.org; Wed, 28 Nov 2012 04:23:42 -0500 Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:55635 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Tddpz-0005gQ-Cp; Wed, 28 Nov 2012 04:21:48 -0500 From: Kenichi Handa In-Reply-To: (message from Stefan Monnier on Tue, 27 Nov 2012 10:10:36 -0500) Date: Wed, 28 Nov 2012 18:20:02 +0900 Message-ID: <87pq2yxewt.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) In article , Stefan Monnier writes: > > For fixing this bug, I've just installed this change to > > trunk (rev. 111019). > Thanks, that looks good. > > But, as the bug had caused crashing, > > it may be better to apply the change to emacs-24. > I didn't see any crashes, only assertion violations. > FWIW Debian's emacs23 and emacs24 binaries don't crash here, so > I suspect that the bug is luckily "solved" by accident somewhere. You wrote; > After letting xft use bitmap fonts on my system, Emacs started to crash, > which was tracked to an invalid font name that was used > without checking. > So I added > if (NILP (spec)) > signal_error ("Invalid font name", ascii_font); > to x_set_font in revno 110704, but this only prevents the crash, > replacing it with an error. Do you mean this workaround as "assertion violations"? I think it just hides the deeper bug. Here, SPEC is a return value of font_spec_from_name (fontset_ascii (fontset)), and font_spec_from_name should never fail with that kind of argument. > I'm still wondering about those names that include -, such as > "semi-condensed" that we have in font.c: > - IIUC, they can never be useful for XFLD font names. Are they useful > for other font name formats supported by Emacs? Examples? > - If they are useful sometimes, is it important to have the dashed > name first in the list? As I wrote before, the table is also used to get a face attribute value from a font spec, and, for instance, face attribute :width allows the symbol `semi-condensed'. If we don't have that name first in the list, we must have another index specifying which name is a valid face attribute value, or must have another tables that map numeric values of font spec to face attribute values. --- Kenichi Handa handa@gnu.org From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Nov 2012 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kenichi Handa Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135411475624677 (code B ref 12823); Wed, 28 Nov 2012 15:00:02 +0000 Received: (at 12823) by debbugs.gnu.org; 28 Nov 2012 14:59:16 +0000 Received: from localhost ([127.0.0.1]:43700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tdj6Z-0006Px-NX for submit@debbugs.gnu.org; Wed, 28 Nov 2012 09:59:16 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47923) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tdj6W-0006Po-OA for 12823@debbugs.gnu.org; Wed, 28 Nov 2012 09:59:13 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id qASEvGsa018616; Wed, 28 Nov 2012 09:57:16 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 6A4A8B4278; Wed, 28 Nov 2012 09:57:16 -0500 (EST) From: Stefan Monnier Message-ID: References: <87pq2yxewt.fsf@gnu.org> Date: Wed, 28 Nov 2012 09:57:16 -0500 In-Reply-To: <87pq2yxewt.fsf@gnu.org> (Kenichi Handa's message of "Wed, 28 Nov 2012 18:20:02 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4416=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4416> : streams <867347> : uri <1279727> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) >> After letting xft use bitmap fonts on my system, Emacs started to crash, >> which was tracked to an invalid font name that was used >> without checking. >> So I added >> if (NILP (spec)) >> signal_error ("Invalid font name", ascii_font); >> to x_set_font in revno 110704, but this only prevents the crash, >> replacing it with an error. > Do you mean this workaround as "assertion violations"? No, I mean that without this NILP check, subsequent code "crashed" with an assertion violation (due to assuming that `spec' is a string, IIRC). > I think it just hides the deeper bug. Here, SPEC is a return value of > font_spec_from_name (fontset_ascii (fontset)), and font_spec_from_name > should never fail with that kind of argument. Right. >> I'm still wondering about those names that include -, such as >> "semi-condensed" that we have in font.c: >> - IIUC, they can never be useful for XFLD font names. Are they useful >> for other font name formats supported by Emacs? Examples? >> - If they are useful sometimes, is it important to have the dashed >> name first in the list? > As I wrote before, the table is also used to get a face > attribute value from a font spec, and, for instance, face > attribute :width allows the symbol `semi-condensed'. Sorry, I must have missed that message. So we can't just remove those dashed names. Fine. > If we don't have that name first in the list, we must have another > index specifying which name is a valid face attribute value, or must > have another tables that map numeric values of font spec to face > attribute values. My understanding is that this issue is only related to whether or not `semi-condensed' is in the list, but is unrelated to whether it comes before or after `semicondensed' in the list. Stefan From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name References: Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Dec 2012 09:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135452685629438 (code B ref 12823); Mon, 03 Dec 2012 09:28:01 +0000 Received: (at 12823) by debbugs.gnu.org; 3 Dec 2012 09:27:36 +0000 Received: from localhost ([127.0.0.1]:50809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfSJL-0007el-Qm for submit@debbugs.gnu.org; Mon, 03 Dec 2012 04:27:36 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:37456) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfSJK-0007ec-CK for 12823@debbugs.gnu.org; Mon, 03 Dec 2012 04:27:35 -0500 Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:61186 helo=mongkok) by fencepost.gnu.org with esmtpa (Exim 4.71) (envelope-from ) id 1TfSGX-0007Uu-Mo; Mon, 03 Dec 2012 04:25:12 -0500 From: Kenichi Handa In-Reply-To: (message from Stefan Monnier on Wed, 28 Nov 2012 09:57:16 -0500) Date: Mon, 03 Dec 2012 18:21:00 +0900 Message-ID: <87pq2rlceb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) In article , Stefan Monnier writes: > > If we don't have that name first in the list, we must have another > > index specifying which name is a valid face attribute value, or must > > have another tables that map numeric values of font spec to face > > attribute values. > My understanding is that this issue is only related to whether or not > `semi-condensed' is in the list, but is unrelated to whether it comes > before or after `semicondensed' in the list. And, what is your opinion on "whether or not `semi-condensed' is in the list"? --- Kenichi Handa handa@gnu.org From unknown Tue Aug 19 23:13:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12823: Invalid font name Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Dec 2012 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kenichi Handa Cc: 12823@debbugs.gnu.org Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135455723119685 (code B ref 12823); Mon, 03 Dec 2012 17:54:02 +0000 Received: (at 12823) by debbugs.gnu.org; 3 Dec 2012 17:53:51 +0000 Received: from localhost ([127.0.0.1]:51727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfaDE-00057Q-QF for submit@debbugs.gnu.org; Mon, 03 Dec 2012 12:53:50 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:42674) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfaDA-00057G-VL for 12823@debbugs.gnu.org; Mon, 03 Dec 2012 12:53:46 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id qB3HpKrV015619; Mon, 3 Dec 2012 12:51:20 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id E1F32B415D; Mon, 3 Dec 2012 12:51:19 -0500 (EST) From: Stefan Monnier Message-ID: References: <87pq2rlceb.fsf@gnu.org> Date: Mon, 03 Dec 2012 12:51:19 -0500 In-Reply-To: <87pq2rlceb.fsf@gnu.org> (Kenichi Handa's message of "Mon, 03 Dec 2012 18:21:00 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4421=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4421> : streams <870503> : uri <1284298> X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.6 (-) >> > If we don't have that name first in the list, we must have another >> > index specifying which name is a valid face attribute value, or must >> > have another tables that map numeric values of font spec to face >> > attribute values. >> My understanding is that this issue is only related to whether or not >> `semi-condensed' is in the list, but is unrelated to whether it comes >> before or after `semicondensed' in the list. > And, what is your opinion on "whether or not > `semi-condensed' is in the list"? IIUC you said that `semi-condensed' should be in the list, and that's fine by me. The remaining question is whether it should come first. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 13 23:39:54 2015 Received: (at control) by debbugs.gnu.org; 14 Feb 2015 04:39:54 +0000 Received: from localhost ([127.0.0.1]:42532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMUWI-0003Uk-Aw for submit@debbugs.gnu.org; Fri, 13 Feb 2015 23:39:54 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:56369) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMUWG-0003Ub-5I for control@debbugs.gnu.org; Fri, 13 Feb 2015 23:39:52 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1E4dnqG009882 for ; Fri, 13 Feb 2015 23:39:49 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 7AC9BAE0CA; Fri, 13 Feb 2015 23:39:49 -0500 (EST) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#18413: Inline part displayed in the middle of its button Message-ID: References: Date: Fri, 13 Feb 2015 23:39:49 -0500 In-Reply-To: (Stefan Monnier's message of "Fri, 31 Oct 2014 10:26:33 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5216=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5216> : inlines <2181> : streams <1389914> : uri <1854855> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) close 4942 close 5037 close 6713 close 9787 close 12823 close 6333 thanks