From unknown Tue Aug 19 21:03:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12813 <12813@debbugs.gnu.org> To: bug#12813 <12813@debbugs.gnu.org> Subject: Status: gv-define-simple-setter can evaluate VAL more than once Reply-To: bug#12813 <12813@debbugs.gnu.org> Date: Wed, 20 Aug 2025 04:03:55 +0000 retitle 12813 gv-define-simple-setter can evaluate VAL more than once reassign 12813 emacs submitter 12813 Glenn Morris severity 12813 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 06 02:50:39 2012 Received: (at submit) by debbugs.gnu.org; 6 Nov 2012 07:50:39 +0000 Received: from localhost ([127.0.0.1]:51532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVdvi-0003Kc-9H for submit@debbugs.gnu.org; Tue, 06 Nov 2012 02:50:39 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:43823) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVdvf-0003KU-M4 for submit@debbugs.gnu.org; Tue, 06 Nov 2012 02:50:36 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TVdsb-0007nT-DA; Tue, 06 Nov 2012 02:47:25 -0500 From: Glenn Morris To: submit@debbugs.gnu.org Subject: gv-define-simple-setter can evaluate VAL more than once X-Spook: David John Oates cypherpunk lynch HAMASMOIS tempest X-Ran: 'P-(PD_^F~(|L2*O8y0]Y*;n~S/2T+KmZ(jJf\=c;Cg%xyj)P0t^/^ghYM`]b}@q7+\h&8 X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 06 Nov 2012 02:47:25 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Package: emacs Version: 24.2.50 I don't know if you will consider this a bug. gv-define-simple-setter with FIX-RETURN non-nil evaluates VAL twice. This may lead to unintended behaviour. Artificial example in `emacs -Q': (defun foo (x) (car x)) (defun foo-set (x y) (setcar x y)) (gv-define-simple-setter foo foo-set t) (setq bar '(1 2 3)) (setq i 0) (setf (foo bar) (setq i (1+ i))) ; -> 1 bar ; -> (2 2 3) rather than (1 2 3) defsetf in 24.2 was documented to not have this issue (info "(cl)Customizing Setf") [...] (let ((temp VALUE)) (UPDATE-FN ARG1 ARG2 ARG3 temp) temp) So at the very least this will be relevant if http://debbugs.gnu.org/12812 gets the "obvious" fix. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 06 22:39:48 2012 Received: (at 12813) by debbugs.gnu.org; 7 Nov 2012 03:39:48 +0000 Received: from localhost ([127.0.0.1]:53142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVwUW-0001sR-05 for submit@debbugs.gnu.org; Tue, 06 Nov 2012 22:39:48 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:6692) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVwUU-0001sK-0s for 12813@debbugs.gnu.org; Tue, 06 Nov 2012 22:39:46 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu0/O+LEi/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLDiYSFBgNJIgcBboJkEQDiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="206642027" Received: from 206-248-177-34.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.177.34]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Nov 2012 22:39:51 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 33049AE49F; Tue, 6 Nov 2012 22:39:50 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#12813: gv-define-simple-setter can evaluate VAL more than once Message-ID: References: Date: Tue, 06 Nov 2012 22:39:50 -0500 In-Reply-To: (Glenn Morris's message of "Tue, 06 Nov 2012 02:47:25 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12813 Cc: 12813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > I don't know if you will consider this a bug. > gv-define-simple-setter with FIX-RETURN non-nil evaluates VAL twice. Thanks, should be fixed now, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 06 22:44:46 2012 Received: (at control) by debbugs.gnu.org; 7 Nov 2012 03:44:47 +0000 Received: from localhost ([127.0.0.1]:53146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVwZJ-00020o-Li for submit@debbugs.gnu.org; Tue, 06 Nov 2012 22:44:46 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:31604) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVwZH-00020g-Px for control@debbugs.gnu.org; Tue, 06 Nov 2012 22:44:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu0/O+LEi/2dsb2JhbABEtBGBCIIRBQEFVjMLNBIUGA2GAAeCKBa6CY0mgx4DiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="206642190" Received: from 206-248-177-34.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.177.34]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Nov 2012 22:44:49 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 6086FAE49F; Tue, 6 Nov 2012 22:44:49 -0500 (EST) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#12813: gv-define-simple-setter can evaluate VAL more than once Message-ID: References: Date: Tue, 06 Nov 2012 22:44:49 -0500 In-Reply-To: (Stefan Monnier's message of "Tue, 06 Nov 2012 22:39:50 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) close 12813 thanks From unknown Tue Aug 19 21:03:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 Dec 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator