From unknown Fri Aug 22 01:03:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12800 <12800@debbugs.gnu.org> To: bug#12800 <12800@debbugs.gnu.org> Subject: Status: Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid. Reply-To: bug#12800 <12800@debbugs.gnu.org> Date: Fri, 22 Aug 2025 08:03:55 +0000 retitle 12800 Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid. reassign 12800 emacs submitter 12800 Paul Eggert severity 12800 normal tag 12800 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 04 14:29:08 2012 Received: (at submit) by debbugs.gnu.org; 4 Nov 2012 19:29:08 +0000 Received: from localhost ([127.0.0.1]:49280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TV5sZ-0006Ai-Cp for submit@debbugs.gnu.org; Sun, 04 Nov 2012 14:29:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57761) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TV5sW-0006Ab-LC for submit@debbugs.gnu.org; Sun, 04 Nov 2012 14:29:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TV5pZ-0004TA-LN for submit@debbugs.gnu.org; Sun, 04 Nov 2012 14:26:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, URIBL_BLACK autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TV5pZ-0004T6-HU for submit@debbugs.gnu.org; Sun, 04 Nov 2012 14:26:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TV5pX-00033m-Om for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2012 14:26:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TV5pV-0004SL-M5 for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2012 14:25:59 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:34763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TV5pV-0004SB-AY for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2012 14:25:57 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1B1ED39E810E for ; Sun, 4 Nov 2012 11:25:56 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x3oVdrXOArDI for ; Sun, 4 Nov 2012 11:25:55 -0800 (PST) Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 0F02339E8106 for ; Sun, 4 Nov 2012 11:25:55 -0800 (PST) Message-ID: <5096C143.8090204@cs.ucla.edu> Date: Sun, 04 Nov 2012 11:25:55 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) Tags: patch This is a proposed code-cleanup patch that arose from a discussion with Eli Zaretskii. Tested on GNU/Linux and on Solaris. === modified file 'ChangeLog' --- ChangeLog 2012-11-03 20:48:03 +0000 +++ ChangeLog 2012-11-04 19:22:04 +0000 @@ -1,3 +1,9 @@ +2012-11-04 Paul Eggert + + Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid. + * configure.ac (setpgid, setsid): Assume their existence. + (AC_FUNC_GETPGRP, SETPGRP_RELEASES_CTTY): Remove; obsolete. + 2012-11-03 Eli Zaretskii * lib/makefile.w32-in (GNULIBOBJS): Add $(BLD)/fpending.$(O) and === modified file 'admin/CPP-DEFINES' --- admin/CPP-DEFINES 2012-09-16 21:43:55 +0000 +++ admin/CPP-DEFINES 2012-11-04 19:22:04 +0000 @@ -298,9 +298,7 @@ HAVE_SEQPACKET HAVE_SETITIMER HAVE_SETLOCALE -HAVE_SETPGID HAVE_SETRLIMIT -HAVE_SETSID HAVE_SHARED_GAME_DIR HAVE_SHUTDOWN HAVE_SIGNED_${GLTYPE} @@ -433,7 +431,6 @@ PTY_TTY_NAME_SPRINTF PURESIZE RUN_TIME_REMAP -SETPGRP_RELEASES_CTTY SETUP_SLAVE_PTY SIGALRM SIGCHLD === modified file 'admin/ChangeLog' --- admin/ChangeLog 2012-11-03 19:19:05 +0000 +++ admin/ChangeLog 2012-11-04 19:22:04 +0000 @@ -1,3 +1,9 @@ +2012-11-04 Paul Eggert + + Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid. + * CPP-DEFINES (HAVE_SETPGID, HAVE_SETSID, SETPGRP_RELEASES_CTTY): + Remove; obsolete. + 2012-11-03 Glenn Morris * admin.el (set-copyright): Add msdos/sed2v2.inp. === modified file 'configure.ac' --- configure.ac 2012-11-02 00:48:12 +0000 +++ configure.ac 2012-11-04 19:22:04 +0000 @@ -2871,9 +2871,9 @@ AC_CHECK_FUNCS(gethostname \ closedir getrusage get_current_dir_name \ -lrand48 setsid \ +lrand48 \ fpathconf select euidaccess getpagesize setlocale \ -utimes getrlimit setrlimit setpgid getcwd shutdown getaddrinfo \ +utimes getrlimit setrlimit getcwd shutdown getaddrinfo \ __fpending strsignal setitimer \ sendto recvfrom getsockname getpeername getifaddrs freeifaddrs \ gai_strerror mkstemp getline getdelim fsync sync \ @@ -2916,8 +2916,6 @@ AC_FUNC_FSEEKO -AC_FUNC_GETPGRP - # UNIX98 PTYs. AC_CHECK_FUNCS(grantpt) @@ -4058,8 +4056,6 @@ irix6-5) AC_DEFINE(PREFER_VSUSP, 1, [Define if process_send_signal should use VSUSP instead of VSWTCH.]) - AC_DEFINE(SETPGRP_RELEASES_CTTY, 1, [Define if process.c:child_setup - should not call setpgrp.]) ;; sol2-10) === modified file 'src/ChangeLog' --- src/ChangeLog 2012-11-04 17:29:52 +0000 +++ src/ChangeLog 2012-11-04 19:22:04 +0000 @@ -1,5 +1,23 @@ 2012-11-04 Paul Eggert + Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid. + This removes code that has been obsolete since around 1990. + * callproc.c (Fcall_process): + * emacs.c (main): + * process.c (create_process): + * term.c (dissociate_if_controlling_tty): + Assume setsid exists. + * callproc.c (child_setup): Assume setpgid exists and behaves as + per POSIX.1-1988 or later. + * conf_post.h (setpgid) [!HAVE_SETPGID]: Remove. + * emacs.c (shut_down_emacs): + * sysdep.c (sys_suspend, init_foreground_group): + Assume getpgrp behaves as per POSIX.1-1998 or later. + * msdos.c (setpgrp): Remove. + (setpgid, setsid): New functions. + * systty.h (EMACS_GETPGRP): Remove. All callers now use getpgrp. + * term.c (no_controlling_tty): Remove; unused. + Fix data-loss with --version (Bug#9574). * emacs.c (close_output_streams): Use strerror, not emacs_strerror, as we can't assume that emacs_strerror is initialized, and strerror === modified file 'src/callproc.c' --- src/callproc.c 2012-10-31 17:27:29 +0000 +++ src/callproc.c 2012-11-04 19:22:04 +0000 @@ -612,11 +612,7 @@ if (fd[0] >= 0) emacs_close (fd[0]); -#ifdef HAVE_SETSID setsid (); -#else - setpgid (0, 0); -#endif /* Emacs ignores SIGPIPE, but the child should not. */ signal (SIGPIPE, SIG_DFL); @@ -1286,11 +1282,7 @@ if (err != in && err != out) emacs_close (err); -#if defined HAVE_SETPGID || ! (defined USG && defined SETPGRP_RELEASES_CTTY) - setpgid (pid, pid); -#endif - - /* setpgrp_of_tty is incorrect here; it uses input_fd. */ + setpgid (0, 0); tcsetpgrp (0, pid); /* execvp does not accept an environment arg so the only way === modified file 'src/conf_post.h' --- src/conf_post.h 2012-11-03 13:48:33 +0000 +++ src/conf_post.h 2012-11-04 19:22:04 +0000 @@ -121,14 +121,6 @@ #define emacs_raise(sig) msdos_fatal_signal (sig) -#ifndef HAVE_SETPGID -# ifdef USG -# define setpgid(pid, pgid) setpgrp () -# else -# define setpgid(pid, pgid) setpgrp (pid, pgid) -# endif -#endif - /* Define one of these for easier conditionals. */ #ifdef HAVE_X_WINDOWS /* We need a little extra space, see ../../lisp/loadup.el and the === modified file 'src/emacs.c' --- src/emacs.c 2012-11-04 17:29:52 +0000 +++ src/emacs.c 2012-11-04 19:22:04 +0000 @@ -1101,9 +1101,7 @@ that it is not accessible to programs started from .emacs. */ fcntl (daemon_pipe[1], F_SETFD, FD_CLOEXEC); -#ifdef HAVE_SETSID setsid (); -#endif #else /* DOS_NT */ fprintf (stderr, "This platform does not support the -daemon flag.\n"); exit (1); @@ -1915,7 +1913,7 @@ /* If we are controlling the terminal, reset terminal modes. */ #ifndef DOS_NT { - pid_t pgrp = EMACS_GETPGRP (0); + pid_t pgrp = getpgrp (); pid_t tpgrp = tcgetpgrp (0); if ((tpgrp != -1) && tpgrp == pgrp) { === modified file 'src/msdos.c' --- src/msdos.c 2012-11-03 13:48:33 +0000 +++ src/msdos.c 2012-11-04 19:22:04 +0000 @@ -3927,8 +3927,9 @@ /* * A few unimplemented functions that we silently ignore. */ -int setpgrp (void) {return 0; } +int setpgid (int pid, int pgid) { return 0; } int setpriority (int x, int y, int z) { return 0; } +pid_t setsid (void) { return 0; } #if __DJGPP__ == 2 && __DJGPP_MINOR__ < 4 ssize_t === modified file 'src/process.c' --- src/process.c 2012-11-03 18:32:41 +0000 +++ src/process.c 2012-11-04 19:22:04 +0000 @@ -1739,7 +1739,6 @@ /* Make the pty be the controlling terminal of the process. */ #ifdef HAVE_PTYS /* First, disconnect its current controlling terminal. */ -#ifdef HAVE_SETSID /* We tried doing setsid only if pty_flag, but it caused process_set_signal to fail on SGI when using a pipe. */ setsid (); @@ -1752,12 +1751,6 @@ ioctl (xforkin, TIOCSCTTY, 0); #endif } -#else /* not HAVE_SETSID */ - /* It's very important to call setpgid here and no time - afterwards. Otherwise, we lose our controlling tty which - is set when we open the pty. */ - setpgid (0, 0); -#endif /* not HAVE_SETSID */ #if defined (LDISC1) if (pty_flag && xforkin >= 0) { @@ -1790,22 +1783,15 @@ ioctl (j, TIOCNOTTY, 0); emacs_close (j); } -#ifndef USG - /* In order to get a controlling terminal on some versions - of BSD, it is necessary to put the process in pgrp 0 - before it opens the terminal. */ - setpgid (0, 0); -#endif } #endif /* TIOCNOTTY */ #if !defined (DONT_REOPEN_PTY) /*** There is a suggestion that this ought to be a - conditional on TIOCSPGRP, - or !(defined (HAVE_SETSID) && defined (TIOCSCTTY)). + conditional on TIOCSPGRP, or !defined TIOCSCTTY. Trying the latter gave the wrong results on Debian GNU/Linux 1.1; that system does seem to need this code, even though - both HAVE_SETSID and TIOCSCTTY are defined. */ + both TIOCSCTTY is defined. */ /* Now close the pty (if we had it open) and reopen it. This makes the pty the controlling terminal of the subprocess. */ if (pty_flag) === modified file 'src/sysdep.c' --- src/sysdep.c 2012-10-31 17:27:29 +0000 +++ src/sysdep.c 2012-11-04 19:22:04 +0000 @@ -452,7 +452,7 @@ #if defined (SIGTSTP) && !defined (MSDOS) { - pid_t pgrp = EMACS_GETPGRP (0); + pid_t pgrp = getpgrp (); EMACS_KILLPG (pgrp, SIGTSTP); } @@ -709,7 +709,7 @@ void init_foreground_group (void) { - pid_t pgrp = EMACS_GETPGRP (0); + pid_t pgrp = getpgrp (); inherited_pgroup = getpid () == pgrp ? 0 : pgrp; } === modified file 'src/systty.h' --- src/systty.h 2012-09-13 02:21:28 +0000 +++ src/systty.h 2012-11-04 19:22:04 +0000 @@ -63,16 +63,6 @@ #endif -/* Manipulate a terminal's current process group. */ - -/* EMACS_GETPGRP (arg) returns the process group of the process. */ - -#if defined (GETPGRP_VOID) -# define EMACS_GETPGRP(x) getpgrp() -#else /* !GETPGRP_VOID */ -# define EMACS_GETPGRP(x) getpgrp(x) -#endif /* !GETPGRP_VOID */ - /* Manipulate a TTY's input/output processing parameters. */ /* struct emacs_tty is a structure used to hold the current tty === modified file 'src/term.c' --- src/term.c 2012-11-03 05:59:17 +0000 +++ src/term.c 2012-11-04 19:22:04 +0000 @@ -133,10 +133,6 @@ static int max_frame_cols; -/* Non-zero if we have dropped our controlling tty and therefore - should not open a frame on stdout. */ -static int no_controlling_tty; - #ifdef HAVE_GPM @@ -2918,36 +2914,9 @@ static void dissociate_if_controlling_tty (int fd) { -#ifndef DOS_NT pid_t pgid = tcgetpgrp (fd); /* If tcgetpgrp succeeds, fd is the ctty. */ - if (pgid != -1) - { -#if defined (USG5) - setpgrp (); - no_controlling_tty = 1; -#elif defined (CYGWIN) - setsid (); - no_controlling_tty = 1; -#else -#ifdef TIOCNOTTY /* Try BSD ioctls. */ - sigset_t blocked; - sigemptyset (&blocked); - sigaddset (&blocked, SIGTTOU); - pthread_sigmask (SIG_BLOCK, &blocked, 0); - fd = emacs_open (DEV_TTY, O_RDWR, 0); - if (fd != -1 && ioctl (fd, TIOCNOTTY, 0) != -1) - { - no_controlling_tty = 1; - } - if (fd != -1) - emacs_close (fd); - pthread_sigmask (SIG_UNBLOCK, &blocked, 0); -#else -# error "Unknown system." -#endif /* ! TIOCNOTTY */ -#endif /* ! USG */ - } -#endif /* !DOS_NT */ + if (0 <= pgid) + setsid (); } /* Create a termcap display on the tty device with the given name and === modified file 'src/w32proc.c' --- src/w32proc.c 2012-11-01 14:21:45 +0000 +++ src/w32proc.c 2012-11-04 19:22:04 +0000 @@ -230,12 +230,6 @@ return (*set & (1U << signo)) != 0; } -int -setpgrp (int pid, int gid) -{ - return 0; -} - pid_t getpgrp (void) { @@ -248,6 +242,12 @@ return 0; } +pid_t +setsid (void) +{ + return getpid (); +} + /* Emulations of interval timers. Limitations: only ITIMER_REAL and ITIMER_PROF are supported. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 04 14:52:39 2012 Received: (at 12800) by debbugs.gnu.org; 4 Nov 2012 19:52:39 +0000 Received: from localhost ([127.0.0.1]:49288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TV6FL-0006jU-4E for submit@debbugs.gnu.org; Sun, 04 Nov 2012 14:52:39 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:54095) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TV6FI-0006jK-8y for 12800@debbugs.gnu.org; Sun, 04 Nov 2012 14:52:37 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MCZ00E00AYJ5L00@a-mtaout20.012.net.il> for 12800@debbugs.gnu.org; Sun, 04 Nov 2012 21:49:06 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCZ00DQBB1UCBC0@a-mtaout20.012.net.il>; Sun, 04 Nov 2012 21:49:06 +0200 (IST) Date: Sun, 04 Nov 2012 21:48:59 +0200 From: Eli Zaretskii Subject: Re: bug#12800: Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid. In-reply-to: <5096C143.8090204@cs.ucla.edu> X-012-Sender: halo1@inter.net.il To: Paul Eggert Message-id: <83bofd409g.fsf@gnu.org> References: <5096C143.8090204@cs.ucla.edu> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Sun, 04 Nov 2012 11:25:55 -0800 > From: Paul Eggert > > @@ -2918, 36 +2914, 9 @@ > static void > dissociate_if_controlling_tty (int fd) > { > -#ifndef DOS_NT > pid_t pgid = tcgetpgrp (fd); /* If tcgetpgrp succeeds, fd is the ctty. */ [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.166 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4859] X-Debbugs-Envelope-To: 12800 Cc: 12800@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > Date: Sun, 04 Nov 2012 11:25:55 -0800 > From: Paul Eggert > > @@ -2918,36 +2914,9 @@ > static void > dissociate_if_controlling_tty (int fd) > { > -#ifndef DOS_NT > pid_t pgid = tcgetpgrp (fd); /* If tcgetpgrp succeeds, fd is the ctty. */ The removal of the #ifndef will need a tcgetpgrp emulation for DOS_NT platforms, I think. Otherwise, I see no problems with this. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 04 22:24:45 2012 Received: (at 12800-done) by debbugs.gnu.org; 5 Nov 2012 03:24:45 +0000 Received: from localhost ([127.0.0.1]:49490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVDIq-0000pa-Qs for submit@debbugs.gnu.org; Sun, 04 Nov 2012 22:24:45 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:37204) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVDIm-0000pQ-TX for 12800-done@debbugs.gnu.org; Sun, 04 Nov 2012 22:24:42 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 16FCF39E8106; Sun, 4 Nov 2012 19:21:37 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cku73y87JaKR; Sun, 4 Nov 2012 19:21:36 -0800 (PST) Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id A9E8839E8100; Sun, 4 Nov 2012 19:21:36 -0800 (PST) Message-ID: <509730BC.6010801@cs.ucla.edu> Date: Sun, 04 Nov 2012 19:21:32 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#12800: Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid. References: <5096C143.8090204@cs.ucla.edu> <83bofd409g.fsf@gnu.org> In-Reply-To: <83bofd409g.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 12800-done Cc: 12800-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 11/04/2012 11:48 AM, Eli Zaretskii wrote: > The removal of the #ifndef will need a tcgetpgrp emulation for DOS_NT > platforms, I think. > > Otherwise, I see no problems with this. Thanks, I made that change, installed the patch as trunk bzr 110801, and am marking this as done. From unknown Fri Aug 22 01:03:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 03 Dec 2012 12:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator