From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 28 Oct 2012 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 12754@debbugs.gnu.org Cc: John David Anglin X-Debbugs-Original-To: bug-coreutils@gnu.org Reply-To: John David Anglin Received: via spool by submit@debbugs.gnu.org id=B.135145375627129 (code B ref -1); Sun, 28 Oct 2012 19:50:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Oct 2012 19:49:16 +0000 Received: from localhost ([127.0.0.1]:36956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSYrD-00073W-IF for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:49:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45428) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSYrB-00073P-7e for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:49:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSYos-0002nQ-8u for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:46:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYos-0002nL-5P for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:46:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYor-0000oa-8L for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:46:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSYoq-0002mz-9L for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:46:49 -0400 Received: from hiauly1.hia.nrc.ca ([132.246.10.84]:3034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYoq-0002mu-52 for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:46:48 -0400 Received: by hiauly1.hia.nrc.ca (Postfix, from userid 1000) id A441B5385; Sun, 28 Oct 2012 15:46:44 -0400 (EDT) Date: Sun, 28 Oct 2012 15:46:44 -0400 From: John David Anglin Message-ID: <20121028194643.GA15492@hiauly1.hia.nrc.ca> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline Organization: nrc.ca User-Agent: Mutt/1.5.16 (2007-06-09) X-detected-operating-system: by eggs.gnu.org: HP-UX B.10.20 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline When USE_LONGLONG_H is defined, factor.c unilaterally defines W_TYPE_SIZE to 64. This selects the wrong code from longlong.h on 32-bit hppa systems causing an assembly failure. Attached is a hack which should work on most but probably not all systems. Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="factor.c.d" --- factor.c.orig Tue Oct 23 10:14:12 2012 +++ factor.c Sun Oct 28 15:03:04 2012 @@ -124,7 +124,7 @@ #if USE_LONGLONG_H /* Make definitions for longlong.h to make it do what it can do for us */ -# define W_TYPE_SIZE 64 /* bitcount for uintmax_t */ +# define W_TYPE_SIZE (INT64_MAX_EQ_LONG_MAX ? 64 : 32) # define UWtype uintmax_t # define UHWtype unsigned long int # undef UDWtype --ZGiS0Q5IWpPtfppv-- From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: Acknowledgement (factor.c selects 64 bit code from longlong.h on 32-bit hppa systems) Resent-From: Dave Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 28 Oct 2012 21:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: <12754@debbugs.gnu.org> Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.13514615208948 (code B ref 12754); Sun, 28 Oct 2012 21:59:02 +0000 Received: (at 12754) by debbugs.gnu.org; 28 Oct 2012 21:58:40 +0000 Received: from localhost ([127.0.0.1]:37010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSasR-0002KG-7C for submit@debbugs.gnu.org; Sun, 28 Oct 2012 17:58:40 -0400 Received: from blu0-omc1-s29.blu0.hotmail.com ([65.55.116.40]:62334) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSasO-0002K7-EM for 12754@debbugs.gnu.org; Sun, 28 Oct 2012 17:58:37 -0400 Received: from BLU0-SMTP55 ([65.55.116.7]) by blu0-omc1-s29.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 28 Oct 2012 14:56:12 -0700 X-Originating-IP: [69.158.131.52] X-EIP: [9BcKqu9aMTUS3obxiZXYshSSdJKVZY0c] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.131.52]) by BLU0-SMTP55.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 28 Oct 2012 14:56:12 -0700 From: Dave Anglin In-Reply-To: Content-Type: text/plain; charset="US-ASCII"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 (Apple Message framework v936) Date: Sun, 28 Oct 2012 17:55:55 -0400 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 28 Oct 2012 21:56:12.0185 (UTC) FILETIME=[0B696090:01CDB557] X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) Patch is wrong. Maybe it is better to define NO_ASM. From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 29 Oct 2012 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: 12754@debbugs.gnu.org, John David Anglin Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.135147776831774 (code B ref 12754); Mon, 29 Oct 2012 02:30:02 +0000 Received: (at 12754) by debbugs.gnu.org; 29 Oct 2012 02:29:28 +0000 Received: from localhost ([127.0.0.1]:37143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSf6W-0008GR-35 for submit@debbugs.gnu.org; Sun, 28 Oct 2012 22:29:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51057) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSf6U-0008GJ-3M for 12754@debbugs.gnu.org; Sun, 28 Oct 2012 22:29:27 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9T2R1Yq021493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 28 Oct 2012 22:27:01 -0400 Received: from [10.36.116.16] (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9T2QwVX028322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 28 Oct 2012 22:27:00 -0400 Message-ID: <508DE972.8020103@draigBrady.com> Date: Mon, 29 Oct 2012 02:26:58 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> In-Reply-To: <20121028194643.GA15492@hiauly1.hia.nrc.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q9T2R1Yq021493 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) On 10/28/2012 07:46 PM, John David Anglin wrote: > When USE_LONGLONG_H is defined, factor.c unilaterally defines W_TYPE_SI= ZE > to 64. This selects the wrong code from longlong.h on 32-bit hppa syst= ems > causing an assembly failure. > > Attached is a hack which should work on most but probably not all syste= ms. This is closely related to the general solution I proposed for http://bugs.gnu.org/12753#8 I.E. making the size of uintmax_t available to the preprocessor. A particular size doesn't matter according to: http://lists.gnu.org/archive/html/bug-coreutils/2012-09/msg00111.html So I'll do something like the following. thanks, P=E1draig. diff --git a/src/factor.c b/src/factor.c index 4c2af98..1b1b37f 100644 --- a/src/factor.c +++ b/src/factor.c @@ -124,7 +124,16 @@ #if USE_LONGLONG_H /* Make definitions for longlong.h to make it do what it can do for us = */ -# define W_TYPE_SIZE 64 /* bitcount for uintmax_t */ + +/* bitcount for uintmax_t */ +#if UINTMAX_MAX =3D=3D UINT32_MAX +# define W_TYPE_SIZE 32 +#elif UINTMAX_MAX =3D=3D UINT64_MAX +# define W_TYPE_SIZE 64 +#elif UINTMAX_MAX =3D=3D UINT128_MAX +# define W_TYPE_SIZE 128 +#endif + # define UWtype uintmax_t # define UHWtype unsigned long int # undef UDWtype From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 29 Oct 2012 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12754@debbugs.gnu.org, John David Anglin Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.13515131484046 (code B ref 12754); Mon, 29 Oct 2012 12:20:02 +0000 Received: (at 12754) by debbugs.gnu.org; 29 Oct 2012 12:19:08 +0000 Received: from localhost ([127.0.0.1]:37587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSoJ8-00013B-2P for submit@debbugs.gnu.org; Mon, 29 Oct 2012 08:19:07 -0400 Received: from blu0-omc4-s14.blu0.hotmail.com ([65.55.111.153]:8806) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSoJ4-000131-JG for 12754@debbugs.gnu.org; Mon, 29 Oct 2012 08:19:04 -0400 Received: from BLU0-SMTP100 ([65.55.111.135]) by blu0-omc4-s14.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Oct 2012 05:16:35 -0700 X-Originating-IP: [69.158.131.52] X-EIP: [4d1U940AUFQAa01EBD6/5TbPZ+XEub4N] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.131.52]) by BLU0-SMTP100.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Oct 2012 05:16:34 -0700 From: John David Anglin In-Reply-To: <508DE972.8020103@draigBrady.com> References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 (Apple Message framework v936) Date: Mon, 29 Oct 2012 08:16:17 -0400 X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 29 Oct 2012 12:16:34.0945 (UTC) FILETIME=[3CF96F10:01CDB5CF] X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) On 28-Oct-12, at 10:26 PM, P=E1draig Brady wrote: > On 10/28/2012 07:46 PM, John David Anglin wrote: >> When USE_LONGLONG_H is defined, factor.c unilaterally defines =20 >> W_TYPE_SIZE >> to 64. This selects the wrong code from longlong.h on 32-bit hppa =20= >> systems >> causing an assembly failure. >> >> Attached is a hack which should work on most but probably not all =20 >> systems. > > This is closely related to the general solution I proposed > for http://bugs.gnu.org/12753#8 > I.E. making the size of uintmax_t available to the preprocessor. > A particular size doesn't matter according to: > http://lists.gnu.org/archive/html/bug-coreutils/2012-09/msg00111.html > > So I'll do something like the following. > > thanks, > P=E1draig. > > diff --git a/src/factor.c b/src/factor.c > index 4c2af98..1b1b37f 100644 > --- a/src/factor.c > +++ b/src/factor.c > @@ -124,7 +124,16 @@ > #if USE_LONGLONG_H > > /* Make definitions for longlong.h to make it do what it can do for =20= > us */ > -# define W_TYPE_SIZE 64 /* bitcount for uintmax_t */ > + > +/* bitcount for uintmax_t */ > +#if UINTMAX_MAX =3D=3D UINT32_MAX > +# define W_TYPE_SIZE 32 This won't work for 32-bit hppa systems because the uintmax_t type is 64 bits (long long) and the "word" size is 32 bits. The distinction =20 between the 64-bit and 32-bit runtimes is the size of long. I think the most =20= common cases are: @item ilp32 Target has 32-bit @code{int}, @code{long}, and pointers. @item lp64 Target has 32-bit @code{int}, 64-bit @code{long} and pointers. @item llp64 Target has 32-bit @code{int} and @code{long}, 64-bit @code{long long} and pointers. Dave -- John David Anglin dave.anglin@bell.net From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 29 Oct 2012 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin , Torbjorn Granlund Cc: 12754@debbugs.gnu.org, John David Anglin Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.13515166779231 (code B ref 12754); Mon, 29 Oct 2012 13:18:02 +0000 Received: (at 12754) by debbugs.gnu.org; 29 Oct 2012 13:17:57 +0000 Received: from localhost ([127.0.0.1]:37637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSpE0-0002On-Rm for submit@debbugs.gnu.org; Mon, 29 Oct 2012 09:17:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20770) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSpDu-0002Ob-VV for 12754@debbugs.gnu.org; Mon, 29 Oct 2012 09:17:51 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9TDFIDE006274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Oct 2012 09:15:18 -0400 Received: from [10.36.116.84] (ovpn-116-84.ams2.redhat.com [10.36.116.84]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9TDFDcN019793 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 29 Oct 2012 09:15:16 -0400 Message-ID: <508E8161.5060004@draigBrady.com> Date: Mon, 29 Oct 2012 13:15:13 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q9TDFIDE006274 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) On 10/29/2012 12:16 PM, John David Anglin wrote: > On 28-Oct-12, at 10:26 PM, P=E1draig Brady wrote: > >> On 10/28/2012 07:46 PM, John David Anglin wrote: >>> When USE_LONGLONG_H is defined, factor.c unilaterally defines W_TYPE_= SIZE >>> to 64. This selects the wrong code from longlong.h on 32-bit hppa sy= stems >>> causing an assembly failure. >>> >>> Attached is a hack which should work on most but probably not all sys= tems. >> >> This is closely related to the general solution I proposed >> for http://bugs.gnu.org/12753#8 >> I.E. making the size of uintmax_t available to the preprocessor. >> A particular size doesn't matter according to: >> http://lists.gnu.org/archive/html/bug-coreutils/2012-09/msg00111.html >> >> So I'll do something like the following. >> >> thanks, >> P=E1draig. >> >> diff --git a/src/factor.c b/src/factor.c >> index 4c2af98..1b1b37f 100644 >> --- a/src/factor.c >> +++ b/src/factor.c >> @@ -124,7 +124,16 @@ >> #if USE_LONGLONG_H >> >> /* Make definitions for longlong.h to make it do what it can do for us= */ >> -# define W_TYPE_SIZE 64 /* bitcount for uintmax_t */ >> + >> +/* bitcount for uintmax_t */ >> +#if UINTMAX_MAX =3D=3D UINT32_MAX >> +# define W_TYPE_SIZE 32 > > This won't work for 32-bit hppa systems because the uintmax_t type is > 64 bits (long long) and the "word" size is 32 bits. The distinction be= tween > the 64-bit and 32-bit runtimes is the size of long. I think the most c= ommon > cases are: > > @item ilp32 > Target has 32-bit @code{int}, @code{long}, and pointers. > > @item lp64 > Target has 32-bit @code{int}, 64-bit @code{long} and pointers. > > @item llp64 > Target has 32-bit @code{int} and @code{long}, 64-bit @code{long long} > and pointers. Sure, but from the message linked above it seems that the size of uintmax_t is significant here rather than the "word" size. Torbjorn should W_TYPE_SIZE match the "word" size or uintmax_t ? thanks, P=E1draig. From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: Torbjorn Granlund Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 29 Oct 2012 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12754@debbugs.gnu.org, John David Anglin , John David Anglin Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.135151739810217 (code B ref 12754); Mon, 29 Oct 2012 13:30:02 +0000 Received: (at 12754) by debbugs.gnu.org; 29 Oct 2012 13:29:58 +0000 Received: from localhost ([127.0.0.1]:37641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSpPh-0002ej-Oa for submit@debbugs.gnu.org; Mon, 29 Oct 2012 09:29:58 -0400 Received: from gmplib-02.nada.kth.se ([130.237.222.242]:53262 helo=shell.gmplib.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSpPd-0002eZ-MP for 12754@debbugs.gnu.org; Mon, 29 Oct 2012 09:29:56 -0400 Received: by shell.gmplib.org (Postfix, from userid 1001) id 4F90710A749; Mon, 29 Oct 2012 14:27:26 +0100 (CET) References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> From: Torbjorn Granlund Date: Mon, 29 Oct 2012 14:27:26 +0100 In-Reply-To: <508E8161.5060004@draigBrady.com> ("=?UTF-8?Q?P=C3=A1draig?= Brady"'s message of "Mon\, 29 Oct 2012 13\:15\:13 +0000") Message-ID: <86fw4xv269.fsf@shell.gmplib.org> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) P=C3=A1draig Brady writes: Sure, but from the message linked above it seems that the size of uintmax_t is significant here rather than the "word" size. =20=20 Torbjorn should W_TYPE_SIZE match the "word" size or uintmax_t ? =20=20 We're setting things up for arithmetic on uintmax_t (one or two of these). W_TYPE_SIZE is then used to ask longlong.h to define a couple of macros (documented in the beginning of that file) which provide arithmetic based on that size. Then longlong.h will do it in assembly or in C. W_TYPE_SIZE must thus be the size of uintmax_t. The problems we've seen are related to this slightly backward use of longlong in factor.c. In GMP (the main home of longlong.h) we figure out the real word size, and then define W_TYPE_SIZE to that. The trick around this is to find better API specific predefs to test in longlong.h, juist like P=C3=A1draig did for sparc. If no such predefs exis= t, we can either set something up via configure to define some cpp symbol, or we need to disable the problematic assembly. This will hurt performance, but will not affect program behaviour. --=20 Torbj=C3=B6rn From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 30 Oct 2012 02:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Torbjorn Granlund Cc: 12754@debbugs.gnu.org, John David Anglin , John David Anglin Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.135156251026344 (code B ref 12754); Tue, 30 Oct 2012 02:02:01 +0000 Received: (at 12754) by debbugs.gnu.org; 30 Oct 2012 02:01:50 +0000 Received: from localhost ([127.0.0.1]:38745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TT19K-0006qr-5i for submit@debbugs.gnu.org; Mon, 29 Oct 2012 22:01:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30821) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TT19H-0006qi-9o for 12754@debbugs.gnu.org; Mon, 29 Oct 2012 22:01:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9U1xFg4026514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Oct 2012 21:59:15 -0400 Received: from [10.36.116.84] (ovpn-116-84.ams2.redhat.com [10.36.116.84]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9U1xBRS016657 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 29 Oct 2012 21:59:13 -0400 Message-ID: <508F346F.4000300@draigBrady.com> Date: Tue, 30 Oct 2012 01:59:11 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> In-Reply-To: <86fw4xv269.fsf@shell.gmplib.org> Content-Type: text/plain; charset=UTF-8; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q9U1xFg4026514 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) On 10/29/2012 01:27 PM, Torbjorn Granlund wrote: > P=C3=A1draig Brady writes: > > Sure, but from the message linked above it seems that > the size of uintmax_t is significant here rather than the "word" siz= e. > > Torbjorn should W_TYPE_SIZE match the "word" size or uintmax_t ? > > We're setting things up for arithmetic on uintmax_t (one or two of > these). > > W_TYPE_SIZE is then used to ask longlong.h to define a couple of macros > (documented in the beginning of that file) which provide arithmetic > based on that size. Then longlong.h will do it in assembly or in C. > > W_TYPE_SIZE must thus be the size of uintmax_t. > > The problems we've seen are related to this slightly backward use of > longlong in factor.c. In GMP (the main home of longlong.h) we figure > out the real word size, and then define W_TYPE_SIZE to that. > > The trick around this is to find better API specific predefs to test in > longlong.h, juist like P=C3=A1draig did for sparc. If no such predefs = exist, > we can either set something up via configure to define some cpp symbol, > or we need to disable the problematic assembly. This will hurt > performance, but will not affect program behaviour. OK thanks for the info. I tested with gcc-4.3.2 on 9000/785/J6000 and similarly to the sparc case, the default compile failed because gcc defaulted to a more compatible arch. So using the same technique to get something for the preprocessor to key on... $ for cpu in 1.0 1.1 2.0; do echo "--------- $cpu --------" cpp -march=3D$cpu -dM /dev/null | grep -i pa_ done --------- 1.0 -------- #define _PA_RISC1_0 1 #define __hppa__ 1 --------- 1.1 -------- #define _PA_RISC1_1 1 #define __hppa__ 1 --------- 2.0 -------- #define _PA_RISC2_0 1 #define __hppa__ 1 Since 2.0 is the only arch that supports the 64 bit hppa code in longlong= .h, the following enables the code to compile by default. diff --git a/src/longlong.h b/src/longlong.h index 8d71611..8b01696 100644 --- a/src/longlong.h +++ b/src/longlong.h @@ -679,7 +679,7 @@ extern UWtype __MPN(udiv_qrnnd) (UWtype *, UWtype, UW= type, UWtype); /* These macros are for ABI=3D2.0w. In ABI=3D2.0n they can't be used, = since GCC (3.2) puts longlong into two adjacent 32-bit registers. Presumably = this is just a case of no direct support for 2.0n but treating it like 1.= 0. */ -#if defined (__hppa) && W_TYPE_SIZE =3D=3D 64 && ! defined (_LONG_LONG_L= IMB) +#if defined (__hppa) && defined (_PA_RISC2_0) && W_TYPE_SIZE =3D=3D 64 &= & ! defined (_LONG_LONG_LIMB) #define add_ssaaaa(sh, sl, ah, al, bh, bl) \ __asm__ ("add%I5 %5,%r4,%1\n\tadd,dc %r2,%r3,%0" = \ : "=3Dr" (sh), "=3D&r" (sl) = \ Note even though I've not encountered a system yet where uintmax_t !=3D 6= 4 bit, I'll add the guards around "#define W_TYPE_SIZE", previously mentioned in this thread, in a separate patch. cheers, P=C3=A1draig. From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 30 Oct 2012 03:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12754@debbugs.gnu.org, John David Anglin , Torbjorn Granlund Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.13515682406833 (code B ref 12754); Tue, 30 Oct 2012 03:38:01 +0000 Received: (at 12754) by debbugs.gnu.org; 30 Oct 2012 03:37:20 +0000 Received: from localhost ([127.0.0.1]:38783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TT2dk-0001m9-3m for submit@debbugs.gnu.org; Mon, 29 Oct 2012 23:37:20 -0400 Received: from blu0-omc4-s37.blu0.hotmail.com ([65.55.111.176]:24962) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TT2dh-0001m1-Bp for 12754@debbugs.gnu.org; Mon, 29 Oct 2012 23:37:18 -0400 Received: from BLU0-SMTP48 ([65.55.111.137]) by blu0-omc4-s37.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Oct 2012 20:34:47 -0700 X-Originating-IP: [69.158.131.52] X-EIP: [Rh8c8l5E3U/XOQu17h3dj8C0vCW6FN4r] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.131.52]) by BLU0-SMTP48.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Oct 2012 20:34:46 -0700 From: John David Anglin In-Reply-To: <508F346F.4000300@draigBrady.com> References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 (Apple Message framework v936) Date: Mon, 29 Oct 2012 23:34:29 -0400 X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 30 Oct 2012 03:34:46.0905 (UTC) FILETIME=[82576690:01CDB64F] X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) On 29-Oct-12, at 9:59 PM, P=E1draig Brady wrote: > --------- 2.0 -------- > #define _PA_RISC2_0 1 > #define __hppa__ 1 > > Since 2.0 is the only arch that supports the 64 bit hppa code in =20 > longlong.h, > the following enables the code to compile by default. The issue is _PA_RISC2_0 is not sufficient to distinguish between the =20= 32-bit and 64-bit PA runtimes. While all PA 2.0 systems accept double word =20 add instructions, it's possible for the context to get clobbered between the add and =20 add,dc instructions in the asm on Linux and narrow HP-UX kernels. Not sure =20 about BSD but it generally follows Linux. GCC only generates double word instructions when compiling for the 64-=20= bit runtime. For the 32-bit runtime, a long long has to be placed in two separate =20 registers to meet the calling conventions. So, long longs are handled the same as =20= for PA 1.X. The ABI=3D2.0w refers to a 64-bit HP-UX kernel. All 64-bit HP-UX =20 kernels support both the 32 and 64-bit runtimes. It is possible to optimize certain =20 operations in the 32-bit runtime using the 64-bit registers on but the benefit is not as great =20= as one might expect because of the calling convention requirements. An additional check such as the size of long is needed to distinguish =20= the two cases. Dave -- John David Anglin dave.anglin@bell.net From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: Torbjorn Granlund Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 30 Oct 2012 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: 12754@debbugs.gnu.org, John David Anglin , =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.135159117610898 (code B ref 12754); Tue, 30 Oct 2012 10:00:02 +0000 Received: (at 12754) by debbugs.gnu.org; 30 Oct 2012 09:59:36 +0000 Received: from localhost ([127.0.0.1]:39096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TT8bg-0002pj-Ft for submit@debbugs.gnu.org; Tue, 30 Oct 2012 05:59:36 -0400 Received: from gmplib-02.nada.kth.se ([130.237.222.242]:37247 helo=shell.gmplib.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TT8bd-0002pb-Rg for 12754@debbugs.gnu.org; Tue, 30 Oct 2012 05:59:35 -0400 Received: by shell.gmplib.org (Postfix, from userid 1001) id D6287107094; Tue, 30 Oct 2012 10:57:01 +0100 (CET) References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> From: Torbjorn Granlund Date: Tue, 30 Oct 2012 10:57:01 +0100 In-Reply-To: (John David Anglin's message of "Mon\, 29 Oct 2012 23\:34\:29 -0400") Message-ID: <867gq8uvte.fsf@shell.gmplib.org> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) John David Anglin writes: The issue is _PA_RISC2_0 is not sufficient to distinguish between the 32-bit and 64-bit PA runtimes. While all PA 2.0 systems accept double word add instructions, it's possible for the context to get clobbered between the add and add,dc instructions in the asm on Linux and narrow HP-UX kernels. Not sure about BSD but it generally follows Linux. =20=20 BSD supports PA 2.0 and has done so for the last decade. The fix for this is long overdue and should be made to GCC; GCC should not support generation of code that will cause register clobbering issues. A compilation for the 2.0 ISA on GNU/Linux should be considered a cross compilation, and the target hppa-linux-gnu should be unsupported. I don't have any proposal for a temporary workaround in GNU coreutils. I have not implemented any workaround for GMP, and this seem to work OK. Very few people choose GNU/Linux on PA 2.0 systems for obvious reasons. GCC only generates double word instructions when compiling for the 64- bit runtime. For the 32-bit runtime, a long long has to be placed in two separate registers to meet the calling conventions. So, long longs are handled the same as for PA 1.X. GCC uses the 64-bit registers if PA 2.0 when it generates code for 2.0. The parameter transfer is the same for the 2.0n and 1.0 ABIs. =20=20 The ABI=3D2.0w refers to a 64-bit HP-UX kernel. Huh? All 64-bit HP-UX kernels support both the 32 and 64-bit runtimes. It is possible to optimize certain operations in the 32-bit runtime using the 64-bit registers on but the benefit is not as great as one might expect because of the calling convention requirements. I expect a two-fold improvement for certain operations, and that's indeed what we get in GMP. But the speed issues seem secondary in this discusson. I regret the decison of the the Linux hppa hacker to not support 2.0, but I respect it. The correctness issues imposed by the incomatibility of the kernel and GCC is much more serious. An additional check such as the size of long is needed to distinguish the two cases. =20=20 I believe that is incorrect, since long will stay 32 bits in the ABI denoted 2.0n. --=20 Torbj=C3=B6rn From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 30 Oct 2012 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Torbjorn Granlund Cc: 12754@debbugs.gnu.org, John David Anglin , John David Anglin Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.135159263613008 (code B ref 12754); Tue, 30 Oct 2012 10:24:02 +0000 Received: (at 12754) by debbugs.gnu.org; 30 Oct 2012 10:23:56 +0000 Received: from localhost ([127.0.0.1]:39115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TT8zD-0003Nk-2f for submit@debbugs.gnu.org; Tue, 30 Oct 2012 06:23:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62265) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TT8z8-0003NZ-S4 for 12754@debbugs.gnu.org; Tue, 30 Oct 2012 06:23:53 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9UALINJ012882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Oct 2012 06:21:18 -0400 Received: from [10.36.116.79] (ovpn-116-79.ams2.redhat.com [10.36.116.79]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9UALEsk010529 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 30 Oct 2012 06:21:16 -0400 Message-ID: <508FAA1A.7060803@draigBrady.com> Date: Tue, 30 Oct 2012 10:21:14 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <867gq8uvte.fsf@shell.gmplib.org> In-Reply-To: <867gq8uvte.fsf@shell.gmplib.org> Content-Type: text/plain; charset=UTF-8; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q9UALINJ012882 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) On 10/30/2012 09:57 AM, Torbjorn Granlund wrote: > John David Anglin writes: > > The issue is _PA_RISC2_0 is not sufficient to distinguish between th= e > 32-bit and 64-bit PA runtimes. While all PA 2.0 systems accept doub= le > word add instructions, it's possible for the context to get clobbere= d > between the add and add,dc instructions in the asm on Linux and narr= ow > HP-UX kernels. Not sure about BSD but it generally follows Linux. > > BSD supports PA 2.0 and has done so for the last decade. All BSDs? > The fix for this is long overdue and should be made to GCC; GCC should > not support generation of code that will cause register clobbering > issues. > > A compilation for the 2.0 ISA on GNU/Linux should be considered a cross > compilation, and the target hppa-linux-gnu should be unsupported. > > I don't have any proposal for a temporary workaround in GNU coreutils. > I have not implemented any workaround for GMP, and this seem to work OK. > Very few people choose GNU/Linux on PA 2.0 systems for obvious reasons. > > GCC only generates double word instructions when compiling for the 6= 4- > bit runtime. For the 32-bit runtime, a long long has to be placed i= n > two separate registers to meet the calling conventions. So, long > longs are handled the same as for PA 1.X. > > GCC uses the 64-bit registers if PA 2.0 when it generates code for 2.0. > The parameter transfer is the same for the 2.0n and 1.0 ABIs. > > The ABI=3D2.0w refers to a 64-bit HP-UX kernel. > > Huh? > > All 64-bit HP-UX kernels support both the 32 and 64-bit runtimes. I= t > is possible to optimize certain operations in the 32-bit runtime usi= ng > the 64-bit registers on but the benefit is not as great as one might > expect because of the calling convention requirements. > > I expect a two-fold improvement for certain operations, and that's > indeed what we get in GMP. But the speed issues seem secondary in this > discusson. I regret the decison of the the Linux hppa hacker to not > support 2.0, but I respect it. The correctness issues imposed by the > incomatibility of the kernel and GCC is much more serious. > > An additional check such as the size of long is needed to distinguis= h > the two cases. > > I believe that is incorrect, since long will stay 32 bits in the ABI > denoted 2.0n. You're saying this is incorrect because it needlessly penalizes the gcc/bsd combination on 2.0n ? If we could quantify which BSDs this was OK on, I might construct an appropriate ifdef to enable this assembly. Though at this stage I'm leaning towards disabling the code on 2.0n along the lines of the following. commit 10a094b7403810c9b2775361d9d477f4c9aeb02b Author: P=C3=A1draig Brady Date: Tue Oct 30 02:02:05 2012 +0000 build: avoid build failure on some HPPA systems * src/longlong.h: Restrict some HPPA assembly variants to PA RISC V2.0. Note we also avoid this assembly for ilp32 runtimes, since even though the assembly is accepted there, it's not safe as the context can get clobbered between the 'add' and 'add,dc'. This fixes a compile failure with newer HPPA systems with default gcc CPU options. Reported by John David Anglin diff --git a/THANKS.in b/THANKS.in index 016a41e..6dc024b 100644 --- a/THANKS.in +++ b/THANKS.in @@ -303,6 +303,7 @@ Joey Hess joeyh@debian.org Johan Boule bohan@bohan.dyndns.org Johan Danielsson joda@pdc.kth.se John Bley jbb6@acpub.duke.edu +John David Anglin dave.anglin@bell.net John Gatewood Ham zappaman@alphabox.compsci.buu.ac.th John Gotts jgotts@umich.edu John Kendall kendall@capps.com diff --git a/src/longlong.h b/src/longlong.h index 8d71611..6a9ae48 100644 --- a/src/longlong.h +++ b/src/longlong.h @@ -679,7 +679,13 @@ extern UWtype __MPN(udiv_qrnnd) (UWtype *, UWtype, U= Wtype, /* These macros are for ABI=3D2.0w. In ABI=3D2.0n they can't be used, = since GCC (3.2) puts longlong into two adjacent 32-bit registers. Presumably = this is just a case of no direct support for 2.0n but treating it like 1.= 0. */ -#if defined (__hppa) && W_TYPE_SIZE =3D=3D 64 && ! defined (_LONG_LONG_L= IMB) +#if defined (__hppa) && W_TYPE_SIZE =3D=3D 64 && ! defined (_LONG_LONG_L= IMB) \ + && defined (_PA_RISC2_0) && (ULONGMAX_MAX =3D=3D UINT64_MAX) +/* Note the _PA_RISC2_0 above is to exclude this code from GCC with + default -march options which doesn't support these instructions. + Also the width check for 'long' is to avoid ilp32 runtimes where + GNU/Linux and narrow HP-UX kernels are known to have issues with + clobbering of context between the add and add,dc instructions. */ #define add_ssaaaa(sh, sl, ah, al, bh, bl) \ __asm__ ("add%I5 %5,%r4,%1\n\tadd,dc %r2,%r3,%0" = \ : "=3Dr" (sh), "=3D&r" (sl) = \ From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 30 Oct 2012 13:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12754@debbugs.gnu.org, John David Anglin , Torbjorn Granlund Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.1351604411748 (code B ref 12754); Tue, 30 Oct 2012 13:41:01 +0000 Received: (at 12754) by debbugs.gnu.org; 30 Oct 2012 13:40:11 +0000 Received: from localhost ([127.0.0.1]:39208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTC38-0000C1-Ax for submit@debbugs.gnu.org; Tue, 30 Oct 2012 09:40:10 -0400 Received: from mail16.primus.ca ([216.254.141.183]:34221 helo=mail-07.primus.ca) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTC34-0000Br-Vt for 12754@debbugs.gnu.org; Tue, 30 Oct 2012 09:40:07 -0400 Received: from 216-58-40-249.cpe.distributel.net ([216.58.40.249] helo=[192.168.0.181]) by mail-07.primus.ca with esmtpa (Exim 4.72) (envelope-from ) id 1TTC0a-0000pE-2T; Tue, 30 Oct 2012 09:37:32 -0400 Message-ID: <508FD80F.3040808@bell.net> Date: Tue, 30 Oct 2012 09:37:19 -0400 From: John David Anglin User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <867gq8uvte.fsf@shell.gmplib.org> <508FAA1A.7060803@draigBrady.com> In-Reply-To: <508FAA1A.7060803@draigBrady.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated: danglin-lux@magma.ca - 216-58-40-249.cpe.distributel.net ([192.168.0.181]) [216.58.40.249] X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 10/30/2012 6:21 AM, =?UTF-8?Q?P=C3=A1draig?= Brady wrote: > -#if defined (__hppa) && W_TYPE_SIZE == 64 && ! defined (_LONG_LONG_LIMB) > +#if defined (__hppa) && W_TYPE_SIZE == 64 && ! defined > (_LONG_LONG_LIMB) \ > + && defined (_PA_RISC2_0) && (ULONGMAX_MAX == UINT64_MAX) > +/* Note the _PA_RISC2_0 above is to exclude this code from GCC with > + default -march options which doesn't support these instructions. > + Also the width check for 'long' is to avoid ilp32 runtimes where > + GNU/Linux and narrow HP-UX kernels are known to have issues with > + clobbering of context between the add and add,dc instructions. */ This #if looks good to me. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 10/30/2012 6:21 AM, =?UTF-8?Q?P=C3=A1draig?= Brady wrote: > -#if defined (__hppa) && W_TYPE_SIZE == 64 && ! defined (_LONG_LONG_LIMB) > +#if defined (__hppa) && W_TYPE_SIZE == 64 && ! defined > (_LONG_LONG_LIMB) \ > + && defined (_PA_RISC2_0) && (ULONGMAX_MAX == UINT64_MAX) > +/* Note the _PA_RISC2_0 above is to exclude this code from GCC with > + default -march options which doesn't support these instructions. > + Also the width check for 'long' is to avoid ilp32 runtimes where > + GNU/Linux and narrow HP-UX kernels are known to have issues with > + clobbering of context between the add and add,dc instructions. */ This #if looks good to me. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4999] On 10/30/2012 6:21 AM, Pádraig Brady wrote: > -#if defined (__hppa) && W_TYPE_SIZE == 64 && ! defined (_LONG_LONG_LIMB) > +#if defined (__hppa) && W_TYPE_SIZE == 64 && ! defined > (_LONG_LONG_LIMB) \ > + && defined (_PA_RISC2_0) && (ULONGMAX_MAX == UINT64_MAX) > +/* Note the _PA_RISC2_0 above is to exclude this code from GCC with > + default -march options which doesn't support these instructions. > + Also the width check for 'long' is to avoid ilp32 runtimes where > + GNU/Linux and narrow HP-UX kernels are known to have issues with > + clobbering of context between the add and add,dc instructions. */ This #if looks good to me. Note HP compilers also define _PA_RISC2_0 when generating PA 2.0 assembly code. Thanks, Dave -- John David Anglin dave.anglin@bell.net From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 30 Oct 2012 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Torbjorn Granlund Cc: 12754@debbugs.gnu.org, John David Anglin , =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.135161182511791 (code B ref 12754); Tue, 30 Oct 2012 15:44:02 +0000 Received: (at 12754) by debbugs.gnu.org; 30 Oct 2012 15:43:45 +0000 Received: from localhost ([127.0.0.1]:39804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTDyj-000348-91 for submit@debbugs.gnu.org; Tue, 30 Oct 2012 11:43:45 -0400 Received: from mail16.primus.ca ([216.254.141.183]:47989 helo=mail-07.primus.ca) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTDyh-000341-Lt for 12754@debbugs.gnu.org; Tue, 30 Oct 2012 11:43:44 -0400 Received: from 216-58-40-249.cpe.distributel.net ([216.58.40.249] helo=[192.168.0.181]) by mail-07.primus.ca with esmtpa (Exim 4.72) (envelope-from ) id 1TTDwD-0007SV-1M; Tue, 30 Oct 2012 11:41:09 -0400 Message-ID: <508FF508.9090008@bell.net> Date: Tue, 30 Oct 2012 11:40:56 -0400 From: John David Anglin User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <867gq8uvte.fsf@shell.gmplib.org> In-Reply-To: <867gq8uvte.fsf@shell.gmplib.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated: danglin-lux@magma.ca - 216-58-40-249.cpe.distributel.net ([192.168.0.181]) [216.58.40.249] X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 10/30/2012 5:57 AM, Torbjorn Granlund wrote: > The fix for this is long overdue and should be made to GCC; GCC should > not support generation of code that will cause register clobbering > issues. As far as I'm aware, GCC does not generate code that will cause register clobbering issues. What applications do in asms is beyond the control of GCC. > GCC uses the 64-bit registers if PA 2.0 when it generates code for 2.0. > The parameter transfer is the same for the 2.0n and 1.0 ABIs. Incorrect. GCC supports generate generation of PA 2.0 code for both 32 and 64-bit environments. > > The ABI=2.0w refers to a 64-bit HP-UX kernel. > > Huh? I assume you are thinking about the ABI parameter used by GMP. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 10/30/2012 5:57 AM, Torbjorn Granlund wrote: > The fix for this is long overdue and should be made to GCC; GCC should > not support generation of code that will cause register clobbering > issues. As far as I'm aware, GCC does not generate code that will cause register clobbering issues. What applications do in asms is beyond the control of GCC. > GCC uses the 64-bit registers if PA 2.0 when it generates code for 2.0. > The parameter transfer is the same for the 2.0n and 1.0 ABIs. Incorrect. GCC supports generate generation of PA 2.0 code for both 32 and 64-bit environments. > > The ABI=2.0w refers to a 64-bit HP-UX kernel. > > Huh? I assume you are thinking about the ABI parameter used by GMP. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] On 10/30/2012 5:57 AM, Torbjorn Granlund wrote: > The fix for this is long overdue and should be made to GCC; GCC should > not support generation of code that will cause register clobbering > issues. As far as I'm aware, GCC does not generate code that will cause register clobbering issues. What applications do in asms is beyond the control of GCC. > GCC uses the 64-bit registers if PA 2.0 when it generates code for 2.0. > The parameter transfer is the same for the 2.0n and 1.0 ABIs. Incorrect. GCC supports generate generation of PA 2.0 code for both 32 and 64-bit environments. > > The ABI=2.0w refers to a 64-bit HP-UX kernel. > > Huh? I assume you are thinking about the ABI parameter used by GMP. Look at config.guess to see how it works. When it returns "hppa2.0w" for the target machine, the target has a 64-bit wide kernel and the compiler is generating code for the 32-bit runtime. It returns "hppa64" when the target is generating code for the 64-bit ELF runtime. In terms of assembly code, this is the difference between ".level 2.0" and ".level 2.0w". > > All 64-bit HP-UX kernels support both the 32 and 64-bit runtimes. It > is possible to optimize certain operations in the 32-bit runtime using > the 64-bit registers on but the benefit is not as great as one might > expect because of the calling convention requirements. > > I expect a two-fold improvement for certain operations, and that's > indeed what we get in GMP. But the speed issues seem secondary in this > discusson. I regret the decison of the the Linux hppa hacker to not > support 2.0, but I respect it. The correctness issues imposed by the > incomatibility of the kernel and GCC is much more serious. > > You are essentially arguing for a second 32-bit runtime with 64-bit registers, calling conventions, probably based on ELF. I know there were discussions in HP about this but it was never fully defined. There is no incompatibility between GCC and the kernel as far as I know. Specifically, what are you talking about? The initial decisions regarding the runtime architecture for Linux were taken by HP and it contractors. Yes, it would have been nice if support was there for a full 64-bit context when the kernel was running on a PA 2.0 machine. Changing it now will break userspace exception support in a variety of applications. There are certainly some opportunities to improve optimizations for HP-UX specific code. In the present case, this can be tested for using the "__hpux__" preprocessor define. Dave -- John David Anglin dave.anglin@bell.net From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: Torbjorn Granlund Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 30 Oct 2012 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: 12754@debbugs.gnu.org, John David Anglin , =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 12754-submit@debbugs.gnu.org id=B12754.135161523016750 (code B ref 12754); Tue, 30 Oct 2012 16:41:02 +0000 Received: (at 12754) by debbugs.gnu.org; 30 Oct 2012 16:40:30 +0000 Received: from localhost ([127.0.0.1]:39836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTEre-0004M7-Ha for submit@debbugs.gnu.org; Tue, 30 Oct 2012 12:40:30 -0400 Received: from gmplib-02.nada.kth.se ([130.237.222.242]:21533 helo=shell.gmplib.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTErX-0004La-Oc for 12754@debbugs.gnu.org; Tue, 30 Oct 2012 12:40:27 -0400 Received: by shell.gmplib.org (Postfix, from userid 1001) id 909FF1070F2; Tue, 30 Oct 2012 17:37:48 +0100 (CET) References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <867gq8uvte.fsf@shell.gmplib.org> <508FF508.9090008@bell.net> From: Torbjorn Granlund Date: Tue, 30 Oct 2012 17:37:48 +0100 In-Reply-To: <508FF508.9090008@bell.net> (John David Anglin's message of "Tue\, 30 Oct 2012 11\:40\:56 -0400") Message-ID: <86hapbsyoz.fsf@shell.gmplib.org> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) No disrespect intended, but I am unable to continue the discussion about HP and Linux. --=20 Torbj=C3=B6rn From unknown Mon Jun 23 06:01:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: John David Anglin Subject: bug#12754: closed (Re: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems) Message-ID: References: <5095BCB1.7090100@draigBrady.com> <20121028194643.GA15492@hiauly1.hia.nrc.ca> X-Gnu-PR-Message: they-closed 12754 X-Gnu-PR-Package: coreutils Reply-To: 12754@debbugs.gnu.org Date: Sun, 04 Nov 2012 00:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1351990682-8166-1" This is a multi-part message in MIME format... ------------=_1351990682-8166-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 12754@debbugs.gnu.org. --=20 12754: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12754 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1351990682-8166-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 12754-done) by debbugs.gnu.org; 4 Nov 2012 00:57:17 +0000 Received: from localhost ([127.0.0.1]:47779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUoWb-00026l-3u for submit@debbugs.gnu.org; Sat, 03 Nov 2012 20:57:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24332) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUoWX-00026d-Uj for 12754-done@debbugs.gnu.org; Sat, 03 Nov 2012 20:57:15 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA40sDsd003143 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Nov 2012 20:54:14 -0400 Received: from [10.36.116.18] (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA40sAAo024882 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 3 Nov 2012 20:54:12 -0400 Message-ID: <5095BCB1.7090100@draigBrady.com> Date: Sun, 04 Nov 2012 00:54:09 +0000 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Torbjorn Granlund Subject: Re: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> In-Reply-To: <508F346F.4000300@draigBrady.com> Content-Type: text/plain; charset=UTF-8; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id qA40sDsd003143 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 12754-done Cc: 12754-done@debbugs.gnu.org, John David Anglin , John David Anglin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) On 10/30/2012 01:59 AM, P=C3=A1draig Brady wrote: > Since 2.0 is the only arch that supports the 64 bit hppa code in longlo= ng.h, > the following enables the code to compile by default. > > diff --git a/src/longlong.h b/src/longlong.h > index 8d71611..8b01696 100644 > --- a/src/longlong.h > +++ b/src/longlong.h > @@ -679,7 +679,7 @@ extern UWtype __MPN(udiv_qrnnd) (UWtype *, UWtype, = UWtype, UWtype); > /* These macros are for ABI=3D2.0w. In ABI=3D2.0n they can't be used= , since GCC > (3.2) puts longlong into two adjacent 32-bit registers. Presumabl= y this > is just a case of no direct support for 2.0n but treating it like = 1.0. */ > -#if defined (__hppa) && W_TYPE_SIZE =3D=3D 64 && ! defined (_LONG_LONG= _LIMB) > +#if defined (__hppa) && defined (_PA_RISC2_0) && W_TYPE_SIZE =3D=3D 64= && ! defined (_LONG_LONG_LIMB) > #define add_ssaaaa(sh, sl, ah, al, bh, bl) \ > __asm__ ("add%I5 %5,%r4,%1\n\tadd,dc %r2,%r3,%0" = \ > : "=3Dr" (sh), "=3D&r" (sl) = \ > > Note even though I've not encountered a system yet where uintmax_t !=3D= 64 bit, > I'll add the guards around "#define W_TYPE_SIZE", previously mentioned = in > this thread, in a separate patch. I've now pushed the patch set discussed in this thread, so I'm marking this bug as done. cheers, P=C3=A1draig. ------------=_1351990682-8166-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Oct 2012 19:49:16 +0000 Received: from localhost ([127.0.0.1]:36956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSYrD-00073W-IF for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:49:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45428) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSYrB-00073P-7e for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:49:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSYos-0002nQ-8u for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:46:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYos-0002nL-5P for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:46:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYor-0000oa-8L for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:46:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSYoq-0002mz-9L for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:46:49 -0400 Received: from hiauly1.hia.nrc.ca ([132.246.10.84]:3034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYoq-0002mu-52 for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:46:48 -0400 Received: by hiauly1.hia.nrc.ca (Postfix, from userid 1000) id A441B5385; Sun, 28 Oct 2012 15:46:44 -0400 (EDT) Date: Sun, 28 Oct 2012 15:46:44 -0400 From: John David Anglin To: bug-coreutils@gnu.org Subject: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Message-ID: <20121028194643.GA15492@hiauly1.hia.nrc.ca> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline Organization: nrc.ca User-Agent: Mutt/1.5.16 (2007-06-09) X-detected-operating-system: by eggs.gnu.org: HP-UX B.10.20 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit Cc: John David Anglin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: John David Anglin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline When USE_LONGLONG_H is defined, factor.c unilaterally defines W_TYPE_SIZE to 64. This selects the wrong code from longlong.h on 32-bit hppa systems causing an assembly failure. Attached is a hack which should work on most but probably not all systems. Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="factor.c.d" --- factor.c.orig Tue Oct 23 10:14:12 2012 +++ factor.c Sun Oct 28 15:03:04 2012 @@ -124,7 +124,7 @@ #if USE_LONGLONG_H /* Make definitions for longlong.h to make it do what it can do for us */ -# define W_TYPE_SIZE 64 /* bitcount for uintmax_t */ +# define W_TYPE_SIZE (INT64_MAX_EQ_LONG_MAX ? 64 : 32) # define UWtype uintmax_t # define UHWtype unsigned long int # undef UDWtype --ZGiS0Q5IWpPtfppv-- ------------=_1351990682-8166-1-- From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 01:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12754-done@debbugs.gnu.org, John David Anglin , Torbjorn Granlund Received: via spool by 12754-done@debbugs.gnu.org id=D12754.135199249710789 (code D ref 12754); Sun, 04 Nov 2012 01:29:01 +0000 Received: (at 12754-done) by debbugs.gnu.org; 4 Nov 2012 01:28:17 +0000 Received: from localhost ([127.0.0.1]:47807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUp0Z-0002nw-0D for submit@debbugs.gnu.org; Sat, 03 Nov 2012 21:28:17 -0400 Received: from blu0-omc4-s2.blu0.hotmail.com ([65.55.111.141]:3161) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUp0W-0002nn-7k for 12754-done@debbugs.gnu.org; Sat, 03 Nov 2012 21:28:13 -0400 Received: from BLU0-SMTP70 ([65.55.111.137]) by blu0-omc4-s2.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 3 Nov 2012 18:25:14 -0700 X-Originating-IP: [69.158.131.52] X-EIP: [aX+kLcrzlRE92vxHpPywt4dnKzIeaELx] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.131.52]) by BLU0-SMTP70.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 3 Nov 2012 18:25:14 -0700 From: John David Anglin In-Reply-To: <5095BCB1.7090100@draigBrady.com> References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <5095BCB1.7090100@draigBrady.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 (Apple Message framework v936) Date: Sat, 3 Nov 2012 21:25:04 -0400 X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 04 Nov 2012 01:25:14.0447 (UTC) FILETIME=[3DA92DF0:01CDBA2B] X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) On 3-Nov-12, at 8:54 PM, P=E1draig Brady wrote: > I've now pushed the patch set discussed in this thread, > so I'm marking this bug as done. Hopefully, it's the one with the _LP64 check. Regards, Dave -- John David Anglin dave.anglin@bell.net From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 01:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: 12754-done@debbugs.gnu.org, John David Anglin , Torbjorn Granlund Received: via spool by 12754-done@debbugs.gnu.org id=D12754.135199363712405 (code D ref 12754); Sun, 04 Nov 2012 01:48:02 +0000 Received: (at 12754-done) by debbugs.gnu.org; 4 Nov 2012 01:47:17 +0000 Received: from localhost ([127.0.0.1]:47816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpIz-0003E2-8B for submit@debbugs.gnu.org; Sat, 03 Nov 2012 21:47:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38874) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpIy-0003Dv-11 for 12754-done@debbugs.gnu.org; Sat, 03 Nov 2012 21:47:16 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA41iH4g030694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Nov 2012 21:44:18 -0400 Received: from [10.36.116.18] (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA41iE8Z017030 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 3 Nov 2012 21:44:16 -0400 Message-ID: <5095C86E.2090705@draigBrady.com> Date: Sun, 04 Nov 2012 01:44:14 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <5095BCB1.7090100@draigBrady.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id qA41iH4g030694 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) On 11/04/2012 01:25 AM, John David Anglin wrote: > On 3-Nov-12, at 8:54 PM, P=E1draig Brady wrote: > >> I've now pushed the patch set discussed in this thread, >> so I'm marking this bug as done. > > Hopefully, it's the one with the _LP64 check. Yes: http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3Dda1329= e7 Also this related one already mentioned: http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3D6108ba= a4 thanks, P=E1draig. From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 02:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12754-done@debbugs.gnu.org, John David Anglin , Torbjorn Granlund Received: via spool by 12754-done@debbugs.gnu.org id=D12754.135199463513835 (code D ref 12754); Sun, 04 Nov 2012 02:04:02 +0000 Received: (at 12754-done) by debbugs.gnu.org; 4 Nov 2012 02:03:55 +0000 Received: from localhost ([127.0.0.1]:47827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpZ4-0003b4-DJ for submit@debbugs.gnu.org; Sat, 03 Nov 2012 22:03:55 -0400 Received: from blu0-omc4-s31.blu0.hotmail.com ([65.55.111.170]:41424) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpZ1-0003ax-OC for 12754-done@debbugs.gnu.org; Sat, 03 Nov 2012 22:03:52 -0400 Received: from BLU0-SMTP22 ([65.55.111.135]) by blu0-omc4-s31.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 3 Nov 2012 19:00:51 -0700 X-Originating-IP: [69.158.131.52] X-EIP: [E8iqQEe9yzvNnaf+Q9iSjVGL9HWPkFiv] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.131.52]) by BLU0-SMTP22.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 3 Nov 2012 19:00:50 -0700 From: John David Anglin In-Reply-To: <5095C86E.2090705@draigBrady.com> References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <5095BCB1.7090100@draigBrady.com> <5095C86E.2090705@draigBrady.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 (Apple Message framework v936) Date: Sat, 3 Nov 2012 22:00:41 -0400 X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 04 Nov 2012 02:00:50.0209 (UTC) FILETIME=[36AC9910:01CDBA30] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 3-Nov-12, at 9:44 PM, P=E1draig Brady wrote: > Also this related one already mentioned: > http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3D6108b= aa4 This one seems to have lost +#include from the original patch to make-prime-list.c. I think this is needed =20= to define PRIxMAX. Regards, Dave -- John David Anglin dave.anglin@bell.net From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 02:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: 12754-done@debbugs.gnu.org, John David Anglin , Torbjorn Granlund Received: via spool by 12754-done@debbugs.gnu.org id=D12754.135199526514720 (code D ref 12754); Sun, 04 Nov 2012 02:15:01 +0000 Received: (at 12754-done) by debbugs.gnu.org; 4 Nov 2012 02:14:25 +0000 Received: from localhost ([127.0.0.1]:47844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpjF-0003pN-EX for submit@debbugs.gnu.org; Sat, 03 Nov 2012 22:14:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30269) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpjC-0003pF-P2 for 12754-done@debbugs.gnu.org; Sat, 03 Nov 2012 22:14:23 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA42BMBg002284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Nov 2012 22:11:23 -0400 Received: from [10.36.116.18] (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qA42BKDK006892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 3 Nov 2012 22:11:21 -0400 Message-ID: <5095CEC7.50104@draigBrady.com> Date: Sun, 04 Nov 2012 02:11:19 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <5095BCB1.7090100@draigBrady.com> <5095C86E.2090705@draigBrady.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id qA42BMBg002284 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) On 11/04/2012 02:00 AM, John David Anglin wrote: > > On 3-Nov-12, at 9:44 PM, P=E1draig Brady wrote: > >> Also this related one already mentioned: >> http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3D610= 8baa4 > > > This one seems to have lost > > +#include > > from the original patch to make-prime-list.c. I think this is needed t= o define > PRIxMAX. So the patches were adjusted slightly and since they spanned both this issue and issue 12753 I didn't post them in full again to a particular issue, to avoid confusion, which I've obivously failed in. Forry about that, I won't do that again :) Anyway the patch referenced above didn't actually introduce PRIxMAX, that was done in this patch from issue 12753 http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3D5e9401= 80 thanks for all the double checking, P=E1draig. From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12754: factor.c selects 64 bit code from longlong.h on 32-bit hppa systems Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 02:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12754 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12754-done@debbugs.gnu.org, John David Anglin , Torbjorn Granlund Received: via spool by 12754-done@debbugs.gnu.org id=D12754.135199596215701 (code D ref 12754); Sun, 04 Nov 2012 02:27:01 +0000 Received: (at 12754-done) by debbugs.gnu.org; 4 Nov 2012 02:26:02 +0000 Received: from localhost ([127.0.0.1]:47849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpuT-00044w-Kr for submit@debbugs.gnu.org; Sat, 03 Nov 2012 22:26:02 -0400 Received: from blu0-omc4-s25.blu0.hotmail.com ([65.55.111.164]:48556) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpuQ-00044i-Tb for 12754-done@debbugs.gnu.org; Sat, 03 Nov 2012 22:26:00 -0400 Received: from BLU0-SMTP5 ([65.55.111.136]) by blu0-omc4-s25.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 3 Nov 2012 19:23:00 -0700 X-Originating-IP: [69.158.131.52] X-EIP: [BJoYcXP1WeqK9PrjWUrrQTUcyJzcAQlM] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.131.52]) by BLU0-SMTP5.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 3 Nov 2012 19:22:59 -0700 From: John David Anglin In-Reply-To: <5095CEC7.50104@draigBrady.com> References: <20121028194643.GA15492@hiauly1.hia.nrc.ca> <508DE972.8020103@draigBrady.com> <508E8161.5060004@draigBrady.com> <86fw4xv269.fsf@shell.gmplib.org> <508F346F.4000300@draigBrady.com> <5095BCB1.7090100@draigBrady.com> <5095C86E.2090705@draigBrady.com> <5095CEC7.50104@draigBrady.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 (Apple Message framework v936) Date: Sat, 3 Nov 2012 22:22:43 -0400 X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 04 Nov 2012 02:22:59.0636 (UTC) FILETIME=[4F130F40:01CDBA33] X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) On 3-Nov-12, at 10:11 PM, P=E1draig Brady wrote: > Forry about that, I won't do that again :) No problem. The GCC commit system generates an entry in bugzilla provided one correctly tags the commit. Makes it easy to track fixes for a PR. Regards, Dave -- John David Anglin dave.anglin@bell.net