From unknown Mon Jun 23 02:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12753: printf in make-prime-list.c uses "modern" features Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 28 Oct 2012 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12753 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 12753@debbugs.gnu.org Cc: John David Anglin X-Debbugs-Original-To: bug-coreutils@gnu.org Reply-To: John David Anglin Received: via spool by submit@debbugs.gnu.org id=B.135145337526555 (code B ref -1); Sun, 28 Oct 2012 19:43:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Oct 2012 19:42:55 +0000 Received: from localhost ([127.0.0.1]:36950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSYl4-0006uG-Pj for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:42:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42530) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSYl3-0006u8-86 for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:42:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSYik-0001OO-Jf for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:40:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYik-0001OK-GN for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:40:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYij-0008MA-Dj for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:40:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSYii-0001O8-Dt for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:40:29 -0400 Received: from hiauly1.hia.nrc.ca ([132.246.10.84]:3031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYii-0001O2-9m for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:40:28 -0400 Received: by hiauly1.hia.nrc.ca (Postfix, from userid 1000) id 3CA8B5385; Sun, 28 Oct 2012 15:40:23 -0400 (EDT) Date: Sun, 28 Oct 2012 15:40:23 -0400 From: John David Anglin Message-ID: <20121028194021.GA14985@hiauly1.hia.nrc.ca> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline Organization: nrc.ca User-Agent: Mutt/1.5.16 (2007-06-09) X-detected-operating-system: by eggs.gnu.org: HP-UX B.10.20 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline make-prime-list crashes on hppa1.1-hp-hpux10.20. This probably will occur on any hppa-hpux system. Attached is a hack to work around the problem. Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="make-prime-list.c.d" --- make-prime-list.c.orig Tue Oct 23 10:14:12 2012 +++ make-prime-list.c Sat Oct 27 16:10:30 2012 @@ -84,10 +84,17 @@ unsigned int d8 = i + 8 < nprimes ? primes[i + 8].p - primes[i].p : 0xff; if (255 < d8) /* this happens at 668221 */ abort (); +#ifdef __hppa + printf ("P (%2u, %3u, 0x%016llx%s, 0x%016llx%s) /* %d */\n", + primes[i].p - p, d8, + primes[i].pinv, suffix, + primes[i].lim, suffix, primes[i].p); +#else printf ("P (%2u, %3u, 0x%0*jx%s, 0x%0*jx%s) /* %d */\n", primes[i].p - p, d8, SZ, primes[i].pinv, suffix, SZ, primes[i].lim, suffix, primes[i].p); +#endif p = primes[i].p; } --gBBFr7Ir9EOA20Yy-- From unknown Mon Jun 23 02:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12753: printf in make-prime-list.c uses "modern" features Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 29 Oct 2012 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12753 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: John David Anglin , 12753@debbugs.gnu.org Received: via spool by 12753-submit@debbugs.gnu.org id=B12753.135147597529283 (code B ref 12753); Mon, 29 Oct 2012 02:00:02 +0000 Received: (at 12753) by debbugs.gnu.org; 29 Oct 2012 01:59:35 +0000 Received: from localhost ([127.0.0.1]:37112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSeda-0007cG-RL for submit@debbugs.gnu.org; Sun, 28 Oct 2012 21:59:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26970) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSedW-0007c5-Mp for 12753@debbugs.gnu.org; Sun, 28 Oct 2012 21:59:32 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9T1v5Hs031000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 28 Oct 2012 21:57:05 -0400 Received: from [10.36.116.16] (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9T1v2Ne019116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 28 Oct 2012 21:57:04 -0400 Message-ID: <508DE26E.5020403@draigBrady.com> Date: Mon, 29 Oct 2012 01:57:02 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <20121028194021.GA14985@hiauly1.hia.nrc.ca> In-Reply-To: <20121028194021.GA14985@hiauly1.hia.nrc.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q9T1v5Hs031000 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 10/28/2012 07:40 PM, John David Anglin wrote: > make-prime-list crashes on hppa1.1-hp-hpux10.20. This probably > will occur on any hppa-hpux system. > > Attached is a hack to work around the problem. Is %jx not supported, or is the * not supported with %j? I'm guessing the latter since you got a runtime issue rather than a compile time one. We also use '*' in other format strings, so I doubt that's an issue in itself. Note there are only a couple of other uses of %j. A newly introduced one in factor.c. So does your system support %ju? src/factor.c: printf ("%ju", t0); Also this one introduced a year ago in an error path: src/join.c: 0, _("%s:%ju: is not sorted: %.*s"), I'm a little surprised (and encouraged) that there were no reported compile issues for the %ju above, which suggests we might be able to depend on that (well soon anyway). Up until now we've been using the PRIuMAX etc. constants. Un any case I might add a syntax check rule for the moment around git grep "%[0*]*j[udx]" to keep %j out of new code. For this particular case can you test this more generic workaround. thanks, P=E1draig. diff --git a/src/make-prime-list.c b/src/make-prime-list.c index e0d9b81..a4c0a3b 100644 --- a/src/make-prime-list.c +++ b/src/make-prime-list.c @@ -20,6 +20,7 @@ this program. If not, see http://www.gnu.org/licenses/= . */ #include #include +#include #include #include #include @@ -77,17 +78,23 @@ output_primes (const struct prime *primes, unsigned n= primes) exit (EXIT_FAILURE); } -#define SZ (int)(2*sizeof (uintmax_t)) +#if UINTMAX_MAX =3D=3D UINT32_MAX +# define SZ "8" /* 8 hex digits. */ +#elif UINTMAX_MAX =3D=3D UINT64_MAX +# define SZ "16" /* 16 hex digits. */ +#elif UINTMAX_MAX =3D=3D UINT128_MAX +# define SZ "32" /* 32 hex digits. */ +#endif for (i =3D 0, p =3D 2; i < nprimes; i++) { unsigned int d8 =3D i + 8 < nprimes ? primes[i + 8].p - primes[i]= .p : 0xff; if (255 < d8) /* this happens at 668221 */ abort (); - printf ("P (%2u, %3u, 0x%0*jx%s, 0x%0*jx%s) /* %d */\n", + printf ("P (%2u, %3u, 0x%0"SZ PRIxMAX"%s, 0x%0"SZ PRIxMAX"%s) /* %= d */\n", primes[i].p - p, d8, - SZ, primes[i].pinv, suffix, - SZ, primes[i].lim, suffix, primes[i].p); + primes[i].pinv, suffix, + primes[i].lim, suffix, primes[i].p); p =3D primes[i].p; } From unknown Mon Jun 23 02:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12753: printf in make-prime-list.c uses "modern" features Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 29 Oct 2012 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12753 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: John David Anglin , 12753@debbugs.gnu.org Received: via spool by 12753-submit@debbugs.gnu.org id=B12753.13515135424629 (code B ref 12753); Mon, 29 Oct 2012 12:26:02 +0000 Received: (at 12753) by debbugs.gnu.org; 29 Oct 2012 12:25:42 +0000 Received: from localhost ([127.0.0.1]:37606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSoPV-0001Cb-Cs for submit@debbugs.gnu.org; Mon, 29 Oct 2012 08:25:41 -0400 Received: from blu0-omc4-s11.blu0.hotmail.com ([65.55.111.150]:15115) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSoPM-0001CN-Pp for 12753@debbugs.gnu.org; Mon, 29 Oct 2012 08:25:36 -0400 Received: from BLU0-SMTP68 ([65.55.111.136]) by blu0-omc4-s11.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Oct 2012 05:23:05 -0700 X-Originating-IP: [69.158.131.52] X-EIP: [o49SuyTHO9R13r1S/SlxZSuvL7KJYizU] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.131.52]) by BLU0-SMTP68.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Oct 2012 05:23:05 -0700 From: John David Anglin In-Reply-To: <508DE26E.5020403@draigBrady.com> References: <20121028194021.GA14985@hiauly1.hia.nrc.ca> <508DE26E.5020403@draigBrady.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 (Apple Message framework v936) Date: Mon, 29 Oct 2012 08:22:56 -0400 X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 29 Oct 2012 12:23:05.0329 (UTC) FILETIME=[25A94E10:01CDB5D0] X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) On 28-Oct-12, at 9:57 PM, P=E1draig Brady wrote: > Is %jx not supported, or is the * not supported with %j? > I'm guessing the latter since you got a runtime issue > rather than a compile time one. We also use '*' in > other format strings, so I doubt that's an issue in itself. I will test this evening. The printf manpage doesn't mention %j or * in the HP-UX 10.20 and 11.11 pages. Sometimes things are supported but not documented. Dave -- John David Anglin dave.anglin@bell.net From unknown Mon Jun 23 02:25:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: John David Anglin Subject: bug#12753: closed (Re: bug#12753: printf in make-prime-list.c uses "modern" features) Message-ID: References: <5095BCF5.8040604@draigBrady.com> <20121028194021.GA14985@hiauly1.hia.nrc.ca> X-Gnu-PR-Message: they-closed 12753 X-Gnu-PR-Package: coreutils Reply-To: 12753@debbugs.gnu.org Date: Sun, 04 Nov 2012 00:59:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1351990742-8276-1" This is a multi-part message in MIME format... ------------=_1351990742-8276-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #12753: printf in make-prime-list.c uses "modern" features which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 12753@debbugs.gnu.org. --=20 12753: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12753 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1351990742-8276-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 12753-done) by debbugs.gnu.org; 4 Nov 2012 00:58:20 +0000 Received: from localhost ([127.0.0.1]:47786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUoXb-00028c-NQ for submit@debbugs.gnu.org; Sat, 03 Nov 2012 20:58:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57529) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUoXa-00028W-4D for 12753-done@debbugs.gnu.org; Sat, 03 Nov 2012 20:58:19 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA40tKEe003319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Nov 2012 20:55:20 -0400 Received: from [10.36.116.18] (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA40tI8R025209 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 3 Nov 2012 20:55:19 -0400 Message-ID: <5095BCF5.8040604@draigBrady.com> Date: Sun, 04 Nov 2012 00:55:17 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: John David Anglin Subject: Re: bug#12753: printf in make-prime-list.c uses "modern" features References: <20121028194021.GA14985@hiauly1.hia.nrc.ca> <508DE26E.5020403@draigBrady.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id qA40tKEe003319 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 12753-done Cc: John David Anglin , 12753-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 10/29/2012 12:22 PM, John David Anglin wrote: > On 28-Oct-12, at 9:57 PM, P=E1draig Brady wrote: > >> Is %jx not supported, or is the * not supported with %j? >> I'm guessing the latter since you got a runtime issue >> rather than a compile time one. We also use '*' in >> other format strings, so I doubt that's an issue in itself. > > > I will test this evening. The printf manpage doesn't mention %j > or * in the HP-UX 10.20 and 11.11 pages. Sometimes things > are supported but not documented. I've now pushed the patch set from this thread, so I'm marking this as done. cheers, P=E1draig. ------------=_1351990742-8276-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Oct 2012 19:42:55 +0000 Received: from localhost ([127.0.0.1]:36950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSYl4-0006uG-Pj for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:42:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42530) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSYl3-0006u8-86 for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:42:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSYik-0001OO-Jf for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:40:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYik-0001OK-GN for submit@debbugs.gnu.org; Sun, 28 Oct 2012 15:40:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYij-0008MA-Dj for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:40:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSYii-0001O8-Dt for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:40:29 -0400 Received: from hiauly1.hia.nrc.ca ([132.246.10.84]:3031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSYii-0001O2-9m for bug-coreutils@gnu.org; Sun, 28 Oct 2012 15:40:28 -0400 Received: by hiauly1.hia.nrc.ca (Postfix, from userid 1000) id 3CA8B5385; Sun, 28 Oct 2012 15:40:23 -0400 (EDT) Date: Sun, 28 Oct 2012 15:40:23 -0400 From: John David Anglin To: bug-coreutils@gnu.org Subject: printf in make-prime-list.c uses "modern" features Message-ID: <20121028194021.GA14985@hiauly1.hia.nrc.ca> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline Organization: nrc.ca User-Agent: Mutt/1.5.16 (2007-06-09) X-detected-operating-system: by eggs.gnu.org: HP-UX B.10.20 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit Cc: John David Anglin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: John David Anglin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline make-prime-list crashes on hppa1.1-hp-hpux10.20. This probably will occur on any hppa-hpux system. Attached is a hack to work around the problem. Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="make-prime-list.c.d" --- make-prime-list.c.orig Tue Oct 23 10:14:12 2012 +++ make-prime-list.c Sat Oct 27 16:10:30 2012 @@ -84,10 +84,17 @@ unsigned int d8 = i + 8 < nprimes ? primes[i + 8].p - primes[i].p : 0xff; if (255 < d8) /* this happens at 668221 */ abort (); +#ifdef __hppa + printf ("P (%2u, %3u, 0x%016llx%s, 0x%016llx%s) /* %d */\n", + primes[i].p - p, d8, + primes[i].pinv, suffix, + primes[i].lim, suffix, primes[i].p); +#else printf ("P (%2u, %3u, 0x%0*jx%s, 0x%0*jx%s) /* %d */\n", primes[i].p - p, d8, SZ, primes[i].pinv, suffix, SZ, primes[i].lim, suffix, primes[i].p); +#endif p = primes[i].p; } --gBBFr7Ir9EOA20Yy-- ------------=_1351990742-8276-1-- From unknown Mon Jun 23 02:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12753: printf in make-prime-list.c uses "modern" features Resent-From: John David Anglin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 01:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12753 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: John David Anglin , 12753-done@debbugs.gnu.org Received: via spool by 12753-done@debbugs.gnu.org id=D12753.135199218310348 (code D ref 12753); Sun, 04 Nov 2012 01:24:01 +0000 Received: (at 12753-done) by debbugs.gnu.org; 4 Nov 2012 01:23:03 +0000 Received: from localhost ([127.0.0.1]:47802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUovW-0002gq-KS for submit@debbugs.gnu.org; Sat, 03 Nov 2012 21:23:03 -0400 Received: from blu0-omc4-s22.blu0.hotmail.com ([65.55.111.161]:47626) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUovS-0002gQ-As for 12753-done@debbugs.gnu.org; Sat, 03 Nov 2012 21:23:00 -0400 Received: from BLU0-SMTP49 ([65.55.111.136]) by blu0-omc4-s22.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 3 Nov 2012 18:20:00 -0700 X-Originating-IP: [69.158.131.52] X-EIP: [b0jzjDBKzzEHAEAXldpsyT6oF24h5lTi] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.131.52]) by BLU0-SMTP49.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 3 Nov 2012 18:19:59 -0700 From: John David Anglin In-Reply-To: <5095BCF5.8040604@draigBrady.com> References: <20121028194021.GA14985@hiauly1.hia.nrc.ca> <508DE26E.5020403@draigBrady.com> <5095BCF5.8040604@draigBrady.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 (Apple Message framework v936) Date: Sat, 3 Nov 2012 21:19:43 -0400 X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 04 Nov 2012 01:19:59.0496 (UTC) FILETIME=[81EF7880:01CDBA2A] X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) On 3-Nov-12, at 8:55 PM, P=E1draig Brady wrote: > On 10/29/2012 12:22 PM, John David Anglin wrote: >> On 28-Oct-12, at 9:57 PM, P=E1draig Brady wrote: >> >>> Is %jx not supported, or is the * not supported with %j? >>> I'm guessing the latter since you got a runtime issue >>> rather than a compile time one. We also use '*' in >>> other format strings, so I doubt that's an issue in itself. >> >> >> I will test this evening. The printf manpage doesn't mention %j >> or * in the HP-UX 10.20 and 11.11 pages. Sometimes things >> are supported but not documented. > > I've now pushed the patch set from this thread, > so I'm marking this as done. As far as I can tell, your patch to make-prime-list.c works. I'm currently doing a build with a hack to try fix the threads issue. The 'j' printf modifier is not supported on HP-UX at least through to 11.11. GCC doesn't parse printf format strings to detect unsupported features. The string "%ju" outputs "ju". As a result, the argument processing messes up. This is what causes the runtime crash. So, the other instances where %j is used need examination. Don't know about '*'. Thanks, Dave -- John David Anglin dave.anglin@bell.net From unknown Mon Jun 23 02:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12753: printf in make-prime-list.c uses "modern" features Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 01:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12753 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: John David Anglin , 12753-done@debbugs.gnu.org Received: via spool by 12753-done@debbugs.gnu.org id=D12753.135199349812182 (code D ref 12753); Sun, 04 Nov 2012 01:45:01 +0000 Received: (at 12753-done) by debbugs.gnu.org; 4 Nov 2012 01:44:58 +0000 Received: from localhost ([127.0.0.1]:47812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpGj-0003AQ-1R for submit@debbugs.gnu.org; Sat, 03 Nov 2012 21:44:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64007) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUpGg-0003AH-NK for 12753-done@debbugs.gnu.org; Sat, 03 Nov 2012 21:44:55 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA41ft9k030274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Nov 2012 21:41:55 -0400 Received: from [10.36.116.18] (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA41fr4C016853 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 3 Nov 2012 21:41:54 -0400 Message-ID: <5095C7E1.4020206@draigBrady.com> Date: Sun, 04 Nov 2012 01:41:53 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <20121028194021.GA14985@hiauly1.hia.nrc.ca> <508DE26E.5020403@draigBrady.com> <5095BCF5.8040604@draigBrady.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id qA41ft9k030274 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) On 11/04/2012 01:19 AM, John David Anglin wrote: > On 3-Nov-12, at 8:55 PM, P=E1draig Brady wrote: > >> On 10/29/2012 12:22 PM, John David Anglin wrote: >>> On 28-Oct-12, at 9:57 PM, P=E1draig Brady wrote: >>> >>>> Is %jx not supported, or is the * not supported with %j? >>>> I'm guessing the latter since you got a runtime issue >>>> rather than a compile time one. We also use '*' in >>>> other format strings, so I doubt that's an issue in itself. >>> >>> >>> I will test this evening. The printf manpage doesn't mention %j >>> or * in the HP-UX 10.20 and 11.11 pages. Sometimes things >>> are supported but not documented. >> >> I've now pushed the patch set from this thread, >> so I'm marking this as done. > > > As far as I can tell, your patch to make-prime-list.c works. I'm > currently doing a build with a hack to try fix the threads issue. > > The 'j' printf modifier is not supported on HP-UX at least through > to 11.11. GCC doesn't parse printf format strings to detect unsupporte= d > features. The string "%ju" outputs "ju". As a result, the argument > processing messes up. This is what causes the runtime crash. > > So, the other instances where %j is used need examination. > > Don't know about '*'. Oh right, %j is only a runtime issue without -Wformat Thanks for the info. All %j should now be handled with: http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3D5e9401= 80 http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3D141102= 2c thanks, P=E1draig.