GNU bug report logs - #12740
24.2.50; ERC fix broke modules after require

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12740 in the body.
You can then email your comments to 12740 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Antoine Levitt <antoine.levitt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: 24.2.50; ERC fix broke modules after require
Date: Fri, 26 Oct 2012 16:58:07 +0200

Hi,

The following code stopped working (ie truncate stopped being activated)
after a series of commits by Stefan Monnier

emacs -Q

(require 'erc)
(setq erc-modules '(truncate))
(erc-update-modules)
(erc :server "irc.freenode.net")

This worked fine before

Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Mon Oct 15 12:49:57 2012 -0400

    * lisp/erc/erc.el (erc-log): Make it into a defsubst.
    (erc-with-server-buffer, define-erc-module, erc-with-buffer)
    (erc-with-all-buffers-of-server): Use `declare'.
    * lisp/erc/erc-backend.el (erc-log): Adjust autoload accordingly.

After this, erc was broken until

Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Thu Oct 18 11:51:28 2012 -0400

    * lisp/erc/erc-backend.el: Require `erc' instead of autoloading its macros.

And after this commit, the sample code above stopped working.

Antoine

Message #8 received at 12740 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Antoine Levitt <antoine.levitt <at> gmail.com>
Cc: 12740 <at> debbugs.gnu.org
Subject: Re: 24.2.50; ERC fix broke modules after require
Date: Fri, 26 Oct 2012 11:21:33 -0400

> emacs -Q
> (require 'erc)
> (setq erc-modules '(truncate))
> (erc-update-modules)
> (erc :server "irc.freenode.net")
> This worked fine before

I don't know what "worked" means precisely, but I tried your above
recipe and "it worked" in the sense that it did something which didn't
look like an error.


        Stefan

Message #11 received at 12740 <at> debbugs.gnu.org (full text, mbox):

From: Antoine Levitt <antoine.levitt <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 12740 <at> debbugs.gnu.org
Subject: Re: 24.2.50; ERC fix broke modules after require
Date: Fri, 26 Oct 2012 17:52:40 +0200

[Message part 1 (text/plain, inline)]

10/26/2012 17:21, Stefan Monnier
>> emacs -Q
>> (require 'erc)
>> (setq erc-modules '(truncate))
>> (erc-update-modules)
>> (erc :server "irc.freenode.net")
>> This worked fine before
>
> I don't know what "worked" means precisely, but I tried your above
> recipe and "it worked" in the sense that it did something which didn't
> look like an error.

Sorry if this bug report is confused. I've tried to reduce the original
bug (which has weird effects on my configuration) to a simple test
case. The bug, which I had not described and you could not guess, was
that lines were filled. My bad. Please discard my original bug report
and consider the following:

(require 'erc)
(setq erc-modules '())
(erc-update-modules)

used to disable buffer filling (try it on a large window). It did so
before your commits, not after.

You might argue that this is the intended behaviour, because
erc-update-modules says that it only enables modules, not disable them
(in which case, to disable modules, is one supposed to set erc-modules
before requiring erc ? I liked the old way better).

I also attach a more involved example of a bug that appeared with your
commits, and has nothing to do with erc-modules (I think). I was hoping
the fix for the simpler issue would also fix the more involved one,
which is why I didn't report it in the first place, but here it is
anywyay. The code is supposed to colour the nicks of people (here, all
in yellow). The bug results from an interaction with
erc-hide-timestamps, which didn't occur before your commits.

Sorry again.

[test.el (application/emacs-lisp, attachment)]

Message #14 received at 12740 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Antoine Levitt <antoine.levitt <at> gmail.com>
Cc: 12740 <at> debbugs.gnu.org
Subject: Re: 24.2.50; ERC fix broke modules after require
Date: Fri, 26 Oct 2012 14:30:04 -0400

A shot in the dark: does the patch below fix your problems?


        Stefan


=== modified file 'lisp/erc/erc-backend.el'
--- lisp/erc/erc-backend.el	2012-10-18 15:51:28 +0000
+++ lisp/erc/erc-backend.el	2012-10-26 18:28:14 +0000
@@ -102,8 +102,7 @@
 ;; There's a fairly strong mutual dependency between erc.el and erc-backend.el.
 ;; Luckily, erc.el does not need erc-backend.el for macroexpansion whereas the
 ;; reverse is true:
-(provide 'erc-backend)
-(require 'erc)
+(eval-when-compile (provide 'erc-backend) (require 'erc))
 
 ;;;; Variables and options
 

Message #17 received at 12740 <at> debbugs.gnu.org (full text, mbox):

From: Antoine Levitt <antoine.levitt <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 12740 <at> debbugs.gnu.org
Subject: Re: 24.2.50; ERC fix broke modules after require
Date: Fri, 26 Oct 2012 20:47:22 +0200

10/26/2012 20:30, Stefan Monnier
> A shot in the dark: does the patch below fix your problems?

It does.

Message #20 received at 12740 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Antoine Levitt <antoine.levitt <at> gmail.com>
Cc: 12740 <at> debbugs.gnu.org
Subject: Re: 24.2.50; ERC fix broke modules after require
Date: Sun, 28 Oct 2012 11:35:03 -0400

>> A shot in the dark: does the patch below fix your problems?
> It does.

Thanks, installed,


        Stefan

Message #25 received at 12740 <at> debbugs.gnu.org (full text, mbox):

From: Antoine Levitt <antoine.levitt <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 12740 <at> debbugs.gnu.org
Subject: Re: 24.2.50; ERC fix broke modules after require
Date: Sun, 28 Oct 2012 16:41:24 +0100

[Message part 1 (text/plain, inline)]

Nice, thanks!
On Oct 28, 2012 4:35 PM, "Stefan Monnier" <monnier <at> iro.umontreal.ca> wrote:

> >> A shot in the dark: does the patch below fix your problems?
> > It does.
>
> Thanks, installed,
>
>
>         Stefan
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.