GNU bug report logs - #12730
coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh

Previous Next

Full log

Message #56 received at 12730 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Andrew Warshall <warshall <at> 99main.com>
Cc: 12730 <at> debbugs.gnu.org
Subject: Re: bug#12730: bug #12730: patch attached
Date: Thu, 08 Nov 2012 08:05:30 +0100

Jim Meyering wrote:
> Date: Sun, 4 Nov 2012 16:41:15 -0800
> Subject: [PATCH] mountlist: do not classify a bind-mounted dir entry as
>  "dummy"
>
> * lib/mountlist.c (ME_DUMMY_0): Rename from ME_DUMMY, but omit
> the "none"-testing clause.
> (ME_DUMMY) [MOUNTED_GETMNTENT1]: New macro to encapsulate the
> exception for bind-mounted directories.
> Copyright-paperwork-exempt: Yes

Hmm.... trying the latest from gnulib, I saw a compilation failure.
And it was my fault for omitting a hunk of your patch when
I adjusted it.  Sorry about that.

Here's the fix.

From ab7a2b67b48deb4c253b3b6bd983690d71515265 Mon Sep 17 00:00:00 2001
From: Jim Meyering <jim <at> meyering.net>
Date: Wed, 7 Nov 2012 22:59:21 -0800
Subject: [PATCH] mountlist.c: fix a compilation failure

* lib/mountlist.c (read_file_system_list): Fix a compilation failure
I introduced while transforming commit v0.0-7683-g613bcb6
---
 ChangeLog       | 6 ++++++
 lib/mountlist.c | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index adcb8d1..1a1e8b7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-11-07  Jim Meyering  <jim <at> meyering.net>
+
+	mountlist.c: fix a compilation failure
+	* lib/mountlist.c (read_file_system_list): Fix a compilation failure
+	I introduced while transforming commit v0.0-7683-g613bcb6
+
 2012-11-05  Paul Eggert  <eggert <at> cs.ucla.edu>

 	errno: port to LynxOS 178 2.2.2
diff --git a/lib/mountlist.c b/lib/mountlist.c
index a9a9f2c..d0fe1b2 100644
--- a/lib/mountlist.c
+++ b/lib/mountlist.c
@@ -430,7 +430,7 @@ read_file_system_list (bool need_fs_type)
         me->me_mountdir = xstrdup (mnt->mnt_dir);
         me->me_type = xstrdup (mnt->mnt_type);
         me->me_type_malloced = 1;
-        me->me_dummy = ME_DUMMY (me->me_devname, me->me_type);
+        me->me_dummy = ME_DUMMY (me->me_devname, me->me_type, mnt);
         me->me_remote = ME_REMOTE (me->me_devname, me->me_type);
         me->me_dev = dev_from_mount_options (mnt->mnt_opts);

--
1.8.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.