From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 04:45:50 2012 Received: (at submit) by debbugs.gnu.org; 25 Oct 2012 08:45:50 +0000 Received: from localhost ([127.0.0.1]:60660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRJ4X-000523-IA for submit@debbugs.gnu.org; Thu, 25 Oct 2012 04:45:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54408) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRJ4T-00051l-Ij for submit@debbugs.gnu.org; Thu, 25 Oct 2012 04:45:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRJ2J-0003in-Tc for submit@debbugs.gnu.org; Thu, 25 Oct 2012 04:43:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:54876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRJ2J-0003ij-Q7 for submit@debbugs.gnu.org; Thu, 25 Oct 2012 04:43:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRJ2D-0004oC-KG for bug-coreutils@gnu.org; Thu, 25 Oct 2012 04:43:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRJ27-0003hQ-74 for bug-coreutils@gnu.org; Thu, 25 Oct 2012 04:43:25 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:45813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRJ26-0003hG-I1 for bug-coreutils@gnu.org; Thu, 25 Oct 2012 04:43:19 -0400 Received: from zimbra33-e6.priv.proxad.net (unknown [172.20.243.183]) by smtp1-g21.free.fr (Postfix) with ESMTP id 6B0BA940168 for ; Thu, 25 Oct 2012 10:43:13 +0200 (CEST) Date: Thu, 25 Oct 2012 10:43:12 +0200 (CEST) From: g.esp@free.fr To: bug-coreutils@gnu.org Message-ID: <1483616685.329281056.1351154592247.JavaMail.root@zimbra33-e6.priv.proxad.net> In-Reply-To: <1610997146.329040031.1351149911652.JavaMail.root@zimbra33-e6.priv.proxad.net> Subject: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_329281054_1589678056.1351154592244" X-Originating-IP: [82.236.101.3] X-Mailer: Zimbra 7.2.0-GA2598 (ZimbraWebClient - FF3.0 (Win)/7.2.0-GA2598) X-Authenticated-User: g.esp@free.fr X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) ------=_Part_329281054_1589678056.1351154592244 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit A new test in 8.20 fail because "mount point 'a/b' already traversed" is not emitted [chroot-i486] root:/usr/src/coreutils-8.20$ uname -r; mount --version 3.4.15 mount from util-linux 2.22.1 (libmount 2.22.0: debug) [chroot-i486] root:/usr/src/coreutils-8.20$ FORCE_UNSAFE_CONFIGURE=1 ./configure --prefix=/usr --disable-nls --enable-no-install-program=kill,uptime ... [chroot-i486] root:/usr/src/coreutils-8.20$ make check TESTS=tests/du/bind-mount-dir-cycle.sh ... FAIL: tests/du/bind-mount-dir-cycle.sh (exit: 1) ... + mkdir -p a/b + mount --bind a a/b + echo a + echo 'du: mount point '\''a/b'\'' already traversed' + du a + sed 's/^[0-9][0-9]* //' out + mv k out + compare exp-err err + compare_dev_null_ exp-err err + test 2 = 2 + test xexp-err = x/dev/null + test xerr = x/dev/null + return 2 + case $? in + compare_ exp-err err + diff -u exp-err err --- exp-err 2012-10-25 09:24:00.000000000 +0200 +++ err 2012-10-25 09:24:00.000000000 +0200 @@ -1 +1,6 @@ -du: mount point 'a/b' already traversed +du: WARNING: Circular directory structure. +This almost certainly means that you have a corrupted file system. +NOTIFY YOUR SYSTEM MANAGER. +The following directory is part of the cycle: + 'a/b' + + fail=1 + compare exp out + compare_dev_null_ exp out + test 2 = 2 + test xexp = x/dev/null + test xout = x/dev/null + return 2 + case $? in + compare_ exp out + diff -u exp out + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + umount a/b I attached the result of strace -o du-bind-mount-dir-cycle.log -s100 -f du a Gilles ------=_Part_329281054_1589678056.1351154592244 Content-Type: text/x-log; name=du-bind-mount-dir-cycle.log Content-Disposition: attachment; filename=du-bind-mount-dir-cycle.log Content-Transfer-Encoding: base64 MzQ2NyAgZXhlY3ZlKCIvdXNyL2Jpbi9kdSIsIFsiZHUiLCAiYSJdLCBbLyogMzAgdmFycyAqL10p ID0gMAozNDY3ICBicmsoMCkgICAgICAgICAgICAgICAgICAgICAgICAgICAgPSAweGI3ZmY0MDAw CjM0NjcgIG1tYXAyKE5VTEwsIDQwOTYsIFBST1RfUkVBRHxQUk9UX1dSSVRFLCBNQVBfUFJJVkFU RXxNQVBfQU5PTllNT1VTLCAtMSwgMCkgPSAweGI3Nzg5MDAwCjM0NjcgIGFjY2VzcygiL2V0Yy9s ZC5zby5wcmVsb2FkIiwgUl9PSykgPSAtMSBFTk9FTlQgKE5vIHN1Y2ggZmlsZSBvciBkaXJlY3Rv cnkpCjM0NjcgIG9wZW4oIi9ldGMvbGQuc28uY2FjaGUiLCBPX1JET05MWSkgPSAzCjM0NjcgIGZz dGF0NjQoMywge3N0X21vZGU9U19JRlJFR3wwNjQ0LCBzdF9zaXplPTE3MDQzLCAuLi59KSA9IDAK MzQ2NyAgbW1hcDIoTlVMTCwgMTcwNDMsIFBST1RfUkVBRCwgTUFQX1BSSVZBVEUsIDMsIDApID0g MHhiNzc4NDAwMAozNDY3ICBjbG9zZSgzKSAgICAgICAgICAgICAgICAgICAgICAgICAgPSAwCjM0 NjcgIG9wZW4oIi9saWIvbGliYy5zby42IiwgT19SRE9OTFkpICA9IDMKMzQ2NyAgcmVhZCgzLCAi XDE3N0VMRlwxXDFcMVwwXDBcMFwwXDBcMFwwXDBcMFwzXDBcM1wwXDFcMFwwXDBcMjQwbFwxXDAw MDRcMFwwXDBcNFwzNTNcMjVcMFwwXDBcMFwwMDA0XDAgXDBcblwwKFwwI1wwIFwwXDZcMFwwXDAw MDRcMFwwXDAwMDRcMFwwXDAwMDRcMFwwXDBAXDFcMFwwQFwxXDBcMFw1XDBcMFwwXDRcMFwwXDBc M1wwXDBcMFwzNjBcMjE0XDI0XDBcMzYwXDIxNFwyNFwwXDM2MFwyMTRcMjRcMCIuLi4sIDUxMikg PSA1MTIKMzQ2NyAgZnN0YXQ2NCgzLCB7c3RfbW9kZT1TX0lGUkVHfDA3NTUsIHN0X3NpemU9MTY3 NzU3NiwgLi4ufSkgPSAwCjM0NjcgIG1tYXAyKE5VTEwsIDE0NTIyODAsIFBST1RfUkVBRHxQUk9U X0VYRUMsIE1BUF9QUklWQVRFfE1BUF9ERU5ZV1JJVEUsIDMsIDApID0gMHhiNzYyMTAwMAozNDY3 ICBtcHJvdGVjdCgweGI3NzdkMDAwLCA0MDk2LCBQUk9UX05PTkUpID0gMAozNDY3ICBtbWFwMigw eGI3NzdlMDAwLCAxMjI4OCwgUFJPVF9SRUFEfFBST1RfV1JJVEUsIE1BUF9QUklWQVRFfE1BUF9G SVhFRHxNQVBfREVOWVdSSVRFLCAzLCAweDE1YykgPSAweGI3NzdlMDAwCjM0NjcgIG1tYXAyKDB4 Yjc3ODEwMDAsIDEwNDg4LCBQUk9UX1JFQUR8UFJPVF9XUklURSwgTUFQX1BSSVZBVEV8TUFQX0ZJ WEVEfE1BUF9BTk9OWU1PVVMsIC0xLCAwKSA9IDB4Yjc3ODEwMDAKMzQ2NyAgY2xvc2UoMykgICAg ICAgICAgICAgICAgICAgICAgICAgID0gMAozNDY3ICBtbWFwMihOVUxMLCA0MDk2LCBQUk9UX1JF QUR8UFJPVF9XUklURSwgTUFQX1BSSVZBVEV8TUFQX0FOT05ZTU9VUywgLTEsIDApID0gMHhiNzYy MDAwMAozNDY3ICBzZXRfdGhyZWFkX2FyZWEoe2VudHJ5X251bWJlcjotMSAtPiA2LCBiYXNlX2Fk ZHI6MHhiNzYyMDZjMCwgbGltaXQ6MTA0ODU3NSwgc2VnXzMyYml0OjEsIGNvbnRlbnRzOjAsIHJl YWRfZXhlY19vbmx5OjAsIGxpbWl0X2luX3BhZ2VzOjEsIHNlZ19ub3RfcHJlc2VudDowLCB1c2Vh YmxlOjF9KSA9IDAKMzQ2NyAgbXByb3RlY3QoMHhiNzc3ZTAwMCwgODE5MiwgUFJPVF9SRUFEKSA9 IDAKMzQ2NyAgbXByb3RlY3QoMHhiNzdiZTAwMCwgNDA5NiwgUFJPVF9SRUFEKSA9IDAKMzQ2NyAg bXByb3RlY3QoMHhiNzdhODAwMCwgNDA5NiwgUFJPVF9SRUFEKSA9IDAKMzQ2NyAgbXVubWFwKDB4 Yjc3ODQwMDAsIDE3MDQzKSAgICAgICAgID0gMAozNDY3ICBicmsoMCkgICAgICAgICAgICAgICAg ICAgICAgICAgICAgPSAweGI3ZmY0MDAwCjM0NjcgIGJyaygweGI4MDE1MDAwKSAgICAgICAgICAg ICAgICAgICA9IDB4YjgwMTUwMDAKMzQ2NyAgb3BlbigiL2V0Yy9tdGFiIiwgT19SRE9OTFkpICAg ICAgID0gMwozNDY3ICBmc3RhdDY0KDMsIHtzdF9tb2RlPVNfSUZSRUd8MDY0NCwgc3Rfc2l6ZT00 NDksIC4uLn0pID0gMAozNDY3ICBtbWFwMihOVUxMLCA0MDk2LCBQUk9UX1JFQUR8UFJPVF9XUklU RSwgTUFQX1BSSVZBVEV8TUFQX0FOT05ZTU9VUywgLTEsIDApID0gMHhiNzc4ODAwMAozNDY3ICBy ZWFkKDMsICJyb290ZnMgLyByb290ZnMgcncgMCAwXG4vZGV2L2Rpc2svYnktdXVpZC83YTIzNWQ2 NC01ZDA0LTQxYWMtYTk1OS03MDQ2NWViNzRmYzggLyBleHQzIHJ3LHJlbGF0aW1lLGVyciIuLi4s IDQwOTYpID0gNDQ5CjM0NjcgIHJlYWQoMywgIiIsIDQwOTYpICAgICAgICAgICAgICAgICA9IDAK MzQ2NyAgY2xvc2UoMykgICAgICAgICAgICAgICAgICAgICAgICAgID0gMAozNDY3ICBtdW5tYXAo MHhiNzc4ODAwMCwgNDA5NikgICAgICAgICAgPSAwCjM0NjcgIHN0YXQ2NCgiLyIsIHtzdF9tb2Rl PVNfSUZESVJ8MDc1NSwgc3Rfc2l6ZT00MDk2LCAuLi59KSA9IDAKMzQ2NyAgc3RhdDY0KCIvIiwg e3N0X21vZGU9U19JRkRJUnwwNzU1LCBzdF9zaXplPTQwOTYsIC4uLn0pID0gMAozNDY3ICBzdGF0 NjQoIi9kZXYvcHRzIiwge3N0X21vZGU9U19JRkRJUnwwNzU1LCBzdF9zaXplPTAsIC4uLn0pID0g MAozNDY3ICBzdGF0NjQoIi9zeXMiLCB7c3RfbW9kZT1TX0lGRElSfDA1NTUsIHN0X3NpemU9MCwg Li4ufSkgPSAwCjM0NjcgIHN0YXQ2NCgiL2Rldi9zaG0iLCB7c3RfbW9kZT1TX0lGRElSfFNfSVNW VFh8MDc3Nywgc3Rfc2l6ZT00MCwgLi4ufSkgPSAwCjM0NjcgIGZzdGF0YXQ2NChBVF9GRENXRCwg ImEiLCB7c3RfbW9kZT1TX0lGRElSfDA3NTUsIHN0X3NpemU9NDA5NiwgLi4ufSwgQVRfU1lNTElO S19OT0ZPTExPVykgPSAwCjM0NjcgIG9wZW5hdChBVF9GRENXRCwgImEiLCBPX1JET05MWXxPX05P Q1RUWXxPX05PTkJMT0NLfE9fTEFSR0VGSUxFfE9fRElSRUNUT1JZfE9fTk9GT0xMT1cpID0gMwoz NDY3ICBmY250bDY0KDMsIEZfR0VURkQpICAgICAgICAgICAgICAgPSAwCjM0NjcgIGZjbnRsNjQo MywgRl9TRVRGRCwgRkRfQ0xPRVhFQykgICA9IDAKMzQ2NyAgZnN0YXQ2NCgzLCB7c3RfbW9kZT1T X0lGRElSfDA3NTUsIHN0X3NpemU9NDA5NiwgLi4ufSkgPSAwCjM0NjcgIGZjbnRsNjQoMywgRl9H RVRGTCkgICAgICAgICAgICAgICA9IDB4Mzg4MDAgKGZsYWdzIE9fUkRPTkxZfE9fTk9OQkxPQ0t8 T19MQVJHRUZJTEV8T19ESVJFQ1RPUll8T19OT0ZPTExPVykKMzQ2NyAgZmNudGw2NCgzLCBGX1NF VEZELCBGRF9DTE9FWEVDKSAgID0gMAozNDY3ICBmc3RhdGF0NjQoQVRfRkRDV0QsICJhIiwge3N0 X21vZGU9U19JRkRJUnwwNzU1LCBzdF9zaXplPTQwOTYsIC4uLn0sIEFUX1NZTUxJTktfTk9GT0xM T1cpID0gMAozNDY3ICBmY250bDY0KDMsIEZfRFVQRkQsIDMpICAgICAgICAgICAgPSA0CjM0Njcg IGZjbnRsNjQoNCwgRl9HRVRGRCkgICAgICAgICAgICAgICA9IDAKMzQ2NyAgZmNudGw2NCg0LCBG X1NFVEZELCBGRF9DTE9FWEVDKSAgID0gMAozNDY3ICBnZXRkZW50czY0KDMsIC8qIDMgZW50cmll cyAqLywgMzI3NjgpID0gNzIKMzQ2NyAgZ2V0ZGVudHM2NCgzLCAvKiAwIGVudHJpZXMgKi8sIDMy NzY4KSA9IDAKMzQ2NyAgY2xvc2UoMykgICAgICAgICAgICAgICAgICAgICAgICAgID0gMAozNDY3 ICBmc3RhdGF0NjQoNCwgImIiLCB7c3RfbW9kZT1TX0lGRElSfDA3NTUsIHN0X3NpemU9NDA5Niwg Li4ufSwgQVRfU1lNTElOS19OT0ZPTExPVykgPSAwCjM0NjcgIG9wZW4oIi91c3IvbGliL2NoYXJz ZXQuYWxpYXMiLCBPX1JET05MWXxPX0xBUkdFRklMRXxPX05PRk9MTE9XKSA9IC0xIEVOT0VOVCAo Tm8gc3VjaCBmaWxlIG9yIGRpcmVjdG9yeSkKMzQ2NyAgd3JpdGUoMiwgImR1OiAiLCA0KSAgICAg ICAgICAgICAgID0gNAozNDY3ICB3cml0ZSgyLCAiV0FSTklORzogQ2lyY3VsYXIgZGlyZWN0b3J5 IHN0cnVjdHVyZS5cblRoaXMgYWxtb3N0IGNlcnRhaW5seSBtZWFucyB0aGF0IHlvdSBoYXZlIGEg Y29ycnVwdGVkIGZpbGUgc3kiLi4uLCAxODgpID0gMTg4CjM0NjcgIHdyaXRlKDIsICJcbiIsIDEp ICAgICAgICAgICAgICAgICA9IDEKMzQ2NyAgY2xvc2UoNCkgICAgICAgICAgICAgICAgICAgICAg ICAgID0gMAozNDY3ICBmc3RhdDY0KDEsIHtzdF9tb2RlPVNfSUZDSFJ8MDYyMCwgc3RfcmRldj1t YWtlZGV2KDEzNiwgMCksIC4uLn0pID0gMAozNDY3ICBtbWFwMihOVUxMLCA0MDk2LCBQUk9UX1JF QUR8UFJPVF9XUklURSwgTUFQX1BSSVZBVEV8TUFQX0FOT05ZTU9VUywgLTEsIDApID0gMHhiNzc4 ODAwMAozNDY3ICB3cml0ZSgxLCAiNFx0YVxuIiwgNCkgICAgICAgICAgICAgPSA0CjM0NjcgIGNs b3NlKDEpICAgICAgICAgICAgICAgICAgICAgICAgICA9IDAKMzQ2NyAgbXVubWFwKDB4Yjc3ODgw MDAsIDQwOTYpICAgICAgICAgID0gMAozNDY3ICBjbG9zZSgyKSAgICAgICAgICAgICAgICAgICAg ICAgICAgPSAwCjM0NjcgIGV4aXRfZ3JvdXAoMSkgICAgICAgICAgICAgICAgICAgICA9ID8K ------=_Part_329281054_1589678056.1351154592244-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 07:03:07 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 11:03:07 +0000 Received: from localhost ([127.0.0.1]:60750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRLDP-0008DB-Cm for submit@debbugs.gnu.org; Thu, 25 Oct 2012 07:03:07 -0400 Received: from mx.meyering.net ([88.168.87.75]:41754) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRLDM-0008D2-Fy for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 07:03:05 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 5262E6024F; Thu, 25 Oct 2012 13:01:00 +0200 (CEST) From: Jim Meyering To: g.esp@free.fr Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh In-Reply-To: <1483616685.329281056.1351154592247.JavaMail.root@zimbra33-e6.priv.proxad.net> (g. esp's message of "Thu, 25 Oct 2012 10:43:12 +0200 (CEST)") References: <1483616685.329281056.1351154592247.JavaMail.root@zimbra33-e6.priv.proxad.net> Date: Thu, 25 Oct 2012 13:01:00 +0200 Message-ID: <87wqyehl3n.fsf@rho.meyering.net> Lines: 71 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) g.esp@free.fr wrote: > A new test in 8.20 fail because "mount point 'a/b' already traversed" > is not emitted > > [chroot-i486] root:/usr/src/coreutils-8.20$ uname -r; mount --version > 3.4.15 > mount from util-linux 2.22.1 (libmount 2.22.0: debug) > > [chroot-i486] root:/usr/src/coreutils-8.20$ FORCE_UNSAFE_CONFIGURE=1 > ./configure --prefix=/usr --disable-nls > --enable-no-install-program=kill,uptime > ... > [chroot-i486] root:/usr/src/coreutils-8.20$ make check > TESTS=tests/du/bind-mount-dir-cycle.sh > ... > FAIL: tests/du/bind-mount-dir-cycle.sh (exit: 1) > ... > + mkdir -p a/b > + mount --bind a a/b > + echo a > + echo 'du: mount point '\''a/b'\'' already traversed' > + du a > + sed 's/^[0-9][0-9]* //' out > + mv k out > + compare exp-err err > + compare_dev_null_ exp-err err > + test 2 = 2 > + test xexp-err = x/dev/null > + test xerr = x/dev/null > + return 2 > + case $? in > + compare_ exp-err err > + diff -u exp-err err > --- exp-err 2012-10-25 09:24:00.000000000 +0200 > +++ err 2012-10-25 09:24:00.000000000 +0200 > @@ -1 +1,6 @@ > -du: mount point 'a/b' already traversed > +du: WARNING: Circular directory structure. ... > I attached the result of strace -o du-bind-mount-dir-cycle.log -s100 -f du a ... > 3467 stat64("/", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 > 3467 stat64("/", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 > 3467 stat64("/dev/pts", {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0 > 3467 stat64("/sys", {st_mode=S_IFDIR|0555, st_size=0, ...}) = 0 > 3467 stat64("/dev/shm", {st_mode=S_IFDIR|S_ISVTX|0777, st_size=40, ...}) = 0 > 3467 fstatat64(AT_FDCWD, "a", {st_mode=S_IFDIR|0755, st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0 > 3467 openat(AT_FDCWD, "a", O_RDONLY|O_NOCTTY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_NOFOLLOW) = 3 ... Thanks for the report. That shows that the mount-listing code does not include the bind-mounted a/b on your system. Here's what I see on Fedora 17, 18, and rawhide: # mkdir -p a/b && mount --bind a a/ strace -e stat /cu/src/du a stat("/", {st_mode=S_IFDIR|0555, st_size=4096, ...}) = 0 stat("/sys", {st_mode=S_IFDIR|0555, st_size=0, ...}) = 0 ... stat("/t/a/b", {st_mode=S_IFDIR|0700, st_size=60, ...}) = 0 /cu/src/du: mount point 'a/b' already traversed 0 a +++ exited with 1 +++ I can see it in /proc/mounts, too: $ grep a/b /proc/mounts : tmpfs /t/a/b tmpfs rw,seclabel,relatime,size=5345280k 0 0 There must be something different about your system. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 07:16:12 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 11:16:12 +0000 Received: from localhost ([127.0.0.1]:60767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRLQ4-0008Vh-01 for submit@debbugs.gnu.org; Thu, 25 Oct 2012 07:16:12 -0400 Received: from smtp3-g21.free.fr ([212.27.42.3]:55174) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRLQ0-0008VX-6s for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 07:16:09 -0400 Received: from zimbra33-e6.priv.proxad.net (unknown [172.20.243.183]) by smtp3-g21.free.fr (Postfix) with ESMTP id AAD8FA62C3; Thu, 25 Oct 2012 13:13:59 +0200 (CEST) Date: Thu, 25 Oct 2012 13:13:58 +0200 (CEST) From: g.esp@free.fr To: Jim Meyering Message-ID: <1224822599.329726140.1351163638489.JavaMail.root@zimbra33-e6.priv.proxad.net> In-Reply-To: <87wqyehl3n.fsf@rho.meyering.net> Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [82.236.101.3] X-Mailer: Zimbra 7.2.0-GA2598 (ZimbraWebClient - FF3.0 (Win)/7.2.0-GA2598) X-Authenticated-User: g.esp@free.fr X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) ----- Mail original ----- > De: "Jim Meyering" > =C3=80: "g esp" > Cc: 12730@debbugs.gnu.org > Envoy=C3=A9: Jeudi 25 Octobre 2012 13:01:00 > Objet: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh >=20 > g.esp@free.fr wrote: > > A new test in 8.20 fail because "mount point 'a/b' already > > traversed" > > is not emitted > > > > [chroot-i486] root:/usr/src/coreutils-8.20$ uname -r; mount > > --version > > 3.4.15 > > mount from util-linux 2.22.1 (libmount 2.22.0: debug) > > > > [chroot-i486] root:/usr/src/coreutils-8.20$ > > FORCE_UNSAFE_CONFIGURE=3D1 > > ./configure --prefix=3D/usr --disable-nls > > --enable-no-install-program=3Dkill,uptime > > ... > > [chroot-i486] root:/usr/src/coreutils-8.20$ make check > > TESTS=3Dtests/du/bind-mount-dir-cycle.sh > > ... > > FAIL: tests/du/bind-mount-dir-cycle.sh (exit: 1) > > ... > > + mkdir -p a/b > > + mount --bind a a/b > > + echo a > > + echo 'du: mount point '\''a/b'\'' already traversed' > > + du a > > + sed 's/^[0-9][0-9]* //' out > > + mv k out > > + compare exp-err err > > + compare_dev_null_ exp-err err > > + test 2 =3D 2 > > + test xexp-err =3D x/dev/null > > + test xerr =3D x/dev/null > > + return 2 > > + case $? in > > + compare_ exp-err err > > + diff -u exp-err err > > --- exp-err 2012-10-25 09:24:00.000000000 +0200 > > +++ err 2012-10-25 09:24:00.000000000 +0200 > > @@ -1 +1,6 @@ > > -du: mount point 'a/b' already traversed > > +du: WARNING: Circular directory structure. > ... > > I attached the result of strace -o du-bind-mount-dir-cycle.log > > -s100 -f du a > ... > > 3467 stat64("/", {st_mode=3DS_IFDIR|0755, st_size=3D4096, ...}) =3D 0 > > 3467 stat64("/", {st_mode=3DS_IFDIR|0755, st_size=3D4096, ...}) =3D 0 > > 3467 stat64("/dev/pts", {st_mode=3DS_IFDIR|0755, st_size=3D0, ...}) = =3D > > 0 > > 3467 stat64("/sys", {st_mode=3DS_IFDIR|0555, st_size=3D0, ...}) =3D 0 > > 3467 stat64("/dev/shm", {st_mode=3DS_IFDIR|S_ISVTX|0777, st_size=3D40, > > ...}) =3D 0 > > 3467 fstatat64(AT_FDCWD, "a", {st_mode=3DS_IFDIR|0755, st_size=3D4096, > > ...}, AT_SYMLINK_NOFOLLOW) =3D 0 > > 3467 openat(AT_FDCWD, "a", > > O_RDONLY|O_NOCTTY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_NOFOLLOW) =3D > > 3 > ... >=20 > Thanks for the report. >=20 > That shows that the mount-listing code does not include the > bind-mounted a/b on your system. Here's what I see on > Fedora 17, 18, and rawhide: >=20 > # mkdir -p a/b && mount --bind a a/ strace -e stat /cu/src/du a > stat("/", {st_mode=3DS_IFDIR|0555, st_size=3D4096, ...}) =3D 0 > stat("/sys", {st_mode=3DS_IFDIR|0555, st_size=3D0, ...}) =3D 0 > ... > stat("/t/a/b", {st_mode=3DS_IFDIR|0700, st_size=3D60, ...}) =3D 0 > /cu/src/du: mount point 'a/b' already traversed > 0 a > +++ exited with 1 +++ >=20 > I can see it in /proc/mounts, too: >=20 > $ grep a/b /proc/mounts > : > tmpfs /t/a/b tmpfs rw,seclabel,relatime,size=3D5345280k 0 0 >=20 > There must be something different about your system. >=20 That's another time a regular /etc/mtab issue chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ ln -sf /proc/mounts /etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b [chroot-i486] root:/usr/src/coreutils-8.20$ du a du: mount point 'a/b' already traversed 4 a [chroot-i486] root:/usr/src/coreutils-8.20$ umount a/b [chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ grep ' / ' /proc/mounts >/etc/m= tab [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b [chroot-i486] root:/usr/src/coreutils-8.20$ du a du: WARNING: Circular directory structure. This almost certainly means that you have a corrupted file system. NOTIFY YOUR SYSTEM MANAGER. The following directory is part of the cycle: 'a/b' 4 a I send a patch that fixed the test for me adding the regular mtab case mess= age. I don't know if this is the proper way to fix the issue or if that uncover = a bug in du code. The comment on this test cleanup_ make me smile. Gilles From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 08:21:19 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 12:21:19 +0000 Received: from localhost ([127.0.0.1]:60805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRMR5-0002iM-9j for submit@debbugs.gnu.org; Thu, 25 Oct 2012 08:21:19 -0400 Received: from mx.meyering.net ([88.168.87.75]:41921) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRMR2-0002iE-S7 for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 08:21:18 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 555DF6024F; Thu, 25 Oct 2012 14:19:12 +0200 (CEST) From: Jim Meyering To: g.esp@free.fr Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh In-Reply-To: <1224822599.329726140.1351163638489.JavaMail.root@zimbra33-e6.priv.proxad.net> (g. esp's message of "Thu, 25 Oct 2012 13:13:58 +0200 (CEST)") References: <1224822599.329726140.1351163638489.JavaMail.root@zimbra33-e6.priv.proxad.net> Date: Thu, 25 Oct 2012 14:19:12 +0200 Message-ID: <87k3uehhhb.fsf@rho.meyering.net> Lines: 78 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) g.esp@free.fr wrote: ... >> I can see it in /proc/mounts, too: >> >> $ grep a/b /proc/mounts >> : >> tmpfs /t/a/b tmpfs rw,seclabel,relatime,size=5345280k 0 0 >> >> There must be something different about your system. >> > That's another time a regular /etc/mtab issue > > chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ ln -sf /proc/mounts /etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b > [chroot-i486] root:/usr/src/coreutils-8.20$ du a > du: mount point 'a/b' already traversed > 4 a > > [chroot-i486] root:/usr/src/coreutils-8.20$ umount a/b > [chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ grep ' / ' /proc/mounts >/etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b > [chroot-i486] root:/usr/src/coreutils-8.20$ du a > du: WARNING: Circular directory structure. > This almost certainly means that you have a corrupted file system. > NOTIFY YOUR SYSTEM MANAGER. > The following directory is part of the cycle: > 'a/b' > > 4 a > I send a patch that fixed the test for me adding the regular mtab case message. > I don't know if this is the proper way to fix the issue or if that > uncover a bug in du code. Thanks for the patch, but at least for now, it seems to me like that test is failing because your chroot is improperly configured. I.e., when your system configuration makes it impossible to obtain a list of mount points using a relatively standard API, a failing test serves as a heads up. > The comment on this test cleanup_ make me smile. Thanks. That deserves a patch: >From 46388ce46ec478b0801ec5b217f5004137afa870 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 25 Oct 2012 13:41:45 +0200 Subject: [PATCH] maint: remove an obsolete test comment * tests/du/bind-mount-dir-cycle.sh: Remove obsolete comment spotted by Gilles Espinasse. --- tests/du/bind-mount-dir-cycle.sh | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tests/du/bind-mount-dir-cycle.sh b/tests/du/bind-mount-dir-cycle.sh index d8d381a..92b4773 100755 --- a/tests/du/bind-mount-dir-cycle.sh +++ b/tests/du/bind-mount-dir-cycle.sh @@ -20,13 +20,7 @@ print_ver_ du require_root_ -cleanup_() -{ - # When you take the undesirable shortcut of making /etc/mtab a link - # to /proc/mounts, unmounting "$other_partition_tmpdir" would fail. - # So, here we unmount a/b instead. - umount a/b -} +cleanup_() { umount a/b; } mkdir -p a/b || framework_failure_ mount --bind a a/b \ -- 1.8.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 12:16:20 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 16:16:20 +0000 Received: from localhost ([127.0.0.1]:33439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRQ6W-0000jY-8s for submit@debbugs.gnu.org; Thu, 25 Oct 2012 12:16:20 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]:34221) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRQ6S-0000jM-Ue for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 12:16:18 -0400 Received: from zimbra33-e6.priv.proxad.net (unknown [172.20.243.183]) by smtp6-g21.free.fr (Postfix) with ESMTP id 248B58235F; Thu, 25 Oct 2012 18:14:06 +0200 (CEST) Date: Thu, 25 Oct 2012 18:14:05 +0200 (CEST) From: g.esp@free.fr To: Jim Meyering Message-ID: <1488904436.330581593.1351181645478.JavaMail.root@zimbra33-e6.priv.proxad.net> In-Reply-To: <87k3uehhhb.fsf@rho.meyering.net> Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [82.236.101.3] X-Mailer: Zimbra 7.2.0-GA2598 (ZimbraWebClient - FF3.0 (Win)/7.2.0-GA2598) X-Authenticated-User: g.esp@free.fr X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) ----- Mail original ----- > De: "Jim Meyering" > =C3=80: "g esp" > Cc: 12730@debbugs.gnu.org > Envoy=C3=A9: Jeudi 25 Octobre 2012 14:19:12 > Objet: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle= .sh >=20 ... >=20 > Thanks for the patch, but at least for now, it seems to me like > that test is failing because your chroot is improperly configured. > I.e., when your system configuration makes it impossible to obtain > a list of mount points using a relatively standard API, a failing > test serves as a heads up. >=20 I fixed anything unusual in my setup and run the last long-term kernel, so = the chroot is now almost very clean. The line in /etc/mtab that let hash.c take a different code path is=20 rootfs / rootfs rw 0 0 I have no issue removing that line in my chroot. Is that rootfs line forbidden now? Gilles From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 12:24:30 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 16:24:30 +0000 Received: from localhost ([127.0.0.1]:33447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRQEP-0000vH-Sh for submit@debbugs.gnu.org; Thu, 25 Oct 2012 12:24:30 -0400 Received: from mx.meyering.net ([88.168.87.75]:42490) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRQEN-0000v8-Fi for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 12:24:28 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id C552260098; Thu, 25 Oct 2012 18:22:21 +0200 (CEST) From: Jim Meyering To: g.esp@free.fr Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh In-Reply-To: <1488904436.330581593.1351181645478.JavaMail.root@zimbra33-e6.priv.proxad.net> (g. esp's message of "Thu, 25 Oct 2012 18:14:05 +0200 (CEST)") References: <1488904436.330581593.1351181645478.JavaMail.root@zimbra33-e6.priv.proxad.net> Date: Thu, 25 Oct 2012 18:22:21 +0200 Message-ID: <87a9vafrnm.fsf@rho.meyering.net> Lines: 56 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) g.esp@free.fr wrote: > ----- Mail original ----- >> De: "Jim Meyering" >> =C0: "g esp" >> Cc: 12730@debbugs.gnu.org >> Envoy=E9: Jeudi 25 Octobre 2012 14:19:12 >> Objet: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycl= e.sh >> > ... >> >> Thanks for the patch, but at least for now, it seems to me like >> that test is failing because your chroot is improperly configured. >> I.e., when your system configuration makes it impossible to obtain >> a list of mount points using a relatively standard API, a failing >> test serves as a heads up. >> > > I fixed anything unusual in my setup and run the last long-term > kernel, so the chroot is now almost very clean. > > The line in /etc/mtab that let hash.c take a different code path is > rootfs / rootfs rw 0 0 You wrote this: chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ ln -sf /proc/mounts /etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b [chroot-i486] root:/usr/src/coreutils-8.20$ du a du: mount point 'a/b' already traversed 4 a [chroot-i486] root:/usr/src/coreutils-8.20$ umount a/b [chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ grep ' / ' /proc/mounts >/etc= /mtab [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b [chroot-i486] root:/usr/src/coreutils-8.20$ du a du: WARNING: Circular directory structure. This almost certainly means that you have a corrupted file system. NOTIFY YOUR SYSTEM MANAGER. The following directory is part of the cycle: 'a/b' 4 a Does the latter mount command arrange to add a line to the one-line (root-only) /etc/mtab ? To me, it looks like the *lack* of a line for the a/b mount is the problem. When you remove the symlink the mount command does not update the regular-file /etc/mtab, so mount-listing code cannot see that a/b is bind-mounted. > I have no issue removing that line in my chroot. > > Is that rootfs line forbidden now? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 14:11:11 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 18:11:11 +0000 Received: from localhost ([127.0.0.1]:33612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRRtf-0004GV-0L for submit@debbugs.gnu.org; Thu, 25 Oct 2012 14:11:11 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:38214) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRRtc-0004GH-EA for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 14:11:10 -0400 Received: from zimbra33-e6.priv.proxad.net (unknown [172.20.243.183]) by smtp2-g21.free.fr (Postfix) with ESMTP id C30C34B00E2; Thu, 25 Oct 2012 20:08:57 +0200 (CEST) Date: Thu, 25 Oct 2012 20:08:56 +0200 (CEST) From: g.esp@free.fr To: Jim Meyering Message-ID: <864818009.330947620.1351188536403.JavaMail.root@zimbra33-e6.priv.proxad.net> In-Reply-To: <87a9vafrnm.fsf@rho.meyering.net> Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [82.236.101.3] X-Mailer: Zimbra 7.2.0-GA2598 (ZimbraWebClient - FF3.0 (Win)/7.2.0-GA2598) X-Authenticated-User: g.esp@free.fr X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) ----- Mail original ----- > De: "Jim Meyering" > =C3=80: "g esp" > Cc: 12730@debbugs.gnu.org > Envoy=C3=A9: Jeudi 25 Octobre 2012 18:22:21 > Objet: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh >=20 > > The line in /etc/mtab that let hash.c take a different code path is > > rootfs / rootfs rw 0 0 >=20 I withdraw my conclusion concerning rootfs line. I made something wrong during testing as I can't reproduce that result now. > You wrote this: >=20 > chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ ln -sf /proc/mounts /etc/mt= ab > [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b > [chroot-i486] root:/usr/src/coreutils-8.20$ du a > du: mount point 'a/b' already traversed > 4 a >=20 > [chroot-i486] root:/usr/src/coreutils-8.20$ umount a/b > [chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ grep ' / ' /proc/mounts >/e= tc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b > [chroot-i486] root:/usr/src/coreutils-8.20$ du a > du: WARNING: Circular directory structure. > This almost certainly means that you have a corrupted file system. > NOTIFY YOUR SYSTEM MANAGER. > The following directory is part of the cycle: > 'a/b' >=20 > 4 a >=20 > Does the latter mount command arrange to add a line to the > one-line (root-only) /etc/mtab ? >=20 Yes I created a/b by hand directly in /usr/src/coreutils-8.20. [chroot-i486] root:/usr/src/coreutils-8.20$ grep '^\/dev.* / ' /proc/mounts= >/etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ mount --bind a a/b [chroot-i486] root:/usr/src/coreutils-8.20$ cat /etc/mtab /dev/disk/by-uuid/7a235d64-5d04-41ac-a959-70465eb74fc8 / ext3 rw,relatime,e= rrors=3Dremount-ro,barrier=3D1,data=3Dordered 0 0 /usr/src/coreutils-8.20/a /usr/src/coreutils-8.20/a/b none rw,bind 0 0 The behavior difference is in hash_lookup in if (bucket->data =3D=3D NULL) = test. I added a few printf to find that. With symlink /etc/mtab, code go further, with regular /etc/mtab, code retur= n NULL there. > To me, it looks like the *lack* of a line for the a/b mount > is the problem. When you remove the symlink the mount command > does not update the regular-file /etc/mtab, so mount-listing > code cannot see that a/b is bind-mounted. >=20 No, this is not a missing line but understanding that line content. To prove that, I started again with a new mtab, - mounted a/b without writting to mtab - copied to mtab a line content with a/b mounted exactly the same as in /pr= oc/mounts case, - hash_lookup answer changed . [chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ grep '^\/dev.* / ' /proc/mounts= >/etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ mount -n --bind a a/b [chroot-i486] root:/usr/src/coreutils-8.20$ echo '/dev/disk/by-uuid/7a235d6= 4-5d04-41ac-a959-70465eb74fc8 /usr/src/coreutils-8.20/a/b ext3 rw,relatime,= errors=3Dremount-ro,barrier=3D1,data=3Dordered 0 0' >>/etc/mtab [chroot-i486] root:/usr/src/coreutils-8.20$ ./src/du a ./src/du: mount point 'a/b' already traversed 4 a Gilles From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 15:39:16 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 19:39:16 +0000 Received: from localhost ([127.0.0.1]:33685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRTGt-0006HP-Ke for submit@debbugs.gnu.org; Thu, 25 Oct 2012 15:39:16 -0400 Received: from mx.meyering.net ([88.168.87.75]:36266) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRTGr-0006HI-Kk for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 15:39:14 -0400 Received: from rho (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 0CE52603D9; Thu, 25 Oct 2012 21:37:08 +0200 (CEST) From: Jim Meyering To: g.esp@free.fr Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh In-Reply-To: <864818009.330947620.1351188536403.JavaMail.root@zimbra33-e6.priv.proxad.net> (g. esp's message of "Thu, 25 Oct 2012 20:08:56 +0200 (CEST)") References: <864818009.330947620.1351188536403.JavaMail.root@zimbra33-e6.priv.proxad.net> Date: Thu, 25 Oct 2012 21:37:08 +0200 Message-ID: <87a9va5onv.fsf@meyering.net> Lines: 38 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) g.esp@free.fr wrote: ... >> To me, it looks like the *lack* of a line for the a/b mount >> is the problem. When you remove the symlink the mount command >> does not update the regular-file /etc/mtab, so mount-listing >> code cannot see that a/b is bind-mounted. >> > No, this is not a missing line but understanding that line content. > > To prove that, I started again with a new mtab, > - mounted a/b without writting to mtab > - copied to mtab a line content with a/b mounted exactly the same as > in /proc/mounts case, > - hash_lookup answer changed > . > [chroot-i486] root:/usr/src/coreutils-8.20$ rm -f /etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ grep '^\/dev.* / ' > /proc/mounts >/etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ mount -n --bind a a/b > [chroot-i486] root:/usr/src/coreutils-8.20$ echo > /dev/disk/by-uuid/7a235d64-5d04-41ac-a959-70465eb74fc8 > /usr/src/coreutils-8.20/a/b ext3 > rw,relatime,errors=remount-ro,barrier=1,data=ordered 0 0' >>/etc/mtab > [chroot-i486] root:/usr/src/coreutils-8.20$ ./src/du a > ./src/du: mount point 'a/b' already traversed > 4 a It sounds like you have confirmed my conclusion. When you use a symlink, /etc/mtab contains a line for the a/b mount and the mount-listing loop in fill_mount_table inserts an entry for a/b. Later, when we search that table for the inode of "a/b", we find that entry and know that it's a bind-mount, so issue only the minor warning, rather than the "DISK CORRUPTION" warning. With your regular mtab file, it contains no such a/b line, and the mount-listing loop in fill_mount_table inserts no entry for a/b. Later, when we search that table for a/b's inode, we find no entry and have to report the more serious error. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 16:57:02 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 20:57:02 +0000 Received: from localhost ([127.0.0.1]:33744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRUU9-0000VI-RC for submit@debbugs.gnu.org; Thu, 25 Oct 2012 16:57:02 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:57328) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRUU6-0000Uw-49 for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 16:57:00 -0400 Received: from zimbra33-e6.priv.proxad.net (unknown [172.20.243.183]) by smtp5-g21.free.fr (Postfix) with ESMTP id 83ED0D4802A; Thu, 25 Oct 2012 22:54:47 +0200 (CEST) Date: Thu, 25 Oct 2012 22:54:46 +0200 (CEST) From: g.esp@free.fr To: Jim Meyering Message-ID: <1197661351.331305547.1351198486238.JavaMail.root@zimbra33-e6.priv.proxad.net> In-Reply-To: <87a9va5onv.fsf@meyering.net> Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [82.236.101.3] X-Mailer: Zimbra 7.2.0-GA2598 (ZimbraWebClient - FF3.0 (Win)/7.2.0-GA2598) X-Authenticated-User: g.esp@free.fr X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) ----- Mail original ----- > De: "Jim Meyering" > =C3=80: "g esp" > Cc: 12730@debbugs.gnu.org > Envoy=C3=A9: Jeudi 25 Octobre 2012 21:37:08 > Objet: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh >=20 ... >=20 > It sounds like you have confirmed my conclusion. > When you use a symlink, /etc/mtab contains a line for the a/b mount > and the mount-listing loop in fill_mount_table inserts an entry for > a/b. > Later, when we search that table for the inode of "a/b", we find > that entry and know that it's a bind-mount, so issue only the minor > warning, rather than the "DISK CORRUPTION" warning. >=20 > With your regular mtab file, it contains no such a/b line, and > the mount-listing loop in fill_mount_table inserts no entry for a/b. > Later, when we search that table for a/b's inode, we find no entry > and have to report the more serious error. >=20 >=20 I don't understand why you conclude that a/b is missing in regular mtab cas= e. To give shorter lines easier to read [chroot-i486] root:/usr/src/coreutils-8.20$ cd / [chroot-i486] root:/$ mkdir -p a/b [chroot-i486] root:/$ mount --bind a a/b [chroot-i486] root:/$ cat /etc/mtab /dev/disk/by-uuid/7a235d64-5d04-41ac-a959-70465eb74fc8 / ext3 rw,relatime,e= rrors=3Dremount-ro,barrier=3D1,data=3Dordered 0 0 /a /a/b none rw,bind 0 0 I see a/b here and umount know how use that a/b entry [chroot-i486] root:/$ umount a/b [chroot-i486] root:/$ what is really missing? Gilles From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 17:08:55 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 21:08:55 +0000 Received: from localhost ([127.0.0.1]:33765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRUff-0000mz-B8 for submit@debbugs.gnu.org; Thu, 25 Oct 2012 17:08:55 -0400 Received: from mx.meyering.net ([88.168.87.75]:36381) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRUfc-0000mp-00 for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 17:08:53 -0400 Received: from rho (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id A892D60128; Thu, 25 Oct 2012 23:06:45 +0200 (CEST) From: Jim Meyering To: g.esp@free.fr Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh In-Reply-To: <1197661351.331305547.1351198486238.JavaMail.root@zimbra33-e6.priv.proxad.net> (g. esp's message of "Thu, 25 Oct 2012 22:54:46 +0200 (CEST)") References: <1197661351.331305547.1351198486238.JavaMail.root@zimbra33-e6.priv.proxad.net> Date: Thu, 25 Oct 2012 23:06:45 +0200 Message-ID: <87sj9245y2.fsf@meyering.net> Lines: 49 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) g.esp@free.fr wrote: > ----- Mail original ----- >> De: "Jim Meyering" >> =C0: "g esp" >> Cc: 12730@debbugs.gnu.org >> Envoy=E9: Jeudi 25 Octobre 2012 21:37:08 >> Objet: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh >> > ... >> >> It sounds like you have confirmed my conclusion. >> When you use a symlink, /etc/mtab contains a line for the a/b mount >> and the mount-listing loop in fill_mount_table inserts an entry for >> a/b. >> Later, when we search that table for the inode of "a/b", we find >> that entry and know that it's a bind-mount, so issue only the minor >> warning, rather than the "DISK CORRUPTION" warning. >> >> With your regular mtab file, it contains no such a/b line, and >> the mount-listing loop in fill_mount_table inserts no entry for a/b. >> Later, when we search that table for a/b's inode, we find no entry >> and have to report the more serious error. >> >> > I don't understand why you conclude that a/b is missing in regular mtab c= ase. > To give shorter lines easier to read > [chroot-i486] root:/usr/src/coreutils-8.20$ cd / > [chroot-i486] root:/$ mkdir -p a/b > [chroot-i486] root:/$ mount --bind a a/b > [chroot-i486] root:/$ cat /etc/mtab > /dev/disk/by-uuid/7a235d64-5d04-41ac-a959-70465eb74fc8 / ext3 > rw,relatime,errors=3Dremount-ro,barrier=3D1,data=3Dordered 0 0 > /a /a/b none rw,bind 0 0 > > I see a/b here and umount know how use that a/b entry > [chroot-i486] root:/$ umount a/b > [chroot-i486] root:/$ > > what is really missing? In the above, is /etc/mtab a regular file? Can you compare the contents with those of /proc/mounts? It might be useful to make fill_mount_table print each mnt_ent->me_devname for which it calls hash_insert. It sounds like the entry for a/b is being inserted when /etc/mtab points to /proc/mounts, but not in the other case. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 18:14:16 2012 Received: (at 12730) by debbugs.gnu.org; 25 Oct 2012 22:14:16 +0000 Received: from localhost ([127.0.0.1]:33815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRVgt-00036M-NH for submit@debbugs.gnu.org; Thu, 25 Oct 2012 18:14:16 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:53180) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRVgo-000369-EK for 12730@debbugs.gnu.org; Thu, 25 Oct 2012 18:14:14 -0400 Received: from zimbra33-e6.priv.proxad.net (unknown [172.20.243.183]) by smtp4-g21.free.fr (Postfix) with ESMTP id 279EF4C8014; Fri, 26 Oct 2012 00:11:58 +0200 (CEST) Date: Fri, 26 Oct 2012 00:11:58 +0200 (CEST) From: g.esp@free.fr To: Jim Meyering Message-ID: <10001730.331414129.1351203118024.JavaMail.root@zimbra33-e6.priv.proxad.net> In-Reply-To: <87sj9245y2.fsf@meyering.net> Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [82.236.101.3] X-Mailer: Zimbra 7.2.0-GA2598 (ZimbraWebClient - FF3.0 (Win)/7.2.0-GA2598) X-Authenticated-User: g.esp@free.fr X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) ----- Mail original ----- > De: "Jim Meyering" > =C3=80: "g esp" > Cc: 12730@debbugs.gnu.org > Envoy=C3=A9: Jeudi 25 Octobre 2012 23:06:45 > Objet: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh >=20 > g.esp@free.fr wrote: >=20 ... > > I don't understand why you conclude that a/b is missing in regular > > mtab case. > > To give shorter lines easier to read > > [chroot-i486] root:/usr/src/coreutils-8.20$ cd / > > [chroot-i486] root:/$ mkdir -p a/b > > [chroot-i486] root:/$ mount --bind a a/b > > [chroot-i486] root:/$ cat /etc/mtab > > /dev/disk/by-uuid/7a235d64-5d04-41ac-a959-70465eb74fc8 / ext3 > > rw,relatime,errors=3Dremount-ro,barrier=3D1,data=3Dordered 0 0 > > /a /a/b none rw,bind 0 0 > > > > I see a/b here and umount know how use that a/b entry > > [chroot-i486] root:/$ umount a/b > > [chroot-i486] root:/$ > > > > what is really missing? >=20 > In the above, is /etc/mtab a regular file? yes > Can you compare the contents with those of /proc/mounts? essentially -/dev/disk/by-uuid/7a235d64-5d04-41ac-a959-70465eb74fc8 /a/b ext3 rw,relati= me,errors=3Dremount-ro,barrier=3D1,data=3Dordered 0 0 +/a /a/b none rw,bind 0 0 >=20 > It might be useful to make fill_mount_table print each > mnt_ent->me_devname > for which it calls hash_insert. >=20 > It sounds like the entry for a/b is being inserted when /etc/mtab > points to /proc/mounts, but not in the other case. >=20 Yes, in that case, this line is exclude by the !mnt_ent->me_dummy condition= . The reason is that the fs value is 'none' and that qualify for the dummy li= st. Gilles From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 07:59:42 2012 Received: (at 12730) by debbugs.gnu.org; 26 Oct 2012 11:59:42 +0000 Received: from localhost ([127.0.0.1]:34359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRiZi-0006aK-Dt for submit@debbugs.gnu.org; Fri, 26 Oct 2012 07:59:42 -0400 Received: from mx.meyering.net ([88.168.87.75]:37369) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRiZf-0006a9-As for 12730@debbugs.gnu.org; Fri, 26 Oct 2012 07:59:41 -0400 Received: from rho (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 68C1360081; Fri, 26 Oct 2012 13:57:29 +0200 (CEST) From: Jim Meyering To: g.esp@free.fr Subject: Re: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh In-Reply-To: <10001730.331414129.1351203118024.JavaMail.root@zimbra33-e6.priv.proxad.net> (g. esp's message of "Fri, 26 Oct 2012 00:11:58 +0200 (CEST)") References: <10001730.331414129.1351203118024.JavaMail.root@zimbra33-e6.priv.proxad.net> Date: Fri, 26 Oct 2012 13:57:29 +0200 Message-ID: <87liet30pi.fsf@meyering.net> Lines: 59 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) g.esp@free.fr wrote: > ----- Mail original ----- >> De: "Jim Meyering" >> =C0: "g esp" >> Cc: 12730@debbugs.gnu.org >> Envoy=E9: Jeudi 25 Octobre 2012 23:06:45 >> Objet: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh >> >> g.esp@free.fr wrote: >> > ... >> > I don't understand why you conclude that a/b is missing in regular >> > mtab case. >> > To give shorter lines easier to read >> > [chroot-i486] root:/usr/src/coreutils-8.20$ cd / >> > [chroot-i486] root:/$ mkdir -p a/b >> > [chroot-i486] root:/$ mount --bind a a/b >> > [chroot-i486] root:/$ cat /etc/mtab >> > /dev/disk/by-uuid/7a235d64-5d04-41ac-a959-70465eb74fc8 / ext3 >> > rw,relatime,errors=3Dremount-ro,barrier=3D1,data=3Dordered 0 0 >> > /a /a/b none rw,bind 0 0 >> > >> > I see a/b here and umount know how use that a/b entry >> > [chroot-i486] root:/$ umount a/b >> > [chroot-i486] root:/$ >> > >> > what is really missing? >> >> In the above, is /etc/mtab a regular file? > yes >> Can you compare the contents with those of /proc/mounts? > > essentially > -/dev/disk/by-uuid/7a235d64-5d04-41ac-a959-70465eb74fc8 /a/b ext3 > rw,relatime,errors=3Dremount-ro,barrier=3D1,data=3Dordered 0 0 > +/a /a/b none rw,bind 0 0 > >> >> It might be useful to make fill_mount_table print each >> mnt_ent->me_devname >> for which it calls hash_insert. >> >> It sounds like the entry for a/b is being inserted when /etc/mtab >> points to /proc/mounts, but not in the other case. >> > Yes, in that case, this line is exclude by the !mnt_ent->me_dummy conditi= on. > The reason is that the fs value is 'none' and that qualify for the dummy = list. I'm not sure your case would be considered mainstream enough to merit changing mountlist.[ch], but that is a possibility: If we went that route, we'd change how me_dummy is set so that it takes account of your case. For example, we might add a boolean "is_bind_mount" parameter to ME_DUMMY macro, so that when me_type is "none" and is_bind_mount is true, ME_DUMMY would evaluate to false, rather than to true. The only tricky part would be robustly determining whether "bind" is in mnt->mnt_opts. Care to write the patch? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 01 11:27:51 2012 Received: (at 12730) by debbugs.gnu.org; 1 Nov 2012 15:27:51 +0000 Received: from localhost ([127.0.0.1]:43302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTwgP-0005qC-Lp for submit@debbugs.gnu.org; Thu, 01 Nov 2012 11:27:50 -0400 Received: from mail.99main.com ([208.28.184.11]:42323) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTwgO-0005q5-7i for 12730@debbugs.gnu.org; Thu, 01 Nov 2012 11:27:48 -0400 Received: from warshall.local.loc (65.172.152.38.dsl.99main.com [65.172.152.38]) by mail.99main.com (8.12.8+Sun/8.12.8) with ESMTP id qA1FP4Js017795 for <12730@debbugs.gnu.org>; Thu, 1 Nov 2012 10:25:04 -0500 (EST) Date: Thu, 1 Nov 2012 10:27:56 -0400 From: Andrew Warshall To: 12730@debbugs.gnu.org Subject: bug#12730: coreutils-8.20: FAIL: tests/du/bind-mount-dir-cycle.sh Message-ID: <20121101102756.0f6fe87f@warshall.local.loc> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: base64 X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi- I'm getting the same thing, with no chroot in the picture. That is, after mkdir -p a/b and mount --bind a a/b then the relevant line of /etc/mtab looks like [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] 1.7 MIME_BASE64_TEXT RAW: Message text disguised using base64 encoding X-Debbugs-Envelope-To: 12730 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi- I'm getting the same thing, with no chroot in the picture. That is, after mkdir -p a/b and mount --bind a a/b then the relevant line of /etc/mtab looks like [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4331] 1.7 MIME_BASE64_TEXT RAW: Message text disguised using base64 encoding LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMQ0KDQpIaS0NCg0K ICAgSSdtIGdldHRpbmcgdGhlIHNhbWUgdGhpbmcsIHdpdGggbm8gY2hyb290IGluIHRoZSBwaWN0 dXJlLiBUaGF0IGlzLA0KICAgYWZ0ZXIgbWtkaXIgLXAgYS9iIGFuZCBtb3VudCAtLWJpbmQgYSBh L2IgdGhlbiB0aGUgcmVsZXZhbnQgbGluZQ0KICAgb2YgL2V0Yy9tdGFiIGxvb2tzIGxpa2UNCg0K PHRlc3RpbmcgZGlyPi9hIDx0ZXN0aW5nIGRpcj4vYS9iIG5vbmUgcncsYmluZCAwIDANCg0KSXMg aGF2aW5nIC9ldGMvbXRhYiBhIHJlZ3VsYXIgZmlsZSByZWFsbHkgdGhhdCBhdHlwaWNhbD8gSWYg aXQgaGVscHMNCmFueSwgdGhlIG91dHB1dCBvZiAibW91bnQgLVYiIGlzDQoNCm1vdW50IGZyb20g dXRpbC1saW51eCAyLjE5ICh3aXRoIGxpYmJsa2lkIHN1cHBvcnQpDQoNCiAgICAgICAgLUFuZHJl dyBXYXJzaGFsbA0KLS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0NClZlcnNpb246IEdudVBH IHYxLjQuMTIgKEdOVS9MaW51eCkNCg0KaVFFY0JBRUJBZ0FHQlFKUWtvYnNBQW9KRUVTUFJXaDc5 VDd0L3NVSC8wamNEa3VBNmFBRVc5Z0UwSVZub3ZxMQ0KZ1YvYUtPQWdsU0wzTXR2ekl6RFl5RG9u bCtSZkRYYVFFNTN0VWJDNFcxVVM0cXcvR1JHYkEra3MyVWMzMDdRYw0KaXlxUytsNjZlazBLcnhV ZEdSWVdXMy8wb3AwVTduajBTamxrTWY2d1lBbStqMmhESE9mMnI1UHdiSElDcFowZw0KUmdKR2Uy SzNMaWVvWGRxbHRTUHFzY3VDa3Y5ODlMV3RBaVNsMFcxOXczLzZGckx6YTZ3ZFFsRXhSMjExTUt2 TQ0KRzlYQWVHamFlS3NFck5TN2M2RmVzTXhiWTBLNEtaREV0SEgvOXlOY3Q5UnJGTnJzR2FLRDQy TSs5VmR6bFRqTw0KajkvNlN3NkVnbjJXaEg1a3g0bXdXMXFLYmx3WTVGS2dMR1JVV1V6SVlGV2hx OEt5QUNIc1dWd3lOWkNmNDZjPQ0KPU9KRHQNCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQ0K From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 04 12:08:23 2012 Received: (at 12730) by debbugs.gnu.org; 4 Nov 2012 17:08:23 +0000 Received: from localhost ([127.0.0.1]:49205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TV3gN-0001J6-Fq for submit@debbugs.gnu.org; Sun, 04 Nov 2012 12:08:23 -0500 Received: from mail.99main.com ([208.28.184.11]:60444) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TV3gL-0001Iy-Jo for 12730@debbugs.gnu.org; Sun, 04 Nov 2012 12:08:22 -0500 Received: from warshall.local.loc (65.172.152.38.dsl.99main.com [65.172.152.38]) by mail.99main.com (8.12.8+Sun/8.12.8) with ESMTP id qA4H5KJs008148 for <12730@debbugs.gnu.org>; Sun, 4 Nov 2012 12:05:20 -0500 (EST) Date: Sun, 4 Nov 2012 11:08:53 -0500 From: Andrew Warshall To: 12730@debbugs.gnu.org Subject: bug #12730: patch attached Message-ID: <20121104110853.40736d58@warshall.local.loc> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/uHjlDp1V72X562aFXT+7xcX" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 12730 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.4 (/) --MP_/uHjlDp1V72X562aFXT+7xcX Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: base64 Content-Disposition: inline LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMQ0KDQo+IElmIHdl IHdlbnQgdGhhdCByb3V0ZSwgd2UnZCBjaGFuZ2UgaG93IG1lX2R1bW15IGlzIHNldCBzbyB0aGF0 IGl0DQo+IHRha2VzIGFjY291bnQgb2YgeW91ciBjYXNlLiAgRm9yIGV4YW1wbGUsIHdlIG1pZ2h0 IGFkZCBhIGJvb2xlYW4NCj4gImlzX2JpbmRfbW91bnQiIHBhcmFtZXRlciB0byBNRV9EVU1NWSBt YWNybywgc28gdGhhdCB3aGVuIG1lX3R5cGUgaXMNCj4gIm5vbmUiIGFuZCBpc19iaW5kX21vdW50 IGlzIHRydWUsIE1FX0RVTU1ZIHdvdWxkIGV2YWx1YXRlIHRvIGZhbHNlLA0KPiByYXRoZXIgdGhh biB0byB0cnVlLiAgVGhlIG9ubHkgdHJpY2t5IHBhcnQgd291bGQgYmUgcm9idXN0bHkNCj4gZGV0 ZXJtaW5pbmcgd2hldGhlciAiYmluZCIgaXMgaW4gbW50LT5tbnRfb3B0cy4NCj4gDQo+IENhcmUg dG8gd3JpdGUgdGhlIHBhdGNoPw0KDQpJJ3ZlIGF0dGFjaGVkIChhbiBhdHRlbXB0IGF0KSB0aGUg c3VnZ2VzdGVkIHBhdGNoLiBJdCBzaG91bGQgd29yayBvbg0KTGludXgvZ2xpYmMsIGJ1dCBzaG91 bGQgYmUgdGVzdGVkIG9uIG90aGVyIHBsYXRmb3Jtcy4NCg0KICAgICAgICAgICAtQW5kcmV3IFdh cnNoYWxsDQotLS0tLUJFR0lOIFBHUCBTSUdOQVRVUkUtLS0tLQ0KVmVyc2lvbjogR251UEcgdjEu NC4xMiAoR05VL0xpbnV4KQ0KDQppUUVjQkFFQkFnQUdCUUpRbHBNVkFBb0pFRVNQUldoNzlUN3RM VEVIL2pDQlhrMmliYTk4NnZvZUVKcWo0N0dtDQpabnVZWkcySms5bTR0K0FiTHppakxYQTNXNGcz Z2Z5VkF3UmorUWpUTnI2V1haTFpjYVozMGZicDZwWmg0V016DQowVk5lY2NSYytKNWlHdWIwTTlx WFdnUXVHLzVtRENaQnFUTmgzYlpWWlBLc0ZqdmFzalBZWVJ2VGQ2U1hTUUxhDQpvQVNGOE5uYUx3 Mko5NTRxMzArR2FpN3JmWFZCK2Q5SWhJTEl1dVU4N0pmTm5zeGREcExSck52Q29Dd2JTQzJrDQpu aE1jYVJWdWdBaC85TE8zaFBjbnhPbGYyU1Vod2hZQS90M2Y0U1hoKzVuSVcvd3hGTzBoN1FONFJh MTAvdnhYDQp5enJkY3JIZ3BOZnRNOUtjNmtrL3ZTdEpnbjk0bnQ0RG1ReS83dDVvMWZ2ZFVDRnhX RlRHVm5yVFJIY0pVdUk9DQo9WDQ2Rw0KLS0tLS1FTkQgUEdQIFNJR05BVFVSRS0tLS0tDQo= --MP_/uHjlDp1V72X562aFXT+7xcX Content-Type: application/octet-stream; name=coreutils-8.20-bind-mount.patch.gz Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=coreutils-8.20-bind-mount.patch.gz H4sICICQllAAA2NvcmV1dGlscy04LjIwLWJpbmQtbW91bnQucGF0Y2gApVTbattAEH22vmLqQLAi r26+pU4dTGo35MEOtA4lUBC2tEqWSrtGu2oSyMd3JNnGkXyp6TxIq5k5Zw4zswpYGAKZztMELCnS xKfS8kVCU8UiSS5N1yYiYU+WFbGFFYuUq4hJZfr7siuJGiHkNOqaazsucRxit8Gx+26v32mb9tqA 2B3b1gzD+GcJJcJ2q99xK4TDIRCnYze7YGQv5xKGQw3OUh7QEPxISBqwRAN0sTD3Tcbe6GEyedQM 9OSO+4fpbDzybsezCR6mMwdDgBHG6Sa78U16fB7TJuBBvS2LA+VKr/3SDEBrSJX48RIam4T6PFUi lHUdBgOwYctWEHh/3wXjgtMVqLZmz+38HD49z2XMlViqHIECELBgPKjrGyUZbZV1mQi/KuUgRKaL HfLXEOsCQpHAlKqbHyNomTZcWLDbDlb5TRNeLVOqcpewV+ianf01jlRhTxy3bVVFxwnTSFLciqOD 1ks14PRhw35ZW7P+AMnXulusdc9t9vKtPr0hByqXGgJnlAcszBqTv4sbk90Pz/v6ePvzbup5WbsY 96M0oPDlBZdOvEjz+ToX23Y+o0qj3fogFi2m5DqmXn6v8SrCAF5RTJCiGFxkjHHloV+/qkAyoTvT 87HszvfieRQJnwYIdK40UkoJ0jh+w9B62ki6CtA/xdS3uLCE8T94/MD/Q1VnQmOhaMHyfTy5n42P ySgzYBrC8emFiYiL3nr4T2CCy60+oUdmaO0vNr+wpS4GAAA= --MP_/uHjlDp1V72X562aFXT+7xcX-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 04 20:05:01 2012 Received: (at 12730) by debbugs.gnu.org; 5 Nov 2012 01:05:01 +0000 Received: from localhost ([127.0.0.1]:49433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVB7c-0005K7-Ng for submit@debbugs.gnu.org; Sun, 04 Nov 2012 20:05:01 -0500 Received: from mx.meyering.net ([88.168.87.75]:45202) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVB7Z-0005Jy-KH for 12730@debbugs.gnu.org; Sun, 04 Nov 2012 20:04:59 -0500 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id AA7EF60385; Mon, 5 Nov 2012 02:01:53 +0100 (CET) From: Jim Meyering To: Andrew Warshall Subject: Re: bug#12730: bug #12730: patch attached In-Reply-To: <20121104110853.40736d58@warshall.local.loc> (Andrew Warshall's message of "Sun, 4 Nov 2012 11:08:53 -0500") References: <1483616685.329281056.1351154592247.JavaMail.root@zimbra33-e6.priv.proxad.net> <20121104110853.40736d58@warshall.local.loc> Date: Mon, 05 Nov 2012 02:01:53 +0100 Message-ID: <871ug8amm6.fsf@rho.meyering.net> Lines: 109 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.4 (/) Andrew Warshall wrote: >> If we went that route, we'd change how me_dummy is set so that it >> takes account of your case. For example, we might add a boolean >> "is_bind_mount" parameter to ME_DUMMY macro, so that when me_type is >> "none" and is_bind_mount is true, ME_DUMMY would evaluate to false, >> rather than to true. The only tricky part would be robustly >> determining whether "bind" is in mnt->mnt_opts. >> >> Care to write the patch? > > I've attached (an attempt at) the suggested patch. It should work on > Linux/glibc, but should be tested on other platforms. Thanks for the patch. However, I'd rather not duplicate all of that logic solely to change the part that deals with type-"none" entries. Instead, I'll leave the other 5 types in a separate, new macro, and use that from the new ME_DUMMY macro. I've also removed the outer "#ifndef ME_DUMMY" and added a comment and a ChangeLog entry for you. But now, you have to proofread that and ACK before I push it. I've tested only on a system with MOUNTED_GETMNTENT1. Finally, it's small enough that you don't have to fill out copyright paperwork (hence the "tiny change" and Copyright-paperwork-exempt notes), but if you think you may contribute something else, please start the process now, so the lack of an assignment does not delay things. Let me know off-list and I'll send you the forms. >From 613bcb6205cf2b64d835c19074c5a7e7c6cb99eb Mon Sep 17 00:00:00 2001 From: Andrew Warshall Date: Sun, 4 Nov 2012 16:41:15 -0800 Subject: [PATCH] mountlist: do not classify a bind-mounted dir entry as "dummy" * lib/mountlist.c (ME_DUMMY_0): Rename from ME_DUMMY, but omit the "none"-testing clause. (ME_DUMMY) [MOUNTED_GETMNTENT1]: New macro to encapsulate the exception for bind-mounted directories. Copyright-paperwork-exempt: Yes --- ChangeLog | 8 ++++++++ lib/mountlist.c | 31 +++++++++++++++++++++---------- 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 720b7a2..2173fb2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2012-11-04 Andrew Warshall (tiny change) + + mountlist: do not classify a bind-mounted dir entry as "dummy" + * lib/mountlist.c (ME_DUMMY_0): Rename from ME_DUMMY, but omit + the "none"-testing clause. + (ME_DUMMY) [MOUNTED_GETMNTENT1]: New macro to encapsulate the + exception for bind-mounted directories. + 2012-11-01 Akim Demaille quote: provide a means to escape strings with nul characters diff --git a/lib/mountlist.c b/lib/mountlist.c index 67154b8..a9a9f2c 100644 --- a/lib/mountlist.c +++ b/lib/mountlist.c @@ -149,16 +149,27 @@ #undef opendir #undef closedir -#ifndef ME_DUMMY -# define ME_DUMMY(Fs_name, Fs_type) \ - (strcmp (Fs_type, "autofs") == 0 \ - || strcmp (Fs_type, "none") == 0 \ - || strcmp (Fs_type, "proc") == 0 \ - || strcmp (Fs_type, "subfs") == 0 \ - /* for NetBSD 3.0 */ \ - || strcmp (Fs_type, "kernfs") == 0 \ - /* for Irix 6.5 */ \ - || strcmp (Fs_type, "ignore") == 0) +#define ME_DUMMY_0(Fs_name, Fs_type) \ + (strcmp (Fs_type, "autofs") == 0 \ + || strcmp (Fs_type, "proc") == 0 \ + || strcmp (Fs_type, "subfs") == 0 \ + /* for NetBSD 3.0 */ \ + || strcmp (Fs_type, "kernfs") == 0 \ + /* for Irix 6.5 */ \ + || strcmp (Fs_type, "ignore") == 0) + +/* Historically, we have marked as "dummy" any file system of type "none", + but now that programs like du need to know about bind-mounted directories, + we grant an exception to any with "bind" in its list of mount options. + I.e., those are *not* dummy entries. */ +#ifdef MOUNTED_GETMNTENT1 +# define ME_DUMMY(Fs_name, Fs_type, Fs_ent) \ + (ME_DUMMY_0 (Fs_name, Fs_type) \ + || (strcmp (Fs_type, "none") == 0 \ + && !hasmntopt (Fs_ent, "bind"))) +#else +# define ME_DUMMY(Fs_name, Fs_type) \ + (ME_DUMMY_0 (Fs_name, Fs_type) || strcmp (Fs_type, "none") == 0) #endif #ifdef __CYGWIN__ -- 1.8.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 04 20:28:18 2012 Received: (at 12730) by debbugs.gnu.org; 5 Nov 2012 01:28:18 +0000 Received: from localhost ([127.0.0.1]:49438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVBU9-0005p8-RR for submit@debbugs.gnu.org; Sun, 04 Nov 2012 20:28:18 -0500 Received: from mail.99main.com ([208.28.184.11]:44257) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVBU5-0005ox-28 for 12730@debbugs.gnu.org; Sun, 04 Nov 2012 20:28:15 -0500 Received: from warshall.local.loc (65.172.152.38.dsl.99main.com [65.172.152.38]) by mail.99main.com (8.12.8+Sun/8.12.8) with ESMTP id qA51P9Js011040; Sun, 4 Nov 2012 20:25:09 -0500 (EST) Date: Sun, 4 Nov 2012 19:28:41 -0500 From: Andrew Warshall To: Jim Meyering Subject: bug #12730: patch attached Message-ID: <20121104192841.17ccdc64@warshall.local.loc> In-Reply-To: <871ug8amm6.fsf@rho.meyering.net> References: <1483616685.329281056.1351154592247.JavaMail.root@zimbra33-e6.priv.proxad.net> <20121104110853.40736d58@warshall.local.loc> <871ug8amm6.fsf@rho.meyering.net> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: base64 X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Mon, 05 Nov 2012 02:01:53 +0100 Jim Meyering wrote: > Thanks for the patch. > However, I'd rather not duplicate all of that logic solely > to change the part that deals with type-"none" entries. > Instead, I'll leave the other 5 types in a separate, new macro, > and use that from the new ME_DUMMY macro. > > I've also removed the outer "#ifndef ME_DUMMY" and added > a comment and a ChangeLog entry for you. But now, > you have to proofread that and ACK before I push it. > > I've tested only on a system with MOUNTED_GETMNTENT1. > > Finally, it's small enough that you don't have to fill > out copyright paperwork (hence the "tiny change" > and Copyright-paperwork-exempt notes), but if you think > you may contribute something else, please start the process now, > so the lack of an assignment does not delay things. > Let me know off-list and I'll send you the forms. > > > From 613bcb6205cf2b64d835c19074c5a7e7c6cb99eb Mon Sep 17 00:00:00 2001 > From: Andrew Warshall > Date: Sun, 4 Nov 2012 16:41:15 -0800 > Subject: [PATCH] mountlist: do not classify a bind-mounted dir entry > as "dummy" > > * lib/mountlist.c (ME_DUMMY_0): Rename from ME_DUMMY, but omit > the "none"-testing clause. > (ME_DUMMY) [MOUNTED_GETMNTENT1]: New macro to encapsulate the > exception for bind-mounted directories. > Copyright-paperwork-exempt: Yes > --- > ChangeLog | 8 ++++++++ > lib/mountlist.c | 31 +++++++++++++++++++++ > 2 files changed, 29 insertions(+), 10 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 720b7a2..2173fb2 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1, 3 +1, 11 @@ > +2012-11-04 Andrew Warshall (tiny change) > + > + mountlist: do not classify a bind-mounted dir entry as > "dummy" > + * lib/mountlist.c (ME_DUMMY_0): Rename from ME_DUMMY, but > omit > + the "none"-testing clause. > + (ME_DUMMY) [MOUNTED_GETMNTENT1]: New macro to encapsulate the > + exception for bind-mounted directories. > + > 2012-11-01 Akim Demaille > > [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] 1.7 MIME_BASE64_TEXT RAW: Message text disguised using base64 encoding X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMQ0KDQpPbiBNb24s IDA1IE5vdiAyMDEyIDAyOjAxOjUzICswMTAwDQpKaW0gTWV5ZXJpbmcgPGppbUBtZXllcmluZy5u ZXQ+IHdyb3RlOg0KPiBUaGFua3MgZm9yIHRoZSBwYXRjaC4NCj4gSG93ZXZlciwgSSdkIHJhdGhl ciBub3QgZHVwbGljYXRlIGFsbCBvZiB0aGF0IGxvZ2ljIHNvbGVseQ0KPiB0byBjaGFuZ2UgdGhl IHBhcnQgdGhhdCBkZWFscyB3aXRoIHR5cGUtIm5vbmUiIGVudHJpZXMuDQo+IEluc3RlYWQsIEkn bGwgbGVhdmUgdGhlIG90aGVyIDUgdHlwZXMgaW4gYSBzZXBhcmF0ZSwgbmV3IG1hY3JvLA0KPiBh bmQgdXNlIHRoYXQgZnJvbSB0aGUgbmV3IE1FX0RVTU1ZIG1hY3JvLg0KPiANCj4gSSd2ZSBhbHNv IHJlbW92ZWQgdGhlIG91dGVyICIjaWZuZGVmIE1FX0RVTU1ZIiBhbmQgYWRkZWQNCj4gYSBjb21t ZW50IGFuZCBhIENoYW5nZUxvZyBlbnRyeSBmb3IgeW91LiAgQnV0IG5vdywNCj4geW91IGhhdmUg dG8gcHJvb2ZyZWFkIHRoYXQgYW5kIEFDSyBiZWZvcmUgSSBwdXNoIGl0Lg0KPiANCj4gSSd2ZSB0 ZXN0ZWQgb25seSBvbiBhIHN5c3RlbSB3aXRoIE1PVU5URURfR0VUTU5URU5UMS4NCj4gDQo+IEZp bmFsbHksIGl0J3Mgc21hbGwgZW5vdWdoIHRoYXQgeW91IGRvbid0IGhhdmUgdG8gZmlsbA0KPiBv dXQgY29weXJpZ2h0IHBhcGVyd29yayAoaGVuY2UgdGhlICJ0aW55IGNoYW5nZSINCj4gYW5kIENv cHlyaWdodC1wYXBlcndvcmstZXhlbXB0IG5vdGVzKSwgYnV0IGlmIHlvdSB0aGluaw0KPiB5b3Ug bWF5IGNvbnRyaWJ1dGUgc29tZXRoaW5nIGVsc2UsIHBsZWFzZSBzdGFydCB0aGUgcHJvY2VzcyBu b3csDQo+IHNvIHRoZSBsYWNrIG9mIGFuIGFzc2lnbm1lbnQgZG9lcyBub3QgZGVsYXkgdGhpbmdz Lg0KPiBMZXQgbWUga25vdyBvZmYtbGlzdCBhbmQgSSdsbCBzZW5kIHlvdSB0aGUgZm9ybXMuDQo+ IA0KPiANCj4gRnJvbSA2MTNiY2I2MjA1Y2YyYjY0ZDgzNWMxOTA3NGM1YTdlN2M2Y2I5OWViIE1v biBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KPiBGcm9tOiBBbmRyZXcgV2Fyc2hhbGwgPHdhcnNoYWxs QDk5bWFpbi5jb20+DQo+IERhdGU6IFN1biwgNCBOb3YgMjAxMiAxNjo0MToxNSAtMDgwMA0KPiBT dWJqZWN0OiBbUEFUQ0hdIG1vdW50bGlzdDogZG8gbm90IGNsYXNzaWZ5IGEgYmluZC1tb3VudGVk IGRpciBlbnRyeQ0KPiBhcyAiZHVtbXkiDQo+IA0KPiAqIGxpYi9tb3VudGxpc3QuYyAoTUVfRFVN TVlfMCk6IFJlbmFtZSBmcm9tIE1FX0RVTU1ZLCBidXQgb21pdA0KPiB0aGUgIm5vbmUiLXRlc3Rp bmcgY2xhdXNlLg0KPiAoTUVfRFVNTVkpIFtNT1VOVEVEX0dFVE1OVEVOVDFdOiBOZXcgbWFjcm8g dG8gZW5jYXBzdWxhdGUgdGhlDQo+IGV4Y2VwdGlvbiBmb3IgYmluZC1tb3VudGVkIGRpcmVjdG9y aWVzLg0KPiBDb3B5cmlnaHQtcGFwZXJ3b3JrLWV4ZW1wdDogWWVzDQo+IC0tLQ0KPiAgQ2hhbmdl TG9nICAgICAgIHwgIDggKysrKysrKysNCj4gIGxpYi9tb3VudGxpc3QuYyB8IDMxICsrKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0NCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9u cygrKSwgMTAgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nDQo+IGluZGV4IDcyMGI3YTIuLjIxNzNmYjIgMTAwNjQ0DQo+IC0tLSBhL0NoYW5nZUxv Zw0KPiArKysgYi9DaGFuZ2VMb2cNCj4gQEAgLTEsMyArMSwxMSBAQA0KPiArMjAxMi0xMS0wNCAg QW5kcmV3IFdhcnNoYWxsICA8d2Fyc2hhbGxAOTltYWluLmNvbT4gICh0aW55IGNoYW5nZSkNCj4g Kw0KPiArCW1vdW50bGlzdDogZG8gbm90IGNsYXNzaWZ5IGEgYmluZC1tb3VudGVkIGRpciBlbnRy eSBhcw0KPiAiZHVtbXkiDQo+ICsJKiBsaWIvbW91bnRsaXN0LmMgKE1FX0RVTU1ZXzApOiBSZW5h bWUgZnJvbSBNRV9EVU1NWSwgYnV0DQo+IG9taXQNCj4gKwl0aGUgIm5vbmUiLXRlc3RpbmcgY2xh dXNlLg0KPiArCShNRV9EVU1NWSkgW01PVU5URURfR0VUTU5URU5UMV06IE5ldyBtYWNybyB0byBl bmNhcHN1bGF0ZSB0aGUNCj4gKwlleGNlcHRpb24gZm9yIGJpbmQtbW91bnRlZCBkaXJlY3Rvcmll cy4NCj4gKw0KPiAgMjAxMi0xMS0wMSAgQWtpbSBEZW1haWxsZSAgPGFraW1AbHJkZS5lcGl0YS5m cj4NCj4gDQo+ICAJcXVvdGU6IHByb3ZpZGUgYSBtZWFucyB0byBlc2NhcGUgc3RyaW5ncyB3aXRo IG51bCBjaGFyYWN0ZXJzDQo+IGRpZmYgLS1naXQgYS9saWIvbW91bnRsaXN0LmMgYi9saWIvbW91 bnRsaXN0LmMNCj4gaW5kZXggNjcxNTRiOC4uYTlhOWYyYyAxMDA2NDQNCj4gLS0tIGEvbGliL21v dW50bGlzdC5jDQo+ICsrKyBiL2xpYi9tb3VudGxpc3QuYw0KPiBAQCAtMTQ5LDE2ICsxNDksMjcg QEANCj4gICN1bmRlZiBvcGVuZGlyDQo+ICAjdW5kZWYgY2xvc2VkaXINCj4gDQo+IC0jaWZuZGVm IE1FX0RVTU1ZDQo+IC0jIGRlZmluZSBNRV9EVU1NWShGc19uYW1lLCBGc190eXBlKSAgICAgICAg ICAgICBcDQo+IC0gICAgKHN0cmNtcCAoRnNfdHlwZSwgImF1dG9mcyIpID09IDAgICAgICAgICAg ICBcDQo+IC0gICAgIHx8IHN0cmNtcCAoRnNfdHlwZSwgIm5vbmUiKSA9PSAwICAgICAgICAgICBc DQo+IC0gICAgIHx8IHN0cmNtcCAoRnNfdHlwZSwgInByb2MiKSA9PSAwICAgICAgICAgICBcDQo+ IC0gICAgIHx8IHN0cmNtcCAoRnNfdHlwZSwgInN1YmZzIikgPT0gMCAgICAgICAgICBcDQo+IC0g ICAgIC8qIGZvciBOZXRCU0QgMy4wICovICAgICAgICAgICAgICAgICAgICAgICBcDQo+IC0gICAg IHx8IHN0cmNtcCAoRnNfdHlwZSwgImtlcm5mcyIpID09IDAgICAgICAgICBcDQo+IC0gICAgIC8q IGZvciBJcml4IDYuNSAqLyAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+IC0gICAgIHx8IHN0 cmNtcCAoRnNfdHlwZSwgImlnbm9yZSIpID09IDApDQo+ICsjZGVmaW5lIE1FX0RVTU1ZXzAoRnNf bmFtZSwgRnNfdHlwZSkgICAgICAgICAgICBcDQo+ICsgIChzdHJjbXAgKEZzX3R5cGUsICJhdXRv ZnMiKSA9PSAwICAgICAgICAgICAgICBcDQo+ICsgICB8fCBzdHJjbXAgKEZzX3R5cGUsICJwcm9j IikgPT0gMCAgICAgICAgICAgICBcDQo+ICsgICB8fCBzdHJjbXAgKEZzX3R5cGUsICJzdWJmcyIp ID09IDAgICAgICAgICAgICBcDQo+ICsgICAvKiBmb3IgTmV0QlNEIDMuMCAqLyAgICAgICAgICAg ICAgICAgICAgICAgICBcDQo+ICsgICB8fCBzdHJjbXAgKEZzX3R5cGUsICJrZXJuZnMiKSA9PSAw ICAgICAgICAgICBcDQo+ICsgICAvKiBmb3IgSXJpeCA2LjUgKi8gICAgICAgICAgICAgICAgICAg ICAgICAgICBcDQo+ICsgICB8fCBzdHJjbXAgKEZzX3R5cGUsICJpZ25vcmUiKSA9PSAwKQ0KPiAr DQo+ICsvKiBIaXN0b3JpY2FsbHksIHdlIGhhdmUgbWFya2VkIGFzICJkdW1teSIgYW55IGZpbGUg c3lzdGVtIG9mIHR5cGUNCj4gIm5vbmUiLA0KPiArICAgYnV0IG5vdyB0aGF0IHByb2dyYW1zIGxp a2UgZHUgbmVlZCB0byBrbm93IGFib3V0IGJpbmQtbW91bnRlZA0KPiBkaXJlY3RvcmllcywNCj4g KyAgIHdlIGdyYW50IGFuIGV4Y2VwdGlvbiB0byBhbnkgd2l0aCAiYmluZCIgaW4gaXRzIGxpc3Qg b2YgbW91bnQNCj4gb3B0aW9ucy4NCj4gKyAgIEkuZS4sIHRob3NlIGFyZSAqbm90KiBkdW1teSBl bnRyaWVzLiAgKi8NCj4gKyNpZmRlZiBNT1VOVEVEX0dFVE1OVEVOVDENCj4gKyMgZGVmaW5lIE1F X0RVTU1ZKEZzX25hbWUsIEZzX3R5cGUsIEZzX2VudCkJXA0KPiArICAoTUVfRFVNTVlfMCAoRnNf bmFtZSwgRnNfdHlwZSkJCVwNCj4gKyAgIHx8IChzdHJjbXAgKEZzX3R5cGUsICJub25lIikgPT0g MAkJXA0KPiArICAgICAgICYmICFoYXNtbnRvcHQgKEZzX2VudCwgImJpbmQiKSkpDQo+ICsjZWxz ZQ0KPiArIyBkZWZpbmUgTUVfRFVNTVkoRnNfbmFtZSwgRnNfdHlwZSkJCVwNCj4gKyAgKE1FX0RV TU1ZXzAgKEZzX25hbWUsIEZzX3R5cGUpIHx8IHN0cmNtcCAoRnNfdHlwZSwgIm5vbmUiKSA9PSAw KQ0KPiAgI2VuZGlmDQo+IA0KPiAgI2lmZGVmIF9fQ1lHV0lOX18NCj4gLS0NCj4gMS44LjANCj4g DQoNClRoaXMgbG9va3MgZmluZS4gSXQgc2hvdWxkIChJIGhvcGUpIGhhdmUgbm8gZWZmZWN0IG9u IGEgc3lzdGVtIHcvbw0KTU9VTlRFRF9HRVRNTlRFTlQxOyBJIHdhcyBtb3JlIGNvbmNlcm5lZCBh Ym91dCB0aGUgZWZmZWN0IG9uIGFueW9uZQ0Kd2l0aCBNT1VOVEVEX0dFVE1OVEVOVDEgYnV0IHdp dGhvdXQgaGFzbW50b3B0IChpLmUuIGEgbm9uLWdsaWJjDQplbnZpcm9ubWVudCB3aXRoIHRoZSBz YW1lIGdldG1udGVudCBzZW1hbnRpY3MpLg0KDQogICAgICAgICAgICAgICAgICAgICAgLUFuZHJl dyBXYXJzaGFsbA0KLS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0NClZlcnNpb246IEdudVBH IHYxLjQuMTIgKEdOVS9MaW51eCkNCg0KaVFFY0JBRUJBZ0FHQlFKUWx3ZzVBQW9KRUVTUFJXaDc5 VDd0NGVzSC8zUzFwQUNqQVNQSk9RNjU2ZHFaUUg2Lw0KeXZpTjEvS3dTUmlzc2V5S0tYMVhqWGdE eVhub3BVVERrZDVpclJxUEZaWXhqYWo1eGFnbGRwNGMzZjBXaGhGWQ0KS2oyTXM1QzFoOW00TnJU b2RnQ1VXOEV0ZmlDa0JmZGdqMzcyaHRKSE1lcE4wY1FNTDVXT0wrNUw5NFZHTGtXeA0KN0VaamlY VlpCWXBPU2pxQkE4VE5Yb2dNQlJ1cmZFdU9CcDRuV3dGZ1lSZ2ZXUTFlSVFTK3R6YkNqZ2lnTHE5 YQ0KL0t6dTZpMng4NmV4NUJ4Y3I0MjFKMEx5cDg2VDRDVjdKNWkzaTJOY2p2QWdVSW1ETGZMSlJy YlFGRHNOaFluRQ0KVHc5a09jVFh0ODRBSUlRU1FKdkI2UEJaVDh1VFBlTThsSW10RG14SXc5R0pO WXloZDZ6a1BRTEc2RVdKckpVPQ0KPUtWRVANCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQ0K From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 05 00:12:23 2012 Received: (at 12730) by debbugs.gnu.org; 5 Nov 2012 05:12:23 +0000 Received: from localhost ([127.0.0.1]:49567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVEz0-00046K-9r for submit@debbugs.gnu.org; Mon, 05 Nov 2012 00:12:22 -0500 Received: from mx.meyering.net ([88.168.87.75]:45470) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVEyx-00046B-IP for 12730@debbugs.gnu.org; Mon, 05 Nov 2012 00:12:20 -0500 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id A3C846009D; Mon, 5 Nov 2012 06:09:14 +0100 (CET) From: Jim Meyering To: Andrew Warshall Subject: Re: bug #12730: patch attached In-Reply-To: <20121104192841.17ccdc64@warshall.local.loc> (Andrew Warshall's message of "Sun, 4 Nov 2012 19:28:41 -0500") References: <1483616685.329281056.1351154592247.JavaMail.root@zimbra33-e6.priv.proxad.net> <20121104110853.40736d58@warshall.local.loc> <871ug8amm6.fsf@rho.meyering.net> <20121104192841.17ccdc64@warshall.local.loc> Date: Mon, 05 Nov 2012 06:09:14 +0100 Message-ID: <87k3u08wlh.fsf@rho.meyering.net> Lines: 14 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.4 (/) Andrew Warshall wrote: ... > This looks fine. I've pushed it to gnulib, so this bug will be fixed in coreutils the next time it syncs from gnulib. > It should (I hope) have no effect on a system w/o > MOUNTED_GETMNTENT1; I was more concerned about the effect on anyone > with MOUNTED_GETMNTENT1 but without hasmntopt (i.e. a non-glibc > environment with the same getmntent semantics). If someone discovers/reports that problem, we can easily write a replacement hasmntopt function. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 08 02:05:35 2012 Received: (at 12730) by debbugs.gnu.org; 8 Nov 2012 07:05:35 +0000 Received: from localhost ([127.0.0.1]:55268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TWMBB-0002tI-OX for submit@debbugs.gnu.org; Thu, 08 Nov 2012 02:05:35 -0500 Received: from mx.meyering.net ([88.168.87.75]:50185) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TWMB9-0002tB-Mq for 12730@debbugs.gnu.org; Thu, 08 Nov 2012 02:05:32 -0500 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id EE138600AE; Thu, 8 Nov 2012 08:05:30 +0100 (CET) From: Jim Meyering To: Andrew Warshall Subject: Re: bug#12730: bug #12730: patch attached In-Reply-To: <871ug8amm6.fsf@rho.meyering.net> (Jim Meyering's message of "Mon, 05 Nov 2012 02:01:53 +0100") References: <1483616685.329281056.1351154592247.JavaMail.root@zimbra33-e6.priv.proxad.net> <20121104110853.40736d58@warshall.local.loc> <871ug8amm6.fsf@rho.meyering.net> Date: Thu, 08 Nov 2012 08:05:30 +0100 Message-ID: <87wqxw1sn9.fsf@rho.meyering.net> Lines: 58 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.4 (/) Jim Meyering wrote: > Date: Sun, 4 Nov 2012 16:41:15 -0800 > Subject: [PATCH] mountlist: do not classify a bind-mounted dir entry as > "dummy" > > * lib/mountlist.c (ME_DUMMY_0): Rename from ME_DUMMY, but omit > the "none"-testing clause. > (ME_DUMMY) [MOUNTED_GETMNTENT1]: New macro to encapsulate the > exception for bind-mounted directories. > Copyright-paperwork-exempt: Yes Hmm.... trying the latest from gnulib, I saw a compilation failure. And it was my fault for omitting a hunk of your patch when I adjusted it. Sorry about that. Here's the fix. >From ab7a2b67b48deb4c253b3b6bd983690d71515265 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 7 Nov 2012 22:59:21 -0800 Subject: [PATCH] mountlist.c: fix a compilation failure * lib/mountlist.c (read_file_system_list): Fix a compilation failure I introduced while transforming commit v0.0-7683-g613bcb6 --- ChangeLog | 6 ++++++ lib/mountlist.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index adcb8d1..1a1e8b7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2012-11-07 Jim Meyering + + mountlist.c: fix a compilation failure + * lib/mountlist.c (read_file_system_list): Fix a compilation failure + I introduced while transforming commit v0.0-7683-g613bcb6 + 2012-11-05 Paul Eggert errno: port to LynxOS 178 2.2.2 diff --git a/lib/mountlist.c b/lib/mountlist.c index a9a9f2c..d0fe1b2 100644 --- a/lib/mountlist.c +++ b/lib/mountlist.c @@ -430,7 +430,7 @@ read_file_system_list (bool need_fs_type) me->me_mountdir = xstrdup (mnt->mnt_dir); me->me_type = xstrdup (mnt->mnt_type); me->me_type_malloced = 1; - me->me_dummy = ME_DUMMY (me->me_devname, me->me_type); + me->me_dummy = ME_DUMMY (me->me_devname, me->me_type, mnt); me->me_remote = ME_REMOTE (me->me_devname, me->me_type); me->me_dev = dev_from_mount_options (mnt->mnt_opts); -- 1.8.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 08 08:40:37 2012 Received: (at 12730) by debbugs.gnu.org; 8 Nov 2012 13:40:38 +0000 Received: from localhost ([127.0.0.1]:55590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TWSLU-0004KI-LJ for submit@debbugs.gnu.org; Thu, 08 Nov 2012 08:40:37 -0500 Received: from mail.99main.com ([208.28.184.11]:45449) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TWSLK-0004Jp-M4 for 12730@debbugs.gnu.org; Thu, 08 Nov 2012 08:40:28 -0500 Received: from warshall.local.loc (65.172.152.38.dsl.99main.com [65.172.152.38]) by mail.99main.com (8.12.8+Sun/8.12.8) with ESMTP id qA8DeNqO024495; Thu, 8 Nov 2012 08:40:23 -0500 (EST) Date: Thu, 8 Nov 2012 07:44:51 -0500 From: Andrew Warshall To: Jim Meyering Subject: Re: bug#12730: bug #12730: patch attached Message-ID: <20121108074451.3bd51c9e@warshall.local.loc> In-Reply-To: <87wqxw1sn9.fsf@rho.meyering.net> References: <1483616685.329281056.1351154592247.JavaMail.root@zimbra33-e6.priv.proxad.net> <20121104110853.40736d58@warshall.local.loc> <871ug8amm6.fsf@rho.meyering.net> <87wqxw1sn9.fsf@rho.meyering.net> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: base64 X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, 08 Nov 2012 08:05:30 +0100 Jim Meyering wrote: > > Hmm.... trying the latest from gnulib, I saw a compilation failure. > And it was my fault for omitting a hunk of your patch when > I adjusted it. Sorry about that. > > Here's the fix. > > From ab7a2b67b48deb4c253b3b6bd983690d71515265 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Wed, 7 Nov 2012 22:59:21 -0800 > Subject: [PATCH] mountlist.c: fix a compilation failure > > * lib/mountlist.c (read_file_system_list): Fix a compilation failure > I introduced while transforming commit v0.0-7683-g613bcb6 > --- > ChangeLog | 6 ++++++ > lib/mountlist.c | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/ChangeLog b/ChangeLog > index adcb8d1..1a1e8b7 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1, 3 +1, 9 @@ > +2012-11-07 Jim Meyering > + > + mountlist.c: fix a compilation failure > + * lib/mountlist.c (read_file_system_list): Fix a compilation > failure > + I introduced while transforming commit v0.0-7683-g613bcb6 > + > 2012-11-05 Paul Eggert > > errno: port to LynxOS 178 2.2.2 > diff --git a/lib/mountlist.c b/lib/mountlist.c > index a9a9f2c..d0fe1b2 100644 > --- a/lib/mountlist.c > +++ b/lib/mountlist.c > @@ -430, 7 +430, 7 @@ read_file_system_list (bool need_fs_type) > me->me_mountdir = xstrdup (mnt->mnt_dir); > me->me_type = xstrdup (mnt->mnt_type); > me->me_type_malloced = 1; > - me->me_dummy = ME_DUMMY (me->me_devname, me->me_type); > + me->me_dummy = ME_DUMMY (me->me_devname, me->me_type, mnt); > me->me_remote = ME_REMOTE (me->me_devname, me->me_type); > me->me_dev = dev_from_mount_options (mnt->mnt_opts); > > -- > 1.8.0 > [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 BAYES_40 BODY: Bayes spam probability is 20 to 40% [score: 0.2545] 1.7 MIME_BASE64_TEXT RAW: Message text disguised using base64 encoding X-Debbugs-Envelope-To: 12730 Cc: 12730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMQ0KDQpPbiBUaHUs IDA4IE5vdiAyMDEyIDA4OjA1OjMwICswMTAwDQpKaW0gTWV5ZXJpbmcgPGppbUBtZXllcmluZy5u ZXQ+IHdyb3RlOg0KDQo+IA0KPiBIbW0uLi4uIHRyeWluZyB0aGUgbGF0ZXN0IGZyb20gZ251bGli LCBJIHNhdyBhIGNvbXBpbGF0aW9uIGZhaWx1cmUuDQo+IEFuZCBpdCB3YXMgbXkgZmF1bHQgZm9y IG9taXR0aW5nIGEgaHVuayBvZiB5b3VyIHBhdGNoIHdoZW4NCj4gSSBhZGp1c3RlZCBpdC4gIFNv cnJ5IGFib3V0IHRoYXQuDQo+IA0KPiBIZXJlJ3MgdGhlIGZpeC4NCj4gDQo+IEZyb20gYWI3YTJi NjdiNDhkZWI0YzI1M2IzYjZiZDk4MzY5MGQ3MTUxNTI2NSBNb24gU2VwIDE3IDAwOjAwOjAwIDIw MDENCj4gRnJvbTogSmltIE1leWVyaW5nIDxqaW1AbWV5ZXJpbmcubmV0Pg0KPiBEYXRlOiBXZWQs IDcgTm92IDIwMTIgMjI6NTk6MjEgLTA4MDANCj4gU3ViamVjdDogW1BBVENIXSBtb3VudGxpc3Qu YzogZml4IGEgY29tcGlsYXRpb24gZmFpbHVyZQ0KPiANCj4gKiBsaWIvbW91bnRsaXN0LmMgKHJl YWRfZmlsZV9zeXN0ZW1fbGlzdCk6IEZpeCBhIGNvbXBpbGF0aW9uIGZhaWx1cmUNCj4gSSBpbnRy b2R1Y2VkIHdoaWxlIHRyYW5zZm9ybWluZyBjb21taXQgdjAuMC03NjgzLWc2MTNiY2I2DQo+IC0t LQ0KPiAgQ2hhbmdlTG9nICAgICAgIHwgNiArKysrKysNCj4gIGxpYi9tb3VudGxpc3QuYyB8IDIg Ky0NCj4gIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+ IA0KPiBkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nDQo+IGluZGV4IGFkY2I4ZDEu LjFhMWU4YjcgMTAwNjQ0DQo+IC0tLSBhL0NoYW5nZUxvZw0KPiArKysgYi9DaGFuZ2VMb2cNCj4g QEAgLTEsMyArMSw5IEBADQo+ICsyMDEyLTExLTA3ICBKaW0gTWV5ZXJpbmcgIDxqaW1AbWV5ZXJp bmcubmV0Pg0KPiArDQo+ICsJbW91bnRsaXN0LmM6IGZpeCBhIGNvbXBpbGF0aW9uIGZhaWx1cmUN Cj4gKwkqIGxpYi9tb3VudGxpc3QuYyAocmVhZF9maWxlX3N5c3RlbV9saXN0KTogRml4IGEgY29t cGlsYXRpb24NCj4gZmFpbHVyZQ0KPiArCUkgaW50cm9kdWNlZCB3aGlsZSB0cmFuc2Zvcm1pbmcg Y29tbWl0IHYwLjAtNzY4My1nNjEzYmNiNg0KPiArDQo+ICAyMDEyLTExLTA1ICBQYXVsIEVnZ2Vy dCAgPGVnZ2VydEBjcy51Y2xhLmVkdT4NCj4gDQo+ICAJZXJybm86IHBvcnQgdG8gTHlueE9TIDE3 OCAyLjIuMg0KPiBkaWZmIC0tZ2l0IGEvbGliL21vdW50bGlzdC5jIGIvbGliL21vdW50bGlzdC5j DQo+IGluZGV4IGE5YTlmMmMuLmQwZmUxYjIgMTAwNjQ0DQo+IC0tLSBhL2xpYi9tb3VudGxpc3Qu Yw0KPiArKysgYi9saWIvbW91bnRsaXN0LmMNCj4gQEAgLTQzMCw3ICs0MzAsNyBAQCByZWFkX2Zp bGVfc3lzdGVtX2xpc3QgKGJvb2wgbmVlZF9mc190eXBlKQ0KPiAgICAgICAgICBtZS0+bWVfbW91 bnRkaXIgPSB4c3RyZHVwIChtbnQtPm1udF9kaXIpOw0KPiAgICAgICAgICBtZS0+bWVfdHlwZSA9 IHhzdHJkdXAgKG1udC0+bW50X3R5cGUpOw0KPiAgICAgICAgICBtZS0+bWVfdHlwZV9tYWxsb2Nl ZCA9IDE7DQo+IC0gICAgICAgIG1lLT5tZV9kdW1teSA9IE1FX0RVTU1ZIChtZS0+bWVfZGV2bmFt ZSwgbWUtPm1lX3R5cGUpOw0KPiArICAgICAgICBtZS0+bWVfZHVtbXkgPSBNRV9EVU1NWSAobWUt Pm1lX2Rldm5hbWUsIG1lLT5tZV90eXBlLCBtbnQpOw0KPiAgICAgICAgICBtZS0+bWVfcmVtb3Rl ID0gTUVfUkVNT1RFIChtZS0+bWVfZGV2bmFtZSwgbWUtPm1lX3R5cGUpOw0KPiAgICAgICAgICBt ZS0+bWVfZGV2ID0gZGV2X2Zyb21fbW91bnRfb3B0aW9ucyAobW50LT5tbnRfb3B0cyk7DQo+IA0K PiAtLQ0KPiAxLjguMA0KPiANCg0KSSdtIHNvcnJ5IEkgZGlkbid0IGNhdGNoIGl0IGJlZm9yZTsg dGhhbmtzIGZvciBmaXhpbmcgaXQsIGluIGFueSBldmVudC4NCg0KICAgICAgICAgIC1BbmRyZXcg V2Fyc2hhbGwNCi0tLS0tQkVHSU4gUEdQIFNJR05BVFVSRS0tLS0tDQpWZXJzaW9uOiBHbnVQRyB2 MS40LjEyIChHTlUvTGludXgpDQoNCmlRRWNCQUVCQWdBR0JRSlFtNmxEQUFvSkVFU1BSV2g3OVQ3 dHdXa0gvM0dzVlRQdDVzdG1FNHBXTnB4Sjl2WWINCnVmakk0VG51VFpVRlBuTTR4eUZlWmt1bFNz S0tqK0w1L0d0UnlhVUU2TzJxU2s1MFpHV3g0M2p0TDhQREhmTVUNCnR1MXNDVDJtKzRZSDFKSXFz NmhtUU1DU1pwb3F0WGFQdklzSDFuTFMybVFBT0xXTzFLRDdEdnFOSXJaaXFyQXANClVJaVJjUGM5 YmpEbjBId0tMampUMldqT2hFcExmOHFOL0tUNmdQYmR0bmt4bDU0VkxQc1BLekEzdm0zV05XSjcN CnhUbldWMzc4MXZ1VHJzbkNKLzVIYi94R0s0Z1FiM0pLOWRKbHpDblFITnplcFF5T1QxVWJ4WTdF SC9HYVNrUWsNCmRTelhDbS92Ykh6V0NkSjJTWGM3TU9WejluTldxa2h1SDhieTY1MHhhanpCVEZy NFNzci9GODRsdS9CWjVXZz0NCj01WUEvDQotLS0tLUVORCBQR1AgU0lHTkFUVVJFLS0tLS0NCg== From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 15 13:48:00 2018 Received: (at control) by debbugs.gnu.org; 15 Oct 2018 17:48:00 +0000 Received: from localhost ([127.0.0.1]:51245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gC6yG-0003JR-JO for submit@debbugs.gnu.org; Mon, 15 Oct 2018 13:48:00 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:44965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gC6yD-0003EX-NH for control@debbugs.gnu.org; Mon, 15 Oct 2018 13:47:57 -0400 Received: by mail-io1-f44.google.com with SMTP id s6-v6so4225587ioa.11 for ; Mon, 15 Oct 2018 10:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:message-id:date:user-agent:mime-version:content-language :content-transfer-encoding; bh=fF8f+yS85HB19e+FyudZBiD3vnXGSjJAAxGgi73OEJE=; b=fufs29euW/K0NtlK7ndDS76+flfpf6mMqC0vLKhgJ+dbG2Wdg+AcJvt/dhA0ryCG0t gKWOB9Uc74G25tvoR11YOXIlTs6tlwwU0Fe1EIYLbqSN7btpSGPoTQUQbta89fFiwCZq clC0yObHxUvvu2RMGMUzxx6smEI3wro+YiHnNQAN4Kg5Yi5yaWw3WR7ZV0BV+rPOuSRN Oj6iiyncG8eMjqElzIm6PdCDUD2mouSXLR4pgKD+G49Wyl9FoNgNKTzQZQlkjw6wFcVp GMivnr34RvaABcSV8xn10Fx+PCRZ3bejEJH1Pla42kC8EFA/ijknJlJZI6gL+4Zm12s9 5fKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=fF8f+yS85HB19e+FyudZBiD3vnXGSjJAAxGgi73OEJE=; b=mi+0RsNhZdygJhNKqbj4GDUeWm3eV2PXAsPWP4kTw6rp9nuKuoMhgRwRYfk1D8+ymJ eeLdInTuwS5J6PLCVPFW/mdnCTtOtdVBoWe4MeUOg5A/stqu/kw7gK4AdVSJO1wntCCb 1ms8HhkdHYCBKXIpQAYTqkLwJ+yZj+b6rjAgNFdv0Fomvh8BDT3RWgQCa/XqEKt8A/jO aH8ZuRCt23HpJcxqpFTKTr8HvORLR8m0QS4Azvvd0FatlJJCcFDTY8aJV03ISfT635bJ HuQRmeHI7yKnZcyMea1jlsEAS0yEBjPTI9JIlm3wtsUxtxJGrGlC8/LXK9rtU30X0bjC X/lg== X-Gm-Message-State: ABuFfog5TBhWHoxubtjeN/hxw3yho5TuUZ87evRiaVIVE1R+nGAtPtQv mz6ShXMXUo2gl3jfHofsT02V03jR+Mc= X-Google-Smtp-Source: ACcGV60//hq0hgxDGhxDPkfOVQ7QBECAm871k53nfwWyC5WhDrFpl35xso5/+DHQL2M0OZgifv3yeQ== X-Received: by 2002:a6b:8f44:: with SMTP id r65-v6mr12234360iod.59.1539625671583; Mon, 15 Oct 2018 10:47:51 -0700 (PDT) Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38]) by smtp.googlemail.com with ESMTPSA id d6-v6sm3923053ite.39.2018.10.15.10.47.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Oct 2018 10:47:50 -0700 (PDT) To: control@debbugs.gnu.org From: Assaf Gordon Message-ID: Date: Mon, 15 Oct 2018 11:47:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 12730 fixed close 12730 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (assafgordon[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.166.44 listed in list.dnswl.org] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 12730 fixed close 12730 From unknown Mon Jun 23 04:15:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 13 Nov 2018 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator