Subject: Re: bug#12728: v8.20 is missing LIBICONV for factor tool

From: Jim Meyering <[email-masked]>
Date: Sun, 04 Nov 2012 05:18:19 +0100

Pádraig Brady wrote:
> On 10/25/2012 05:36 PM, Jim Meyering wrote:
>> Pádraig Brady wrote:
>>
>>> On 10/25/2012 11:21 AM, Jim Meyering wrote:
>>>> Thanks for dealing with that.
>>>> Along with the fix, please add a syntax-check rule that does something
>>>> like this:
>>>>
>>>>     cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do
>>>>       grep -E "^src_${i}_LDADD .?= .*\$(LIBICONV)" local.mk > /dev/null \
>>>>         || echo FAIL $i
>>>>     done
>>>>
>>>> Before the fix, it would print this:
>>>>
>>>>     FAIL factor
>>>
>>> Pushed with this:
>>>
>>> # Ensure programs with authors with non ASCII names link with LIBICONV
>>> sc_check-I18N-AUTHORS:
>>>         @(cd $(srcdir)/src &&                           \
>>>           for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
>>>             grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
>>>               /dev/null || { echo FAIL $$i; exit 1; };            \
>>>           done)
>>
>> Thanks!
>> I wanted to include a little more information in the diagnostic, so...
...
>> +	      || { "echo $(ME): link rules for $$i do not include"	\
>> +		    '$$(LIBICONV)' 1>&2; exit 1; };			\
...
> The quoting was a bit off there, so I just pushed this.

"off", as in just plain wrong ;)
Thanks for cleaning up after me.

...
> Author: Pádraig Brady <[email-masked]>
> Date:   Sun Nov 4 00:55:57 2012 +0000
>
>     maint: fix the error message from sc_check-I18N-AUTHORS
>
>     * cfk.mk (sc_check-I18N-AUTHORS): Fix the quoting so
>     you don't get a 'command not found' error.
>
> diff --git a/cfg.mk b/cfg.mk
> index 46652b0..53295b4 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -187,7 +187,7 @@ sc_check-I18N-AUTHORS:
>           for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
>             grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
>                 > /dev/null                                             \
> -             || { "echo $(ME): link rules for $$i do not include"      \
> +             || { echo "$(ME): link rules for $$i do not include"      \
>                     '$$(LIBICONV)' 1>&2; exit 1; };                     \
>           done