From unknown Sun Jun 22 17:14:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12728: v8.20 is missing LIBICONV for factor tool Resent-From: "Christian Jullien" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 25 Oct 2012 04:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12728 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 12728@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.135114080120958 (code B ref -1); Thu, 25 Oct 2012 04:54:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Oct 2012 04:53:21 +0000 Received: from localhost ([127.0.0.1]:60474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRFRY-0005Rz-AG for submit@debbugs.gnu.org; Thu, 25 Oct 2012 00:53:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43079) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRF86-0004xf-C6 for submit@debbugs.gnu.org; Thu, 25 Oct 2012 00:33:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRF62-0007QB-SS for submit@debbugs.gnu.org; Thu, 25 Oct 2012 00:31:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:34398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRF62-0007Q7-PN for submit@debbugs.gnu.org; Thu, 25 Oct 2012 00:31:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRF61-0007U8-CX for bug-coreutils@gnu.org; Thu, 25 Oct 2012 00:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRF60-0007Pv-As for bug-coreutils@gnu.org; Thu, 25 Oct 2012 00:31:05 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:60777 helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRF60-0007Pe-1S for bug-coreutils@gnu.org; Thu, 25 Oct 2012 00:31:04 -0400 Received: from young ([217.128.172.94]) by mwinf5d38 with ME id FGX11k00922ZY4h03GX1Zw; Thu, 25 Oct 2012 06:31:01 +0200 From: "Christian Jullien" Date: Thu, 25 Oct 2012 06:30:57 +0200 Message-ID: <003601cdb269$87c09d70$9741d850$@orange.fr> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0037_01CDB27A.4B4BDE70" X-Mailer: Microsoft Outlook 14.0 Thread-Index: Ac2yaYdjU7MkH4cbQUqxzqclcguuyA== Content-Language: fr X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Mailman-Approved-At: Thu, 25 Oct 2012 00:53:19 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) This is a multipart message in MIME format. ------=_NextPart_000_0037_01CDB27A.4B4BDE70 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi maintainers, Trying to compile new 8.20 version on my Solaris 10 sparc machine using gcc 4.7.2, I got an error on factor link: CCLD src/factor lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv': /export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined reference to `libiconv' /export/home/jullien/coreutils-8.20/lib/striconv.c:72: undefined reference to `libiconv' I easily fixed this issue adding $(LIBICONV) on Makefile.in (Line 3117): < src_factor_LDADD = $(LDADD) $(LIB_GMP) > src_factor_LDADD = $(LDADD) $(LIB_GMP) $(LIBICONV) This is the only issue I had. Thanks to include this fix for the next release. Christian ------=_NextPart_000_0037_01CDB27A.4B4BDE70 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi = maintainers,

 

Trying to compile new 8.20 version on my Solaris 10 = sparc machine using gcc 4.7.2, I got an error on factor = link:

 

CCLD   src/factor

lib/libcoreutils.a(striconv.o): In function = `mem_cd_iconv':

/export/home/jullien/coreutils-8.20/lib/striconv.c:55: = undefined reference to `libiconv'

/export/home/jullien/coreutils-8.20/lib/striconv.c:72: = undefined reference to `libiconv'

 

I easily = fixed this issue adding $(LIBICONV) on Makefile.in (Line = 3117):

 

< src_factor_LDADD =3D $(LDADD) = $(LIB_GMP)

> src_factor_LDADD =3D = $(LDADD) $(LIB_GMP) $(LIBICONV)

 

This is the = only issue I had.

 

Thanks to = include this fix for the next release.

 

Christian

------=_NextPart_000_0037_01CDB27A.4B4BDE70-- From unknown Sun Jun 22 17:14:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Christian Jullien" Subject: bug#12728: closed (Re: bug#12728: v8.20 is missing LIBICONV for factor tool) Message-ID: References: <50890C59.9040308@draigBrady.com> <003601cdb269$87c09d70$9741d850$@orange.fr> X-Gnu-PR-Message: they-closed 12728 X-Gnu-PR-Package: coreutils Reply-To: 12728@debbugs.gnu.org Date: Thu, 25 Oct 2012 09:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1351159022-25545-1" This is a multi-part message in MIME format... ------------=_1351159022-25545-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #12728: v8.20 is missing LIBICONV for factor tool which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 12728@debbugs.gnu.org. --=20 12728: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12728 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1351159022-25545-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 12728-done) by debbugs.gnu.org; 25 Oct 2012 09:56:48 +0000 Received: from localhost ([127.0.0.1]:60713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRKBE-0006dd-16 for submit@debbugs.gnu.org; Thu, 25 Oct 2012 05:56:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54049) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRKBB-0006dQ-Ep for 12728-done@debbugs.gnu.org; Thu, 25 Oct 2012 05:56:46 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9P9savF009996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 25 Oct 2012 05:54:36 -0400 Received: from [10.36.116.83] (ovpn-116-83.ams2.redhat.com [10.36.116.83]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9P9sX6s022563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 25 Oct 2012 05:54:35 -0400 Message-ID: <50890C59.9040308@draigBrady.com> Date: Thu, 25 Oct 2012 10:54:33 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Christian Jullien Subject: Re: bug#12728: v8.20 is missing LIBICONV for factor tool References: <003601cdb269$87c09d70$9741d850$@orange.fr> In-Reply-To: <003601cdb269$87c09d70$9741d850$@orange.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q9P9savF009996 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 12728-done Cc: 12728-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 10/25/2012 05:30 AM, Christian Jullien wrote: > Hi maintainers, > > Trying to compile new 8.20 version on my Solaris 10 sparc machine using= gcc > 4.7.2, I got an error on factor link: > > CCLD src/factor > > lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv': > > /export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined refere= nce > to `libiconv' Right you are. This is required in the new factor because of: proper_name_utf8 ("Torbjorn Granlund", "Torbj\303\266rn Granlund"), = \ proper_name_utf8 ("Niels Moller", "Niels M\303\266ller") I didn't pick up the issue on my gcc 3.4.3, solaris 10, sparc test system because of: $ grep ICONV lib/config.h /* #undef HAVE_ICONV */ #define HAVE_ICONV_H 1 #define ICONV_CONST const #define ICONV_FLAVOR ICONV_FLAVOR_SOLARIS To fix this up I'll add in: diff --git a/src/local.mk b/src/local.mk index 6a01ef1..f40f681 100644 --- a/src/local.mk +++ b/src/local.mk @@ -277,6 +277,7 @@ src_cat_LDADD +=3D $(LIBICONV) src_cp_LDADD +=3D $(LIBICONV) src_df_LDADD +=3D $(LIBICONV) src_du_LDADD +=3D $(LIBICONV) +src_factor_LDADD +=3D $(LIBICONV) src_getlimits_LDADD +=3D $(LIBICONV) src_printf_LDADD +=3D $(LIBICONV) src_ptx_LDADD +=3D $(LIBICONV) thanks! P=E1draig. ------------=_1351159022-25545-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Oct 2012 04:53:21 +0000 Received: from localhost ([127.0.0.1]:60474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRFRY-0005Rz-AG for submit@debbugs.gnu.org; Thu, 25 Oct 2012 00:53:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43079) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRF86-0004xf-C6 for submit@debbugs.gnu.org; Thu, 25 Oct 2012 00:33:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRF62-0007QB-SS for submit@debbugs.gnu.org; Thu, 25 Oct 2012 00:31:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:34398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRF62-0007Q7-PN for submit@debbugs.gnu.org; Thu, 25 Oct 2012 00:31:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRF61-0007U8-CX for bug-coreutils@gnu.org; Thu, 25 Oct 2012 00:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRF60-0007Pv-As for bug-coreutils@gnu.org; Thu, 25 Oct 2012 00:31:05 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:60777 helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRF60-0007Pe-1S for bug-coreutils@gnu.org; Thu, 25 Oct 2012 00:31:04 -0400 Received: from young ([217.128.172.94]) by mwinf5d38 with ME id FGX11k00922ZY4h03GX1Zw; Thu, 25 Oct 2012 06:31:01 +0200 From: "Christian Jullien" To: Subject: v8.20 is missing LIBICONV for factor tool Date: Thu, 25 Oct 2012 06:30:57 +0200 Message-ID: <003601cdb269$87c09d70$9741d850$@orange.fr> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0037_01CDB27A.4B4BDE70" X-Mailer: Microsoft Outlook 14.0 Thread-Index: Ac2yaYdjU7MkH4cbQUqxzqclcguuyA== Content-Language: fr X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 25 Oct 2012 00:53:19 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) This is a multipart message in MIME format. ------=_NextPart_000_0037_01CDB27A.4B4BDE70 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi maintainers, Trying to compile new 8.20 version on my Solaris 10 sparc machine using gcc 4.7.2, I got an error on factor link: CCLD src/factor lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv': /export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined reference to `libiconv' /export/home/jullien/coreutils-8.20/lib/striconv.c:72: undefined reference to `libiconv' I easily fixed this issue adding $(LIBICONV) on Makefile.in (Line 3117): < src_factor_LDADD = $(LDADD) $(LIB_GMP) > src_factor_LDADD = $(LDADD) $(LIB_GMP) $(LIBICONV) This is the only issue I had. Thanks to include this fix for the next release. Christian ------=_NextPart_000_0037_01CDB27A.4B4BDE70 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi = maintainers,

 

Trying to compile new 8.20 version on my Solaris 10 = sparc machine using gcc 4.7.2, I got an error on factor = link:

 

CCLD   src/factor

lib/libcoreutils.a(striconv.o): In function = `mem_cd_iconv':

/export/home/jullien/coreutils-8.20/lib/striconv.c:55: = undefined reference to `libiconv'

/export/home/jullien/coreutils-8.20/lib/striconv.c:72: = undefined reference to `libiconv'

 

I easily = fixed this issue adding $(LIBICONV) on Makefile.in (Line = 3117):

 

< src_factor_LDADD =3D $(LDADD) = $(LIB_GMP)

> src_factor_LDADD =3D = $(LDADD) $(LIB_GMP) $(LIBICONV)

 

This is the = only issue I had.

 

Thanks to = include this fix for the next release.

 

Christian

------=_NextPart_000_0037_01CDB27A.4B4BDE70-- ------------=_1351159022-25545-1-- From unknown Sun Jun 22 17:14:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12728: v8.20 is missing LIBICONV for factor tool Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 25 Oct 2012 10:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12728 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 12728@debbugs.gnu.org Cc: P@draigBrady.com Received: via spool by 12728-submit@debbugs.gnu.org id=B12728.135116061927881 (code B ref 12728); Thu, 25 Oct 2012 10:24:01 +0000 Received: (at 12728) by debbugs.gnu.org; 25 Oct 2012 10:23:39 +0000 Received: from localhost ([127.0.0.1]:60731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRKbD-0007Fe-F7 for submit@debbugs.gnu.org; Thu, 25 Oct 2012 06:23:39 -0400 Received: from mx.meyering.net ([88.168.87.75]:41654) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRKbA-0007FS-0u for 12728@debbugs.gnu.org; Thu, 25 Oct 2012 06:23:37 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 98205600FE; Thu, 25 Oct 2012 12:21:31 +0200 (CEST) From: Jim Meyering In-Reply-To: <50890C59.9040308@draigBrady.com> ("=?UTF-8?Q?P=C3=A1draig?= Brady"'s message of "Thu, 25 Oct 2012 10:54:33 +0100") References: <003601cdb269$87c09d70$9741d850$@orange.fr> <50890C59.9040308@draigBrady.com> Date: Thu, 25 Oct 2012 12:21:31 +0200 Message-ID: <878vauj1hw.fsf@rho.meyering.net> Lines: 57 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) P=E1draig Brady wrote: > On 10/25/2012 05:30 AM, Christian Jullien wrote: >> Hi maintainers, >> >> Trying to compile new 8.20 version on my Solaris 10 sparc machine using = gcc >> 4.7.2, I got an error on factor link: >> >> CCLD src/factor >> >> lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv': >> >> /export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined referen= ce >> to `libiconv' > > Right you are. > This is required in the new factor because of: > > proper_name_utf8 ("Torbjorn Granlund", "Torbj\303\266rn Granlund"), \ > proper_name_utf8 ("Niels Moller", "Niels M\303\266ller") > > I didn't pick up the issue on my gcc 3.4.3, solaris 10, sparc > test system because of: > > $ grep ICONV lib/config.h > /* #undef HAVE_ICONV */ > #define HAVE_ICONV_H 1 > #define ICONV_CONST const > #define ICONV_FLAVOR ICONV_FLAVOR_SOLARIS > > To fix this up I'll add in: > > diff --git a/src/local.mk b/src/local.mk > index 6a01ef1..f40f681 100644 > --- a/src/local.mk > +++ b/src/local.mk > @@ -277,6 +277,7 @@ src_cat_LDADD +=3D $(LIBICONV) > src_cp_LDADD +=3D $(LIBICONV) > src_df_LDADD +=3D $(LIBICONV) > src_du_LDADD +=3D $(LIBICONV) > +src_factor_LDADD +=3D $(LIBICONV) > src_getlimits_LDADD +=3D $(LIBICONV) > src_printf_LDADD +=3D $(LIBICONV) > src_ptx_LDADD +=3D $(LIBICONV) Thanks for dealing with that. Along with the fix, please add a syntax-check rule that does something like this: cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do grep -E "^src_${i}_LDADD .?=3D .*\$(LIBICONV)" local.mk > /dev/null \ || echo FAIL $i done Before the fix, it would print this: FAIL factor From unknown Sun Jun 22 17:14:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12728: v8.20 is missing LIBICONV for factor tool Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 25 Oct 2012 12:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12728 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Jim Meyering Cc: 12728@debbugs.gnu.org Received: via spool by 12728-submit@debbugs.gnu.org id=B12728.13511664088652 (code B ref 12728); Thu, 25 Oct 2012 12:01:02 +0000 Received: (at 12728) by debbugs.gnu.org; 25 Oct 2012 12:00:08 +0000 Received: from localhost ([127.0.0.1]:60800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRM6a-0002FV-GG for submit@debbugs.gnu.org; Thu, 25 Oct 2012 08:00:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48555) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRM6Y-0002FK-MC for 12728@debbugs.gnu.org; Thu, 25 Oct 2012 08:00:07 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9PBw1ah022422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 25 Oct 2012 07:58:02 -0400 Received: from [10.36.116.83] (ovpn-116-83.ams2.redhat.com [10.36.116.83]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9PBvxjM014301 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 25 Oct 2012 07:58:00 -0400 Message-ID: <50892947.7040906@draigBrady.com> Date: Thu, 25 Oct 2012 12:57:59 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <003601cdb269$87c09d70$9741d850$@orange.fr> <50890C59.9040308@draigBrady.com> <878vauj1hw.fsf@rho.meyering.net> In-Reply-To: <878vauj1hw.fsf@rho.meyering.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q9PBw1ah022422 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 10/25/2012 11:21 AM, Jim Meyering wrote: > Thanks for dealing with that. > Along with the fix, please add a syntax-check rule that does something > like this: > > cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'= ); do > grep -E "^src_${i}_LDADD .?=3D .*\$(LIBICONV)" local.mk > /dev/nul= l \ > || echo FAIL $i > done > > Before the fix, it would print this: > > FAIL factor Pushed with this: # Ensure programs with authors with non ASCII names link with LIBICONV sc_check-I18N-AUTHORS: @(cd $(srcdir)/src && \ for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//');= do \ grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.mk= > \ /dev/null || { echo FAIL $$i; exit 1; }; \ done) thanks, P=E1draig. From unknown Sun Jun 22 17:14:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12728: v8.20 is missing LIBICONV for factor tool Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 25 Oct 2012 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12728 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12728@debbugs.gnu.org Received: via spool by 12728-submit@debbugs.gnu.org id=B12728.13511831114853 (code B ref 12728); Thu, 25 Oct 2012 16:39:02 +0000 Received: (at 12728) by debbugs.gnu.org; 25 Oct 2012 16:38:31 +0000 Received: from localhost ([127.0.0.1]:33491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRQRz-0001GE-8W for submit@debbugs.gnu.org; Thu, 25 Oct 2012 12:38:31 -0400 Received: from mx.meyering.net ([88.168.87.75]:42522) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRQRx-0001G6-OO for 12728@debbugs.gnu.org; Thu, 25 Oct 2012 12:38:30 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 1DA8F600FE; Thu, 25 Oct 2012 18:36:25 +0200 (CEST) From: Jim Meyering In-Reply-To: <50892947.7040906@draigBrady.com> ("=?UTF-8?Q?P=C3=A1draig?= Brady"'s message of "Thu, 25 Oct 2012 12:57:59 +0100") References: <003601cdb269$87c09d70$9741d850$@orange.fr> <50890C59.9040308@draigBrady.com> <878vauj1hw.fsf@rho.meyering.net> <50892947.7040906@draigBrady.com> Date: Thu, 25 Oct 2012 18:36:25 +0200 Message-ID: <874nlifr06.fsf@rho.meyering.net> Lines: 67 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) P=E1draig Brady wrote: > On 10/25/2012 11:21 AM, Jim Meyering wrote: >> Thanks for dealing with that. >> Along with the fix, please add a syntax-check rule that does something >> like this: >> >> cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//')= ; do >> grep -E "^src_${i}_LDADD .?=3D .*\$(LIBICONV)" local.mk > /dev/null= \ >> || echo FAIL $i >> done >> >> Before the fix, it would print this: >> >> FAIL factor > > Pushed with this: > > # Ensure programs with authors with non ASCII names link with LIBICONV > sc_check-I18N-AUTHORS: > @(cd $(srcdir)/src && \ > for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); = do \ > grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.mk = > \ > /dev/null || { echo FAIL $$i; exit 1; }; \ > done) Thanks! I wanted to include a little more information in the diagnostic, so... >From 74da4c80470bffe3ccfaead598dad36bf64f1b97 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 25 Oct 2012 18:35:34 +0200 Subject: [PATCH] maint: tweak sc_check-I18N-AUTHORS * cfg.mk (sc_check-I18N-AUTHORS): Remove unnecessary subshell; add a self-explanatory diagnostic. --- cfg.mk | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/cfg.mk b/cfg.mk index 40ece55..08f6c3d 100644 --- a/cfg.mk +++ b/cfg.mk @@ -181,13 +181,15 @@ sc_check-AUTHORS: $(all_programs) && diff $(au_actual) $(au_dotdot) \ && rm -f $(au_actual) $(au_dotdot) -# Ensure programs with authors with non ASCII names link with LIBICONV +# Each program with a non-ASCII author name must link with LIBICONV. sc_check-I18N-AUTHORS: - @(cd $(srcdir)/src && \ + @cd $(srcdir)/src && \ for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \ - grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.mk > \ - /dev/null || { echo FAIL $$i; exit 1; }; \ - done) + grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.mk \ + > /dev/null \ + || { "echo $(ME): link rules for $$i do not include" \ + '$$(LIBICONV)' 1>&2; exit 1; }; \ + done # Look for lines longer than 80 characters, except omit: # - program-generated long lines in diff headers, -- 1.8.0 From unknown Sun Jun 22 17:14:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12728: v8.20 is missing LIBICONV for factor tool Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 25 Oct 2012 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12728 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Jim Meyering Cc: 12728@debbugs.gnu.org Received: via spool by 12728-submit@debbugs.gnu.org id=B12728.135118780515148 (code B ref 12728); Thu, 25 Oct 2012 17:57:02 +0000 Received: (at 12728) by debbugs.gnu.org; 25 Oct 2012 17:56:45 +0000 Received: from localhost ([127.0.0.1]:33606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRRfg-0003wH-3c for submit@debbugs.gnu.org; Thu, 25 Oct 2012 13:56:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7995) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRRfd-0003w8-Cu for 12728@debbugs.gnu.org; Thu, 25 Oct 2012 13:56:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9PHsZjJ030249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 25 Oct 2012 13:54:35 -0400 Received: from [10.36.116.39] (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9PHsX0l022547 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 25 Oct 2012 13:54:35 -0400 Message-ID: <50897CD9.2060902@draigBrady.com> Date: Thu, 25 Oct 2012 18:54:33 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <003601cdb269$87c09d70$9741d850$@orange.fr> <50890C59.9040308@draigBrady.com> <878vauj1hw.fsf@rho.meyering.net> <50892947.7040906@draigBrady.com> <874nlifr06.fsf@rho.meyering.net> In-Reply-To: <874nlifr06.fsf@rho.meyering.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 10/25/2012 05:36 PM, Jim Meyering wrote: > Thanks! > I wanted to include a little more information in the diagnostic, so... looks good. thanks From unknown Sun Jun 22 17:14:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12728: v8.20 is missing LIBICONV for factor tool Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 25 Oct 2012 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12728 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12728@debbugs.gnu.org Received: via spool by 12728-submit@debbugs.gnu.org id=B12728.135119359423622 (code B ref 12728); Thu, 25 Oct 2012 19:34:02 +0000 Received: (at 12728) by debbugs.gnu.org; 25 Oct 2012 19:33:14 +0000 Received: from localhost ([127.0.0.1]:33680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRTB3-00068x-V8 for submit@debbugs.gnu.org; Thu, 25 Oct 2012 15:33:14 -0400 Received: from mx.meyering.net ([88.168.87.75]:36257) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRTB2-00068p-5Z for 12728@debbugs.gnu.org; Thu, 25 Oct 2012 15:33:13 -0400 Received: from rho (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 857C7603D9; Thu, 25 Oct 2012 21:31:05 +0200 (CEST) From: Jim Meyering In-Reply-To: <50897CD9.2060902@draigBrady.com> ("=?UTF-8?Q?P=C3=A1draig?= Brady"'s message of "Thu, 25 Oct 2012 18:54:33 +0100") References: <003601cdb269$87c09d70$9741d850$@orange.fr> <50890C59.9040308@draigBrady.com> <878vauj1hw.fsf@rho.meyering.net> <50892947.7040906@draigBrady.com> <874nlifr06.fsf@rho.meyering.net> <50897CD9.2060902@draigBrady.com> Date: Thu, 25 Oct 2012 21:31:05 +0200 Message-ID: <87fw525oxy.fsf@meyering.net> Lines: 8 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) P=E1draig Brady wrote: > On 10/25/2012 05:36 PM, Jim Meyering wrote: >> Thanks! >> I wanted to include a little more information in the diagnostic, so... > > looks good. thanks Thanks for the review. Pushed. From unknown Sun Jun 22 17:14:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12728: v8.20 is missing LIBICONV for factor tool Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 01:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12728 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Jim Meyering Cc: 12728@debbugs.gnu.org Received: via spool by 12728-submit@debbugs.gnu.org id=B12728.13519909498638 (code B ref 12728); Sun, 04 Nov 2012 01:03:01 +0000 Received: (at 12728) by debbugs.gnu.org; 4 Nov 2012 01:02:29 +0000 Received: from localhost ([127.0.0.1]:47794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUobc-0002FH-HR for submit@debbugs.gnu.org; Sat, 03 Nov 2012 21:02:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56844) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUobZ-0002F8-FE for 12728@debbugs.gnu.org; Sat, 03 Nov 2012 21:02:26 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA40xRWO003759 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Nov 2012 20:59:27 -0400 Received: from [10.36.116.18] (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qA40xPo3032408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 3 Nov 2012 20:59:26 -0400 Message-ID: <5095BDED.3000308@draigBrady.com> Date: Sun, 04 Nov 2012 00:59:25 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 References: <003601cdb269$87c09d70$9741d850$@orange.fr> <50890C59.9040308@draigBrady.com> <878vauj1hw.fsf@rho.meyering.net> <50892947.7040906@draigBrady.com> <874nlifr06.fsf@rho.meyering.net> In-Reply-To: <874nlifr06.fsf@rho.meyering.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id qA40xRWO003759 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) On 10/25/2012 05:36 PM, Jim Meyering wrote: > P=E1draig Brady wrote: > >> On 10/25/2012 11:21 AM, Jim Meyering wrote: >>> Thanks for dealing with that. >>> Along with the fix, please add a syntax-check rule that does somethin= g >>> like this: >>> >>> cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c= //'); do >>> grep -E "^src_${i}_LDADD .?=3D .*\$(LIBICONV)" local.mk > /dev/= null \ >>> || echo FAIL $i >>> done >>> >>> Before the fix, it would print this: >>> >>> FAIL factor >> >> Pushed with this: >> >> # Ensure programs with authors with non ASCII names link with LIBICONV >> sc_check-I18N-AUTHORS: >> @(cd $(srcdir)/src && \ >> for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//= '); do \ >> grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local= .mk > \ >> /dev/null || { echo FAIL $$i; exit 1; }; \ >> done) > > Thanks! > I wanted to include a little more information in the diagnostic, so... > >>>From 74da4c80470bffe3ccfaead598dad36bf64f1b97 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 25 Oct 2012 18:35:34 +0200 > Subject: [PATCH] maint: tweak sc_check-I18N-AUTHORS > > * cfg.mk (sc_check-I18N-AUTHORS): Remove unnecessary subshell; > add a self-explanatory diagnostic. > --- > cfg.mk | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/cfg.mk b/cfg.mk > index 40ece55..08f6c3d 100644 > --- a/cfg.mk > +++ b/cfg.mk > @@ -181,13 +181,15 @@ sc_check-AUTHORS: $(all_programs) > && diff $(au_actual) $(au_dotdot) \ > && rm -f $(au_actual) $(au_dotdot) > > -# Ensure programs with authors with non ASCII names link with LIBICONV > +# Each program with a non-ASCII author name must link with LIBICONV. > sc_check-I18N-AUTHORS: > - @(cd $(srcdir)/src && \ > + @cd $(srcdir)/src && \ > for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do= \ > - grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.mk > \ > - /dev/null || { echo FAIL $$i; exit 1; }; \ > - done) > + grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.mk \ > + > /dev/null \ > + || { "echo $(ME): link rules for $$i do not include" \ > + '$$(LIBICONV)' 1>&2; exit 1; }; \ > + done > > # Look for lines longer than 80 characters, except omit: > # - program-generated long lines in diff headers, The quoting was a bit off there, so I just pushed this. cheers, P=E1draig. commit 8096ec664173f243e045be065203e6ad1aa1fa75 Author: P=E1draig Brady Date: Sun Nov 4 00:55:57 2012 +0000 maint: fix the error message from sc_check-I18N-AUTHORS * cfk.mk (sc_check-I18N-AUTHORS): Fix the quoting so you don't get a 'command not found' error. diff --git a/cfg.mk b/cfg.mk index 46652b0..53295b4 100644 --- a/cfg.mk +++ b/cfg.mk @@ -187,7 +187,7 @@ sc_check-I18N-AUTHORS: for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//')= ; do \ grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.m= k \ > /dev/null = \ - || { "echo $(ME): link rules for $$i do not include" \ + || { echo "$(ME): link rules for $$i do not include" \ '$$(LIBICONV)' 1>&2; exit 1; }; = \ done From unknown Sun Jun 22 17:14:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12728: v8.20 is missing LIBICONV for factor tool Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 04 Nov 2012 04:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12728 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 12728@debbugs.gnu.org Received: via spool by 12728-submit@debbugs.gnu.org id=B12728.135200288032303 (code B ref 12728); Sun, 04 Nov 2012 04:22:02 +0000 Received: (at 12728) by debbugs.gnu.org; 4 Nov 2012 04:21:20 +0000 Received: from localhost ([127.0.0.1]:47915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUri4-0008Oy-I6 for submit@debbugs.gnu.org; Sun, 04 Nov 2012 00:21:20 -0400 Received: from mx.meyering.net ([88.168.87.75]:43996) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUri2-0008Oq-1d for 12728@debbugs.gnu.org; Sun, 04 Nov 2012 00:21:19 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 0C85460103; Sun, 4 Nov 2012 05:18:19 +0100 (CET) From: Jim Meyering In-Reply-To: <5095BDED.3000308@draigBrady.com> ("=?UTF-8?Q?P=C3=A1draig?= Brady"'s message of "Sun, 04 Nov 2012 00:59:25 +0000") References: <003601cdb269$87c09d70$9741d850$@orange.fr> <50890C59.9040308@draigBrady.com> <878vauj1hw.fsf@rho.meyering.net> <50892947.7040906@draigBrady.com> <874nlifr06.fsf@rho.meyering.net> <5095BDED.3000308@draigBrady.com> Date: Sun, 04 Nov 2012 05:18:19 +0100 Message-ID: <878vait304.fsf@rho.meyering.net> Lines: 60 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.2 (/) P=E1draig Brady wrote: > On 10/25/2012 05:36 PM, Jim Meyering wrote: >> P=E1draig Brady wrote: >> >>> On 10/25/2012 11:21 AM, Jim Meyering wrote: >>>> Thanks for dealing with that. >>>> Along with the fix, please add a syntax-check rule that does something >>>> like this: >>>> >>>> cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c/= /'); do >>>> grep -E "^src_${i}_LDADD .?=3D .*\$(LIBICONV)" local.mk > /dev/n= ull \ >>>> || echo FAIL $i >>>> done >>>> >>>> Before the fix, it would print this: >>>> >>>> FAIL factor >>> >>> Pushed with this: >>> >>> # Ensure programs with authors with non ASCII names link with LIBICONV >>> sc_check-I18N-AUTHORS: >>> @(cd $(srcdir)/src && \ >>> for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'= ); do \ >>> grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.= mk > \ >>> /dev/null || { echo FAIL $$i; exit 1; }; \ >>> done) >> >> Thanks! >> I wanted to include a little more information in the diagnostic, so... ... >> + || { "echo $(ME): link rules for $$i do not include" \ >> + '$$(LIBICONV)' 1>&2; exit 1; }; \ ... > The quoting was a bit off there, so I just pushed this. "off", as in just plain wrong ;) Thanks for cleaning up after me. ... > Author: P=E1draig Brady > Date: Sun Nov 4 00:55:57 2012 +0000 > > maint: fix the error message from sc_check-I18N-AUTHORS > > * cfk.mk (sc_check-I18N-AUTHORS): Fix the quoting so > you don't get a 'command not found' error. > > diff --git a/cfg.mk b/cfg.mk > index 46652b0..53295b4 100644 > --- a/cfg.mk > +++ b/cfg.mk > @@ -187,7 +187,7 @@ sc_check-I18N-AUTHORS: > for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//');= do \ > grep -E "^src_$${i}_LDADD"' .?=3D .*\$$\(LIBICONV\)' local.mk= \ > > /dev/null \ > - || { "echo $(ME): link rules for $$i do not include" \ > + || { echo "$(ME): link rules for $$i do not include" \ > '$$(LIBICONV)' 1>&2; exit 1; }; \ > done